Module: kamailio
Branch: master
Commit: 0cdd264f67b37cff68afb5fbc9ced29b1b0315eb
URL: https://github.com/kamailio/kamailio/commit/0cdd264f67b37cff68afb5fbc9ced29…
Author: Henning Westerholt <hw(a)skalatan.de>
Committer: Henning Westerholt <hw(a)skalatan.de>
Date: 2019-11-15T10:52:01+01:00
github: update CONTRIBUTING guide as decided on the developer meeting
- update CONTRIBUTING guide as decided on the developer meeting
- new introduced functions must be done in native cfg and KEMI
- new introduced module code must be documented in the module docs or wiki
---
Modified: .github/CONTRIBUTING.md
---
Diff: https://github.com/kamailio/kamailio/commit/0cdd264f67b37cff68afb5fbc9ced29…
Patch: https://github.com/kamailio/kamailio/commit/0cdd264f67b37cff68afb5fbc9ced29…
---
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index ea6ba9cdd8..f90d1c492b 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -65,6 +65,12 @@ and commit history, there are several *rules* required for each contribution.
* code **should** be formatted with **clang-format** or to match the style of
the component that the commit applies to. The `.clang-format` file is part of
Kamailio source code tree, in the root folder.
+ * new function exports to the configuration **must** be done both as native
+ configuration export and KEMI function export.
+ * new introduced module parameters, functions and RPC commands **must**
+ be documented in the module documentation.
+ * new introduced pseudo-variables and transformations **must** be
+ documented in the wiki.
### Commit Message Rules ###
I am troubleshooting intermittent latency on a server, several processes
will report slow action at the same time every now and then,
something odd it that some of the actions are most likely not using any
mutexes, I can not imagine how they can end up blocking unless the process
is actually suspended by the OS, however the CPU usage and load average is
quite low on this server.
Is there any reason why assigning to a PKG var could be delayed 3 seconds.
2019-11-13T21:58:04.018631614Z 23(42) WARNING: <core> [core/action.c:1586]:
run_actions(): alert - action [corefunc (16)] cfg
[/etc/kamailio/kamailio.cfg:115] took too long [2579486 us]
$var(reply) = 0; // I wonder how this can endup blocking ?
2019-11-13T21:58:04.018748710Z 42(61) WARNING: <core> [core/action.c:1586]:
run_actions(): alert - action [corefunc (16)] cfg
[/etc/kamailio/kamailio.cfg:221] took too long [2222010 us]
} // Samething here, simply exiting a scope
2019-11-13T21:58:04.015675095Z 11(30) WARNING: <core> [core/action.c:1586]:
run_actions(): alert - action [t_relay_cancel (24)] cfg
[/etc/kamailio/kamailio.cfg:86] took too long [2588818 us]
} if (!t_relay_cancel()) { // Indeed a t_relay_cancel
2019-11-13T21:58:04.018647988Z 26(45) WARNING: <core> [core/action.c:1586]:
run_actions(): alert - action [t_relay (24)] cfg
[/etc/kamailio/kamailio.cfg:289] took too long [2739366 us]
t_relay(); // Indeed a t_relay
2019-11-13T21:58:04.018651243Z 15(34) WARNING: <core> [core/action.c:1586]:
run_actions(): alert - action [sl_send_reply (26)] cfg
[/etc/kamailio/kamailio.cfg:112] took too long [2587812 us]
sl_send_reply("100", "Trying"); // Indeed a sl_send_reply
Not sure which mailing list is best for this question
Regards
Julien