sr-dev February 2019

sr-dev@lists.kamailio.org

23 participants
336 discussions

[kamailio/kamailio] Topos - Via Restore (#1865)

by nicoonline

### Description Topos don't restore the via on the correct position towards the caller.  ### Troubleshooting #### Reproduction SIP/2.0 200 OK. From: "N" <sip:+111111111@proxy1>;tag=as68c113e4. To: <sip:0000000@proxy1>;tag=DHpXgm46a8QgQ. Call-ID: 09e5173225bed77e5cd7247550ee5b60 CSeq: 104 BYE. Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, INFO, UPDATE, REGISTER, REFER, NOTIFY. Supported: path, replaces. Content-Length: 0. Via: SIP/2.0/UDP IP:10060;rport=10060;branch=z9hG4bK7e7ab41c. Contact: <sip:atpsh-5c710f13-962-c@IP>. Should be SIP/2.0 200 OK. Via: SIP/2.0/UDP IP:10060;rport=10060;branch=z9hG4bK7e7ab41c. From: "N" <sip:+111111111@proxy1>;tag=as68c113e4. To: <sip:0000000@proxy1>;tag=DHpXgm46a8QgQ. Call-ID: 09e5173225bed77e5cd7247550ee5b60 CSeq: 104 BYE. Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, INFO, UPDATE, REGISTER, REFER, NOTIFY. Supported: path, replaces. Content-Length: 0. Contact: <sip:atpsh-5c710f13-962-c@IP>. ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.1.7 (x86_64/linux) 567df3 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 567df3 compiled on 07:05:54 Feb 21 2019 with gcc 4.4.7 ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1865

5 years, 9 months

git:master:1500cc5f: modules: readme files regenerated - rtp_media_server ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 1500cc5f03cc37deefc6b3036a4c53da0d945d3b URL: https://github.com/kamailio/kamailio/commit/1500cc5f03cc37deefc6b3036a4c53d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-02-25T05:31:36+01:00 modules: readme files regenerated - rtp_media_server ... [skip ci] --- Modified: src/modules/rtp_media_server/README --- Diff: https://github.com/kamailio/kamailio/commit/1500cc5f03cc37deefc6b3036a4c53d… Patch: https://github.com/kamailio/kamailio/commit/1500cc5f03cc37deefc6b3036a4c53d…

5 years, 9 months

git:master:0fb8b15f: rtp_media_server: configurable event routes

by Julien Chavanton

Module: kamailio Branch: master Commit: 0fb8b15f1269216f4d31998f3d096859e8333be9 URL: https://github.com/kamailio/kamailio/commit/0fb8b15f1269216f4d31998f3d09685… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-02-25T04:28:22Z rtp_media_server: configurable event routes for all action commands and corrected docs --- Modified: src/modules/rtp_media_server/config_example/kamailio.cfg Modified: src/modules/rtp_media_server/doc/rtp_media_server_admin.xml Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/0fb8b15f1269216f4d31998f3d09685… Patch: https://github.com/kamailio/kamailio/commit/0fb8b15f1269216f4d31998f3d09685…

5 years, 9 months

git:5.1:ca71b44d: topoh: improve checks for via header processing

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: ca71b44dd2e85501454b83609ffe6d5a10b99718 URL: https://github.com/kamailio/kamailio/commit/ca71b44dd2e85501454b83609ffe6d5… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-24T21:28:25+01:00 topoh: improve checks for via header processing (cherry picked from commit 78ccdb7ff1ebc34748092fe01ff249f5eeb661c8) --- Modified: src/modules/topoh/th_mask.c Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/ca71b44dd2e85501454b83609ffe6d5… Patch: https://github.com/kamailio/kamailio/commit/ca71b44dd2e85501454b83609ffe6d5… --- diff --git a/src/modules/topoh/th_mask.c b/src/modules/topoh/th_mask.c index 2c0d1aa24f..fce9255f20 100644 --- a/src/modules/topoh/th_mask.c +++ b/src/modules/topoh/th_mask.c @@ -141,6 +141,12 @@ char* th_mask_decode(char *in, int ilen, str *prefix, int extra, int *olen) *olen = (((ilen-((prefix!=NULL&&prefix->len>0)?prefix->len:0)) * 6) >> 3) - n; + + if (*olen<=0) { + LM_ERR("invalid olen parameter calculated, can't continue %d\n", *olen); + return NULL; + } + out = (char*)pkg_malloc((*olen+1+extra)*sizeof(char)); if(out==NULL) diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index 142eda1580..a3b6ab5f29 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -419,7 +419,7 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) else out.s = th_mask_decode(vp->value.s, vp->value.len, &th_vparam_prefix, 0, &out.len); - if(out.s==NULL) + if(out.s==NULL || out.len<=0) { LM_ERR("cannot decode via %d\n", i); return -1; @@ -949,7 +949,12 @@ int th_add_via_cookie(sip_msg_t *msg, struct via_body *via) if (via->params.s) { viap = via->params.s - via->hdr.s - 1; } else { - viap = via->host.s - via->hdr.s + via->host.len; + if (via->host.s) { + viap = via->host.s - via->hdr.s + via->host.len; + } else { + LM_ERR("no via parameter and no via host, can't insert cookie\n"); + return -1; + } if (via->port!=0) viap += via->port_str.len + 1; /* +1 for ':'*/ }

5 years, 9 months

git:5.2:bf4a0f3e: topoh: improve checks for via header processing

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: bf4a0f3ef34b5d52464b86a456b435d865c583f2 URL: https://github.com/kamailio/kamailio/commit/bf4a0f3ef34b5d52464b86a456b435d… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-24T21:28:09+01:00 topoh: improve checks for via header processing (cherry picked from commit 78ccdb7ff1ebc34748092fe01ff249f5eeb661c8) --- Modified: src/modules/topoh/th_mask.c Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/bf4a0f3ef34b5d52464b86a456b435d… Patch: https://github.com/kamailio/kamailio/commit/bf4a0f3ef34b5d52464b86a456b435d… --- diff --git a/src/modules/topoh/th_mask.c b/src/modules/topoh/th_mask.c index 2c0d1aa24f..fce9255f20 100644 --- a/src/modules/topoh/th_mask.c +++ b/src/modules/topoh/th_mask.c @@ -141,6 +141,12 @@ char* th_mask_decode(char *in, int ilen, str *prefix, int extra, int *olen) *olen = (((ilen-((prefix!=NULL&&prefix->len>0)?prefix->len:0)) * 6) >> 3) - n; + + if (*olen<=0) { + LM_ERR("invalid olen parameter calculated, can't continue %d\n", *olen); + return NULL; + } + out = (char*)pkg_malloc((*olen+1+extra)*sizeof(char)); if(out==NULL) diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index 142eda1580..a3b6ab5f29 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -419,7 +419,7 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) else out.s = th_mask_decode(vp->value.s, vp->value.len, &th_vparam_prefix, 0, &out.len); - if(out.s==NULL) + if(out.s==NULL || out.len<=0) { LM_ERR("cannot decode via %d\n", i); return -1; @@ -949,7 +949,12 @@ int th_add_via_cookie(sip_msg_t *msg, struct via_body *via) if (via->params.s) { viap = via->params.s - via->hdr.s - 1; } else { - viap = via->host.s - via->hdr.s + via->host.len; + if (via->host.s) { + viap = via->host.s - via->hdr.s + via->host.len; + } else { + LM_ERR("no via parameter and no via host, can't insert cookie\n"); + return -1; + } if (via->port!=0) viap += via->port_str.len + 1; /* +1 for ':'*/ }

5 years, 9 months

git:master:78ccdb7f: topoh: improve checks for via header processing

by Henning Westerholt

Module: kamailio Branch: master Commit: 78ccdb7ff1ebc34748092fe01ff249f5eeb661c8 URL: https://github.com/kamailio/kamailio/commit/78ccdb7ff1ebc34748092fe01ff249f… Author: Henning Westerholt <hw(a)kamailio.org> Committer: Henning Westerholt <hw(a)kamailio.org> Date: 2019-02-24T21:25:25+01:00 topoh: improve checks for via header processing --- Modified: src/modules/topoh/th_mask.c Modified: src/modules/topoh/th_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/78ccdb7ff1ebc34748092fe01ff249f… Patch: https://github.com/kamailio/kamailio/commit/78ccdb7ff1ebc34748092fe01ff249f… --- diff --git a/src/modules/topoh/th_mask.c b/src/modules/topoh/th_mask.c index 2c0d1aa24f..fce9255f20 100644 --- a/src/modules/topoh/th_mask.c +++ b/src/modules/topoh/th_mask.c @@ -141,6 +141,12 @@ char* th_mask_decode(char *in, int ilen, str *prefix, int extra, int *olen) *olen = (((ilen-((prefix!=NULL&&prefix->len>0)?prefix->len:0)) * 6) >> 3) - n; + + if (*olen<=0) { + LM_ERR("invalid olen parameter calculated, can't continue %d\n", *olen); + return NULL; + } + out = (char*)pkg_malloc((*olen+1+extra)*sizeof(char)); if(out==NULL) diff --git a/src/modules/topoh/th_msg.c b/src/modules/topoh/th_msg.c index 142eda1580..a3b6ab5f29 100644 --- a/src/modules/topoh/th_msg.c +++ b/src/modules/topoh/th_msg.c @@ -419,7 +419,7 @@ int th_unmask_via(sip_msg_t *msg, str *cookie) else out.s = th_mask_decode(vp->value.s, vp->value.len, &th_vparam_prefix, 0, &out.len); - if(out.s==NULL) + if(out.s==NULL || out.len<=0) { LM_ERR("cannot decode via %d\n", i); return -1; @@ -949,7 +949,12 @@ int th_add_via_cookie(sip_msg_t *msg, struct via_body *via) if (via->params.s) { viap = via->params.s - via->hdr.s - 1; } else { - viap = via->host.s - via->hdr.s + via->host.len; + if (via->host.s) { + viap = via->host.s - via->hdr.s + via->host.len; + } else { + LM_ERR("no via parameter and no via host, can't insert cookie\n"); + return -1; + } if (via->port!=0) viap += via->port_str.len + 1; /* +1 for ':'*/ }

5 years, 9 months

Using htable module while developing other modules

by Mojtaba

Hello, According to previous my question about udsing htable module as dependencies module in other modules (Actually i mean hiops module), i want to have some changes in my code. Already i saved some data in cache memory that is implemented via linked_list structure in module, i want to replace them with htable module. So i have to load htable module and some more extra works, all things are straightforward. But when i have more dived into htable module (api.c, ht_api.c files), there is no function to get the value of specific key. there is "ht_api_get_cell_expire_f" function that it just get back the expire time, no value of key. Now I need a function that it return the value of key also, Could i add this function in api.c and ht_api.c source files and commit it or not? If there is already the function like this, let me know about it? Let me know about it? With Regards -- --Mojtaba Esfandiari.S

5 years, 9 months

[kamailio] dialog module with broken defaults (#372)

by zabbal

If I enable dialog module Kamailio will fail to start with following error: ERROR: dialog [dialog.c:498]: mod_init(): no dlg flag set!! In the documentation this parameter is set to 4 as an example: modparam("dialog", "dlg_flag", 4) But no comments made as to why number 4 is used, which numbers are possible to use and most importantly - why such default value is chosen? In any case - module should use default which does not break server's configuration. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/372

5 years, 9 months

git:master:4b7e6089: modules: readme files regenerated - rtp_media_server ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 4b7e6089e32ed71897396b95fed60b2461f14434 URL: https://github.com/kamailio/kamailio/commit/4b7e6089e32ed71897396b95fed60b2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-02-22T18:31:45+01:00 modules: readme files regenerated - rtp_media_server ... [skip ci] --- Modified: src/modules/rtp_media_server/README --- Diff: https://github.com/kamailio/kamailio/commit/4b7e6089e32ed71897396b95fed60b2… Patch: https://github.com/kamailio/kamailio/commit/4b7e6089e32ed71897396b95fed60b2… --- diff --git a/src/modules/rtp_media_server/README b/src/modules/rtp_media_server/README index bc47d7311e..742264f366 100644 --- a/src/modules/rtp_media_server/README +++ b/src/modules/rtp_media_server/README @@ -1,4 +1,3 @@ - rtp_media_server Module Julien Chavanton @@ -38,8 +37,9 @@ Julien Chavanton 4.1. rms_answer () 4.2. rms_hangup () - 4.3. rms_media_stop () - 4.4. rms_play () + 4.3. rms_session_check () + 4.4. rms_sip_request () + 4.5. rms_play () List of Examples @@ -48,6 +48,7 @@ Julien Chavanton 1.3. usage example 1.4. usage example 1.5. usage example + 1.6. usage example Chapter 1. Admin Guide @@ -67,8 +68,9 @@ Chapter 1. Admin Guide 4.1. rms_answer () 4.2. rms_hangup () - 4.3. rms_media_stop () - 4.4. rms_play () + 4.3. rms_session_check () + 4.4. rms_sip_request () + 4.5. rms_play () 1. Overview @@ -111,6 +113,10 @@ Chapter 1. Admin Guide * mediastreamer2 git clone git://git.linphone.org/mediastreamer2.git Mediastreamer2 is a powerful and lightweight streaming engine specialized for voice/video telephony applications. + * bcunit git clone + https://github.com/BelledonneCommunications/bcunit.git + fork of the defunct project CUnit, with several fixes and patches + applied. CUnit is a Unit testing framework for C. 3. Parameters @@ -132,8 +138,9 @@ modparam("rtp_media_server", "log_file_name", "/var/log/rms/rms_ortp.log") 4.1. rms_answer () 4.2. rms_hangup () - 4.3. rms_media_stop () - 4.4. rms_play () + 4.3. rms_session_check () + 4.4. rms_sip_request () + 4.5. rms_play () 4.1. rms_answer () @@ -166,11 +173,7 @@ route { t_reply("503", "server error"); } } - - if (is_method("BYE")){ - xnotice("BYE RECEIVED [$ci]\n"); - rms_media_stop(); - } + rms_sip_request(); ... 4.2. rms_hangup () @@ -184,10 +187,27 @@ route { rms_hangup(); ... -4.3. rms_media_stop () +4.3. rms_session_check () + + Returns true if the current SIP message it handled/known by the RMS + module, else it may be handle in any other way by Kamailio. + + This function can be used from REQUEST_ROUTE, REPLY_ROUTE and + FAILURE_ROUTE. + + Example 1.4. usage example +... + if (rms_session_check()) { + xnotice("This session is handled by the RMS module\n"); + rms_sip_request(); + } +... + +4.4. rms_sip_request () - This should be called on reception of a BYE, this will delete the RTP - session and the media ressources. and reply "200 OK". + This should be called for every in-dialog SIP request, it will be + forwarded behaving as a B2BUA, the transaction will be suspended until + the second leg replies. If the SIP session is not found "481 Call/Transaction Does Not Exist" is returned. @@ -195,14 +215,14 @@ route { This function can be used from REQUEST_ROUTE, REPLY_ROUTE and FAILURE_ROUTE. - Example 1.4. usage example + Example 1.5. usage example ... - if (is_method("BYE")){ - rms_media_stop(); + if (rms_session_check()) { + rms_sip_request(); } ... -4.4. rms_play () +4.5. rms_play () Play a wav file, a resampler is automaticaly configured to resample and convert stereo to mono if needed. @@ -212,7 +232,7 @@ route { This function can be used from EVENT_ROUTE. - Example 1.5. usage example + Example 1.6. usage example ... rms_play("file.wav", "event_route_name"); ...

5 years, 9 months

git:master:1018b363: modules: readme files regenerated - rtp_media_server ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 1018b3631ac629ca79ccade7d36d35af273a3267 URL: https://github.com/kamailio/kamailio/commit/1018b3631ac629ca79ccade7d36d35a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-02-23T00:01:34+01:00 modules: readme files regenerated - rtp_media_server ... [skip ci] --- Modified: src/modules/rtp_media_server/README --- Diff: https://github.com/kamailio/kamailio/commit/1018b3631ac629ca79ccade7d36d35a… Patch: https://github.com/kamailio/kamailio/commit/1018b3631ac629ca79ccade7d36d35a…

5 years, 9 months

← Newer
1
...
13
14
15
16
17
18
19
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019