sr-dev February 2019

sr-dev@lists.kamailio.org

23 participants
336 discussions

git:master:065b1d64: mqueue: added missing license header, removed svn ids
by Daniel-Constantin Mierla 04 Feb '19

04 Feb '19

Module: kamailio Branch: master Commit: 065b1d64453d8b5709069f50cfd705901206feb3 URL: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-04T18:09:47+01:00 mqueue: added missing license header, removed svn ids --- Modified: src/modules/mqueue/api.h Modified: src/modules/mqueue/mqueue_api.c Modified: src/modules/mqueue/mqueue_api.h --- Diff: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… Patch: https://github.com/kamailio/kamailio/commit/065b1d64453d8b5709069f50cfd7059… --- diff --git a/src/modules/mqueue/api.h b/src/modules/mqueue/api.h index 3c67f2fdbd..e00b474c92 100644 --- a/src/modules/mqueue/api.h +++ b/src/modules/mqueue/api.h @@ -1,3 +1,25 @@ +/** + * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) + * + * This file is part of Kamailio, a free SIP server. + * + * This file is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version + * + * This file is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + * + */ + + #ifndef _MQUEUE_EXT_API_H_ #define _MQUEUE_EXT_API_H_ diff --git a/src/modules/mqueue/mqueue_api.c b/src/modules/mqueue/mqueue_api.c index d83c3ce6ce..55833790f8 100644 --- a/src/modules/mqueue/mqueue_api.c +++ b/src/modules/mqueue/mqueue_api.c @@ -1,6 +1,4 @@ /** - * $Id$ - * * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) * * This file is part of Kamailio, a free SIP server. diff --git a/src/modules/mqueue/mqueue_api.h b/src/modules/mqueue/mqueue_api.h index 79996805f7..bc976b6ff7 100644 --- a/src/modules/mqueue/mqueue_api.h +++ b/src/modules/mqueue/mqueue_api.h @@ -1,6 +1,4 @@ /** - * $Id$ - * * Copyright (C) 2010 Elena-Ramona Modroiu (asipto.com) * * This file is part of Kamailio, a free SIP server.

1 0

git:master:25173335: misc/examples: exec.cfg updated for latest releases
by Daniel-Constantin Mierla 04 Feb '19

04 Feb '19

Module: kamailio Branch: master Commit: 25173335dda3142e01243f209d24ba571d61578d URL: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-02-03T07:35:08+01:00 misc/examples: exec.cfg updated for latest releases --- Modified: misc/examples/exec/exec.cfg --- Diff: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… Patch: https://github.com/kamailio/kamailio/commit/25173335dda3142e01243f209d24ba5… --- diff --git a/misc/examples/exec/exec.cfg b/misc/examples/exec/exec.cfg index b0cfe43eaa..30a3a6ed8b 100644 --- a/misc/examples/exec/exec.cfg +++ b/misc/examples/exec/exec.cfg @@ -1,5 +1,4 @@ -# -# $Id$ +#!KAMAILIO # # this example shows use of ser as stateless redirect server # which rewrites URIs using an exernal utility @@ -7,17 +6,18 @@ # ------------------ module loading ---------------------------------- -loadmodule "modules/exec/exec.so" -loadmodule "modules/sl/sl.so" +loadmodule "exec.so" +loadmodule "sl.so" +loadmodule "xlog.so" # ------------------------- request routing logic ------------------- # main routing logic -route{ +request_route { # for testing purposes, simply okay all REGISTERs if (method=="REGISTER") { - log("REGISTER"); + xlog("REGISTER"); sl_send_reply("200", "ok"); break; }; @@ -30,7 +30,7 @@ route{ sl_send_reply("300", "Redirect"); } else { sl_reply_error(); - log(1, "alas, rewriting failed\n"); + xlog("rewriting failed\n"); }; }

1 0

Planning Fosdem 2019
by Daniel-Constantin Mierla 02 Feb '19

02 Feb '19

Hello, Fosdem 2019 is approaching, so I am writing to see if any of you plans to go to the event. If there is interest, we can try to organize again a dinner on Saturday evening, a tradition for our project at the past 10 editions or even more. Henning Westerholt will give a presentation about Kamailio in the RTC Devroom, I will be around as well. I know few more developers that plan to go to the event, so let's see who else from the community wants to join us. As usual, at Fosdem will be developers from other VoIP projects, like Asterisk, Janus, CGRates, Homer, Jitsi, ... At the past editions we typically had two "kamailio" events: 1) an "ad-hoc" developers meeting in the cantina (or other available room around) to discuss about short term plans for Kamailio -- time and place being decided as we meet there between us (expected in the afternoon of Saturday or during Sunday). 2) a dinner at a place nearby, with other VoIP folks joining us Reply if you plan to go to Fosdem and say if you want to join for a dinner. Just be aware that you have to pay for your food and drinks at the dinner, unless we are going to be surprised again by a generous sponsor that covers partially or completely to dinner. If you need more details about Fosdem, the website is: - https://fosdem.org Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - May 6-8, 2019 -- www.kamailioworld.com Kamailio Advanced Training - Mar 4-6, 2019 in Berlin; Mar 25-27, 2019, in Washington, DC, USA -- www.asipto.com

4 6

git:master:18835e0d: Merge pull request #1825 from ycaner06/patch-11
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 18835e0d8bfc55dd63b1a07faa9bde8dfafa8b70 URL: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:59:35+01:00 Merge pull request #1825 from ycaner06/patch-11 ims_isc : fixed P-associated-uri header constructing --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8… Patch: https://github.com/kamailio/kamailio/commit/18835e0d8bfc55dd63b1a07faa9bde8…

1 0

[kamailio/kamailio] ims_isc : fixed P-associated-uri header constructing (#1825)
by Yasin CANER 01 Feb '19

01 Feb '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  fixed P-associated-uri header construncting. it now creates sip and tel uri and appending them to P-header You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1825 -- Commit Summary -- * ims_isc : fixed memory leak * ims_isc : fixed P-associated-uri header constructing -- File Changes -- M src/modules/ims_isc/third_party_reg.c (61) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1825.patch https://github.com/kamailio/kamailio/pull/1825.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1825

2 3

git:master:a704f7d6: ims_isc : fixed wrong type for memcpy
by Yasin CANER 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: a704f7d68dddfaa9719acb7b04f4058a1cdf5673 URL: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-01-30T07:59:32+03:00 ims_isc : fixed wrong type for memcpy fixed wrong type for memcpy --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… Patch: https://github.com/kamailio/kamailio/commit/a704f7d68dddfaa9719acb7b04f4058… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index f5c780feed..b07773efa8 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -173,7 +173,7 @@ int build_p_associated_uri(ims_subscription* s) { if (cnt == 0 && cnttel == 0){ *p++ = '<'; } else if(cnttel != 0 && cnt == 0){ - memcpy(p, ", <", 2); + memcpy(p, ", <", 3); p += 3; } else { memcpy(p, ">, <", 4);

1 0

git:master:91408caf: ims_isc : fixed P-associated-uri header constructing
by Yasin CANER 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 91408cafec655f98a7f5915fbee33be27ec299fa URL: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: Yasin CANER <caner_yaso(a)hotmail.com> Date: 2019-01-30T07:47:17+03:00 ims_isc : fixed P-associated-uri header constructing fixed P-associated-uri header construncting. it now creates sip and tel uri and appending to header. --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be… Patch: https://github.com/kamailio/kamailio/commit/91408cafec655f98a7f5915fbee33be…

1 0

git:master:414bceec: ims_isc : fixed memory leak
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 414bceec25ba7cbfdd5ef607f772e7d2a8335d34 URL: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… Author: Yasin CANER <caner_yaso(a)hotmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-01-30T07:24:05+03:00 ims_isc : fixed memory leak fixed memory leak for third_part_registration body value. --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… Patch: https://github.com/kamailio/kamailio/commit/414bceec25ba7cbfdd5ef607f772e7d… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index b54d4e07d4..62cac53f54 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -403,9 +403,9 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) { } if (r->cv.len) { - STR_APPEND(h, p_charging_vector_s); - STR_APPEND(h, r->cv); - STR_APPEND(h, p_charging_vector_e); + STR_APPEND(h, p_charging_vector_s); + STR_APPEND(h, r->cv); + STR_APPEND(h, p_charging_vector_e); } if (p_associated_uri.data_len > 0) { @@ -436,11 +436,15 @@ int r_send_third_party_reg(r_third_party_registration *r, int expires) { } if (h.s) pkg_free(h.s); + if (b.s) + pkg_free(b.s); return 1; error: if (h.s) pkg_free(h.s); + if (b.s) + pkg_free(b.s); return 0; }

1 0

git:master:4d775faf: Merge pull request #1824 from jchavanton/dns_slow_query
by GitHub 01 Feb '19

01 Feb '19

Module: kamailio Branch: master Commit: 4d775fafa9f2dba6630fc0318616f26f7b72886e URL: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-02-01T19:59:00+01:00 Merge pull request #1824 from jchavanton/dns_slow_query core: dns slow queries reporting --- Modified: src/core/cfg.lex Modified: src/core/cfg.y Modified: src/core/cfg_core.c Modified: src/core/cfg_core.h Modified: src/core/resolve.c Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26… Patch: https://github.com/kamailio/kamailio/commit/4d775fafa9f2dba6630fc0318616f26…

1 0

[kamailio/kamailio] core: dns slow queries reporting (#1824)
by Julien Chavanton 01 Feb '19

01 Feb '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description I remember there was some discussion about adding DNS statistics, I think I remember a discussion involving @ngvoice Carsten ? This is adding a parameter to the core `dns_slow_query_ms` Example: ``` dns_slow_query_ms=100 ``` When using the internal resolver any query taking more than `dns_slow_query_ms` will be lodged as a warning : ``` dns_slow_query_ms=10 (example with 10ms) 5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[35][us-west-wa.sip.flowroute.com]elapsed[12ms] 5(5960) WARNING: <core> [core/resolve.c:752]: get_record(): res_search[1][ep-us-west-wa-01.flowroute.com]elapsed[12ms] ``` and a statistic counter will be incremented : ``` kamcmd stats.fetch dns:slow_dns_request { dns.slow_dns_request: 1 } ``` I think this will be a good start to monitor the impact of slow DNS queries on Kamailio. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1824 -- Commit Summary -- * core: dns slow queries reporting -- File Changes -- M src/core/cfg.lex (3) M src/core/cfg.y (3) M src/core/cfg_core.c (3) M src/core/cfg_core.h (1) M src/core/resolve.c (17) M src/core/resolve.h (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1824.patch https://github.com/kamailio/kamailio/pull/1824.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1824

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2019