sr-dev April 2019

sr-dev@lists.kamailio.org

23 participants
317 discussions

git:master:270af568: modules:sipcapture Fixed wrong pointer for payload buffer.

by Alexandr Dubovikov

Module: kamailio Branch: master Commit: 270af568892cece36cdd4c3eea05e3afc99634fa URL: https://github.com/kamailio/kamailio/commit/270af568892cece36cdd4c3eea05e3a… Author: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Committer: Alexandr Dubovikov <alexandr.dubovikov(a)gmail.com> Date: 2019-04-16T13:28:23+02:00 modules:sipcapture Fixed wrong pointer for payload buffer. --- Modified: src/modules/sipcapture/hep.c Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://github.com/kamailio/kamailio/commit/270af568892cece36cdd4c3eea05e3a… Patch: https://github.com/kamailio/kamailio/commit/270af568892cece36cdd4c3eea05e3a… --- diff --git a/src/modules/sipcapture/hep.c b/src/modules/sipcapture/hep.c index 0430b96969..f435477a09 100644 --- a/src/modules/sipcapture/hep.c +++ b/src/modules/sipcapture/hep.c @@ -739,7 +739,11 @@ int hepv3_message_parse(char *buf, unsigned int len, sip_msg_t *msg) msg->rcv.proto = PROTO_UDP; if(payload != NULL) + { ret = len - payload_len; + msg->buf = payload; + msg->len = payload_len; + } done: diff --git a/src/modules/sipcapture/sipcapture.c b/src/modules/sipcapture/sipcapture.c index dbb53c0537..a7a7564608 100644 --- a/src/modules/sipcapture/sipcapture.c +++ b/src/modules/sipcapture/sipcapture.c @@ -2969,11 +2969,8 @@ static int nosip_hep_msg(sr_event_param_t *evp) return 0; } - buf = msg->buf + len; - len = msg->len - len; - - msg->buf = buf; - msg->len = len; + buf = msg->buf; + len = msg->len; } else { LOG(L_ERR, "ERROR: sipcapture:hep_msg_received: not supported version " "or bad length: v:[%d] l:[%d]\n",

5 years, 5 months

[kamailio/kamailio] siptrace: fix coverity found issue (#1931)

by Ionut Ionita

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix coverity found issue. Unlikely to happen but still it was a bug leading to potential crashes. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1931 -- Commit Summary -- * siptrace: fix coverity found issue -- File Changes -- M src/modules/siptrace/siptrace.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1931.patch https://github.com/kamailio/kamailio/pull/1931.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1931

5 years, 5 months

git:master:c49b50a2: siptrace: safety check for tm callback parameter

by iionita

Module: kamailio Branch: master Commit: c49b50a26aa7f478c135df39b5d91b17b75b88ff URL: https://github.com/kamailio/kamailio/commit/c49b50a26aa7f478c135df39b5d91b1… Author: iionita <ionut-razvan.ionita(a)1and1.ro> Committer: iionita <ionut-razvan.ionita(a)1and1.ro> Date: 2019-04-23T08:25:06+03:00 siptrace: safety check for tm callback parameter Found via coverity scan. --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/c49b50a26aa7f478c135df39b5d91b1… Patch: https://github.com/kamailio/kamailio/commit/c49b50a26aa7f478c135df39b5d91b1… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index c34d25d249..e559d7874a 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1956,6 +1956,12 @@ static void trace_dialog_transaction(struct dlg_cell* dlg, int type, struct dlg_ return; } + /* coverity fix - there shouldn't be a scenario for this to happen */ + if (params == NULL) { + LM_ERR("NULL tm params!\n"); + return; + } + /** * DUAL BYE - internally generated BYE from kamailio * set flag to signal request_in callback which will register

5 years, 5 months

git:master:ff1ce230: Merge pull request #1931 from ionutionita92/master

by GitHub

Module: kamailio Branch: master Commit: ff1ce23083387e15cdd7dde5d5b59e5564d2409c URL: https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-04-23T08:53:28+02:00 Merge pull request #1931 from ionutionita92/master siptrace: safety check for tm callback parameter --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5… Patch: https://github.com/kamailio/kamailio/commit/ff1ce23083387e15cdd7dde5d5b59e5… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index c34d25d249..e559d7874a 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -1956,6 +1956,12 @@ static void trace_dialog_transaction(struct dlg_cell* dlg, int type, struct dlg_ return; } + /* coverity fix - there shouldn't be a scenario for this to happen */ + if (params == NULL) { + LM_ERR("NULL tm params!\n"); + return; + } + /** * DUAL BYE - internally generated BYE from kamailio * set flag to signal request_in callback which will register

5 years, 5 months

git:master:ce1138d2: core: helper function to get scope id for ipv6 network interface

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ce1138d2d8962296de2867d5751abf770b035da3 URL: https://github.com/kamailio/kamailio/commit/ce1138d2d8962296de2867d5751abf7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-04-22T20:20:18+02:00 core: helper function to get scope id for ipv6 network interface --- Modified: src/core/socket_info.c Modified: src/core/socket_info.h --- Diff: https://github.com/kamailio/kamailio/commit/ce1138d2d8962296de2867d5751abf7… Patch: https://github.com/kamailio/kamailio/commit/ce1138d2d8962296de2867d5751abf7… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 1f2850a67b..c77e4b8227 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -42,6 +42,7 @@ #include <sys/ioctl.h> #include <net/if.h> #include <ifaddrs.h> +#include <netdb.h> #ifdef HAVE_SYS_SOCKIO_H #include <sys/sockio.h> #endif @@ -100,6 +101,54 @@ #define addr_info_listins sock_listins #define addr_info_listrm sock_listrm +/** + * return the scope for IPv6 interface matching the ipval parameter + * - needed for binding to link local IPv6 addresses + */ +unsigned int ipv6_get_netif_scope(const char *ipval) +{ + struct ifaddrs *netiflist = NULL; + struct ifaddrs *netif = NULL; + char ipaddr[NI_MAXHOST]; + unsigned int iscope = 0; + int i = 0; + int r = 0; + + /* walk over the list of all network interface addresses */ + if(getifaddrs(&netiflist)!=0) { + LM_ERR("failed to get network interfaces - errno: %d\n", errno); + return 0; + } + for(netif = netiflist; netif; netif = netif->ifa_next) { + /* only active and ipv6 */ + if (netif->ifa_addr && (netif->ifa_flags & IFF_UP) + && netif->ifa_addr->sa_family==AF_INET6) { + r = getnameinfo(netif->ifa_addr, sizeof(struct sockaddr_in6), + ipaddr, sizeof(ipaddr), NULL, 0, NI_NUMERICHOST); + if(r!=0) { + LM_ERR("failed to get the name info - ret: %d\n", r); + goto done; + } + /* strip the interface name after */ + for(i=0; ipaddr[i]; i++) { + if(ipaddr[i]=='%') { + ipaddr[i]='\0'; + break; + } + } + /* if the ips matche, get scope index from interface name */ + if(strcmp(ipaddr, ipval)==0){ + iscope=if_nametoindex(netif->ifa_name); + goto done; + } + } + } + +done: + freeifaddrs(netiflist); + return iscope; +} + inline static void addr_info_list_ins_lst(struct addr_info* lst, struct addr_info* after) { diff --git a/src/core/socket_info.h b/src/core/socket_info.h index abc6a150aa..e8c684407c 100644 --- a/src/core/socket_info.h +++ b/src/core/socket_info.h @@ -151,4 +151,6 @@ typedef struct _sr_phostp { struct socket_info* lookup_local_socket(str *phostp); int parse_protohostport(str* ins, sr_phostp_t *r); +unsigned int ipv6_get_netif_scope(const char *ipval); + #endif

5 years, 5 months

git:master:88997dc3: CONTRIBUTING.md: restructured the chapter about commit message rules

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 88997dc3cce73c939c5da00b73405773c32fefd7 URL: https://github.com/kamailio/kamailio/commit/88997dc3cce73c939c5da00b7340577… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-04-22T18:50:46+02:00 CONTRIBUTING.md: restructured the chapter about commit message rules - relocated content from basic rules to a dedicated section about commit message content - notes that references to non-public resources should not be part of commit messages - commits related to code analyzer reports have to describe what was changed, not be just a referenced to the report --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/88997dc3cce73c939c5da00b7340577… Patch: https://github.com/kamailio/kamailio/commit/88997dc3cce73c939c5da00b7340577…

5 years, 5 months

git:master:ccb8ba34: modules: readme files regenerated - rtp_media_server ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: ccb8ba34736556a628497dcc6ac8b525cf201453 URL: https://github.com/kamailio/kamailio/commit/ccb8ba34736556a628497dcc6ac8b52… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-04-21T22:46:39+02:00 modules: readme files regenerated - rtp_media_server ... [skip ci] --- Modified: src/modules/rtp_media_server/README --- Diff: https://github.com/kamailio/kamailio/commit/ccb8ba34736556a628497dcc6ac8b52… Patch: https://github.com/kamailio/kamailio/commit/ccb8ba34736556a628497dcc6ac8b52… --- diff --git a/src/modules/rtp_media_server/README b/src/modules/rtp_media_server/README index 3ed260c03e..5d4a74cbd2 100644 --- a/src/modules/rtp_media_server/README +++ b/src/modules/rtp_media_server/README @@ -38,7 +38,7 @@ Julien Chavanton 4.1. rms_answer (event_route) 4.2. rms_hangup () 4.3. rms_bridge (target URI, event_route) - 4.4. rms_session_check () + 4.4. rms_dialog_check () 4.5. rms_sip_request () 4.6. rms_play (file, event_route) @@ -48,7 +48,7 @@ Julien Chavanton 1.2. rms_answer usage example 1.3. rms_hangup usage example 1.4. rms_bridge usage example - 1.5. rms_session_check usage example + 1.5. rms_dialog_check usage example 1.6. rms_sip_request usage example 1.7. rms_play usage example @@ -71,7 +71,7 @@ Chapter 1. Admin Guide 4.1. rms_answer (event_route) 4.2. rms_hangup () 4.3. rms_bridge (target URI, event_route) - 4.4. rms_session_check () + 4.4. rms_dialog_check () 4.5. rms_sip_request () 4.6. rms_play (file, event_route) @@ -142,13 +142,14 @@ modparam("rtp_media_server", "log_file_name", "/var/log/rms/rms_ortp.log") 4.1. rms_answer (event_route) 4.2. rms_hangup () 4.3. rms_bridge (target URI, event_route) - 4.4. rms_session_check () + 4.4. rms_dialog_check () 4.5. rms_sip_request () 4.6. rms_play (file, event_route) 4.1. rms_answer (event_route) - Create a session and a call leg and call the event_route + Create a call leg : with a SIP dialog and an RTP session call the + event_route This function can be used from REQUEST_ROUTE, REPLY_ROUTE and FAILURE_ROUTE. @@ -217,12 +218,12 @@ route { t_reply("503", "server error"); } } - if(rms_session_check()) // If the dialog is managed by the RMS module, t -he in-dialog request needs to be handled by it. + if(rms_dialog_check()) // If the dialog is managed by the RMS module, th +e in-dialog request needs to be handled by it. rms_sip_request(); ... -4.4. rms_session_check () +4.4. rms_dialog_check () Returns true if the current SIP message it handled/known by the RMS module, else it may be handle in any other way by Kamailio. @@ -230,10 +231,10 @@ he in-dialog request needs to be handled by it. This function can be used from REQUEST_ROUTE, REPLY_ROUTE and FAILURE_ROUTE. - Example 1.5. rms_session_check usage example + Example 1.5. rms_dialog_check usage example ... - if (rms_session_check()) { - xnotice("This session is handled by the RMS module\n"); + if (rms_dialog_check()) { + xnotice("This dialog is handled by the RMS module\n"); rms_sip_request(); } ... @@ -244,15 +245,15 @@ he in-dialog request needs to be handled by it. forwarded behaving as a B2BUA, the transaction will be suspended until the second leg replies. - If the SIP session is not found "481 Call/Transaction Does Not Exist" - is returned. + If the SIP dialog is not found "481 Call/Transaction Does Not Exist" is + returned. This function can be used from REQUEST_ROUTE, REPLY_ROUTE and FAILURE_ROUTE. Example 1.6. rms_sip_request usage example ... - if (rms_session_check()) { + if (rms_dialog_check()) { rms_sip_request(); } ...

5 years, 5 months

git:master:3bfbea5f: rtp_media_server: rename rms sessions to rms dialogs

by Julien Chavanton

Module: kamailio Branch: master Commit: 3bfbea5fc0737aebe29559267cc21e3a10ab0cb4 URL: https://github.com/kamailio/kamailio/commit/3bfbea5fc0737aebe29559267cc21e3… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-04-21T20:30:15Z rtp_media_server: rename rms sessions to rms dialogs This was creating confusion, the term session is reserved for the RTP sessions --- Added: src/modules/rtp_media_server/rms_dialog_info.c Added: src/modules/rtp_media_server/rms_dialog_info.h Modified: src/modules/rtp_media_server/config_example/kamailio.cfg Modified: src/modules/rtp_media_server/doc/design_notes.txt Modified: src/modules/rtp_media_server/doc/rtp_media_server_admin.xml Modified: src/modules/rtp_media_server/rms_media.c Modified: src/modules/rtp_media_server/rms_media.h Modified: src/modules/rtp_media_server/rtp_media_server.c Modified: src/modules/rtp_media_server/rtp_media_server.h Removed: src/modules/rtp_media_server/rms_session_info.c Removed: src/modules/rtp_media_server/rms_session_info.h --- Diff: https://github.com/kamailio/kamailio/commit/3bfbea5fc0737aebe29559267cc21e3… Patch: https://github.com/kamailio/kamailio/commit/3bfbea5fc0737aebe29559267cc21e3…

5 years, 5 months

git:master:f4056ebf: rtp_media_server: bridging refactoring

by Julien Chavanton

Module: kamailio Branch: master Commit: f4056ebf61952b9e2140031ee0bb63e7340d5709 URL: https://github.com/kamailio/kamailio/commit/f4056ebf61952b9e2140031ee0bb63e… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-04-21T20:29:30Z rtp_media_server: bridging refactoring support bridging after answer, play, etc. --- Modified: src/modules/rtp_media_server/rms_media.c Modified: src/modules/rtp_media_server/rms_sdp.c Modified: src/modules/rtp_media_server/rms_session_info.c Modified: src/modules/rtp_media_server/rms_session_info.h Modified: src/modules/rtp_media_server/rtp_media_server.c Modified: src/modules/rtp_media_server/rtp_media_server.h --- Diff: https://github.com/kamailio/kamailio/commit/f4056ebf61952b9e2140031ee0bb63e… Patch: https://github.com/kamailio/kamailio/commit/f4056ebf61952b9e2140031ee0bb63e…

5 years, 5 months

git:master:bd828828: More string buffer handling improvements in imc module

by Jan Janak

Module: kamailio Branch: master Commit: bd82882807ad89c7564709db414ddbe26bd70728 URL: https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe… Author: Jan Janak <janakj(a)cs.columbia.edu> Committer: Jan Janak <janakj(a)cs.columbia.edu> Date: 2019-04-20T12:18:52-04:00 More string buffer handling improvements in imc module Let the compiler do the work of figuring out the size of the string buffer being written to using the sizeof operator. Hopefully, this will make the source code less error-prone and more Coverity friendly. Properly handle all return values of snprintf. In particular, do not fail silently if the function returns -1. --- Modified: src/modules/imc/imc_cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe… Patch: https://github.com/kamailio/kamailio/commit/bd82882807ad89c7564709db414ddbe…

5 years, 6 months

← Newer
1
...
9
10
11
12
13
14
15
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2019