sr-dev May 2019

sr-dev@lists.kamailio.org

29 participants
307 discussions

git:master:796a12d6: siptrace: use xavps to pass data for the duration of transaction/dialog
by Henning Westerholt 28 May '19

28 May '19

Module: kamailio Branch: master Commit: 796a12d6ef27c01e9c5a9ad36b82833b03b62109 URL: https://github.com/kamailio/kamailio/commit/796a12d6ef27c01e9c5a9ad36b82833… Author: iionita <ionut-razvan.ionita(a)1and1.ro> Committer: Henning Westerholt <henningw(a)users.noreply.github.com> Date: 2019-05-28T21:56:25+02:00 siptrace: use xavps to pass data for the duration of transaction/dialog Before this data was serialized in order to fit a normal AVP and be passed to DLGCB_CREATED callback. Moreover for transaction tracing data was allocated in current process memory which would have crashed if the reply were to be recieved in a different process. With the current implementation data is allocated in shared memory, all processes having access to it. For dialogs data is passed through xavp to dlgcb created. From there all dialog callbacks are registered and they receive argument the pointer to siptrace info. For transactions the pointer is passed as dialog callback parameter. --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/796a12d6ef27c01e9c5a9ad36b82833… Patch: https://github.com/kamailio/kamailio/commit/796a12d6ef27c01e9c5a9ad36b82833…

1 0

[kamailio/kamailio] [Low Priority] Build warning with gcc-9.1.1 (#1965)
by Anthony Messina 28 May '19

28 May '19

Building on Fedora 30 x86_64, the following warning appears: ` BUILDSTDERR: Makefile.defs:1014: You are using an old and unsupported gcc version (9.1.1), compile at your own risk!` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1965

3 5

Re: [sr-dev] [kamailio/kamailio] Makefile.defs: detect gcc 9.0+ (07209c3)
by sergey-safarov 28 May '19

28 May '19

think i many places missed "," -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/07209c3095d8c3ab47108af94c004ce…

1 0

git:master:07209c30: Makefile.defs: detect gcc 9.0+
by Daniel-Constantin Mierla 28 May '19

28 May '19

Module: kamailio Branch: master Commit: 07209c3095d8c3ab47108af94c004ce963012a92 URL: https://github.com/kamailio/kamailio/commit/07209c3095d8c3ab47108af94c004ce… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-05-28T14:27:34+02:00 Makefile.defs: detect gcc 9.0+ - reported by GH #1965 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/07209c3095d8c3ab47108af94c004ce… Patch: https://github.com/kamailio/kamailio/commit/07209c3095d8c3ab47108af94c004ce…

1 0

git:master:78d73877: kemix: functions to return directly user and host from ruri
by Daniel-Constantin Mierla 28 May '19

28 May '19

Module: kamailio Branch: master Commit: 78d73877e1f08ac5ab542fce832653f78a05de93 URL: https://github.com/kamailio/kamailio/commit/78d73877e1f08ac5ab542fce832653f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-05-28T14:06:19+02:00 kemix: functions to return directly user and host from ruri --- Modified: src/modules/kemix/kemix_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/78d73877e1f08ac5ab542fce832653f… Patch: https://github.com/kamailio/kamailio/commit/78d73877e1f08ac5ab542fce832653f… --- diff --git a/src/modules/kemix/kemix_mod.c b/src/modules/kemix/kemix_mod.c index 7ed5fe9c98..5c61703b31 100644 --- a/src/modules/kemix/kemix_mod.c +++ b/src/modules/kemix/kemix_mod.c @@ -174,6 +174,88 @@ static sr_kemi_xval_t* ki_kx_get_turi(sip_msg_t *msg) return &_sr_kemi_kx_xval; } +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_xuri_attr(sip_msg_t *msg, sip_uri_t *puri, + int iattr, int xmode) +{ + if(iattr==1) { + /* username */ + if(puri->user.s==NULL || puri->user.len<=0) { + sr_kemi_xval_null(&_sr_kemi_kx_xval, xmode); + return &_sr_kemi_kx_xval; + } + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + _sr_kemi_kx_xval.v.s = puri->user; + return &_sr_kemi_kx_xval; + } else if(iattr==2) { + /* domain */ + if(puri->host.s==NULL || puri->host.len<=0) { + sr_kemi_xval_null(&_sr_kemi_kx_xval, xmode); + return &_sr_kemi_kx_xval; + } + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + _sr_kemi_kx_xval.v.s = puri->host; + return &_sr_kemi_kx_xval; + } + LM_ERR("unknown attribute id: %d\n", iattr); + sr_kemi_xval_null(&_sr_kemi_kx_xval, xmode); + return &_sr_kemi_kx_xval; +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_ruri_attr(sip_msg_t *msg, int iattr, int xmode) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + + if(msg==NULL || msg->first_line.type == SIP_REPLY) { + sr_kemi_xval_null(&_sr_kemi_kx_xval, xmode); + return &_sr_kemi_kx_xval; + } + + if(msg->parsed_uri_ok==0 /* R-URI not parsed*/ && parse_sip_msg_uri(msg)<0) { + LM_ERR("failed to parse the R-URI\n"); + sr_kemi_xval_null(&_sr_kemi_kx_xval, xmode); + return &_sr_kemi_kx_xval; + } + return ki_kx_get_xuri_attr(msg, &(msg->parsed_uri), iattr, xmode); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_ruser(sip_msg_t *msg) +{ + return ki_kx_get_ruri_attr(msg, 1, SR_KEMI_XVAL_NULL_NONE); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_ruserx(sip_msg_t *msg, int xmode) +{ + return ki_kx_get_ruri_attr(msg, 1, xmode); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rhost(sip_msg_t *msg) +{ + return ki_kx_get_ruri_attr(msg, 2, SR_KEMI_XVAL_NULL_NONE); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rhostx(sip_msg_t *msg, int xmode) +{ + return ki_kx_get_ruri_attr(msg, 2, xmode); +} + /** * */ @@ -199,6 +281,27 @@ static sr_kemi_t sr_kemi_kx_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("kx"), str_init("get_ruser"), + SR_KEMIP_XVAL, ki_kx_get_ruser, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_ruserx"), + SR_KEMIP_XVAL, ki_kx_get_ruserx, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_rhost"), + SR_KEMIP_XVAL, ki_kx_get_rhost, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_rhostx"), + SR_KEMIP_XVAL, ki_kx_get_rhostx, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:e91d9562: core: kemi - defines for modes used to return null string
by Daniel-Constantin Mierla 28 May '19

28 May '19

Module: kamailio Branch: master Commit: e91d9562689dc879540d8b04a337dcd016de4a21 URL: https://github.com/kamailio/kamailio/commit/e91d9562689dc879540d8b04a337dcd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-05-28T14:06:19+02:00 core: kemi - defines for modes used to return null string --- Modified: src/core/kemi.c Modified: src/core/kemi.h --- Diff: https://github.com/kamailio/kamailio/commit/e91d9562689dc879540d8b04a337dcd… Patch: https://github.com/kamailio/kamailio/commit/e91d9562689dc879540d8b04a337dcd… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index 037532f96b..e4403af9d0 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -2018,10 +2018,10 @@ static sr_kemi_t _sr_kemi_hdr[] = { */ void sr_kemi_xval_null(sr_kemi_xval_t *xval, int rmode) { - if(rmode==1) { + if(rmode==SR_KEMI_XVAL_NULL_PRINT) { xval->vtype = SR_KEMIP_STR; xval->v.s = *pv_get_null_str(); - } else if(rmode==2) { + } else if(rmode==SR_KEMI_XVAL_NULL_EMPTY) { xval->vtype = SR_KEMIP_STR; xval->v.s = *pv_get_empty_str(); } else { @@ -2086,7 +2086,7 @@ static sr_kemi_xval_t* sr_kemi_pv_get_mode(sip_msg_t *msg, str *pvn, int rmode) */ static sr_kemi_xval_t* sr_kemi_pv_get(sip_msg_t *msg, str *pvn) { - return sr_kemi_pv_get_mode(msg, pvn, 0); + return sr_kemi_pv_get_mode(msg, pvn, SR_KEMI_XVAL_NULL_NONE); } /** @@ -2094,7 +2094,7 @@ static sr_kemi_xval_t* sr_kemi_pv_get(sip_msg_t *msg, str *pvn) */ static sr_kemi_xval_t* sr_kemi_pv_getw(sip_msg_t *msg, str *pvn) { - return sr_kemi_pv_get_mode(msg, pvn, 1); + return sr_kemi_pv_get_mode(msg, pvn, SR_KEMI_XVAL_NULL_PRINT); } /** @@ -2102,7 +2102,7 @@ static sr_kemi_xval_t* sr_kemi_pv_getw(sip_msg_t *msg, str *pvn) */ static sr_kemi_xval_t* sr_kemi_pv_gete(sip_msg_t *msg, str *pvn) { - return sr_kemi_pv_get_mode(msg, pvn, 2); + return sr_kemi_pv_get_mode(msg, pvn, SR_KEMI_XVAL_NULL_EMPTY); } /** diff --git a/src/core/kemi.h b/src/core/kemi.h index ef9451b2d5..7824ce2f60 100644 --- a/src/core/kemi.h +++ b/src/core/kemi.h @@ -204,6 +204,9 @@ int sr_kemi_ctx_route(sr_kemi_eng_t *keng, run_act_ctx_t *ctx, sip_msg_t *msg, sr_kemi_t* sr_kemi_exports_get_pv(void); +#define SR_KEMI_XVAL_NULL_NONE 0 +#define SR_KEMI_XVAL_NULL_PRINT 1 +#define SR_KEMI_XVAL_NULL_EMPTY 2 void sr_kemi_xval_null(sr_kemi_xval_t *xval, int rmode); #endif

1 0

[kamailio/kamailio] ims_registrar_pcscf: parse security verify header (#1964)
by alexyosifov 28 May '19

28 May '19

- Parse 'security verify' header from REGISTER request message and save updated parameters into the database. - Added debug messages in save_pendign and save for easy debugging.   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1964 -- Commit Summary -- * ims_registrar_pcscf: parse security verify header -- File Changes -- M src/modules/ims_registrar_pcscf/save.c (24) M src/modules/ims_registrar_pcscf/sec_agree.c (66) M src/modules/ims_registrar_pcscf/sec_agree.h (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1964.patch https://github.com/kamailio/kamailio/pull/1964.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1964

3 3

git:master:6c902f52: Merge pull request #1964 from alexyosifov/registrar_pcscf_sec_agree
by GitHub 28 May '19

28 May '19

Module: kamailio Branch: master Commit: 6c902f526698904129cc5369c74d83312b435ff7 URL: https://github.com/kamailio/kamailio/commit/6c902f526698904129cc5369c74d833… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-05-28T13:27:24+02:00 Merge pull request #1964 from alexyosifov/registrar_pcscf_sec_agree ims_registrar_pcscf: parse security verify header --- Modified: src/modules/ims_registrar_pcscf/save.c Modified: src/modules/ims_registrar_pcscf/sec_agree.c Modified: src/modules/ims_registrar_pcscf/sec_agree.h --- Diff: https://github.com/kamailio/kamailio/commit/6c902f526698904129cc5369c74d833… Patch: https://github.com/kamailio/kamailio/commit/6c902f526698904129cc5369c74d833…

1 0

git:master:6845772a: ims_registrar_pcscf: parse security verify header
by Aleksandar Yosifov 28 May '19

28 May '19

Module: kamailio Branch: master Commit: 6845772a5345d60d48b702b624f673d979451004 URL: https://github.com/kamailio/kamailio/commit/6845772a5345d60d48b702b624f673d… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Committer: Aleksandar Yosifov <alexyosifov(a)gmail.com> Date: 2019-05-23T11:34:12+03:00 ims_registrar_pcscf: parse security verify header - Parse 'security verify' header from REGISTER request message and save updated parameters into the database. - Added debug messages in save_pendign and save for easy debugging. --- Modified: src/modules/ims_registrar_pcscf/save.c Modified: src/modules/ims_registrar_pcscf/sec_agree.c Modified: src/modules/ims_registrar_pcscf/sec_agree.h --- Diff: https://github.com/kamailio/kamailio/commit/6845772a5345d60d48b702b624f673d… Patch: https://github.com/kamailio/kamailio/commit/6845772a5345d60d48b702b624f673d…

1 0

[kamailio/kamailio] kamdbctl: Fixes name of ims_charging sql script. (#1967)
by Ali Shirvani 28 May '19

28 May '19

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1967 -- Commit Summary -- * Fixes name of ims_charging sql script. -- File Changes -- R utils/kamctl/mysql/ims_charging-create.sql (0) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1967.patch https://github.com/kamailio/kamailio/pull/1967.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1967

2 4

← Newer
1
...
8
9
10
11
12
13
14
...
31
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2019