sr-dev June 2019

sr-dev@lists.kamailio.org

19 participants
216 discussions

git:5.2:4a458861: registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event

by Victor Seva

Module: kamailio Branch: 5.2 Commit: 4a458861b4377f53218a6c836f18adca6b17a9ff URL: https://github.com/kamailio/kamailio/commit/4a458861b4377f53218a6c836f18adc… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-06-27T08:57:54+02:00 registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event (cherry picked from commit c671e78142b51515d64392fd9a9db8f07e904167) --- Modified: src/modules/registrar/regpv.c --- Diff: https://github.com/kamailio/kamailio/commit/4a458861b4377f53218a6c836f18adc… Patch: https://github.com/kamailio/kamailio/commit/4a458861b4377f53218a6c836f18adc… --- diff --git a/src/modules/registrar/regpv.c b/src/modules/registrar/regpv.c index d04f129d47..dbf48ae47d 100644 --- a/src/modules/registrar/regpv.c +++ b/src/modules/registrar/regpv.c @@ -35,6 +35,7 @@ #include "../../core/action.h" #include "../../core/fmsg.h" #include "../../core/kemi.h" +#include "../../core/receive.h" #include "../usrloc/usrloc.h" #include "registrar.h" #include "common.h" @@ -751,7 +752,7 @@ void reg_ul_expired_contact(ucontact_t* ptr, int type, void* param) } } set_route_type(backup_rt); - + ksr_msg_env_reset(); return; error: regpv_free_profile(rpp);

5 years, 4 months

[kamailio/kamailio] registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event (#1994)

by Victor Seva

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally #### Description I was creating avp variables at route_event[usrloc:contact-expired] and shared memory was always growing I think this is the same issue #1391 and solved by ad46b115bedec01c52c5a9dcde0756db85ee61ec You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1994 -- Commit Summary -- * registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event -- File Changes -- M src/modules/registrar/regpv.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1994.patch https://github.com/kamailio/kamailio/pull/1994.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1994

5 years, 4 months

git:master:c671e781: registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event

by Victor Seva

Module: kamailio Branch: master Commit: c671e78142b51515d64392fd9a9db8f07e904167 URL: https://github.com/kamailio/kamailio/commit/c671e78142b51515d64392fd9a9db8f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2019-06-27T08:56:47+02:00 registrar: clean avp/xavp created at 'usrloc:contact-expired' route_event --- Modified: src/modules/registrar/regpv.c --- Diff: https://github.com/kamailio/kamailio/commit/c671e78142b51515d64392fd9a9db8f… Patch: https://github.com/kamailio/kamailio/commit/c671e78142b51515d64392fd9a9db8f… --- diff --git a/src/modules/registrar/regpv.c b/src/modules/registrar/regpv.c index d04f129d47..dbf48ae47d 100644 --- a/src/modules/registrar/regpv.c +++ b/src/modules/registrar/regpv.c @@ -35,6 +35,7 @@ #include "../../core/action.h" #include "../../core/fmsg.h" #include "../../core/kemi.h" +#include "../../core/receive.h" #include "../usrloc/usrloc.h" #include "registrar.h" #include "common.h" @@ -751,7 +752,7 @@ void reg_ul_expired_contact(ucontact_t* ptr, int type, void* param) } } set_route_type(backup_rt); - + ksr_msg_env_reset(); return; error: regpv_free_profile(rpp);

5 years, 4 months

[kamailio/kamailio] Crash in pdb module (#1985)

by Daniel-Constantin Mierla

### Description Investigating a report on a Kamailio crash, it led to pdb module, with the following backtrace: ``` #0 0x0000000000000000 in ?? () #1 0x00007f870472fa33 in vfprintf () from /lib64/libc.so.6 #2 0x00007f87047562bb in vsprintf () from /lib64/libc.so.6 #3 0x00007f8704738457 in sprintf () from /lib64/libc.so.6 #4 0x00007f86f881c6f9 in pdb_msg_dbg (msg=..., dbg_msg=0x7f86f8828313 "Kamailio pdb client receives:") at pdb.c:152 #5 0x00007f86f88204e4 in pdb_query (_msg=0x7f8700fae068, _number=0x7f8700fa2e88, _dstavp=0x7f8700fa2f10) at pdb.c:335 #6 0x000000000047b72c in do_action (h=0x7ffeb03d10e0, a=0x7f8700abf678, msg=0x7f8700fae068) at core/action.c:1079 #7 0x0000000000487e70 in run_actions (h=0x7ffeb03d10e0, a=0x7f8700abf678, msg=0x7f8700fae068) at core/action.c:1569 #8 0x0000000000488531 in run_actions_safe (h=0x7ffeb03d3180, a=0x7f8700abf678, msg=0x7f8700fae068) at core/action.c:1633 #9 0x0000000000447f40 in rval_get_int (h=0x7ffeb03d3180, msg=0x7f8700fae068, i=0x7ffeb03d18b0, rv=0x7f8700ac0148, cache=0x0) at core/rvalue.c:912 #10 0x000000000044c4f0 in rval_expr_eval_int (h=0x7ffeb03d3180, msg=0x7f8700fae068, res=0x7ffeb03d18b0, rve=0x7f8700ac0140) at core/rvalue.c:1910 ``` Looking at the data in frame 4, it looks that an empty (0-ed) pdb structure is printed: ``` (gdb) frame 4 #4 0x00007f86f881c6f9 in pdb_msg_dbg (msg=..., dbg_msg=0x7f86f8828313 "Kamailio pdb client receives:") at pdb.c:152 152 ptr += sprintf(ptr,"%02X ", msg.bdy.payload[i]); (gdb) p i $1 = 263 (gdb) p msg $2 = {hdr = {version = 0 '\000', type = 0 '\000', code = 0 '\000', length = 0 '\000', id = 0}, bdy = {payload = '\000' <repeats 248 times>}} (gdb) p msg.hdr.length $3 = 0 '\000' ``` I just pushed commit 3c07e2351a94e4ff2cf3c6b9b9df4d7462cd5760 for a safety check, but not being the developer of the module, I am not sure it is supposed to deal with a 0-ed pdb structure, or the issue is somewhere else, leading to this 0-only structure content. Therefore I am opening this one for further analyze, if the commit above is enough, just close the issue. ### Troubleshooting #### Reproduction Try to send traffic to a config using pdb matching PDB_VERSION_1. #### Debugging Data ``` gdb backtrace above ``` #### Log Messages ``` N/A ``` #### SIP Traffic ``` N/A ``` ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 compiled on 10:34:54 Jun 13 2019 with gcc 4.8.5 ``` * **Operating System**: ``` CentOS 7 with Kamailio installed from RPM (using opensuse build service repo) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1985

5 years, 4 months

[kamailio/kamailio] Memory leak in sanity module 'proxy require' check (#1990)

by Tijs Zwinkels - TinkerTank

### Description We noticed one of our kamailio instances using increasing amounts of pkg memory. This appears to be related to the sanity-check module. sanity.c:655 - `if (msg->proxy_require->parsed == NULL)` then that header is parsed into `msg->proxy_require->parsed`. This buffer should be free'd in sanity.c:712, but this only happens if the sanity check is succesfull. If the sanity check fails (on line 701), then the buffer is never free'd. ### Troubleshooting #### Reproduction We can reproduce the issue by repeatedly sending the following SIP packet to kamailio. Please note that this 'Proxy-Require' header is invalid in our setup, and is most likely originally caused by an invalid configured phone. ``` SUBSCRIBE sip:phone_0@example.com:5060 SIP/2.0 Via: SIP/2.0/UDP 192.168.1.102:5062;branch=z9hG4bK2104306013 From: "xxx" <sip:phone_0@example.com>;tag=108111795 To: "xxx" <sip:phone_0@example.com> Call-ID: 3276145660(a)192.168.1.102 CSeq: 1 SUBSCRIBE Contact: <sip:phone_0@192.168.1.102:5062> Accept: application/x-as-feature-event+xml Max-Forwards: 70 User-Agent: Yealink SIP-T48G 35.72.188.7 Proxy-Require: sip.example.com Expires: 3630 Event: as-feature-event Content-Length: 0 ``` ### Possible Solutions The code to free the buffer could be duplicated before the return on sanity.c:701. However, it's not clear to me why the `msg->proxy_require->parsed` structure doesn't get properly free'd when msg is free'd, as most other fields in this struct seem to be destructed correctly. For now, we disabled the proxy require check with: ``` modparam("sanity", "default_checks", 2535) ``` this mitigates the memory leak. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 5.3.1 ``` Problem still present in current master. * **Operating System**:  Ubuntu 16.04 ``` Linux tijscmp01 4.4.0-145-generic #171-Ubuntu SMP Tue Mar 26 12:43:40 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1990

5 years, 5 months

git:master:ffa2aa43: sanity: free parsed proxy-required header in case of failure

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ffa2aa438e2a13e6e8bdbe70dd90827ae18279ce URL: https://github.com/kamailio/kamailio/commit/ffa2aa438e2a13e6e8bdbe70dd90827… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-06-25T23:04:00+02:00 sanity: free parsed proxy-required header in case of failure - reported by GH #1990 --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/ffa2aa438e2a13e6e8bdbe70dd90827… Patch: https://github.com/kamailio/kamailio/commit/ffa2aa438e2a13e6e8bdbe70dd90827… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index d00eab5d6d..04ad2b86d6 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -698,6 +698,10 @@ int check_proxy_require(sip_msg_t* msg) { } LM_DBG("checking proxy require failed\n"); if (u) pkg_free(u); + if (msg->proxy_require->parsed) { + free_str_list(msg->proxy_require->parsed); + msg->proxy_require->parsed = NULL; + } return SANITY_CHECK_FAILED; } else {

5 years, 5 months

git:master:3c84c44f: crypto: fix two small copy and paste errors in comments

by Henning Westerholt

Module: kamailio Branch: master Commit: 3c84c44ff2191f71dbb2af8beb211b75e48f9b1d URL: https://github.com/kamailio/kamailio/commit/3c84c44ff2191f71dbb2af8beb211b7… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-06-25T22:32:30+02:00 crypto: fix two small copy and paste errors in comments --- Modified: src/modules/crypto/api.h --- Diff: https://github.com/kamailio/kamailio/commit/3c84c44ff2191f71dbb2af8beb211b7… Patch: https://github.com/kamailio/kamailio/commit/3c84c44ff2191f71dbb2af8beb211b7… --- diff --git a/src/modules/crypto/api.h b/src/modules/crypto/api.h index a3823d443c..fa87923304 100644 --- a/src/modules/crypto/api.h +++ b/src/modules/crypto/api.h @@ -49,12 +49,12 @@ inline static int load_crypto_api( struct crypto_binds *cb ) { load_crypto_f load_crypto_v; - /* import the RR auto-loading function */ + /* import the crypto auto-loading function */ if ( !(load_crypto_v=(load_crypto_f)find_export("load_crypto", 0, 0))) { LM_ERR("failed to import load_crypto\n"); return -1; } - /* let the auto-loading function load all RR stuff */ + /* let the auto-loading function load all crypto stuff */ load_crypto_v( cb ); return 0;

5 years, 5 months

Re: [sr-dev] [kamailio/kamailio] db_postgres: fix, insert update should always (2bebdb0)

by Julien Chavanton

This index was wrong, the module was not able to favor unique constraint over primary key constraint ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/2bebdb083ba8078fa9eec237fe0b0e2…

5 years, 5 months

git:master:2bebdb08: db_postgres: fix, insert update should always

by Julien Chavanton

Module: kamailio Branch: master Commit: 2bebdb083ba8078fa9eec237fe0b0e2134a21b9b URL: https://github.com/kamailio/kamailio/commit/2bebdb083ba8078fa9eec237fe0b0e2… Author: Julien Chavanton <jchavanton(a)gmail.com> Committer: Julien Chavanton <jchavanton(a)gmail.com> Date: 2019-06-25T08:49:45-07:00 db_postgres: fix, insert update should always favor unique constraint over primary key --- Modified: src/modules/db_postgres/km_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/2bebdb083ba8078fa9eec237fe0b0e2… Patch: https://github.com/kamailio/kamailio/commit/2bebdb083ba8078fa9eec237fe0b0e2… --- diff --git a/src/modules/db_postgres/km_dbase.c b/src/modules/db_postgres/km_dbase.c index 4ddbe641b9..0ae7dff54d 100644 --- a/src/modules/db_postgres/km_dbase.c +++ b/src/modules/db_postgres/km_dbase.c @@ -788,7 +788,7 @@ static char *db_postgres_constraint_get(const db1_con_t *_h) rows = RES_ROWS(res); for(x = 0; x < RES_ROW_N(res); x++) { val = (ROW_VALUES(&rows[x])[0]).val.string_val; - type = (ROW_VALUES(&rows[x])[0]).val.string_val; + type = (ROW_VALUES(&rows[x])[1]).val.string_val; LM_DBG("name[%s]type[%s]\n", val, type); if(type[0] == 'u') break; // always favor unique constraint over primary key constraint

5 years, 5 months

[kamailio/kamailio] KEMI - Missing PVX functions in app_ruby (#1987)

by Whitey

### Description Only the following PVX methods are available on app_ruby: :sbranch_set_ruri, :sbranch_append, :sbranch_reset, :pv_var_to_xavp, :pv_xavp_to_var, :pv_xavp_print, :xavp_params_explode, :xavp_params_implode, :evalx, :freeze However pvx.xavp.get() etc are documented: https://kamailio.org/docs/tutorials/devel/kamailio-kemi-framework/modules/#… #### Reproduction `KSR.info(KSR::PVX.methods.to_s)` ### Additional Information kamailio 5.3.0-dev4 (x86_64/linux) 6d43ea Can be potentially worked around by using `:pv_xavp_to_var` and `KSR::PV.gete()`, however this feels a bit messy -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1987

5 years, 5 months

← Newer
1
...
8
9
10
11
12
13
14
...
22
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2019