sr-dev August 2019

sr-dev@lists.kamailio.org

17 participants
340 discussions

[kamailio/kamailio] nathelper: test sdp c line and sip source ip address is matched. (#2045)
by Yasin CANER 03 Sep '19

03 Sep '19

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  test sdp c line and sip source ip address is matched. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2045 -- Commit Summary -- * nathelper: test sdp c line and sip source ip address is matched * nathelper : flag 256 is added to nathelper documentation -- File Changes -- M src/modules/nathelper/doc/nathelper_admin.xml (72) M src/modules/nathelper/nathelper.c (47) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2045.patch https://github.com/kamailio/kamailio/pull/2045.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2045

3 19

[kamailio/kamailio] to tags generation (#1164)
by Dmitri Savolainen 02 Sep '19

02 Sep '19

### Description Not shure is this relevant issue. according to rfc3261: > When a tag is generated by a UA for insertion into a request or > response, it MUST be globally unique and cryptographically random > with at least 32 bits of randomness. Kamailio has 16 instead and distribution is not good. I look at tags for 419485 sip flows (different callid) and table below (top keys ordered by count): tag suffix; count for different flows with this suffix ed54 6258 d118 5988 56ce 5923 a7a5 5220 de51 2150 82d8 1143 cf52 890 af92 740 7b5f 534 85f7 307 e553 163 7f7e 138 1d55 130 1afe 62 5a69 43 7caa 18 8474 18 9db2 18 11d3 18 f9ff 18 5420 17 dae6 17 908d 17 ede4 17 09ee 17 96be 17 25dc 17 af6d 16 2506 16 3da0 16 f161 16 1c29 16 #### SIP Traffic To: <sip:039*101@host:5071>;tag=555d2c3eafafcba8ac92b676e91bb6ed.58eb -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1164

3 4

5.3 add rr record_route_preset to KEMI?
by Anthony Alba 01 Sep '19

01 Sep '19

Hi Daniel and Kamailio developers, Could you consider adding record_route_preset to KEMI in 5.3? If you like I can do the PR. Hope it is not too late. Regards Anthony Alba

2 1

git:master:8aeca29b: pkg/docker: updated submodule [skip ci]
by Sergey Safarov 31 Aug '19

31 Aug '19

Module: kamailio Branch: master Commit: 8aeca29b0666a6c6fbca7e7488677aad1a45e44e URL: https://github.com/kamailio/kamailio/commit/8aeca29b0666a6c6fbca7e7488677aa… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-08-31T13:05:32+03:00 pkg/docker: updated submodule [skip ci] --- Modified: pkg/docker --- Diff: https://github.com/kamailio/kamailio/commit/8aeca29b0666a6c6fbca7e7488677aa… Patch: https://github.com/kamailio/kamailio/commit/8aeca29b0666a6c6fbca7e7488677aa… --- diff --git a/pkg/docker b/pkg/docker index b92a1c899b..5d6f46a758 160000 --- a/pkg/docker +++ b/pkg/docker @@ -1 +1 @@ -Subproject commit b92a1c899b8c474afadd0cf29dd7cb4ea01a3466 +Subproject commit 5d6f46a758e0d98fa4258925d40aa1521b1e27d0

1 0

git:master:8f98a04c: pkg/kamailio/obs: packaged kemix, lost and xhttp_prom modules
by Sergey Safarov 31 Aug '19

31 Aug '19

Module: kamailio Branch: master Commit: 8f98a04c0f9392db6a74289a184d06da11545ab0 URL: https://github.com/kamailio/kamailio/commit/8f98a04c0f9392db6a74289a184d06d… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2019-08-31T13:03:20+03:00 pkg/kamailio/obs: packaged kemix, lost and xhttp_prom modules --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/8f98a04c0f9392db6a74289a184d06d… Patch: https://github.com/kamailio/kamailio/commit/8f98a04c0f9392db6a74289a184d06d… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 8fd4254eb7..9dec32a876 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1425,7 +1425,9 @@ fi %doc %{_docdir}/kamailio/modules/README.htable %doc %{_docdir}/kamailio/modules/README.imc %doc %{_docdir}/kamailio/modules/README.ipops +%doc %{_docdir}/kamailio/modules/README.kemix %doc %{_docdir}/kamailio/modules/README.kex +%doc %{_docdir}/kamailio/modules/README.lost %doc %{_docdir}/kamailio/modules/README.malloc_test %doc %{_docdir}/kamailio/modules/README.mangler %doc %{_docdir}/kamailio/modules/README.matrix @@ -1492,6 +1494,7 @@ fi %doc %{_docdir}/kamailio/modules/README.userblacklist %doc %{_docdir}/kamailio/modules/README.usrloc %doc %{_docdir}/kamailio/modules/README.xhttp +%doc %{_docdir}/kamailio/modules/README.xhttp_prom %doc %{_docdir}/kamailio/modules/README.xhttp_rpc %doc %{_docdir}/kamailio/modules/README.xlog %doc %{_docdir}/kamailio/modules/README.xprint @@ -1576,7 +1579,9 @@ fi %{_libdir}/kamailio/modules/htable.so %{_libdir}/kamailio/modules/imc.so %{_libdir}/kamailio/modules/ipops.so +%{_libdir}/kamailio/modules/kemix.so %{_libdir}/kamailio/modules/kex.so +%{_libdir}/kamailio/modules/lost.so %{_libdir}/kamailio/modules/malloc_test.so %{_libdir}/kamailio/modules/mangler.so %{_libdir}/kamailio/modules/matrix.so @@ -1643,6 +1648,7 @@ fi %{_libdir}/kamailio/modules/userblacklist.so %{_libdir}/kamailio/modules/usrloc.so %{_libdir}/kamailio/modules/xhttp.so +%{_libdir}/kamailio/modules/xhttp_prom.so %{_libdir}/kamailio/modules/xhttp_rpc.so %{_libdir}/kamailio/modules/xlog.so %{_libdir}/kamailio/modules/xprint.so @@ -1875,7 +1881,9 @@ fi %files lua %defattr(-,root,root) %doc %{_docdir}/kamailio/modules/README.app_lua +%doc %{_docdir}/kamailio/modules/README.app_lua_sr %{_libdir}/kamailio/modules/app_lua.so +%{_libdir}/kamailio/modules/app_lua_sr.so %endif @@ -2217,6 +2225,8 @@ fi %changelog +* Sat Aug 31 2019 Sergey Safarov <s.safarov(a)gmail.com> 5.3.0-dev7 + - Packaged kemix, lost and xhttp_prom modules * Sat Mar 30 2019 Sergey Safarov <s.safarov(a)gmail.com> 5.3.0-0 - Added support of openSUSE:Leap:15.0, openSUSE:Leap:15.1 and Fedora 30 dists * Thu Feb 21 2019 Sergey Safarov <s.safarov(a)gmail.com> 5.3.0-0

1 0

Info: Upgrading kamcli to work with Python3
by Daniel-Constantin Mierla 30 Aug '19

30 Aug '19

Hello, with the perspective that Python2 is going to be removed from the major Linux distributes starting with the beginning of next year, the work to upgrade kamcli to run with Python3 has been started. >From now on, master branch of kamcli is expected to work only with Python3: * https://github.com/kamailio/kamcli There is still work to be done to upgrade all the code, but any use of it should be done with Python3 and eventual issues to be filed on bug tracker. Of course, pull requests are welcome as always! Who wants to use the version for Python2 has to use the code from git branch v1.2-python2. That branch is probably not going to receive any new feature, it will be kept for use with older systems (as well as a running option during the upgrade period to Python3). Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

1 0

git:master:72a4d665: tm: void the return for sr_kemi_route() to prevent analyzer warnings
by Daniel-Constantin Mierla 30 Aug '19

30 Aug '19

Module: kamailio Branch: master Commit: 72a4d665607d3c38278a744d3af3588ed54d2a05 URL: https://github.com/kamailio/kamailio/commit/72a4d665607d3c38278a744d3af3588… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-08-30T09:09:33+02:00 tm: void the return for sr_kemi_route() to prevent analyzer warnings --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/72a4d665607d3c38278a744d3af3588… Patch: https://github.com/kamailio/kamailio/commit/72a4d665607d3c38278a744d3af3588… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 350be35bdd..331bdbdf71 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -593,7 +593,7 @@ static int _reply_light( struct cell *trans, char* buf, unsigned int len, } else { bctx = sr_kemi_act_ctx_get(); sr_kemi_act_ctx_set(&ctx); - sr_kemi_route(keng, &pmsg, EVENT_ROUTE, + (void)sr_kemi_route(keng, &pmsg, EVENT_ROUTE, &_tm_event_callback_lres_sent, &evname); sr_kemi_act_ctx_set(bctx); }

1 0

git:master:932bbdb1: sl: void the return for sr_kemi_route() to prevent analyzer warnings
by Daniel-Constantin Mierla 30 Aug '19

30 Aug '19

Module: kamailio Branch: master Commit: 932bbdb19f48808fe6f40849e4798124ef4da127 URL: https://github.com/kamailio/kamailio/commit/932bbdb19f48808fe6f40849e479812… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-08-30T09:04:43+02:00 sl: void the return for sr_kemi_route() to prevent analyzer warnings --- Modified: src/modules/sl/sl_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/932bbdb19f48808fe6f40849e479812… Patch: https://github.com/kamailio/kamailio/commit/932bbdb19f48808fe6f40849e479812… --- diff --git a/src/modules/sl/sl_funcs.c b/src/modules/sl/sl_funcs.c index 83cf15bb5d..5e36a5542e 100644 --- a/src/modules/sl/sl_funcs.c +++ b/src/modules/sl/sl_funcs.c @@ -293,7 +293,7 @@ int sl_reply_helper(struct sip_msg *msg, int code, char *reason, str *tag) } else if (keng!=NULL) { bctx = sr_kemi_act_ctx_get(); sr_kemi_act_ctx_set(&ctx); - sr_kemi_route(keng, msg, EVENT_ROUTE, + (void)sr_kemi_route(keng, msg, EVENT_ROUTE, &_sl_event_callback_lres_sent, &evname); sr_kemi_act_ctx_set(bctx); } @@ -448,7 +448,7 @@ int sl_filter_ACK(struct sip_msg *msg, unsigned int flags, void *bar ) init_run_actions_ctx(&ctx); bctx = sr_kemi_act_ctx_get(); sr_kemi_act_ctx_set(&ctx); - sr_kemi_route(keng, msg, EVENT_ROUTE, + (void)sr_kemi_route(keng, msg, EVENT_ROUTE, &_sl_event_callback_fl_ack, &evname); sr_kemi_act_ctx_set(bctx); }

1 0

[kamailio/kamailio] tls_domain subdomain matching broken (#2049)
by Laszlo 29 Aug '19

29 Aug '19

Concerns the following code: https://github.com/kamailio/kamailio/blob/master/src/modules/tls/tls_domain… Let's say `sname = sip.example.com` and `p->server_name = example.com`. ``` dotpos = sname->len - p->server_name.len; > dotpos = len("sip.example.com") - len("example.com") > dotpos = 15 - 11 = 4 if (sname->s[dotpos] == '.') > if ("sip.example.com"[4] == '.') ``` `sip.example.com"[4]` is "e", not "." so the if clause will always fail and subdomains will never be matched. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2049

2 2

git:master:16beec2b: tls: proper dot position for matching subdomains
by Daniel-Constantin Mierla 29 Aug '19

29 Aug '19

Module: kamailio Branch: master Commit: 16beec2b7660d416a05f069695b4ce18e8b4e795 URL: https://github.com/kamailio/kamailio/commit/16beec2b7660d416a05f069695b4ce1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-08-29T18:51:17+02:00 tls: proper dot position for matching subdomains - reported by GH #2049 --- Modified: src/modules/tls/tls_domain.c --- Diff: https://github.com/kamailio/kamailio/commit/16beec2b7660d416a05f069695b4ce1… Patch: https://github.com/kamailio/kamailio/commit/16beec2b7660d416a05f069695b4ce1… --- diff --git a/src/modules/tls/tls_domain.c b/src/modules/tls/tls_domain.c index fff4603eba..1ca62ff200 100644 --- a/src/modules/tls/tls_domain.c +++ b/src/modules/tls/tls_domain.c @@ -1563,7 +1563,7 @@ tls_domain_t* tls_lookup_cfg(tls_domains_cfg_t* cfg, int type, if ((p->server_name_mode==KSR_TLS_SNM_INCDOM || p->server_name_mode==KSR_TLS_SNM_SUBDOM) && (p->server_name.len<sname->len)) { - dotpos = sname->len - p->server_name.len; + dotpos = sname->len - p->server_name.len - 1; if(sname->s[dotpos] == '.' && strncasecmp(p->server_name.s, sname->s + dotpos + 1,

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
34
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2019