sr-dev August 2019

sr-dev@lists.kamailio.org

17 participants
339 discussions

by Daniel-Constantin Mierla

Hello, at couple of events I participated during the past few months, I was asked about support of STIR/SHAKEN (caller identity authentication/verification), which is a hot topic these days at least in USA, aiming to combat "fraudulent" robo-calling. Therefore I thought of share some details with everyone in the community about the state in Kamailio, writing to both devs and users, the information being relevant for everyone. We already have the (related) module named auth_identity, available since 2008 (iirc): - https://www.kamailio.org/docs/modules/stable/modules/auth_identity.html But it implements the previous iteration of the specs for caller identity, respectively RFC 4474: - https://tools.ietf.org/html/rfc4474 However, that RFC is obsoleted by 8224 (the latest core specs for STIR/SHAKEN): - https://tools.ietf.org/html/rfc8224 Then, there are also RFCs 8225 and 8226 to add to the core specs. Should anyone be interested to implement STIR/SHAKEN specs in a modules, I would suggest to start from auth_identity -- might not be much work to update it to become conform with latest specs (a new module can be created, of course, even when starting from auth_identity). However, these specs are about signing the SIP request (the INVITE) with special PKI certificate. It can be done easily with embedded scripts such as Lua or Python (inline execution in native kamailio.cfg or using kemi scripts). At Kamailio World 2019, one of the participants I discussed with told me they already implemented using Lua. That's it for a starting point, if anyone wants to discuss more, just reply to sr-users and add your comments or ask the questions. If someone wants to go ahead and work on a C module, announce yourself to avoid duplicate work of others, and use sr-dev if you need assistance on module development. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

5 years, 3 months

[kamailio/kamailio] Module:rtpengine: memory leak is fixed, if no rtpengine in list (#2038)

by Surendra Tiwari

… reload   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2038 -- Commit Summary -- * Module:rtpengine: memory leak is fixed, if no rtpengine in list while reload -- File Changes -- M src/modules/rtpengine/rtpengine_db.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2038.patch https://github.com/kamailio/kamailio/pull/2038.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2038

5 years, 3 months

git:master:7d7670f6: Merge pull request #2038 from surendratiwari3/memory_leak_rtpengine

by GitHub

Module: kamailio Branch: master Commit: 7d7670f6d19cba5cbb8a3533795d6e271edad8f1 URL: https://github.com/kamailio/kamailio/commit/7d7670f6d19cba5cbb8a3533795d6e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2019-08-23T09:46:40+02:00 Merge pull request #2038 from surendratiwari3/memory_leak_rtpengine Module:rtpengine: memory leak is fixed, if no rtpengine in list --- Modified: src/modules/rtpengine/rtpengine_db.c --- Diff: https://github.com/kamailio/kamailio/commit/7d7670f6d19cba5cbb8a3533795d6e2… Patch: https://github.com/kamailio/kamailio/commit/7d7670f6d19cba5cbb8a3533795d6e2… --- diff --git a/src/modules/rtpengine/rtpengine_db.c b/src/modules/rtpengine/rtpengine_db.c index 0da3a6f371..8532fd270a 100644 --- a/src/modules/rtpengine/rtpengine_db.c +++ b/src/modules/rtpengine/rtpengine_db.c @@ -98,6 +98,7 @@ static int rtpp_load_db(void) if (n_rows == 0) { LM_WARN("No rtpproxy instances in database\n"); + rtpp_dbf.free_result(rtpp_db_handle, res); return 0; }

5 years, 3 months

git:master:0e29879e: Module:rtpengine: memory leak is fixed, if no rtpengine in list while reload

by surendra tiwari

Module: kamailio Branch: master Commit: 0e29879ee950d5a9e9a669c7d5c634416d52f5c9 URL: https://github.com/kamailio/kamailio/commit/0e29879ee950d5a9e9a669c7d5c6344… Author: Surendra Tiwari <surendratiwari3(a)gmail.com> Committer: surendra tiwari <surendratiwari3(a)gmail.com> Date: 2019-08-20T13:17:04+05:30 Module:rtpengine: memory leak is fixed, if no rtpengine in list while reload --- Modified: src/modules/rtpengine/rtpengine_db.c --- Diff: https://github.com/kamailio/kamailio/commit/0e29879ee950d5a9e9a669c7d5c6344… Patch: https://github.com/kamailio/kamailio/commit/0e29879ee950d5a9e9a669c7d5c6344… --- diff --git a/src/modules/rtpengine/rtpengine_db.c b/src/modules/rtpengine/rtpengine_db.c index 0da3a6f371..8532fd270a 100644 --- a/src/modules/rtpengine/rtpengine_db.c +++ b/src/modules/rtpengine/rtpengine_db.c @@ -98,6 +98,7 @@ static int rtpp_load_db(void) if (n_rows == 0) { LM_WARN("No rtpproxy instances in database\n"); + rtpp_dbf.free_result(rtpp_db_handle, res); return 0; }

5 years, 3 months

git:master:92a25673: uac: remove obselete DB definition from source code

by Henning Westerholt

Module: kamailio Branch: master Commit: 92a25673cb3b16b0d324569c25dc74f14a7c9147 URL: https://github.com/kamailio/kamailio/commit/92a25673cb3b16b0d324569c25dc74f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-08-22T22:28:11+02:00 uac: remove obselete DB definition from source code --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/92a25673cb3b16b0d324569c25dc74f… Patch: https://github.com/kamailio/kamailio/commit/92a25673cb3b16b0d324569c25dc74f… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index c19d758630..8b12fe4361 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -139,26 +139,6 @@ str reg_delay_column = str_init("reg_delay"); str str_empty = str_init(""); -#if 0 -INSERT INTO version (table_name, table_version) values ('uacreg','1'); -CREATE TABLE uacreg ( - id INT(10) UNSIGNED AUTO_INCREMENT PRIMARY KEY NOT NULL, - l_uuid VARCHAR(64) NOT NULL, - l_username VARCHAR(64) NOT NULL, - l_domain VARCHAR(128) DEFAULT '' NOT NULL, - r_username VARCHAR(64) NOT NULL, - r_domain VARCHAR(128) NOT NULL, - realm VARCHAR(64) NOT NULL, - auth_username VARCHAR(64) NOT NULL, - auth_password VARCHAR(64) NOT NULL, - auth_proxy VARCHAR(128) DEFAULT '' NOT NULL, - expires INT(10) UNSIGNED DEFAULT 0 NOT NULL, - flags INT(10) UNSIGNED DEFAULT 0 NOT NULL, - reg_delay INT(10) UNSIGNED DEFAULT 0 NOT NULL, - CONSTRAINT l_uuid_idx UNIQUE (l_uuid) - ) ENGINE=MyISAM; -#endif - extern struct tm_binds uac_tmb; extern pv_spec_t auth_username_spec;

5 years, 3 months

Failed to catch some reply message with reply_route block

by Salah Ahmed

Hello, We facing an issue on capturing sip message in Kamailio(Version: 5.2.3). The scenario is very simple. UAC Kamailio UAS |--------INVITE--------->| | | |-------INVITE------->| | |<------100 Trying----| |<-------100 Trying------| | | |<------200 Ok--------| |<-------200 Ok----------| | In this simple scenario, we can't catch any reply messages in between the Kamailio and UAC. We have tried reply_route, onreply_route, and onsend_route. But no one work to grep that reply on that side. onsend_route was bad try as its only for forwarded reply message. Is there any other magic to capture those replies. A debug=3 log message attached here. Thanks, Salah

5 years, 3 months

git:5.1:144a4945: dialog: run dlg callbacks also for PRACK requests (as done for "other" requests)

by Henning Westerholt

Module: kamailio Branch: 5.1 Commit: 144a49451387eee0cc75725af121348596184a7d URL: https://github.com/kamailio/kamailio/commit/144a49451387eee0cc75725af121348… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-08-20T22:28:41+02:00 dialog: run dlg callbacks also for PRACK requests (as done for "other" requests) - run dlg callbacks also for PRACK requests (as done for "other" requests) - bugfix for uac module in auto mode with dialog storage for PRACK requests (cherry picked from commit 4efe19f64d8bb787d2d620a833f5dd29619fa588) --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/144a49451387eee0cc75725af121348… Patch: https://github.com/kamailio/kamailio/commit/144a49451387eee0cc75725af121348… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 8d45d7818f..cb156e0f9d 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1451,7 +1451,7 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) goto done; } - if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK) + if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK || event==DLG_EVENT_REQPRACK) && (new_state==DLG_STATE_CONFIRMED || new_state==DLG_STATE_EARLY)) { timeout = get_dlg_timeout(req);

5 years, 3 months

git:5.2:a5713816: dialog: run dlg callbacks also for PRACK requests (as done for "other" requests)

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: a57138162a40390c245236a8ab693e62292d92ce URL: https://github.com/kamailio/kamailio/commit/a57138162a40390c245236a8ab693e6… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-08-20T22:28:37+02:00 dialog: run dlg callbacks also for PRACK requests (as done for "other" requests) - run dlg callbacks also for PRACK requests (as done for "other" requests) - bugfix for uac module in auto mode with dialog storage for PRACK requests (cherry picked from commit 4efe19f64d8bb787d2d620a833f5dd29619fa588) --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/a57138162a40390c245236a8ab693e6… Patch: https://github.com/kamailio/kamailio/commit/a57138162a40390c245236a8ab693e6… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 79a547aef1..ef36db8976 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1451,7 +1451,7 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) goto done; } - if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK) + if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK || event==DLG_EVENT_REQPRACK) && (new_state==DLG_STATE_CONFIRMED || new_state==DLG_STATE_EARLY)) { timeout = get_dlg_timeout(req);

5 years, 3 months

git:master:4efe19f6: dialog: run dlg callbacks also for PRACK requests (as done for "other" requests)

by Henning Westerholt

Module: kamailio Branch: master Commit: 4efe19f64d8bb787d2d620a833f5dd29619fa588 URL: https://github.com/kamailio/kamailio/commit/4efe19f64d8bb787d2d620a833f5dd2… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-08-20T22:24:30+02:00 dialog: run dlg callbacks also for PRACK requests (as done for "other" requests) - run dlg callbacks also for PRACK requests (as done for "other" requests) - bugfix for uac module in auto mode with dialog storage for PRACK requests --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/4efe19f64d8bb787d2d620a833f5dd2… Patch: https://github.com/kamailio/kamailio/commit/4efe19f64d8bb787d2d620a833f5dd2… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index eebb1e502e..71f29e24fc 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1472,7 +1472,7 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) goto done; } - if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK) + if ( (event==DLG_EVENT_REQ || event==DLG_EVENT_REQACK || event==DLG_EVENT_REQPRACK) && (new_state==DLG_STATE_CONFIRMED || new_state==DLG_STATE_EARLY)) { timeout = get_dlg_timeout(req);

5 years, 3 months

git:master:c5208429: build: lost module depends (also via http_client) on curl library, correct group

by Henning Westerholt

Module: kamailio Branch: master Commit: c5208429d1e2b4f4c0d3e7928849a172d8779644 URL: https://github.com/kamailio/kamailio/commit/c5208429d1e2b4f4c0d3e7928849a17… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-08-20T21:44:36+02:00 build: lost module depends (also via http_client) on curl library, correct group --- Modified: src/Makefile.groups --- Diff: https://github.com/kamailio/kamailio/commit/c5208429d1e2b4f4c0d3e7928849a17… Patch: https://github.com/kamailio/kamailio/commit/c5208429d1e2b4f4c0d3e7928849a17… --- diff --git a/src/Makefile.groups b/src/Makefile.groups index 936c8817ca..22fa6db0ed 100644 --- a/src/Makefile.groups +++ b/src/Makefile.groups @@ -22,7 +22,7 @@ mod_list_extra=avp auth_diameter call_control call_obj dmq domainpolicy msrp \ carrierroute pdb qos sca seas sms sst timer tmrec uac_redirect \ xhttp xhttp_rpc xprint jsonrpcs nosip dmq_usrloc statsd rtjson \ log_custom keepalive ss7ops app_sqlang acc_diameter evrexec \ - sipjson xhttp_prom lost + sipjson xhttp_prom # - common modules depending on database mod_list_db=acc alias_db auth_db avpops cfg_db db_text db_flatstore \ @@ -76,7 +76,7 @@ mod_list_xmpp=xmpp mod_list_berkeley=db_berkeley # - modules depending on curl library -mod_list_utils=utils http_client +mod_list_utils=utils http_client lost # - modules depending on curl and libevent2 library mod_list_http_async=http_async_client

5 years, 3 months

← Newer
1
...
14
15
16
17
18
19
20
...
34
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev August 2019