sr-dev September 2019

sr-dev@lists.kamailio.org

24 participants
368 discussions

git: new commits in branch 5.2
by Daniel-Constantin Mierla 24 Sep '19

24 Sep '19

- URL: https://github.com/kamailio/kamailio/commit/09ac3e47ef79dbd599b7dec5b84ae3b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:49:37+02:00 tm: set send socket flag when computing the destination and local socket is found (cherry picked from commit 8d608d1c3ed0fe4c69cb02868b746cd0497dd1f5) - URL: https://github.com/kamailio/kamailio/commit/ccf16cb7b8f84d2f9899d9922f5c940… Author: Surendra Tiwari <surendratiwari3(a)gmail.com> Date: 2019-09-24T11:50:18+02:00 Module:rtpengine: memory leak is fixed, if no rtpengine in list while reload (cherry picked from commit 0e29879ee950d5a9e9a669c7d5c634416d52f5c9) - URL: https://github.com/kamailio/kamailio/commit/c63d048c7ba2dc1e271fafbbd0e0a74… Author: Juha Heinanen <jh(a)tutpro.com> Date: 2019-09-24T11:52:05+02:00 modules/rtpengine: set_rtpengine_set fix (cherry picked from commit fe6614feb5f9b062a556de82fd7df6fc12c96471) - URL: https://github.com/kamailio/kamailio/commit/80bb3b96f60d3347460a202ec69e012… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:53:17+02:00 tls: proper dot position for matching subdomains - reported by GH #2049 (cherry picked from commit 16beec2b7660d416a05f069695b4ce18e8b4e795) - URL: https://github.com/kamailio/kamailio/commit/21ccb8f3e4f5496e5bb71c6cdfeec96… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:54:06+02:00 phonenum: new param resid to register result container ids - allow use in KEMI scripting by pre-registering container result id via modparam (cherry picked from commit 67412b4b2b377cca179de2ebe109bd56fb8a63b9) - URL: https://github.com/kamailio/kamailio/commit/e1197ad59685fa97868c5fffcbde841… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:54:17+02:00 phonenum: docs for resid parameter (cherry picked from commit d2bac426192c074368bf78014e0d1d0ca97f3274) - URL: https://github.com/kamailio/kamailio/commit/becc6bc3f90781f64b90879db1f7eea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:54:44+02:00 phonenum: proper access to the str type param resid (cherry picked from commit 56f86535e0ae3fcf8fa2d0b565c7ab61351678d0) - URL: https://github.com/kamailio/kamailio/commit/dcdfc26fc260d36000c991eed89da25… Author: A Alba <ascanio.alba7(a)gmail.com> Date: 2019-09-24T11:55:23+02:00 module rr: KEMI expose record_route_preset (cherry picked from commit e1ab977fd9a61864376782f2534cc0d932347d78) - URL: https://github.com/kamailio/kamailio/commit/7c3cc32c98a66318fa355fd14c69772… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:59:20+02:00 core: main - set default send tcp sockets to tls if no tcp is available (cherry picked from commit 8a678c244aa34cf352fb614693c6e6d505ce2dfe) - URL: https://github.com/kamailio/kamailio/commit/28c4e65e7aef8e6ab1129a45fc01e2b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:59:33+02:00 core: tcp - set default local socket for tls when lookup fails - GH #2028 (cherry picked from commit f40df55af2f50789ca4a8b89a213f7323b1932f2) - URL: https://github.com/kamailio/kamailio/commit/827dccc75d560257ba4caef5187894d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:59:47+02:00 Makefile.defs: detect if libssl version is 1.1+ - link against pthread to be able to set PTHREAD_PROCESS_SHARED attribute for mutex and rwlock initialization (cherry picked from commit 79619717aa67c219fc36dfaac8d06919b8f2018e) - URL: https://github.com/kamailio/kamailio/commit/cba7b6a19c9ac0d80e4bf8915379685… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T11:59:57+02:00 core: main - functions to set PTHREAD_PROCESS_SHARED for pthread mutex and rwlock - code relocated from src/modules/tls/utils/openssl_mutex_shared/openssl_mutex_shared.c - simpler option to initialize kamailio with the workaround for libssl v1.1+ without using the preloaded library approach (cherry picked from commit a8c811e69e964821b73d0861a9547a301253d172) - URL: https://github.com/kamailio/kamailio/commit/3425fbad549c16aa79c001560e7ec9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:00:59+02:00 log_systemd: return in case the xavp is not valid (cherry picked from commit 9e703c1c1eb362bd68e53b38021aa42f8b173d0c) - URL: https://github.com/kamailio/kamailio/commit/ffec32d01d440cb16dbaaac1b497f7c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:01:10+02:00 presence: reset freed list to avoid double free in case of error (cherry picked from commit 28dc74fa8a30b17abd7f7b173b66b8538c5a4bb5) - URL: https://github.com/kamailio/kamailio/commit/25585a67489cba4e55e888c68aacb1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:02:13+02:00 kamctl: kamdbctl.base - replaced get_answer() with a portable version - contributed by Sergey Safarov, GH #2019 (cherry picked from commit 88d06a08a8baf460188745f1d748dd83f275356f) - URL: https://github.com/kamailio/kamailio/commit/40e1dba3b2089ee66fec6e431dbbd2b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:02:29+02:00 core: print a version flag when pthread shared mutex is enabled for tls (cherry picked from commit 801a9e38bcd863950a53ed0ca63a2976376daddc) - URL: https://github.com/kamailio/kamailio/commit/745475301cdacf9d391b39bb1701453… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:03:03+02:00 xmlrpc: reset fields in case of error for building fake via (cherry picked from commit b54573ca9167c807a1de39634bed04cb7953dce0) - URL: https://github.com/kamailio/kamailio/commit/991a12f98320af2066697cd74394b6f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2019-09-24T12:03:12+02:00 xcap_server: free xpath object before reusing the variable - removed unnecessary resets of local variables at the end of function (cherry picked from commit d0ed04ae7938ef09da1ca215043334190adb9c52)

1 0

[kamailio/kamailio] Entries never expires on dns cache (#2063)
by Mathieu Bodjikian 24 Sep '19

24 Sep '19

Hello, We have a weird bug in our Kamailio boxes. We use the DNS cache (for dns failover to work properly), and on some servers, the cache becomes broken after some time. The expire value is stuck and do not decrement over time, on the entry and on the records : ` kamcmd> dns.lookup A freeswitch { name: freeswitch type: A size_bytes: 200 reference_counter: 2 permanent: no expires: 2 last_used: 0 negative_entry: no records: { { rr_idx: 0 rr_ip: 10.0.0.1 rr_permanent: no rr_expires: 2 } { rr_idx: 1 rr_ip: 10.0.0.2 rr_permanent: no rr_expires: 2 } { rr_idx: 2 rr_ip: 10.0.0.3 rr_permanent: no rr_expires: 2 } } } ` Expires values are computed each time like this : ` now=get_ticks_raw(); expires = (s_ticks_t)(e->expire-now)<0?-1: TICKS_TO_S(e->expire-now); ` So it would means either : - TICKS_TO_S(get_ticks_raw()) == 0 when the entry is created - TICKS_TO_S(get_ticks_raw()) == 0 when the value is printed when we execute a dns.lookup through rpc. Details : - Kamailio : 5.2.4 (x86_64/linux) - OS : Debian 9.9 - Running in Docker on Kubernetes cluster I cannot say how to reproduce, it happens sometimes after running the binary :/ Do you have any idea ? Kind regards, Mathieu Bodjikian -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2063

3 8

[kamailio/kamailio] registrar: memory leak in xavp_rcd (#1834)
by Olle E. Johansson 24 Sep '19

24 Sep '19

### Description Kamailio 5.1 on Debian - Enabled xavp_rcd in registrar - Shared memory usage keeps growing over time ### Troubleshooting - `mod.stats core all `show a large amount of allocated memory for xavp_new_value that keeps growing over time ` xavp_new_value(94): 48815768` #### Reproduction We have the same symptom on multiple servers #### Log Messages Nothing shown in the log yet. ### Possible Solutions Using reg_fetch_contacts to grab expiry time is an alternative that works. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 10:59:52 Jul 3 2018 with gcc 6.3.0 ``` * **Operating System**: ``` Debian 9.7 x86_64 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1834

5 12

rate-limiting enabled on kamailio.org
by Henning Westerholt 22 Sep '19

22 Sep '19

Hello, just to inform you that rate-limiting on kamailio.org web server has been enabled. The motivation is to throttle robots and other automated services to not overload the server. If you notice any new errors in accessing the service (like page not found, or a 429 Too Many Requests) let us know. Cheers, Henning -- Kamailio Merchandising - https://skalatan.de/merchandising/ Kamailio services - https://skalatan.de/services Henning Westerholt - https://skalatan.de/blog/

1 0

git:master:2f690e4c: modules: readme files regenerated - drouting ... [skip ci]
by Kamailio Dev 21 Sep '19

21 Sep '19

Module: kamailio Branch: master Commit: 2f690e4c01502ad744d3e24e368ff4359dcbdf33 URL: https://github.com/kamailio/kamailio/commit/2f690e4c01502ad744d3e24e368ff43… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2019-09-22T00:46:32+02:00 modules: readme files regenerated - drouting ... [skip ci] --- Modified: src/modules/drouting/README --- Diff: https://github.com/kamailio/kamailio/commit/2f690e4c01502ad744d3e24e368ff43… Patch: https://github.com/kamailio/kamailio/commit/2f690e4c01502ad744d3e24e368ff43… --- diff --git a/src/modules/drouting/README b/src/modules/drouting/README index b24eb6c78d..a61a00e6d7 100644 --- a/src/modules/drouting/README +++ b/src/modules/drouting/README @@ -6,8 +6,6 @@ Edited by Ovidiu Sas -Edited by - Anca-Maria Vamanu Copyright © 2005-2008 Voice Sistem SRL @@ -307,18 +305,18 @@ Chapter 1. Admin Guide draft 09): Table 1.4. Time recurrence attributes - Attribute Description - dastard Start of interval (RFC 2445 DATE-TIME) - duration Length of interval (RFC 2445 DURATION) - freq Frequency of recurrence (secondly,minutely,hourly, daily,weekly, - monthly, or yearly). - until bound of recurrence (RFC 2445 DATE-TIME) - interval How often the recurrence repeats - byday List of days of the week - bymonthday List of days of the month - byyearday List of days of the year - byweekno List of weeks of the year - bymonth List of months of the year + Attribute Description + dastard Start of interval (RFC 2445 DATE-TIME) + duration Length of interval (RFC 2445 DURATION) + freq Frequency of recurrence (secondly,minutely,hourly, daily,weekly, + monthly, or yearly). + until bound of recurrence (RFC 2445 DATE-TIME) + interval How often the recurrence repeats + byday List of days of the week + bymonthday List of days of the month + byyearday List of days of the year + byweekno List of weeks of the year + bymonth List of months of the year The value stored in database has the format of: <dtstart>|<duration>|<freq>|<until>|<interval>|<byday>|<bymonthday> |<byyearday>|<byweekno>|<bymonth> @@ -509,7 +507,7 @@ Chapter 1. Admin Guide The database url. - Default value is “NULL”. + Default value is “mysql://kamailioro:kamailioro@localhost/kamailio”. Example 1.1. Set db_url parameter ...

1 0

git: new commits in branch master
by Henning Westerholt 21 Sep '19

21 Sep '19

- URL: https://github.com/kamailio/kamailio/commit/4dbe7fa01d43931cbe1bfc041d4a16b… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T22:53:55+02:00 core: remove code for NO_REVERSE_INIT #define from 2002, which don't compile anymore - URL: https://github.com/kamailio/kamailio/commit/0cd270bcb4b4402f94fa65224e8d69c… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T23:35:35+02:00 core: more secure PRNG initialization, use fastrand (its much safer) to init the other PRNGs - URL: https://github.com/kamailio/kamailio/commit/3caeb310bda0a40f0dca3567308df9f… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T23:40:11+02:00 core: improve child_init debug logging - URL: https://github.com/kamailio/kamailio/commit/9d9e6f0df91fdab423bc5740099a9db… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T23:44:33+02:00 drouting: use default DB URL as all the other modules - URL: https://github.com/kamailio/kamailio/commit/e8aa74a0220d6776c417d0f83d438be… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T23:45:00+02:00 drouting: document default DB URL - URL: https://github.com/kamailio/kamailio/commit/f07664492be76212aaa5c380d982860… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T23:53:13+02:00 core: more secure PRNG initialization, use fastrand (its much safer) to init the other PRNGs - more secure PRNG initialization, use fastrand (its much safer) to init the other PRNGs - related to commit 0cd270bcb4b for main process, this is for the forked children - URL: https://github.com/kamailio/kamailio/commit/8dc02a6bd0adb068a07ec7b6b856e20… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:05:18+02:00 uac: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/e85c9fc326d7d06a1078a529ed0a873… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:08:31+02:00 dispatcher: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/e68bab8a107c19776f0d4abdc52ca8b… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:09:53+02:00 auth: remove commented out code block related to PRNG initialization - URL: https://github.com/kamailio/kamailio/commit/df25b16635e88b493b07bb3c3e0eb6a… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:10:51+02:00 cdp: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/930406ec25254859eef0fa1db194d19… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:11:14+02:00 lost: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/c89746fd908788807fdae32577450de… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:11:41+02:00 drouting: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/6e81ff04eff41666a7fa94a7ac090bd… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:12:14+02:00 mohqueue: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/56c6f787a0e968d3ed05c21cffe8bde… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:31:08+02:00 cdp: several own processes are forked, we need to properly initialize the PRNG for them - cdp: several own processes are forked, properly initialize the PRNG for them - related to commit df25b16635e - URL: https://github.com/kamailio/kamailio/commit/53ea0794c9ffeb017e0e5500b0ac248… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:34:49+02:00 sipcapture: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children - URL: https://github.com/kamailio/kamailio/commit/e2c3ed2de42eaa85c52d9d78c6e2076… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-22T00:36:18+02:00 lib: don't initialize the PRNG again, especially with insecure low entropy input - don't initialize the PRNG again, especially with insecure low entropy input - this is done in the core for the main process and all children

1 0

git:5.1:8ff3c229: core: remove unused seq variable in build_iface_list function
by Henning Westerholt 21 Sep '19

21 Sep '19

Module: kamailio Branch: 5.1 Commit: 8ff3c229f8c659278c0e1209933748b99f478507 URL: https://github.com/kamailio/kamailio/commit/8ff3c229f8c659278c0e1209933748b… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T21:25:55+02:00 core: remove unused seq variable in build_iface_list function (cherry picked from commit 8821cc2f5a6b972307fb71e73cf8d57496e61f66) --- Modified: src/core/socket_info.c --- Diff: https://github.com/kamailio/kamailio/commit/8ff3c229f8c659278c0e1209933748b… Patch: https://github.com/kamailio/kamailio/commit/8ff3c229f8c659278c0e1209933748b… --- diff --git a/src/core/socket_info.c b/src/core/socket_info.c index 424c5d83e8..6c3f6d5921 100644 --- a/src/core/socket_info.c +++ b/src/core/socket_info.c @@ -992,7 +992,6 @@ static int build_iface_list(void) struct rtgenmsg g; } req; - int seq = 0; int rtn = 0; struct nlmsghdr* nlp; struct ifaddrmsg *ifi;

1 0

git:5.1:cd0fe9e4: tools: fix python exception usage in route_graph.py tool
by Henning Westerholt 21 Sep '19

21 Sep '19

Module: kamailio Branch: 5.1 Commit: cd0fe9e469c60be0b5c22cfa62f33cc70c12bb1f URL: https://github.com/kamailio/kamailio/commit/cd0fe9e469c60be0b5c22cfa62f33cc… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T21:25:25+02:00 tools: fix python exception usage in route_graph.py tool (cherry picked from commit 4a66e500ddb6028d3dfcf67aca951282309b6ea4) --- Modified: misc/tools/route_graph/route_graph.py --- Diff: https://github.com/kamailio/kamailio/commit/cd0fe9e469c60be0b5c22cfa62f33cc… Patch: https://github.com/kamailio/kamailio/commit/cd0fe9e469c60be0b5c22cfa62f33cc… --- diff --git a/misc/tools/route_graph/route_graph.py b/misc/tools/route_graph/route_graph.py index 135440a3c5..b416bdc186 100755 --- a/misc/tools/route_graph/route_graph.py +++ b/misc/tools/route_graph/route_graph.py @@ -75,12 +75,12 @@ def traverse_routes(_level, _name): if len(sys.argv) < 2: - raise "usage: %s configuration-file [max_depth]" % sys.argv[0] + raise Exception('wrong number of arguments\nusage: ' + sys.argv[0] + ' configuration-file [max_depth]') if len(sys.argv) == 3: max_depth = int(sys.argv[2]) cfg = file(sys.argv[1], "r") if cfg is None: - raise "Missing config file" + raise Exception ('Missing config file') line = cfg.readline() rt = routes while line:

1 0

git:5.1:2b4cfd66: tools: use correct check of None instead of wrong comparison in route_graph.py tool
by Henning Westerholt 21 Sep '19

21 Sep '19

Module: kamailio Branch: 5.1 Commit: 2b4cfd66a57fdb1558852554189287f08c15ae5a URL: https://github.com/kamailio/kamailio/commit/2b4cfd66a57fdb1558852554189287f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T21:25:01+02:00 tools: use correct check of None instead of wrong comparison in route_graph.py tool (cherry picked from commit 545ef51912ae9bf5e14eaffeb9f41be8359a442f) --- Modified: misc/tools/route_graph/route_graph.py --- Diff: https://github.com/kamailio/kamailio/commit/2b4cfd66a57fdb1558852554189287f… Patch: https://github.com/kamailio/kamailio/commit/2b4cfd66a57fdb1558852554189287f… --- diff --git a/misc/tools/route_graph/route_graph.py b/misc/tools/route_graph/route_graph.py index 2024cf42a0..135440a3c5 100755 --- a/misc/tools/route_graph/route_graph.py +++ b/misc/tools/route_graph/route_graph.py @@ -79,7 +79,7 @@ def traverse_routes(_level, _name): if len(sys.argv) == 3: max_depth = int(sys.argv[2]) cfg = file(sys.argv[1], "r") -if cfg == None: +if cfg is None: raise "Missing config file" line = cfg.readline() rt = routes @@ -90,40 +90,40 @@ def traverse_routes(_level, _name): main_match = re_main_route.search(line) def_match = re_def_route.search(line) call_match = re_call_route.search(line) - if not call_match == None: + if not call_match is None: log("CALL: " + line) name = call_match.group(2) log(rname +":"+name) rt[rname].append(name) - elif not def_match == None: + elif not def_match is None: log("DEF: " + line) rtype = def_match.group(1) rname = def_match.group(3) if rtype == "failure_": rt = f_routes - if rname == None: + if rname is None: rname = "failure" elif rtype == "onreply_": rt = r_routes - if rname == None: + if rname is None: rname = "onreply" elif rtype == "onsend_": rt = s_routes - if rname == None: + if rname is None: rname = "onsend" elif rtype == "branch_": rt = b_routes - if rname == None: + if rname is None: rname = "branch" elif rtype == "event_": rt = e_routes - if rname == None: + if rname is None: rname = "event" else: rt = routes log(rname) rt[rname] = [] - elif not main_match == None: + elif not main_match is None: log("MAIN: " + line) rtype = main_match.group(1) if rtype == "failure_":

1 0

git:5.1:f21f3e63: core: fix possible int overflow (conversion after multiplication) in cfg code
by Henning Westerholt 21 Sep '19

21 Sep '19

Module: kamailio Branch: 5.1 Commit: f21f3e63fe6e16867568883e8aafd4f8dbe7c9f5 URL: https://github.com/kamailio/kamailio/commit/f21f3e63fe6e16867568883e8aafd4f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2019-09-21T21:24:24+02:00 core: fix possible int overflow (conversion after multiplication) in cfg code (cherry picked from commit d1f5a2a266716d4f6759f9e695249dce442ccdd2) --- Modified: src/core/cfg/cfg_struct.c --- Diff: https://github.com/kamailio/kamailio/commit/f21f3e63fe6e16867568883e8aafd4f… Patch: https://github.com/kamailio/kamailio/commit/f21f3e63fe6e16867568883e8aafd4f… --- diff --git a/src/core/cfg/cfg_struct.c b/src/core/cfg/cfg_struct.c index f7b1530419..f89e5a0daf 100644 --- a/src/core/cfg/cfg_struct.c +++ b/src/core/cfg/cfg_struct.c @@ -682,7 +682,7 @@ cfg_group_inst_t *cfg_extend_array(cfg_group_meta_t *meta, cfg_group_t *group, if (i > 0) memcpy( new_array, old_array, - inst_size * i); + (size_t) inst_size * i); memset((char*)new_array + inst_size * i, 0, inst_size); *new_group = (cfg_group_inst_t *)((char*)new_array + inst_size * i); @@ -691,7 +691,7 @@ cfg_group_inst_t *cfg_extend_array(cfg_group_meta_t *meta, cfg_group_t *group, if (i < meta->num) memcpy( (char*)new_array + inst_size * (i + 1), (char*)old_array + inst_size * i, - inst_size * (meta->num - i)); + (size_t) inst_size * (meta->num - i)); return new_array; }

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
37
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2019