sr-dev October 2020

sr-dev@lists.kamailio.org

19 participants
527 discussions

[kamailio/kamailio] Can't install kamailio-sipcapture-daemon-config package due to missing dependency (#1861)
by pwakano 22 Oct '20

22 Oct '20

kamailio-sipcapture-daemon-config can't be installed because it depends on the kamailio-sipcapture package, which can't be found...  Use the http://download.opensuse.org/repositories/home:/kamailio:/v5.2.x-rpms/CentO… repo and try to install the kamailio-sipcapture-daemon-config. The dependency can't be resolved and so the package does not install. It is not clear if the dependency is missing or if it is not valid. ``` # yum install kamailio-sipcapture-daemon-config Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: mirror.optus.net * epel: mirror.optus.net * extras: mirror.intergrid.com.au * updates: mirror.intergrid.com.au Resolving Dependencies --> Running transaction check ---> Package kamailio-sipcapture-daemon-config.x86_64 0:5.2.1-1.el7.centos will be installed --> Processing Dependency: kamailio-sipcapture = 5.2.1 for package: kamailio-sipcapture-daemon-config-5.2.1-1.el7.centos.x86_64 --> Finished Dependency Resolution Error: Package: kamailio-sipcapture-daemon-config-5.2.1-1.el7.centos.x86_64 (home_kamailio_v5.2.x-rpms) Requires: kamailio-sipcapture = 5.2.1 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest # yum deplist kamailio-sipcapture-daemon-config Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: mirror.optus.net * epel: mirror.optus.net * extras: mirror.intergrid.com.au * updates: mirror.intergrid.com.au package: kamailio-sipcapture-daemon-config.x86_64 5.2.1-1.el7.centos dependency: /bin/sh provider: bash.x86_64 4.2.46-31.el7 dependency: kamailio-sipcapture = 5.2.1 Unsatisfied dependency ```      * **Operating System**:  ``` # uname -a Linux voice-conn-kamailio-1 3.10.0-957.5.1.el7.x86_64 #1 SMP Fri Feb 1 14:54:57 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux # cat /etc/redhat-release CentOS Linux release 7.6.1810 (Core) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1861

3 11

[kamailio/kamailio] utils/pdbt: Relax permissions when creating files (#2523)
by Kristian Høgh 21 Oct '20

21 Oct '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  pdbt created files with permissions 0700, it is changed to 0644 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2523 -- Commit Summary -- * utils/pdbt: Relax permissions when creating files -- File Changes -- M utils/pdbt/pdbt.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2523.patch https://github.com/kamailio/kamailio/pull/2523.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2523

2 2

git:master:bb42ee28: utils/pdbt: Relax permissions when creating files
by Henning Westerholt 21 Oct '20

21 Oct '20

Module: kamailio Branch: master Commit: bb42ee28fc115e1e3373962c02162c9a8e6d41fc URL: https://github.com/kamailio/kamailio/commit/bb42ee28fc115e1e3373962c02162c9… Author: Kristian F. HÃ¸gh <kfh(a)uni-tel.dk> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-21T15:05:09+02:00 utils/pdbt: Relax permissions when creating files --- Modified: utils/pdbt/pdbt.c --- Diff: https://github.com/kamailio/kamailio/commit/bb42ee28fc115e1e3373962c02162c9… Patch: https://github.com/kamailio/kamailio/commit/bb42ee28fc115e1e3373962c02162c9… --- diff --git a/utils/pdbt/pdbt.c b/utils/pdbt/pdbt.c index 6521985b2b..5a52cf8c7a 100644 --- a/utils/pdbt/pdbt.c +++ b/utils/pdbt/pdbt.c @@ -297,7 +297,7 @@ int dt_write_tree(const struct dt_node_t *root, const char* filename) char number[25]; number[0] = '\0'; - fd = creat(filename, S_IRWXU); + fd = creat(filename, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH); if (fd < 0) { LERR("cannot create file '%s'\n", filename); return -1; @@ -370,7 +370,7 @@ int save_mmap(struct dt_node_t *root, char *filename) { int fd; int n; - fd = open(filename, O_RDWR|O_CREAT|O_TRUNC, S_IRWXU); + fd = open(filename, O_RDWR|O_CREAT|O_TRUNC, S_IRUSR|S_IWUSR|S_IRGRP|S_IROTH); if (fd < 0) { LERR("cannot create file '%s'\n", filename); return -1;

1 0

git:master:3a162187: rtp_media_server: use directly gen_lock_t instead of ser_lock_t which is tm typedef
by Daniel-Constantin Mierla 21 Oct '20

21 Oct '20

Module: kamailio Branch: master Commit: 3a162187580880fa7210bd376621f57576e9d209 URL: https://github.com/kamailio/kamailio/commit/3a162187580880fa7210bd376621f57… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-21T08:29:21+02:00 rtp_media_server: use directly gen_lock_t instead of ser_lock_t which is tm typedef --- Modified: src/modules/rtp_media_server/rms_dialog_info.c Modified: src/modules/rtp_media_server/rtp_media_server.h --- Diff: https://github.com/kamailio/kamailio/commit/3a162187580880fa7210bd376621f57… Patch: https://github.com/kamailio/kamailio/commit/3a162187580880fa7210bd376621f57… --- diff --git a/src/modules/rtp_media_server/rms_dialog_info.c b/src/modules/rtp_media_server/rms_dialog_info.c index b8c51bada2..841e74a340 100644 --- a/src/modules/rtp_media_server/rms_dialog_info.c +++ b/src/modules/rtp_media_server/rms_dialog_info.c @@ -23,7 +23,7 @@ extern rms_dialog_info_t *rms_dialog_list; extern int in_rms_process; -ser_lock_t dialog_list_mutex; +gen_lock_t dialog_list_mutex; static void rms_action_free(rms_dialog_info_t *si) { diff --git a/src/modules/rtp_media_server/rtp_media_server.h b/src/modules/rtp_media_server/rtp_media_server.h index cd3a0109ce..c23cf0df6e 100644 --- a/src/modules/rtp_media_server/rtp_media_server.h +++ b/src/modules/rtp_media_server/rtp_media_server.h @@ -39,7 +39,7 @@ #include "rms_media.h" #include "rms_dialog_info.h" -extern ser_lock_t dialog_list_mutex; +extern gen_lock_t dialog_list_mutex;

1 0

git:master:128ba4fe: rtp_media_server: declare variables in .c files
by Daniel-Constantin Mierla 21 Oct '20

21 Oct '20

Module: kamailio Branch: master Commit: 128ba4fe95f3c27474c9f839d34f8fb1fd75e064 URL: https://github.com/kamailio/kamailio/commit/128ba4fe95f3c27474c9f839d34f8fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-21T08:24:53+02:00 rtp_media_server: declare variables in .c files - extern in .h files, GH #2522 --- Modified: src/modules/rtp_media_server/rms_dialog_info.c Modified: src/modules/rtp_media_server/rtp_media_server.c Modified: src/modules/rtp_media_server/rtp_media_server.h --- Diff: https://github.com/kamailio/kamailio/commit/128ba4fe95f3c27474c9f839d34f8fb… Patch: https://github.com/kamailio/kamailio/commit/128ba4fe95f3c27474c9f839d34f8fb… --- diff --git a/src/modules/rtp_media_server/rms_dialog_info.c b/src/modules/rtp_media_server/rms_dialog_info.c index 24fe0bb0c0..b8c51bada2 100644 --- a/src/modules/rtp_media_server/rms_dialog_info.c +++ b/src/modules/rtp_media_server/rms_dialog_info.c @@ -19,9 +19,12 @@ */ #include "rtp_media_server.h" + extern rms_dialog_info_t *rms_dialog_list; extern int in_rms_process; +ser_lock_t dialog_list_mutex; + static void rms_action_free(rms_dialog_info_t *si) { rms_action_t *a, *tmp; diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index 8f2b2592aa..99eca96484 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -36,6 +36,8 @@ static char *rms_answer_default_route = "rms:start"; int in_rms_process; rms_t *rms; +struct tm_binds tmb; + static rms_dialog_info_t *rms_dialog_create_leg(rms_dialog_info_t *di, struct sip_msg *msg); static int fixup_rms_action_play(void **param, int param_no); static int fixup_rms_bridge(void **param, int param_no); diff --git a/src/modules/rtp_media_server/rtp_media_server.h b/src/modules/rtp_media_server/rtp_media_server.h index bf22660b1b..cd3a0109ce 100644 --- a/src/modules/rtp_media_server/rtp_media_server.h +++ b/src/modules/rtp_media_server/rtp_media_server.h @@ -39,7 +39,7 @@ #include "rms_media.h" #include "rms_dialog_info.h" -ser_lock_t dialog_list_mutex; +extern ser_lock_t dialog_list_mutex; @@ -51,7 +51,7 @@ typedef struct rms char *local_ip; } rms_t; -struct tm_binds tmb; +extern struct tm_binds tmb; #endif

1 0

[kamailio/kamailio] core: Document that a str can be zero-terminated (#2520)
by Alex Hermann 21 Oct '20

21 Oct '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2520 -- Commit Summary -- * core: Document that a str can be zero-terminated -- File Changes -- M src/core/str.h (17) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2520.patch https://github.com/kamailio/kamailio/pull/2520.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2520

2 2

git:master:fcdfaf98: core: Document that a str can be zero-terminated
by Henning Westerholt 21 Oct '20

21 Oct '20

Module: kamailio Branch: master Commit: fcdfaf98acf8a66e84b9dccc767fb52c0cf0d460 URL: https://github.com/kamailio/kamailio/commit/fcdfaf98acf8a66e84b9dccc767fb52… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-10-21T07:40:24+02:00 core: Document that a str can be zero-terminated But by default it isn't. The functions shm_str_dup() and pkg_str_dup() will always create a zero-terminated copy --- Modified: src/core/str.h --- Diff: https://github.com/kamailio/kamailio/commit/fcdfaf98acf8a66e84b9dccc767fb52… Patch: https://github.com/kamailio/kamailio/commit/fcdfaf98acf8a66e84b9dccc767fb52… --- diff --git a/src/core/str.h b/src/core/str.h index 01b12ecb62..58d7d627f6 100644 --- a/src/core/str.h +++ b/src/core/str.h @@ -40,13 +40,16 @@ * need to make a zero-terminated copy of it. * * @section drawbacks Drawbacks - * Note well that the fact that string stored - * using this data structure are not zero terminated makes them a little - * incovenient to use with many standard libc string functions, because these - * usually expect the input to be zero-terminated. In this case you have to - * either make a zero-terminated copy or inject the terminating zero behind - * the actuall string (if possible). Note that injecting a zero terminating - * characters is considered to be dangerous. + * Note well that the fact that a string stored + * using this data structure are not guaranteed to be zero terminated (by + * default they're not) makes them a little incovenient to use with many + * standard libc string functions, because these usually expect the input + * to be zero-terminated. + * In this case you have to either make a zero-terminated copy or inject the + * terminating zero behind the actuall string (if possible). Note that + * injecting a zero terminating characters is considered to be dangerous. + * The functions shm_str_dup() and pkg_str_dup() will always create a + * zero-terminated copy. */ /** @file

1 0

[kamailio/kamailio] core: Zero terminate str copies made with (pkg|shm)_str_dup() (#2519)
by Alex Hermann 20 Oct '20

20 Oct '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [x] Related to PR #2512 #### Description  As discussed in #2512, zero-terminating all copies is preferred as most str usage is already with zero-terminated str.s. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2519 -- Commit Summary -- * core: Zero terminate str copies made with (pkg|shm)_str_dup() -- File Changes -- M src/core/ut.h (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2519.patch https://github.com/kamailio/kamailio/pull/2519.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2519

3 6

git:master:d52f6017: modules: readme files regenerated - mqueue ... [skip ci]
by Kamailio Dev 20 Oct '20

20 Oct '20

Module: kamailio Branch: master Commit: d52f60173be34c5c1581c762444b5e26c57b097a URL: https://github.com/kamailio/kamailio/commit/d52f60173be34c5c1581c762444b5e2… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-10-20T14:01:14+02:00 modules: readme files regenerated - mqueue ... [skip ci] --- Modified: src/modules/mqueue/README --- Diff: https://github.com/kamailio/kamailio/commit/d52f60173be34c5c1581c762444b5e2… Patch: https://github.com/kamailio/kamailio/commit/d52f60173be34c5c1581c762444b5e2… --- diff --git a/src/modules/mqueue/README b/src/modules/mqueue/README index 9209bbcf43..c0ce6523f8 100644 --- a/src/modules/mqueue/README +++ b/src/modules/mqueue/README @@ -56,6 +56,7 @@ Julien Chavanton 6.1. mqueue.get_size 6.2. mqueue.fetch + 6.3. mqueue.get_sizes List of Examples @@ -67,6 +68,7 @@ Julien Chavanton 1.6. mq_size usage 1.7. mqueue.get_size usage 1.8. mqueue.fetch usage + 1.9. mqueue.get_sizes usage Chapter 1. Admin Guide @@ -95,6 +97,7 @@ Chapter 1. Admin Guide 6.1. mqueue.get_size 6.2. mqueue.fetch + 6.3. mqueue.get_sizes 1. Overview @@ -248,6 +251,7 @@ xlog("L_INFO", "Size of queue is: $var(q_size)\n"); 6.1. mqueue.get_size 6.2. mqueue.fetch + 6.3. mqueue.get_sizes 6.1. mqueue.get_size @@ -272,3 +276,14 @@ kamcmd mqueue.get_size xyz ... kamcmd mqueue.fetch xyz ... + +6.3. mqueue.get_sizes + + Get the size for all memory queues. + + Parameters: none + + Example 1.9. mqueue.get_sizes usage +... +kamcmd mqueue.get_sizes +...

1 0

[kamailio/kamailio] mqueue: RPC features (#2514)
by Alex Hermann 20 Oct '20

20 Oct '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - Add RPC to fetch all queue sizes at once (mqueue.sizes) - Proper HTTP response for client errors (4xx instead of 500) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2514 -- Commit Summary -- * mqueue: Use HTTP status codes for rpc * mqueue: Add rpc mqueue.sizes -- File Changes -- M src/modules/mqueue/doc/mqueue_admin.xml (18) M src/modules/mqueue/mqueue_api.c (3) M src/modules/mqueue/mqueue_api.h (1) M src/modules/mqueue/mqueue_mod.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2514.patch https://github.com/kamailio/kamailio/pull/2514.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2514

2 2

← Newer
1
...
22
23
24
25
26
27
28
...
53
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2020