sr-dev October 2020

sr-dev@lists.kamailio.org

19 participants
527 discussions

git:5.3:147fd7fc: core: parser - print lenghts in to header parsing debug message

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 147fd7fc5f3d2495b00961b407ca9aca38040a30 URL: https://github.com/kamailio/kamailio/commit/147fd7fc5f3d2495b00961b407ca9ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:30:08+02:00 core: parser - print lenghts in to header parsing debug message (cherry picked from commit 2648eb330b133a20f1398d59a28c53532106cad3) (cherry picked from commit 6e2bdf1056e3a31f1ca1f485473fcd26f9ccf044) --- Modified: src/core/parser/msg_parser.c --- Diff: https://github.com/kamailio/kamailio/commit/147fd7fc5f3d2495b00961b407ca9ac… Patch: https://github.com/kamailio/kamailio/commit/147fd7fc5f3d2495b00961b407ca9ac… --- diff --git a/src/core/parser/msg_parser.c b/src/core/parser/msg_parser.c index ca0bf789c5..bc5f77b10f 100644 --- a/src/core/parser/msg_parser.c +++ b/src/core/parser/msg_parser.c @@ -169,9 +169,9 @@ char* get_hdr_field(char* const buf, char* const end, struct hdr_field* const hd hdr->body.len=tmp-hdr->body.s; DBG("<%.*s> [%d]; uri=[%.*s]\n", hdr->name.len, ZSW(hdr->name.s), hdr->body.len, to_b->uri.len, ZSW(to_b->uri.s)); - DBG("to body [%.*s], to tag [%.*s]\n", to_b->body.len, - ZSW(to_b->body.s), to_b->tag_value.len, - ZSW(to_b->tag_value.s)); + DBG("to body (%d)[%.*s], to tag (%d)[%.*s]\n", to_b->body.len, + to_b->body.len, ZSW(to_b->body.s), to_b->tag_value.len, + to_b->tag_value.len, ZSW(to_b->tag_value.s)); break; case HDR_CONTENTLENGTH_T: hdr->body.s=tmp;

3 years, 9 months

git:5.3:5d5dd676: sanity: extended check 4 (required headers) for uniqueness

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 5d5dd676d299a27f14c6079b497cf1ae311909ce URL: https://github.com/kamailio/kamailio/commit/5d5dd676d299a27f14c6079b497cf1a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:29:57+02:00 sanity: extended check 4 (required headers) for uniqueness - Call-ID, CSeq, From and To have to be only once (cherry picked from commit a9ede56b35990fcc9164af0775f503e49e33377e) (cherry picked from commit 7adf410af754f1bb737edca6f427ef02d3441cda) --- Modified: src/modules/sanity/sanity.c --- Diff: https://github.com/kamailio/kamailio/commit/5d5dd676d299a27f14c6079b497cf1a… Patch: https://github.com/kamailio/kamailio/commit/5d5dd676d299a27f14c6079b497cf1a… --- diff --git a/src/modules/sanity/sanity.c b/src/modules/sanity/sanity.c index 04ad2b86d6..842d394194 100644 --- a/src/modules/sanity/sanity.c +++ b/src/modules/sanity/sanity.c @@ -299,8 +299,21 @@ int check_ruri_scheme(sip_msg_t* msg) { return SANITY_CHECK_PASSED; } +#define SANITY_HDR_DUPCHECK(_hf, _hdr_flags, _hdr_type, _hdr_flag, _hdr_name) \ + do { \ + if((_hf)->type == _hdr_type) { \ + if(_hdr_flags & _hdr_flag) { \ + LM_DBG("duplicated %s header\n", _hdr_name); \ + return SANITY_CHECK_FAILED; \ + } \ + _hdr_flags |= _hdr_flag; \ + } \ + } while(0) + /* check for the presence of the minimal required headers */ int check_required_headers(sip_msg_t* msg) { + hdr_field_t* hf; + hdr_flags_t hdr_flags = 0; LM_DBG("check_required_headers entered\n"); @@ -309,6 +322,20 @@ int check_required_headers(sip_msg_t* msg) { LM_DBG("check_required_headers failed\n"); return SANITY_CHECK_FAILED; } + if (parse_headers(msg, HDR_EOH_F, 0) != 0) { + LM_ERR("failed to parse headers\n"); + if (sanity_reply(msg, 400, "Bad Headers") < 0) { + LM_WARN("failed to send 400 reply\n"); + } + return SANITY_CHECK_FAILED; + } + for (hf=msg->headers; hf; hf=hf->next) { + SANITY_HDR_DUPCHECK(hf, hdr_flags, HDR_FROM_T, HDR_FROM_F, "From"); + SANITY_HDR_DUPCHECK(hf, hdr_flags, HDR_TO_T, HDR_TO_F, "To"); + SANITY_HDR_DUPCHECK(hf, hdr_flags, HDR_CALLID_T, HDR_CALLID_F, "Call-Id"); + SANITY_HDR_DUPCHECK(hf, hdr_flags, HDR_CSEQ_T, HDR_CSEQ_F, "CSeq"); + } + /* TODO: check for other required headers according to request type */ LM_DBG("check_required_headers passed\n");

3 years, 9 months

git:5.3:1cb4273a: dialog: do unlock after saving updated dialog details

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 1cb4273aa67c588552b671a98a9edb15471df129 URL: https://github.com/kamailio/kamailio/commit/1cb4273aa67c588552b671a98a9edb1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:29:42+02:00 dialog: do unlock after saving updated dialog details - lock()/unlock() for dialog slots are reentrant (cherry picked from commit e4cf6739e62c2ac1e5364315aaed1a7b73919253) (cherry picked from commit 73476522301b6de65b8873e4ab04041315e93a82) --- Modified: src/modules/dialog/dlg_var.c --- Diff: https://github.com/kamailio/kamailio/commit/1cb4273aa67c588552b671a98a9edb1… Patch: https://github.com/kamailio/kamailio/commit/1cb4273aa67c588552b671a98a9edb1… --- diff --git a/src/modules/dialog/dlg_var.c b/src/modules/dialog/dlg_var.c index fa9eae9d1f..b2a373a501 100644 --- a/src/modules/dialog/dlg_var.c +++ b/src/modules/dialog/dlg_var.c @@ -434,10 +434,11 @@ int pv_set_dlg_variable(struct sip_msg* msg, pv_param_t *param, int op, pv_value /* unlock dialog */ if (dlg) { dlg->dflags |= DLG_FLAG_CHANGED_VARS; - dlg_unlock(d_table, &(d_table->entries[dlg->h_entry])); - if ( dlg_db_mode==DB_MODE_REALTIME ) + if ( dlg_db_mode==DB_MODE_REALTIME ) { + /* dlg_lock() / dlg_unlock() are reentrant */ update_dialog_dbinfo(dlg); - + } + dlg_unlock(d_table, &(d_table->entries[dlg->h_entry])); } print_lists(dlg);

3 years, 9 months

git:5.4:a505f5eb: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.4 Commit: a505f5eb2bb60f935d3ecc55b0dfa1b410c1bb58 URL: https://github.com/kamailio/kamailio/commit/a505f5eb2bb60f935d3ecc55b0dfa1b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-10-12T10:31:20+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/nathelper/README Modified: src/modules/phonenum/README Modified: src/modules/topos/README --- Diff: https://github.com/kamailio/kamailio/commit/a505f5eb2bb60f935d3ecc55b0dfa1b… Patch: https://github.com/kamailio/kamailio/commit/a505f5eb2bb60f935d3ecc55b0dfa1b…

3 years, 9 months

[kamailio/kamailio] Adding KA-Roundtrip value from the usrloc module in the DB (#2501)

by iliesh

### Description Would be very handy to have all information from the KA function (KA-Roundtrip and Last-Keepalive values) in the DB location table as well in two separate columns. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2501

3 years, 9 months

git:5.4:eec7d261: rtpproxy: renamed extract_mediaip() to rp_extract_mediaip()

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: eec7d2613489613725b8979ce3d00d6616bb80c8 URL: https://github.com/kamailio/kamailio/commit/eec7d2613489613725b8979ce3d00d6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:13:59+02:00 rtpproxy: renamed extract_mediaip() to rp_extract_mediaip() - extract_mediaip() is also in core sdp parser (cherry picked from commit 8d0044770e94eaf7099eabbb55abe177e52e5373) --- Modified: src/modules/rtpproxy/rtpproxy.c --- Diff: https://github.com/kamailio/kamailio/commit/eec7d2613489613725b8979ce3d00d6… Patch: https://github.com/kamailio/kamailio/commit/eec7d2613489613725b8979ce3d00d6… --- diff --git a/src/modules/rtpproxy/rtpproxy.c b/src/modules/rtpproxy/rtpproxy.c index 8aef20019f..23c8357e4b 100644 --- a/src/modules/rtpproxy/rtpproxy.c +++ b/src/modules/rtpproxy/rtpproxy.c @@ -114,7 +114,7 @@ static str DEFAULT_RTPP_SET_ID_STR = str_init("0"); #define PTL_CPROTOVER "20081102" #define CPORT "22222" -static int extract_mediaip(str *, str *, int *, char *); +static int rp_extract_mediaip(str *, str *, int *, char *); static int alter_mediaip(struct sip_msg *, str *, str *, int, str *, int, int); static int alter_mediaport(struct sip_msg *, str *, str *, str *, int); static int alter_rtcp(struct sip_msg *msg, str *body, str *oldport, str *newport); @@ -958,7 +958,7 @@ replace_sdp_ip(struct sip_msg* msg, str *org_body, char *line, str *ip) } body1 = body; for(;;) { - if (extract_mediaip(&body1, &oldip, &pf,line) == -1) + if (rp_extract_mediaip(&body1, &oldip, &pf,line) == -1) break; if (pf != AF_INET) { LM_ERR("not an IPv4 address in '%s' SDP\n",line); @@ -988,7 +988,7 @@ replace_sdp_ip(struct sip_msg* msg, str *org_body, char *line, str *ip) } static int -extract_mediaip(str *body, str *mediaip, int *pf, char *line) +rp_extract_mediaip(str *body, str *mediaip, int *pf, char *line) { char *cp, *cp1; int len, nextisip;

3 years, 9 months

git:5.4:a989f384: nathelper: renamed extract_mediaip() to nh_extract_mediaip()

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: a989f384b5cb95e096e89899c57d8f11283b12cb URL: https://github.com/kamailio/kamailio/commit/a989f384b5cb95e096e89899c57d8f1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:13:25+02:00 nathelper: renamed extract_mediaip() to nh_extract_mediaip() - extract_mediaip() is also in core sdp parser (cherry picked from commit b0f239a2c16b71b8b7e7b325ea121ffc48afa78e) --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/a989f384b5cb95e096e89899c57d8f1… Patch: https://github.com/kamailio/kamailio/commit/a989f384b5cb95e096e89899c57d8f1… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 3a295e2067..12206ba152 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -116,7 +116,7 @@ static int pv_get_rr_count_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int pv_get_rr_top_count_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int fix_nated_sdp_f(struct sip_msg *, char *, char *); static int is_rfc1918_f(struct sip_msg *, char *, char *); -static int extract_mediaip(str *, str *, int *, char *, int); +static int nh_extract_mediaip(str *, str *, int *, char *, int); static int alter_mediaip(struct sip_msg *, str *, str *, int, str *, int, int); static int fix_nated_register_f(struct sip_msg *, char *, char *); static int fixup_fix_nated_register(void **param, int param_no); @@ -1631,7 +1631,7 @@ static inline int replace_sdp_ip( } body1 = body; for(;;) { - if(extract_mediaip(&body1, &oldip, &pf, line, linelen) == -1) + if(nh_extract_mediaip(&body1, &oldip, &pf, line, linelen) == -1) break; if(pf != AF_INET) { LM_ERR("not an IPv4 address in '%s' SDP\n", line); @@ -1786,7 +1786,8 @@ static int fix_nated_sdp_f(struct sip_msg *msg, char *str1, char *str2) return ki_fix_nated_sdp_ip(msg, level, &ip); } -static int extract_mediaip(str *body, str *mediaip, int *pf, char *line, int linelen) +static int nh_extract_mediaip(str *body, str *mediaip, int *pf, char *line, + int linelen) { char *cp, *cp1; int len, nextisip;

3 years, 9 months

git:5.4:d5393ffd: nathelper: docs - updated notes for fix_nated_sdp. few typos fixed [skip ci]

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: d5393ffd76cc37e98365d7b945454e0215d9f82f URL: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0… Author: Arsen Semenov <arsperger(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:13:11+02:00 nathelper: docs - updated notes for fix_nated_sdp. few typos fixed [skip ci] (cherry picked from commit 64579fee33d0a82a583b75184f78fcb7c9df2d82) --- Modified: src/modules/nathelper/doc/nathelper_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0… Patch: https://github.com/kamailio/kamailio/commit/d5393ffd76cc37e98365d7b945454e0… --- diff --git a/src/modules/nathelper/doc/nathelper_admin.xml b/src/modules/nathelper/doc/nathelper_admin.xml index c73baf21a4..6bf4783337 100644 --- a/src/modules/nathelper/doc/nathelper_admin.xml +++ b/src/modules/nathelper/doc/nathelper_admin.xml @@ -562,7 +562,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();}; <listitem> <para><emphasis>0x02</emphasis> - rewrite media &ip; address (c=) with source address of the message - or the provided IP address (the provide IP address take + or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take precedence over the source address).</para> </listitem> <listitem> @@ -572,7 +572,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();}; <listitem> <para><emphasis>0x08</emphasis> - rewrite IP from origin description (o=) with source address of the message - or the provided IP address (the provide IP address take + or the provided IP address. (a=rtpc) param will be rewritten if exists. (the provided IP address take precedence over the source address).</para> </listitem> </itemizedlist> @@ -582,7 +582,7 @@ if (search("User-Agent: Cisco ATA.*") {fix_nated_contact();}; If not specified, the received signalling IP will be used. The parameter allows pseudo-variables usage. NOTE: For the IP to be used, you need to use 0x02 or 0x08 flags, otherwise it will have - no effect. + no effect. Must be IPv4 address family. </para> </listitem> </itemizedlist>

3 years, 9 months

git:5.4:fd4dd363: nathelper: fix_nated_sdp added support for a=rtcp param RFC3605

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: fd4dd36319599867e590098d86dc37186595cfad URL: https://github.com/kamailio/kamailio/commit/fd4dd36319599867e590098d86dc371… Author: Arsen Semenov <arsperger(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:13:02+02:00 nathelper: fix_nated_sdp added support for a=rtcp param RFC3605 - GH #2459 (cherry picked from commit 088738ce16e73339e4c1b78c11f6ad6f8f3394cf) --- Modified: src/modules/nathelper/nathelper.c --- Diff: https://github.com/kamailio/kamailio/commit/fd4dd36319599867e590098d86dc371… Patch: https://github.com/kamailio/kamailio/commit/fd4dd36319599867e590098d86dc371… --- diff --git a/src/modules/nathelper/nathelper.c b/src/modules/nathelper/nathelper.c index 396e8b5323..3a295e2067 100644 --- a/src/modules/nathelper/nathelper.c +++ b/src/modules/nathelper/nathelper.c @@ -116,7 +116,7 @@ static int pv_get_rr_count_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int pv_get_rr_top_count_f(struct sip_msg *, pv_param_t *, pv_value_t *); static int fix_nated_sdp_f(struct sip_msg *, char *, char *); static int is_rfc1918_f(struct sip_msg *, char *, char *); -static int extract_mediaip(str *, str *, int *, char *); +static int extract_mediaip(str *, str *, int *, char *, int); static int alter_mediaip(struct sip_msg *, str *, str *, int, str *, int, int); static int fix_nated_register_f(struct sip_msg *, char *, char *); static int fixup_fix_nated_register(void **param, int param_no); @@ -1611,7 +1611,7 @@ static int is_rfc1918_f(struct sip_msg *msg, char *str1, char *str2) /* replace ip addresses in SDP and return umber of replacements */ static inline int replace_sdp_ip( - struct sip_msg *msg, str *org_body, char *line, str *ip) + struct sip_msg *msg, str *org_body, char *line, str *ip, int linelen) { str body1, oldip, newip; str body = *org_body; @@ -1631,7 +1631,7 @@ static inline int replace_sdp_ip( } body1 = body; for(;;) { - if(extract_mediaip(&body1, &oldip, &pf, line) == -1) + if(extract_mediaip(&body1, &oldip, &pf, line, linelen) == -1) break; if(pf != AF_INET) { LM_ERR("not an IPv4 address in '%s' SDP\n", line); @@ -1734,20 +1734,31 @@ static int ki_fix_nated_sdp_ip(sip_msg_t *msg, int level, str *ip) } } - if(level & FIX_MEDIP) { - /* Iterate all c= and replace ips in them. */ - ret = replace_sdp_ip(msg, &body, "c=", (ip && ip->len>0) ? ip : 0); - if(ret == -1) - return -1; - count += ret; - } + if(level & (FIX_MEDIP | FIX_ORGIP)) { - if(level & FIX_ORGIP) { - /* Iterate all o= and replace ips in them. */ - ret = replace_sdp_ip(msg, &body, "o=", (ip && ip->len>0) ? ip : 0); + /* Iterate all a=rtcp and replace ips in them. rfc3605 */ + ret = replace_sdp_ip(msg, &body, "a=rtcp", (ip && ip->len>0) ? ip : 0, 6); if(ret == -1) - return -1; - count += ret; + LM_DBG("a=rtcp parameter does not exist. nothing to do.\n"); + else + count += ret; + + if(level & FIX_MEDIP) { + /* Iterate all c= and replace ips in them. */ + ret = replace_sdp_ip(msg, &body, "c=", (ip && ip->len>0) ? ip : 0, 2); + if(ret == -1) + return -1; + count += ret; + } + + if(level & FIX_ORGIP) { + /* Iterate all o= and replace ips in them. */ + ret = replace_sdp_ip(msg, &body, "o=", (ip && ip->len>0) ? ip : 0, 2); + if(ret == -1) + return -1; + count += ret; + } + } return count > 0 ? 1 : 2; @@ -1775,22 +1786,22 @@ static int fix_nated_sdp_f(struct sip_msg *msg, char *str1, char *str2) return ki_fix_nated_sdp_ip(msg, level, &ip); } -static int extract_mediaip(str *body, str *mediaip, int *pf, char *line) +static int extract_mediaip(str *body, str *mediaip, int *pf, char *line, int linelen) { char *cp, *cp1; int len, nextisip; cp1 = NULL; for(cp = body->s; (len = body->s + body->len - cp) > 0;) { - cp1 = ser_memmem(cp, line, len, 2); + cp1 = ser_memmem(cp, line, len, linelen); if(cp1 == NULL || cp1[-1] == '\n' || cp1[-1] == '\r') break; - cp = cp1 + 2; + cp = cp1 + linelen; } if(cp1 == NULL) return -1; - mediaip->s = cp1 + 2; + mediaip->s = cp1 + linelen; mediaip->len = eat_line(mediaip->s, body->s + body->len - mediaip->s) - mediaip->s; trim_len(mediaip->len, mediaip->s, *mediaip);

3 years, 9 months

git:5.4:755867b9: phonenum: note about the role of country code name for phonenum_match_cn()

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: 755867b920e4e0d17a4bdf447a0d59a06875f8e1 URL: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-10-12T10:11:45+02:00 phonenum: note about the role of country code name for phonenum_match_cn() (cherry picked from commit dfd6c3966ed70d111a9196076bc29767c395d814) --- Modified: src/modules/phonenum/doc/phonenum_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a… Patch: https://github.com/kamailio/kamailio/commit/755867b920e4e0d17a4bdf447a0d59a… --- diff --git a/src/modules/phonenum/doc/phonenum_admin.xml b/src/modules/phonenum/doc/phonenum_admin.xml index d30c2026ee..f3a3e98ede 100644 --- a/src/modules/phonenum/doc/phonenum_admin.xml +++ b/src/modules/phonenum/doc/phonenum_admin.xml @@ -156,6 +156,14 @@ if(phonenum_match("1-484-555-8888", "src")) { (two letter, e.g: "DE", "US", "ES"). The function has to be called before accessing a key via: $phn(pvc=>key). </para> + <para> + Note from libphonenumber library docs: country name code is the region + that is expected the number to be from. It is only used if the number + being parsed is not written in international format. The country code + for the number in this case would be stored as that of the region + supplied. If the number is guaranteed to start with a '+' followed + by the country calling code, then region 'ZZ'. + </para> <para> The parameters can be static strings or strings with variables. </para>

3 years, 9 months

← Newer
1
...
32
33
34
35
36
37
38
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2020