sr-dev November 2020

sr-dev@lists.kamailio.org

22 participants
312 discussions

git:master:8ab72a37: http_async_client: add http_time pseudovariable

by Federico Cabiddu

Module: kamailio Branch: master Commit: 8ab72a37565bbec503d825f48774a0627014f665 URL: https://github.com/kamailio/kamailio/commit/8ab72a37565bbec503d825f48774a06… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2020-11-19T10:34:13+01:00 http_async_client: add http_time pseudovariable --- Modified: src/modules/http_async_client/async_http.c Modified: src/modules/http_async_client/async_http.h Modified: src/modules/http_async_client/doc/http_async_client_admin.xml Modified: src/modules/http_async_client/hm_hash.h Modified: src/modules/http_async_client/http_async_client_mod.c Modified: src/modules/http_async_client/http_multi.c --- Diff: https://github.com/kamailio/kamailio/commit/8ab72a37565bbec503d825f48774a06… Patch: https://github.com/kamailio/kamailio/commit/8ab72a37565bbec503d825f48774a06…

4 years

git:master:b7b33ad1: pkg: fix debian lintian error after kamailio scripts changed to python3

by Henning Westerholt

Module: kamailio Branch: master Commit: b7b33ad13942a7f0ef48ed9487541cd418f137f6 URL: https://github.com/kamailio/kamailio/commit/b7b33ad13942a7f0ef48ed9487541cd… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-11-19T07:07:35Z pkg: fix debian lintian error after kamailio scripts changed to python3 --- Modified: pkg/kamailio/deb/bionic/control Modified: pkg/kamailio/deb/buster/control Modified: pkg/kamailio/deb/debian/control Modified: pkg/kamailio/deb/focal/control Modified: pkg/kamailio/deb/jessie/control Modified: pkg/kamailio/deb/precise/control Modified: pkg/kamailio/deb/sid/control Modified: pkg/kamailio/deb/stretch/control Modified: pkg/kamailio/deb/trusty/control Modified: pkg/kamailio/deb/wheezy/control Modified: pkg/kamailio/deb/xenial/control --- Diff: https://github.com/kamailio/kamailio/commit/b7b33ad13942a7f0ef48ed9487541cd… Patch: https://github.com/kamailio/kamailio/commit/b7b33ad13942a7f0ef48ed9487541cd… --- diff --git a/pkg/kamailio/deb/bionic/control b/pkg/kamailio/deb/bionic/control index dfe684cda3..457a4671ea 100644 --- a/pkg/kamailio/deb/bionic/control +++ b/pkg/kamailio/deb/bionic/control @@ -71,7 +71,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/buster/control b/pkg/kamailio/deb/buster/control index dfe684cda3..457a4671ea 100644 --- a/pkg/kamailio/deb/buster/control +++ b/pkg/kamailio/deb/buster/control @@ -71,7 +71,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/debian/control b/pkg/kamailio/deb/debian/control index 52957ddabc..62719f61c6 100644 --- a/pkg/kamailio/deb/debian/control +++ b/pkg/kamailio/deb/debian/control @@ -74,7 +74,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/focal/control b/pkg/kamailio/deb/focal/control index dfe684cda3..457a4671ea 100644 --- a/pkg/kamailio/deb/focal/control +++ b/pkg/kamailio/deb/focal/control @@ -71,7 +71,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/jessie/control b/pkg/kamailio/deb/jessie/control index f4ea235b3b..ddfe38a40c 100644 --- a/pkg/kamailio/deb/jessie/control +++ b/pkg/kamailio/deb/jessie/control @@ -70,7 +70,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/precise/control b/pkg/kamailio/deb/precise/control index fec8c75984..5d5dabc02b 100644 --- a/pkg/kamailio/deb/precise/control +++ b/pkg/kamailio/deb/precise/control @@ -61,7 +61,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/sid/control b/pkg/kamailio/deb/sid/control index dfe684cda3..457a4671ea 100644 --- a/pkg/kamailio/deb/sid/control +++ b/pkg/kamailio/deb/sid/control @@ -71,7 +71,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/stretch/control b/pkg/kamailio/deb/stretch/control index 69d071586b..55c32d2230 100644 --- a/pkg/kamailio/deb/stretch/control +++ b/pkg/kamailio/deb/stretch/control @@ -73,7 +73,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/trusty/control b/pkg/kamailio/deb/trusty/control index 213c83989a..954ca2b6fb 100644 --- a/pkg/kamailio/deb/trusty/control +++ b/pkg/kamailio/deb/trusty/control @@ -65,7 +65,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/wheezy/control b/pkg/kamailio/deb/wheezy/control index fec8c75984..5d5dabc02b 100644 --- a/pkg/kamailio/deb/wheezy/control +++ b/pkg/kamailio/deb/wheezy/control @@ -61,7 +61,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces: diff --git a/pkg/kamailio/deb/xenial/control b/pkg/kamailio/deb/xenial/control index 0bd5a2a845..5635f2daac 100644 --- a/pkg/kamailio/deb/xenial/control +++ b/pkg/kamailio/deb/xenial/control @@ -76,7 +76,7 @@ Pre-Depends: Depends: adduser, lsb-base, - python, + python3, ${misc:Depends}, ${shlibs:Depends}, Replaces:

4 years

[kamailio/kamailio] jansson: Fix another case of inverse boolean logic (#2555)

by Alex Hermann

Copy-pasto from before the other fix. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2555 -- Commit Summary -- * jansson: Fix another case of inverse boolean logic -- File Changes -- M src/modules/jansson/jansson_utils.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2555.patch https://github.com/kamailio/kamailio/pull/2555.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2555

4 years

git:master:526873c7: jansson: Fix another case of inverse boolean logic

by Henning Westerholt

Module: kamailio Branch: master Commit: 526873c70ac3860638107a74ac50ed6028319bc8 URL: https://github.com/kamailio/kamailio/commit/526873c70ac3860638107a74ac50ed6… Author: Alex Hermann <alex(a)hexla.nl> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-11-19T07:54:01+01:00 jansson: Fix another case of inverse boolean logic Copy-pasto from before the other fix. --- Modified: src/modules/jansson/jansson_utils.c --- Diff: https://github.com/kamailio/kamailio/commit/526873c70ac3860638107a74ac50ed6… Patch: https://github.com/kamailio/kamailio/commit/526873c70ac3860638107a74ac50ed6… --- diff --git a/src/modules/jansson/jansson_utils.c b/src/modules/jansson/jansson_utils.c index 14b4b82c25..db1ab43b07 100644 --- a/src/modules/jansson/jansson_utils.c +++ b/src/modules/jansson/jansson_utils.c @@ -97,7 +97,7 @@ int jansson_to_xval(sr_xval_t *val, char** freeme, json_t* v) { val->v.s.len = strlen(value); }else if(json_is_boolean(v)) { val->type = SR_XTYPE_INT; - val->v.i = json_is_true(v) ? 0 : 1; + val->v.i = json_is_true(v) ? 1 : 0; }else if(json_is_real(v)) { char* value = NULL; if(asprintf(&value, "%.15g", json_real_value(v))<0) {

4 years

[kamailio/kamailio] topos module seems to break re-SUBSCRIBE routing to downstream destinations (#1724)

by George Diamantopoulos

### Description Kamailio seems to fail to properly route in-dialog SUBSCRIBE with the topos module enabled. In this configuration, SUBSCRIBEs are expected to be delivered to a downstream UAS, an asterisk instance in the internal network. record_route() is executed for all initial requests, including SUBSCRIBEs. Routing is performed correctly with the topos module disabled, no other modifications were needed.  ### Troubleshooting I haven't been able to work around this issue in any other way other than disabling the topos module. #### Reproduction The configuration used is a heavily modified version of the example configuration file, but the handling of SUBSCRIBEs is generally simple. The initial SUBSCRIBE is subject to some tests, the R-URI is edited and dispatched to a farm of asterisk servers based on some criteria. Record Routing is enforced, so subsequent in-dialog re-SUBSCRIBEs are expected to be routed with loose_route(), which doesn't seem to handle things properly.  #### Debugging Data I'm attaching kamailio logs with debug=4, cfg_trace  #### Log Messages See attachments  #### SIP Traffic Please see: https://www.cloudshark.org/captures/d2643aae7f2a  ### Possible Solutions Using topoh instead for topos, but unfortunately this will break communication for other reasons (messages too large/UDP fragmentation for some peers). ### Additional Information * **Kamailio Version** Tried with kamailio 5.1.6 and kamailio 5.3.0-dev0 deb.kamailio.org repositories were used to acquire binaries for both versions * **Operating System**: Debian Stretch  [resubscribe.log](https://github.com/kamailio/kamailio/files/2586440/resubsc… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1724

4 years

[kamailio/kamailio] uri_restore_rcv_alias() tried twice for local request (#2014)

by Alex Hermann

### Description While debugging an issue with locally generated in-dialog requests I stumbled upon some weirdness with the alias functionality from the nathelper module. The dialog modules tries to handle an alias parameter when sending an in-dialog request by calling ```uri_restore_rcv_alias()``` in the function ```build_dlg_t()```. A few instructions later, the same is attempted by the tm module in the function ```req_within()```. It seems to me that the attempt by the dialog module is redundant and can be removed. And while at it, IMHO it should be removed from the tm module too. This is functionality introduced by the nathelper module. Nowhere in the documentation it is mentioned there is some automatic handling of the alias parameter. If handling is needed for local requests, the script writer can call ```handle_uri_alias()``` from within local_route. If the functionality has to stay, may I suggest that the code in the nathelper module makes use of the ```uri_restore_rcv_alias()``` function instead of having its own duplicate implementation. Less maintenance, easier debugging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2014

4 years

[kamailio/kamailio] rtpengine: stats for rtpengine command and reply from rtpengine (#1699)

by Surendra Tiwari

### Description rightnow, there is no stats about command sent to rtpengine and getting reply from rtpengine. There should be a stats that will tell that number of offer request sent: number of answer request sent: number of delete request sent: number of failed request for offer [after retry]: number of failed request for answer [after retry]: number of failed request for delete [after retry]: This will help to identify actual number of failed request.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1699

4 years

[kamailio/kamailio] 100% CPU usage after NTP date update (#2046)

by Benjamin Marty

#### Reproduction Install newest Kamailio 5.2. Change date e.g. 2 Years into the future. (Make sure you have no daemon running which prohibits those operations): ``` sudo date -s "2014-12-25 $(date +%H:%M:%S)" ``` ``` sudo date -s "2016-12-25 $(date +%H:%M:%S)" ``` Kamailio now uses the whole CPU to do stuff: ``` top - 08:10:35 up 14 days, 1:29, 2 users, load average: 3.77, 1.83, 1.05 Tasks: 212 total, 11 running, 201 sleeping, 0 stopped, 0 zombie %Cpu(s): 95.9 us, 1.5 sy, 2.2 ni, 0.0 id, 0.0 wa, 0.0 hi, 0.4 si, 0.0 st MiB Mem : 926.1 total, 116.3 free, 382.5 used, 427.3 buff/cache MiB Swap: 100.0 total, 40.4 free, 59.6 used. 423.4 avail Mem PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 13264 root 20 0 89720 3944 2676 R 44.9 0.4 0:05.15 kamailio 13266 root 20 0 89720 4000 2736 R 37.3 0.4 0:04.63 kamailio 13267 root 20 0 89720 4912 3488 R 36.0 0.5 0:04.37 kamailio 13270 root 20 0 89720 4540 3240 R 36.0 0.5 0:05.85 kamailio 13269 root 20 0 89720 4000 2736 R 34.7 0.4 0:04.81 kamailio 13265 root 20 0 89720 3944 2680 R 34.4 0.4 0:04.61 kamailio 13261 root 20 0 89720 3952 2676 R 32.2 0.4 0:04.44 kamailio 13262 root 20 0 89720 3944 2676 R 31.8 0.4 0:04.72 kamailio 13256 root 20 0 89720 4752 3540 R 30.3 0.5 0:07.04 kamailio 13268 root 20 0 89720 4000 2736 R 30.3 0.4 0:04.49 kamailio 18021 root 20 0 40116 11884 5728 D 13.7 1.3 0:01.11 apt-get ``` There are multiple mailing list entries regarding this issue: https://lists.kamailio.org/pipermail/sr-users/2015-October/090465.html https://lists.kamailio.org/pipermail/sr-users/2015-November/090487.html https://lists.kamailio.org/pipermail/sr-users/2019-June/105967.html https://lists.kamailio.org/pipermail/sr-users/2019-August/106428.html I was able to get rid of the issue with uncommenting the mentioned part of the code. But I'm quite sure that's not a fix :) ![image](https://user-images.githubusercontent.com/11159719/63680341-b6d67880-c7f3-11e9-825b-529e7ec26b2e.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2046

4 years

[kamailio/kamailio] commit 0436af5abd8b73e breaks startup for jsonrpcs module (#2391)

by Henning Westerholt

The commit 0436af5abd8b73e breaks startup for jsonrpcs module. Logs: ``` Jul 5 10:04:41 kam01 kamailio[4951]: ERROR: jsonrpcs [jsonrpcs_sock.c:358]: jsonrpc_dgram_init_server(): failed to change the owner/group for /var/run/kamailio/kamailio_rpc.sock to 33.0;Operation not permitted[1] Jul 5 10:04:41 kam01 kamailio[4951]: CRITICAL: jsonrpcs [jsonrpcs_sock.c:423]: jsonrpc_dgram_init_socks(): initializing datagram server function returned error Jul 5 10:04:41 kam01 kamailio[4951]: ERROR: jsonrpcs [jsonrpcs_sock.c:246]: jsonrpc_dgram_mod_init(): init datagram sockets function failed Jul 5 10:04:41 kam01 kamailio[4951]: ERROR: jsonrpcs [jsonrpcs_mod.c:1150]: mod_init(): cannot initialize datagram transport Jul 5 10:04:41 kam01 kamailio[4951]: ERROR: <core> [core/sr_module.c:849]: init_mod(): Error while initializing module jsonrpcs (/usr/lib/x86_64-linux-gnu/kamailio/modules/jsonrpcs.so) ``` Relevant cfg: ``` loadmodule "jsonrpcs.so" modparam("jsonrpcs", "pretty_format", 1) modparam("jsonrpcs", "dgram_user", "www-data") modparam("jsonrpcs", "dgram_group", "root") modparam("jsonrpcs", "transport", 7) ``` Previously Kamailio was started as root, and then configured with -u $USER and -g $GROUP to drop privileges to the lower user/group. During startup Kamailio could create the socket with the correct permissions. The mentioned commit changes this to: start Kamailio directly as user Kamailio and group Kamailio, which don't have privileges create the sockets with the correct permissions. Not sure about the motivation about this change, so I don't want to simple revert it. Maybe @sergey-safarov or other developers can comment. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2391

4 years

git:master:3214ecd8: tm: print ruri mode in debug message from t load contacts

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3214ecd8ee82d1b69cde57d96dddefe1301c190c URL: https://github.com/kamailio/kamailio/commit/3214ecd8ee82d1b69cde57d96dddefe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-11-18T14:14:48+01:00 tm: print ruri mode in debug message from t load contacts --- Modified: src/modules/tm/t_serial.c --- Diff: https://github.com/kamailio/kamailio/commit/3214ecd8ee82d1b69cde57d96dddefe… Patch: https://github.com/kamailio/kamailio/commit/3214ecd8ee82d1b69cde57d96dddefe… --- diff --git a/src/modules/tm/t_serial.c b/src/modules/tm/t_serial.c index 13611cdb54..e7e9c8eedc 100644 --- a/src/modules/tm/t_serial.c +++ b/src/modules/tm/t_serial.c @@ -337,7 +337,7 @@ int ki_t_load_contacts_mode(struct sip_msg* msg, int mode) } /* Check if anything needs to be done */ - LM_DBG("nr_branches is %d\n", nr_branches); + LM_DBG("nr_branches is %d - new uri mode %d\n", nr_branches, ruri_is_new); if ((nr_branches == 0) || ((nr_branches == 1) && !ruri_is_new)) { LM_DBG("nothing to do - only one contact!\n");

4 years

← Newer
1
...
16
17
18
19
20
21
22
...
32
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2020