sr-dev February 2020

sr-dev@lists.kamailio.org

17 participants
324 discussions

[kamailio/kamailio] sanity: use debug log level when content length header is missing (#2211)

by Lasse Bang Mikkelsen

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description This is to align behavior with the remaining checks. The example configuration enable the content length sanity check and prior to this change would warn when SIP messages without body were received. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2211 -- Commit Summary -- * sanity: use debug log level when content length header is missing -- File Changes -- M src/modules/sanity/sanity.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2211.patch https://github.com/kamailio/kamailio/pull/2211.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2211

4 years, 9 months

git:5.3:b98bdc21: tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration)

by Henning Westerholt

Module: kamailio Branch: 5.3 Commit: b98bdc21dc495ca2f4babcc6a556b9c0dc63884a URL: https://github.com/kamailio/kamailio/commit/b98bdc21dc495ca2f4babcc6a556b9c… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-02-03T11:57:37+01:00 tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration) - use WARN log level for status rewrite by UAS (log level decreased before SER tm integration, e.g. v1.5.x) - for bad interconnection or gateways this might be reported frequently (cherry picked from commit e1a01699af450292859e4f2cd69b6a6d85246e5e) --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/b98bdc21dc495ca2f4babcc6a556b9c… Patch: https://github.com/kamailio/kamailio/commit/b98bdc21dc495ca2f4babcc6a556b9c… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 331bdbdf71..77747d34c0 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -1307,7 +1307,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, } /* this looks however how a very strange status rewrite attempt; * report on it */ - LM_ERR("status rewrite by UAS: stored: %d, received: %d\n", + LM_WARN("status rewrite by UAS: stored: %d, received: %d\n", Trans->uac[branch].last_received, new_code); goto discard; }

4 years, 9 months

git:5.2:b370041c: tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration)

by Henning Westerholt

Module: kamailio Branch: 5.2 Commit: b370041ccfd86e15812e1a06ad803569654eac07 URL: https://github.com/kamailio/kamailio/commit/b370041ccfd86e15812e1a06ad80356… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-02-03T11:57:07+01:00 tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration) - use WARN log level for status rewrite by UAS (log level decreased before SER tm integration, e.g. v1.5.x) - for bad interconnection or gateways this might be reported frequently (cherry picked from commit e1a01699af450292859e4f2cd69b6a6d85246e5e) --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/b370041ccfd86e15812e1a06ad80356… Patch: https://github.com/kamailio/kamailio/commit/b370041ccfd86e15812e1a06ad80356… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index d4ed5592ec..5840afd16f 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -1299,7 +1299,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, } /* this looks however how a very strange status rewrite attempt; * report on it */ - LM_ERR("status rewrite by UAS: stored: %d, received: %d\n", + LM_WARN("status rewrite by UAS: stored: %d, received: %d\n", Trans->uac[branch].last_received, new_code); goto discard; }

4 years, 9 months

git:master:e1a01699: tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration)

by Henning Westerholt

Module: kamailio Branch: master Commit: e1a01699af450292859e4f2cd69b6a6d85246e5e URL: https://github.com/kamailio/kamailio/commit/e1a01699af450292859e4f2cd69b6a6… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-02-03T11:53:55+01:00 tm: use WARN log level for status rewrite by UAS (were decreased before SER tm integration) - use WARN log level for status rewrite by UAS (log level decreased before SER tm integration, e.g. v1.5.x) - for bad interconnection or gateways this might be reported frequently --- Modified: src/modules/tm/t_reply.c --- Diff: https://github.com/kamailio/kamailio/commit/e1a01699af450292859e4f2cd69b6a6… Patch: https://github.com/kamailio/kamailio/commit/e1a01699af450292859e4f2cd69b6a6… --- diff --git a/src/modules/tm/t_reply.c b/src/modules/tm/t_reply.c index 331bdbdf71..77747d34c0 100644 --- a/src/modules/tm/t_reply.c +++ b/src/modules/tm/t_reply.c @@ -1307,7 +1307,7 @@ static enum rps t_should_relay_response( struct cell *Trans , int new_code, } /* this looks however how a very strange status rewrite attempt; * report on it */ - LM_ERR("status rewrite by UAS: stored: %d, received: %d\n", + LM_WARN("status rewrite by UAS: stored: %d, received: %d\n", Trans->uac[branch].last_received, new_code); goto discard; }

4 years, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2020