March 2020 - sr-dev - kamailio.org

[kamailio/kamailio] cfgt: doesn't support tm_suspend() tm_continue() (#684)
by Victor Seva 23 Jan '24

23 Jan '24

Actual implementation doesn't work with async. Need to investigate how to support it --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/684

3 8

[kamailio/kamailio] dialog: failover database loading behaviour in shared DB scenario, expiration of dialogs (#2080)
by Henning Westerholt 20 Jan '24

20 Jan '24

The dialog module will expire dialogs that don't actually belong to the particular proxy. Scenario: 2 proxies on 5.2.4 with a loadbalancer in front. Call was routed over proxy1, dialog timeout on proxy2 was shorter (to make it easier to reproduce it). The results: * Dialog synchronized with DMQ: proxy 2 would timeout the dialog * Dialog entry synchronized to proxy2 DB and proxy2 restarted: Proxy2 would timeout the dialog * Dialog entry synchronized to proxy2 DB and proxy2 not restarted: Proxy2 would _not_ timeout the dialog (I’ve tried both db_mode 1 and 2) So the proxy2 would load the dialog into memory and then later expire it. So timeout routes, send_bye on timeout would not work correctly. One idea to solve this would be to check e.g. over the existing socket data if the dialog belongs to this proxy and skip loading it in this case. This could be also made configurable e.g. with a module parameter. Any comments? Better ideas how to solve it? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2080

5 9

[kamailio/kamailio] core/cfg has memory leak if string value is set (#2094)
by Bastian Triller 17 Jan '24

17 Jan '24

### Description Setting string values via `cfg_rpc` leaves old strings in SHM. #### Reproduction  Set some string value to e.g. `tm.ac_extra_hdrs`: ```shell x=10 while [ $x -gt 0 ] ; do sudo kamctl rpc cfg.sets tm ac_extra_hdrs das$x >/dev/null sleep 0.001 x=$((x - 1)) done ``` #### Debugging Data After running above snippet four times: ``` sudo kamcmd cfg.set_now_int core mem_dump_shm 1 grep "^Oct 4 15:11:4.* qm_status:.*alloc'd" /var/log/syslog | cut -d: -f6- | sort | uniq -c | sort -n | grep core/cfg/cfg 1 alloc'd from core: core/cfg/cfg_struct.c: cfg_shmize(217) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(322) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(334) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(346) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(353) 1 alloc'd from core: core/cfg/cfg_struct.c: sr_cfg_init(360) 2 alloc'd from core: core/cfg/cfg_ctx.c: cfg_register_ctx(47) 3 alloc'd from core: core/cfg/cfg_struct.c: cfg_clone_global(625) 39 alloc'd from core: core/cfg/cfg_ctx.c: cfg_set_now(559) 40 alloc'd from core: core/cfg/cfg_struct.c: cfg_child_cb_new(828) 42 alloc'd from core: core/cfg/cfg_struct.c: cfg_clone_str(130) sudo kamcmd mod.stats core shm|grep \\bcfg_ cfg_clone_global(625): 1392 cfg_set_now(559): 624 cfg_clone_str(130): 384 cfg_shmize(217): 696 cfg_register_ctx(47): 64 cfg_child_cb_new(828): 2560 ``` memory values from cfg_clone_str addresses: ``` grep -B1 'Oct 4 15:11:4.*cfg_clone_str' /var/log/syslog|sed '/address=/!d' | cut -d: -f6- 55. N address=0x7f1310eab7f8 frag=0x7f1310eab7c0 size=40 used=1 56. N address=0x7f1310eab888 frag=0x7f1310eab850 size=24 used=1 62. N address=0x7f1310ec7b10 frag=0x7f1310ec7ad8 size=8 used=1 65. N address=0x7f1310ec7ca0 frag=0x7f1310ec7c68 size=8 used=1 68. N address=0x7f1310ec7e30 frag=0x7f1310ec7df8 size=8 used=1 69. N address=0x7f1310ec7ea0 frag=0x7f1310ec7e68 size=8 used=1 72. N address=0x7f1310ec8030 frag=0x7f1310ec7ff8 size=8 used=1 75. N address=0x7f1310ec81c0 frag=0x7f1310ec8188 size=8 used=1 78. N address=0x7f1310ec8350 frag=0x7f1310ec8318 size=8 used=1 81. N address=0x7f1310ec84e0 frag=0x7f1310ec84a8 size=8 used=1 84. N address=0x7f1310ec8670 frag=0x7f1310ec8638 size=8 used=1 87. N address=0x7f1310ec8800 frag=0x7f1310ec87c8 size=8 used=1 90. N address=0x7f1310ec8990 frag=0x7f1310ec8958 size=8 used=1 93. N address=0x7f1310ec8b20 frag=0x7f1310ec8ae8 size=8 used=1 96. N address=0x7f1310ec8cb0 frag=0x7f1310ec8c78 size=8 used=1 99. N address=0x7f1310ec8e40 frag=0x7f1310ec8e08 size=8 used=1 103. N address=0x7f1310ec92f0 frag=0x7f1310ec92b8 size=8 used=1 106. N address=0x7f1310ec9480 frag=0x7f1310ec9448 size=8 used=1 109. N address=0x7f1310ec9610 frag=0x7f1310ec95d8 size=8 used=1 112. N address=0x7f1310ec97a0 frag=0x7f1310ec9768 size=8 used=1 115. N address=0x7f1310ec9930 frag=0x7f1310ec98f8 size=8 used=1 118. N address=0x7f1310ec9ac0 frag=0x7f1310ec9a88 size=8 used=1 121. N address=0x7f1310ec9c50 frag=0x7f1310ec9c18 size=8 used=1 124. N address=0x7f1310ec9de0 frag=0x7f1310ec9da8 size=8 used=1 127. N address=0x7f1310ec9f70 frag=0x7f1310ec9f38 size=8 used=1 131. N address=0x7f1310eca420 frag=0x7f1310eca3e8 size=8 used=1 134. N address=0x7f1310eca5b0 frag=0x7f1310eca578 size=8 used=1 137. N address=0x7f1310eca740 frag=0x7f1310eca708 size=8 used=1 140. N address=0x7f1310eca8d0 frag=0x7f1310eca898 size=8 used=1 144. N address=0x7f1310ecad80 frag=0x7f1310ecad48 size=8 used=1 147. N address=0x7f1310ecaf10 frag=0x7f1310ecaed8 size=8 used=1 150. N address=0x7f1310ecb0a0 frag=0x7f1310ecb068 size=8 used=1 153. N address=0x7f1310ecb230 frag=0x7f1310ecb1f8 size=8 used=1 156. N address=0x7f1310ecb3c0 frag=0x7f1310ecb388 size=8 used=1 159. N address=0x7f1310ecb550 frag=0x7f1310ecb518 size=8 used=1 162. N address=0x7f1310ecb6e0 frag=0x7f1310ecb6a8 size=8 used=1 165. N address=0x7f1310ecb870 frag=0x7f1310ecb838 size=8 used=1 168. N address=0x7f1310ecba00 frag=0x7f1310ecb9c8 size=8 used=1 172. N address=0x7f1310ecbeb0 frag=0x7f1310ecbe78 size=8 used=1 175. N address=0x7f1310ecc040 frag=0x7f1310ecc008 size=8 used=1 178. N address=0x7f1310ecc1d0 frag=0x7f1310ecc198 size=8 used=1 181. N address=0x7f1310ecc360 frag=0x7f1310ecc328 size=8 used=1 0x7f1310eab7f8: "trying -- your call is important to us" 0x7f1310eab888: "Server Internal Error" 0x7f1310ec7b10: "das10" 0x7f1310ec7ca0: "das9" 0x7f1310ec7e30: "das10" 0x7f1310ec7ea0: "das10" 0x7f1310ec8030: "das9" 0x7f1310ec81c0: "das9" 0x7f1310ec8350: "das8" 0x7f1310ec84e0: "das7" 0x7f1310ec8670: "das6" 0x7f1310ec8800: "das5" 0x7f1310ec8990: "das4" 0x7f1310ec8b20: "das3" 0x7f1310ec8cb0: "das2" 0x7f1310ec8e40: "das1" 0x7f1310ec92f0: "das10" 0x7f1310ec9480: "das9" 0x7f1310ec9610: "das8" 0x7f1310ec97a0: "das7" 0x7f1310ec9930: "das6" 0x7f1310ec9ac0: "das5" 0x7f1310ec9c50: "das4" 0x7f1310ec9de0: "das3" 0x7f1310ec9f70: "das2" 0x7f1310eca420: "das1" 0x7f1310eca5b0: "das8" 0x7f1310eca740: "das7" 0x7f1310eca8d0: "das6" 0x7f1310ecad80: "das5" 0x7f1310ecaf10: "das4" 0x7f1310ecb0a0: "das3" 0x7f1310ecb230: "das2" 0x7f1310ecb3c0: "das1" 0x7f1310ecb550: "das8" 0x7f1310ecb6e0: "das7" 0x7f1310ecb870: "das6" 0x7f1310ecba00: "das5" 0x7f1310ecbeb0: "das4" 0x7f1310ecc040: "das3" 0x7f1310ecc1d0: "das2" 0x7f1310ecc360: "das1" ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` /usr/sbin/kamailio -v version: kamailio 5.2.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: ``` Debian 9.11 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2094

5 13

[kamailio/kamailio] dmq_usrloc not replicating contact attributes (#1968)
by pwakano 16 Jan '24

16 Jan '24

### Description  The dmq_usrloc module is not replicating the extra attributes saved in the xavp for the contact. So remote nodes don't receive these values, being unable to access it properly. It is expected that the attributes are replicated as well. #### Reproduction  Setup two nodes using the dmq_usrloc and usrloc in db_mode=0. When receiving a REGISTER, before saving the contact add some attribute in the xavp_contact. In a subsequent message to this contact (e.g.: INVITE) use a lookup() or registered() and try to access the desired xavp_contact attribute. If the request is received in the local node (which received the original REGISTER), the attribute will be valid, but if the request is received in the remote node, the attribute is empty. #### Log Messages  ``` May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: registrar [save.c:410]: pack_ci(): generated ruid is: uloc-5cee2114-5abe-2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:73]: ucontact_xavp_store(): trying to clone per contact xavps May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:697]: xavp_clone_level_nodata(): cloned root xavp [ulattrs] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: <core> [core/xavp.c:721]: xavp_clone_level_nodata(): cloned inner xavp [cluster_node] May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ucontact.c:1701]: update_ucontact(): exists callback for type= UL_CONTACT_UPDATE May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: usrloc [ul_callback.h:84]: run_ul_callbacks(): contact=0x7f51b624d418, callback type 2/15, id 1 entered May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:776]: dmq_ul_cb_contact(): Callback from usrloc with type=2 May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:427]: init_usrloc_dmq_recv(): Initializing usrloc_dmq_recv for pid (23230) May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:785]: dmq_ul_cb_contact(): Replicating local update to other nodes... May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:746]: usrloc_dmq_send_contact(): sending serialized data {"action":1,"aor":"345671002","ruid":"uloc-5cee20df-5953-1","c":"sip:345671002@172.28.128.200:5060;rinstance=38e53fed7e84e081;transport=UDP","received":"","path":"<sip:172.28.128.102:5060;received=sip:172.28.128.200:5060;lr>","callid":"NOeeFh1Bh5JR0eJG8DENkg..","user_agent":"Z 3.15.40006 rv2.8.20","instance":"","expires":1559110577,"cseq":12,"flags":0,"cflags":3072,"q":-1,"last_modified":1559109977,"methods":4294967295,"reg_id":0,"server_id":0} May 29 16:06:18 kamailio-2 /usr/sbin/kamailio[23230]: DEBUG: dmq_usrloc [usrloc_sync.c:315]: usrloc_dmq_send(): sending dmq broadcast... ``` ### Possible Solutions  Only workaround seems to use usrloc with db_mode=3 and then not use the dmq_usrloc, having the usrloc with attributes info shared via the DB.... ### Additional Information Kamailio 5.2.2 installed from the repo. ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # cat /etc/centos-release CentOS Linux release 7.3.1611 (Core) # uname -a Linux kamailio-2 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1968

3 7

[kamailio/kamailio] Using PATH makes nathelper to send the SIP ping to itself (#2011)
by pwakano 13 Jan '24

13 Jan '24

### Description When using the PATH header option to keep track of original Kamailio node that received the REGISTER, if nathelper is also used with SIP ping enabled, the SIP OPTIONS is sent to itself following the PATH header and not sent directly to the destination. The nathelper/user location modules should have a flag similar to the "path_check_local" of the registrar module, which is meant to avoid looping the message to itself in case the next hop pointed by the PATH header is "myself".  ### Troubleshooting #### Reproduction Configure the registrar module to support PATH and before saving the contact info add the PATH header with the local Kamailio information. Also make sure to have the nathelper and usrloc modules configured to send the keepalive SIP OPTIONS to the registered extensions. By the time the SIP OPTIONS is sent, Kamailio sends to itself, then the message has to be loose_route'd to the final destination. This could be avoided by having the nathelper module to identify the next hop is Kamailio itself skipping this destination as a call to "lookup()" does for the registrar module when the flag path_check_local is true.  #### SIP Traffic  172.128.128.10 is the Kamailio IP and 172.128.128.20 is the extension IP ``` 11:51:07.224713 IP (tos 0x60, ttl 64, id 64497, offset 0, flags [none], proto UDP (17), length 518) 172.128.128.10.5060 > 172.128.128.10.5060: SIP, length: 490 OPTIONS sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP SIP/2.0 Via: SIP/2.0/UDP 172.128.128.10:5060;branch=z9hG4bK2540713 Route: <sip:172.128.128.10:5060;received=sip:172.128.128.20:5060;lr;cluster_node=192.168.156.10:5060> From: sip:sbc@mydomain.com;tag=uloc-5d2e6499-2fb5-1-0-c15309d2 To: sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP Call-ID: 40ee1573-7506bba3-5e30c05(a)172.128.128.10 CSeq: 1 OPTIONS Content-Length: 0 11:51:07.226132 IP (tos 0x60, ttl 64, id 44359, offset 0, flags [none], proto UDP (17), length 502) 172.128.128.10.5060 > 172.128.128.20.5060: SIP, length: 474 OPTIONS sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP SIP/2.0 Via: SIP/2.0/UDP 172.128.128.10;branch=z9hG4bKb958.b807e80b742db62504a45220d8f0e974.0 Via: SIP/2.0/UDP 172.128.128.10:5060;branch=z9hG4bK2540713 From: sip:sbc@mydomain.com;tag=uloc-5d2e6499-2fb5-1-0-c15309d2 To: sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP Call-ID: 40ee1573-7506bba3-5e30c05(a)172.128.128.10 CSeq: 1 OPTIONS Content-Length: 0 11:51:07.303474 IP (tos 0x0, ttl 128, id 10816, offset 0, flags [none], proto UDP (17), length 786) 172.128.128.20.5060 > 172.128.128.10.5060: SIP, length: 758 SIP/2.0 200 OK Via: SIP/2.0/UDP 172.128.128.10;branch=z9hG4bKb958.b807e80b742db62504a45220d8f0e974.0 Via: SIP/2.0/UDP 172.128.128.10:5060;branch=z9hG4bK2540713 Contact: <sip:172.128.128.20:5060> To: <sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP>;tag=bb0c1f2d From: sip:sbc@mydomain.com;tag=uloc-5d2e6499-2fb5-1-0-c15309d2 Call-ID: 40ee1573-7506bba3-5e30c05(a)172.128.128.10 CSeq: 1 OPTIONS Accept: application/sdp, application/sdp Accept-Language: en Allow: INVITE, ACK, CANCEL, BYE, NOTIFY, REFER, MESSAGE, OPTIONS, INFO, SUBSCRIBE Supported: replaces, norefersub, extended-refer, timer, outbound, path, X-cisco-serviceuri User-Agent: Z 3.15.40006 rv2.8.20 Allow-Events: presence, kpml, talk Content-Length: 0 11:51:07.306821 IP (tos 0x60, ttl 64, id 64570, offset 0, flags [none], proto UDP (17), length 727) 172.128.128.10.5060 > 172.128.128.10.5060: SIP, length: 699 SIP/2.0 200 OK Via: SIP/2.0/UDP 172.128.128.10:5060;branch=z9hG4bK2540713 Contact: <sip:172.128.128.20:5060;alias=172.128.128.20~5060~1> To: <sip:345671002@172.128.128.20:5060;rinstance=d1eb3444a5cec5a1;transport=UDP>;tag=bb0c1f2d From: sip:sbc@mydomain.com;tag=uloc-5d2e6499-2fb5-1-0-c15309d2 Call-ID: 40ee1573-7506bba3-5e30c05(a)172.128.128.10 CSeq: 1 OPTIONS Accept: application/sdp, application/sdp Accept-Language: en Allow: INVITE, ACK, CANCEL, BYE, NOTIFY, REFER, MESSAGE, OPTIONS, INFO, SUBSCRIBE Supported: replaces, norefersub, extended-refer, timer, outbound, path, X-cisco-serviceuri User-Agent: Z 3.15.40006 rv2.8.20 Allow-Events: presence, kpml, talk Content-Length: 0 ``` ### Possible Solutions  Not found. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # uname -a Linux kamailio-1 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2011

4 7

[kamailio/kamailio] unistr.h: No such file or directory (#2020)
by stefan.wen 12 Jan '24

12 Jan '24

### Description when i make websocket module: ws_frame.c:32:20: fatal error: unistr.h: No such file or directory #include <unistr.h> ^ compilation terminated. make: *** [ws_frame.o] Error 1 OS: centos7 and i try reinstall libunistring,Still failed -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2020

4 4

[kamailio/kamailio] lib: big integers should not be treated as negative ones (#2106)
by Ivan Murashko 08 Dec '23

08 Dec '23

0xffffffff00000000ULL mask does not take into consideration signed 32 bit integers and as result 2147483648 will be stored as -2147483648. Another mask should be used to correct the issue: 0xffffffff80000000ULL. It processes correctly the case of integers that are greater than 2147483647. There are several gdb tests below: (gdb) p ((unsigned long long)2147483648 & 0xffffffff80000000ULL) $1= 2147483648 (gdb) p ((unsigned long long)2147483647 & 0xffffffff80000000ULL) $2 = 0 (gdb) p ((unsigned long long)2147483646 & 0xffffffff80000000ULL) $3 = 0 (gdb) p ((unsigned long long)4147483646 & 0xffffffff80000000ULL) $4 = 2147483648   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2106 -- Commit Summary -- * lib: big integers should not be treated as negative ones -- File Changes -- M src/lib/srdb1/db_ut.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2106.patch https://github.com/kamailio/kamailio/pull/2106.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2106

4 6

[kamailio/kamailio] Presence module RPC command to dump active watchers from memory. (#2188)
by VolodyaIvanets 23 Nov '23

23 Nov '23

### Description Explain what you did, what you expected to happen, and what actually happened. I'm looking at using presence module with **subs_db_mode** parameter set to 0-2 where it uses memory to store and query active watchers. I noticed that sometimes Kamailio will throw following message during PUBLISH processesing and it will not generate appropriate NOTIFY for watchers: `DEBUG: presence [notify.c:1234]: publ_notify(): Could not find subs_dialog ` RPC command to dump current active watchers will be helpful during troubleshooting. Currently with **subs_db_mode** set to 0 you can not tell for sure if subsciption already expired or not. And with **subs_db_mode** set to 1 or 2 you can get information from DB with delay. This command will also allow to clarify subscriber _domain_ value which if I understood correctly must match domain from presentity. Thanks a lot! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2188

2 2

[kamailio/kamailio] ims_charging module not sending CCR Terminate Request to Diameter Server (#2129)
by harishyadav1465 23 Nov '23

23 Nov '23

Some times ims_charging module not sending ccr terminate request to Diameter Server upon receiving the BYE Request . **ISSUE Description:** 1 ) Consider User A registered with kamailio. 2 ) A called PSTN number ..Initial CCR request went to diameter server successfully. 3 ) PSTN number hangup the call....Here After BYE Transaction is done...Kamailio is generating a new BYE request to itself and it is retransmitting it four times. 4 ) I think this is the reason Ims_cahrging not generating ccr terminate request. **Please find below sip traces. [Proxy is : 7080 , gateway : 5060]** BYE sip:+xxxxxxxxxxxx@xxxxxxxxxxxx:35465 SIP/2.0 Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;branch=z9hG4bK05c0a4d6 Route: <sip:xxxxxxxxxxxx:7080;lr;transport=UDP;did=492.d7f1> Max-Forwards: 70 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: SM SoftSwitch 11-06C13 X-Asterisk-HangupCause: Normal Clearing X-Asterisk-HangupCauseCode: 16 Content-Length: 0 SIP/2.0 200 OK Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;rport=5060;branch=z9hG4bK05c0a4d6 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: Janus WebRTC Gateway SIP Plugin 0.0.6 Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, UPDATE Content-Length: 0 BYE sip:xxxxxxxxxxxx:7080;lr;transport=UDP;did=492.d7f1 SIP/2.0 Via: SIP/2.0/UDP xxxxxxxxxxxx:7080;branch=z9hG4bK461c.5003522650d9dbb33e47c6d83d7465b8.1 Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;rport=5060;branch=z9hG4bK05c0a4d6 Max-Forwards: 69 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: SM SoftSwitch 11-06C13 X-Asterisk-HangupCause: Normal Clearing X-Asterisk-HangupCauseCode: 16 Content-Length: 0 BYE sip:xxxxxxxxxxxx:7080;lr;transport=UDP;did=492.d7f1 SIP/2.0 Via: SIP/2.0/UDP xxxxxxxxxxxx:7080;branch=z9hG4bK461c.5003522650d9dbb33e47c6d83d7465b8.1 Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;rport=5060;branch=z9hG4bK05c0a4d6 Max-Forwards: 69 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: SM SoftSwitch 11-06C13 X-Asterisk-HangupCause: Normal Clearing X-Asterisk-HangupCauseCode: 16 Content-Length: 0 BYE sip:xxxxxxxxxxxx:7080;lr;transport=UDP;did=492.d7f1 SIP/2.0 Via: SIP/2.0/UDP xxxxxxxxxxxx:7080;branch=z9hG4bK461c.5003522650d9dbb33e47c6d83d7465b8.1 Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;rport=5060;branch=z9hG4bK05c0a4d6 Max-Forwards: 69 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: SM SoftSwitch 11-06C13 X-Asterisk-HangupCause: Normal Clearing X-Asterisk-HangupCauseCode: 16 Content-Length: 0 BYE sip:xxxxxxxxxxxx:7080;lr;transport=UDP;did=492.d7f1 SIP/2.0 Via: SIP/2.0/UDP xxxxxxxxxxxx:7080;branch=z9hG4bK461c.5003522650d9dbb33e47c6d83d7465b8.1 Via: SIP/2.0/UDP xxxxxxxxxxxx:5060;rport=5060;branch=z9hG4bK05c0a4d6 Max-Forwards: 69 From: <sip:xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=as4ab1ab4b To: "+xxxxxxxxxxxx" <sip:+xxxxxxxxxxxx@xxxxxxxxxxxx>;tag=8110a0S32NHgp Call-ID: 8fa995a0-061c-11ea-8d83-00505697042b CSeq: 102 BYE User-Agent: SM SoftSwitch 11-06C13 X-Asterisk-HangupCause: Normal Clearing X-Asterisk-HangupCauseCode: 16 Content-Length: 0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2129

2 2

[kamailio/kamailio] dialog and dmq in db_mode 2 - dialog_vars entries created and not deleted (#2093)
by Henning Westerholt 23 Nov '23

23 Nov '23

Dialog and DMQ in db_mode 2 - dialog_vars entries created and not deleted. Szenario: two proxies in DMQ synchronization with additional database. Configuration identical on both machines: ``` root@proxy-1:/etc/kamailio# grep dialog kamailio.cfg loadmodule "dialog.so" modparam("dialog", "db_mode", 2) modparam("dialog", "db_update_period", 10) modparam("dialog", "enable_dmq", 1) modparam("dialog", "default_timeout", 60); modparam("dialog", "send_bye", 1) ``` Call is placed on proxy1. Proxy1 handles the call, and synchronize the dialog data to proxy2. Proxy2 is able to list the dialog with kamcmd dlg.list etc.. Proxy2 will not write the dialog into dialog table, but will write the dialog variables to the dialog_var table: ``` root@proxy-2:/etc/kamailio# mysql kamailio MariaDB [kamailio]> select * from dialog; select * from dialog_vars; Empty set (0.00 sec) +----+------------+---------+-------------+---------------------------------+ | id | hash_entry | hash_id | dialog_key | dialog_value | +----+------------+---------+-------------+---------------------------------+ | 9 | 3479 | 1648 | _uac_fu | sip:customer-1@sip.XXXX.net | | 10 | 3479 | 1648 | _uac_funew | sip:batman@XXX.org | | 11 | 3479 | 1648 | _uac_fdp | | | 12 | 3479 | 1648 | _uac_fdpnew | | | 13 | 3479 | 1648 | _uac_to | sip:customer-2@sip.skalatan.net | | 14 | 3479 | 1648 | _uac_tonew | sip:robin@XXX.org | | 15 | 3479 | 1648 | _uac_tdp | | | 16 | 3479 | 1648 | _uac_tdpnew | | +----+------------+---------+-------------+---------------------------------+ 8 rows in set (0.00 sec) ``` Because of this the dialog_vars will grow for every call. In db_mode 1 this dialog_vars entries (and also dialog entries) are not written. I suggest to adapt db_mode 2 with DMQ to the same behaviour. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2093

3 4

[kamailio/kamailio] Kemi API xlog doesn't support log_facility configuration (#2064)
by adil-mafzool 23 Nov '23

23 Nov '23

### Description  ### Troubleshooting kamailio native config: - xlog("LOG_LOCAL2", "L_INFO", "REQUEST: transaction_id=$avp(tid);timestamp=$Ts;method=$rm;source_ip=$si;source_port=$sp;from_user=$fU;from_domain=$fd;to_user=$tU;to_domain=$td;request_user=$oU;request_domain=$od;"); python kemi config KSR.xlog.xlog( "LOG_LOCAL2", "L_INFO", "REQUEST: timestamp=$Ts;method=$rm;source_ip=$si;source_port=$sp;from_user=$fU;from_domain=$fd;to_user=$tU;to_domain=$td;request_user=$oU;request_domain=$od;") produced following errors: - ERROR: app_python [python_support.c:150]: python_handle_exception(): python_exec2: Unhandled exception in the Python code:#012TypeError: kemi-param-ss() takes exactly 2 arguments (3 given) #### Debugging Data  ``` N-A ``` #### Log Messages  ``` N-A ``` #### SIP Traffic  ``` N-A ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.8 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` Debian 9.5  ``` Linux routing-proxy-01 4.9.0-3-amd64 #1 SMP Debian 4.9.30-2+deb9u5 (2017-09-19) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2064

3 4

[kamailio/kamailio] CDP / IMS Diameter Server Module- diameter_request() function fails to send/forward request (#2035)
by Nick 23 Nov '23

23 Nov '23

Hi Kamailio team, I'm attempting to use Kamailio as a Diameter Routing Agent, but I can't seem to get the diameter_request() function to actually _send_ the diameter request, instead I get a warning about no JSON Response: > WARNING: ims_diameter_server [avp_helper.c:341]: addAVPsfromJSON(): No JSON Response Even when relaying received data without modifying it. I posted this issue on the mailing list but have had no responses. Since then I've run a bunch more tests on a few different versions of Kamailio with a few different Diameter peers with the same result. ### Description The IMS Diameter Server Module's[ diameter_request() function](https://www.kamailio.org/docs/modules/devel/modules/ims_diameter_… fails to send, reporting "No JSON Response" even when fed unmodified received data into it. ### Troubleshooting Initially I was trying to use CDP & IMS Diameter Server Module to create & send Diameter messages, I thought my formatting in the message (the Diameter Message (as JSON)) was incorrect. as I was getting: > WARNING: ims_diameter_server [avp_helper.c:341]: addAVPsfromJSON(): No JSON Response When trying to send the request. To rule out my JSON formatting being the issue I configured two Diameter Peers in Kamailio: >From one Diameter peer, I sent a Diameter request to Kamailio. Kamailio is configured to receive the Diameter request, and without modifying the message body ($diameter_request), put that message into the message of the the diameter_request() so as to rule out formatting errors in the message, just a relay of the message, but this also fails to send. I also included a series of checks to confirm the peer to receive the relayed message was online and capable of handling the specified Diameter application, all of which passed. I've defined the peers in the diametercfg.xml config file, and they're all showing as online when I do a "kamcmd cdp.list_peers": FQDN: ims-hss.localdomain Details: { State: I_Open Disabled: False Last used: 0 Applications: { appid:vendorid: 16777216:10415 appid:vendorid: 16777216:4491 appid:vendorid: 16777216:13019 appid:vendorid: 16777216:0 appid:vendorid: 16777217:10415 appid:vendorid: 16777221:10415 } } Here's a simplified version of my event_route[diameter:request], showing I simply receive the diameter request and then try to send it straight back out using the diameter_request() function: ``` event_route[diameter:request]{ xlog("Got diameter message"); diameter_request("ims-hss.localdomain", $diameter_application, $diameter_command, $diameter_request); xlog("Forwarded Diameter Request"); } ``` When tailing syslog I see the "Got diameter message" entry but not the "Forwarded Diameter Request", which suggests it's not getting past the diameter_request(), instead I just see the: > WARNING: ims_diameter_server [avp_helper.c:341]: addAVPsfromJSON(): No JSON Response Packet captures show Kamailio receives the request but never relays it. The source of avp_helper.c shows the warning is called if the length of the JSON is <= 0, but as I'm feeding back out what I've received it shouldn't be 0, an no recent major changes to the source, so I'm stumped as to why it's catching this. I've attached a full copy of the config files below. #### Reproduction I've tried this with a few different Diameter servers, but I can reproduce it with two FreeDIAMETER peers configured in Diameter CDP Config XML, I've also tried with one Kamailio CDP based peer and using xhttp to call the diameter_request() function with the same results. #### Log Messages Copy of relevant SysLog: https://pastebin.com/ZY8z2kd4 ### Additional Information Full Kamailio Config: https://pastebin.com/afgqUfWr Diameter CDP Config XML: https://pastebin.com/bVrBG8mG Relevant Syslog: https://pastebin.com/ZY8z2kd4 Kamcmd cdp.list_peers: https://pastebin.com/cKi4JAHC Kamailio 5.1.2 on Ubuntu 18.04 installed from Repos. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2035

5 11

[kamailio/kamailio] mod pua (dialoginfo) etag race conditions (#2048)
by Laszlo 23 Nov '23

23 Nov '23

I'm observing the following scenario: * mod_dialog callbacks trigger 2 or more times (nearly) simultaneously for the same dialog * pua_dialoginfo sends PUBLISH 1, referencing etag A * pua_dialoginfo sends PUBLISH 2, referencing etag A * presence_dialoginfo processes PUBLISH 1, replies with new etag B * presence_dialoginfo processes PUBLISH 2, replies with a 412 (because etag A no longer exists) * pua_dialoginfo receives the 412 and re-tries it as PUBLISH 3 ("sent a PUBLISH within a dialog that no longer exists, send again an intial PUBLISH") * presence_dialoginfo processes PUBLISH 3, and may or may not accept it The situation as described is not ideal since it'll fill up your logs with errors, but isn't critical per se. Much more problematic is when there are more than 2 PUBLISHes generated for the same dialog simultaneously, as this can cause a (near) infinite race between the various PUBLISH requests all fighting to update the same etag. For example, 10 PUBLISH are sent out for etag A; all but one are rejected with a 412; then the other 9 keep on bouncing back and forth between pua_dialoginfo and presence_dialoginfo because they do not share the same view on the dialog's latest etag. Even worse is when presence_dialoginfo is rejecting *all* incoming PUBLISHes with a 412, for example because of a database/memory/replication problem or a malformed request. A `t_reply("412", "Not today")` in the presence_dialoginfo server, combined with a single PUBLISH from pua_dialoginfo is enough to reproducibly brick the pua_dialoginfo server because it runs into critical memory fragmentation levels. I think there are multiple ways to fix or alleviate this problem. ## pua generic * pua (publ_cback_func) should not retry 412-failed PUBLISHes indefinitely, but e.g. at most once * pua should not generate simultaneous PUBLISHes for the same presentity. It should delay PUBLISH 2 until PUBLISH 1 is either (permanently) accepted or rejected; or it should discard PUBLISH 2 immediately when it is generated. * Perhaps make handling of 412 replies more fine-grained. Currently every 412 reply is handled like this ("sent a PUBLISH within a dialog that no longer exists"), while that statement doesn't apply to all possible 412 replies. ## pua_dialoginfo specific * pua_dialoginfo currently subscribes to a lot of mod_dialog callbacks. For example subscribing to both DLGCB_CONFIRMED and DLGCB_CONFIRMED_NA will always get you two (rapidly succeeding) PUBLISHes with exactly the same contents. Subscribing to DLGCB_REQ_WITHIN means you'll get a new PUBLISH for every re-INVITE such as hold/unhold or codec negotiation, which is useless in many usecases. It would be helpful to allow configuring pua_dialoginfo with a list of callbacks to subscribe to. * With or without a smaller set of mod_dialog callbacks, pua_dialoginfo can generate multiple PUBLISH requests with exactly the same contents. Since pua is aware of the (last) state that it published for the presentity, it could compare if the newly generated PUBLISH is any different from the last known state, and discard it if it's not. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2048

3 4

[kamailio/kamailio] Kamailio crashed in ims_dialog (#2221)
by harishyadav1465 23 Nov '23

23 Nov '23

**Description** Recently we have upgraded to **kamailio 5.3** version and we are performing load tests on it for scalability but Unfortunately it is **crashed** while performing in **ims_dialog** module. we are using **ims_dialog** module instead of **dialog** module for **diameter** protocol purpose. **Troubleshooting** We found out that **dlg_out** is **NULL** but we are accessing the **dlg_out->to_tag.len** this leads to the crash..But unfortunately we don't know how this gets **NULL** as **dlg_out** is assigned to **d_entry_out->first** which is **NOT NULL** **GDB messages:** (gdb) #0 0x00007fbe5a646ea6 in next_state_dlg (dlg=0x7fbe57dcf268, event=3, old_state=0x7ffc8b03f0a0, new_state=0x7ffc8b03f0a4, unref=0x7ffc8b03f09c, to_tag=0x7ffc8b03f080) at dlg_hash.c:1180 #1 0x00007fbe5a622170 in dlg_onreply (t=0x7fbe57f7a3f0, type=1048576, param=0x7ffc8b03f2f0) at dlg_handlers.c:1276 #2 0x00007fbe5e2b5517 in run_trans_callbacks_internal (cb_lst=0x7fbe57f7a468, type=1048576, trans=0x7fbe57f7a3f0, params=0x7ffc8b03f2f0) at t_hooks.c:254 #3 0x00007fbe5e2b5733 in run_trans_callbacks_with_buf (type=1048576, rbuf=0x7fbe57f7a4c0, req=0x7fbe57f7bab0, repl=0x7fbe5fa1d218, flags=0) at t_hooks.c:297 #4 0x00007fbe5e2fc05f in relay_reply (t=0x7fbe57f7a3f0, p_msg=0x7fbe5fa1d218, branch=1, msg_status=183, cancel_data=0x7ffc8b03f760, do_put_on_wait=1) at t_reply.c:1986 #5 0x00007fbe5e300ec3 in reply_received (p_msg=0x7fbe5fa1d218) at t_reply.c:2540 #6 0x00000000004b6f43 in do_forward_reply (msg=0x7fbe5fa1d218, mode=0) at core/forward.c:745 #7 0x00000000004b8a8f in forward_reply (msg=0x7fbe5fa1d218) at core/forward.c:846 #8 0x00000000005527c7 in receive_msg ( buf=0xb3b740 "SIP/2.0 183 Session Progress\r\nVia: SIP/2.0/UDP 182.72.244.91:5060;branch=z9hG4bK7fea.85af5c92096548bdd857481789b3e50f.1, SIP/2.0/UDP 182.72.244.91:5080;received=182.72.244.91;rport=5080;branch=z9hG4bK"..., len=613, rcv_info=0x7ffc8b040000) at core/receive.c:510 #9 0x0000000000675077 in udp_rcv_loop () at core/udp_server.c:548 #10 0x0000000000425f4b in main_loop () at main.c:1673 #11 0x000000000042e52a in main (argc=13, argv=0x7ffc8b040808) at main.c:2802 ******************************************************************************* (gdb) f 0 #0 0x00007fbe5a646ea6 in next_state_dlg (dlg=0x7fbe57dcf268, event=3, old_state=0x7ffc8b03f0a0, new_state=0x7ffc8b03f0a4, unref=0x7ffc8b03f09c, to_tag=0x7ffc8b03f080) at dlg_hash.c:1180 1180 if (dlg_out->to_tag.len == to_tag->len && memcmp(dlg_out->to_tag.s, to_tag->s, dlg_out->to_tag.len) == 0) { (gdb) info locals d_entry = 0x7fbe57d5ab70 d_entry_out = 0x7fbe57dcf378 dlg_out = 0x0 found = -1 delete = 1 __FUNCTION__ = "next_state_dlg" (gdb) p d_entry_out->first $10 = (struct dlg_cell_out *) 0x7fbe57fcf6b8 **Additional Information** **version**: kamailio 5.3.2 (x86_64/linux) Thanks in Advance...I am beginning to work with kamailio ....can you guys please give me some hints how to move forward with this.. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2221

6 7

[kamailio/kamailio] kamctl - shell interpreter selection (#2019)
by Daniel-Constantin Mierla 23 Nov '23

23 Nov '23

### Description The `kamctl` tool seems to require `bash`, while trying to use `/bin/sh`, which can point to `dash` or other shell interpreters. For example, the output of `kamdbctl create`: ``` MySQL password for root: -e \E[37;33mINFO: creating database kamailio_simple_db ... -e \E[37;33mINFO: granting privileges to database kamailio_simple_db ... -e \E[37;33mINFO: creating standard tables into kamailio_simple_db ... -e \E[37;33mINFO: Core Kamailio tables succesfully created. Install presence related tables? (y/n): n /usr/sbin/kamdbctl: 216: /usr/sbin/kamdbctl: Bad substitution ``` It seems that the issue is expanding the variable when getting the answer for y/n question: * https://github.com/kamailio/kamailio/blob/master/utils/kamctl/kamdbctl.base… Such expression seems to be specific for bash: * https://mywiki.wooledge.org/Bashism ### Troubleshooting #### Reproduction Run `kamctl` with `/bin/sh` pointing to `bash`. ### Possible Solutions Decide what to do to have an acceptable solution: enforce `bash`, remove bashisms`... Or maybe focus to make `kamcli` a (full) replacement for `kamctl/kamdbctl` and get rid of those old-style shell/bash scripts: * https://github.com/kamailio/kamcli -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2019

3 4

[kamailio/kamailio] EVAPI: Better ability to remove dead clients (#1880)
by weili-jiang 23 Nov '23

23 Nov '23

### Description If an EVAPI client drops dead and silently closes its TCP connection, EVAPI is not notified in an acceptable time frame. The default OS TCP keep-alive parameters are generally far too long to be effective, and there is no way to override these using module or runtime configuration. Moreover, any attempts to put in a workaround is thwarted by the inability to close an arbitrary EVAPI connection from say, a timer event (since there is no way to specify a connection to close outside the EVAPI context). ### Expected behavior When an EVAPI client goes dead, the connection should be closed in the order of seconds (ideally configurable). The EVAPI should allow connections to be closed via scripting from any context. #### Actual observed behavior When an EVAPI client goes dead, the connection stays open (counting towards the maximum number of allowed clients). When the evapi_close is invoked from other contexts, nothing happens. #### Debugging Data #### Log Messages #### SIP Traffic ### Possible Solutions ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.1 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: Debian GNU/Linux 9 (stretch) ``` Linux 3b83b180f7c9 4.15.0-45-generic #48-Ubuntu SMP Tue Jan 29 16:28:13 UTC 2019 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1880

2 2

[kamailio/kamailio] support for a kamailio-dev package for external modules (#1752)
by Victor Seva 23 Nov '23

23 Nov '23

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902944 > Hi! > > We've got several local kamailio modules, and it would be nice to be > able to build them separately and not have to hook them into the > kamailio source and build systems. I suppose others might find this > useful too. > > I started pondering what adding support for this would imply, and I > think the first step is whether this is something you think upstream > and you'd be happy supporting? It could be that the internal interfaces > are completely unstable and providing this might be a support nightmare, > for example, or other similar concerns. > > I think what would be needed is: > > - Support installing the library .so symlinks into the -dev package. > (The module .so I think would need to stay in the main and module > packages, because some stuff loads them as module.so directly?) > - Support installing the kamailio core, library and module .h files > into the -dev package. AFAIUI modules can have inter-module > dependencies and they might use interfaces from both kamailio core > itself, the shared libraries or other modules. > - Provide a pkg-config file with the necessary compile and link runes > (-I, -L, -rpath and similar) to be able to build 3rd party modules > easily. > > While checking this, I noticed there's a src/lib/Makefile.defs, which > has a TYPE variable to install headers and similar, but it does not > appear to be currently used? > > Thanks, > Guillem -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1752

5 7

[kamailio/kamailio] TLS: Consider what's new and what's supported in OpenSSL (#1878)
by Olle E. Johansson 23 Nov '23

23 Nov '23

### Description  ### Expected behavior #### Actual observed behavior #### Debugging Data ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1878

3 7

[kamailio/kamailio] OpenSUSE warning cleanup (#1714)
by sergey-safarov 23 Nov '23

23 Nov '23

### Description During kamailio packaging on OpenSUSE in log exist this warnings ``` [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/acc_diameter.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/auth_diameter.so [ 860s] kamailio-json.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/jsonrpcc.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/pdb.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/siputils.so [ 860s] kamailio-xmpp.i586: I: binary-or-shlib-calls-gethostbyname /usr/lib/kamailio/modules/xmpp.so [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/sbin/kamailio [ 860s] kamailio.i586: I: binary-or-shlib-calls-gethostbyname /usr/sbin/kamcmd [ 860s] The binary calls gethostbyname(). Please port the code to use getaddrinfo(). ``` Could you `port the code to use getaddrinfo()`. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1714

3 3

[kamailio/kamailio] tls connection terminated frequently when mongodb cluster member becomes unavailable (#1599)
by flo-eyeson-team 23 Nov '23

23 Nov '23

### Description Kamailio frequently terminates tls connections to sip clients, if db_mongodb database driver is used and one mongodb cluster member becomes unavailable. If one mongodb secondary is shutdown (or the primary and a promotion takes place) kamailio will terminate the tls connection to a sip-client (sends a FIN/ACK) after a short period of time (differs 20s to 180s). If a sip client reconnects, registration will succeed (so mongodb access is fine) but kamailio will terminate the tls connection shortly after. This situation happens as well if only the connection between kamailio and a secondary is blocked (the cluster members can still communicate with each other). I assume that the mongo-c's server discovery might be the culprit. Mongoc iteratively tries to connect to all servers in the mongoc-uri to update their status (`mongodb://mongodb-cluster2:27017,mongodb-cluster1:27017,mongodb-cluster0:27017/kamailio?authMechanism=MONGODB-X509&replicaSet=rs1&ssl=true&sslcertificateauthorityfile=mongo.ca&sslclientcertificatekeyfile=mongo.certkey`). Nonethless, mongoc's server discovery should be transparent to the kamailio client as long as a primary exists (and this is the case). No reason to terminate tls client connections.  ### Troubleshooting #### Reproduction  1. Setup a mongodb cluster with 3 members. 2. Setup kamailio with tls using db-mongodb via tls. Note: The mongodb-uri must contain all three members, e.g. `mongodb://mongodb-cluster2:27017,mongodb-cluster1:27017,mongodb-cluster0:27017/kamailio?ssl=true`) 3. Connect/register a sip client via tls. 4. Stop one member. 5. Clients will receive a ready error on its tls connection. #### Log Messages  The db_mongodb kamailio logs don't reveal any errors. Operations are normal. The only thing which is shown in the logs is TLS read:error. As seen below. ``` Jul 23 14:22:09 bda3e8fce481 /usr/local/sbin/kamailio[318]: ERROR: tls [tls_util.h:42]: tls_err_ret(): TLS read:error:140E0197:SSL routines:SSL_shutdown:shutdown while in init Jul 23 14:22:09 bda3e8fce481 /usr/local/sbin/kamailio[318]: ERROR: <core> [core/tcp_read.c:1485]: tcp_read_req(): ERROR: tcp_read_req: error reading - c: 0x7fa9b6343210 r: 0x7fa9b6343290 ``` A wireshark trace reveals that kamailio closes the tcp connection (FIN/ACK). The client receives a "stream truncated". ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.4 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 13:39:15 Jul 23 2018 with gcc 6.3.0 ``` * **mongoc-version** ``` mongoc-1.11.0 (built with cmake ../ -DENABLE_AUTOMATIC_INIT_AND_CLEANUP=OFF) ``` * **Operating System**:  ``` Debian 9.5 docker image running on CentOS 7 (kernel 3.10.0-514.6.1.el7.x86_64) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1599

3 9

[kamailio/kamailio] core: use standard c atomic code from stdatomic.h instead of providing assembly routines (#1430)
by Victor Seva 23 Nov '23

23 Nov '23

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=886111 ``` Source: kamailio Version: 5.1.0-1 Severity: wishlist Hi, I noticed from the build log on mips64el a lot of warnings like this: > In file included from ../../core/parser/../mem/../atomic/atomic_native.h:50:0, > from ../../core/parser/../mem/../futexlock.h:42, > from ../../core/parser/../mem/../lock_ops.h:75, > from ../../core/parser/../mem/shm.h:39, > from ../../core/parser/../mem/shm_mem.h:34, > from ../../core/parser/../ut.h:45, > from ../../core/parser/../ip_addr.h:39, > from ../../core/parser/msg_parser.h:37, > from app_sqlang_api.h:28, > from app_sqlang_kemi_export.c:32: > ../../core/parser/../mem/../atomic/atomic_mips2.h:41:2: warning: #warning mips64 atomic code was not tested, please report problems to serdev(a)iptel.org or andrei(a)iptel.org [-Wcpp] > #warning mips64 atomic code was not tested, please report problems to \ > ^~~~~~~ If possible, kamailio should use the standard c atomic code from stdatomic.h instead of providing assembly routines. This will improve maintainability and architecture support. Thanks, James ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1430

4 4

[kamailio/kamailio] tmx: t_reuse_branch() doesn't copy $du into new branch (#1264)
by Sebastian Damm 23 Nov '23

23 Nov '23

### Description When using the t_reuse_branch() function after a branch failure, Kamailio doesn't send out the call again if $du was filled and differed from $ru. Instead, Kamailio tries to send the call directly to $ru. I would expect that the call gets sent out the same way as the original call. ### Troubleshooting #### Reproduction You need a setup like this: UAC1 K(LB) <=> K(Proxy/Registrar) <=> K(LB) => UAC2 When a UAC registers, the Path module is used to save the LB (Loadbalancer) for outbound calls. When UAC1 calls UAC2, the original call gets sent through K(LB) to UAC2. However, if the first call gets rejected and the call gets retried through branch failure route, K(Proxy/Registrar) tries to send the call directly to the request URI. In your branch_route add a reference to a branch failure route: ```t_on_branch_failure("samplename");``` Then add a branch failure route like this: ```event_route[tm:branch-failure:handle_tls_branch] { if(t_check_status("488")) { if (isbflagset(0) && !isbflagset(1)) { t_reuse_branch(); setbflag(1); t_relay(); } } }``` When filling $du manually before sending out the call again, everything works. ### Possible Solutions The original destination URI should be copied to the reused branch. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 4.4.5 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 4.7.2 ``` But from what I see in source code, the devel version still copies the same value. * **Operating System**:  ``` Debian Wheezy ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1264

4 5

[kamailio/kamailio] Solve the high potential of having conflicts for internal dialog id in multiple simultaneous kamailio instances (#1500)
by alexsosic 23 Nov '23

23 Nov '23

Regarding the issue 1274 (https://github.com/kamailio/kamailio/issues/1274) there's a problem in highly scalable environments to avoid conflicts in storing dialogs in the same DB. As @miconda pointed out: > The internal id is made from two integers, hash entry and hash id (h_entry, h_id). h_entry is the index of the slot in the hash table used to store the dialog structure, computed by hashing over call id. h_id is an incremented integer specific for each hash table slot. > > So, when loading a new record from database, if its h_id is not conflicting with an existing dialog on the same hash table slot, all is ok, otherwise the module is not going to work properly with two dialogs having same h_id. > > So, when loading a new record from database, if its h_id is not conflicting with an existing dialog on the same hash table slot, all is ok, otherwise the module is not going to work properly with two dialogs having same h_id. > > Among solutions I thought of: > > 1. have the servers generating non conflicting h_id, by having a start value different per server and an increment step larger than the number of servers. Iirc, here was at some point a similar attempt, but somehow didn't make it. Let's say one has two servers, first server starts allocating h_id from 1 and increments by 2 (e.g: 1, 3, 5, ...) and the seconds start from 2 and increments with 2 (2, 4, 6, ...). Those values can be set via mod params, eventually with an option to rely on server_id. > This should be the least intrusive in the other modules built on top of dialog. But it is rather rigid, with the example above, if one adds an extra server, it needs to reconfigure the old ones, so each server starts from either 1, 2 or 3 and increment by 3. Of course, one can set increment step to a larger value, like 100, and then has flexibility to deploy up to 1 hundred servers before having to reconfigure in case there is need for more server. > > 2. add server_id as the third field in the dialog id. It will require review of other modules using dialog and eventual code updates in those modules. One column to store the server_id needs to be added to dialog db tables. > > 3. switch from this conflicting id system to something like string unique ids, similar to what we have in usrloc records. This will require coding in other modules, changes to database schema, etc., so more work comparing with the above two, but could be the best in long term. It would be great to have the option 3 developed if possible but we would also be satisfied with the option 2 to have a third field, server_id, in the dialog id. Thank You! -- Alex -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1500

3 6

[kamailio/kamailio] allow more than one tcp/tls connection to same destination (#1107)
by juha-h 23 Nov '23

23 Nov '23

When K connects to another SIP proxy over TCP or TLS, the connection is shared for all requests to that destination. If the receiving SIP proxy is K, it means that only one worker process is handling all those requests. This may become a bottleneck if processing of requests is time consuming, e.g., because of DB operations. It should therefore be possible one way or another to establish more than one parallel TCP or TLS connections to the same destination. One solution could be based on a function call, such as t_forward_connect(number), to be called before t_relay specifying the desired number of parallel connections shared randomly by outgoing requests. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1107

6 6

[kamailio/kamailio] kazoo: incomplete documentation (#976)
by Ovidiu Sas 23 Nov '23

23 Nov '23

There are lots of module parameters that are not documented in the README file: "amqp_timmer_process_interval" "amqp_consumer_ack_timeout_micro" "amqp_consumer_ack_timeout_sec" "amqp_interprocess_timeout_micro" "amqp_interprocess_timeout_sec" "amqp_waitframe_timeout_micro" "amqp_waitframe_timeout_sec" "amqp_consumer_workers" "amqp_query_timeout_micro" "amqp_query_timeout_sec" "pua_include_entity" "json_escape_char" "app_name" "use_federated_exchange" "federated_exchange" "amqp_heartbeats" "amqp_primary_zone" "amqp_command_hashtable_size" "amqp_result_avp" "amqps_ca_cert" "amqps_cert" "amqps_key" "amqps_verify_peer" "amqps_verify_hostname" Also, the follwing functions are not documented: "kazoo_json_keys" "kazoo_async_query" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/976

3 3

[kamailio/kamailio] Presentity tabla, faster update when drop TCP/TLS connection (#915)
by jresende 23 Nov '23

23 Nov '23

Hello, I'm testing kamailio with a SIP client with presence support, when I get a connection drop from a client (i.e when the client lost the access to the Internet connection) I do not receive the change in the status to offline immediately, I just received when the timeout from the presentity database finishes. I know that I'm able to change the expiry parameter from the presentity table, but that increases my battery consumption and the data exchange, the same happens if I reduce the publish interval on the client side. The connection with the server are connected with the TLS or TCP. @miconda Suggested that a solution could be: "For TCP/TLS, what can work, it's to use tcpops module which can execute an event route when a tcp/tls connection is dropped. If you track the association of connection id with the call-id of the presence publish, then you may be able to do some tricks and lower the expires of the published presence state. I haven't had the time to see what's possible there, but could worth investing. An alternative would be to enhance presence module to behave as registrar/usrloc (which can delete contact records on connection drop) to expire documents when tcp/tls connection is closed (not sure if anyone already added it)." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/915

2 2

[kamailio/kamailio] support valgrind when *_MALLOC is used (#949)
by Victor Seva 23 Nov '23

23 Nov '23

As explain at https://www.kamailio.org/wiki/tutorials/troubleshooting/memory#pkg_with_sys… valgrind can be used to check memory leaks if kamailio is compiled without ``*_MALLOC``. I would like to support valgrind even if kamailio is compiled to use its own memory managers. In order to archive this, valgrind has to be informed of how those managers control the memory as described at http://valgrind.org/docs/manual/mc-manual.html#mc-manual.mempools -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/949

4 6

[kamailio/kamailio] dnssec: stop using libdnsval-dev for DNSSEC validation (#851)
by Victor Seva 23 Nov '23

23 Nov '23

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843477 > From: Ondřej Surý <ondrej(a)debian.org> > To: Debian Bug Tracking System <submit(a)bugs.debian.org> > Subject: src:kamailio: stop using libval-dev for DNSSEC validation > > Package: src:kamailio > Version: 4.4.3-2 > Severity: serious > > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA512 > > Dear maintainer, > > please stop using libdnsval-dev for DNSSEC validation. src:dnsval > is very poorly upstream maintained (SVN repository, issue tracker, > mailing list are non-functional) and I am going to schedule it for > removal for stretch. > > In a long term you should migrated to better and maintained library > (preferrably getdns or just libunbound), but now please just drop > it. > > Cheers, > Ondrej > > - -- System Information: > Debian Release: 8.6 > APT prefers stable-updates > APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 'stable') > Architecture: amd64 (x86_64) > > Kernel: Linux 4.2.0-41-generic (SMP w/24 CPU cores) > Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: systemd (via /run/systemd/system) > > -----BEGIN PGP SIGNATURE----- So I'm going to remove **dnssec** module from the official Debian package -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/851

2 2

[kamailio/kamailio] track_cseq_updates does not update Rack SIP header in PRACK. (#801)
by scfcplummy 23 Nov '23

23 Nov '23

Hi, When using dialog module and track_cseq_updates when needing to update CSeq for authenticated invites, if early media is present the CSeq in the Rack header is not also incremented. Kamailio version: version: kamailio 4.4.2 (x86_64/linux) 892ad6 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 892ad6 compiled on 11:18:36 Sep 28 2016 with gcc 5.4.0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/801

4 6

[kamailio/kamailio] sca: implement db_mode only (#781)
by Victor Seva 23 Nov '23

23 Nov '23

Sipwise hat ON: We have more than one server and we need to keep things in db in order to share sca subscription/appearance between servers -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/781

4 6

[kamailio/kamailio] Allow function set_advertised_address to receive variable as parameter (#2137)
by pwakano 17 Nov '23

17 Nov '23

### Description Currently the functions set_advertised_address and set_advertised_port only accept strings as parameters. Trying to use it with variable causes an error. Having the function using a hard coded value is not a good practice and in order to add flexibility to the script in different installations it would be nice to have this function accepting variables. Also, the 'advertise' option on the 'listen' parameter is not always desired because it apply for all messages sent via the socket, and there are situations where different advertised IP for the same interface are necessary. ### Expected behavior set_advertised_address should receive a variable as parameter and use its value to change the SIP headers. ### Actual observed behavior Kamailio won't start if set_advertised_address is used with a variable due to script parse error or it will set the SIP message with the literal string "$var(test)" for example, instead of using the value of $var(test). ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # uname -a Linux voice-conn-kamailio-1 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2137

7 9

[kamailio/kamailio] dialplan: implement Iterative dialplan matching (#764)
by Victor Seva 13 Nov '23

13 Nov '23

>From http://lists.kamailio.org/pipermail/sr-dev/2016-August/036231.html On 24/08/16 10:17, Andreas Granig wrote: > Hi, > > When translating strings with the dialplan module, you sometimes end up > with very complex patterns for sanitizing the target string and > performing some replacements, since for a given dialplan id, processing > stops on the first match within the dialplan entries for a given dpid. > > The idea is to introduce a "continue" flag (default 0) in the dialplan > table indicating to proceed with processing further dialplan entries > within the given dpid after a match. The use case is to have a sanitize > rule with highest priority which e.g. removes any spaces, dashes and > parentheses from the target string, then with a lower priority do > further processing with the cleaned up string, e.g. stripping leading > double-zeroes or a plus when normalizing to E164 numbers, or replacing a > single leading zero with the country code and so on. > > This is particularly useful when a user dials a number from an address > book of some sort (e.g. on a mobile app) where number formats are stored > with country-specific formating characters like "+1-(234)-567 890", and > catching all of that in one rule results in really messy match/replace > patterns. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/764

4 5

[kamailio/kamailio] app_ruby: print backtrace when ruby exception occurs (#1766)
by Fatih Orhan 13 Nov '23

13 Nov '23

### Description Hello, When there is an error in my ruby script, app_ruby prints exception message without a stack trace, like this: ``` Dec 14 16:25:17 servername /usr/sbin/kamailio[24313]: ERROR: app_ruby [app_ruby_api.c:105]: app_ruby_print_last_exception(): exception: wrong number of arguments (1 for 2..3) Dec 14 16:25:17 servername /usr/sbin/kamailio[24313]: ERROR: app_ruby [app_ruby_api.c:1078]: app_ruby_run_ex(): ruby exception (6) on callback for: ksr_request_route (res type: 17) ``` Altough this message tells what is the error, it doesn't tell **where** the error happened, so it's hard to find the source of the problem. In ruby, exceptions have _backtrace()_ method returning stack trace as an array of strings. It would be really helpful if app_ruby also call this method and append its result to error message. ### Reproduction in kamailio.cfg ``` loadmodule "app_ruby.so" modparam("app_ruby", "load", "/etc/kamailio/ruby/routes.rb") cfgengine "ruby" ``` in /etc/kamailio/ruby/routes.rb ``` def some_method(param1, param2) end def ksr_request_route some_method(1) end ``` ### Expected behavior ``` Dec 14 16:46:24 servername /usr/sbin/kamailio[24314]: ERROR: <core> [core/kemi.c:87]: sr_kemi_core_err(): wrong number of arguments (1 for 2): /etc/kamailio/ruby/routes.rb:1:in `some_method' /etc/kamailio/ruby/routes.rb:4:in `ksr_request_route' ``` #### Actual observed behavior ``` Dec 14 16:45:42 servername /usr/sbin/kamailio[24311]: ERROR: app_ruby [app_ruby_api.c:105]: app_ruby_print_last_exception(): exception: wrong number of arguments (1 for 2) ``` ### Possible Solutions Relevant code seem to be here: https://github.com/kamailio/kamailio/blob/master/src/modules/app_ruby/app_r… I found example C code to print stack trace here but couldn't figure out how to integrate to app_ruby: http://zoo-project.org/svn/trunk/zoo-project/zoo-kernel/service_internal_ru… Equivalent ruby code would be (this code is not idiomatic, my aim is to provide C-like ruby code): ``` def some_error_generating_method method_taking_two_params(1) rescue => exception message = exception.to_s() + "\n" stack_trace = exception.backtrace() for line in stack_trace message = message + line + "\n" end print(message) end ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.0 (x86_64/linux) 535e13 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 535e13 compiled on 10:26:34 Nov 28 2018 with gcc 4.8.5 ``` * **Operating System**: Centos 7.2 64bit ``` Linux servername 3.10.0-327.28.2.el7.x86_64 #1 SMP Wed Aug 3 11:11:39 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1766

3 3

[kamailio/kamailio] Warnings compiling app_java module (#1984)
by Jaigongon 08 Nov '23

08 Nov '23

### Description I recently downloaded kamailio 5.2.3 and tried to install it for investigation purposes. I was trying to include app_java module in order to execute some brief java apps in kamailio. But then I get the same issue wen I compile and when I run kamailio Thank you for all the help you can give me ### Troubleshooting I get the same bunch of warnings everytime I try to make all java_msgobj.c: In function ‘fill_sipmsg_object’: java_msgobj.c:83:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->id); ^~~~~~~~~~~~~~ java_msgobj.c:83:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:96:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->pid); ^~~~~~~~~~~~~~ java_msgobj.c:96:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:110:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:110:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:127:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:127:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:142:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:142:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:156:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->len); ^~~~~~~~~~~~~~ java_msgobj.c:156:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:172:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:172:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:189:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:189:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:205:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->parsed_orig_ruri_ok); ^~~~~~~~~~~~~~ java_msgobj.c:205:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:222:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:222:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:237:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->add_to_branch_len); ^~~~~~~~~~~~~~ java_msgobj.c:237:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:251:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->hash_index); ^~~~~~~~~~~~~~ java_msgobj.c:251:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:265:27: warning: passing argument 2 of ‘(*env)->SetIntField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetIntField(env, SipMsgInstance, fid, msg->msg_flags); ^~~~~~~~~~~~~~ java_msgobj.c:265:27: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:286:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:286:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ java_msgobj.c:306:30: warning: passing argument 2 of ‘(*env)->SetObjectField’ from incompatible pointer type [-Wincompatible-pointer-types] (*env)->SetObjectField(env, SipMsgInstance, fid, jStrParam); ^~~~~~~~~~~~~~ java_msgobj.c:306:30: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘struct _jobject **’ CC (gcc) [M app_java.so] java_support.o CC (gcc) [M app_java.so] java_iface.o java_iface.c: In function ‘java_exec’: java_iface.c:205:53: warning: passing argument 2 of ‘(*_aj_env)->NewLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:205:53: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:205:18: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] invk_method_ref = (*_aj_env)->NewLocalRef(_aj_env, invk_method); ^ java_iface.c:208:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:208:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:216:40: warning: passing argument 2 of ‘(*_aj_env)->MonitorEnter’ from incompatible pointer type [-Wincompatible-pointer-types] if((*_aj_env)->MonitorEnter(_aj_env, invk_method_ref) != JNI_OK) { ^~~~~~~~~~~~~~~ java_iface.c:216:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:234:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:234:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:235:40: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:235:40: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:258:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:258:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:259:39: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:259:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:266:39: warning: passing argument 2 of ‘(*_aj_env)->MonitorExit’ from incompatible pointer type [-Wincompatible-pointer-types] if((*_aj_env)->MonitorExit(_aj_env, invk_method_ref) != JNI_OK) { ^~~~~~~~~~~~~~~ java_iface.c:266:39: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:272:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method_ref); ^~~~~~~~~~~~~~~ java_iface.c:272:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ java_iface.c:273:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, invk_method); ^~~~~~~~~~~ java_iface.c:273:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ CC (gcc) [M app_java.so] java_native_methods.o java_native_methods.c: In function ‘Java_org_siprouter_SipMsg_ParseSipMsg’: java_native_methods.c:484:9: warning: return from incompatible pointer type [-Wincompatible-pointer-types] return fill_sipmsg_object(jenv, _aj_msg); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CC (gcc) [M app_java.so] app_java_mod.o app_java_mod.c: In function ‘child_init’: app_java_mod.c:236:38: warning: passing argument 2 of ‘(*_aj_env)->DeleteLocalRef’ from incompatible pointer type [-Wincompatible-pointer-types] (*_aj_env)->DeleteLocalRef(_aj_env, child_init_id); ^~~~~~~~~~~~~ app_java_mod.c:236:38: note: expected ‘jobject {aka struct _jobject *}’ but argument is of type ‘jmethodID {aka struct _jmethodID *}’ #### Reproduction 1. Download 5.2.3 2. in /usr/local/src/kamailio-5.2.3/ 2.1 make include_modules="app_java" cfg 2.2 make all 2.3 make install 3 kamailo -e -E -ddd #### Debugging Data 0(18169) ERROR: <core> [core/sr_module.c:498]: load_module(): could not open module </usr/local/lib64/kamailio/modules/app_java.so>: libjvm.so: cannot open shared object file: No such file or directory 0(18169) CRITICAL: <core> [core/cfg.y:3507]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 300, column 12-24: failed to load module 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 306, column 46: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 307, column 55: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 308, column 60: Can't set module parameter 0(18169) ERROR: <core> [core/modparam.c:152]: set_mod_param_regex(): No module matching <app_java> found 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 309, column 41: Can't set module parameter 0(18169) ERROR: <core> [core/cfg.y:3370]: yyparse(): cfg. parser: failed to find command java_method_exec (params 2) 0(18169) CRITICAL: <core> [core/cfg.y:3510]: yyerror_at(): parse error in config file /usr/local/etc/kamailio/kamailio.cfg, line 483, column 37: unknown command, missing loadmodule? ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` version: kamailio 5.2.3 (x86_64/linux) c36229 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c36229 * **Operating System**: Ubuntu 18.04 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1984

2 3

[kamailio/kamailio] tm:local-request not documented (#980)
by Olle E. Johansson 18 Oct '23

18 Oct '23

The local-request event route is not documented. When using our friend google I find an old blog post by @miconda but not much else. I can come up with some good text, but need to know what can be done in the route, like - modify request uri - add/remove headers - drop request - add/modify destination uri ($du) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/980

3 8

[kamailio/kamailio] Kamailio sending CCR TERMINATE request without waiting for the CCR INITIAL request response (#2143)
by harishyadav1465 03 Aug '23

03 Aug '23

**Description** We are using ims_charging module and Freediameter as diameter server for billing process....recently we faced one issue...For Initial **INVITEs** kamailio sending **CCR request (INITIAL_REQUEST)** to **diameter server** but if we receive Immediate **CANCLE** for the **INVITE**, kamailio sending **CCR request ( TERMINATE_REQUEST )** without waiting for the **CCR request (INITIAL_REQUEST) response** from the **Diameter server.**.. **Expected behavior** Kamailio has to send **CCR request ( TERMINATE_REQUEST )** after getting the **response** from the **INITIAL_REQUEST.** **Additional Info** kamailio server : 4.2 platform : linux -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2143

3 6

[kamailio/kamailio] siptrace: frong IPv4 address value (#2092)
by sergey-safarov 30 Jul '23

30 Jul '23

### Description Please check attached pcap. [siptrace.pcap.gz](https://github.com/kamailio/kamailio/files/3688791/siptra… Kamailio send INVITE (packet 1) from port `TCP/42394`. SIP trace encapsulate INVITE (packet 2) and encodes Kamailio source port `TCP/5060` #### Debugging Data HEP header parsed by lua [disector](https://github.com/sipcapture/hep-wireshark) ``` HEP3 Protocol HEP ID: HEP3 Length (Bytes): 1574 Protocol family: IPv4 Protocol ID: TCP Source IPv4 address: 172.21.0.131 Destination IPv4 address: 192.168.57.11 Source port: 5060 Destination port: 5060 Timestamp: 1570150645 Timestamp us: 740165 Protocol Type: SIP Capture ID: 1 Payload [truncated]: INVITE sip:911@192.168.57.11;transport=tcp SIP/2.0\r\nRecord-Route: <sip:172.21.0.131;transport=tcp;lr=on;ftag=KvNj7jXrmK89p>\r\nVia: SIP/2.0/TCP 172.21.0.131;branch=z9hG4bK7c2d.2d8104273b7063309f5694ac963c9ad8.0;i=21 ``` [HEP format description located here](https://github.com/sipcapture/HEP/blob/master/docs/HEP3_Network_Proto…. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` / # kamailio -v version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 11:01:40 Oct 4 2018 with gcc 6.4.0 ``` * **Operating System**: Docker container Userland ``` / # cat /etc/os-release NAME="Alpine Linux" ID=alpine VERSION_ID=3.8.1 PRETTY_NAME="Alpine Linux v3.8" HOME_URL="http://alpinelinux.org" BUG_REPORT_URL="http://bugs.alpinelinux.org" ``` Kernel Amazon Linux 2 ``` / # uname -a Linux proxy-dc0-0 4.14.128-112.105.amzn2.x86_64 #1 SMP Wed Jun 19 16:53:40 UTC 2019 x86_64 Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2092

2 7

[kamailio/kamailio] core:tcp allow to handle TCP connections with tcp_accept_haproxy=yes flag even message does not contain PROXY protocol header (#2206)
by ovoshlook 30 Mar '23

30 Mar '23

Covers setups when kamailio behind the service with HAPROXY protocol support but in other hand it also serves requests from other services that available per direct connection (such as B2BUA in the same local network). #### Pre-Submission Checklist - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [*] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [*] PR should be backported to stable branches - [*] Tested changes locally #### Description - function tcpconn_read_haproxy() returns 2 if PROXY header NOT found. - Message about no header shown at the debug level. - No errors - TCP connection successfully establishes You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2206 -- Commit Summary -- * handle tcp request with tcp_accept_haproxy even no PROXY header found * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header * core:tcp allow to handle TCP connections even message does not contain PROXY protocol header -- File Changes -- M src/core/tcp_main.c (8) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2206.patch https://github.com/kamailio/kamailio/pull/2206.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2206

3 6

[kamailio/kamailio] hiops moduls (#2209)
by mojtabaesfandiari 26 Feb '23

26 Feb '23

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2209 -- Commit Summary -- * add received_in_via function(use it in hiops module) * hiops: new module in Kamailio -- File Changes -- M src/core/msg_translator.c (25) M src/core/msg_translator.h (3) A src/modules/hiops/Alarm-Indicator.c (153) A src/modules/hiops/Alarm-Indicator.h (57) A src/modules/hiops/BIT_STRING.c (189) A src/modules/hiops/BIT_STRING.h (33) A src/modules/hiops/CMakeLists.txt (92) A src/modules/hiops/Code.c (64) A src/modules/hiops/Code.h (49) A src/modules/hiops/CommunicationIdentifier.c (94) A src/modules/hiops/CommunicationIdentifier.h (43) A src/modules/hiops/GeneralizedTime.c (706) A src/modules/hiops/GeneralizedTime.h (69) A src/modules/hiops/HI1-Operation.c (94) A src/modules/hiops/HI1-Operation.h (61) A src/modules/hiops/IA5String.c (77) A src/modules/hiops/IA5String.h (27) A src/modules/hiops/INTEGER.c (1025) A src/modules/hiops/INTEGER.h (82) A src/modules/hiops/IP-value.c (130) A src/modules/hiops/IP-value.h (55) A src/modules/hiops/IPAddress.c (393) A src/modules/hiops/IPAddress.h (67) A src/modules/hiops/LawfulInterceptionIdentifier.c (126) A src/modules/hiops/LawfulInterceptionIdentifier.h (38) A src/modules/hiops/LocalTimeStamp.c (191) A src/modules/hiops/LocalTimeStamp.h (50) A src/modules/hiops/Makefile (15) A src/modules/hiops/National-HI1-ASN1parameters.c (139) A src/modules/hiops/National-HI1-ASN1parameters.h (43) A src/modules/hiops/NativeEnumerated.c (207) A src/modules/hiops/NativeEnumerated.h (32) A src/modules/hiops/NativeInteger.c (332) A src/modules/hiops/NativeInteger.h (37) A src/modules/hiops/Network-Element-Identifier.c (198) A src/modules/hiops/Network-Element-Identifier.h (60) A src/modules/hiops/Network-Identifier.c (94) A src/modules/hiops/Network-Identifier.h (48) A src/modules/hiops/Notification.c (153) A src/modules/hiops/Notification.h (57) A src/modules/hiops/OBJECT_IDENTIFIER.c (764) A src/modules/hiops/OBJECT_IDENTIFIER.h (139) A src/modules/hiops/OCTET_STRING.c (1807) A src/modules/hiops/OCTET_STRING.h (86) A src/modules/hiops/PrintableString.c (109) A src/modules/hiops/PrintableString.h (24) A src/modules/hiops/Priority.c (125) A src/modules/hiops/Priority.h (38) A src/modules/hiops/TimeStamp.c (64) A src/modules/hiops/TimeStamp.h (49) A src/modules/hiops/UTCTime.c (179) A src/modules/hiops/UTCTime.h (38) A src/modules/hiops/asn_application.h (47) A src/modules/hiops/asn_codecs.h (109) A src/modules/hiops/asn_codecs_prim.c (312) A src/modules/hiops/asn_codecs_prim.h (53) A src/modules/hiops/asn_internal.h (128) A src/modules/hiops/asn_system.h (137) A src/modules/hiops/ber_decoder.c (283) A src/modules/hiops/ber_decoder.h (64) A src/modules/hiops/ber_tlv_length.c (178) A src/modules/hiops/ber_tlv_length.h (50) A src/modules/hiops/ber_tlv_tag.c (144) A src/modules/hiops/ber_tlv_tag.h (60) A src/modules/hiops/constr_CHOICE.c (1114) A src/modules/hiops/constr_CHOICE.h (57) A src/modules/hiops/constr_SEQUENCE.c (1425) A src/modules/hiops/constr_SEQUENCE.h (60) A src/modules/hiops/constr_TYPE.c (77) A src/modules/hiops/constr_TYPE.h (180) A src/modules/hiops/constraints.c (93) A src/modules/hiops/constraints.h (63) A src/modules/hiops/der_encoder.c (201) A src/modules/hiops/der_encoder.h (68) A src/modules/hiops/hi1ops.c (682) A src/modules/hiops/hi1ops.h (102) A src/modules/hiops/hi2ops.c (1319) A src/modules/hiops/hi2ops.h (109) A src/modules/hiops/hiops.c (272) A src/modules/hiops/hiops.h (38) A src/modules/hiops/per_decoder.c (93) A src/modules/hiops/per_decoder.h (56) A src/modules/hiops/per_encoder.c (151) A src/modules/hiops/per_encoder.h (69) A src/modules/hiops/per_opentype.c (378) A src/modules/hiops/per_opentype.h (22) A src/modules/hiops/per_support.c (483) A src/modules/hiops/per_support.h (135) A src/modules/hiops/tcp_socket.c (136) A src/modules/hiops/tcp_socket.h (39) A src/modules/hiops/xer_decoder.c (368) A src/modules/hiops/xer_decoder.h (106) A src/modules/hiops/xer_encoder.c (67) A src/modules/hiops/xer_encoder.h (59) A src/modules/hiops/xer_support.c (227) A src/modules/hiops/xer_support.h (55) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2209.patch https://github.com/kamailio/kamailio/pull/2209.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2209

5 17

[kamailio/kamailio] dialog: not able to set the hangup_reason , when we hangup calls using xmlrpc. (#1737)
by Surendra Tiwari 26 Aug '22

26 Aug '22

### Description We are using xmlrpc to terminate the calls once customer balance reaches to zero. call got terminated but we will not be able to set the dialog variable related to hangup_reason. There should be a way during dlg.terminate_dlg xmlrpc request that if i mention the some parameter then it should set before sending bye to callee and caller.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` root@ip-172-31-4-160:/etc/kamailio# kamailio -version version: kamailio 5.1.4 (x86_64/linux) 6ebfda flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 6ebfda compiled on 11:48:26 Sep 7 2018 with gcc 4.8.4 ``` * **Operating System**:  ``` root@ip-172-31-4-160:/etc/kamailio# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 14.04.5 LTS Release: 14.04 Codename: trusty root@ip-172-31-4-160:/etc/kamailio# uname -a Linux ip-172-31-4-160 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1737

2 5

[kamailio/kamailio] keep new features in a file in the repository (#668)
by Victor Seva 26 Aug '22

26 Aug '22

This will allow us to point https://www.kamailio.org/wiki/features/new-in-devel to the file and "force" developers to update that file with the new features when they are introduced in the repository Remaining developers to upgrade the wiki seems pointless and anyone can create a PR for changes --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/668

4 4

[kamailio/kamailio] kazoo: consuming of events fails if message has no body (#1837)
by mihovilkolaric 26 Aug '22

26 Aug '22

### Description Consuming messages without message body fails due to a JSON parsing error: ``` ERROR: kazoo [kz_json.c:287]: kz_json_parse(): Error parsing json: unexpected end of data ERROR: kazoo [kz_json.c:288]: kz_json_parse(): ERROR: kazoo [kz_amqp.c:2960]: kz_amqp_send_worker_event(): error parsing json body ``` This makes it unable to consume messages from RabbitMQ's event exchange plugin ( https://www.rabbitmq.com/event-exchange.html ), as the documentatin states: **"The message body is always blank."** ### Possible Solutions As a possible fix I tried following change in kz_amqp.c: ``` void kz_amqp_send_worker_event(kz_amqp_server_ptr server_ptr, amqp_envelope_t* envelope, kz_amqp_bind_ptr bind) { char buffer[100]; kz_amqp_cmd_ptr cmd = NULL; kz_amqp_consumer_delivery_ptr ptr = NULL; json_obj_ptr json_obj = NULL; json_object* JObj = NULL; str* message_id = NULL; int idx = envelope->channel-1; int worker = 0; int _kz_server_id = server_ptr->id; int msg_size = envelope->message.body.len; //begin of changes int routingkey_size = envelope->routing_key.len; if (msg_size == 0 && routingkey_size > 0 ) { char *routingkey_data = pkg_malloc(routingkey_size + 1); memset(routingkey_data, 0, routingkey_size + 1); memcpy(routingkey_data, (char*)envelope->routing_key.bytes, routingkey_size); LM_DBG("Message size: %d\n", msg_size); LM_DBG("Routing Key: %s\n", routingkey_data); char *pos = strchr(routingkey_data,'.'); while (pos){ *pos = '_'; pos = strchr(pos,'.'); } LM_DBG("New Routing Key: %s\n", routingkey_data); sprintf(buffer, "kazoo:%s", routingkey_data); if(kz_amqp_consumer_fire_event(buffer) != 0) { LM_ERR("kazoo:%s not found", routingkey_data); } pkg_free(routingkey_data); return; } char *json_data = pkg_malloc(msg_size + 1); if(!json_data) { LM_ERR("no more package memory available. needed %d\n", msg_size + 1); return; } char *json_data = pkg_malloc(msg_size + 1); //end of changes if(!json_data) { LM_ERR("no more package memory available. needed %d\n", msg_size + 1); return; } ``` The change is rather simple: If there is no message-body supplied, the event-route _kazoo:<binding_key>_ is called (after replacing any '.' with '_' in the routing_key). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1837

3 6

[kamailio/kamailio] crash related to functions in cfg file parser for invalid cfg (#2239)
by Henning Westerholt 14 Jun '22

14 Jun '22

Against current git master. ``` henning@static:~/repositories/kamailio$ cat etc/crash-4.cfg #!KAMAILIO loadmodule "sl.so" request_route { switch (1) { case -1: send_reply("404", "Not Found"); case -2: send_reply("405",("Method Not Allowed"); exit; } ``` > $ ./src/kamailio -f etc/crash-4.cfg -L src/modules/ -Y /tmp -E -d > 0(2278) CRITICAL: <core> [core/cfg.y:3549]: yyerror_at(): parse error in config file /home/henning/repositories/kamailio/etc/crash-4.cfg, line 10, column 43: syntax error > 0(2278) CRITICAL: <core> [core/cfg.y:3549]: yyerror_at(): parse error in config file /home/henning/repositories/kamailio/etc/crash-4.cfg, line 10, column 43: '('')' expected (function call) > Segmentation fault (core dumped) > henning@static:~/repositories/kamailio$ gdb src/kamailio core > Reading symbols from src/kamailio...done. > [New LWP 2278] > Core was generated by `./src/kamailio -f etc/crash-4.cfg -L src/modules/ -Y /tmp -E -d'. > Program terminated with signal SIGSEGV, Segmentation fault. > #0 0x00005580cdbd131e in append_action (a=0x7fad84db9300, b=0x7fad84db97f8) at core/route_struct.c:147 > 147 for(t=a; t->next; t=t->next); > (gdb) bt > #0 0x00005580cdbd131e in append_action (a=0x7fad84db9300, b=0x7fad84db97f8) at core/route_struct.c:147 > #1 0x00005580cdf9208b in yyparse () at core/cfg.y:2428 > #2 0x00005580cdb96c11 in main (argc=9, argv=0x7ffc2d9f6a68) at main.c:2309 > (gdb) f 0 > #0 0x00005580cdbd131e in append_action (a=0x7fad84db9300, b=0x7fad84db97f8) at core/route_struct.c:147 > 147 for(t=a; t->next; t=t->next); > (gdb) p a > $1 = (struct action *) 0x7fad84db9300 > (gdb) p b > $2 = (struct action *) 0x7fad84db97f8 > (gdb) p t > $3 = (struct action *) 0x80 > (gdb) p a->next > $4 = (struct action *) 0x80 > (gdb) p *t > Cannot access memory at address 0x80 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2239

2 2

[kamailio/kamailio] [Feature Request] Add reload capability for geoip2 module (#2029)
by Joel Serrano 13 Apr '22

13 Apr '22

### Description Currently, the `geoip2` module loads the IP database at startup and keeps it in cache and there is no way to tell Kamailio to reload the database without a full restart. ### Possible Solutions To keep this module inline with other modules that use external datasources, I would suggest to implement a new RPC command and a new geoip2 function to reload the database defined in the `path` geoip2 modparam without the need of a restart. I'm not aware of the effort required for implementing either of them, but only having an RPC command would effectively solve this issue as you can call RPC commands from within Kamailio conf, thus, the reload function would not be something strictly required but more of a nice-to-have. ### Examples: Function: ``` geoip2_reload() ``` RPC command: ``` kamctl rpc gip2.reload / kamctl rpc geoip2.reload ``` Kamcmd command: ``` kamcmd geoip2.reload ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2029

2 3

[kamailio/kamailio] server crashes every 10 hours (#2101)
by ekke56 14 Jan '22

14 Jan '22

### Description  ### Troubleshooting coredump data below. #### Reproduction  #### Debugging Data  ``` (gdb) bt full #0 0x000000000046ccdd in get_hash1_raw (s=0x5da51296 <Address 0x5da51296 out of bounds>, len=9) at core/hashes.h:109 p = 0x5da51296 <Address 0x5da51296 out of bounds> v = 4100353960 h = 0 #1 0x000000000046cfb6 in str_hash_get (ht=0xa6d6c0 <cnts_hash_table>, key=0x5da51296 <Address 0x5da51296 out of bounds>, len=9) at core/str_hash.h:94 h = 0 e = 0x19 #2 0x000000000046debe in cnt_hash_lookup (group=0x7ffc2db9d7c0, name=0x7eff79693b80) at core/counters.c:420 e = 0x7eff80c48c88 first = 0xbd8191bc2e950d55 cnt_rec = 0x7eff80c48cb0 #3 0x000000000046e752 in counter_lookup_str (handle=0x7ffc2db9d7d0, group=0x7ffc2db9d7c0, name=0x7eff79693b80) at core/counters.c:541 cnt_rec = 0x19 #4 0x00007eff7d65b447 in get_stat (name=0x7eff79693b80) at ../../core/counters.h:197 h = {id = 13} grp = {s = 0x0, len = 0} #5 0x00007eff7d65c113 in statsc_svalue (name=0x7eff79693b80, res=0x7eff79693f4b) at statsc_mod.c:149 stat = 0xd __FUNCTION__ = "statsc_svalue" #6 0x00007eff7d65db79 in statsc_timer (ticks=113205942, param=0x0) at statsc_mod.c:274 sm = 0x7eff79693b70 tn = 1571099286 n = 115 __FUNCTION__ = "statsc_timer" #7 0x00000000005db7f9 in sr_wtimer_exec (ticks=113205942, param=0x0) at core/timer_proc.c:390 wt = 0x7eff80c56f48 wn = 0x0 wp = 0x0 cs = 0 __FUNCTION__ = "sr_wtimer_exec" #8 0x00000000005daa29 in fork_sync_timer (child_id=-1, desc=0x7c8a71 "secondary timer", make_sock=1, f=0x5db4f2 <sr_wtimer_exec>, param=0x0, interval=1000) at core/timer_proc.c:224 pid = 0 ts1 = 1811295077 ts2 = 1000 #9 0x00000000005dbb26 in sr_wtimer_start () at core/timer_proc.c:416 __FUNCTION__ = "sr_wtimer_start" #10 0x0000000000425a33 in main_loop () at main.c:1729 i = 8 pid = 3615 si = 0x0 si_desc = "udp receiver child=7 sock=91.216.86.57:5060\000\377~\000\000@۹-\374\177\000\000\020\207A\000\000\000\000\000\020\336\271-\374\177\000\000\323c{\000\000\000\000\000\031\000\000\000\000\000\000\000\000\000\000\004\000\000\000\000\000\000\200\000\000\000\000\000__:\201\377~\000\000\250\346\260v\377~\000\000\270\314À\377~\000" nrprocs = 8 woneinit = 1 __FUNCTION__ = "main_loop" #11 0x000000000042c72a in main (argc=7, argv=0x7ffc2db9def8) at main.c:2696 cfg_stream = 0x1ee3010 c = -1 r = 0 tmp = 0x7ffc2db9ef2c "" tmp_len = 0 port = 0 proto = 0 options = 0x76a9a0 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 ---Type <return> to continue, or q <return> to quit--- info locals seed = 2620966285 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x2 p = 0x0 st = {st_dev = 20, st_ino = 22346, st_nlink = 2, st_mode = 16832, st_uid = 0, st_gid = 0, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1568107728, tv_nsec = 458000000}, st_mtim = { tv_sec = 1571064422, tv_nsec = 57000000}, st_ctim = {tv_sec = 1571064422, tv_nsec = 57000000}, __unused = {0, 0, 0}} __FUNCTION__ = "main" (gdb) list 104 register unsigned v; 105 register unsigned h; 106 107 h=0; 108 109 hash_update_str(s, s+len, p, v, h); 110 return hash_finish(h); 111 } 112 113 ``` #### Log Messages  ``` no relevant messages ``` #### SIP Traffic  ``` seems to be triggered by internal timer ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.4 (x86_64/linux) 759867 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 759867 compiled on 12:20:22 Sep 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` CentOS Linux release 7.4.1708 (Core) Linux xxx 3.10.0-957.12.2.el7.x86_64 #1 SMP Tue May 14 21:24:32 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2101

3 20

[kamailio/kamailio] module_db_mysql: Allow '@' in username/password for db_url URIs (#1346)
by Florian Floimair 12 Jan '22

12 Jan '22

#### Pre-Submission Checklist    - [x ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - It is allowed to use '@' within a username and/or a password for MySQL. Database as a Service providers like e.g. Microsoft Azure use these in usernames by default. The existing URI parser always treated the '@' as a separator between username:password and host:port/db parts of the URI. The parser now checks how many '@' characters are present in the URI and only treats the last occurence as separator for the host:port/db part. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1346 -- Commit Summary -- * module_db_mysql: Allow '@' in username/password for db_url URIs -- File Changes -- M src/modules/db_mysql/my_uri.c (35) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1346.patch https://github.com/kamailio/kamailio/pull/1346.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1346

2 4

[kamailio/kamailio] hostname in kubernetes (#2119)
by lazedo 11 Jan '22

11 Jan '22

### Description gethostname not accurate in kubernetes  ### Troubleshooting #### Reproduction  on a recent test with kamailio in kubernetes, found that gethostname can return only the hostname and not the fqdn. this depends on the kind of object is used (deployment/statefulset) ### Possible Solutions  the below patch fixed the issues i was having ``` diff --git a/src/modules/ipops/ipops_pv.c b/src/modules/ipops/ipops_pv.c index 5f77aa9..f65b4dd 100644 --- a/src/modules/ipops/ipops_pv.c +++ b/src/modules/ipops/ipops_pv.c @@ -455,6 +455,11 @@ if (gethostname(hbuf, 512)<0) { LM_WARN("gethostname failed - host pvs will be null\n"); return -1; + } else { + struct hostent* h; + if((h = gethostbyname(hbuf)) != NULL) { + memcpy(hbuf, h->h_name, 512); + } } hlen = strlen(hbuf); ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` latest master ``` * **Operating System**:  ``` buster & centos7 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2119

4 10

[kamailio/kamailio] erlang: getting null value in erl_xbuff in response of erl_rpc request (#2069)
by vipulpatel310 11 Jan '22

11 Jan '22

### Description **I did:** I have installed kamailio 5.2.4 in ubuntu system and configured kamailio script to connect with erlang node also it sends rpc request to erlang node and get response which I have printed in a logs. ... $erl_list(L) = "two"; $erl_list(L) = "one"; xlog("L_ALERT","Before RPC: $erl_list(args=>format)\n"); erl_rpc("erlang", "list_to_tuple", "$erl_list(args)", "$erl_xbuff(repl)"); xlogl("L_ALERT","type(reply): $erl_xbuff(repl=>type), format(repl): $erl_xbuff(repl=>format)\n"); ... **Expected to happen:** Response should be get from erlang node against RPC request and it should be store in erl_xbuff. And it should be print logs like: ALERT: <script>: 501:type(reply): tuple, format(repl): {"one", "two"} **Actually happened:** Response is getting properly. but the problem is to store data into xbuff so it print logs like: ALERT: <script>: 501:type(reply): <null>, format(repl): <null> ### Troubleshooting I have check with older version 4.3.0 and it works fine. getting this problem after 5.2.0 version So, I have compare 5.2.0 and 4.3.0 version code. I found one change in pv_xbuff.c file which is creating a problem when I revert the change then it works fine. #### Reproduction It will be reproducible everytime. Just sends rpc request and get the value in xbuff. check xbuff value #### Log Messages Problem logs: ``` ALERT: <script>: Before RPC: [["one", "two"]] WARNING: <core> [core/mem/q_malloc.c:480]: qm_free(): WARNING: free(0) called from erlang: pv_xbuff.c: xavp_decode(1209) ALERT: <script>: 501:type(reply): <null>, format(repl): <null> ``` logs after change: ``` ALERT: <script>: Before RPC: [["one", "two"]] WARNING: <core> [core/mem/q_malloc.c:480]: qm_free(): WARNING: free(0) called from erlang: pv_xbuff.c: xavp_decode(1209) ALERT: <script>: 501:type(reply): tuple, format(repl): {"one", "two"} ``` ### Possible Solutions revert the 6542a367638ec5f8a2b62994f8c309e7a2533962 commit. It will work fine ### Additional Information ``` version: kamailio 5.2.4 (x86_64/linux) 759867 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 759867 compiled on 11:52:55 Sep 4 2019 with gcc 7.4.0 ``` * **Operating System**: ``` Distributor ID: Ubuntu Description: Ubuntu 18.04 LTS Release: 18.04 Codename: bionic Linux hostname.domain.com 4.15.0-20-generic #21-Ubuntu SMP Tue Apr 24 06:16:15 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2069

2 3

[kamailio/kamailio] kamailio can't support send Rx_AAR for origin call (#1793)
by lsm808 11 Jan '22

11 Jan '22

Hi All, When kamailio(kamailio-5.0) receive 200 OK message, we need to send Rx_AAR for origin and term call. Rx_AAR("MT_aar_reply", "origin","",2); for origin call Rx_AAR("MT_aar_reply", "term","",2); for term call. But from source code ims_qos_mod.c, we see lots of part like below to not support for a request. Even we comments them, there are still lots of issues, could we support the scenarios like below: when kamailio receive 200 OK, we can send Rx_AAR for term and origin call. //We don't ever do AAR on request for calling scenario... if (msg->first_line.type != SIP_REPLY) { // Added by vlv // LM_DBG("Can't do AAR for call session in request\n"); // return result; } -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1793

2 4

[kamailio/kamailio] while passing different callid then actual for rtpengine_offer, rtpengine_answer and rtpengine_delete, rtpstats will not populate the stastics of rtpengine (#1788)
by Surendra Tiwari 11 Jan '22

11 Jan '22

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1788

2 4

[kamailio/kamailio] siptrace: option ping from nathelper do not get duplicated (#1722)
by Roman Dissauer 11 Jan '22

11 Jan '22

### Description when using kamailio with mod siptrace in trace mode, option pings from nathelper module and tls encrypted packets do not get duplicated ### Troubleshooting #### Reproduction  version: kamailio 5.1.6 (x86_64/linux) modparam("nathelper", "ping_nated_only", 0) modparam("siptrace", "trace_mode", 1) modparam("siptrace", "duplicate_uri", "sip:10.1.1.1:5888") when listening on sip:10.1.1.1:5888 all the duplicated sip packets arrive except option pings from nathelper and tls encrypted traffic (which should then be already decrypted by kamailio) ### Possible Solutions  seems that core triggers are not evaluated when using tls or nathelper option pings ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Linux AT1LKAM04 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1722

3 8

[kamailio/kamailio] evapi: if there is no evapi clients are connected to kamailio, evapi trying to send data. (#1700)
by Surendra Tiwari 11 Jan '22

11 Jan '22

### Description right now, evapi module trying to send data even if no clients are connected .in the case new transaction is created and even suspended also. kamailio should not create the transaction if no evapi client is connected to kamailio.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1700

2 3

[kamailio/kamailio] Feature request: Increase number of "custom fields" in sipcapture-module (#1278)
by mihovilkolaric 11 Jan '22

11 Jan '22

The module sipcapture provides the modparams "custom_field1_header" to "custom_field3_header", to store the content of up to three arbitrary header fields as separate columns in the database. They can be used as all other "standard" columns in homer. However I found out that searching/filtering for even more (standardized, as well as private) header fields would be very helpful (I identified about ten interesting additional headers, but the number is constantly increasing ;-) ). Could you thus please increase the number of custom fields? (I suppose the most flexible solution could be something as the db_extra in the acc-module, which is not fixed to certain columns (regarding number of columns, as well as their names) (see https://www.kamailio.org/docs/modules/5.0.x/modules/acc.html#acc.p.db_extra ).) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1278

2 2

[kamailio/kamailio] Diameter AVP handling from kamailio.cfg (#922)
by miricz 11 Jan '22

11 Jan '22

Below feature were discussed with Carsten Bock Currently Diameter AVP values and especially Experimental Result Code is not available from the kamailio.cfg Therefore I would like to request such kind of feature. I would like to use it mainly on Cx interface for Server-Assignment-Answer (SAA), Location-Info-Answer (LIA), Multimedia-Auth-Answer (MAA), Push-Profile-Answer (PPA) It should be implemented such a way like in the ims_charging module. Thank you very much in advance! _Cheers, Zoltan_ -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/922

2 2

[kamailio] add socket activation support (#293)
by zabbal 11 Jan '22

11 Jan '22

Having (optional) support for socket activation in Kamailio would bring several benefits: * Security: systemd can listen on privileged ports or socket paths and start Kamailio with privileges already dropped. * Major upgrades or reconfigurations of Kamailio requiring a full restart are possible without having the listening socket(s) ever go away. * Any service dependent on Kamailio doesn't have to wait for it to finish starting (or start at all). --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/293

3 4

[kamailio/kamailio] pv needed to get access to X509v3 Subject Alternative Names of peer's SSL certificate (#707)
by juha-h 11 Jan '22

11 Jan '22

A sip proxy may serve many domains listed in its SSL certificate X509v3 Subject Alternative Name field. In order to find out if a peer sip proxy is serving a particular domain, access would be needed in config file to this list of domains. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/707

4 4

[kamailio/kamailio] TLS module: access UID attribute (#1843)
by Sebastian Denz 24 Nov '21

24 Nov '21

### Description While implementing an edgeproxy based on kamailio i have to add a custom SIPHeader which contains the uid from the useragents client certificate. The UID is part of the subject like: O = Company CN = Sebastian Denz UID = denz But i cant access that attribute. All i can do is reading the CN and O. ### Expected behavior There should be a select to access the uid Attribute from the subject, or at least a select which returns the whole subject, so it can be parsed manually in kamailio.cfg. #### Actual observed behavior It is only possible to access the O and CN field from the subject. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` kamailio -v version: kamailio 5.2.0 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 5.3.1 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1843

4 24

[kamailio/kamailio] Store full JSON output of rtpengine_query in avp (#2130)
by hrantbagdasarian 23 Nov '21

23 Nov '21

### Description Currently the rtpengine_query function stores some values in predefined avps. I would like to have access to the whole output returned by the query to rtpengine. Sample provided at: https://github.com/sipwise/rtpengine#query-message ### Possible Solutions / Expected behavior Introduce a new avp which stores the full output in json format. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2130

2 2

[kamailio/kamailio] topos module producing invalid SIP message (missing Via header) when handling 200 OK to OPTIONS request (#1350)
by George Diamantopoulos 20 Oct '21

20 Oct '21

Hello all, I've come across the following issue with topos on Kamailio 5.1.0-rc2. ### Description Kamailio acts as a proxy for asterisk instances residing in a private IP range. Asterisk's peers are configured with their public IP address or hostname, but asterisk will dispatch requests to them to kamailio instead (because kamailio's IP is set in outboundproxy option in peer definition). This works fine for INVITEs, but if qualify=yes is set for the peer, asterisk will send out OPTIONs to monitor these peers. If the topos module is loaded, 200 OK replies to these OPTIONs will be malformed when forwarded from kamailio to asterisk (no Via header present). Disabling the topos module will resolve this. ### Troubleshooting #### Reproduction Configure a peer in asterisk with outboundproxy option set to kamailio's IP address. Set qualify=yes. Adjust kamailio's default configuration so that OPTIONs to other hosts besides itself are routed. Change the following section in request_route: ``` if ($rU==$null) { # request with no Username in RURI sl_send_reply("484","Address Incomplete"); exit; } ``` to: ``` if ( ($rU==$null) && !(is_method("OPTIONS")) ) { # request with no Username in RURI sl_send_reply("484","Address Incomplete"); exit; } # Permit asterisk's monitoring using options if(is_method("OPTIONS") && uri!=myself) { route(RELAY); } ``` Enable and configure the topos module with database. #### SIP Traffic asterisk:5060 -> kamailio:5060 ``` OPTIONS sip:peer.domain.tld SIP/2.0 Via: SIP/2.0/UDP asterisk:5060;branch=z9hG4bK460330cf;rport Max-Forwards: 70 From: "asterisk" <sip:asterisk@domain.tld>;tag=as690c2406 To: <sip:peer.domain.tld> Contact: <sip:asterisk@asterisk:5060> Call-ID: 6548f43b2d8740122186bb0c6e72ac78(a)domain.tld CSeq: 102 OPTIONS User-Agent: myUA Date: Sun, 03 Dec 2017 00:39:38 GMT Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Content-Length: 0 ``` kamailio:5060 -> peer:5060 ``` OPTIONS sip:peer.domain.tld SIP/2.0 Via: SIP/2.0/UDP kamailio:5060;branch=z9hG4bK460330cf;rport Max-Forwards: 69 From: "asterisk" <sip:asterisk@domain.tld>;tag=as690c2406 To: <sip:peer.domain.tld> Contact: <sip:asterisk@asterisk:5060> Call-ID: 6548f43b2d8740122186bb0c6e72ac78(a)domain.tld CSeq: 102 OPTIONS User-Agent: myUA Date: Sun, 03 Dec 2017 00:39:38 GMT Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Content-Length: 0 ``` peer:5060 -> kamailio:5060 ``` SIP/2.0 200 OK Via: SIP/2.0/UDP kamailio;branch=z9hG4bKda8d.cc03bd2def8ad36e8c43f61ab31a636f.0;received=kamailio;rport=5060 From: "asterisk" <sip:asterisk@domain.tld>;tag=as690c2406 To: <sip:peer.domain.tld>;tag=as472874ee Call-ID: 6548f43b2d8740122186bb0c6e72ac78(a)domain.tld CSeq: 102 OPTIONS Server: myUA Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Contact: <sip:peer:5060> Accept: application/sdp Content-Length: 0 ``` **kamailio:5060 -> asterisk:5060: Missing Via Header** ``` SIP/2.0 200 OK From: "asterisk" <sip:asterisk@domain.tld>;tag=as690c2406 To: <sip:peer.domain.tld>;tag=as472874ee Call-ID: 6548f43b2d8740122186bb0c6e72ac78(a)domain.tld CSeq: 102 OPTIONS Server: myUA Allow: INVITE, ACK, CANCEL, OPTIONS, BYE, REFER, SUBSCRIBE, NOTIFY, INFO, PUBLISH, MESSAGE Supported: replaces, timer Contact: <sip:peer:5060> Accept: application/sdp Content-Length: 0 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.0-rc2 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**: ``` Debian 9.1 ``` * **Other pertinent configuration information**: This kamailio box has several network interfaces. mhomed is not used, instead force_send_socket is called where necessary. I'm mentioning this in case it's what might trigger this issue with topos. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1350

4 18

[kamailio/kamailio] db_redis: add support for native redis cluster (#1997)
by George Diamantopoulos 15 Sep '21

15 Sep '21

The db_redis module seems to only support connecting with a single redis instance. It is not evident from the documentation if it implements support for native redis cluster by honouring 'MOVED' replies. ndb_redis seems to have support for native redis clusters, and supports both automatic (see allow_dynamic_nodes parameter of ndb_redis) and manual configuration of redis nodes. Since both modules are based on the hiredis library, is it safe to assume this support could be easily implemented, with some code sharing between the two modules perhaps? If db_redis supports clusters with automatic configuration only (by processing MOVED replies), perhaps the module's documentation should be updated to reflect that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1997

4 4

[kamailio/kamailio] Wrong Record-Route and Via header fields when TCP is used (#2033)
by leonid-xorcom 03 May '21

03 May '21

### Description Kamailio server has two legs that are connected to different networks. I'm using Kamailio v.5.2.3 and the "enable_double_rr" is implicitly set to "1". The leg "A" IP address is 10.28.80.1 The leg "B" IP address is 192.168.9.103 The call is initiated from 10.28.80.47 According to the "rr" module documentation, function record_route() should insert two "Record_Route" header fields when a request is accepted on one leg is should go out via the second leg. This works as expected in case of UDP protocol: INVITE sip:2601@192.168.0.178:49162;transport=udp SIP/2.0 Record-Route: <sip:192.168.9.103;r2=on;lr;did=e2c.a191> Record-Route: <sip:10.28.80.1;r2=on;lr;did=e2c.a191> Via: SIP/2.0/UDP 192.168.9.103;branch=z9hG4bKcfa5.d64ecbd87d5315b5993c4ccf16f86537.0 Via: SIP/2.0/UDP 10.28.80.47:5060;rport=5060;branch=z9hG4bK3a9e9a4d But when the TCP protocol is used AND "listen" parameters are defined: listen=udp:10.28.80.1:5060 listen=tcp:10.28.80.1:5060 listen=udp:192.168.9.103:5060 listen=tcp:192.168.9.103:5060 then the outbound message looks like this: INVITE sip:2601@192.168.0.178:48758;transport=tcp SIP/2.0 Record-Route: <sip:10.28.80.1;transport=tcp;lr;did=bcd.72f> Via: SIP/2.0/TCP 10.28.80.1;branch=z9hG4bKb9ca.26ea08654c9dbc32bb0dc6e3b6f92d45.0;i=3 Via: SIP/2.0/TCP 10.28.80.47:5060;rport=33976;branch=z9hG4bK5291fab1 There are two problems there: a) only one Record-Route with leg "A" is inserted b) the added "Via" header field contains the leg "A" IP address instead of expected leg "B" IP address (192.168.9.103). In the LAN trace, I see that in reality the message was sent from leg "B". IMPORTANT: The problem occurs only when the "listen" parameters are defined in the Kamailio configuration. When the "listens" are not configured then everything works correctly. ### Troubleshooting #### Reproduction #### Debugging Data #### Log Messages http://updates.xorcom.com/~xorcom/kam-tcp-problem.tar.gz The archive contains the following files: * syslog-bad.log and bad.cap - Kamailio log and tcpdump trace of a call when the problem occurs * syslog-good.log and good.cap - Kamailio log and tcpdump trace of a call when the problem doesn't occur #### SIP Traffic ### Possible Solutions ### Additional Information kamailio -v version: kamailio 5.2.3 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 7.3.0 ***Operating System**: Ubuntu 18.0.4 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2033

3 13

[kamailio/kamailio] import_file - wildcard support (#2125)
by sergey-safarov 31 Mar '21

31 Mar '21

### Description Could you extend `import_file` directive to support wildcards like ``` import_file "/run/kamailio/cfg/*" ``` This will allow place runtime config files with public IP of VM. Useful for cloud installation. ``` listen=udp:eth0 advertise 52.24.72.57:5060 listen=tcp:eth0 advertise 52.24.72.57:5060 ``` ### Expected behavior All files matched to wildcard included into config #### Actual observed behavior wildcard ignored -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2125

3 5

[kamailio/kamailio] lreproxy module (#2208)
by mojtabaesfandiari 03 Mar '21

03 Mar '21

lreproxy: add new lreproxy module   #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2208 -- Commit Summary -- * lreproxy module -- File Changes -- A src/modules/lreproxy/README.md (1) A src/modules/lreproxy/lreproxy.c (1976) A src/modules/lreproxy/lreproxy.h (120) A src/modules/lreproxy/lreproxy_funcs.c (460) A src/modules/lreproxy/lreproxy_funcs.h (41) A src/modules/lreproxy/lreproxy_hash.c (521) A src/modules/lreproxy/lreproxy_hash.h (70) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2208.patch https://github.com/kamailio/kamailio/pull/2208.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2208

9 59

[kamailio/kamailio] Kamailio not retrieving custom or default socket when sending timed REGISTER messages (#2262)
by kdanderso 26 Jan '21

26 Jan '21

### Description When using Kamailio in a multi-homed configuration to register with another device using the uac module, it does not retrieve the custom or default socket information for timed registration attempts. It does, however, use the custom/default socket data for the initial registration. #### Reproduction The network is configured for two addresses: 10.9.9.121/24 and 10.9.7.121/24. Two floating IP addresses are also assigned (via Pacemaker/Corosync): 10.9.9.120/24 and 10.9.7.120/24. For testing, all addresses can be assigned permanently, so it is not necessary to have Pacemaker/Corosync installed. MySQL database has a user in the uacreg table with the socket column set to udp:10.9.7.120:5060. kamailio.cfg includes the following to enable sending of REGISTER messages: mhomed = 1 listen=udp:10.9.9.120 listen=udp:10.9.7.120 #!define DBURL "mysql://kamailio:kamailiorw@10.9.9.101/kamailio" modparam("rr", "append_fromtag", 1); modparam("uac", "reg_db_url", DBURL); modparam("uac", "reg_contact_addr", "10.9.7.120:5060"); modparam("uac", "reg_keep_callid", 1); modparam("uac", "default_socket", "udp:10.9.7.120:5060"); modparam("uac", "reg_timer_interval", 30); #### Log Messages The initial REGISTER outputs the following log data. The registration completes successfully. Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: uac [uac.c:407]: child_init(): run initial uac registration routine Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: uac [uac_reg.c:1172]: uac_reg_update(): using custom socket udp:10.9.7.120:5060 to send request Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/socket_info.c:628]: grep_sock_info(): checking if host==us: 10==10 && [10.9.7.120] == [10.9.9.120] Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/socket_info.c:635]: grep_sock_info(): checking if port 5060 (advertise 0) matches port 5060 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/socket_info.c:628]: grep_sock_info(): checking if host==us: 10==10 && [10.9.7.120] == [10.9.7.120] Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/socket_info.c:635]: grep_sock_info(): checking if port 5060 (advertise 0) matches port 5060 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: tm [uac.c:435]: t_uac_prepare(): next_hop=<sip:10.9.7.102> Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: tm [uac.c:158]: dlg2hash(): hashid 3846 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: tm [uac.c:244]: t_run_local_req(): executing event_route[tm:local-request] Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:610]: parse_msg(): SIP Request: Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:612]: parse_msg(): method: <REGISTER> Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:614]: parse_msg(): uri: <sip:10.9.7.102> Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:616]: parse_msg(): version: <SIP/2.0> Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK60f.6fd7c907000000000000000000000000.0>; state=16 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/parse_via.c:2639]: parse_via(): end of header reached, state=5 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:498]: parse_headers(): Via found, flags=2 Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <core> [core/parser/msg_parser.c:500]: parse_headers(): this is the first via Mar 24 19:09:27 kam_test kamailio[8425]: exec: *** cfgtrace:local_route=[tm:local-request] c=[/usr/local/etc/kamailio/kamailio.cfg] l=229 a=26 n=xlog Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: <script>: In event_route(tm:local-request) Mar 24 19:09:27 kam_test kamailio[8425]: DEBUG: tm [uac.c:664]: send_prepared_request_impl(): uac: 0x7268e184 branch: 0 to 10.9.7.102:5060 When the timer expires, the following is logged. Since the socket is not found, the registration fails: Mar 24 19:09:57 kam_test kamailio[8425]: DEBUG: tm [uac.c:435]: t_uac_prepare(): next_hop=<sip:10.9.7.102> Mar 24 19:09:57 kam_test kamailio[8425]: ERROR: <core> [core/forward.c:181]: get_out_socket(): no socket found Mar 24 19:09:57 kam_test kamailio[8425]: ERROR: <core> [core/forward.c:183]: get_out_socket(): no corresponding socket found for(udp:10.9.7.102:5060) Mar 24 19:09:57 kam_test kamailio[8425]: ERROR: tm [ut.h:316]: uri2dst2(): no corresponding socket found for "10.9.7.102" af 2 (udp:10.9.7.102:5060) Mar 24 19:09:57 kam_test kamailio[8425]: ERROR: tm [uac.c:463]: t_uac_prepare(): no socket found Mar 24 19:09:57 kam_test kamailio[8425]: DEBUG: tm [h_table.c:132]: free_cell_helper(): freeing transaction 0x7268de10 from uac.c:604 Mar 24 19:09:57 kam_test kamailio[8425]: ERROR: uac [uac_reg.c:1196]: uac_reg_update(): failed to send request for [kamailioha] ### Additional Information version: kamailio 5.3.2 (arm6/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled on 17:22:05 Mar 18 2020 with gcc 8.3.0 * **Operating System**: Linux kam_test 4.19.75-v7+ #1270 SMP Tue Sep 24 18:45:11 BST 2019 armv7l GNU/Linux -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2262

4 6

[kamailio/kamailio] core: main - Protect async-signal-unsafe code in sig_usr() with SIG_DEBUG (#2127)
by Guillem Jover 02 Dec '20

02 Dec '20

#### Pre-Submission Checklist - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description The sig_usr() signal handler contains debug code to print memory usage and statistics that is not async-signal-safe, which can cause crashes or misbehavior. This code which only affects explicit SIGUSR1 signals on children processes, and is not guarded with the SIG_DEBUG macro. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2127 -- Commit Summary -- * core: main - Protect async-signal-unsafe code in sig_usr() with SIG_DEBUG -- File Changes -- M src/main.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2127.patch https://github.com/kamailio/kamailio/pull/2127.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2127

4 9

[kamailio/kamailio] Expand the list of required default 3rd party libraries for Kamailio (#969)
by Olle E. Johansson 02 Dec '20

02 Dec '20

(from devmeeting #Fosdem) - adding new dependencies as core dependencies - Curl - libssl - uuid - libunistring - libxml2 Any other candidates? They have to be libraries that are commonly installed on most Linux/Unix system. This would mean that a lot of more modules will be built by default, like TLS, HTTP_CLIENT, WEBSOCKET. We may also look over the names of the packages/groups for the build system and linux distros -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/969

2 3

[kamailio/kamailio] topos module seems to break re-SUBSCRIBE routing to downstream destinations (#1724)
by George Diamantopoulos 18 Nov '20

18 Nov '20

### Description Kamailio seems to fail to properly route in-dialog SUBSCRIBE with the topos module enabled. In this configuration, SUBSCRIBEs are expected to be delivered to a downstream UAS, an asterisk instance in the internal network. record_route() is executed for all initial requests, including SUBSCRIBEs. Routing is performed correctly with the topos module disabled, no other modifications were needed.  ### Troubleshooting I haven't been able to work around this issue in any other way other than disabling the topos module. #### Reproduction The configuration used is a heavily modified version of the example configuration file, but the handling of SUBSCRIBEs is generally simple. The initial SUBSCRIBE is subject to some tests, the R-URI is edited and dispatched to a farm of asterisk servers based on some criteria. Record Routing is enforced, so subsequent in-dialog re-SUBSCRIBEs are expected to be routed with loose_route(), which doesn't seem to handle things properly.  #### Debugging Data I'm attaching kamailio logs with debug=4, cfg_trace  #### Log Messages See attachments  #### SIP Traffic Please see: https://www.cloudshark.org/captures/d2643aae7f2a  ### Possible Solutions Using topoh instead for topos, but unfortunately this will break communication for other reasons (messages too large/UDP fragmentation for some peers). ### Additional Information * **Kamailio Version** Tried with kamailio 5.1.6 and kamailio 5.3.0-dev0 deb.kamailio.org repositories were used to acquire binaries for both versions * **Operating System**: Debian Stretch  [resubscribe.log](https://github.com/kamailio/kamailio/files/2586440/resubsc… -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1724

2 4

[kamailio/kamailio] uri_restore_rcv_alias() tried twice for local request (#2014)
by Alex Hermann 18 Nov '20

18 Nov '20

### Description While debugging an issue with locally generated in-dialog requests I stumbled upon some weirdness with the alias functionality from the nathelper module. The dialog modules tries to handle an alias parameter when sending an in-dialog request by calling ```uri_restore_rcv_alias()``` in the function ```build_dlg_t()```. A few instructions later, the same is attempted by the tm module in the function ```req_within()```. It seems to me that the attempt by the dialog module is redundant and can be removed. And while at it, IMHO it should be removed from the tm module too. This is functionality introduced by the nathelper module. Nowhere in the documentation it is mentioned there is some automatic handling of the alias parameter. If handling is needed for local requests, the script writer can call ```handle_uri_alias()``` from within local_route. If the functionality has to stay, may I suggest that the code in the nathelper module makes use of the ```uri_restore_rcv_alias()``` function instead of having its own duplicate implementation. Less maintenance, easier debugging. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2014

2 3

[kamailio/kamailio] rtpengine: stats for rtpengine command and reply from rtpengine (#1699)
by Surendra Tiwari 18 Nov '20

18 Nov '20

### Description rightnow, there is no stats about command sent to rtpengine and getting reply from rtpengine. There should be a stats that will tell that number of offer request sent: number of answer request sent: number of delete request sent: number of failed request for offer [after retry]: number of failed request for answer [after retry]: number of failed request for delete [after retry]: This will help to identify actual number of failed request.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1699

2 2

[kamailio/kamailio] 100% CPU usage after NTP date update (#2046)
by Benjamin Marty 18 Nov '20

18 Nov '20

#### Reproduction Install newest Kamailio 5.2. Change date e.g. 2 Years into the future. (Make sure you have no daemon running which prohibits those operations): ``` sudo date -s "2014-12-25 $(date +%H:%M:%S)" ``` ``` sudo date -s "2016-12-25 $(date +%H:%M:%S)" ``` Kamailio now uses the whole CPU to do stuff: ``` top - 08:10:35 up 14 days, 1:29, 2 users, load average: 3.77, 1.83, 1.05 Tasks: 212 total, 11 running, 201 sleeping, 0 stopped, 0 zombie %Cpu(s): 95.9 us, 1.5 sy, 2.2 ni, 0.0 id, 0.0 wa, 0.0 hi, 0.4 si, 0.0 st MiB Mem : 926.1 total, 116.3 free, 382.5 used, 427.3 buff/cache MiB Swap: 100.0 total, 40.4 free, 59.6 used. 423.4 avail Mem PID USER PR NI VIRT RES SHR S %CPU %MEM TIME+ COMMAND 13264 root 20 0 89720 3944 2676 R 44.9 0.4 0:05.15 kamailio 13266 root 20 0 89720 4000 2736 R 37.3 0.4 0:04.63 kamailio 13267 root 20 0 89720 4912 3488 R 36.0 0.5 0:04.37 kamailio 13270 root 20 0 89720 4540 3240 R 36.0 0.5 0:05.85 kamailio 13269 root 20 0 89720 4000 2736 R 34.7 0.4 0:04.81 kamailio 13265 root 20 0 89720 3944 2680 R 34.4 0.4 0:04.61 kamailio 13261 root 20 0 89720 3952 2676 R 32.2 0.4 0:04.44 kamailio 13262 root 20 0 89720 3944 2676 R 31.8 0.4 0:04.72 kamailio 13256 root 20 0 89720 4752 3540 R 30.3 0.5 0:07.04 kamailio 13268 root 20 0 89720 4000 2736 R 30.3 0.4 0:04.49 kamailio 18021 root 20 0 40116 11884 5728 D 13.7 1.3 0:01.11 apt-get ``` There are multiple mailing list entries regarding this issue: https://lists.kamailio.org/pipermail/sr-users/2015-October/090465.html https://lists.kamailio.org/pipermail/sr-users/2015-November/090487.html https://lists.kamailio.org/pipermail/sr-users/2019-June/105967.html https://lists.kamailio.org/pipermail/sr-users/2019-August/106428.html I was able to get rid of the issue with uncommenting the mentioned part of the code. But I'm quite sure that's not a fix :) ![image](https://user-images.githubusercontent.com/11159719/63680341-b6d67880-c7f3-11e9-825b-529e7ec26b2e.png) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2046

2 3

[kamailio/kamailio] add rtpproxy in kamailio/kamailio-ci:master-alpine (#2109)
by Gaurav Bmotra 05 Nov '20

05 Nov '20

hi can any one help me to add rtpproxy in kamailio/kamailio-ci:master-alpine thank you -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2109

3 12

[kamailio/kamailio] Can't install kamailio-sipcapture-daemon-config package due to missing dependency (#1861)
by pwakano 22 Oct '20

22 Oct '20

kamailio-sipcapture-daemon-config can't be installed because it depends on the kamailio-sipcapture package, which can't be found...  Use the http://download.opensuse.org/repositories/home:/kamailio:/v5.2.x-rpms/CentO… repo and try to install the kamailio-sipcapture-daemon-config. The dependency can't be resolved and so the package does not install. It is not clear if the dependency is missing or if it is not valid. ``` # yum install kamailio-sipcapture-daemon-config Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: mirror.optus.net * epel: mirror.optus.net * extras: mirror.intergrid.com.au * updates: mirror.intergrid.com.au Resolving Dependencies --> Running transaction check ---> Package kamailio-sipcapture-daemon-config.x86_64 0:5.2.1-1.el7.centos will be installed --> Processing Dependency: kamailio-sipcapture = 5.2.1 for package: kamailio-sipcapture-daemon-config-5.2.1-1.el7.centos.x86_64 --> Finished Dependency Resolution Error: Package: kamailio-sipcapture-daemon-config-5.2.1-1.el7.centos.x86_64 (home_kamailio_v5.2.x-rpms) Requires: kamailio-sipcapture = 5.2.1 You could try using --skip-broken to work around the problem You could try running: rpm -Va --nofiles --nodigest # yum deplist kamailio-sipcapture-daemon-config Loaded plugins: fastestmirror Loading mirror speeds from cached hostfile * base: mirror.optus.net * epel: mirror.optus.net * extras: mirror.intergrid.com.au * updates: mirror.intergrid.com.au package: kamailio-sipcapture-daemon-config.x86_64 5.2.1-1.el7.centos dependency: /bin/sh provider: bash.x86_64 4.2.46-31.el7 dependency: kamailio-sipcapture = 5.2.1 Unsatisfied dependency ```      * **Operating System**:  ``` # uname -a Linux voice-conn-kamailio-1 3.10.0-957.5.1.el7.x86_64 #1 SMP Fri Feb 1 14:54:57 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux # cat /etc/redhat-release CentOS Linux release 7.6.1810 (Core) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1861

3 11

[kamailio/kamailio] topos/topos_redis canceled and failed calls not deleted in redis (#2012)
by ohammami 11 Sep '20

11 Sep '20

### Description `topos-redis` does not clean entries for failed and canceled calls. modules are loaded in this order: ``` ... loadmodule "topos.so" loadmodule "ndb_redis.so" loadmodule "topos_redis.so" # ----- ndb_redis params ----- modparam("ndb_redis", "server", "name=srvC;addr=REDIS_HOST;port=REDIS_PORT;db=REDIS_DB_TOPOS") # ----- topos params ----- modparam("topos", "storage", "redis") modparam("topos_redis", "serverid", "srvC") modparam("topos", "mask_callid", 0) modparam("topos", "sanity_checks", 0) modparam("topos", "branch_expire", 30) modparam("topos", "dialog_expire", 14400) modparam("topos", "clean_interval", 10) ... ``` When a call is answered the timer are working fine and the records are cleaned after branch_expire timer. 1. call established ``` 10.0.1.11:6379[9]> KEYS * 1) "b:x:z9hG4bKe33b.1c2d440696a8e6d47f678fcf80962608.0" 2) "d:z:atpsh-5d305fc4-51c0-1" 3) "b:x:INVITE:6cbb3f3c-0470-474a-90e9-1d3f07d42a1a:as32b06c60" ``` 2. after 30s ``` 10.0.1.11:6379[9]> KEYS * 1) "d:z:atpsh-5d305fc4-51c0-1" ``` 4. call ends ``` 10.0.1.11:6379[9]> KEYS * 1) "b:x:z9hG4bKa4f4.d283ab69d26e3eadea338bb3cc28860e.0" 2) "d:z:atpsh-5d305fc4-51c0-1" ``` 5. after 30s ``` 10.0.1.11:6379[9]> KEYS * (empty list or set) ``` #### Issue description When the call fails or it's canceled ``` 10.0.1.11:6379[9]> KEYS * 1) "b:x:z9hG4bK6b04.0b594f71aba72f5f7f6f3ca8d7e57f04.0" 2) "d:z:atpsh-5d305fc4-51c3-1" 3) "b:x:INVITE:0319e114-c5b9-4dfc-91f0-392dc4239255:as018c9b6b" ``` after 30s ``` 10.0.1.11:6379[9]> KEYS * 1) "d:z:atpsh-5d305fc4-51c3-1" 10.0.1.11:6379[9]> TTL "d:z:atpsh-5d305fc4-51c3-1" (integer) 14319 ``` The record `d:z:atpsh-5d305fc4-51c3-1` is not cleaned by the cancel or busy...it will persist in the redis until it expires. I upgraded my machine from 5.1.3 to 5.1.8 after finding this fix #1608 which I noticed in the beginning. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.8 (x86_64/linux) c7a172 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c7a172 compiled on 05:42:57 Jun 19 2019 with gcc 4.8.5 ``` * **Operating System**: ``` 3.10.0-693.17.1.el7.x86_64 #1 SMP Thu Jan 25 20:13:58 UTC 2018 x86_64 x86_64 x86_64 GNU/Lin ``` ``` CentOS Linux release 7.4.1708 (Core) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2012

3 5

[kamailio/kamailio] Use kamilio to deploy as P-cscf, I-cscf, S-cscf to implement IMS functions. In the SIP call Flow , the P-CSCF will exit every time. (#2267)
by chenhao5651 11 Sep '20

11 Sep '20

### Description I use kamilio to deploy as P-cscf, I-cscf,S-cscf to implement IMS functions, two test phones attach kamilio and make volte call. The P-cscf will exit every time. ### Troubleshooting I think it may related to the collaboration between tm module and ipsec module. #### Reproduction I set up a test environment according to the instructions https://open5gs.org/open5gs/docs/tutorial/02-VoLTE-setup/ . two iphones connetc to the EPC and attach to kamailio,and the IPSec is available. #### Debugging Data Here is the gdb info ``` Reading symbols from /usr/local/sbin/kamailio...done. [New LWP 22934] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/local/sbin/kamailio -f /etc/kamailio_pcscf/kamailio_pcscf.cfg -P /var/run/'. Program terminated with signal SIGSEGV, Segmentation fault. #0 0x00007f1f4951f2d0 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 (gdb) bt #0 0x00007f1f4951f2d0 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x00007f1f494cefb4 in vfprintf () from /lib/x86_64-linux-gnu/libc.so.6 #2 0x00007f1f494d1370 in ?? () from /lib/x86_64-linux-gnu/libc.so.6 #3 0x00007f1f494ce7ea in vfprintf () from /lib/x86_64-linux-gnu/libc.so.6 #4 0x00007f1f494d78c4 in fprintf () from /lib/x86_64-linux-gnu/libc.so.6 #5 0x00007f1f44290629 in fill_contact (ci=0x7fff6d0ae1a0, m=0x7f1f48ee3280) at cmd.c:218 #6 0x00007f1f4429a29a in ipsec_forward (m=0x7f1f48ee3280, d=0x7f1f44a7efb8) at cmd.c:693 #7 0x00007f1f442890ac in w_forward (_m=0x7f1f48ee3280, _d=0x7f1f44a7efb8 "\270\356\247D\037\177", _cflags=0x0) at ims_ipsec_pcscf_mod.c:355 #8 0x000055713f26f2f1 in do_action (h=0x7fff6d0af080, a=0x7f1f48e7d3d8, msg=0x7f1f48ee3280) at core/action.c:1079 #9 0x000055713f27d2ab in run_actions (h=0x7fff6d0af080, a=0x7f1f48e79710, msg=0x7f1f48ee3280) at core/action.c:1578 #10 0x000055713f27dabd in run_top_route (a=0x7f1f48e79710, msg=0x7f1f48ee3280, c=0x7fff6d0af080) at core/action.c:1663 #11 0x00007f1f489dd18a in reply_received (p_msg=0x7f1f48ee3280) at t_reply.c:2418 #12 0x000055713f382183 in do_forward_reply (msg=0x7f1f48ee3280, mode=0) at core/forward.c:745 #13 0x000055713f383fcb in forward_reply (msg=0x7f1f48ee3280) at core/forward.c:846 #14 0x000055713f3e82a9 in receive_msg ( buf=0x55713f6c9ea0 <buf> "SIP/2.0 183 Session Progress\r\nRecord-Route: <sip:mt@192.168.4.207;transport=tcp;r2=on;lr=on;ftag=2573636716;rm=7;did=a1e.1e8>,<sip:mt@192.168.4.207;r2=on;lr=on;ftag=2573636716;rm=7;did=a1e.1e8>,<sip:m"..., len=1958, rcv_info=0x7fff6d0af5c0) at core/receive.c:510 #15 0x000055713f2d05e1 in udp_rcv_loop () at core/udp_server.c:548 #16 0x000055713f233c1e in main_loop () at main.c:1673 #17 0x000055713f23cff2 in main (argc=13, argv=0x7fff6d0afea8) at main.c:2802 ``` #### Log Messages Here is the P-cscf logs [pcscf.log](https://github.com/kamailio/kamailio/files/4401553/pcscf.log) #### SIP Traffic [traffic.zip](https://github.com/kamailio/kamailio/files/4401567/traffic.zip) ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2267

3 5

[kamailio/kamailio] Extend rtpengine hashing algorithms (#1986)
by Ionut Ionita 26 Aug '20

26 Aug '20

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #1911 #### Description  The goal was to have a different, more complex hashing algorithm that would offer a better distribution among nodes. We've seen in production that the current algorithm does not perform well under heavy load therefore we decided to add SHA1 hashing. After running performance tests we've decided that we need a cryptographic function in order to have the best results mostly when the callids have small entropy. In order to add SHA1, a new API was added in crypto module exporting a function applying SHA1 to a string. The API was used in rtpengine module over the callid. After this operation the hash was calculated as before except for applying 0xFF mask over the hash as it was done before, which restrains the power of this algorithm. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1986 -- Commit Summary -- * crypto: add exportable API and expose SHA1 hashing function * rtpengine: use SHA1 over callid for better distribution among nodes * rtpengine: add modparam to switch between legacy hashing algorithm and SHA1 * rtpengine: update README -- File Changes -- A src/modules/crypto/api.c (30) A src/modules/crypto/api.h (63) M src/modules/crypto/crypto_mod.c (2) M src/modules/crypto/crypto_uuid.c (34) M src/modules/crypto/crypto_uuid.h (8) M src/modules/rtpengine/doc/rtpengine_admin.xml (25) M src/modules/rtpengine/rtpengine.c (53) M src/modules/rtpengine/rtpengine.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1986.patch https://github.com/kamailio/kamailio/pull/1986.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1986

5 6

[kamailio/kamailio] Kamailio memory leak - versions 5.1.4 and 5.1.7 (#1895)
by Jay J 19 Aug '20

19 Aug '20

### Description Kamailio runs out of memory and stops processing requests. ``` ERROR: <core> [core/tcp_main.c:973]: tcpconn_new(): mem. allocation failure ERROR: <core> [core/tcp_main.c:4042]: handle_new_connect(): tcpconn_new failed, closing socket ERROR: uac [uac_reg.c:533]: reg_ht_add(): no more shm ERROR: uac [uac_reg.c:1347]: uac_reg_load_db(): Error adding reg to htable ``` ### Troubleshooting Restarting the Kamailio process resolves the issue #### Reproduction The issue occurs every 48 hours or so on the Kamailio instance #### Debugging Data ``` #kamcmd mod.stats all pkg Module: core { init_io_wait(475): 6480 init_dst_set(83): 32208 init_io_wait(524): 3576 yyparse(1782): 8 mk_new_net(52): 48 fix_param(1196): 128 route_new_list(200): 352 fix_expr(541): 616 exp_optimize_right(411): 40 fixup_regexp_null(213): 216 fix_param(1257): 352 yyparse(2729): 4872 mk_rval_expr1(2616): 68256 mk_elem(90): 976 mk_rval_expr2(2674): 321160 mk_rval_expr_v(2548): 768 mk_rval_expr_v(2537): 808136 mk_action(118): 196384 parse_params2(585): 560 set_mod_param_regex(121): 848 set_mod_param_regex(110): 264 tr_table_add(1875): 400 sr_cmd_exports_convert(235): 34160 register_module(280): 6192 load_module(496): 2072 new_sock_info(235): 176 new_sock_info(230): 3640 yyparse(642): 352 yyparse(1732): 288 add_alias(93): 80 add_alias(91): 128 yyparse(1446): 8 yyparse(2262): 296 yyparse(661): 416 subst_str(514): 416 subst_parser(301): 264 subst_parser(291): 2384 subst_parser(274): 960 pp_subst_add(57): 312 pp_define(1766): 1096 addstr(1399): 261168 str_hash_alloc(59): 512 pv_table_add(236): 22616 parse_pvname_list(1515): 2496 tr_new(1646): 1512 fix_match_rve(3028): 2152 pv_cache_add(347): 20664 fix_param(1162): 18936 init_modules(1026): 16 cnt_hash_add(383): 2048 db_do_init2(299): 336 dupl_string_name(72): 32 dupl_string(48): 144 new_db_id(272): 288 get_abs_pathname(262): 80 rpc_hash_add(146): 2048 pv_parse_format(1150): 40592 get_hdr_field(116): 232 parse_headers(320): 64 register_select_table(458): 104 rpc_hash_add(100): 26264 add_callback(59): 288 sr_wtimer_init(308): 136 cfg_new_group(79): 1160 cfg_declare(50): 4120 fix_socket_list(1509): 96 fix_sock_str(420): 912 fix_hostname(1301): 160 grp_hash_add(234): 952 pv_init_buffer(2055): 163840 pv_init_buffer(2045): 320 init_nonsip_hooks(43): 24 init_rlist(146): 40 route_add(124): 1784 str_hash_alloc(59): 768 rval_get_str(1256): 33648 init_counters(122): 128 cnt_hash_add(332): 26352 str_hash_alloc(59): 1280 Total: 2138200 } Module: ndb_redis { redis_parse_index(627): 88 pv_parse_redisc_name(704): 16496 redisc_add_server(257): 24064 Total: 40648 } Module: pv { tr_parse_string(2340): 64 tr_parse_string(2310): 192 tr_parse_string(2300): 192 tr_parse_string(2360): 32 tr_parse_string(2264): 544 add_var(65): 512 add_var(58): 2080 tr_parse_string(2275): 496 tr_parse_paramlist(2668): 32 Total: 4144 } Module: sqlops { sql_get_result(200): 64 pv_parse_dbr_name(134): 864 sql_init_con(83): 240 sqlops_tr_buffer_init(46): 2048 Total: 3216 } Module: textops { tr_txt_parse_re(212): 96 hname_fixup(2819): 616 fixup_method(2889): 1256 Total: 1968 } Module: xhttp_rpc { child_init(789): 832 Total: 832 } Module: db_mysql { db_mysql_new_connection(75): 4088 db_mysql_new_connection(65): 96 Total: 4184 } Module: auth { generate_random_secret(239): 32 generate_random_secret(238): 32 Total: 64 } Module: htable { pv_parse_ht_name(158): 160 fixup_ht_key(339): 88 Total: 248 } Module: xlog { xlog_fixup_helper(535): 17472 mod_init(214): 4104 xdbg_fixup_helper(500): 3352 Total: 24928 } Module: cnxcc { __alloc_redis(149): 24 __alloc_redis(146): 40 Total: 64 } Module: rtpengine { build_rtpp_socks(1611): 8 child_init(1768): 240 Total: 248 } Module: mangler { compile_expresions(557): 64 compile_expresions(541): 64 Total: 128 } Module: acc { parse_acc_extra(116): 672 Total: 672 } Module: rr { register_rrcb(61): 32 Total: 32 } Module: dialog { dlg_bridge_init_hdrs(66): 80 Total: 80 } Module: tm { Total: 0 } Module: uac { Total: 0 } Module: tls { Total: 0 } Module: sl { Total: 0 } Module: tmx { Total: 0 } Module: kex { Total: 0 } Module: usrloc { Total: 0 } Module: pike { Total: 0 } Module: websocket { Total: 0 } Module: cfgutils { Total: 0 } Module: nathelper { Total: 0 } Module: dispatcher { Total: 0 } ``` #### Log Messages ``` kamailio[6722]: ERROR: <core> [core/tcp_main.c:973]: tcpconn_new(): mem. allocation failure kamailio[6722]: ERROR: <core> [core/tcp_main.c:4042]: handle_new_connect(): tcpconn_new failed, closing socket kamailio[6722]: ERROR: tm [t_msgbuilder.c:1594]: build_uac_req(): no more shared memory (544) ``` ### Possible Solutions Restarting Kamailio ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.7 (x86_64/linux) 567df3 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 567df3 compiled on 04:30:41 Mar 14 2019 with gcc 7.3.0 ``` * **Operating System**: ``` cat /etc/lsb-release DISTRIB_ID=Ubuntu DISTRIB_RELEASE=18.04 DISTRIB_CODENAME=bionic DISTRIB_DESCRIPTION="Ubuntu 18.04.2 LTS" ``` ``` 4.15.0-1034-aws #36-Ubuntu SMP Tue Mar 5 23:17:16 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` ``` cat /proc/meminfo MemTotal: 4038176 kB MemFree: 130020 kB MemAvailable: 747324 kB Buffers: 15136 kB Cached: 2851248 kB SwapCached: 0 kB Active: 930936 kB Inactive: 2672836 kB Active(anon): 737672 kB Inactive(anon): 2097272 kB Active(file): 193264 kB Inactive(file): 575564 kB Unevictable: 0 kB Mlocked: 0 kB SwapTotal: 0 kB SwapFree: 0 kB Dirty: 120 kB Writeback: 0 kB AnonPages: 734064 kB Mapped: 2180672 kB Shmem: 2097544 kB Slab: 154288 kB SReclaimable: 101108 kB SUnreclaim: 53180 kB KernelStack: 4176 kB PageTables: 81940 kB NFS_Unstable: 0 kB Bounce: 0 kB WritebackTmp: 0 kB CommitLimit: 2019088 kB Committed_AS: 4529756 kB VmallocTotal: 34359738367 kB VmallocUsed: 0 kB VmallocChunk: 0 kB HardwareCorrupted: 0 kB AnonHugePages: 0 kB ShmemHugePages: 0 kB ShmemPmdMapped: 0 kB CmaTotal: 0 kB CmaFree: 0 kB HugePages_Total: 0 HugePages_Free: 0 HugePages_Rsvd: 0 HugePages_Surp: 0 Hugepagesize: 2048 kB DirectMap4k: 221184 kB DirectMap2M: 3973120 kB ``` Also, here is the output of "grep alloc qm_status.txt | awk '{ print substr( $0, 16, length($0) ) }' | sort | uniq -c | sort -k1n" (as per https://www.kamailio.org/wiki/tutorials/troubleshooting/memory): https://www.dropbox.com/s/act3whe6gumyzvj/alloc.txt?dl=1 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1895

8 41

[kamailio/kamailio] app_java.so: undefined symbol: JNI_CreateJavaVM please help (#1969)
by xevilstar 11 Aug '20

11 Aug '20

### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1969

4 29

[kamailio/kamailio] t_set_fr only works with UDP (#1966)
by Boden Garman 11 Aug '20

11 Aug '20

### Description Using t_set_fr within the LOCATION section of a slightly modified default kamailio.cfg only works if the contact is using UDP and not TCP. ``` # ----- tm params ----- # auto-discard branches from previous serial forking leg modparam("tm", "failure_reply_mode", 3) # default retransmission timeout: 30sec modparam("tm", "fr_timer", 30000) # default invite retransmission timeout after 1xx: 120sec modparam("tm", "fr_inv_timer", 30000) # User location service route[LOCATION] { [...] # per subscriber ring time if ($avp(s:ring_time) != $null) { # xlog("setting time out to $avp(s:ring_time)"); t_set_fr($avp(s:ring_time) * 1000); } } ```  #### Reproduction register an contact with UDP, set the timer to 5 seconds. observe kamailio terminates the invite after 5 seconds. then with TCP observe kamailio terminates the invite after 30 seconds (the default)  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.1 (x86_64/linux) 947769 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 947769 compiled on 20:48:14 Feb 26 2019 with gcc 4.8.5 ``` * **Operating System**: CentOS 7  -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1966

4 7

[kamailio/kamailio] RPM repos at https://rpm.kamailio.org (#2084)
by Daniel-Constantin Mierla 11 Aug '20

11 Aug '20

Build own repositories for RPM packages for various distros: CentOS, RedHate, OpenSuse ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2084

8 37

[kamailio/kamailio] rtpengine module is not retrying for rtpengine_offer. retry is working for rtpengine_answer and rtpengine_delete (#1696)
by Surendra Tiwari 11 Aug '20

11 Aug '20

### Description we are using rtpengine with kamailio [KSR-LUA]. kamailio sending the rtpengine_offer to rtpengine. If kamailio didn't get the response from the rtpengine then it's not retrying . for rtpengine_answer and rtpengine_delete retry is working pretty good. we are using following rtpengine configuration # ----- rtpengine params ----- modparam("rtpengine", "db_url", DBURL) modparam("rtpengine", "table_name" , "rtpengine") modparam("rtpengine", "rtpengine_allow_op", 1) modparam("rtpengine", "queried_nodes_limit", 4) modparam("rtpengine", "rtpengine_retr", 2) modparam("rtpengine", "rtp_inst_pvar", "$avp(RTP_INSTANCE)") modparam("rtpengine", "setid_default", 1) modparam("rtpengine", "rtpengine_tout_ms", 400)  ### Troubleshooting #### Reproduction This issue can be reproduced by above configuration. and need to use rtpengine_offer,rtpengine_answer and rtpengine_delete with ksr lua routing.  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.4 (x86_64/linux) a1df59 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: a1df59 compiled on 06:23:23 Oct 30 2018 with gcc 4.8.4 ``` * **Operating System**:  ``` root@ip-172-31-4-160:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 14.04.5 LTS Release: 14.04 Codename: trusty root@ip-172-31-4-160:~# uname -a Linux ip-172-31-4-160 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27 10:45:36 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1696

3 4

[kamailio/kamailio] Active dialog stats stays static on a passive kamailio node that replicates dialogs via DMQ (#1692)
by Joel Serrano 11 Aug '20

11 Aug '20

### Description In a setup with 2 kamailios in active/passive with a virtual IP that failovers between them: sbc01 (active) is handling calls. sbc02 (passive) is started, and does an initial dialog sync via DMQ ``` root@sbc01:~# kamctl rpc stats.get_statistics all | grep dialog "dialog:active_dialogs = 39", "dialog:early_dialogs = 2", "dialog:expired_dialogs = 0", "dialog:failed_dialogs = 583", "dialog:processed_dialogs = 2527", root@sbc01:~# ``` ``` root@sbc02:/etc/kamailio# kamctl rpc stats.get_statistics all | grep dialog "dialog:active_dialogs = 39", "dialog:early_dialogs = 0", "dialog:expired_dialogs = 0", "dialog:failed_dialogs = 0", "dialog:processed_dialogs = 0", root@sbc02:/etc/kamailio# ``` >From that point onwards, as long as sbc01 stays as active, sbc02 stays as passive, and no restarts occur anywhere, the values for `dialog` metrics in sbc02 will not change and remain as they are, in the previous example, active_dialogs would remain as 39. ### Troubleshooting This was discovered during some tests from #1591 #### Reproduction Setup 2 kamailio instances that replicate dialogs via DMQ. 1- On Kamailio1 put some traffic to have some active dialogs (must call `dlg_manage()` in routing script for these test calls) 2- Start Kamailio2 3- Compare output of: `kamcmd stats.get_statistics dialog:` on both nodes. 4- Alter the amount of active dialogs on Kamailio1 (either end some or create new ones). 5- Repeat step 3. Kamailio1 --> Step5 will have different values from Step3. Kamailio2 --> Step5 will have exactly the same values from Step3. ### Possible Solutions `dialog:active_dialogs` should remain as 0 on Kamailio2, as technically there are no dialogs being handled by that server, it only has information of replicated dialogs and those stats are available in the `dlg.stats_active` metric. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -V version: kamailio 5.2.0-pre1 (x86_64/linux) 2ecf60-dirty flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 2ecf60 -dirty compiled with gcc 6.3.0 ``` * **Operating System**:  ``` root@sbc02:~# lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 9.5 (stretch) Release: 9.5 Codename: stretch root@sbc02:~# uname -a Linux sbc02 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u6 (2018-10-08) x86_64 GNU/Linux root@sbc02:~# ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1692

2 2

[kamailio/kamailio] t_forward_nonack not decoding/unescaping URI (#2255)
by Julien Chavanton 10 Aug '20

10 Aug '20

### Description SIP OPTION relayed using `t_forward_nonack()` not being URI decoded  ### Troubleshooting #### Reproduction register with PATH and use SIP OPTION keep alive or simply send relay a SIP OPTIONS with a route. #### Debugging Data  ```#1 0x00007fa3067a998f in t_forward_nonack (t=0x7fa3246fce88, p_msg=0x7fa3885aa1c0, proxy=0x0, proto=0) at t_fwd.c:1729 1729 raise(SIGSEGV); (gdb) l 1724 ser_error=MIN_int(lowest_ret, E_CFG); 1725 return -1; 1726 } 1727 if(lowest_ret!=E_CFG) { 1728 LM_ERR("failure to add branches\n"); 1729 raise(SIGSEGV); << raising exception to get the coredump 1730 } 1731 ser_error=lowest_ret; 1732 return lowest_ret; 1733 } ``` #### Log Messages ``` 4(34) ERROR: tm [ut.h:245]: uri2dst2(): bad_uri: sip:247.25.169.51:52307%3Btransport%3Dtls 4(34) ERROR: tm [t_fwd.c:1728]: t_forward_nonack(): failure to add branches ``` ### Possible Solutions This patch can fix the problem from the routing script : ``` if (is_method("OPTIONS") && uri!=myself) { $var(path_uri) = $(hdr(Route){re.subst,/<(.*)>/\1/}); if (defined $(var(path_uri){uri.params}) && $(var(path_uri){uri.params}{param.value,received}) != "") { $var(received) = $(var(path_uri){uri.params}{param.value,received}); if ($var(received) =~ "sip:.*:.*") { $du = $var(received); $avp(received) = $(var(path_uri){uri.params}{param.value,received}); avp_subst("$avp(received)", "/%3Btransport%3Dtcp/;transport=tcp/ig"); if ($avp(received) =~ "sip:.*:.*") { $du = $avp(received); } } t_relay(); } ``` ### Additional Information tested on 5.3.2, something changed during 5.3.0.dev, I will try to pin point the commit -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2255

2 14

[kamailio] Anyone thinking about adding JWT (JSON Web Token) support to Kamailio (#29)
by mading087 24 Jul '20

24 Jul '20

It seems a good idea to support JWT as a new SIP authorization method. Wonder if anyone is interested? Think auth_db would be the best spot to add support for JWT. --- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/29

12 24

[kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)
by Sergey Basov 05 Jun '20

05 Jun '20

### Description Kamailio with TOPOS enabled acts as a proxy between SIP client and SBC. When client sends "180 Ringing" without Contact header - kamailio does not forward it to SBC. If Contact header exists in "180 Ringing" - all works as expected. ### Troubleshooting #### Reproduction Load and configure topos module Make call with "180 Ringing" without Contact header - kamailio will not forward it. #### Log Messages ``` ERROR: topos [tps_storage.c:340]: tps_storage_link_msg(): bad sip message or missing Contact hdr ``` #### SIP Traffic ``` SIP/2.0 180 Ringing Via: SIP/2.0/TLS 1.2.3.4:5061;branch=z9hG4bKef45.8c75f0bae8a59dfaec6ff533ff0f3b2d.0 From: <sip:1111@1.2.3.4:5061>;tag=02000879948559 To: <sip:2.2.2.2@5.6.7.8:5061;transport=tls;user=phone>;tag=SDbsq8499-y2pMOVV Call-ID: apdW7374315131g0bcGhEfDjFof CSeq: 988207425 INVITE User-Agent: agent Supported: replaces, outbound Content-Length: 0 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select ``` * **Operating System**: ``` Red Hat Enterprise Linux Server 7.3 3.10.0-514.el7.x86_64 #1 SMP Wed Oct 19 11:24:13 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1720

5 19

[kamailio/kamailio] Configure permissions module without database (#2037)
by Sebastian Damm 25 May '20

25 May '20

### Description In our setup, we try to eliminate setup configuration in database and replace it with files. The advantage is, that we can maintain those files via puppet or ansible, and since we always rewrite the whole file, we don't have to take care about deleting obsolete entries. We can run different Kamailio versions without having problems with the version table when using the same database. And finally, we can stop all those local mysqld processes on a lot of machines. Modules like the dispatcher module were easy to change. But the permissions module is not prepared to run without database, if you want to use `allow_trusted()` or `allow_source_address()` and similar. The only option to feed those functions with data is a database table. ### Expected behavior We would like to place files for trusted and address into the Kamailio directory and have Kamailio read from those files during startup or after reload commands. #### Actual observed behavior Data for trusted and address have to reside inside a database. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2037

3 4

[kamailio/kamailio] Allow more options on dispatcher.set_state (#2085)
by duarterocha91 22 May '20

22 May '20

Greetings, Dispatcher RPC command allows to change the runtime state of a GW using its Group ID and the IP. In my implementation i have 2 Kamailio machines in an HA setup and, as such, i have the GW configured twice with same group_id and different sockets (Different HA adressess - one for each machine). I would like to be able to disable on runtime GWs that are configured with an HA adress that isn't present yet on that machine. To be able do that, the combination of GroupID + IP is not enough, but Socket + IP would be enough. Is this possible to implement ? Best Regards -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2085

2 2

[kamailio/kamailio] error: 'pkg/docker' does not have a commit checked out (#2003)
by Daniel-Constantin Mierla 19 May '20

19 May '20

When I just tried to do a commit today, I got the following error: ``` kamailio $ git ci . error: 'pkg/docker' does not have a commit checked out fatal: updating files failed ``` It is related to the `pkg/docker` submodule referencing to kamailio/kamailio-ci. Not sure if this is due to a new git version or something else, because I did commits in that folder a few days ago. To get is sorted out, I did: ``` kamailio $ git submodule update pkg/docker Submodule path 'pkg/docker' not initialized Maybe you want to use 'update --init'? kamailio $ git submodule update --init pkg/docker Submodule 'pkg/docker' (https://github.com/kamailio/kamailio-ci.git) registered for path 'pkg/docker' Cloning into '/.../kamailio/pkg/docker'... Submodule path 'pkg/docker': checked out 'b92a1c899b8c474afadd0cf29dd7cb4ea01a3466' ``` Then it worked to do the commit. I wonder if this is going to break the process we were used with, specially the installation guidelines from GIT repo. Therefore I open this item to see if we really need the to have `pkg/docker` submodule, or better have the docker files directly in the repo. Other options to keep things sane and simple? Git version: ``` $ git --version git version 2.22.0 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2003

5 10

possible bug on kemi dlg_ontimeout
by David Escartin 15 May '20

15 May '20

Hello all Testing dialog timeout event callback for kemi lua setup on kamailio 5.4.0-dev3 (x86_64/linux) d74157-dirty, i had some problems to perform the dlg timeroute behaviour the same as we could on native version. If i used KSR.dialog.var_sets to set $dlg_ctx(timeout_route), I saw that on a dialog timeout, the dlg_ontimeout event route was not triggered, and only the dialog callback was executed with evname dialog:end. (only executing event_route -1 on state 5) So i'm guessing that the kemi dialog var_sets is for $dlg_var only (¿?) Anycase, If i used KSR.pv.sets, i saw the kamailio was crashing ..... 16(5579) DEBUG: dialog [dlg_hash.c:1013]: dlg_ref_helper(): ref dlg 0x7f9a961f5f90 with 1 -> 3 16(5579) DEBUG: dialog [dlg_handlers.c:1589]: dlg_ontimeout(): executing route -1 on timeout 22(5645) CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 8 22(5645) DEBUG: <core> [core/tcp_main.c:3762]: handle_ser_child(): dead child 16, pid 5579 (shutting down?) .... Adding some debug, i could see that the call was not attempting the kemi function of line 1598 of dlg_handlers.c, and was trying the code i think was for native on line 1593. We think the issue is that the toroute is defined as unsigned dlg_hash.h: unsigned int toroute; /*!< index of route that is executed on timeout */ but after that when setting $dlg_ctx(timeout_route) with pv module, it tries to compare an integer being unsigned, so it's always true and never uses kemi with this change we made it work + if ((int)(dlg->toroute) > 0) { + /*if(dlg->toroute>0) {*/ but i don't know maybe there is a better way to do it. best regards david

2 5

[kamailio/kamailio] Debian package version don't support distribution upgrades (#2160)
by Bas Couwenberg 14 May '20

14 May '20

When upgrading from stretch to buster the kamailio packages aren't upgraded because the 5.3.1+stretch version is greater than 5.3.1+buster: ``` $ dpkg --compare-versions 5.3.1+stretch gt 5.3.1+buster ; echo $? 0 ``` The package version should include the release version instead of its codename, e.g. 5.3.1+deb9u1 & 5.3.1+deb10u1 like done for [stable updates](https://www.debian.org/doc/manuals/developers-reference/pkgs.en.ht…: ``` $ dpkg --compare-versions 5.3.1+deb10u1 gt 5.3.1+deb9u1 ; echo $? 0 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2160

3 5

[kamailio/kamailio] support pkg-config when detecting libxml2 (#2199)
by Victor Seva 11 May '20

11 May '20

>From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=949521: > your package is using `xml2-config` to detect and use libxml2. I'm removing that script, so please update your build system to use pkg-config instead. > >Additionally, your package is not failing to build, so it's creating binaries that are not linked against libxml2 anymore: -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2199

4 12

[kamailio/kamailio] Continued OpenSSL 1.1 crashes with 5.3.0 (#2121)
by Nathan Whitehorn 05 May '20

05 May '20

### Description After upgrading to 5.3.0 from 5.2.2 (standard packages on FreeBSD 12.0), I am experiencing intermittent crashes related to handling of BYE messages. ### Troubleshooting #### Reproduction This happens ~ weekly and I have not found a good way to reproduce it. #### Debugging Data An example backtrace is below from the last dumped core (the SIGSEGV one); unfortunately it overwrote the earlier one: ``` * thread #1, name = 'kamailio', stop reason = signal SIGSEGV * frame #0: 0x00000008009c5b79 libc.so.7`___lldb_unnamed_symbol403$$libc.so.7 + 41 frame #1: 0x00000008009ed63e libc.so.7`__free + 990 frame #2: 0x000000080271562b libthr.so.3`pthread_rwlock_destroy + 59 frame #3: 0x0000000802bedbf6 libcrypto.so.111`CRYPTO_THREAD_lock_free + 22 frame #4: 0x0000000802aef3c4 libcrypto.so.111`RSA_free + 100 frame #5: 0x0000000802b10c32 libcrypto.so.111`EVP_PKEY_free + 66 frame #6: 0x000000080296ed86 libssl.so.111`___lldb_unnamed_symbol646$$libssl.so.111 + 134 frame #7: 0x000000080295f93c libssl.so.111`SSL_CTX_free + 236 frame #8: 0x00000008028aee42 tls.so`tls_free_domain + 114 frame #9: 0x00000008028af1d7 tls.so`tls_free_cfg + 199 frame #10: 0x00000008028af2df tls.so`tls_destroy_cfg + 191 frame #11: 0x00000008028ad1f1 tls.so`destroy_tls_h + 1185 frame #12: 0x000000000041adea kamailio`destroy_tls + 26 frame #13: 0x00000000002e36fd kamailio`cleanup + 269 frame #14: 0x00000000002eb5b7 kamailio`___lldb_unnamed_symbol5$$kamailio + 1351 frame #15: 0x00000000002ea5e5 kamailio`handle_sigs + 21669 frame #16: 0x00000000002fb83e kamailio`main_loop + 40014 frame #17: 0x0000000000307d2b kamailio`main + 50267 frame #18: 0x00000000002e311b kamailio`_start + 283 ``` This is with OpenSSL 1.1 With the LD_PRELOAD hack to 5.2.2, things were completely stable; I am trying to use kamailio without the LD_PRELOAD'ed mutex wrapper now, which I believe is no longer required. It looks like the SSL-related stuff in the TLS crash (which was 5 minutes later!) is unrelated to the initial problem and may just be an artifact of one of the kamailio processes crashing earlier. #### Log Messages ``` Nov 2 08:11:31 home /usr/local/sbin/kamailio[94702]: CRITICAL: {1 527440 BYE 973470944-5061-16392(a)BA.A.B.I} <core> [core/mem/q_malloc.c:149]: qm_debug_check_frag(): BUG: qm: prev. fragm. tail overwritten(c0c0c000, abcdefed)[0x801544c58:0x801544c90]! Memory allocator was called from core: core/action.c:754. Fragment marked by core: core/dset.c:733. Exec from core/mem/q_malloc.c:504. Nov 2 08:13:41 home /usr/local/sbin/kamailio[94703]: CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 22 Nov 2 08:13:41 home kernel: pid 94702 (kamailio), uid 0: exited on signal 6 (core dumped) Nov 2 08:13:41 home /usr/local/sbin/kamailio[94692]: ALERT: <core> [main.c:767]: handle_sigs(): child process 94702 exited by a signal 6 Nov 2 08:13:41 home /usr/local/sbin/kamailio[94692]: ALERT: <core> [main.c:770]: handle_sigs(): core was generated Nov 2 08:14:56 home login[8284]: ROOT LOGIN (root) ON ttyu0 Nov 2 08:16:26 home kernel: pid 94692 (kamailio), uid 0: exited on signal 11 (core dumped) ``` I had an identical problem a week ago, also with a crash on a BYE for an active call: ``` Oct 27 13:00:02 home /usr/local/sbin/kamailio[79819]: CRITICAL: {1 598425 BYE 649761149-5061-291(a)BA.A.B.I} <core> [core/mem/q_malloc.c:149]: qm_debug_check_frag(): BUG: qm: prev. fragm. tail overwritten(c0c0c000, abcdefed)[0x801551808:0x801551840]! Memory allocator was called from core: core/action.c:754. Fragment marked by core: core/dset.c:733. Exec from core/mem/q_malloc.c:504. Oct 27 13:02:09 home /usr/local/sbin/kamailio[79820]: CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 22 Oct 27 13:02:09 home kernel: pid 79819 (kamailio), uid 0: exited on signal 6 (core dumped) Oct 27 13:02:09 home /usr/local/sbin/kamailio[79809]: ALERT: <core> [main.c:767]: handle_sigs(): child process 79819 exited by a signal 6 Oct 27 13:02:09 home /usr/local/sbin/kamailio[79809]: ALERT: <core> [main.c:770]: handle_sigs(): core was generated Oct 27 13:04:55 home kernel: pid 79809 (kamailio), uid 0: exited on signal 11 (core dumped) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0 (x86_64/freebsd) 4cc67a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, select, kqueue. id: 4cc67a compiled on 18:51:34 Oct 25 2019 with cc 6.0 ``` * **Operating System**: FreeBSD 12.0 ``` FreeBSD home.XXX 12.0-RELEASE-p10 FreeBSD 12.0-RELEASE-p10 GENERIC amd64 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2121

2 16

[kamailio/kamailio] [Feature Request] Python3 compatibility for dbtextdb (#1747)
by Anthony Messina 04 May '20

04 May '20

kamctl's dbtextdb.py fails to build in a Python3-only environment. Update dbtextdb to Python3. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1747

4 12

[kamailio/kamailio] db_redis: warning: 'table_name.len' may be used uninitialized (#2169)
by sergey-safarov 23 Apr '20

23 Apr '20

``` CC (gcc) [M db_redis.so] redis_table.o CC (gcc) [M db_redis.so] db_redis_mod.o CC (gcc) [M db_redis.so] redis_connection.o In file included from ../../lib/srdb1/../../core/ut.h:42, from ../../lib/srdb1/db_key.h:31, from ../../lib/srdb1/db.h:43, from db_redis_mod.h:26, from redis_table.c:25: redis_table.c: In function 'db_redis_parse_keys': ../../lib/srdb1/../../core/dprint.h:303:8: warning: 'table_name.len' may be used uninitialized in this function [-Wmaybe-uninitialized] 303 | fprintf(stderr, "%2d(%d) %s: %.*s%s" fmt, \ | ^~~~~~~ redis_table.c:494:9: note: 'table_name.len' was declared here 494 | str table_name; | ^~~~~~~~~~ In file included from ../../lib/srdb1/../../core/ut.h:42, from ../../lib/srdb1/db_key.h:31, from ../../lib/srdb1/db.h:43, from db_redis_mod.h:26, from redis_table.c:25: ../../lib/srdb1/../../core/dprint.h:303:8: warning: 'table_name.s' may be used uninitialized in this function [-Wmaybe-uninitialized] 303 | fprintf(stderr, "%2d(%d) %s: %.*s%s" fmt, \ | ^~~~~~~ redis_table.c:494:9: note: 'table_name.s' was declared here 494 | str table_name; | ^~~~~~~~~~ redis_table.c:581:38: warning: 'table' may be used uninitialized in this function [-Wmaybe-uninitialized] 581 | table->types = type_target = type; | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~ CC (gcc) [M db_redis.so] redis_dbase.o make[3]: 'libsrdb2.so.1.0' is up to date. make[3]: 'libsrdb1.so.1.0' is up to date. ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2169

4 12

[kamailio/kamailio] Kamailio 5.3.0 crashed when exec module tried to execute external program (#2165)
by Konstantin 22 Apr '20

22 Apr '20

### Description  In some cases we need to call zabbix_sender utility to notify that some failure happens. At this time we move our configs from Kamailio 4.4.7 to Kamailio 5.3.0 and during testing we meet this issue. We configured exec module to kill the program after 20 seconds ``` modparam("exec", "time_to_kill", 20) .... exec_avp("/usr/bin/zabbix_sender --config ZABBIX_AGENT_CONFIG_PATH --key ecsp_no_telephony --value 1"); ``` zabbix_sender could not connect to server and were hanged up. Kamailio probably tried to kill it and crashed. ### Troubleshooting #### Reproduction  #### Debugging Data  ``` Dec 5 12:25:08 sip-proxy01 /usr/ecsp/sbin/kamailio[12458]: NOTICE: <script>: zabbix_sender (ecsp_no_telephony) Dec 5 12:25:09 sip-proxy01 /usr/ecsp/sbin/kamailio[12417]: ALERT: <core> [main.c:767]: handle_sigs(): child process 12458 exited by a signal 11 Dec 5 12:25:09 sip-proxy01 /usr/ecsp/sbin/kamailio[12466]: CRITICAL: <core> [core/pass_fd.c:277]: receive_fd(): EOF on 50 Dec 5 12:25:09 sip-proxy01 /usr/ecsp/sbin/kamailio[12417]: ALERT: <core> [main.c:770]: handle_sigs(): core was generated ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0 (x86_64/linux) 4cc67a flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 4cc67a compiled on 14:01:24 Nov 28 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` Linux sip-proxy01 3.10.0-1062.4.1.el7.x86_64 #1 SMP Fri Oct 18 17:15:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux CentOS Linux release 7.7.1908 (Core) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2165

3 15

[kamailio/kamailio] ims_registrar_scscf: fix multiple contacts in NOTIFY (#2246)
by alexyosifov 21 Apr '20

21 Apr '20

- Prevent multiple contacts for NOTIFY message in Message body <registration> tag after RE-REGISTRATION procedure.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2246 -- Commit Summary -- * ims_registrar_scscf: fix multiple contacts in NOTIFY -- File Changes -- M src/modules/ims_registrar_scscf/registrar_notify.c (86) M src/modules/ims_registrar_scscf/registrar_notify.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2246.patch https://github.com/kamailio/kamailio/pull/2246.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2246

5 16

[kamailio/kamailio] TLS module compiled with outdated OpenSSL version for Ubuntu bionic (#2018)
by welljsjs 14 Apr '20

14 Apr '20

### Description  Ubuntu Bionic 18.04.02 LTS ships with "OpenSSL 1.1.1 11 Sep 2018" (0x1010100f), whereas the `kamailio-tls-modules` package is compiled with "OpenSSL 1.1.0g 2 Nov 2017" (0x1010007f). I installed Kamailio from the Kamailio repositories (not from the Ubuntu repositories). This leads to Kamailio being unable to start as it complains about the OpenSSL versions being too different from each other. Overriding the OpenSSl version check by enabling `tls_force_run` does not solve the issue, instead, it leads to Kamailio emitting multiple errors.  #### Reproduction I installed Kamailio from the official Kamailio apt sources (nightly build, the same occurs for the latest stable version 5.2). ``` deb http://deb.kamailio.org/kamailiodev-nightly bionic main deb-src http://deb.kamailio.org/kamailiodev-nightly bionic main ``` I enabled TLS and edited the configuration files accordingly.    ``` (paste your debugging data here) ``` #### Log Messages ``` CRITICAL: tls [tls_init.c:677]: init_tls_h(): installed openssl library version is too different from the library the kamailio tls module was compiled with: installed "OpenSSL 1.1.1 11 Sep 2018" (0x1010100f), compiled "OpenSSL 1.1.0g 2 Nov 2017" (0x1010007f).#012 Please make sure a compatible version is used (tls_force_run in kamailio.cfg will override this check) ```  ### Possible Solutions Recompile and publish the `kamailio-tls-modules` package compiled with OpenSSL 1.1.1b. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.0-dev6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 7.3.0 ``` * **Operating System**:  ``` Linux hostname 4.15.0-55-generic #60-Ubuntu SMP Tue Jul 2 18:22:20 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Description: Ubuntu 18.04.2 LTS Release: 18.04 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2018

4 13

[kamailio/kamailio] dialog: extract/dump a large amount (#2269)
by Julien Chavanton 08 Apr '20

08 Apr '20

### Description The commands available to extract dialog information `dlg.profile_list` and `dlg.list` Are not fast enough to output a large amount of dialogs. After doing some benchmark the time is spent in in `rpc->struct_add`, `rpc->add etc`, etc. it appears to be slowing down linearly. ### Possible Solutions I made a quick POC to verify what I can get if I output to file instead and I got blazing fast performance, this is good news since it means that iterating over the hash table etc. is super fast. https://github.com/jchavanton/kamailio/commit/f28c5a6b6364d79ee35acb5be439e… ``` dialog: outputing large amount of dialogs to file Test: 1) injecting 100K dialogs with voip_perf 2) confirmation that we have 100K+ dialogs kamcmd dlg.profile_get_size outbound_call 100879 3) execute the quickly hacked modifications to output to /tmp/dialogs.txt kamctl rpc dlg.profile_list outbound_call 3.1) verify how long it took 2020-03-31T22:28:18.398916476Z 12(31) : dialog [dialog.c:2174]: internal_rpc_profile_print_dlgs(): profile->lock 2020-03-31T22:28:18.554379411Z 12(31) : dialog [dialog.c:2190]: internal_rpc_profile_print_dlgs(): profile->lock release // command took less then 20ms 3.2) verify the content of the output wc /tmp/dialogs.txt 124355 117324 20547037 /tmp/dialogs.txt Note about the content // not everything is outputed in this quick hack but we can imagine that the impact will be very low. call-id[uV.YzlhIZd1inE8SYDAlzmOLG12tYqVS]from[sip:voip_perf@147.75.65.247]to[sip:12060412757@52.42.112.21]h_entry[6207]h_id[44579]ref[2]contact[sip:voip_perf@147.75.65.247:5072;transport=udp]cseq[19528] ``` ### Additional Information I am thinking about adding commands to output to file in `json` and/or `csv` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2269

1 1

[kamailio/kamailio] Support for 192.0.0.0/29 as NATed source (#1488)
by dtryba 07 Apr '20

07 Apr '20

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  192.0.0.0/29 is a reserved subnet for NATtin IPv4 across an IPv6 netwerk. For example Dual Stack Lite carrier grade NAT. This is small change and updates the subnets used for NAT according to https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-speci… You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/1488 -- Commit Summary -- * Support for -- File Changes -- M src/modules/ipops/detailed_ip_type.c (1) M src/modules/ipops/detailed_ip_type.h (2) M src/modules/nat_traversal/nat_traversal.c (3) M src/modules/nathelper/nathelper.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/1488.patch https://github.com/kamailio/kamailio/pull/1488.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/1488

3 4

siptrace inconsistency
by Federico Cabiddu 07 Apr '20

07 Apr '20

Hi all, I've been recently testing 5.3.x/master siptrace module, in particular the new trace mode "t" vs the legacy flag + sip_trace() mode and I've found some issues with the handling of CANCEL. Specifically, I've tested the following scenarios: 1) sip_trace_mode("t") on the initial INVITE only: received ACK for negative replies not captured 2) sip_trace_mode("t") on the initial INVITE and on neg ACK: received ACK captured twice 3) setflag and sip_trace() on the initial INVITE only: received CANCEL and ACK not captured (outgoing yes) 4) setflag and sip_trace() on the initial INVITE and ACK: received CANCEL not captured, received ACK captured twice 5) setflag and sip_trace() for each message (legacy): received CANCEL and 200 captured twice, received ACK captured twice Digging into the module's code the "culprit" looks to be trace_is_off function ( https://github.com/kamailio/kamailio/blob/2768f8ce1cf6da242674e7e40c8e76eb6…) and the places where it is called. E.g.: for the case 1), when a negative reply is received, trace_tm_neg_ack_in is called, which calls inside trace_is_off ( https://github.com/kamailio/kamailio/blob/2768f8ce1cf6da242674e7e40c8e76eb6…), which cannot be true unless the ACK has been marked for capture in the script, in which case it will be capture twice (case 2). The same applies to the CANCEL for case 3), in trace_onreq_out (callback for TMCB_E2ECANCEL_IN) trace_is_off because the incoming message is not flagged. Case 3) should theoretically behave like case 1) according to commit https://github.com/kamailio/kamailio/commit/40e09d8625184f19ff5666a2848cbb8… . I'm not really sure if (and how) modify the trace_is_off function or not calling it in specific cases. E.g.: why calling it in trace_tm_neg_ack_in? This callback is set when we explicity want to trace a transaction, so why checking inside if tracing is on? Maybe I'm missing something, but I think that probably the different behaviors of the modes should be better specified/decided. Best regards, Federico

3 15

[kamailio/kamailio] tls: add support for escaped cert PVs and select (#2268)
by Armen Babikyan 06 Apr '20

06 Apr '20

- new PVs: $tls_peer_escaped_cert, $tls_my_escaped_cert - new selects: @tls.peer.escaped_cert, @tls.my.escaped_cert You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2268 -- Commit Summary -- * tls: add support for escaped cert PVs and select -- File Changes -- M src/modules/tls/tls_select.c (106) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2268.patch https://github.com/kamailio/kamailio/pull/2268.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2268

3 10

[kamailio/kamailio] kamctl: added secfilter to dbtext (#2261)
by Igor Olhovskiy 04 Apr '20

04 Apr '20

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [X] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Added secfilter module scheme to dbtext, as per using `kamdbctl create` with DBTEXT, was getting following error ``` cp: cannot stat '/usr/share/kamailio//dbtext/kamailio/secfilter': No such file or directory ``` With this patch error is gone. Secfilter DBTEXT scheme is taken from SQLite scheme. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2261 -- Commit Summary -- * kamctl: added secfilter to dbtext -- File Changes -- A utils/kamctl/dbtext/kamailio/secfilter (1) M utils/kamctl/dbtext/kamailio/version (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2261.patch https://github.com/kamailio/kamailio/pull/2261.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2261

2 4

git:master:5a166124: modules: readme files regenerated - tcpops ... [skip ci]
by Kamailio Dev 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: 5a16612493f9d6622f2c22fa83864295c7b55c9b URL: https://github.com/kamailio/kamailio/commit/5a16612493f9d6622f2c22fa8386429… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-31T11:31:21+02:00 modules: readme files regenerated - tcpops ... [skip ci] --- Modified: src/modules/tcpops/README --- Diff: https://github.com/kamailio/kamailio/commit/5a16612493f9d6622f2c22fa8386429… Patch: https://github.com/kamailio/kamailio/commit/5a16612493f9d6622f2c22fa8386429… --- diff --git a/src/modules/tcpops/README b/src/modules/tcpops/README index 4c08b3624b..70209686f0 100644 --- a/src/modules/tcpops/README +++ b/src/modules/tcpops/README @@ -32,6 +32,8 @@ Olle E. Johansson 3.5. tcp_set_connection_lifetime([conid], lifetime) 3.6. tcp_enable_closed_event([conid]) 3.7. tcp_get_conid(hostport, pvname) + 3.8. tcp_set_otcpid(conid) + 3.9. tcp_set_otcpid_flag(mode) 4. Event routes @@ -51,6 +53,8 @@ Olle E. Johansson 1.7. tcp_set_connection_lifetime usage 1.8. tcp_set_closed_event usage 1.9. tcp_get_conid usage + 1.10. tcp_set_otcpid usage + 1.11. tcp_set_otcpid_flag usage Chapter 1. Admin Guide @@ -71,6 +75,8 @@ Chapter 1. Admin Guide 3.5. tcp_set_connection_lifetime([conid], lifetime) 3.6. tcp_enable_closed_event([conid]) 3.7. tcp_get_conid(hostport, pvname) + 3.8. tcp_set_otcpid(conid) + 3.9. tcp_set_otcpid_flag(mode) 4. Event routes @@ -144,6 +150,8 @@ end 3.5. tcp_set_connection_lifetime([conid], lifetime) 3.6. tcp_enable_closed_event([conid]) 3.7. tcp_get_conid(hostport, pvname) + 3.8. tcp_set_otcpid(conid) + 3.9. tcp_set_otcpid_flag(mode) 3.1. tcp_conid_alive(conid) @@ -345,6 +353,53 @@ event_route[tcp:closed] { } ... +3.8. tcp_set_otcpid(conid) + + Set the value for outbound tcp connection id. + + Meaning of the parameters is as follows: + * conid - the value of tcp connection id. It can be an integer number + or a variable holding an interver value. + + Return values: + * 1: success + * -1: failure + + Example 1.10. tcp_set_otcpid usage +... + $var(conid) = 10; + tcp_set_otcpid("$var(conid)"); +... + +3.9. tcp_set_otcpid_flag(mode) + + Set or reset the internal flag for using or not the outbound tcp + connection id for sending out. The outbound connection id can be set by + module or by config using tcp_set_otcpid(...) function. An example of a + module setting the otcpid is register via lookup location function, + which sets the filed to the connection id used to receive the + registration request. + + Meaning of the parameters is as follows: + * mode - if 0, then the flag is reset, otherwise it is set. + + Return values: + * 1: success + * -1: failure + + Note: if you set the flag to use the outbound tcp connection id, then + custom config changes to the destination address, like updating the + r-uri ($ru) or dst uri ($du) are not resetting it, so the same already + set connection id is used and the SIP request might be sent to the + unexpected destination. Reset the flag in such case, if you set it + previously. + + Example 1.11. tcp_set_otcpid_flag usage +... + $var(cmode) = 1; + tcp_set_otcpid_flag("$var(cmode)"); +... + 4. Event routes 4.1. tcp:closed

1 0

git:master:d6e94d07: tcpops: docs for tcp_set_otcpid() and tcp_set_otcpid_flag() functions
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: d6e94d074a2a1f1af2964f1ed7f24602a8dd295a URL: https://github.com/kamailio/kamailio/commit/d6e94d074a2a1f1af2964f1ed7f2460… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T11:23:20+02:00 tcpops: docs for tcp_set_otcpid() and tcp_set_otcpid_flag() functions --- Modified: src/modules/tcpops/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/d6e94d074a2a1f1af2964f1ed7f2460… Patch: https://github.com/kamailio/kamailio/commit/d6e94d074a2a1f1af2964f1ed7f2460… --- diff --git a/src/modules/tcpops/doc/functions.xml b/src/modules/tcpops/doc/functions.xml index 9c6409c4e6..94cefaa776 100644 --- a/src/modules/tcpops/doc/functions.xml +++ b/src/modules/tcpops/doc/functions.xml @@ -290,6 +290,87 @@ event_route[tcp:closed] { if(tcp_get_conid("127.0.0.1:5060", "$var(conid)")) { xlog("connection id is: $var(conid)\n"); } +... + ]]></programlisting> + </example> + </section> + <section id="tcpops.f.tcp_set_otcpid"> + <title> + <function>tcp_set_otcpid(conid)</function> + </title> + <para> + Set the value for outbound tcp connection id. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para><emphasis>conid</emphasis> - the value of tcp connection id. + It can be an integer number or a variable holding an interver value. + </para> + </listitem> + </itemizedlist> + <para>Return values:</para> + <itemizedlist> + <listitem> + <para>1: success</para> + </listitem> + <listitem> + <para>-1: failure</para> + </listitem> + </itemizedlist> + <example> + <title><function>tcp_set_otcpid</function> usage</title> + <programlisting><![CDATA[ +... + $var(conid) = 10; + tcp_set_otcpid("$var(conid)"); +... + ]]></programlisting> + </example> + </section> + <section id="tcpops.f.tcp_set_otcpid_flag"> + <title> + <function>tcp_set_otcpid_flag(mode)</function> + </title> + <para> + Set or reset the internal flag for using or not the outbound tcp + connection id for sending out. The outbound connection id can be + set by module or by config using tcp_set_otcpid(...) function. An + example of a module setting the otcpid is register via lookup location + function, which sets the filed to the connection id used to receive + the registration request. + </para> + <para>Meaning of the parameters is as follows:</para> + <itemizedlist> + <listitem> + <para><emphasis>mode</emphasis> - if 0, then the flag is reset, + otherwise it is set. + </para> + </listitem> + </itemizedlist> + <para>Return values:</para> + <itemizedlist> + <listitem> + <para>1: success</para> + </listitem> + <listitem> + <para>-1: failure</para> + </listitem> + </itemizedlist> + <para> + Note: if you set the flag to use the outbound tcp connection id, + then custom config changes to the destination address, like + updating the r-uri ($ru) or dst uri ($du) are not resetting it, so + the same already set connection id is used and the SIP request + might be sent to the unexpected destination. Reset the flag in such + case, if you set it previously. + </para> + <example> + <title><function>tcp_set_otcpid_flag</function> usage</title> + <programlisting><![CDATA[ +... + $var(cmode) = 1; + tcp_set_otcpid_flag("$var(cmode)"); ... ]]></programlisting> </example>

1 0

git:master:f84fd657: tcpops: function to control use of outbound tcp connection id
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: f84fd65707ff05c51f1b1764c42c98479ef74a14 URL: https://github.com/kamailio/kamailio/commit/f84fd65707ff05c51f1b1764c42c984… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T11:08:51+02:00 tcpops: function to control use of outbound tcp connection id - tcp_set_otcpid(id) - set the id for outbound tcp connection - tcp_set_otcpid_flag(mode) - set/reset the internal flag for using outbound tcp connection id --- Modified: src/modules/tcpops/tcpops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f84fd65707ff05c51f1b1764c42c984… Patch: https://github.com/kamailio/kamailio/commit/f84fd65707ff05c51f1b1764c42c984… --- diff --git a/src/modules/tcpops/tcpops_mod.c b/src/modules/tcpops/tcpops_mod.c index b95a642f8d..ee2404a9ac 100644 --- a/src/modules/tcpops/tcpops_mod.c +++ b/src/modules/tcpops/tcpops_mod.c @@ -62,6 +62,8 @@ static int w_tcp_conid_state(sip_msg_t* msg, char* con, char *p2); static int w_tcp_conid_alive(sip_msg_t* msg, char* con, char *p2); static int w_tcp_get_conid(sip_msg_t* msg, char *paddr, char *pvn); static int fixup_numpv(void** param, int param_no); +static int w_tcp_set_otcpid(sip_msg_t* msg, char* conid, char *p2); +static int w_tcp_set_otcpid_flag(sip_msg_t* msg, char* mode, char *p2); str tcpops_event_callback = STR_NULL; @@ -98,6 +100,10 @@ static cmd_export_t cmds[]={ fixup_spve_pvar, fixup_free_spve_pvar, ANY_ROUTE}, {"tcp_conid_alive", (cmd_function)w_tcp_conid_alive, 1, fixup_numpv, 0, ANY_ROUTE}, + {"tcp_set_otcpid", (cmd_function)w_tcp_set_otcpid, 1, + fixup_igp_all, fixup_free_igp_all, ANY_ROUTE}, + {"tcp_set_otcpid_flag", (cmd_function)w_tcp_set_otcpid_flag, 1, + fixup_igp_all, fixup_free_igp_all, ANY_ROUTE}, {0, 0, 0, 0, 0, 0} }; @@ -612,6 +618,62 @@ static int w_tcp_get_conid(sip_msg_t* msg, char *paddr, char *pvn) return ki_tcp_get_conid_helper(msg, &saddr, (pv_spec_t*)pvn); } +/** + * + */ +static int ki_tcp_set_otcpid(sip_msg_t* msg, int vconid) +{ + if(msg == NULL) { + return -1; + } + msg->otcpid = vconid; + return 1; +} + +/** + * + */ +static int w_tcp_set_otcpid(sip_msg_t* msg, char* conid, char *p2) +{ + int vconid = 0; + + if(fixup_get_ivalue(msg, (gparam_t*)conid, &vconid)<0) { + LM_ERR("failed to get connection id\n"); + return -1; + } + return ki_tcp_set_otcpid(msg, vconid); +} + +/** + * + */ +static int ki_tcp_set_otcpid_flag(sip_msg_t* msg, int vmode) +{ + if(msg == NULL) { + return -1; + } + if(vmode) { + msg->msg_flags |= FL_USE_OTCPID; + } else { + msg->msg_flags &= ~(FL_USE_OTCPID); + } + return 1; +} + +/** + * + */ +static int w_tcp_set_otcpid_flag(sip_msg_t* msg, char* mode, char *p2) +{ + int vmode = 0; + + if(fixup_get_ivalue(msg, (gparam_t*)mode, &vmode)<0) { + LM_ERR("failed to get mode parameter\n"); + return -1; + } + return ki_tcp_set_otcpid_flag(msg, vmode); +} + /** * */ @@ -736,6 +798,16 @@ static sr_kemi_t sr_kemi_tcpops_exports[] = { { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("tcpops"), str_init("tcp_set_otcpid"), + SR_KEMIP_INT, ki_tcp_set_otcpid, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("tcpops"), str_init("tcp_set_otcpid_flag"), + SR_KEMIP_INT, ki_tcp_set_otcpid_flag, + { SR_KEMIP_INT, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

1 0

git:master:2846ef42: tm: use outbound tcp connection id for relaying if FL_USE_OTCPID is set
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: 2846ef4271c4e539b3ffdfe8667a2894d7627af7 URL: https://github.com/kamailio/kamailio/commit/2846ef4271c4e539b3ffdfe8667a289… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T10:04:05+02:00 tm: use outbound tcp connection id for relaying if FL_USE_OTCPID is set --- Modified: src/modules/tm/t_funcs.c Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/2846ef4271c4e539b3ffdfe8667a289… Patch: https://github.com/kamailio/kamailio/commit/2846ef4271c4e539b3ffdfe8667a289… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index ee06bedf43..97c0d2568b 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -285,6 +285,9 @@ int t_relay_to( struct sip_msg *p_msg , struct proxy_l *proxy, int proto, if ( p_msg->REQ_METHOD==METHOD_ACK) { LM_DBG("forwarding ACK statelessly\n"); init_dest_info(&dst); + if(p_msg->msg_flags & FL_USE_OTCPID) { + dst.id = p_msg->otcpid; + } if (proxy==0) { dst.proto=proto; if (get_uri_send_info(GET_NEXT_HOP(p_msg), &host, &port, diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 83f22ebf0d..0a302c438b 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1673,6 +1673,9 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, if (t->flags & T_CANCELED) goto canceled; if (branch_ret>=0) { added_branches |= 1<<branch_ret; + if(p_msg->msg_flags & FL_USE_OTCPID) { + t->uac[branch_ret].request.dst.id = p_msg->otcpid; + } } else { lowest_ret=MIN_int(lowest_ret, branch_ret); } @@ -1699,6 +1702,9 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, * branch result */ if (branch_ret>=0) { added_branches |= 1<<branch_ret; + if(p_msg->msg_flags & FL_USE_OTCPID) { + t->uac[branch_ret].request.dst.id = p_msg->otcpid; + } } else { lowest_ret=MIN_int(lowest_ret, branch_ret); }

1 0

git:master:2ec8e05f: core: use outbound tcp connection id for forward(...) if FL_USE_OTCPID is set
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: 2ec8e05f1297d9ed69c8cd847c9d4f5d3529d3cd URL: https://github.com/kamailio/kamailio/commit/2ec8e05f1297d9ed69c8cd847c9d4f5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T09:57:11+02:00 core: use outbound tcp connection id for forward(...) if FL_USE_OTCPID is set --- Modified: src/core/action.c --- Diff: https://github.com/kamailio/kamailio/commit/2ec8e05f1297d9ed69c8cd847c9d4f5… Patch: https://github.com/kamailio/kamailio/commit/2ec8e05f1297d9ed69c8cd847c9d4f5… --- diff --git a/src/core/action.c b/src/core/action.c index cfb1bf934b..d72cc97a77 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -385,11 +385,17 @@ int do_action(struct run_act_ctx* h, struct action* a, struct sip_msg* msg) #ifdef USE_TCP else if (a->type==FORWARD_TCP_T) { dst.proto= PROTO_TCP; + if(msg->msg_flags & FL_USE_OTCPID) { + dst.id = msg->otcpid; + } } #endif #ifdef USE_TLS else if (a->type==FORWARD_TLS_T) { dst.proto= PROTO_TLS; + if(msg->msg_flags & FL_USE_OTCPID) { + dst.id = msg->otcpid; + } } #endif #ifdef USE_SCTP

1 0

git:master:b9381ab2: core: parser - new internal flag FL_USE_OTCPID
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: b9381ab2f4f3f4a791b284902757303a1cc21b90 URL: https://github.com/kamailio/kamailio/commit/b9381ab2f4f3f4a791b284902757303… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T09:54:47+02:00 core: parser - new internal flag FL_USE_OTCPID - mark request for routing existing outbound tcp connection id (e.g., restored from usrloc location lookup) --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/b9381ab2f4f3f4a791b284902757303… Patch: https://github.com/kamailio/kamailio/commit/b9381ab2f4f3f4a791b284902757303… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 02bba6b1b9..973b5702b4 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -110,6 +110,7 @@ typedef enum request_method { #define FL_MSG_NOREPLY (1<<23) /*!< do not send sip reply for request */ #define FL_SIPTRACE (1<<24) /*!< message to be traced in stateless replies */ #define FL_ROUTE_ADDR (1<<25) /*!< request has Route address for next hop */ +#define FL_USE_OTCPID (1<<26) /*!< request to be routed using outboud tcp con id */ /* WARNING: Value (1 << 28) is reserved for use in kamailio call_control * module (flag FL_USE_CALL_CONTROL )! */

1 0

git:master:8801ee89: core: parser - removed temporarily remark for module reserved internal flags
by Daniel-Constantin Mierla 31 Mar '20

31 Mar '20

Module: kamailio Branch: master Commit: 8801ee89856d4a37709869a5c01dfa66988b8f5a URL: https://github.com/kamailio/kamailio/commit/8801ee89856d4a37709869a5c01dfa6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-31T09:11:40+02:00 core: parser - removed temporarily remark for module reserved internal flags --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/8801ee89856d4a37709869a5c01dfa6… Patch: https://github.com/kamailio/kamailio/commit/8801ee89856d4a37709869a5c01dfa6… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index ceedf2cda9..02bba6b1b9 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -111,16 +111,16 @@ typedef enum request_method { #define FL_SIPTRACE (1<<24) /*!< message to be traced in stateless replies */ #define FL_ROUTE_ADDR (1<<25) /*!< request has Route address for next hop */ -/* WARNING: Value (1 << 28) is temporarily reserved for use in kamailio call_control +/* WARNING: Value (1 << 28) is reserved for use in kamailio call_control * module (flag FL_USE_CALL_CONTROL )! */ -/* WARNING: Value (1 << 29) is temporarily reserved for use in kamailio acc +/* WARNING: Value (1 << 29) is reserved for use in kamailio acc * module (flag FL_REQ_UPSTREAM)! */ -/* WARNING: Value (1 << 30) is temporarily reserved for use in kamailio +/* WARNING: Value (1 << 30) is reserved for use in kamailio * media proxy module (flag FL_USE_MEDIA_PROXY)! */ -/* WARNING: Value (1 << 31) is temporarily reserved for use in kamailio +/* WARNING: Value (1 << 31) is reserved for use in kamailio * nat_traversal module (flag FL_DO_KEEPALIVE)! */ #define FL_MTU_FB_MASK (FL_MTU_TCP_FB|FL_MTU_TLS_FB|FL_MTU_SCTP_FB)

1 0

[kamailio/kamailio] bugfix IMS_Rx dialog callback (#2263)
by annema-Kontron 31 Mar '20

31 Mar '20

ims_dialog bugfix for registering dialog callbacks ims_qos bugfix for Rx register dialog callback  #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches --> 5.3 - [x] Tested changes locally --> Tested locally based on 5.1.6 - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  ims_dialog bugfix for registering dialog callbacks In Rx scenarios of parallel forking (several INVITEs with same CALLID and FROMTAG sent to PCSCF) and INVITE for orig and term handled in same PCSCF (means also INVITEs with identical CALLID and FROMTAG) the wrong dialog is selected for registering the callback (i.e. the callback for sending STR) when 200OK from terminator is processed. Root cause is that dialog is searched with callid-fromtag-totag but at the time of dialog insertion (processing of INVITE) no totag is available. fix is to get ctx dialog at 200OK processing before suspending the transaction - save dialog until AAA is received - use this dialog for registering the STR callback. ims_qos bugfix for Rx register dialog callback In some scenarios like parallel forking several INVITE with identical CALLID and FROMTAG sent to PCSCF which inserts dialogues for each INVITE. When 200OK is received in PCSCF the dialog callback must be registered for the respective dialog. Currently sometimes the wrong dialog is selected by searching with CALLID FROMTAG and TOTAG thus leading to problem no STR is sent at BYE. Fix is to pickup the right dialog before suspending the transaction during AAR/AAA processing and reuse this saved dialog after AAA reception for registering the dialog callback. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2263 -- Commit Summary -- * ims_dialog bugfix for registering dialog callbacks * ims_qos bugfix for Rx register dialog callback -- File Changes -- M src/modules/ims_dialog/dlg_cb.c (9) M src/modules/ims_dialog/dlg_cb.h (5) M src/modules/ims_dialog/dlg_handlers.c (1) M src/modules/ims_qos/ims_qos_mod.c (7) M src/modules/ims_qos/rx_aar.c (3) M src/modules/ims_qos/rx_aar.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2263.patch https://github.com/kamailio/kamailio/pull/2263.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2263

4 10

git:5.2:a1137979: ims_qos: bugfix for Rx register dialog callback
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.2 Commit: a11379790d1477c789fb72360bf2d5a23197fdd5 URL: https://github.com/kamailio/kamailio/commit/a11379790d1477c789fb72360bf2d5a… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:09:31+02:00 ims_qos: bugfix for Rx register dialog callback - bugfix for Rx register dialog callback - In some scenarios like parallel forking several INVITE with identical CALLID and FROMTAG sent to PCSCF which inserts dialogues for each INVITE. - When 200OK is received in PCSCF the dialog callback must be registered for the respective dialog. Currently sometimes the wrong dialog is selected by searching with CALLID FROMTAG and TOTAG thus leading to problem no STR is sent at BYE. - Fix is to pickup the right dialog before suspending the transaction during AAR/AAA processing and reuse this saved dialog. (cherry picked from commit 2768f8ce1cf6da242674e7e40c8e76eb6c630f6b) --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h --- Diff: https://github.com/kamailio/kamailio/commit/a11379790d1477c789fb72360bf2d5a… Patch: https://github.com/kamailio/kamailio/commit/a11379790d1477c789fb72360bf2d5a… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index 6f68b39be1..11a2e30df5 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -1085,6 +1085,13 @@ static int w_rx_aar(struct sip_msg *msg, char *route, char* dir, char *c_id, int saved_t_data->aar_update = 1; //this is an update aar - we set this so on async_aar we know this is an update and act accordingly } + dlg = dlgb.get_dlg(msg); + if (!dlg) { + LM_ERR("Unable to find dialog and cannot do Rx without it\n"); + goto error; + } + saved_t_data->dlg = dlg; + LM_DBG("Suspending SIP TM transaction\n"); if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 684f3a75c5..3fa9633fb5 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -176,8 +176,7 @@ void async_aar_callback(int is_timeout, void *param, AAAMessage *aaa, long elaps passed_rx_session_id->len = 0; STR_SHM_DUP(*passed_rx_session_id, aaa->sessionId->data, "cb_passed_rx_session_id"); LM_DBG("passed rx session id [%.*s]", passed_rx_session_id->len, passed_rx_session_id->s); - - dlgb.register_dlgcb_nodlg(&data->callid, &data->ftag, &data->ttag, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); + dlgb.register_dlgcb_nodlg( data->dlg, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); } result = CSCF_RETURN_TRUE; } else { diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index f12def162f..596e0726c6 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -72,6 +72,7 @@ typedef struct saved_transaction { str ftag; str ttag; unsigned int aar_update; + struct dlg_cell* dlg; } saved_transaction_t; typedef struct saved_transaction_local {

1 0

git:5.2:91436c9f: ims_dialog: bugfix for registering dialog callbacks
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.2 Commit: 91436c9fc402f2038467a18ffa0aa00d1ade12a6 URL: https://github.com/kamailio/kamailio/commit/91436c9fc402f2038467a18ffa0aa00… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:09:26+02:00 ims_dialog: bugfix for registering dialog callbacks - bugfix for registering dialog callbacks - in Rx scenarios of parallel forking (several INVITEs with same CALLID and FROMTAG sent to PCSCF) and INVITE for orig and term handled in same PCSCF (means also INVITEs with identical CALLID and FROMTAG) the wrong dialog is selected for registering the callback (i.e. the callback for sending STR) when 200OK from terminator is processed. - Root cause is that dialog is searched with callid-fromtag-totag but at the time of dialog insertion (processing of INVITE) no totag is available. - fix is to get ctx dialog at 200OK processing before suspending the transaction - save dialog until AAA is received - use this dialog for registering the STR callback. (cherry picked from commit e2a1b967fd6e2cc92dc1447e1c033f6124aca446) --- Modified: src/modules/ims_dialog/dlg_cb.c Modified: src/modules/ims_dialog/dlg_cb.h Modified: src/modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/91436c9fc402f2038467a18ffa0aa00… Patch: https://github.com/kamailio/kamailio/commit/91436c9fc402f2038467a18ffa0aa00… --- diff --git a/src/modules/ims_dialog/dlg_cb.c b/src/modules/ims_dialog/dlg_cb.c index 1b7caa21ce..d4d0ee356c 100644 --- a/src/modules/ims_dialog/dlg_cb.c +++ b/src/modules/ims_dialog/dlg_cb.c @@ -100,15 +100,10 @@ void destroy_dlg_callbacks(unsigned int types) } } -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, - int types, dialog_cb f, + +int register_dlgcb_nodlg(struct dlg_cell *dlg, int types, dialog_cb f, void *param, param_free_cb ff ) { - struct dlg_cell *dlg; - - unsigned int dir = DLG_DIR_NONE; - dlg = get_dlg(callid, ftag, ttag, &dir); //increments ref count! - if (!dlg) { LM_ERR("Can't find dialog to register callback\n"); return -1; diff --git a/src/modules/ims_dialog/dlg_cb.h b/src/modules/ims_dialog/dlg_cb.h index f0f9815c9c..13d76d5a74 100644 --- a/src/modules/ims_dialog/dlg_cb.h +++ b/src/modules/ims_dialog/dlg_cb.h @@ -51,8 +51,7 @@ typedef void (param_free_cb) (void *param); typedef int (*ims_register_dlgcb_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); -typedef int (*ims_register_dlgcb_nodlg_f)(str *callid, str *ftag, str *ttag, - int cb_types, dialog_cb f, void *param, param_free_cb ff); +typedef int (*ims_register_dlgcb_nodlg_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); /* method to set a variable within a dialog */ //typedef int (*set_dlg_variable_f)( struct dlg_cell* dlg, @@ -103,7 +102,7 @@ void destroy_dlg_callbacks(unsigned int type); void destroy_dlg_callbacks_list(struct dlg_callback *cb); -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, int types, dialog_cb f, void *param, param_free_cb ff ); +int register_dlgcb_nodlg(struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); int register_dlgcb( struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); void run_create_callbacks(struct dlg_cell *dlg, struct sip_msg *msg); diff --git a/src/modules/ims_dialog/dlg_handlers.c b/src/modules/ims_dialog/dlg_handlers.c index b0f5b491bb..3d8dee7ff3 100644 --- a/src/modules/ims_dialog/dlg_handlers.c +++ b/src/modules/ims_dialog/dlg_handlers.c @@ -1965,4 +1965,3 @@ struct dlg_cell *dlg_get_msg_dialog(sip_msg_t *msg) { return dlg; } -

1 0

git:5.3:46ad9e6d: ims_qos: bugfix for Rx register dialog callback
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.3 Commit: 46ad9e6dacb7b6040e50ba0c53d72585510dac28 URL: https://github.com/kamailio/kamailio/commit/46ad9e6dacb7b6040e50ba0c53d7258… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:08:31+02:00 ims_qos: bugfix for Rx register dialog callback - bugfix for Rx register dialog callback - In some scenarios like parallel forking several INVITE with identical CALLID and FROMTAG sent to PCSCF which inserts dialogues for each INVITE. - When 200OK is received in PCSCF the dialog callback must be registered for the respective dialog. Currently sometimes the wrong dialog is selected by searching with CALLID FROMTAG and TOTAG thus leading to problem no STR is sent at BYE. - Fix is to pickup the right dialog before suspending the transaction during AAR/AAA processing and reuse this saved dialog. (cherry picked from commit 2768f8ce1cf6da242674e7e40c8e76eb6c630f6b) --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h --- Diff: https://github.com/kamailio/kamailio/commit/46ad9e6dacb7b6040e50ba0c53d7258… Patch: https://github.com/kamailio/kamailio/commit/46ad9e6dacb7b6040e50ba0c53d7258… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index 7e0d50b2df..24a7a14531 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -1089,6 +1089,13 @@ static int w_rx_aar(struct sip_msg *msg, char *route, char* dir, char *c_id, int saved_t_data->aar_update = 1; //this is an update aar - we set this so on async_aar we know this is an update and act accordingly } + dlg = dlgb.get_dlg(msg); + if (!dlg) { + LM_ERR("Unable to find dialog and cannot do Rx without it\n"); + goto error; + } + saved_t_data->dlg = dlg; + LM_DBG("Suspending SIP TM transaction\n"); if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 2029035415..b1e8df51b8 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -176,8 +176,7 @@ void async_aar_callback(int is_timeout, void *param, AAAMessage *aaa, long elaps passed_rx_session_id->len = 0; STR_SHM_DUP(*passed_rx_session_id, aaa->sessionId->data, "cb_passed_rx_session_id"); LM_DBG("passed rx session id [%.*s]", passed_rx_session_id->len, passed_rx_session_id->s); - - dlgb.register_dlgcb_nodlg(&data->callid, &data->ftag, &data->ttag, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); + dlgb.register_dlgcb_nodlg( data->dlg, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); } result = CSCF_RETURN_TRUE; } else { diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index 10fa2cc059..550202fa40 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -72,6 +72,7 @@ typedef struct saved_transaction { str ftag; str ttag; unsigned int aar_update; + struct dlg_cell* dlg; } saved_transaction_t; typedef struct saved_transaction_local {

1 0

git:5.3:8cee1675: ims_dialog: bugfix for registering dialog callbacks
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.3 Commit: 8cee1675e95363462d20cdc2b8aaac1a6976eb9c URL: https://github.com/kamailio/kamailio/commit/8cee1675e95363462d20cdc2b8aaac1… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:08:17+02:00 ims_dialog: bugfix for registering dialog callbacks - bugfix for registering dialog callbacks - in Rx scenarios of parallel forking (several INVITEs with same CALLID and FROMTAG sent to PCSCF) and INVITE for orig and term handled in same PCSCF (means also INVITEs with identical CALLID and FROMTAG) the wrong dialog is selected for registering the callback (i.e. the callback for sending STR) when 200OK from terminator is processed. - Root cause is that dialog is searched with callid-fromtag-totag but at the time of dialog insertion (processing of INVITE) no totag is available. - fix is to get ctx dialog at 200OK processing before suspending the transaction - save dialog until AAA is received - use this dialog for registering the STR callback. (cherry picked from commit e2a1b967fd6e2cc92dc1447e1c033f6124aca446) --- Modified: src/modules/ims_dialog/dlg_cb.c Modified: src/modules/ims_dialog/dlg_cb.h Modified: src/modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/8cee1675e95363462d20cdc2b8aaac1… Patch: https://github.com/kamailio/kamailio/commit/8cee1675e95363462d20cdc2b8aaac1… --- diff --git a/src/modules/ims_dialog/dlg_cb.c b/src/modules/ims_dialog/dlg_cb.c index 1b7caa21ce..d4d0ee356c 100644 --- a/src/modules/ims_dialog/dlg_cb.c +++ b/src/modules/ims_dialog/dlg_cb.c @@ -100,15 +100,10 @@ void destroy_dlg_callbacks(unsigned int types) } } -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, - int types, dialog_cb f, + +int register_dlgcb_nodlg(struct dlg_cell *dlg, int types, dialog_cb f, void *param, param_free_cb ff ) { - struct dlg_cell *dlg; - - unsigned int dir = DLG_DIR_NONE; - dlg = get_dlg(callid, ftag, ttag, &dir); //increments ref count! - if (!dlg) { LM_ERR("Can't find dialog to register callback\n"); return -1; diff --git a/src/modules/ims_dialog/dlg_cb.h b/src/modules/ims_dialog/dlg_cb.h index f0f9815c9c..13d76d5a74 100644 --- a/src/modules/ims_dialog/dlg_cb.h +++ b/src/modules/ims_dialog/dlg_cb.h @@ -51,8 +51,7 @@ typedef void (param_free_cb) (void *param); typedef int (*ims_register_dlgcb_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); -typedef int (*ims_register_dlgcb_nodlg_f)(str *callid, str *ftag, str *ttag, - int cb_types, dialog_cb f, void *param, param_free_cb ff); +typedef int (*ims_register_dlgcb_nodlg_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); /* method to set a variable within a dialog */ //typedef int (*set_dlg_variable_f)( struct dlg_cell* dlg, @@ -103,7 +102,7 @@ void destroy_dlg_callbacks(unsigned int type); void destroy_dlg_callbacks_list(struct dlg_callback *cb); -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, int types, dialog_cb f, void *param, param_free_cb ff ); +int register_dlgcb_nodlg(struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); int register_dlgcb( struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); void run_create_callbacks(struct dlg_cell *dlg, struct sip_msg *msg); diff --git a/src/modules/ims_dialog/dlg_handlers.c b/src/modules/ims_dialog/dlg_handlers.c index b0f5b491bb..3d8dee7ff3 100644 --- a/src/modules/ims_dialog/dlg_handlers.c +++ b/src/modules/ims_dialog/dlg_handlers.c @@ -1965,4 +1965,3 @@ struct dlg_cell *dlg_get_msg_dialog(sip_msg_t *msg) { return dlg; } -

1 0

git:master:2768f8ce: ims_qos: bugfix for Rx register dialog callback
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: master Commit: 2768f8ce1cf6da242674e7e40c8e76eb6c630f6b URL: https://github.com/kamailio/kamailio/commit/2768f8ce1cf6da242674e7e40c8e76e… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:02:29+02:00 ims_qos: bugfix for Rx register dialog callback - bugfix for Rx register dialog callback - In some scenarios like parallel forking several INVITE with identical CALLID and FROMTAG sent to PCSCF which inserts dialogues for each INVITE. - When 200OK is received in PCSCF the dialog callback must be registered for the respective dialog. Currently sometimes the wrong dialog is selected by searching with CALLID FROMTAG and TOTAG thus leading to problem no STR is sent at BYE. - Fix is to pickup the right dialog before suspending the transaction during AAR/AAA processing and reuse this saved dialog. --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h --- Diff: https://github.com/kamailio/kamailio/commit/2768f8ce1cf6da242674e7e40c8e76e… Patch: https://github.com/kamailio/kamailio/commit/2768f8ce1cf6da242674e7e40c8e76e… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index c2e2ae06a1..e58dd2c140 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -1095,6 +1095,13 @@ static int w_rx_aar(struct sip_msg *msg, char *route, char* dir, char *c_id, int saved_t_data->aar_update = 1; //this is an update aar - we set this so on async_aar we know this is an update and act accordingly } + dlg = dlgb.get_dlg(msg); + if (!dlg) { + LM_ERR("Unable to find dialog and cannot do Rx without it\n"); + goto error; + } + saved_t_data->dlg = dlg; + LM_DBG("Suspending SIP TM transaction\n"); if (tmb.t_suspend(msg, &saved_t_data->tindex, &saved_t_data->tlabel) != 0) { LM_ERR("failed to suspend the TM processing\n"); diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 2029035415..b1e8df51b8 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -176,8 +176,7 @@ void async_aar_callback(int is_timeout, void *param, AAAMessage *aaa, long elaps passed_rx_session_id->len = 0; STR_SHM_DUP(*passed_rx_session_id, aaa->sessionId->data, "cb_passed_rx_session_id"); LM_DBG("passed rx session id [%.*s]", passed_rx_session_id->len, passed_rx_session_id->s); - - dlgb.register_dlgcb_nodlg(&data->callid, &data->ftag, &data->ttag, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); + dlgb.register_dlgcb_nodlg( data->dlg, DLGCB_TERMINATED | DLGCB_DESTROY | DLGCB_EXPIRED | DLGCB_RESPONSE_WITHIN | DLGCB_CONFIRMED | DLGCB_FAILED, callback_dialog, (void*) (passed_rx_session_id), free_dialog_data); } result = CSCF_RETURN_TRUE; } else { diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index 10fa2cc059..550202fa40 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -72,6 +72,7 @@ typedef struct saved_transaction { str ftag; str ttag; unsigned int aar_update; + struct dlg_cell* dlg; } saved_transaction_t; typedef struct saved_transaction_local {

1 0

git:master:e2a1b967: ims_dialog: bugfix for registering dialog callbacks
by Henning Westerholt 30 Mar '20

30 Mar '20

Module: kamailio Branch: master Commit: e2a1b967fd6e2cc92dc1447e1c033f6124aca446 URL: https://github.com/kamailio/kamailio/commit/e2a1b967fd6e2cc92dc1447e1c033f6… Author: Peter Friedrich <peter.friedrich(a)kapsch.net> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-30T19:00:58+02:00 ims_dialog: bugfix for registering dialog callbacks - bugfix for registering dialog callbacks - in Rx scenarios of parallel forking (several INVITEs with same CALLID and FROMTAG sent to PCSCF) and INVITE for orig and term handled in same PCSCF (means also INVITEs with identical CALLID and FROMTAG) the wrong dialog is selected for registering the callback (i.e. the callback for sending STR) when 200OK from terminator is processed. - Root cause is that dialog is searched with callid-fromtag-totag but at the time of dialog insertion (processing of INVITE) no totag is available. - fix is to get ctx dialog at 200OK processing before suspending the transaction - save dialog until AAA is received - use this dialog for registering the STR callback. --- Modified: src/modules/ims_dialog/dlg_cb.c Modified: src/modules/ims_dialog/dlg_cb.h Modified: src/modules/ims_dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/e2a1b967fd6e2cc92dc1447e1c033f6… Patch: https://github.com/kamailio/kamailio/commit/e2a1b967fd6e2cc92dc1447e1c033f6… --- diff --git a/src/modules/ims_dialog/dlg_cb.c b/src/modules/ims_dialog/dlg_cb.c index 1b7caa21ce..d4d0ee356c 100644 --- a/src/modules/ims_dialog/dlg_cb.c +++ b/src/modules/ims_dialog/dlg_cb.c @@ -100,15 +100,10 @@ void destroy_dlg_callbacks(unsigned int types) } } -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, - int types, dialog_cb f, + +int register_dlgcb_nodlg(struct dlg_cell *dlg, int types, dialog_cb f, void *param, param_free_cb ff ) { - struct dlg_cell *dlg; - - unsigned int dir = DLG_DIR_NONE; - dlg = get_dlg(callid, ftag, ttag, &dir); //increments ref count! - if (!dlg) { LM_ERR("Can't find dialog to register callback\n"); return -1; diff --git a/src/modules/ims_dialog/dlg_cb.h b/src/modules/ims_dialog/dlg_cb.h index f0f9815c9c..13d76d5a74 100644 --- a/src/modules/ims_dialog/dlg_cb.h +++ b/src/modules/ims_dialog/dlg_cb.h @@ -51,8 +51,7 @@ typedef void (param_free_cb) (void *param); typedef int (*ims_register_dlgcb_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); -typedef int (*ims_register_dlgcb_nodlg_f)(str *callid, str *ftag, str *ttag, - int cb_types, dialog_cb f, void *param, param_free_cb ff); +typedef int (*ims_register_dlgcb_nodlg_f)(struct dlg_cell* dlg, int cb_types, dialog_cb f, void *param, param_free_cb ff); /* method to set a variable within a dialog */ //typedef int (*set_dlg_variable_f)( struct dlg_cell* dlg, @@ -103,7 +102,7 @@ void destroy_dlg_callbacks(unsigned int type); void destroy_dlg_callbacks_list(struct dlg_callback *cb); -int register_dlgcb_nodlg(str *callid, str *ftag, str *ttag, int types, dialog_cb f, void *param, param_free_cb ff ); +int register_dlgcb_nodlg(struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); int register_dlgcb( struct dlg_cell* dlg, int types, dialog_cb f, void *param, param_free_cb ff); void run_create_callbacks(struct dlg_cell *dlg, struct sip_msg *msg); diff --git a/src/modules/ims_dialog/dlg_handlers.c b/src/modules/ims_dialog/dlg_handlers.c index b0f5b491bb..3d8dee7ff3 100644 --- a/src/modules/ims_dialog/dlg_handlers.c +++ b/src/modules/ims_dialog/dlg_handlers.c @@ -1965,4 +1965,3 @@ struct dlg_cell *dlg_get_msg_dialog(sip_msg_t *msg) { return dlg; } -

1 0

git:5.3:40586f8a: tm: do not set msg tcp connection id in the dst info
by Daniel-Constantin Mierla 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.3 Commit: 40586f8a61a27cc25df6c4bffff60205617eba88 URL: https://github.com/kamailio/kamailio/commit/40586f8a61a27cc25df6c4bffff6020… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-30T10:23:22+02:00 tm: do not set msg tcp connection id in the dst info (cherry picked from commit 974c50aea6b581b5f8545f3d710e98b53d44bd67) --- Modified: src/modules/tm/t_funcs.c Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/40586f8a61a27cc25df6c4bffff6020… Patch: https://github.com/kamailio/kamailio/commit/40586f8a61a27cc25df6c4bffff6020… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index 0e484d9ebf..ee06bedf43 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -285,7 +285,6 @@ int t_relay_to( struct sip_msg *p_msg , struct proxy_l *proxy, int proto, if ( p_msg->REQ_METHOD==METHOD_ACK) { LM_DBG("forwarding ACK statelessly\n"); init_dest_info(&dst); - dst.id = p_msg->otcpid; if (proxy==0) { dst.proto=proto; if (get_uri_send_info(GET_NEXT_HOP(p_msg), &host, &port, diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 81a0f20841..83f22ebf0d 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1673,7 +1673,6 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, if (t->flags & T_CANCELED) goto canceled; if (branch_ret>=0) { added_branches |= 1<<branch_ret; - t->uac[branch_ret].request.dst.id = p_msg->otcpid; } else { lowest_ret=MIN_int(lowest_ret, branch_ret); } @@ -1700,7 +1699,6 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, * branch result */ if (branch_ret>=0) { added_branches |= 1<<branch_ret; - t->uac[branch_ret].request.dst.id = obranch.otcpid; } else { lowest_ret=MIN_int(lowest_ret, branch_ret); }

1 0

git:5.3:2b8bf4fe: core: do not set msg tcp connection id in the dst info
by Daniel-Constantin Mierla 30 Mar '20

30 Mar '20

Module: kamailio Branch: 5.3 Commit: 2b8bf4fee656242eddc9bbc45bdb234d96eb518a URL: https://github.com/kamailio/kamailio/commit/2b8bf4fee656242eddc9bbc45bdb234… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-30T10:23:12+02:00 core: do not set msg tcp connection id in the dst info (cherry picked from commit f9eaa1298f7263be53b709ab7b68336d09e9de0b) --- Modified: src/core/action.c --- Diff: https://github.com/kamailio/kamailio/commit/2b8bf4fee656242eddc9bbc45bdb234… Patch: https://github.com/kamailio/kamailio/commit/2b8bf4fee656242eddc9bbc45bdb234… --- diff --git a/src/core/action.c b/src/core/action.c index 8211cf00f7..1520f87877 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -385,13 +385,11 @@ int do_action(struct run_act_ctx* h, struct action* a, struct sip_msg* msg) #ifdef USE_TCP else if (a->type==FORWARD_TCP_T) { dst.proto= PROTO_TCP; - dst.id = msg->otcpid; } #endif #ifdef USE_TLS else if (a->type==FORWARD_TLS_T) { dst.proto= PROTO_TLS; - dst.id = msg->otcpid; } #endif #ifdef USE_SCTP

1 0

git:master:974c50ae: tm: do not set msg tcp connection id in the dst info
by Daniel-Constantin Mierla 30 Mar '20

30 Mar '20

Module: kamailio Branch: master Commit: 974c50aea6b581b5f8545f3d710e98b53d44bd67 URL: https://github.com/kamailio/kamailio/commit/974c50aea6b581b5f8545f3d710e98b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-30T10:19:29+02:00 tm: do not set msg tcp connection id in the dst info --- Modified: src/modules/tm/t_funcs.c Modified: src/modules/tm/t_fwd.c --- Diff: https://github.com/kamailio/kamailio/commit/974c50aea6b581b5f8545f3d710e98b… Patch: https://github.com/kamailio/kamailio/commit/974c50aea6b581b5f8545f3d710e98b… --- diff --git a/src/modules/tm/t_funcs.c b/src/modules/tm/t_funcs.c index 0e484d9ebf..ee06bedf43 100644 --- a/src/modules/tm/t_funcs.c +++ b/src/modules/tm/t_funcs.c @@ -285,7 +285,6 @@ int t_relay_to( struct sip_msg *p_msg , struct proxy_l *proxy, int proto, if ( p_msg->REQ_METHOD==METHOD_ACK) { LM_DBG("forwarding ACK statelessly\n"); init_dest_info(&dst); - dst.id = p_msg->otcpid; if (proxy==0) { dst.proto=proto; if (get_uri_send_info(GET_NEXT_HOP(p_msg), &host, &port, diff --git a/src/modules/tm/t_fwd.c b/src/modules/tm/t_fwd.c index 81a0f20841..83f22ebf0d 100644 --- a/src/modules/tm/t_fwd.c +++ b/src/modules/tm/t_fwd.c @@ -1673,7 +1673,6 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, if (t->flags & T_CANCELED) goto canceled; if (branch_ret>=0) { added_branches |= 1<<branch_ret; - t->uac[branch_ret].request.dst.id = p_msg->otcpid; } else { lowest_ret=MIN_int(lowest_ret, branch_ret); } @@ -1700,7 +1699,6 @@ int t_forward_nonack( struct cell *t, struct sip_msg* p_msg, * branch result */ if (branch_ret>=0) { added_branches |= 1<<branch_ret; - t->uac[branch_ret].request.dst.id = obranch.otcpid; } else { lowest_ret=MIN_int(lowest_ret, branch_ret); }

1 0

git:master:f9eaa129: core: do not set msg tcp connection id in the dst info
by Daniel-Constantin Mierla 30 Mar '20

30 Mar '20

Module: kamailio Branch: master Commit: f9eaa1298f7263be53b709ab7b68336d09e9de0b URL: https://github.com/kamailio/kamailio/commit/f9eaa1298f7263be53b709ab7b68336… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-30T10:19:29+02:00 core: do not set msg tcp connection id in the dst info --- Modified: src/core/action.c --- Diff: https://github.com/kamailio/kamailio/commit/f9eaa1298f7263be53b709ab7b68336… Patch: https://github.com/kamailio/kamailio/commit/f9eaa1298f7263be53b709ab7b68336… --- diff --git a/src/core/action.c b/src/core/action.c index 633a38da16..cfb1bf934b 100644 --- a/src/core/action.c +++ b/src/core/action.c @@ -385,13 +385,11 @@ int do_action(struct run_act_ctx* h, struct action* a, struct sip_msg* msg) #ifdef USE_TCP else if (a->type==FORWARD_TCP_T) { dst.proto= PROTO_TCP; - dst.id = msg->otcpid; } #endif #ifdef USE_TLS else if (a->type==FORWARD_TLS_T) { dst.proto= PROTO_TLS; - dst.id = msg->otcpid; } #endif #ifdef USE_SCTP

1 0

Transaction Matching Failed ACK & BYE
by egemen ulus 30 Mar '20

30 Mar '20

Hi All, I'm trying to establish a topology with Kamailio which is located between Asterisk and Outside. My issue is "transaction matching failed" (t_check_trans failed). That means Kamailio does not recognise ACK & BYE message to forwards. I had a check on email list and google but found nothing. I'm using it with record_route. SIP signalling and part of kamailio.cfg is below. Is there any suggestion? route[WITHINDLG] { if (!has_totag()) return; if (loose_route()) { route(DLGURI); if (is_method("BYE")) { setflag(FLT_ACC); # do accounting ... setflag(FLT_ACCFAILED); # ... even if the transaction fails } else if ( is_method("ACK") ) { xlog("ack is came: $si:$sp\n"); route(NATMANAGE); } else if ( is_method("NOTIFY") ) { record_route(); } route(RELAY); exit; } if (is_method("SUBSCRIBE") && uri == myself) { route(PRESENCE); exit; } if ( is_method("ACK") ) { if ( t_check_trans() ) { route(RELAY); exit; } else { exit; } } sl_send_reply("404","Not here"); exit; } route[NATMANAGE] { #!ifdef WITH_NAT if (is_request()) { if(has_totag()) { if(check_route_param("nat=yes")) { setbflag(FLB_NATB); } } } route(RTPPROXY); if (!(isflagset(FLT_NATS) || isbflagset(FLB_NATB))) return; if (is_request()) { if (!has_totag()) { if(t_is_branch_route()) { add_rr_param(";nat=yes"); } } } if (is_reply()) { if(isbflagset(FLB_NATB)) { if(is_first_hop()) set_contact_alias(); } } #!endif return; } Asterisk > Kamailio INVITE sip:user@outside_ip SIP/2.0 Via: SIP/2.0/UDP asterisk_ip:5060;branch=z9hG4bK1b56cce0 Max-Forwards: 70 From: "KUYRUK" <sip:0553847<tel:+10553847>aaaa@asterisk_ip>;tag=as3dde7cdb To: <sip:user@outside_ip> Contact: <sip:0553847<tel:+10553847>aaaa@asterisk_ip:5060> Call-ID: 62a480bf71d2a1aa0ec94b454cd98945@asterisk_ip:5060 CSeq: 102 INVITE User-Agent: Asterisk PBX 1.8.32.3 Kamailio > Outside INVITE sip:user@outside_ip SIP/2.0 Record-Route: <sip:kamailio_ip;lr;nat=yes> Via: SIP/2.0/UDP kamailio_ip;branch=z9hG4bK7b3f.8e4716eeea4b0dc45cc51d21b5aded57.0 Via: SIP/2.0/UDP asterisk_ip:5060;rport=5060;branch=z9hG4bK1b56cce0 From: "KUYRUK" <sip:0553847<tel:+10553847>aaaa@asterisk_ip>;tag=as3dde7cdb To: <sip:user@outside_ip> Contact: <sip:0553847<tel:+10553847>aaaa@asterisk_ip:5060;alias=asterisk_ip~5060~1> Call-ID: 62a480bf71d2a1aa0ec94b454cd98945@asterisk_ip:5060 CSeq: 102 INVITE User-Agent: Asterisk PBX 1.8.32.3 Outside > Kamailio SIP/2.0 200 OK Via: SIP/2.0/UDP kamailio_ip;branch=z9hG4bK7b3f.8e4716eeea4b0dc45cc51d21b5aded57.0 Via: SIP/2.0/UDP asterisk_ip:5060;rport=5060;branch=z9hG4bK1b56cce0 From: "KUYRUK" <sip:0553847<tel:+10553847>aaaa@asterisk_ip>;tag=as3dde7cdb To: <sip:user@outside_ip>;tag=kv8iml6ur9 Call-ID: 62a480bf71d2a1aa0ec94b454cd98945@asterisk_ip:5060 CSeq: 102 INVITE Record-Route: <sip:kamailio_ip;lr;nat=yes> Contact: <sip:user@outside_ip:5060;alias=x.x.x.x~18005~6;transport=udp> Kamailio > Asterisk SIP/2.0 200 OK Via: SIP/2.0/UDP asterisk_ip:5060;rport=5060;branch=z9hG4bK1b56cce0 From: "KUYRUK" <sip:0553847<tel:+10553847>aaaa@asterisk_ip>;tag=as3dde7cdb To: <sip:user@outside_ip>;tag=kv8iml6ur9 Call-ID: 62a480bf71d2a1aa0ec94b454cd98945@asterisk_ip:5060 CSeq: 102 INVITE Record-Route: <sip:kamailio_ip;lr;nat=yes> Contact: <sip:user@outside_ip:5060;alias=x.x.x.x~18005~6;transport=udp> Asterisk > Kamailio THIS ACK IS NOT ROUTED TO OUTSIDE BY KAMAILIO!! ACK sip:user@outside_ip:5060;alias=x.x.x.x~18005~6;transport=udp SIP/2.0 Via: SIP/2.0/UDP asterisk_ip:5060;branch=z9hG4bK73366924 Route: <sip:kamailio_ip;lr;nat=yes> From: "KUYRUK" <sip:0553847<tel:+10553847>aaaa@asterisk_ip>;tag=as3dde7cdb To: <sip:user@outside_ip>;tag=kv8iml6ur9 Contact: <sip:0553847<tel:+10553847>aaaa@asterisk_ip:5060> Call-ID: 62a480bf71d2a1aa0ec94b454cd98945@asterisk_ip:5060 CSeq: 102 ACK User-Agent: Asterisk PBX 1.8.32.3 Get Outlook for Android<https://aka.ms/ghei36>

2 1

git:master:b505a4df: modules: readme files regenerated - usrloc ... [skip ci]
by Kamailio Dev 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: b505a4df46c241f8676f663ddcdddba935c0b3e4 URL: https://github.com/kamailio/kamailio/commit/b505a4df46c241f8676f663ddcdddba… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-29T17:31:14+02:00 modules: readme files regenerated - usrloc ... [skip ci] --- Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/b505a4df46c241f8676f663ddcdddba… Patch: https://github.com/kamailio/kamailio/commit/b505a4df46c241f8676f663ddcdddba… --- diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index 5ec1281c47..ac3a6b7bb6 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -1166,9 +1166,9 @@ modparam("usrloc", "ka_filter", 1) 3.55. ka_loglevel (int) The level to print the log message when the keepalive response is - received. It should be a value between LOG_ALERT + received. It should be a value between -5 (L_ALERT) and 3 (L_DBG). - Default value is “kamailio.org”. + Default value is “255” (disabled). Example 1.55. ka_loglevel parameter usage ... @@ -1185,11 +1185,11 @@ modparam("usrloc", "ka_loglevel", 1) The value of this parameter can contain script variables that are evaluated with the SIP response. - Default value is “ to-uri: [$tu] src-uri: [$su]”. + Default value is “ to-uri: [$tu] remote-addr: [$sas]”. Example 1.56. ka_logmsg parameter usage ... -modparam("usrloc", "ka_logmsg", " to-uri: [$tu] src-uri: [$su]") +modparam("usrloc", "ka_logmsg", " to-uri: [$tu] remote-addr: [$sas]") ... 4. RPC Commands

1 0

git:master:c3a8a97d: usrloc: docs - updates for ka_loglevel and ka_logmsg params
by Daniel-Constantin Mierla 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: c3a8a97d235b2399994c191a7b289bd943ce6388 URL: https://github.com/kamailio/kamailio/commit/c3a8a97d235b2399994c191a7b289bd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-29T17:30:03+02:00 usrloc: docs - updates for ka_loglevel and ka_logmsg params --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/c3a8a97d235b2399994c191a7b289bd… Patch: https://github.com/kamailio/kamailio/commit/c3a8a97d235b2399994c191a7b289bd… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index a6d9654d51..396d89828d 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1428,10 +1428,10 @@ modparam("usrloc", "ka_filter", 1) <title><varname>ka_loglevel</varname> (int)</title> <para> The level to print the log message when the keepalive response is - received. It should be a value between LOG_ALERT + received. It should be a value between -5 (L_ALERT) and 3 (L_DBG). </para> <para> - Default value is <quote>kamailio.org</quote>. + Default value is <quote>255</quote> (disabled). </para> <example> <title><varname>ka_loglevel</varname> parameter usage</title> @@ -1456,13 +1456,13 @@ modparam("usrloc", "ka_loglevel", 1) evaluated with the SIP response. </para> <para> - Default value is <quote> to-uri: [$tu] src-uri: [$su]</quote>. + Default value is <quote> to-uri: [$tu] remote-addr: [$sas]</quote>. </para> <example> <title><varname>ka_logmsg</varname> parameter usage</title> <programlisting format="linespecific"> ... -modparam("usrloc", "ka_logmsg", " to-uri: [$tu] src-uri: [$su]") +modparam("usrloc", "ka_logmsg", " to-uri: [$tu] remote-addr: [$sas]") ... </programlisting> </example>

1 0

git:master:8525a26f: usrloc: default keepalive log message prints remote address in socket format
by Daniel-Constantin Mierla 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: 8525a26fa60c70035df22495ecf309d01019d093 URL: https://github.com/kamailio/kamailio/commit/8525a26fa60c70035df22495ecf309d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-29T17:25:28+02:00 usrloc: default keepalive log message prints remote address in socket format - more compact than sip uri format --- Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8525a26fa60c70035df22495ecf309d… Patch: https://github.com/kamailio/kamailio/commit/8525a26fa60c70035df22495ecf309d… --- diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c index 8d3cfffdbf..dfc0bc5141 100644 --- a/src/modules/usrloc/usrloc_mod.c +++ b/src/modules/usrloc/usrloc_mod.c @@ -124,7 +124,7 @@ str ul_ka_method = str_init("OPTIONS"); int ul_ka_mode = 0; int ul_ka_filter = 0; int ul_ka_loglevel = 255; -str ul_ka_logmsg = str_init(" to-uri: [$tu] src-uri: [$su]"); +str ul_ka_logmsg = str_init(" to-uri: [$tu] remote-addr: [$sas]"); pv_elem_t *ul_ka_logfmt = NULL; /* sruid to get internal uid for mi/rpc commands */

1 0

[kamailio/kamailio] Kamailio breaks RFC's 'Contact Header' (#2266)
by ObakeFilter 29 Mar '20

29 Mar '20

### Description I'm running Kamailio 5.2.0, whenever I relay an invite via Kamailio, my original contact header is changed from the original: <sip:+XXXXXXXXX@YYY.YYY.YYY.YYYY:5060;transport=udp;gw=netvision> To <sip:YYY.YYY.YYY.YYY;line=sr-.n274i0TMfsHMcCAlVyAMV5IlgCXvV8n4edQlgIUlgKQ4Vk74gI1LmZ69NM79FZAR3JC.cDNLfHUj3Wnp3MP9nd*>. Even when I set it correctly on my route, using: remove_hf("Contact"); append_hf("Contact: <sip:$tU@YYY.YYY.YYY.YYY:5060;transport=udp;gw=netvision>\r\n", "Contact"); It still ends up being modified. What can I do to keep the contact header as it is?  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` U YYY.YYY.YYY.YYY:5060 -> 81.24.193.248:5060 INVITE sip:+442033202609@81.24.193.248:5060 SIP/2.0. Record-Route: <sip:YYY.YYY.YYY.YYY;r2=on;lr=on;ftag=mp0S9yH11vryH;vsf=AAAAAAAAAAAAAAAAAAAAAAADCAEACRgPGB8AAy4xNjM->. Record-Route: <sip:2YYY.YYY.YYY.YYY;line=sr-.n274V8TlidQMVyUlg87vV8nlfDXlVHB9VD0.VHB9VDoLGtNRbH7ltlTEkyQl3jXEky1LNMoRkt5ukt5ukt5ukt5ukt5ukt5ukt5ukt5W8M5WktckoLuWAsduktTMm64pCAD>. Via: SIP/2.0/UDP YYY.YYY.YYY.YYY;branch=z9hG4bK53e9.308596b23ed683368534c9d609dce0f6.0. Via: SIP/2.0/UDP YYY.YYY.YYY.YYY;branch=z9hG4bKsr-kA2uvfsUlerJWtIylgCXvV8n4edQlgIUlgKQ4Vk74gI1.oJVjb2njburlgCXvV8n4edQlgIUlgKQ4HWsRbWPLVDX.GrXLcAHlcC74nZXKbTVpcHh4b6mMGZvJgLsLcJTkgtGu2PGgy**. Max-Forwards: 67. From: +18702935016 <sip:+18702935016@YYY.YYY.YYY.YYY>;tag=mp0S9yH11vryH. To: <sip:+442033202609@81.24.193.248>. Call-ID: !!:jbkfMgyHjbsDjblfjqAQlVldvgyHKolDlcIHlcknKVIdjcIT. CSeq: 18182498 INVITE. Contact: <sip:YYY.YYY.YYY.YYY;line=sr-.n274i0TMfsHMcCAlVyAMV5IlgCXvV8n4edQlgIUlgKQ4Vk74gI1LmZ69NM79FZAR3JC.cDNLfHUj3Wnp3MP9nd*>. User-Agent: FreeSWITCH-mod_sofia/1.9.0+git~20180706T160334Z~de3df8dc0e~64bit. Allow: INVITE, ACK, BYE, CANCEL, OPTIONS, MESSAGE, INFO, UPDATE, REGISTER, REFER, NOTIFY. Supported: timer, path, replaces. Allow-Events: talk, hold, conference, refer. Content-Type: application/sdp. Content-Disposition: session. Content-Length: 224. Remote-Party-ID: "+18702935016" <sip:+18702935016@YYY.YYY.YYY.YYY>;party=calling;screen=yes;privacy=off. .. v=0. o=FreeSWITCH 1585439298 1585439299 IN IP4 ZZZ.ZZZ.ZZZ.ZZZ. s=FreeSWITCH. c=IN IP4 ZZZ.ZZZ ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.0-dev6 (x86_64/linux) c4daee flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: c4daee compiled on 15:59:42 Aug 22 2018 with gcc 5.4.0 ``` * **Operating System**:  ``` Linux version 4.4.0-98-generic (buildd@lcy01-03) (gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) ) #121-Ubuntu SMP Tue Oct 10 14:24:03 UTC 2017 Linux kamaillioegress 4.4.0-98-generic #121-Ubuntu SMP Tue Oct 10 14:24:03 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2266

2 2

master xml warnings
by Juha Heinanen 29 Mar '20

29 Mar '20

version.xml:14: namespace error : Namespace prefix db on para is not defined <db:para> ^

3 3

git:master:367a865e: lib/srdb1/schema: removed kamailio-extensions.xml file
by Daniel-Constantin Mierla 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: 367a865e7f0c9cd67fda9176add1ca3c0dad2d46 URL: https://github.com/kamailio/kamailio/commit/367a865e7f0c9cd67fda9176add1ca3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-29T14:17:19+02:00 lib/srdb1/schema: removed kamailio-extensions.xml file - file didn't have any content itself, tried to include an inexistent extra.xml, which generated an warning for 'make dbschema' --- Removed: src/lib/srdb1/schema/kamailio-extensions.xml --- Diff: https://github.com/kamailio/kamailio/commit/367a865e7f0c9cd67fda9176add1ca3… Patch: https://github.com/kamailio/kamailio/commit/367a865e7f0c9cd67fda9176add1ca3… --- diff --git a/src/lib/srdb1/schema/kamailio-extensions.xml b/src/lib/srdb1/schema/kamailio-extensions.xml deleted file mode 100644 index f4a0aec097..0000000000 --- a/src/lib/srdb1/schema/kamailio-extensions.xml +++ /dev/null @@ -1,21 +0,0 @@ -<?xml version="1.0" encoding="UTF-8"?> -<!DOCTYPE database PUBLIC "-//kamailio.org//DTD DBSchema V1.1//EN" - "http://kamailio.org/pub/kamailio/dbschema/dtd/1.1/dbschema.dtd" [ - - <!ENTITY % entities SYSTEM "entities.xml"> - %entities; -]> - - - -<database xmlns:xi="http://www.w3.org/2001/XInclude"> - <name>CUSTOM Extensions</name> -  - <xi:include href="extra.xml"> - <xi:fallback/> - </xi:include> -  -  -</database>

1 0

master compiler warnings
by Juha Heinanen 29 Mar '20

29 Mar '20

CC (gcc) [M usrloc.so] ul_keepalive.o ul_keepalive.c: In function 'ul_ka_urecord': ul_keepalive.c:61:18: warning: format '%x' expects argument of type 'unsigned int', but argument 26 has type '__suseconds_t' {aka 'long int'} [-Wformat=] #define ULKA_MSG "%.*s %.*s SIP/2.0\r\n" \ ^~~~~~~~~~~~~~~~~~~~~~~ ul_keepalive.c:193:50: note: in expansion of macro 'ULKA_MSG' kabuf_len = snprintf(kabuf, ULKA_BUF_SIZE - 1, ULKA_MSG, ^~~~~~~~ ul_keepalive.c:64:34: note: format string is defined here "From: <%.*s>;tag=%.*s-%x-%lx-%x-%x.%x\r\n" \ ~^ %lx In file included from ul_keepalive.c:30: ul_keepalive.c: In function 'ul_ka_reply_received': ../../core/dprint.h:316:24: warning: format '%u' expects argument of type 'unsigned int', but argument 11 has type '__suseconds_t' {aka 'long int'} [-Wformat=] fprintf(stderr, "%2d(%d) %s: %.*s%s%s%s" fmt, \ ^~~~~~~~~~~~~~~~~~~~~~~~ ../../core/dprint.h:340:4: note: in expansion of macro 'LOG_FX' LOG_FX(facility, level, lname, prefix, _FUNC_NAME_, fmt, ## args) ^~~~~~ ../../core/dprint.h:346:4: note: in expansion of macro 'LOG_FL' LOG_FL(facility, level, NULL, prefix, fmt, ## args) ^~~~~~ ../../core/dprint.h:349:4: note: in expansion of macro 'LOG_FP' LOG_FP(DEFAULT_FACILITY, (level), LOC_INFO, fmt, ## args) ^~~~~~ ../../core/dprint.h:396:32: note: in expansion of macro 'LOG' # define DBG(fmt, args...) LOG(L_DBG, fmt , ## args) ^~~ ../../core/dprint.h:400:30: note: in expansion of macro 'DBG' # define DEBUG(fmt, args...) DBG(fmt , ## args) ^~~ ../../core/dprint.h:417:16: note: in expansion of macro 'DEBUG' #define LM_DBG DEBUG ^~~~~ ul_keepalive.c:366:2: note: in expansion of macro 'LM_DBG' LM_DBG("tv usec is [%u]\n", tvm.tv_usec); ^~~~~~ ul_keepalive.c:366:23: note: format string is defined here LM_DBG("tv usec is [%u]\n", tvm.tv_usec); ~^ %lu

2 2

git:master:ea2d21c2: usrloc: cast to get rid of warnings for different OSes in keepalive printing
by Daniel-Constantin Mierla 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: ea2d21c2bb53ffa54d4fedcdd1d582707c654da6 URL: https://github.com/kamailio/kamailio/commit/ea2d21c2bb53ffa54d4fedcdd1d5827… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-29T12:41:32+02:00 usrloc: cast to get rid of warnings for different OSes in keepalive printing --- Modified: src/modules/usrloc/ul_keepalive.c --- Diff: https://github.com/kamailio/kamailio/commit/ea2d21c2bb53ffa54d4fedcdd1d5827… Patch: https://github.com/kamailio/kamailio/commit/ea2d21c2bb53ffa54d4fedcdd1d5827… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 0addb21a42..6038a6002a 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -61,7 +61,7 @@ Content-Length: 0\r\n\r\n" #define ULKA_MSG "%.*s %.*s SIP/2.0\r\n" \ "Via: SIP/2.0/%.*s %.*s:%.*s;branch=z9hG4bKx.%u.%u.0\r\n" \ "%.*s%.*s" \ - "From: <%.*s>;tag=%.*s-%x-%lx-%x-%x.%x\r\n" \ + "From: <%.*s>;tag=%.*s-%x-%lx-%lx-%x.%x\r\n" \ "To: <sip:%.*s%s%.*s>\r\n" \ "Call-ID: " ULKA_CALLID_PREFIX "%u.%u\r\n" \ "CSeq: 80 %.*s\r\n" \ @@ -203,7 +203,8 @@ int ul_ka_urecord(urecord_t *ur) (uc->path.len>0)?"\r\n":"", ul_ka_from.len, ul_ka_from.s, uc->ruid.len, uc->ruid.s, ur->aorhash, - tv.tv_sec, tv.tv_usec, _ul_ka_counter, bcnt, + (unsigned long)tv.tv_sec, (unsigned long)tv.tv_usec, + _ul_ka_counter, bcnt, ur->aor.len, ur->aor.s, (aortype==1)?"":"@", (aortype==1)?0:ul_ka_domain.len, (aortype==1)?"":ul_ka_domain.s, @@ -363,7 +364,7 @@ int ul_ka_reply_received(sip_msg_t *msg) LM_DBG("invalid tv usec value\n"); return 1; } - LM_DBG("tv usec is [%u]\n", tvm.tv_usec); + LM_DBG("tv usec is [%lu]\n", (unsigned long)tvm.tv_usec); /* tv_sec hash */ tok.len = p - fb->tag_value.s; @@ -385,7 +386,7 @@ int ul_ka_reply_received(sip_msg_t *msg) LM_DBG("invalid tv sec value\n"); return 1; } - LM_DBG("tv sec is [%lu]\n", tvm.tv_sec); + LM_DBG("tv sec is [%lu]\n", (unsigned long)tvm.tv_sec); /* aor hash */ tok.len = p - fb->tag_value.s;

1 0

git:5.2:ad4bd72a: doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date
by Henning Westerholt 29 Mar '20

29 Mar '20

Module: kamailio Branch: 5.2 Commit: ad4bd72a29c9b3805152970f5eb9761dfc7e7a4d URL: https://github.com/kamailio/kamailio/commit/ad4bd72a29c9b3805152970f5eb9761… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-29T11:42:04+02:00 doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date (cherry picked from commit 446dc8006240050a1e0c13c7094e9f9739cc16c8) --- Modified: doc/stylesheets/dbschema_k/bookinfo.xml --- Diff: https://github.com/kamailio/kamailio/commit/ad4bd72a29c9b3805152970f5eb9761… Patch: https://github.com/kamailio/kamailio/commit/ad4bd72a29c9b3805152970f5eb9761… --- diff --git a/doc/stylesheets/dbschema_k/bookinfo.xml b/doc/stylesheets/dbschema_k/bookinfo.xml index 5e4ce4bf71..e88d18761d 100644 --- a/doc/stylesheets/dbschema_k/bookinfo.xml +++ b/doc/stylesheets/dbschema_k/bookinfo.xml @@ -12,10 +12,6 @@ <editor> <firstname>Henning</firstname> <surname>Westerholt</surname> - <affiliation><orgname>1und1 Internet AG</orgname></affiliation> - <address> - <email>henning.westerholt(a)1und1.de</email> - </address> </editor> <editor> <firstname>Norman</firstname> @@ -23,7 +19,7 @@ </editor> </authorgroup> <copyright> - <year>2008-2017</year> + <year>2008-2020</year> <holder>&kamailio; Project</holder> </copyright> </bookinfo>

1 0

git:5.3:cf28e401: doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date
by Henning Westerholt 29 Mar '20

29 Mar '20

Module: kamailio Branch: 5.3 Commit: cf28e401122daa6cd880af58e51519c2c7a43fda URL: https://github.com/kamailio/kamailio/commit/cf28e401122daa6cd880af58e51519c… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-29T11:41:42+02:00 doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date (cherry picked from commit 446dc8006240050a1e0c13c7094e9f9739cc16c8) --- Modified: doc/stylesheets/dbschema_k/bookinfo.xml --- Diff: https://github.com/kamailio/kamailio/commit/cf28e401122daa6cd880af58e51519c… Patch: https://github.com/kamailio/kamailio/commit/cf28e401122daa6cd880af58e51519c… --- diff --git a/doc/stylesheets/dbschema_k/bookinfo.xml b/doc/stylesheets/dbschema_k/bookinfo.xml index 5e4ce4bf71..e88d18761d 100644 --- a/doc/stylesheets/dbschema_k/bookinfo.xml +++ b/doc/stylesheets/dbschema_k/bookinfo.xml @@ -12,10 +12,6 @@ <editor> <firstname>Henning</firstname> <surname>Westerholt</surname> - <affiliation><orgname>1und1 Internet AG</orgname></affiliation> - <address> - <email>henning.westerholt(a)1und1.de</email> - </address> </editor> <editor> <firstname>Norman</firstname> @@ -23,7 +19,7 @@ </editor> </authorgroup> <copyright> - <year>2008-2017</year> + <year>2008-2020</year> <holder>&kamailio; Project</holder> </copyright> </bookinfo>

1 0

git:master:446dc800: doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date
by Henning Westerholt 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: 446dc8006240050a1e0c13c7094e9f9739cc16c8 URL: https://github.com/kamailio/kamailio/commit/446dc8006240050a1e0c13c7094e9f9… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-29T11:39:34+02:00 doc/stylesheets: remove obselete company and e-mail address from my name, update copyright date --- Modified: doc/stylesheets/dbschema_k/bookinfo.xml --- Diff: https://github.com/kamailio/kamailio/commit/446dc8006240050a1e0c13c7094e9f9… Patch: https://github.com/kamailio/kamailio/commit/446dc8006240050a1e0c13c7094e9f9… --- diff --git a/doc/stylesheets/dbschema_k/bookinfo.xml b/doc/stylesheets/dbschema_k/bookinfo.xml index 5e4ce4bf71..e88d18761d 100644 --- a/doc/stylesheets/dbschema_k/bookinfo.xml +++ b/doc/stylesheets/dbschema_k/bookinfo.xml @@ -12,10 +12,6 @@ <editor> <firstname>Henning</firstname> <surname>Westerholt</surname> - <affiliation><orgname>1und1 Internet AG</orgname></affiliation> - <address> - <email>henning.westerholt(a)1und1.de</email> - </address> </editor> <editor> <firstname>Norman</firstname> @@ -23,7 +19,7 @@ </editor> </authorgroup> <copyright> - <year>2008-2017</year> + <year>2008-2020</year> <holder>&kamailio; Project</holder> </copyright> </bookinfo>

1 0

git:master:d4311f3d: lib/srdb1: fix warning about wrong namespace in version.xml
by Henning Westerholt 29 Mar '20

29 Mar '20

Module: kamailio Branch: master Commit: d4311f3dfa3fc6c3836e8573fb12bc2ae4b6c264 URL: https://github.com/kamailio/kamailio/commit/d4311f3dfa3fc6c3836e8573fb12bc2… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-29T11:27:07+02:00 lib/srdb1: fix warning about wrong namespace in version.xml --- Modified: src/lib/srdb1/schema/version.xml --- Diff: https://github.com/kamailio/kamailio/commit/d4311f3dfa3fc6c3836e8573fb12bc2… Patch: https://github.com/kamailio/kamailio/commit/d4311f3dfa3fc6c3836e8573fb12bc2… --- diff --git a/src/lib/srdb1/schema/version.xml b/src/lib/srdb1/schema/version.xml index 42734bb2b9..2b65f68dae 100644 --- a/src/lib/srdb1/schema/version.xml +++ b/src/lib/srdb1/schema/version.xml @@ -6,7 +6,7 @@ ]> -<table id="version" xmlns:xi="http://www.w3.org/2001/XInclude"> +<table id="version" xmlns:db="http://docbook.org/ns/docbook">> <name>version</name> <version>1</version> <type db="mysql">&MYSQL_TABLE_TYPE;</type>

1 0

git:master:91c1b9a0: modules: readme files regenerated - usrloc ... [skip ci]
by Kamailio Dev 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: 91c1b9a0e68c8a76a84fc7696b755cc1c8205aa5 URL: https://github.com/kamailio/kamailio/commit/91c1b9a0e68c8a76a84fc7696b755cc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-28T10:31:12+01:00 modules: readme files regenerated - usrloc ... [skip ci] --- Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/91c1b9a0e68c8a76a84fc7696b755cc… Patch: https://github.com/kamailio/kamailio/commit/91c1b9a0e68c8a76a84fc7696b755cc… --- diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index 5f3592be47..5ec1281c47 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -94,6 +94,8 @@ Carsten Bock 3.52. ka_from (str) 3.53. ka_domain (str) 3.54. ka_filter (int) + 3.55. ka_loglevel (int) + 3.56. ka_logmsg (str) 4. RPC Commands @@ -195,6 +197,8 @@ Carsten Bock 1.52. ka_from parameter usage 1.53. ka_domain parameter usage 1.54. ka_filter parameter usage + 1.55. ka_loglevel parameter usage + 1.56. ka_logmsg parameter usage Chapter 1. Admin Guide @@ -265,6 +269,8 @@ Chapter 1. Admin Guide 3.52. ka_from (str) 3.53. ka_domain (str) 3.54. ka_filter (int) + 3.55. ka_loglevel (int) + 3.56. ka_logmsg (str) 4. RPC Commands @@ -398,6 +404,8 @@ Chapter 1. Admin Guide 3.52. ka_from (str) 3.53. ka_domain (str) 3.54. ka_filter (int) + 3.55. ka_loglevel (int) + 3.56. ka_logmsg (str) 3.1. nat_bflag (int) @@ -1155,6 +1163,35 @@ modparam("usrloc", "ka_domain", "mydomain.com") modparam("usrloc", "ka_filter", 1) ... +3.55. ka_loglevel (int) + + The level to print the log message when the keepalive response is + received. It should be a value between LOG_ALERT + + Default value is “kamailio.org”. + + Example 1.55. ka_loglevel parameter usage +... +modparam("usrloc", "ka_loglevel", 1) +... + +3.56. ka_logmsg (str) + + The formatted log specification to be added to the message printed when + the keepalive is received and roundtrip time is computed. The log + message starts with "keepalive roundtrip: %u.%06u sec - ruid [%.*s]", + then concatenates the value of this parameter and the end of line. + + The value of this parameter can contain script variables that are + evaluated with the SIP response. + + Default value is “ to-uri: [$tu] src-uri: [$su]”. + + Example 1.56. ka_logmsg parameter usage +... +modparam("usrloc", "ka_logmsg", " to-uri: [$tu] src-uri: [$su]") +... + 4. RPC Commands 4.1. ul.dump

1 0

git:master:54bce5c7: usrloc: docs for ka_loglevel and ka_logmsg params
by Daniel-Constantin Mierla 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: 54bce5c707feb91b2de90abe64e75952972816f0 URL: https://github.com/kamailio/kamailio/commit/54bce5c707feb91b2de90abe64e7595… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-28T10:11:54+01:00 usrloc: docs for ka_loglevel and ka_logmsg params --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/54bce5c707feb91b2de90abe64e7595… Patch: https://github.com/kamailio/kamailio/commit/54bce5c707feb91b2de90abe64e7595… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index 7b945a76bb..a6d9654d51 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1424,6 +1424,50 @@ modparam("usrloc", "ka_filter", 1) </example> </section> + <section id="usrloc.p.ka_loglevel"> + <title><varname>ka_loglevel</varname> (int)</title> + <para> + The level to print the log message when the keepalive response is + received. It should be a value between LOG_ALERT + </para> + <para> + Default value is <quote>kamailio.org</quote>. + </para> + <example> + <title><varname>ka_loglevel</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_loglevel", 1) +... + </programlisting> + </example> + </section> + + <section id="usrloc.p.ka_logmsg"> + <title><varname>ka_logmsg</varname> (str)</title> + <para> + The formatted log specification to be added to the message printed when + the keepalive is received and roundtrip time is computed. The log + message starts with "keepalive roundtrip: %u.%06u sec - ruid [%.*s]", + then concatenates the value of this parameter and the end of line. + </para> + <para> + The value of this parameter can contain script variables that are + evaluated with the SIP response. + </para> + <para> + Default value is <quote> to-uri: [$tu] src-uri: [$su]</quote>. + </para> + <example> + <title><varname>ka_logmsg</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_logmsg", " to-uri: [$tu] src-uri: [$su]") +... + </programlisting> + </example> + </section> + </section> <section>

1 0

git:master:0d912f11: usrloc: fexible logging for roundtrip details
by Daniel-Constantin Mierla 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: 0d912f11c9618ea399b81fe7d38faf335fe911c7 URL: https://github.com/kamailio/kamailio/commit/0d912f11c9618ea399b81fe7d38faf3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-28T10:11:54+01:00 usrloc: fexible logging for roundtrip details - new params ka_loglevel and ka_logmsg --- Modified: src/modules/usrloc/ul_keepalive.c Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0d912f11c9618ea399b81fe7d38faf3… Patch: https://github.com/kamailio/kamailio/commit/0d912f11c9618ea399b81fe7d38faf3… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 7955efa14b..0addb21a42 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -32,6 +32,7 @@ #include "../../core/resolve.h" #include "../../core/forward.h" #include "../../core/globals.h" +#include "../../core/pvar.h" #include "../../core/parser/parse_uri.h" #include "../../core/parser/parse_from.h" #include "../../core/parser/parse_to.h" @@ -71,6 +72,9 @@ extern str ul_ka_domain; extern str ul_ka_method; extern int ul_ka_mode; extern int ul_ka_filter; +extern int ul_ka_loglevel; +extern pv_elem_t *ul_ka_logfmt; + extern unsigned int nat_bflag; static unsigned int _ul_ka_counter = 0; @@ -417,11 +421,19 @@ int ul_ka_reply_received(sip_msg_t *msg) gettimeofday(&tvn, NULL); tvdiff = (tvn.tv_sec - tvm.tv_sec) * 1000000 + (tvn.tv_usec - tvm.tv_usec); + ul_update_keepalive(aorhash, &ruid, tvn.tv_sec, tvdiff); - LM_DBG("reply for keepalive of [%.*s:%u] roundtrip: %u.%06usec\n", - ruid.len, ruid.s, aorhash, tvdiff/1000000, tvdiff%1000000); + if(ul_ka_loglevel != 255 && ul_ka_logfmt != NULL) { + if (pv_printf_s(msg, ul_ka_logfmt, &tok) == 0) { + LOG(ul_ka_loglevel, "keepalive roundtrip: %u.%06u sec - ruid [%.*s]%.*s\n", + tvdiff/1000000, tvdiff%1000000, ruid.len, ruid.s, + tok.len, tok.s); + return 0; + } + } - ul_update_keepalive(aorhash, &ruid, tvn.tv_sec, tvdiff); + LM_DBG("response of keepalive for ruid [%.*s] aorhash [%u] roundtrip: %u.%06u secs\n", + ruid.len, ruid.s, aorhash, tvdiff/1000000, tvdiff%1000000); return 0; } diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c index 0cceb0b0e5..8d3cfffdbf 100644 --- a/src/modules/usrloc/usrloc_mod.c +++ b/src/modules/usrloc/usrloc_mod.c @@ -123,6 +123,9 @@ str ul_ka_domain = str_init("kamailio.org"); str ul_ka_method = str_init("OPTIONS"); int ul_ka_mode = 0; int ul_ka_filter = 0; +int ul_ka_loglevel = 255; +str ul_ka_logmsg = str_init(" to-uri: [$tu] src-uri: [$su]"); +pv_elem_t *ul_ka_logfmt = NULL; /* sruid to get internal uid for mi/rpc commands */ sruid_t _ul_sruid; @@ -255,6 +258,7 @@ static param_export_t params[] = { {"ka_domain", PARAM_STR, &ul_ka_domain}, {"ka_method", PARAM_STR, &ul_ka_method}, {"ka_filter", PARAM_INT, &ul_ka_filter}, + {"ka_loglevel", PARAM_INT, &ul_ka_loglevel}, {0, 0, 0} }; @@ -396,9 +400,17 @@ static int mod_init(void) ul_set_xavp_contact_clone(1); } - /* set max partition number for timers processing of db records */ - if((ul_ka_mode != ULKA_NONE) && (ul_timer_procs > 1)) { - ul_set_max_partition((unsigned int)ul_timer_procs); + if(ul_ka_mode != ULKA_NONE) { + /* set max partition number for timers processing of db records */ + if (ul_timer_procs > 1) { + ul_set_max_partition((unsigned int)ul_timer_procs); + } + if(ul_ka_logmsg.len > 0) { + if(pv_parse_format(&ul_ka_logmsg, &ul_ka_logfmt) < 0) { + LM_ERR("failed parsing ka log message format\n"); + return -1; + } + } } init_flag = 1;

1 0

[kamailio/kamailio] pv: remove urlencode/urldecode functions (moved to core/strutils) (#2265)
by Armen Babikyan 28 Mar '20

28 Mar '20

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2265 -- Commit Summary -- * pv: remove urlencode/urldecode functions; moved to core/strutils -- File Changes -- M src/modules/pv/pv_trans.c (80) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2265.patch https://github.com/kamailio/kamailio/pull/2265.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2265

2 1

git:master:7883a5e4: Merge pull request #2265 from armenb/pv_remove_urlencode_urldecode
by GitHub 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: 7883a5e417d10e88d187c7d88f61e28506483b7d URL: https://github.com/kamailio/kamailio/commit/7883a5e417d10e88d187c7d88f61e28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-03-28T08:31:03+01:00 Merge pull request #2265 from armenb/pv_remove_urlencode_urldecode pv: remove urlencode/urldecode functions (moved to core/strutils) --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/7883a5e417d10e88d187c7d88f61e28… Patch: https://github.com/kamailio/kamailio/commit/7883a5e417d10e88d187c7d88f61e28… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 36dbcf24b5..826fa9c2ef 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -107,78 +107,6 @@ char *tr_set_crt_buffer(void) /* -- helper functions */ -/* Converts a hex character to its integer value */ -static char pv_from_hex(char ch) -{ - return isdigit(ch) ? ch - '0' : tolower(ch) - 'a' + 10; -} - -/* Converts an integer value to its hex character */ -static char pv_to_hex(char code) -{ - static char hex[] = "0123456789abcdef"; - return hex[code & 15]; -} - -/*! \brief - * URL Encodes a string for use in a HTTP query - */ -static int urlencode_param(str *sin, str *sout) -{ - char *at, *p; - - if (sin==NULL || sout==NULL || sin->s==NULL || sout->s==NULL || - sin->len<0 || sout->len < 3*sin->len+1) - return -1; - - at = sout->s; - p = sin->s; - - while (p < sin->s+sin->len) { - if (isalnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == '~') - *at++ = *p; - else if (*p == ' ') - *at++ = '+'; - else - *at++ = '%', *at++ = pv_to_hex(*p >> 4), *at++ = pv_to_hex(*p & 15); - p++; - } - - *at = 0; - sout->len = at - sout->s; - LM_DBG("urlencoded string is <%s>\n", sout->s); - - return 0; -} - -/* URL Decode a string */ -static int urldecode_param(str *sin, str *sout) { - char *at, *p; - - at = sout->s; - p = sin->s; - - while (p < sin->s+sin->len) { - if (*p == '%') { - if (p[1] && p[2]) { - *at++ = pv_from_hex(p[1]) << 4 | pv_from_hex(p[2]); - p += 2; - } - } else if (*p == '+') { - *at++ = ' '; - } else { - *at++ = *p; - } - p++; - } - - *at = 0; - sout->len = at - sout->s; - - LM_DBG("urldecoded string is <%s>\n", sout->s); - return 0; -} - /* Encode 7BIT PDU */ static int pdu_7bit_encode(str sin) { int i, j; @@ -215,8 +143,8 @@ static int pdu_7bit_decode(str sin) { unsigned char oldfill = 0; j = 0; for(i = 0; i < sin.len; i += 2) { - _tr_buffer[j] = (unsigned char)pv_from_hex(sin.s[i]) << 4; - _tr_buffer[j] |= (unsigned char)pv_from_hex(sin.s[i+1]); + _tr_buffer[j] = (unsigned char)hex_to_char(sin.s[i]) << 4; + _tr_buffer[j] |= (unsigned char)hex_to_char(sin.s[i+1]); fill = (unsigned char)_tr_buffer[j]; fill >>= (8 - nleft); _tr_buffer[j] <<= (nleft -1 ); @@ -1246,7 +1174,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, return -1; st.s = _tr_buffer; st.len = TR_BUFFER_SIZE; - if (urlencode_param(&val->rs, &st) < 0) + if (urlencode(&val->rs, &st) < 0) return -1; memset(val, 0, sizeof(pv_value_t)); val->flags = PV_VAL_STR; @@ -1260,7 +1188,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, return -1; st.s = _tr_buffer; st.len = TR_BUFFER_SIZE; - if (urldecode_param(&val->rs, &st) < 0) + if (urldecode(&val->rs, &st) < 0) return -1; memset(val, 0, sizeof(pv_value_t)); val->flags = PV_VAL_STR;

1 0

git:master:c2ddf608: pv: remove urlencode/urldecode functions; moved to core/strutils
by Armen Babikyan 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: c2ddf608dd3cdb3a071763769e336157f9e831c9 URL: https://github.com/kamailio/kamailio/commit/c2ddf608dd3cdb3a071763769e33615… Author: Armen Babikyan <armen(a)firespotter.com> Committer: Armen Babikyan <armen(a)firespotter.com> Date: 2020-03-27T14:14:53-07:00 pv: remove urlencode/urldecode functions; moved to core/strutils --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/c2ddf608dd3cdb3a071763769e33615… Patch: https://github.com/kamailio/kamailio/commit/c2ddf608dd3cdb3a071763769e33615… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 36dbcf24b5..826fa9c2ef 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -107,78 +107,6 @@ char *tr_set_crt_buffer(void) /* -- helper functions */ -/* Converts a hex character to its integer value */ -static char pv_from_hex(char ch) -{ - return isdigit(ch) ? ch - '0' : tolower(ch) - 'a' + 10; -} - -/* Converts an integer value to its hex character */ -static char pv_to_hex(char code) -{ - static char hex[] = "0123456789abcdef"; - return hex[code & 15]; -} - -/*! \brief - * URL Encodes a string for use in a HTTP query - */ -static int urlencode_param(str *sin, str *sout) -{ - char *at, *p; - - if (sin==NULL || sout==NULL || sin->s==NULL || sout->s==NULL || - sin->len<0 || sout->len < 3*sin->len+1) - return -1; - - at = sout->s; - p = sin->s; - - while (p < sin->s+sin->len) { - if (isalnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == '~') - *at++ = *p; - else if (*p == ' ') - *at++ = '+'; - else - *at++ = '%', *at++ = pv_to_hex(*p >> 4), *at++ = pv_to_hex(*p & 15); - p++; - } - - *at = 0; - sout->len = at - sout->s; - LM_DBG("urlencoded string is <%s>\n", sout->s); - - return 0; -} - -/* URL Decode a string */ -static int urldecode_param(str *sin, str *sout) { - char *at, *p; - - at = sout->s; - p = sin->s; - - while (p < sin->s+sin->len) { - if (*p == '%') { - if (p[1] && p[2]) { - *at++ = pv_from_hex(p[1]) << 4 | pv_from_hex(p[2]); - p += 2; - } - } else if (*p == '+') { - *at++ = ' '; - } else { - *at++ = *p; - } - p++; - } - - *at = 0; - sout->len = at - sout->s; - - LM_DBG("urldecoded string is <%s>\n", sout->s); - return 0; -} - /* Encode 7BIT PDU */ static int pdu_7bit_encode(str sin) { int i, j; @@ -215,8 +143,8 @@ static int pdu_7bit_decode(str sin) { unsigned char oldfill = 0; j = 0; for(i = 0; i < sin.len; i += 2) { - _tr_buffer[j] = (unsigned char)pv_from_hex(sin.s[i]) << 4; - _tr_buffer[j] |= (unsigned char)pv_from_hex(sin.s[i+1]); + _tr_buffer[j] = (unsigned char)hex_to_char(sin.s[i]) << 4; + _tr_buffer[j] |= (unsigned char)hex_to_char(sin.s[i+1]); fill = (unsigned char)_tr_buffer[j]; fill >>= (8 - nleft); _tr_buffer[j] <<= (nleft -1 ); @@ -1246,7 +1174,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, return -1; st.s = _tr_buffer; st.len = TR_BUFFER_SIZE; - if (urlencode_param(&val->rs, &st) < 0) + if (urlencode(&val->rs, &st) < 0) return -1; memset(val, 0, sizeof(pv_value_t)); val->flags = PV_VAL_STR; @@ -1260,7 +1188,7 @@ int tr_eval_string(struct sip_msg *msg, tr_param_t *tp, int subtype, return -1; st.s = _tr_buffer; st.len = TR_BUFFER_SIZE; - if (urldecode_param(&val->rs, &st) < 0) + if (urldecode(&val->rs, &st) < 0) return -1; memset(val, 0, sizeof(pv_value_t)); val->flags = PV_VAL_STR;

1 0

[kamailio/kamailio] core: strutils - add urlencode and urldecode functions (#2264)
by Armen Babikyan 28 Mar '20

28 Mar '20

- moved from modules/pv/pv_trans.c and exported, so they can be used in other modules - genericized fn names You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2264 -- Commit Summary -- * core: strutils - add urlencode and urldecode functions -- File Changes -- M src/core/strutils.c (73) M src/core/strutils.h (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2264.patch https://github.com/kamailio/kamailio/pull/2264.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2264

2 2

git:master:c5bac154: Merge pull request #2264 from armenb/core_strutils_urlencode_urldecode
by GitHub 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: c5bac15472ad7db452e35f000a3236a839f14cf8 URL: https://github.com/kamailio/kamailio/commit/c5bac15472ad7db452e35f000a3236a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-03-28T08:30:16+01:00 Merge pull request #2264 from armenb/core_strutils_urlencode_urldecode core: strutils - add urlencode and urldecode functions --- Modified: src/core/strutils.c Modified: src/core/strutils.h --- Diff: https://github.com/kamailio/kamailio/commit/c5bac15472ad7db452e35f000a3236a… Patch: https://github.com/kamailio/kamailio/commit/c5bac15472ad7db452e35f000a3236a… --- diff --git a/src/core/strutils.c b/src/core/strutils.c index b06fa44175..7df31727cb 100644 --- a/src/core/strutils.c +++ b/src/core/strutils.c @@ -701,3 +701,76 @@ int reg_replace(char *pattern, char *replacement, char *string, str *result) return replace(&pmatch[0], string, replacement, result); } + +/* Converts a hex character to its integer value */ +char hex_to_char(char hex_code) +{ + return isdigit(hex_code) ? hex_code - '0' : tolower(hex_code) - 'a' + 10; +} + +/* Converts an integer value to its hex character */ +char char_to_hex(char char_code) +{ + static char hex[] = "0123456789abcdef"; + return hex[char_code & 15]; +} + +/*! \brief + * URL Encodes a string + */ +int urlencode(str *sin, str *sout) +{ + char *at, *p; + + if (sin==NULL || sout==NULL || sin->s==NULL || sout->s==NULL || + sin->len<0 || sout->len < 3*sin->len+1) + return -1; + + at = sout->s; + p = sin->s; + + while (p < sin->s+sin->len) { + if (isalnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == '~') + *at++ = *p; + else + *at++ = '%', *at++ = char_to_hex(*p >> 4), *at++ = char_to_hex(*p & 15); + p++; + } + + *at = 0; + sout->len = at - sout->s; + LM_DBG("urlencoded string is <%s>\n", sout->s); + + return 0; +} + +/*! \brief + * URL Decodes a string + */ +int urldecode(str *sin, str *sout) +{ + char *at, *p; + + at = sout->s; + p = sin->s; + + while (p < sin->s+sin->len) { + if (*p == '%') { + if (p[1] && p[2]) { + *at++ = hex_to_char(p[1]) << 4 | hex_to_char(p[2]); + p += 2; + } + } else if (*p == '+') { + *at++ = ' '; + } else { + *at++ = *p; + } + p++; + } + + *at = 0; + sout->len = at - sout->s; + + LM_DBG("urldecoded string is <%s>\n", sout->s); + return 0; +} diff --git a/src/core/strutils.h b/src/core/strutils.h index 37152dd18d..8b20f72e44 100644 --- a/src/core/strutils.h +++ b/src/core/strutils.h @@ -61,4 +61,8 @@ int escape_param(str *sin, str *sout); int unescape_param(str *sin, str *sout); int escape_csv(str *sin, str *sout); +char hex_to_char(char hex_code); +char char_to_hex(char char_code); +int urlencode(str *sin, str *sout); +int urldecode(str *sin, str *sout); #endif

1 0

git:master:0973bee7: core: strutils - add urlencode and urldecode functions
by Armen Babikyan 28 Mar '20

28 Mar '20

Module: kamailio Branch: master Commit: 0973bee70e2a7f6ea274c357083fb67b6b2e27ad URL: https://github.com/kamailio/kamailio/commit/0973bee70e2a7f6ea274c357083fb67… Author: Armen Babikyan <armen(a)firespotter.com> Committer: Armen Babikyan <armen(a)firespotter.com> Date: 2020-03-27T14:32:29-07:00 core: strutils - add urlencode and urldecode functions - moved from modules/pv/pv_trans.c and exported, so they can be used in other modules - genericized fn names --- Modified: src/core/strutils.c Modified: src/core/strutils.h --- Diff: https://github.com/kamailio/kamailio/commit/0973bee70e2a7f6ea274c357083fb67… Patch: https://github.com/kamailio/kamailio/commit/0973bee70e2a7f6ea274c357083fb67… --- diff --git a/src/core/strutils.c b/src/core/strutils.c index b06fa44175..7df31727cb 100644 --- a/src/core/strutils.c +++ b/src/core/strutils.c @@ -701,3 +701,76 @@ int reg_replace(char *pattern, char *replacement, char *string, str *result) return replace(&pmatch[0], string, replacement, result); } + +/* Converts a hex character to its integer value */ +char hex_to_char(char hex_code) +{ + return isdigit(hex_code) ? hex_code - '0' : tolower(hex_code) - 'a' + 10; +} + +/* Converts an integer value to its hex character */ +char char_to_hex(char char_code) +{ + static char hex[] = "0123456789abcdef"; + return hex[char_code & 15]; +} + +/*! \brief + * URL Encodes a string + */ +int urlencode(str *sin, str *sout) +{ + char *at, *p; + + if (sin==NULL || sout==NULL || sin->s==NULL || sout->s==NULL || + sin->len<0 || sout->len < 3*sin->len+1) + return -1; + + at = sout->s; + p = sin->s; + + while (p < sin->s+sin->len) { + if (isalnum(*p) || *p == '-' || *p == '_' || *p == '.' || *p == '~') + *at++ = *p; + else + *at++ = '%', *at++ = char_to_hex(*p >> 4), *at++ = char_to_hex(*p & 15); + p++; + } + + *at = 0; + sout->len = at - sout->s; + LM_DBG("urlencoded string is <%s>\n", sout->s); + + return 0; +} + +/*! \brief + * URL Decodes a string + */ +int urldecode(str *sin, str *sout) +{ + char *at, *p; + + at = sout->s; + p = sin->s; + + while (p < sin->s+sin->len) { + if (*p == '%') { + if (p[1] && p[2]) { + *at++ = hex_to_char(p[1]) << 4 | hex_to_char(p[2]); + p += 2; + } + } else if (*p == '+') { + *at++ = ' '; + } else { + *at++ = *p; + } + p++; + } + + *at = 0; + sout->len = at - sout->s; + + LM_DBG("urldecoded string is <%s>\n", sout->s); + return 0; +} diff --git a/src/core/strutils.h b/src/core/strutils.h index 37152dd18d..8b20f72e44 100644 --- a/src/core/strutils.h +++ b/src/core/strutils.h @@ -61,4 +61,8 @@ int escape_param(str *sin, str *sout); int unescape_param(str *sin, str *sout); int escape_csv(str *sin, str *sout); +char hex_to_char(char hex_code); +char char_to_hex(char char_code); +int urlencode(str *sin, str *sout); +int urldecode(str *sin, str *sout); #endif

1 0

git:master:7d1e27e9: modules: readme files regenerated - usrloc ... [skip ci]
by Kamailio Dev 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 7d1e27e945b09674f07bdb56f69947b41e8e945a URL: https://github.com/kamailio/kamailio/commit/7d1e27e945b09674f07bdb56f69947b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-27T18:31:09+01:00 modules: readme files regenerated - usrloc ... [skip ci] --- Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/7d1e27e945b09674f07bdb56f69947b… Patch: https://github.com/kamailio/kamailio/commit/7d1e27e945b09674f07bdb56f69947b… --- diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index 4637de5a55..5f3592be47 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -93,6 +93,7 @@ Carsten Bock 3.51. ka_method (str) 3.52. ka_from (str) 3.53. ka_domain (str) + 3.54. ka_filter (int) 4. RPC Commands @@ -193,6 +194,7 @@ Carsten Bock 1.51. ka_method parameter usage 1.52. ka_from parameter usage 1.53. ka_domain parameter usage + 1.54. ka_filter parameter usage Chapter 1. Admin Guide @@ -262,6 +264,7 @@ Chapter 1. Admin Guide 3.51. ka_method (str) 3.52. ka_from (str) 3.53. ka_domain (str) + 3.54. ka_filter (int) 4. RPC Commands @@ -394,6 +397,7 @@ Chapter 1. Admin Guide 3.51. ka_method (str) 3.52. ka_from (str) 3.53. ka_domain (str) + 3.54. ka_filter (int) 3.1. nat_bflag (int) @@ -1066,14 +1070,15 @@ modparam("usrloc", "version_table", 0) 3.50. ka_mode (int) Keepalive mode - control the internal keepalive mechanism. With this - feature enable, the module sends periodically (based on timer interval) - SIP requests to location contacts and measures the round trip in - microseconds (the round trip value can be seen in the response of the - RPC command 'ul.dump'). + feature enabled, the module sends periodically (based on timer + interval) SIP requests to location contacts and measures the round trip + in microseconds (the round trip value can be seen in the response of + the RPC command 'ul.dump'). Its value is a set of flags: * 0 - if the value is zero, no keepalive is sent - * 1 - if set to 1, the keepalive is enabled for all contacts + * 1 (bit 1 set) - if set to 1, the keepalive is enabled for all + contacts * 2 (bit 2 set) - the keepalive is sent only for natted contacts (nat_bflag set) * 4 (bit 3 set) - the keepalive is sent only for UDP contacts @@ -1134,6 +1139,22 @@ modparam("usrloc", "ka_from", "sip:server@mydomain.com") modparam("usrloc", "ka_domain", "mydomain.com") ... +3.54. ka_filter (int) + + Set filters for keepalive processing. + + Its value is a set of flags: + * 0 - if the value is zero, no filter is enabled for keepalives + * 1 (bit 1 set) - keepalives sent only to records matching the + server_id global parameter. + + Default value is “0” (no filter). + + Example 1.54. ka_filter parameter usage +... +modparam("usrloc", "ka_filter", 1) +... + 4. RPC Commands 4.1. ul.dump

1 0

git:master:30eda8a8: usrloc: keepalive server id filtering also for in-memory contacts
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 30eda8a8f244e3e6eba66b50fa355b11735d8f7d URL: https://github.com/kamailio/kamailio/commit/30eda8a8f244e3e6eba66b50fa355b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T18:16:28+01:00 usrloc: keepalive server id filtering also for in-memory contacts --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/ul_keepalive.c --- Diff: https://github.com/kamailio/kamailio/commit/30eda8a8f244e3e6eba66b50fa355b1… Patch: https://github.com/kamailio/kamailio/commit/30eda8a8f244e3e6eba66b50fa355b1… --- diff --git a/src/modules/usrloc/dlist.c b/src/modules/usrloc/dlist.c index 14eb75b1d4..a811df5326 100644 --- a/src/modules/usrloc/dlist.c +++ b/src/modules/usrloc/dlist.c @@ -222,6 +222,9 @@ int ul_ka_db_records(int partidx) /* flags */ uc.cflags = VAL_BITMAP(ROW_VALUES(row) + 3); + /* server id */ + uc.server_id = server_id; + /* aor from username and domain */ ur.aor.s = aorbuf; ur.domain = &dom->name; diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 3557848e34..7955efa14b 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -31,6 +31,7 @@ #include "../../core/ut.h" #include "../../core/resolve.h" #include "../../core/forward.h" +#include "../../core/globals.h" #include "../../core/parser/parse_uri.h" #include "../../core/parser/parse_from.h" #include "../../core/parser/parse_to.h" @@ -69,6 +70,7 @@ extern str ul_ka_from; extern str ul_ka_domain; extern str ul_ka_method; extern int ul_ka_mode; +extern int ul_ka_filter; extern unsigned int nat_bflag; static unsigned int _ul_ka_counter = 0; @@ -113,6 +115,9 @@ int ul_ka_urecord(urecord_t *ur) if (uc->c.len <= 0) { continue; } + if((ul_ka_filter&GAU_OPT_SERVER_ID) && (uc->server_id != server_id)) { + continue; + } if(ul_ka_mode & ULKA_NAT) { /* keepalive for natted contacts only */ if (nat_bflag == 0) {

1 0

git:master:1968b324: usrloc: docs for ka_filter parameter
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 1968b3248acc9d71974f5765e489af82ecf4849a URL: https://github.com/kamailio/kamailio/commit/1968b3248acc9d71974f5765e489af8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T18:06:46+01:00 usrloc: docs for ka_filter parameter --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/1968b3248acc9d71974f5765e489af8… Patch: https://github.com/kamailio/kamailio/commit/1968b3248acc9d71974f5765e489af8… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index d4f96db94f..7b945a76bb 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1229,9 +1229,12 @@ modparam("usrloc", "rm_expired_delay", 30) <section id="usrloc.p.server_id_filter"> <title><varname>server_id_filter</varname> (int)</title> <para> - Enable (1) or disable (0) filter records by server_id on load and during cleaning of expired db records. - It could be useful when you want to use the same location table for several kamailio instances which are configured to work in db_mode=1 or db_mode=2 (cache modes). - Otherwise one instance of proxy cleans records made by another proxy and that breaks its cache. + Enable (1) or disable (0) filter records by server_id on load and + during cleaning of expired db records. It could be useful when you + want to use the same location table for several kamailio instances + which are configured to work in db_mode=1 or db_mode=2 (cache modes). + Otherwise one instance of proxy cleans records made by another proxy + and that breaks its cache. </para> <para> <emphasis> @@ -1271,7 +1274,7 @@ modparam("usrloc", "version_table", 0) <title><varname>ka_mode</varname> (int)</title> <para> Keepalive mode - control the internal keepalive mechanism. With this feature - enable, the module sends periodically (based on timer interval) SIP requests + enabled, the module sends periodically (based on timer interval) SIP requests to location contacts and measures the round trip in microseconds (the round trip value can be seen in the response of the RPC command 'ul.dump'). </para> @@ -1286,7 +1289,7 @@ modparam("usrloc", "version_table", 0) </listitem> <listitem> <para> - 1 - if set to 1, the keepalive is enabled for all contacts + 1 (bit 1 set) - if set to 1, the keepalive is enabled for all contacts </para> </listitem> <listitem> @@ -1349,7 +1352,7 @@ modparam("usrloc", "ka_method", "NOTIFY") </example> </section> - <section id="usrloc.p.from"> + <section id="usrloc.p.ka_from"> <title><varname>ka_from</varname> (str)</title> <para> The SIP URI to be set in the From header of the keepalive requests. @@ -1367,7 +1370,7 @@ modparam("usrloc", "ka_from", "sip:server@mydomain.com") </example> </section> - <section id="usrloc.p.domain"> + <section id="usrloc.p.ka_domain"> <title><varname>ka_domain</varname> (str)</title> <para> The domain to be set in To header URI if the multi-domain is not enabled. @@ -1387,6 +1390,40 @@ modparam("usrloc", "ka_domain", "mydomain.com") </example> </section> + <section id="usrloc.p.ka_filter"> + <title><varname>ka_filter</varname> (int)</title> + <para> + Set filters for keepalive processing. + </para> + <para> + Its value is a set of flags: + </para> + <itemizedlist> + <listitem> + <para> + 0 - if the value is zero, no filter is enabled for keepalives + </para> + </listitem> + <listitem> + <para> + 1 (bit 1 set) - keepalives sent only to records matching the + server_id global parameter. + </para> + </listitem> + </itemizedlist> + <para> + Default value is <quote>0</quote> (no filter). + </para> + <example> + <title><varname>ka_filter</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_filter", 1) +... + </programlisting> + </example> + </section> + </section> <section>

1 0

git:master:c4f3de7b: usrloc: internal keepalive support for db only mode
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: c4f3de7bfa704551e4b6cbf16e543c469a42c99c URL: https://github.com/kamailio/kamailio/commit/c4f3de7bfa704551e4b6cbf16e543c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T17:54:00+01:00 usrloc: internal keepalive support for db only mode - new parameter ka_filter to enable server_id filtering of db records processed for keepalive --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/c4f3de7bfa704551e4b6cbf16e543c4… Patch: https://github.com/kamailio/kamailio/commit/c4f3de7bfa704551e4b6cbf16e543c4…

1 0

git:master:f47700bb: usrloc: fixed wrong comments related to the flags fields in ucontact_t
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: f47700bb55cbf19f7d3f7d967bd4c4755a994db5 URL: https://github.com/kamailio/kamailio/commit/f47700bb55cbf19f7d3f7d967bd4c47… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T17:52:53+01:00 usrloc: fixed wrong comments related to the flags fields in ucontact_t --- Modified: src/modules/usrloc/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/f47700bb55cbf19f7d3f7d967bd4c47… Patch: https://github.com/kamailio/kamailio/commit/f47700bb55cbf19f7d3f7d967bd4c47… --- diff --git a/src/modules/usrloc/usrloc.h b/src/modules/usrloc/usrloc.h index 5d071c1734..a9a0309d9d 100644 --- a/src/modules/usrloc/usrloc.h +++ b/src/modules/usrloc/usrloc.h @@ -82,8 +82,8 @@ typedef struct ucontact { str callid; /*!< Call-ID header field of registration */ int cseq; /*!< CSeq value */ cstate_t state; /*!< State of the contact (\ref cstate) */ - unsigned int flags; /*!< Various flags (NAT, ping type, etc) */ - unsigned int cflags; /*!< Custom contact flags (from script) */ + unsigned int flags; /*!< Various internal flags (sync, etc) */ + unsigned int cflags; /*!< Custom contact flags (from script - bflags) */ str user_agent; /*!< User-Agent header field */ str uniq; /*!< Uniq header field */ struct socket_info *sock; /*!< received socket */

1 0

git:master:bef747a3: usrloc: global root var for domains list renamed to _ksr_ul_root
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: bef747a3ff728fb92593c565229d20e642b8b6c4 URL: https://github.com/kamailio/kamailio/commit/bef747a3ff728fb92593c565229d20e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T13:58:56+01:00 usrloc: global root var for domains list renamed to _ksr_ul_root --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/dlist.h Modified: src/modules/usrloc/ul_rpc.c Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/bef747a3ff728fb92593c565229d20e… Patch: https://github.com/kamailio/kamailio/commit/bef747a3ff728fb92593c565229d20e…

1 0

git:master:3b706926: pkg/kamailio/deb: version set 5.4.0~dev4
by Victor Seva 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 3b7069269f28be7869a90420682ef03641a741e4 URL: https://github.com/kamailio/kamailio/commit/3b7069269f28be7869a90420682ef03… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-27T12:55:43+01:00 pkg/kamailio/deb: version set 5.4.0~dev4 --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/3b7069269f28be7869a90420682ef03… Patch: https://github.com/kamailio/kamailio/commit/3b7069269f28be7869a90420682ef03…

1 0

[kamailio/kamailio] [FEATURE REQUEST] - Add RTT metric to usrloc for measuring subscriber latency (#2223)
by Joel Serrano 27 Mar '20

27 Mar '20

## Description ### Add RTT metric to usrloc for measuring subscriber latency This has been discussed several times in the mailing list. As I personally need this too I though it would be a good idea to open this issue for tracking. Unfortunately I'm not aware of the complexity of implementing this and I cannot code it myself, I'm happy to do any testing though or help with any other tasks. Some threads were this has been commented and some solutions proposed by @miconda: https://lists.kamailio.org/pipermail/sr-users/2015-April/088031.html (1st post, see complete thread) https://lists.kamailio.org/pipermail/sr-users/2019-January/104291.html (1st post, see complete thread) Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2223

2 2

[kamailio/kamailio] qm_free(): BUG: freeing already freed pointer (#2224)
by ibaques 27 Mar '20

27 Mar '20

### Description Kamailio is crashing randomly 1 or 2 times a day. We have 2 kamailio with DMQ/Dialog sharing. #### Debugging Data ``` #0 0x00007feb7466ddf3 in destroy_linkers () from /usr/lib64/kamailio/modules/dialog.so No symbol table info available. #1 0x00007feb7463a42e in dlg_dmq_handle_msg () from /usr/lib64/kamailio/modules/dialog.so No symbol table info available. #2 0x00007feb74d90718 in worker_loop () from /usr/lib64/kamailio/modules/dmq.so No symbol table info available. #3 0x00007feb74d73686 in ?? () from /usr/lib64/kamailio/modules/dmq.so No symbol table info available. #4 0x00000000005e79b0 in ?? () No symbol table info available. #5 0x00000000005e763c in ?? () No symbol table info available. #6 0x00000000005e763c in ?? () No symbol table info available. #7 0x00000000005e763c in ?? () No symbol table info available. #8 0x00000000005e763c in ?? () No symbol table info available. #9 0x00000000005e763c in ?? () No symbol table info available. #10 0x00000000005e763c in ?? () No symbol table info available. #11 0x00000000005e763c in ?? () No symbol table info available. #12 0x00000000005e80e9 in init_child () No symbol table info available. #13 0x0000000000426b94 in main_loop () ---Type <return> to continue, or q <return> to quit--- No symbol table info available. #14 0x000000000042e52a in main () No symbol table info available. ``` #### Log Messages ``` /usr/sbin/kamailio[9221]: CRITICAL: <core> [core/mem/q_malloc.c:521]: qm_free(): BUG: freeing already freed pointer (0x7feb781ee500), called from dialog: dlg_profile.c: destroy_linkers(291), first free dialog: dlg_profile.c: destroy_linkers(291) - ignoring /usr/sbin/kamailio[9221]: ALERT: <core> [main.c:767]: handle_sigs(): child process 9495 exited by a signal 11 /usr/sbin/kamailio[9221]: ALERT: <core> [main.c:770]: handle_sigs(): core was generated /usr/sbin/kamailio[9221]: CRITICAL: <core> [main.c:678]: sig_alarm_abort(): shutdown timeout triggered, dying... ``` ### Additional Information ``` version: kamailio 5.3.2 (x86_64/linux) 7ba545 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 7ba545 compiled on 11:29:01 Jan 9 2020 with gcc 4.4.7 ``` * **Operating System**: ``` 2.6.32-042stab140.1 #1 SMP Thu Aug 15 13:32:22 MSK 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2224

3 7

git:master:b4d38c4a: modules: readme files regenerated - usrloc ... [skip ci]
by Kamailio Dev 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: b4d38c4a1bf40e190628a82db87a2b913abecf22 URL: https://github.com/kamailio/kamailio/commit/b4d38c4a1bf40e190628a82db87a2b9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-27T10:31:18+01:00 modules: readme files regenerated - usrloc ... [skip ci] --- Modified: src/modules/usrloc/README --- Diff: https://github.com/kamailio/kamailio/commit/b4d38c4a1bf40e190628a82db87a2b9… Patch: https://github.com/kamailio/kamailio/commit/b4d38c4a1bf40e190628a82db87a2b9… --- diff --git a/src/modules/usrloc/README b/src/modules/usrloc/README index 2cc6ddc0f3..4637de5a55 100644 --- a/src/modules/usrloc/README +++ b/src/modules/usrloc/README @@ -89,6 +89,10 @@ Carsten Bock 3.47. rm_expired_delay (int) 3.48. server_id_filter (int) 3.49. version_table (int) + 3.50. ka_mode (int) + 3.51. ka_method (str) + 3.52. ka_from (str) + 3.53. ka_domain (str) 4. RPC Commands @@ -185,6 +189,10 @@ Carsten Bock 1.47. Set rm_expired_delay parameter 1.48. Set server_id_filter parameter 1.49. version_table parameter usage + 1.50. ka_mode parameter usage + 1.51. ka_method parameter usage + 1.52. ka_from parameter usage + 1.53. ka_domain parameter usage Chapter 1. Admin Guide @@ -250,6 +258,10 @@ Chapter 1. Admin Guide 3.47. rm_expired_delay (int) 3.48. server_id_filter (int) 3.49. version_table (int) + 3.50. ka_mode (int) + 3.51. ka_method (str) + 3.52. ka_from (str) + 3.53. ka_domain (str) 4. RPC Commands @@ -378,6 +390,10 @@ Chapter 1. Admin Guide 3.47. rm_expired_delay (int) 3.48. server_id_filter (int) 3.49. version_table (int) + 3.50. ka_mode (int) + 3.51. ka_method (str) + 3.52. ka_from (str) + 3.53. ka_domain (str) 3.1. nat_bflag (int) @@ -1047,6 +1063,77 @@ modparam("usrloc", "server_id_filter", 1) modparam("usrloc", "version_table", 0) ... +3.50. ka_mode (int) + + Keepalive mode - control the internal keepalive mechanism. With this + feature enable, the module sends periodically (based on timer interval) + SIP requests to location contacts and measures the round trip in + microseconds (the round trip value can be seen in the response of the + RPC command 'ul.dump'). + + Its value is a set of flags: + * 0 - if the value is zero, no keepalive is sent + * 1 - if set to 1, the keepalive is enabled for all contacts + * 2 (bit 2 set) - the keepalive is sent only for natted contacts + (nat_bflag set) + * 4 (bit 3 set) - the keepalive is sent only for UDP contacts + + For example, if set to 6, then keepalive is sent only natted UDP + contacs. + + Note: the internal keepalive of usrloc module conflicts in some way + with the keepalive done by nathelper module. It is recommended to + enable only one. + + Note: the internal keepalive is for the moment implemented only for + contact records stored in memory. + + Note: it is recommeder to set 'timer_procs' parameter in order to have + dedicated timer processes for usrloc module and off-load the keepalive + sending process from the core timers. + + Default value is “0 (keepalive disabled)”. + + Example 1.50. ka_mode parameter usage +... +modparam("usrloc", "ka_mode", 1) +... + +3.51. ka_method (str) + + The SIP method type for keepalive requests. + + Default value is “OPTIONS”. + + Example 1.51. ka_method parameter usage +... +modparam("usrloc", "ka_method", "NOTIFY") +... + +3.52. ka_from (str) + + The SIP URI to be set in the From header of the keepalive requests. + + Default value is “sip:server@kamailio.org”. + + Example 1.52. ka_from parameter usage +... +modparam("usrloc", "ka_from", "sip:server@mydomain.com") +... + +3.53. ka_domain (str) + + The domain to be set in To header URI if the multi-domain is not + enabled. If multi-domain is enabled, then the domain from the location + record is used and this parameter is ignored. + + Default value is “kamailio.org”. + + Example 1.53. ka_domain parameter usage +... +modparam("usrloc", "ka_domain", "mydomain.com") +... + 4. RPC Commands 4.1. ul.dump

1 0

git:master:91bf474a: usrloc: options to do keepalive for natted or udp contacts only
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 91bf474a77ad594edccc5e5f8aca9f0abd905aca URL: https://github.com/kamailio/kamailio/commit/91bf474a77ad594edccc5e5f8aca9f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T10:16:23+01:00 usrloc: options to do keepalive for natted or udp contacts only - variants to make it emulate the current nathelper keepalive, which is done for UDP only - usrloc keepalive can be sent for all types of contacts --- Modified: src/modules/usrloc/ul_keepalive.c Modified: src/modules/usrloc/ul_keepalive.h Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/91bf474a77ad594edccc5e5f8aca9f0… Patch: https://github.com/kamailio/kamailio/commit/91bf474a77ad594edccc5e5f8aca9f0… --- diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index b40a93040a..3557848e34 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -97,7 +97,7 @@ int ul_ka_urecord(urecord_t *ur) int i; struct timeval tv; - if (ul_ka_mode == 0) { + if (ul_ka_mode == ULKA_NONE) { return 0; } LM_DBG("keepalive for aor: %.*s\n", ur->aor.len, ur->aor.s); @@ -113,7 +113,7 @@ int ul_ka_urecord(urecord_t *ur) if (uc->c.len <= 0) { continue; } - if(ul_ka_mode == 2) { + if(ul_ka_mode & ULKA_NAT) { /* keepalive for natted contacts only */ if (nat_bflag == 0) { continue; @@ -145,9 +145,15 @@ int ul_ka_urecord(urecord_t *ur) dproto = duri.proto; he = sip_resolvehost(&duri.host, &duri.port_no, &dproto); if(he == NULL) { - LM_ERR("can't resolve_host\n"); + LM_ERR("cannot resolve destination\n"); continue; } + if(ul_ka_mode & ULKA_UDP) { + if(dproto != PROTO_UDP) { + LM_DBG("skipping non-udp contact - proto %d\n", (int)dproto); + continue; + } + } init_dest_info(&idst); hostent2su(&idst.to, he, 0, duri.port_no); ssock = uc->sock; diff --git a/src/modules/usrloc/ul_keepalive.h b/src/modules/usrloc/ul_keepalive.h index b5c673efce..71a59db81a 100644 --- a/src/modules/usrloc/ul_keepalive.h +++ b/src/modules/usrloc/ul_keepalive.h @@ -28,6 +28,11 @@ #include "urecord.h" +#define ULKA_NONE 0 +#define ULKA_ALL 1 +#define ULKA_NAT (1<<1) +#define ULKA_UDP (1<<2) + int ul_ka_urecord(urecord_t *ur); int ul_ka_reply_received(sip_msg_t *msg); diff --git a/src/modules/usrloc/usrloc_mod.c b/src/modules/usrloc/usrloc_mod.c index b633e4c1ed..42964e1315 100644 --- a/src/modules/usrloc/usrloc_mod.c +++ b/src/modules/usrloc/usrloc_mod.c @@ -251,8 +251,8 @@ static param_export_t params[] = { {"version_table", PARAM_INT, &ul_version_table}, {"ka_mode", PARAM_INT, &ul_ka_mode}, {"ka_from", PARAM_STR, &ul_ka_from}, - {"ka_domain", PARAM_STR, &ul_ka_domain}, - {"ka_method", PARAM_STR, &ul_ka_method}, + {"ka_domain", PARAM_STR, &ul_ka_domain}, + {"ka_method", PARAM_STR, &ul_ka_method}, {0, 0, 0} };

1 0

git:master:d1a221af: usrloc: docs for keepalive parameters
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: d1a221af4cac226199365c18a6a121090dc4cf82 URL: https://github.com/kamailio/kamailio/commit/d1a221af4cac226199365c18a6a1210… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T10:16:03+01:00 usrloc: docs for keepalive parameters --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/d1a221af4cac226199365c18a6a1210… Patch: https://github.com/kamailio/kamailio/commit/d1a221af4cac226199365c18a6a1210… --- diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index 902d0586c1..d4f96db94f 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -1267,6 +1267,126 @@ modparam("usrloc", "version_table", 0) </example> </section> + <section id="usrloc.p.ka_mode"> + <title><varname>ka_mode</varname> (int)</title> + <para> + Keepalive mode - control the internal keepalive mechanism. With this feature + enable, the module sends periodically (based on timer interval) SIP requests + to location contacts and measures the round trip in microseconds (the + round trip value can be seen in the response of the RPC command 'ul.dump'). + </para> + <para> + Its value is a set of flags: + </para> + <itemizedlist> + <listitem> + <para> + 0 - if the value is zero, no keepalive is sent + </para> + </listitem> + <listitem> + <para> + 1 - if set to 1, the keepalive is enabled for all contacts + </para> + </listitem> + <listitem> + <para> + 2 (bit 2 set) - the keepalive is sent only for natted contacts + (nat_bflag set) + </para> + </listitem> + <listitem> + <para> + 4 (bit 3 set) - the keepalive is sent only for UDP contacts + </para> + </listitem> + </itemizedlist> + <para> + For example, if set to 6, then keepalive is sent only natted UDP contacs. + </para> + <para> + Note: the internal keepalive of usrloc module conflicts in some way with + the keepalive done by nathelper module. It is recommended to enable only + one. + </para> + <para> + Note: the internal keepalive is for the moment implemented only for + contact records stored in memory. + </para> + <para> + Note: it is recommeder to set 'timer_procs' parameter in order to have + dedicated timer processes for usrloc module and off-load the keepalive + sending process from the core timers. + </para> + <para> + Default value is <quote>0 (keepalive disabled)</quote>. + </para> + <example> + <title><varname>ka_mode</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_mode", 1) +... + </programlisting> + </example> + </section> + + <section id="usrloc.p.ka_method"> + <title><varname>ka_method</varname> (str)</title> + <para> + The SIP method type for keepalive requests. + </para> + <para> + Default value is <quote>OPTIONS</quote>. + </para> + <example> + <title><varname>ka_method</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_method", "NOTIFY") +... + </programlisting> + </example> + </section> + + <section id="usrloc.p.from"> + <title><varname>ka_from</varname> (str)</title> + <para> + The SIP URI to be set in the From header of the keepalive requests. + </para> + <para> + Default value is <quote>sip:server@kamailio.org</quote>. + </para> + <example> + <title><varname>ka_from</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_from", "sip:server@mydomain.com") +... + </programlisting> + </example> + </section> + + <section id="usrloc.p.domain"> + <title><varname>ka_domain</varname> (str)</title> + <para> + The domain to be set in To header URI if the multi-domain is not enabled. + If multi-domain is enabled, then the domain from the location record is + used and this parameter is ignored. + </para> + <para> + Default value is <quote>kamailio.org</quote>. + </para> + <example> + <title><varname>ka_domain</varname> parameter usage</title> + <programlisting format="linespecific"> +... +modparam("usrloc", "ka_domain", "mydomain.com") +... + </programlisting> + </example> + </section> + </section> <section>

1 0

git:master:4652a116: usrloc: print ka roundtrip via rpc dump command
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

Module: kamailio Branch: master Commit: 4652a116fb940fbda527e1b04a5a0a32f7b9a3fe URL: https://github.com/kamailio/kamailio/commit/4652a116fb940fbda527e1b04a5a0a3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T09:12:34+01:00 usrloc: print ka roundtrip via rpc dump command --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/ul_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/4652a116fb940fbda527e1b04a5a0a3… Patch: https://github.com/kamailio/kamailio/commit/4652a116fb940fbda527e1b04a5a0a3… --- diff --git a/src/modules/usrloc/dlist.c b/src/modules/usrloc/dlist.c index 11366cc0f7..ab88801e9e 100644 --- a/src/modules/usrloc/dlist.c +++ b/src/modules/usrloc/dlist.c @@ -524,9 +524,10 @@ int ul_update_keepalive(unsigned int _aorhash, str *_ruid, time_t tval, { /* found */ c->last_keepalive = tval; - LM_DBG("updated keepalive for [%.*s:%u] to %u\n", + c->ka_roundtrip = rtrip; + LM_DBG("updated keepalive for [%.*s:%u] to %u (rtrip: %u)\n", _ruid->len, _ruid->s, _aorhash, - (unsigned int)c->last_keepalive); + (unsigned int)c->last_keepalive, c->ka_roundtrip); unlock_ulslot(p->d, i); return 0; } diff --git a/src/modules/usrloc/ul_rpc.c b/src/modules/usrloc/ul_rpc.c index 6c00c87c63..32417d06e5 100644 --- a/src/modules/usrloc/ul_rpc.c +++ b/src/modules/usrloc/ul_rpc.c @@ -200,6 +200,11 @@ int rpc_dump_contact(rpc_t* rpc, void* ctx, void *ih, ucontact_t* c) rpc->fault(ctx, 500, "Internal error adding last_keepalive"); return -1; } + if(rpc->struct_add(vh, "d", "KA-Roundtrip", (int)c->ka_roundtrip)<0) + { + rpc->fault(ctx, 500, "Internal error adding keepalive roundtrip"); + return -1; + } if(rpc->struct_add(vh, "d", "Last-Modified", (int)c->last_modified)<0) { rpc->fault(ctx, 500, "Internal error adding last_modified");

1 0

git:5.3:d91b5440: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 27 Mar '20

27 Mar '20

Module: kamailio Branch: 5.3 Commit: d91b5440947884ac00889bfc985d35564699dc8f URL: https://github.com/kamailio/kamailio/commit/d91b5440947884ac00889bfc985d355… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-27T08:46:30+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/corex/README Modified: src/modules/pike/README Modified: src/modules/sst/README --- Diff: https://github.com/kamailio/kamailio/commit/d91b5440947884ac00889bfc985d355… Patch: https://github.com/kamailio/kamailio/commit/d91b5440947884ac00889bfc985d355… --- diff --git a/src/modules/corex/README b/src/modules/corex/README index a67289bdb5..e9f8045f3a 100644 --- a/src/modules/corex/README +++ b/src/modules/corex/README @@ -10,8 +10,6 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> -Edited by - Muhammad Shahzad Shafi <shahzad(a)voip-demos.com> @@ -574,7 +572,15 @@ via_add_srv("1"); Example 1.23. via_add_xavp_params usage ... -via_add_xavp_params("1"); +xavp_via_params="xvia" +... +request_route { + ... + $xavp(xvia=>srvid) = "1"; + $xavp(xvia[0]=>myval) = "xyz"; + via_add_xavp_params("1"); + ... +} ... 4.20. via_use_xavp_fields(flags) @@ -589,7 +595,15 @@ via_add_xavp_params("1"); Example 1.24. via_use_xavp_fields usage ... -via_use_xavp_fields("1"); +xavp_via_fields="mvia" +... +request_route { + ... + $xavp(mvia=>address) = "10.10.10.10"; + $xavp(mvia[0]=>port) = "5060"; + via_use_xavp_fields("1"); + ... +} ... 5. RPC Commands diff --git a/src/modules/pike/README b/src/modules/pike/README index 34a26d7020..a7f66697e7 100644 --- a/src/modules/pike/README +++ b/src/modules/pike/README @@ -247,9 +247,9 @@ Chapter 3. Developer Guide Example 3.1. Tree of IP addresses / 193 - 175 - 132 - 164 -tree root / \ 142 +tree root / \ - 142 \ 195 - 37 - 78 - 163 - \ 79 - 134 + \ - 79 - 134 To detect the whole address, step by step, from the root to the leafs, the nodes corresponding to each byte of the ip address are expanded. In diff --git a/src/modules/sst/README b/src/modules/sst/README index 725cffc95d..3444863563 100644 --- a/src/modules/sst/README +++ b/src/modules/sst/README @@ -219,20 +219,36 @@ modparam("sst", "min_se", 2400) 4.3. timeout_avp (string) - This parameter MUST be set to the same value as the dialog module - parameter of the same name. If this parameter is NOT set, the sst - module will not do anything! + This parameter must be set to the same value as the dialog module + parameter of the same name, when it is wanted to update dialog timeout + using Session-Expires header value. If this parameter is not set, the + sst module will not update dialog timeout. - This is how the sst module knows which avp in the dialog module it has - to change with the new expire value. + With this parameter, the sst module knows which avp is expected by the + dialog module to change to a new expire value. - Default value is “NULL!” it is not set by default. + Note that the avp is set only for requests within dialog, not for the + initial INVITE. For this one, it can be done using script operations, + see the next example for such solution. + + Default value is “NULL” (not set by default). Example 1.4. Set timeout_avp parameter ... -modparam("dialog", "timeout_avp", "$avp(i:10)") +modparam("dialog", "timeout_avp", "$avp(dlgtimeout)") # Set the sst modules timeout_avp to be the same value -modparam("sst", "timeout_avp", "$avp(i:10)") +modparam("sst", "timeout_avp", "$avp(dlgtimeout)") +... +request_route { + ... + # when wanting to use Session-Expires value for initial INVITE + if(is_method("INVITE") and !has_totag()) { + if(is_present_hf("Session-Expires")) { + $avp(dlgtimeout) = $(hdr(Session-Expires){s.int}); + } + } + ... +} ... 4.4. reject_to_small (integer)

1 0

git: new commits in branch 5.3
by Daniel-Constantin Mierla 27 Mar '20

27 Mar '20

- URL: https://github.com/kamailio/kamailio/commit/382e55f8b1fa8c79b01a90438e674fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:21:52+01:00 dmq: init worker structure in chid_init for PROC_INIT rank - have it ready when other processes are started (cherry picked from commit 21bdbff049571ca22f1205a041c8b1162005d319) - URL: https://github.com/kamailio/kamailio/commit/18f17c944f0ab48d3e7af69deac1f58… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:22:02+01:00 dialog: detailed debug messages when resolving the timeout (cherry picked from commit 20013e4e2bf1a5d5ce8535e07320dca034639286) - URL: https://github.com/kamailio/kamailio/commit/5cdcb3a77879266303daa2be22b424e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:22:14+01:00 sst: debug message when setting timeout avp (cherry picked from commit 56ed5c028bd97837c7a9e0017a2599f09554211f) - URL: https://github.com/kamailio/kamailio/commit/01defdb59e7017d284d8519bcb0043c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:22:24+01:00 corex: docs - examples with setting xavps for via functions (cherry picked from commit 1e58a56cb7f9d83ca0c943481d02c429d33e188a) - URL: https://github.com/kamailio/kamailio/commit/975d09a68cbd15f4f042c1c97e0c4d1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:22:55+01:00 dialog: functions to search dialog by uuid and keep table entry locked - helper macros to lock/unlock table entry with dlg cell structure (cherry picked from commit a4f8c0291bfd32752c0c2c323f618c6ac0c91d53) - URL: https://github.com/kamailio/kamailio/commit/3b8d925ff74ed30f259fa9858d17ab7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:23:05+01:00 dialog: exposed functions to search dlg and lock table entry (cherry picked from commit 125031daeade9dab5c36b912dda65700d95c4c6a) - URL: https://github.com/kamailio/kamailio/commit/e59362c76599b29efa7722cebacb8ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:23:17+01:00 dialog: dmq operations under locked dlg table entry - protect against races that could be due to rentransmissions or other parallel processing cases - related to GH #2224 (cherry picked from commit 8965ff07f2e9fa105fc56896eed9caf4b6faf261) - URL: https://github.com/kamailio/kamailio/commit/f127bcec39888a8b34524e9f8ad336b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:23:28+01:00 rtpengine: replaced rtpproxy with rtpengine - avoid confusion in printed log messges (cherry picked from commit dda07c69420e1a38948dae4b71f8005b2375253b) - URL: https://github.com/kamailio/kamailio/commit/5fc4b6871a2c9f8cca841350d4bd0c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:24:24+01:00 lib/srdb1: schema - added xml file for sefilter module (cherry picked from commit 09c18bb06691ad29b71990179a3006b5bdfbf602) - URL: https://github.com/kamailio/kamailio/commit/f8b1f4f3b9447b2400c7cb241a83249… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:24:34+01:00 lib/srdb1: schema - use smallint for secfilter - tinyint is not supported (cherry picked from commit 7c8fdb0df37ee1466d7171ff3cff77e5b961abb4) - URL: https://github.com/kamailio/kamailio/commit/261af6718472a7d3d62cb269f135ea1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:24:43+01:00 kamctl: regenerated db schema file with secfilter updates (cherry picked from commit 63cd404d4b46e4514ae1490303189a0f81def942) - URL: https://github.com/kamailio/kamailio/commit/c3273ba4bc3bc8d1395823f019ad871… Author: Zero King <l2dy(a)icloud.com> Date: 2020-03-27T08:24:55+01:00 nathelper: fix zero-length log placeholder (cherry picked from commit 69714b26c63c75df6759f9158c7181d4f86b4764) - URL: https://github.com/kamailio/kamailio/commit/6ac87dbf749c3c53cc1dfd031185ffd… Author: Zero King <l2dy(a)icloud.com> Date: 2020-03-27T08:25:05+01:00 rtpproxy: fix zero-length log placeholder (cherry picked from commit 030f18b5cffeb117dcf582cf12c5b3c35ace1469) - URL: https://github.com/kamailio/kamailio/commit/6b5052823d9e123a0e34c53d258b94b… Author: Zero King <l2dy(a)icloud.com> Date: 2020-03-27T08:25:14+01:00 rtpengine: fix zero-length log placeholder (cherry picked from commit 740afac15b3d8d618b5101a761a37f5808d4b4f0) - URL: https://github.com/kamailio/kamailio/commit/98b651a5cd3c5c782462867a4492717… Author: Nathan Bruning <nathan(a)iperity.com> Date: 2020-03-27T08:25:27+01:00 core: fix returning multiple IPs for a cached DNS entry (cherry picked from commit 29a35ec3cec8b9c3ee4b45c8d84308701bda097c) - URL: https://github.com/kamailio/kamailio/commit/4b5d7ae9911d320a7c3335fb627791c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:25:38+01:00 sst: docs - more info about how timeout_avp is used (cherry picked from commit b800ffb9fb1de6ee0d7b6c2b42a25669022c1142) - URL: https://github.com/kamailio/kamailio/commit/6760931a9938fcd92e36a30821c5bc8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:25:51+01:00 pike: docs - aligned ip tree example (cherry picked from commit e65ce2fd407626acc89879033a2114cf521457dc) - URL: https://github.com/kamailio/kamailio/commit/082e7dfd9048c79e2d6b7cc6365bf4c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-27T08:26:37+01:00 core: receive_msg() - init local variables for better runtime troubleshooting (cherry picked from commit 1611766a329aa60a690803d7ff179159a4657a56)

1 0

[kamailio/kamailio] Request for new RPC htable.flush to DB (#2201)
by Sergiu Pojoga 27 Mar '20

27 Mar '20

### Description Ability to flush on-demand htable from memory to DB. ### Possible Solutions Implement a new RPC `htable.flush` command Flush hash table to database. Name: dhtable.flush Parameters: htable : Name of the hash table to flush Example: ... kamcmd htable.flush ... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2201

2 3

git:master:de849323: modules: readme files regenerated - lost ... [skip ci]
by Kamailio Dev 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: de8493232eb6aefa742e038cb3ca6282aadf1a6a URL: https://github.com/kamailio/kamailio/commit/de8493232eb6aefa742e038cb3ca628… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-26T22:46:08+01:00 modules: readme files regenerated - lost ... [skip ci] --- Modified: src/modules/lost/README --- Diff: https://github.com/kamailio/kamailio/commit/de8493232eb6aefa742e038cb3ca628… Patch: https://github.com/kamailio/kamailio/commit/de8493232eb6aefa742e038cb3ca628… --- diff --git a/src/modules/lost/README b/src/modules/lost/README index 036451cd21..be5e43711c 100644 --- a/src/modules/lost/README +++ b/src/modules/lost/README @@ -198,7 +198,8 @@ Chapter 1. Admin Guide * pidf-lo - the PIDF-LO returned in the HELD locationRequest response * url - the location reference returned in the HELD locationRequest response - this reference may be added as Geolocation header value - and forwarded downstream + and forwarded downstream Note: to work properly, it is required to + include "locationURI" in the location_type parameter. * error - any error code returned in the HELD locationRequest response

1 0

git:master:340bb1ef: lost: fixed defects reported from Coverity Scan
by Wolfgang Kampichler 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: 340bb1efbf5fc9ba9e1ef2ec8d3074c40be5d0ca URL: https://github.com/kamailio/kamailio/commit/340bb1efbf5fc9ba9e1ef2ec8d3074c… Author: Wolfgang Kampichler <dev(a)kampichler.info> Committer: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2020-03-26T22:36:05+01:00 lost: fixed defects reported from Coverity Scan - in lost_function(): illegal access - in lost_held_type(): null pointer dereferences - in lost_xpath_location(): resource leak, control flow, null pointer dereferences - besides: README update and code refactoring. --- Modified: src/modules/lost/doc/lost_admin.xml Modified: src/modules/lost/functions.c Modified: src/modules/lost/utilities.c Modified: src/modules/lost/utilities.h --- Diff: https://github.com/kamailio/kamailio/commit/340bb1efbf5fc9ba9e1ef2ec8d3074c… Patch: https://github.com/kamailio/kamailio/commit/340bb1efbf5fc9ba9e1ef2ec8d3074c…

1 0

git:master:68928e95: usrloc: store keepalive roundtrip in contact structure
by Daniel-Constantin Mierla 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: 68928e95f50581170097373dafe7a441e7f88304 URL: https://github.com/kamailio/kamailio/commit/68928e95f50581170097373dafe7a44… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-26T21:57:08+01:00 usrloc: store keepalive roundtrip in contact structure --- Modified: src/modules/usrloc/dlist.c Modified: src/modules/usrloc/ul_keepalive.c Modified: src/modules/usrloc/usrloc.h --- Diff: https://github.com/kamailio/kamailio/commit/68928e95f50581170097373dafe7a44… Patch: https://github.com/kamailio/kamailio/commit/68928e95f50581170097373dafe7a44… --- diff --git a/src/modules/usrloc/dlist.c b/src/modules/usrloc/dlist.c index a4c838e1f6..11366cc0f7 100644 --- a/src/modules/usrloc/dlist.c +++ b/src/modules/usrloc/dlist.c @@ -489,11 +489,11 @@ int get_all_ucontacts(void *buf, int len, unsigned int flags, } - /** * */ -int ul_refresh_keepalive(unsigned int _aorhash, str *_ruid) +int ul_update_keepalive(unsigned int _aorhash, str *_ruid, time_t tval, + unsigned int rtrip) { dlist_t *p; urecord_t *r; @@ -523,7 +523,7 @@ int ul_refresh_keepalive(unsigned int _aorhash, str *_ruid) && !memcmp(c->ruid.s, _ruid->s, _ruid->len)) { /* found */ - c->last_keepalive = time(NULL); + c->last_keepalive = tval; LM_DBG("updated keepalive for [%.*s:%u] to %u\n", _ruid->len, _ruid->s, _aorhash, (unsigned int)c->last_keepalive); @@ -539,6 +539,14 @@ int ul_refresh_keepalive(unsigned int _aorhash, str *_ruid) return 0; } +/** + * + */ +int ul_refresh_keepalive(unsigned int _aorhash, str *_ruid) +{ + return ul_update_keepalive(_aorhash, _ruid, time(NULL), 0); +} + /*! * \brief Create a new domain structure * \return 0 if everything went OK, otherwise value < 0 is returned diff --git a/src/modules/usrloc/ul_keepalive.c b/src/modules/usrloc/ul_keepalive.c index 83bce13c77..b40a93040a 100644 --- a/src/modules/usrloc/ul_keepalive.c +++ b/src/modules/usrloc/ul_keepalive.c @@ -410,7 +410,7 @@ int ul_ka_reply_received(sip_msg_t *msg) LM_DBG("reply for keepalive of [%.*s:%u] roundtrip: %u.%06usec\n", ruid.len, ruid.s, aorhash, tvdiff/1000000, tvdiff%1000000); - ul_refresh_keepalive(aorhash, &ruid); + ul_update_keepalive(aorhash, &ruid, tvn.tv_sec, tvdiff); return 0; } diff --git a/src/modules/usrloc/usrloc.h b/src/modules/usrloc/usrloc.h index a1e26da211..5d071c1734 100644 --- a/src/modules/usrloc/usrloc.h +++ b/src/modules/usrloc/usrloc.h @@ -88,7 +88,8 @@ typedef struct ucontact { str uniq; /*!< Uniq header field */ struct socket_info *sock; /*!< received socket */ time_t last_modified; /*!< When the record was last modified */ - time_t last_keepalive; /*!< last keepalive timestamp */ + time_t last_keepalive; /*!< Last keepalive timestamp */ + unsigned int ka_roundtrip; /*!< Keepalive roundtrip in microseconds */ unsigned int methods; /*!< Supported methods */ str instance; /*!< SIP instance value - gruu */ unsigned int reg_id; /*!< reg-id parameters */ @@ -192,6 +193,8 @@ int ul_set_keepalive_timeout(int _to); typedef int (*ul_refresh_keepalive_t)(unsigned int _aorhash, str *_ruid); int ul_refresh_keepalive(unsigned int _aorhash, str *_ruid); +int ul_update_keepalive(unsigned int _aorhash, str *_ruid, time_t tval, + unsigned int rtrip); typedef void (*ul_set_max_partition_t)(unsigned int m);

1 0

git:master:87c5d45a: usrloc: process keepalive response
by Daniel-Constantin Mierla 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: 87c5d45a66d2d1ecfca4d2677be4d3ff633dc218 URL: https://github.com/kamailio/kamailio/commit/87c5d45a66d2d1ecfca4d2677be4d3f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-26T21:02:09+01:00 usrloc: process keepalive response --- Modified: src/modules/usrloc/ul_keepalive.c Modified: src/modules/usrloc/ul_keepalive.h Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/87c5d45a66d2d1ecfca4d2677be4d3f… Patch: https://github.com/kamailio/kamailio/commit/87c5d45a66d2d1ecfca4d2677be4d3f…

1 0

git:master:b3677f75: usrloc: ability to send keep alive requests
by Daniel-Constantin Mierla 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: b3677f7508cfdcea54f48ed01688fa0cf9380e58 URL: https://github.com/kamailio/kamailio/commit/b3677f7508cfdcea54f48ed01688fa0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-26T16:18:17+01:00 usrloc: ability to send keep alive requests - GH #2223 - work in progress --- Added: src/modules/usrloc/ul_keepalive.c Added: src/modules/usrloc/ul_keepalive.h Modified: src/modules/usrloc/udomain.c Modified: src/modules/usrloc/usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b3677f7508cfdcea54f48ed01688fa0… Patch: https://github.com/kamailio/kamailio/commit/b3677f7508cfdcea54f48ed01688fa0…

1 0

git:master:1611766a: core: receive_msg() - init local variables for better runtime troubleshooting
by Daniel-Constantin Mierla 26 Mar '20

26 Mar '20

Module: kamailio Branch: master Commit: 1611766a329aa60a690803d7ff179159a4657a56 URL: https://github.com/kamailio/kamailio/commit/1611766a329aa60a690803d7ff17915… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-26T11:28:51+01:00 core: receive_msg() - init local variables for better runtime troubleshooting --- Modified: src/core/receive.c --- Diff: https://github.com/kamailio/kamailio/commit/1611766a329aa60a690803d7ff17915… Patch: https://github.com/kamailio/kamailio/commit/1611766a329aa60a690803d7ff17915… --- diff --git a/src/core/receive.c b/src/core/receive.c index b780440030..428214df68 100644 --- a/src/core/receive.c +++ b/src/core/receive.c @@ -223,15 +223,15 @@ int ksr_evrt_received(char *buf, unsigned int len, receive_info_t *rcv_info) */ int receive_msg(char *buf, unsigned int len, receive_info_t *rcv_info) { - struct sip_msg *msg; + struct sip_msg *msg = NULL; struct run_act_ctx ctx; - struct run_act_ctx *bctx; - int ret; + struct run_act_ctx *bctx = NULL; + int ret = -1; struct timeval tvb, tve; struct timezone tz; unsigned int diff = 0; - str inb; - sr_net_info_t netinfo; + str inb = STR_NULL; + sr_net_info_t netinfo = {0}; sr_kemi_eng_t *keng = NULL; sr_event_param_t evp = {0}; unsigned int cidlockidx = 0;

1 0

git:master:1d01ae5e: modules: readme files regenerated - htable ... [skip ci]
by Kamailio Dev 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: 1d01ae5e7934cc84bb40ae4d18e6a48f6a78e5e2 URL: https://github.com/kamailio/kamailio/commit/1d01ae5e7934cc84bb40ae4d18e6a48… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-25T19:46:12+01:00 modules: readme files regenerated - htable ... [skip ci] --- Modified: src/modules/htable/README --- Diff: https://github.com/kamailio/kamailio/commit/1d01ae5e7934cc84bb40ae4d18e6a48… Patch: https://github.com/kamailio/kamailio/commit/1d01ae5e7934cc84bb40ae4d18e6a48… --- diff --git a/src/modules/htable/README b/src/modules/htable/README index 78b7547085..4aa4c258a9 100644 --- a/src/modules/htable/README +++ b/src/modules/htable/README @@ -80,9 +80,10 @@ Ovidiu Sas 6.4. htable.seti htable key value 6.5. htable.dump htable 6.6. htable.reload htable - 6.7. htable.flush htable - 6.8. htable.listTables - 6.9. htable.stats + 6.7. htable.store htable + 6.8. htable.flush htable + 6.9. htable.listTables + 6.10. htable.stats 7. Event routes @@ -183,9 +184,10 @@ Chapter 1. Admin Guide 6.4. htable.seti htable key value 6.5. htable.dump htable 6.6. htable.reload htable - 6.7. htable.flush htable - 6.8. htable.listTables - 6.9. htable.stats + 6.7. htable.store htable + 6.8. htable.flush htable + 6.9. htable.listTables + 6.10. htable.stats 7. Event routes @@ -977,9 +979,10 @@ if(sht_match_str_value("ha", "eq", "alice")) { 6.4. htable.seti htable key value 6.5. htable.dump htable 6.6. htable.reload htable - 6.7. htable.flush htable - 6.8. htable.listTables - 6.9. htable.stats + 6.7. htable.store htable + 6.8. htable.flush htable + 6.9. htable.listTables + 6.10. htable.stats 6.1. htable.get htable key @@ -1063,7 +1066,7 @@ kamcmd htable.sets test x[0] 123 Lists all the values in a hash table - Name: dhtable.dump + Name: htable.dump Parameters: * htable : Name of the hash table to dump @@ -1077,7 +1080,7 @@ kamcmd htable.dump ipban Reload hash table from database. - Name: dhtable.reload + Name: htable.reload Parameters: * htable : Name of the hash table to reload @@ -1087,7 +1090,21 @@ kamcmd htable.dump ipban kamcmd htable.reload ipban ... -6.7. htable.flush htable +6.7. htable.store htable + + Store hash table to database. + + Name: htable.store + + Parameters: + * htable : Name of the hash table to store + + Example: +... +kamcmd htable.store ipban +... + +6.8. htable.flush htable Empty the hash table @@ -1101,7 +1118,7 @@ kamcmd htable.reload ipban kamcmd htable.flush ipban ... -6.8. htable.listTables +6.9. htable.listTables Lists all defined tables @@ -1115,7 +1132,7 @@ kamcmd htable.flush ipban kamcmd htable.listTables ... -6.9. htable.stats +6.10. htable.stats Get statistics for hash tables - name, number of slots, number of items, max number of items per slot, min number of items per slot.

1 0

git:master:01933ac0: htable: docs for rpc command htable.store
by Daniel-Constantin Mierla 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: 01933ac03f3db92f1c5f493a16ed3e4e75565e62 URL: https://github.com/kamailio/kamailio/commit/01933ac03f3db92f1c5f493a16ed3e4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-25T19:36:37+01:00 htable: docs for rpc command htable.store --- Modified: src/modules/htable/doc/htable_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/01933ac03f3db92f1c5f493a16ed3e4… Patch: https://github.com/kamailio/kamailio/commit/01933ac03f3db92f1c5f493a16ed3e4…

1 0

git:master:17ed8ddf: htable: new rpc command htable.store
by Daniel-Constantin Mierla 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: 17ed8ddf20338e0728cf4e8c496f726650577898 URL: https://github.com/kamailio/kamailio/commit/17ed8ddf20338e0728cf4e8c496f726… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-25T19:31:49+01:00 htable: new rpc command htable.store - save the content of hash table to database --- Modified: src/modules/htable/htable.c --- Diff: https://github.com/kamailio/kamailio/commit/17ed8ddf20338e0728cf4e8c496f726… Patch: https://github.com/kamailio/kamailio/commit/17ed8ddf20338e0728cf4e8c496f726… --- diff --git a/src/modules/htable/htable.c b/src/modules/htable/htable.c index 144a65beaa..a1a8e04c48 100644 --- a/src/modules/htable/htable.c +++ b/src/modules/htable/htable.c @@ -1285,9 +1285,14 @@ static const char* htable_flush_doc[2] = { 0 }; static const char* htable_reload_doc[2] = { - "Reload hash table.", + "Reload hash table from database.", 0 }; +static const char* htable_store_doc[2] = { + "Store hash table to database.", + 0 +}; + static void htable_rpc_delete(rpc_t* rpc, void* c) { str htname, keyname; @@ -1754,6 +1759,56 @@ static void htable_rpc_reload(rpc_t* rpc, void* c) return; } +/*! \brief RPC htable.store command to store content of a hash table to db */ +static void htable_rpc_store(rpc_t* rpc, void* c) +{ + str htname; + ht_t *ht; + + if(ht_db_url.len<=0) { + rpc->fault(c, 500, "No htable db_url"); + return; + } + if(ht_db_init_con()!=0) { + rpc->fault(c, 500, "Failed to init htable db connection"); + return; + } + if(ht_db_open_con()!=0) { + rpc->fault(c, 500, "Failed to open htable db connection"); + return; + } + + if (rpc->scan(c, "S", &htname) < 1) { + ht_db_close_con(); + rpc->fault(c, 500, "No htable name given"); + return; + } + ht = ht_get_table(&htname); + if(ht==NULL) { + ht_db_close_con(); + rpc->fault(c, 500, "No such htable"); + return; + } + if(ht->dbtable.s==NULL || ht->dbtable.len<=0) { + ht_db_close_con(); + rpc->fault(c, 500, "No database htable"); + return; + } + LM_DBG("sync db table [%.*s] from ht [%.*s]\n", + ht->dbtable.len, ht->dbtable.s, + ht->name.len, ht->name.s); + ht_db_delete_records(&ht->dbtable); + if(ht_db_save_table(ht, &ht->dbtable)!=0) { + LM_ERR("failed syncing hash table [%.*s] to db\n", + ht->name.len, ht->name.s); + ht_db_close_con(); + rpc->fault(c, 500, "Storing htable failed"); + return; + } + ht_db_close_con(); + return; +} + rpc_export_t htable_rpc[] = { {"htable.dump", htable_rpc_dump, htable_dump_doc, RET_ARRAY}, {"htable.delete", htable_rpc_delete, htable_delete_doc, 0}, @@ -1762,6 +1817,7 @@ rpc_export_t htable_rpc[] = { {"htable.seti", htable_rpc_seti, htable_seti_doc, 0}, {"htable.listTables", htable_rpc_list, htable_list_doc, RET_ARRAY}, {"htable.reload", htable_rpc_reload, htable_reload_doc, 0}, + {"htable.store", htable_rpc_store, htable_store_doc, 0}, {"htable.stats", htable_rpc_stats, htable_stats_doc, RET_ARRAY}, {"htable.flush", htable_rpc_flush, htable_flush_doc, 0}, {0, 0, 0, 0}

1 0

git:master:06d545bb: Makefile.defs: version set to 5.4.0-dev4
by Daniel-Constantin Mierla 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: 06d545bb3e3e0921cdd70dbdd7fd290b74824b55 URL: https://github.com/kamailio/kamailio/commit/06d545bb3e3e0921cdd70dbdd7fd290… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-25T17:34:07+01:00 Makefile.defs: version set to 5.4.0-dev4 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/06d545bb3e3e0921cdd70dbdd7fd290… Patch: https://github.com/kamailio/kamailio/commit/06d545bb3e3e0921cdd70dbdd7fd290… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index f6f39e3a01..9b36b0b56e 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 4 SUBLEVEL = 0 -EXTRAVERSION = -dev3 +EXTRAVERSION = -dev4 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:daf74e8a: sipdump: test initialization of faked msg structure
by Daniel-Constantin Mierla 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: daf74e8a7356014a0227352d8f7be44d4c4fd9d0 URL: https://github.com/kamailio/kamailio/commit/daf74e8a7356014a0227352d8f7be44… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-25T17:17:00+01:00 sipdump: test initialization of faked msg structure --- Modified: src/modules/sipdump/sipdump_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/daf74e8a7356014a0227352d8f7be44… Patch: https://github.com/kamailio/kamailio/commit/daf74e8a7356014a0227352d8f7be44… --- diff --git a/src/modules/sipdump/sipdump_mod.c b/src/modules/sipdump/sipdump_mod.c index d686dc897e..ad867ff0ce 100644 --- a/src/modules/sipdump/sipdump_mod.c +++ b/src/modules/sipdump/sipdump_mod.c @@ -137,7 +137,10 @@ static int mod_init(void) if (sipdump_event_route_idx>=0 && event_rt.rlist[sipdump_event_route_idx]==0) { sipdump_event_route_idx = -1; /* disable */ } - faked_msg_init(); + if(faked_msg_init() <0) { + LM_ERR("cannot initialize faked msg structure\n"); + return -1; + } } if(sipdump_mode & SIPDUMP_MODE_WFILE) {

1 0

git:master:d8acd8b9: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: d8acd8b9329955c21093df9507ebd8edd916eac9 URL: https://github.com/kamailio/kamailio/commit/d8acd8b9329955c21093df9507ebd8e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-25T15:01:15+01:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/d8acd8b9329955c21093df9507ebd8e… Patch: https://github.com/kamailio/kamailio/commit/d8acd8b9329955c21093df9507ebd8e… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index d6ae750551..638760ee09 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -2097,6 +2097,18 @@ rtpengine_offer(); here will still be accepted and used for transcoding on the offering side.Useful only in combination with codec-transcode. all keyword can be used to mask all offered codecs + + T.38=decode - If the offered SDP contains a media section + advertising T.38 over UDPTL, translate it to a regular audio + media section over RTP. By default, PCMU and PCMA will be used + as audio codecs, but that can be overriden using the codec + options described above. Other transport protocols (e.g. SRTP) + can also be selected in the same way. If the offered SDP does + not contain a T.38 section, then this flag has no effect. + + T.38=force - Any audio media section (over RTP) in the offered + SDP will be translated into a T.38 section over UDPTL. + + T.38=stop - Stops a previously established T.38 to audio + gateway and reverts the session back to media passthrough. + This is useful when handling a rejected T.38 offer. Check also the documentation of RTPEngine, these flags are documented there as well: https://github.com/sipwise/rtpengine.

1 0

git:master:de5b28f8: rtpengine: document new T.38 options
by Richard Fuchs 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: de5b28f89aadfbbf70f023bce7a6fcdd55bfd044 URL: https://github.com/kamailio/kamailio/commit/de5b28f89aadfbbf70f023bce7a6fcd… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2020-03-25T09:56:56-04:00 rtpengine: document new T.38 options --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/de5b28f89aadfbbf70f023bce7a6fcd… Patch: https://github.com/kamailio/kamailio/commit/de5b28f89aadfbbf70f023bce7a6fcd… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index fafff2e4c5..d9230209f6 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -2404,6 +2404,23 @@ rtpengine_offer(); and used for transcoding on the offering side.Useful only in combination with codec-transcode. <emphasis>all</emphasis> keyword can be used to mask all offered codecs </para></listitem> + <listitem><para> + <emphasis>T.38=decode</emphasis> - If the offered &sdp; contains a media section + advertising T.38 over UDPTL, translate it to a regular audio media section + over RTP. By default, PCMU and PCMA will be used as audio codecs, but that can + be overriden using the codec options described above. Other transport protocols + (e.g. SRTP) can also be selected in the same way. If the offered &sdp; does not + contain a T.38 section, then this flag has no effect. + </para></listitem> + <listitem><para> + <emphasis>T.38=force</emphasis> - Any audio media section (over RTP) in the + offered &sdp; will be translated into a T.38 section over UDPTL. + </para></listitem> + <listitem><para> + <emphasis>T.38=stop</emphasis> - Stops a previously established T.38 to audio + gateway and reverts the session back to media passthrough. This is useful when + handling a rejected T.38 offer. + </para></listitem> </itemizedlist> <para> Check also the documentation of RTPEngine, these flags are documented there as well:

1 0

git:master:6ab14314: rtpengine: add support for new T.38 options
by Richard Fuchs 25 Mar '20

25 Mar '20

Module: kamailio Branch: master Commit: 6ab1431464f97e856812e0f69d77bc96e3dd8f57 URL: https://github.com/kamailio/kamailio/commit/6ab1431464f97e856812e0f69d77bc9… Author: Richard Fuchs <rfuchs(a)sipwise.com> Committer: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2020-03-25T09:00:40-04:00 rtpengine: add support for new T.38 options --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/6ab1431464f97e856812e0f69d77bc9… Patch: https://github.com/kamailio/kamailio/commit/6ab1431464f97e856812e0f69d77bc9… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 6d821aee7a..7be7968660 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -118,6 +118,7 @@ enum { struct ng_flags_parse { int via, to, packetize, transport, directional; bencode_item_t *dict, *flags, *direction, *replace, *rtcp_mux, *sdes, + *t38, *codec, *codec_strip, *codec_offer, *codec_transcode, *codec_mask; str call_id, from_tag, to_tag; }; @@ -2125,6 +2126,10 @@ static int parse_flags(struct ng_flags_parse *ng_flags, struct sip_msg *msg, enu bencode_list_add_str(ng_flags->sdes, &s); goto next; } + if (str_key_val_prefix(&key, "T38", &val, &s) || str_key_val_prefix(&key, "T.38", &val, &s)) { + bencode_list_add_str(ng_flags->t38, &s); + goto next; + } if (str_key_val_prefix(&key, "rtcp-mux", &val, &s)) { bencode_list_add_str(ng_flags->rtcp_mux, &s); goto next; @@ -2402,6 +2407,7 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf, struct sip_ ng_flags.replace = bencode_list(bencbuf); ng_flags.rtcp_mux = bencode_list(bencbuf); ng_flags.sdes = bencode_list(bencbuf); + ng_flags.t38 = bencode_list(bencbuf); ng_flags.codec = bencode_dictionary(bencbuf); if (read_sdp_pvar!= NULL) { @@ -2455,6 +2461,8 @@ static bencode_item_t *rtpp_function_call(bencode_buffer_t *bencbuf, struct sip_ bencode_dictionary_add(ng_flags.dict, "rtcp-mux", ng_flags.rtcp_mux); if (ng_flags.sdes && ng_flags.sdes->child) bencode_dictionary_add(ng_flags.dict, "SDES", ng_flags.sdes); + if (ng_flags.t38 && ng_flags.t38->child) + bencode_dictionary_add(ng_flags.dict, "T.38", ng_flags.t38); bencode_dictionary_add_str(ng_flags.dict, "call-id", &ng_flags.call_id);

1 0

Broken: kamailio/kamailio#8606 (5.2 - 09985a4)
by Travis CI 25 Mar '20

25 Mar '20

Build Update for kamailio/kamailio ------------------------------------- Build: #8606 Status: Broken Duration: 3 mins and 56 secs Commit: 09985a4 (5.2) Author: Henning Westerholt Message: uac: also set socket for in dialog REGISTER (GH #2262) (cherry picked from commit a752411df65b93f82aaad43a767cff102f5a6100) View the changeset: https://github.com/kamailio/kamailio/compare/3858b3057c8a...09985a448ffd View the full build log and details: https://travis-ci.org/github/kamailio/kamailio/builds/666801142?utm_medium=… -- You can unsubscribe from build emails from the kamailio/kamailio repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3596148&ut…. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notificati…. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.

1 0

git:5.3:7404e276: uac: also set socket for in dialog REGISTER (GH #2262)
by Henning Westerholt 25 Mar '20

25 Mar '20

Module: kamailio Branch: 5.3 Commit: 7404e276680cebc925002ff3bb714127ea20b265 URL: https://github.com/kamailio/kamailio/commit/7404e276680cebc925002ff3bb71412… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-25T14:57:02+01:00 uac: also set socket for in dialog REGISTER (GH #2262) (cherry picked from commit a752411df65b93f82aaad43a767cff102f5a6100) --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/7404e276680cebc925002ff3bb71412… Patch: https://github.com/kamailio/kamailio/commit/7404e276680cebc925002ff3bb71412… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index fb45a4fd3d..2ce37258e1 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -1131,6 +1131,19 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) /* Callback parameter */ uac_r.cbp = (void*)uuid; + if(reg->socket.s != NULL && reg->socket.len > 0) { + /* custom socket */ + LM_DBG("using custom socket %.*s to send request\n", + reg->socket.len, reg->socket.s); + uac_r.ssock = &reg->socket; + } else { + /* default socket */ + if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { + LM_DBG("using configured default_socket to send request\n"); + uac_r.ssock = &uac_default_socket; + } + } + if (reg_keep_callid && reg->flags & UAC_REG_ONLINE && reg->cseq > 0 && reg->cseq < 2147483638 && reg->callid.len > 0) @@ -1150,19 +1163,6 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) ret = uac_tmb.t_request_within(&uac_r); } else { - /* custom socket */ - if(reg->socket.s != NULL && reg->socket.len > 0) { - LM_DBG("using custom socket %.*s to send request\n", - reg->socket.len, reg->socket.s); - uac_r.ssock = &reg->socket; - } - /* default socket */ - else { - if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { - LM_DBG("using configured default_socket to send request\n"); - uac_r.ssock = &uac_default_socket; - } - } ret = uac_tmb.t_request(&uac_r, /* UAC Req */ &s_ruri, /* Request-URI */ &s_turi, /* To */

1 0

git:5.2:0506dee4: Revert "uac: also set socket for in dialog REGISTER (GH #2262)"
by Henning Westerholt 25 Mar '20

25 Mar '20

Module: kamailio Branch: 5.2 Commit: 0506dee4af74b5e1190ca1e28b1f4cc4a4f3e334 URL: https://github.com/kamailio/kamailio/commit/0506dee4af74b5e1190ca1e28b1f4cc… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-25T14:56:32+01:00 Revert "uac: also set socket for in dialog REGISTER (GH #2262)" This reverts commit 09985a448ffd34375be0d93f4b16f17c7dac3dc0. --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/0506dee4af74b5e1190ca1e28b1f4cc… Patch: https://github.com/kamailio/kamailio/commit/0506dee4af74b5e1190ca1e28b1f4cc… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index b944ebf4f9..f75c7cf38a 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -1150,19 +1150,6 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) /* Callback parameter */ uac_r.cbp = (void*)uuid; - if(reg->socket.s != NULL && reg->socket.len > 0) { - /* custom socket */ - LM_DBG("using custom socket %.*s to send request\n", - reg->socket.len, reg->socket.s); - uac_r.ssock = &reg->socket; - } else { - /* default socket */ - if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { - LM_DBG("using configured default_socket to send request\n"); - uac_r.ssock = &uac_default_socket; - } - } - if (reg_keep_callid && reg->flags & UAC_REG_ONLINE && reg->cseq > 0 && reg->cseq < 2147483638 && reg->callid.len > 0)

1 0

git:5.2:09985a44: uac: also set socket for in dialog REGISTER (GH #2262)
by Henning Westerholt 25 Mar '20

25 Mar '20

Module: kamailio Branch: 5.2 Commit: 09985a448ffd34375be0d93f4b16f17c7dac3dc0 URL: https://github.com/kamailio/kamailio/commit/09985a448ffd34375be0d93f4b16f17… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-25T14:54:53+01:00 uac: also set socket for in dialog REGISTER (GH #2262) (cherry picked from commit a752411df65b93f82aaad43a767cff102f5a6100) --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/09985a448ffd34375be0d93f4b16f17… Patch: https://github.com/kamailio/kamailio/commit/09985a448ffd34375be0d93f4b16f17… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index f75c7cf38a..b944ebf4f9 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -1150,6 +1150,19 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) /* Callback parameter */ uac_r.cbp = (void*)uuid; + if(reg->socket.s != NULL && reg->socket.len > 0) { + /* custom socket */ + LM_DBG("using custom socket %.*s to send request\n", + reg->socket.len, reg->socket.s); + uac_r.ssock = &reg->socket; + } else { + /* default socket */ + if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { + LM_DBG("using configured default_socket to send request\n"); + uac_r.ssock = &uac_default_socket; + } + } + if (reg_keep_callid && reg->flags & UAC_REG_ONLINE && reg->cseq > 0 && reg->cseq < 2147483638 && reg->callid.len > 0)

1 0

git:master:4b2e79d9: modules: readme files regenerated - textopsx ... [skip ci]
by Kamailio Dev 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 4b2e79d932840c6810038e0e386354bc3cc90e6c URL: https://github.com/kamailio/kamailio/commit/4b2e79d932840c6810038e0e386354b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-24T22:46:07+01:00 modules: readme files regenerated - textopsx ... [skip ci] --- Modified: src/modules/textopsx/README --- Diff: https://github.com/kamailio/kamailio/commit/4b2e79d932840c6810038e0e386354b… Patch: https://github.com/kamailio/kamailio/commit/4b2e79d932840c6810038e0e386354b… --- diff --git a/src/modules/textopsx/README b/src/modules/textopsx/README index fdd95cd8e9..8b87eb20d3 100644 --- a/src/modules/textopsx/README +++ b/src/modules/textopsx/README @@ -238,8 +238,8 @@ ot exists add new header Insert new header value before an existing header, if no index acquired insert before first hf header. Note that a header may consist of comma - delimited list of values. To insert value behind last value use - appenf_hf_value. + delimited list of values. To insert a value behind the last value use + append_hf_value. Meaning of the parameters is as follows: * hf - Header field to be appended. Format: HFNAME [ [IDX] ]. If

1 0

git:master:a752411d: uac: also set socket for in dialog REGISTER (GH #2262)
by Henning Westerholt 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: a752411df65b93f82aaad43a767cff102f5a6100 URL: https://github.com/kamailio/kamailio/commit/a752411df65b93f82aaad43a767cff1… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-24T22:43:42+01:00 uac: also set socket for in dialog REGISTER (GH #2262) --- Modified: src/modules/uac/uac_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/a752411df65b93f82aaad43a767cff1… Patch: https://github.com/kamailio/kamailio/commit/a752411df65b93f82aaad43a767cff1… --- diff --git a/src/modules/uac/uac_reg.c b/src/modules/uac/uac_reg.c index f35fedf384..c0cd5179b8 100644 --- a/src/modules/uac/uac_reg.c +++ b/src/modules/uac/uac_reg.c @@ -1131,6 +1131,19 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) /* Callback parameter */ uac_r.cbp = (void*)uuid; + if(reg->socket.s != NULL && reg->socket.len > 0) { + /* custom socket */ + LM_DBG("using custom socket %.*s to send request\n", + reg->socket.len, reg->socket.s); + uac_r.ssock = &reg->socket; + } else { + /* default socket */ + if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { + LM_DBG("using configured default_socket to send request\n"); + uac_r.ssock = &uac_default_socket; + } + } + if (reg_keep_callid && reg->flags & UAC_REG_ONLINE && reg->cseq > 0 && reg->cseq < 2147483638 && reg->callid.len > 0) @@ -1150,19 +1163,6 @@ int uac_reg_update(reg_uac_t *reg, time_t tn) ret = uac_tmb.t_request_within(&uac_r); } else { - /* custom socket */ - if(reg->socket.s != NULL && reg->socket.len > 0) { - LM_DBG("using custom socket %.*s to send request\n", - reg->socket.len, reg->socket.s); - uac_r.ssock = &reg->socket; - } - /* default socket */ - else { - if(uac_default_socket.s != NULL && uac_default_socket.len > 0) { - LM_DBG("using configured default_socket to send request\n"); - uac_r.ssock = &uac_default_socket; - } - } ret = uac_tmb.t_request(&uac_r, /* UAC Req */ &s_ruri, /* Request-URI */ &s_turi, /* To */

1 0

git:master:53ccb420: textopsx: small spelling fix in docs
by Henning Westerholt 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 53ccb420c0414a12af0783add864bb4d97a65d90 URL: https://github.com/kamailio/kamailio/commit/53ccb420c0414a12af0783add864bb4… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-24T22:43:42+01:00 textopsx: small spelling fix in docs --- Modified: src/modules/textopsx/doc/functions.xml --- Diff: https://github.com/kamailio/kamailio/commit/53ccb420c0414a12af0783add864bb4… Patch: https://github.com/kamailio/kamailio/commit/53ccb420c0414a12af0783add864bb4… --- diff --git a/src/modules/textopsx/doc/functions.xml b/src/modules/textopsx/doc/functions.xml index 768e291f73..717b8ddb40 100644 --- a/src/modules/textopsx/doc/functions.xml +++ b/src/modules/textopsx/doc/functions.xml @@ -200,7 +200,7 @@ append_hf_value("foo[-1]", "$var(Bar)") # try add value to the last header, if n <para> Insert new header value before an existing header, if no index acquired insert before first hf header. Note that a header may consist of comma delimited list of values. - To insert value behind last value use <function>appenf_hf_value</function>. + To insert a value behind the last value use <function>append_hf_value</function>. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist>

1 0

git:master:61e1fa2d: pike: renamed common name structs and globals to have module prefix
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 61e1fa2db0b6cdfaa4a5dc3791b646c38e3aaed2 URL: https://github.com/kamailio/kamailio/commit/61e1fa2db0b6cdfaa4a5dc3791b646c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T16:40:35+01:00 pike: renamed common name structs and globals to have module prefix --- Modified: src/modules/pike/ip_tree.c Modified: src/modules/pike/ip_tree.h Modified: src/modules/pike/pike.c Modified: src/modules/pike/pike_funcs.c Modified: src/modules/pike/pike_funcs.h Modified: src/modules/pike/pike_rpc.c Modified: src/modules/pike/pike_rpc.h Modified: src/modules/pike/pike_top.c Modified: src/modules/pike/pike_top.h Modified: src/modules/pike/timer.c Modified: src/modules/pike/timer.h --- Diff: https://github.com/kamailio/kamailio/commit/61e1fa2db0b6cdfaa4a5dc3791b646c… Patch: https://github.com/kamailio/kamailio/commit/61e1fa2db0b6cdfaa4a5dc3791b646c…

1 0

git:master:55e721ee: modules: readme files regenerated - pike ... [skip ci]
by Kamailio Dev 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 55e721eed77f129ab22d043a7d03fbca21e64200 URL: https://github.com/kamailio/kamailio/commit/55e721eed77f129ab22d043a7d03fbc… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-24T15:31:11+01:00 modules: readme files regenerated - pike ... [skip ci] --- Modified: src/modules/pike/README --- Diff: https://github.com/kamailio/kamailio/commit/55e721eed77f129ab22d043a7d03fbc… Patch: https://github.com/kamailio/kamailio/commit/55e721eed77f129ab22d043a7d03fbc… --- diff --git a/src/modules/pike/README b/src/modules/pike/README index 34a26d7020..a7f66697e7 100644 --- a/src/modules/pike/README +++ b/src/modules/pike/README @@ -247,9 +247,9 @@ Chapter 3. Developer Guide Example 3.1. Tree of IP addresses / 193 - 175 - 132 - 164 -tree root / \ 142 +tree root / \ - 142 \ 195 - 37 - 78 - 163 - \ 79 - 134 + \ - 79 - 134 To detect the whole address, step by step, from the root to the leafs, the nodes corresponding to each byte of the ip address are expanded. In

1 0

git:master:e65ce2fd: pike: docs - aligned ip tree example
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: e65ce2fd407626acc89879033a2114cf521457dc URL: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T15:23:10+01:00 pike: docs - aligned ip tree example --- Modified: src/modules/pike/doc/pike_devel.xml --- Diff: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… Patch: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… --- diff --git a/src/modules/pike/doc/pike_devel.xml b/src/modules/pike/doc/pike_devel.xml index 3b96276da5..950b54cf90 100644 --- a/src/modules/pike/doc/pike_devel.xml +++ b/src/modules/pike/doc/pike_devel.xml @@ -19,10 +19,10 @@ <example> <title>Tree of &ip; addresses</title> <programlisting format="linespecific"> - / 193 - 175 - 132 - 164 -tree root / \ 142 - \ 195 - 37 - 78 - 163 - \ 79 - 134 + / 193 - 175 - 132 - 164 +tree root / \ - 142 + \ 195 - 37 - 78 - 163 + \ - 79 - 134 </programlisting> </example> <para>

1 0

git:master:ca33c2de: modules: readme files regenerated - sst ... [skip ci]
by Kamailio Dev 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: ca33c2deb73e4532488ac8181622f2c7f723bd5f URL: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-24T15:01:12+01:00 modules: readme files regenerated - sst ... [skip ci] --- Modified: src/modules/sst/README --- Diff: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… Patch: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… --- diff --git a/src/modules/sst/README b/src/modules/sst/README index 725cffc95d..3444863563 100644 --- a/src/modules/sst/README +++ b/src/modules/sst/README @@ -219,20 +219,36 @@ modparam("sst", "min_se", 2400) 4.3. timeout_avp (string) - This parameter MUST be set to the same value as the dialog module - parameter of the same name. If this parameter is NOT set, the sst - module will not do anything! + This parameter must be set to the same value as the dialog module + parameter of the same name, when it is wanted to update dialog timeout + using Session-Expires header value. If this parameter is not set, the + sst module will not update dialog timeout. - This is how the sst module knows which avp in the dialog module it has - to change with the new expire value. + With this parameter, the sst module knows which avp is expected by the + dialog module to change to a new expire value. - Default value is “NULL!” it is not set by default. + Note that the avp is set only for requests within dialog, not for the + initial INVITE. For this one, it can be done using script operations, + see the next example for such solution. + + Default value is “NULL” (not set by default). Example 1.4. Set timeout_avp parameter ... -modparam("dialog", "timeout_avp", "$avp(i:10)") +modparam("dialog", "timeout_avp", "$avp(dlgtimeout)") # Set the sst modules timeout_avp to be the same value -modparam("sst", "timeout_avp", "$avp(i:10)") +modparam("sst", "timeout_avp", "$avp(dlgtimeout)") +... +request_route { + ... + # when wanting to use Session-Expires value for initial INVITE + if(is_method("INVITE") and !has_totag()) { + if(is_present_hf("Session-Expires")) { + $avp(dlgtimeout) = $(hdr(Session-Expires){s.int}); + } + } + ... +} ... 4.4. reject_to_small (integer)

1 0

git:master:b800ffb9: sst: docs - more info about how timeout_avp is used
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: b800ffb9fb1de6ee0d7b6c2b42a25669022c1142 URL: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T14:50:58+01:00 sst: docs - more info about how timeout_avp is used --- Modified: src/modules/sst/doc/sst_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… Patch: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… --- diff --git a/src/modules/sst/doc/sst_admin.xml b/src/modules/sst/doc/sst_admin.xml index 49f2630287..a82132bd6e 100644 --- a/src/modules/sst/doc/sst_admin.xml +++ b/src/modules/sst/doc/sst_admin.xml @@ -207,25 +207,41 @@ modparam("sst", "min_se", 2400) <section id="sst.p.timeout_avp"> <title><varname>timeout_avp</varname> (string)</title> - <para>This parameter MUST be set to the same value as the - dialog module parameter of the same name. If this parameter is - NOT set, the sst module will not do anything!</para> - - <para>This is how the sst module knows which avp in the - dialog module it has to change with the new expire value.</para> + <para>This parameter must be set to the same value as the + dialog module parameter of the same name, when it is wanted to update + dialog timeout using Session-Expires header value. If this parameter is + not set, the sst module will not update dialog timeout.</para> + <para>With this parameter, the sst module knows which avp is expected + by the dialog module to change to a new expire value.</para> + <para> <para> + Note that the avp is set only for requests within dialog, not for + the initial INVITE. For this one, it can be done using script operations, + see the next example for such solution. + </para> <emphasis> - Default value is <quote>NULL!</quote> it is not set by default. + Default value is <quote>NULL</quote> (not set by default). </emphasis> </para> <example> <title>Set <varname>timeout_avp</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("dialog", "timeout_avp", "$avp(i:10)") +modparam("dialog", "timeout_avp", "$avp(dlgtimeout)") # Set the sst modules timeout_avp to be the same value -modparam("sst", "timeout_avp", "$avp(i:10)") +modparam("sst", "timeout_avp", "$avp(dlgtimeout)") +... +request_route { + ... + # when wanting to use Session-Expires value for initial INVITE + if(is_method("INVITE") and !has_totag()) { + if(is_present_hf("Session-Expires")) { + $avp(dlgtimeout) = $(hdr(Session-Expires){s.int}); + } + } + ... +} ... </programlisting> </example>

1 0

[kamailio/kamailio] Fix returning multiple IP's for a cached DNS entry (#2260)
by Nathan 24 Mar '20

24 Mar '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description The method `dns_entry2he` was returning 10 `hostent` structures, containing the same record, because the rr counter was never updated (10 being the value of `DNS_HE_MAX_ADDR`). With this fix, the cache correctly returns all records found by the resolver. In the documentation of `dns_int_match_ip`, it says: >> At this moment, the function might not check all the IP addresses as returned by dns_sys_match_ip(), because the internal resolver targets to discover the first address to be used for relaying SIP traffic. I believe that with this patch, `dns_int_match_ip` now also works for DNS entries with multiple values. I'm not sure about mixed ipv4/ipv6 though. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2260 -- Commit Summary -- * Fix returning multiple IP's for a cached DNS entry -- File Changes -- M src/core/dns_cache.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2260.patch https://github.com/kamailio/kamailio/pull/2260.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2260

2 2

git:master:29a35ec3: core: fix returning multiple IPs for a cached DNS entry
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 29a35ec3cec8b9c3ee4b45c8d84308701bda097c URL: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… Author: Nathan Bruning <nathan(a)iperity.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:24:28+01:00 core: fix returning multiple IPs for a cached DNS entry --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… Patch: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 8f3f4aeaf9..81fc6a9e45 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -2304,6 +2304,7 @@ inline static struct hostent* dns_entry2he(struct dns_hash_entry* e) return 0; } memcpy(p_addr[i], ip, len); + rr_no++; } if (i==0){ LM_DBG("no good records found (%d) for %.*s (%d)\n",

1 0

[kamailio/kamailio] modules: fix zero-length log placeholder (#2241)
by Zero King 24 Mar '20

24 Mar '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2241 -- Commit Summary -- * modules: fix zero-length log placeholder -- File Changes -- M src/modules/nathelper/nhelpr_funcs.c (2) M src/modules/rtpengine/rtpengine_funcs.c (2) M src/modules/rtpproxy/rtpproxy_funcs.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2241.patch https://github.com/kamailio/kamailio/pull/2241.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2241

3 3

git:master:740afac1: rtpengine: fix zero-length log placeholder
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 740afac15b3d8d618b5101a761a37f5808d4b4f0 URL: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:12:39+01:00 rtpengine: fix zero-length log placeholder --- Modified: src/modules/rtpengine/rtpengine_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… Patch: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… --- diff --git a/src/modules/rtpengine/rtpengine_funcs.c b/src/modules/rtpengine/rtpengine_funcs.c index b99153a063..598af6360e 100644 --- a/src/modules/rtpengine/rtpengine_funcs.c +++ b/src/modules/rtpengine/rtpengine_funcs.c @@ -231,7 +231,7 @@ int extract_body(struct sip_msg *msg, str *body ) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if ( rest > p2 ) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1-p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2-p1), p1); return -1; } while( rest<p2 ) {

1 0

git:master:030f18b5: rtpproxy: fix zero-length log placeholder
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 030f18b5cffeb117dcf582cf12c5b3c35ace1469 URL: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:12:25+01:00 rtpproxy: fix zero-length log placeholder --- Modified: src/modules/rtpproxy/rtpproxy_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… Patch: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… --- diff --git a/src/modules/rtpproxy/rtpproxy_funcs.c b/src/modules/rtpproxy/rtpproxy_funcs.c index 858c5196d5..35401cdb24 100644 --- a/src/modules/rtpproxy/rtpproxy_funcs.c +++ b/src/modules/rtpproxy/rtpproxy_funcs.c @@ -228,7 +228,7 @@ int extract_body(struct sip_msg *msg, str *body ) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if ( rest > p2 ) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1-p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2-p1), p1); return -1; } while( rest<p2 ) {

1 0

git:master:69714b26: nathelper: fix zero-length log placeholder
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 69714b26c63c75df6759f9158c7181d4f86b4764 URL: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:11:54+01:00 nathelper: fix zero-length log placeholder --- Modified: src/modules/nathelper/nhelpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… Patch: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… --- diff --git a/src/modules/nathelper/nhelpr_funcs.c b/src/modules/nathelper/nhelpr_funcs.c index 7300868532..c0db297c1e 100644 --- a/src/modules/nathelper/nhelpr_funcs.c +++ b/src/modules/nathelper/nhelpr_funcs.c @@ -227,7 +227,7 @@ int extract_body(struct sip_msg *msg, str *body) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if(rest > p2) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1 - p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2 - p1), p1); return -1; } while(rest < p2) {

1 0

git:master:63cd404d: kamctl: regenerated db schema file with secfilter updates
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 63cd404d4b46e4514ae1490303189a0f81def942 URL: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T10:33:30+01:00 kamctl: regenerated db schema file with secfilter updates --- Added: utils/kamctl/db_berkeley/kamailio/secfilter Added: utils/kamctl/db_redis/kamailio/secfilter Added: utils/kamctl/dbtext/kamailio/secfilter Added: utils/kamctl/mongodb/kamailio/secfilter.json Added: utils/kamctl/xhttp_pi/secfilter-mod Added: utils/kamctl/xhttp_pi/secfilter-table Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/db_sqlite/secfilter-create.sql Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mongodb/kamailio/version-create.mongo Modified: utils/kamctl/mysql/secfilter-create.sql Modified: utils/kamctl/oracle/secfilter-create.sql Modified: utils/kamctl/postgres/secfilter-create.sql Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0… Patch: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0…

1 0

git:master:7c8fdb0d: lib/srdb1: schema - use smallint for secfilter
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 7c8fdb0df37ee1466d7171ff3cff77e5b961abb4 URL: https://github.com/kamailio/kamailio/commit/7c8fdb0df37ee1466d7171ff3cff77e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T10:33:30+01:00 lib/srdb1: schema - use smallint for secfilter - tinyint is not supported --- Modified: src/lib/srdb1/schema/secfilter.xml --- Diff: https://github.com/kamailio/kamailio/commit/7c8fdb0df37ee1466d7171ff3cff77e… Patch: https://github.com/kamailio/kamailio/commit/7c8fdb0df37ee1466d7171ff3cff77e… --- diff --git a/src/lib/srdb1/schema/secfilter.xml b/src/lib/srdb1/schema/secfilter.xml index 3e0037da5a..4edab34e6c 100644 --- a/src/lib/srdb1/schema/secfilter.xml +++ b/src/lib/srdb1/schema/secfilter.xml @@ -36,14 +36,14 @@ <column id="action"> <name>action</name> - <type>tinyint</type> + <type>short</type> <default/> <description>Action to do (0=blacklisted data, 1=whitelisted data, 2=blacklisted destination).</description> </column> <column id="type"> <name>type</name> - <type>tinyint</type> + <type>short</type> <default/> <description>Type of data (0=user-agent, 1=country, 2=domain, 3=IP address, 4=user).</description> </column>

1 0

git:master:09c18bb0: lib/srdb1: schema - added xml file for sefilter module
by Daniel-Constantin Mierla 24 Mar '20

24 Mar '20

Module: kamailio Branch: master Commit: 09c18bb06691ad29b71990179a3006b5bdfbf602 URL: https://github.com/kamailio/kamailio/commit/09c18bb06691ad29b71990179a3006b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T10:33:30+01:00 lib/srdb1: schema - added xml file for sefilter module --- Added: src/lib/srdb1/schema/kamailio-secfilter.xml --- Diff: https://github.com/kamailio/kamailio/commit/09c18bb06691ad29b71990179a3006b… Patch: https://github.com/kamailio/kamailio/commit/09c18bb06691ad29b71990179a3006b… --- diff --git a/src/lib/srdb1/schema/kamailio-secfilter.xml b/src/lib/srdb1/schema/kamailio-secfilter.xml new file mode 100644 index 0000000000..ae34ded087 --- /dev/null +++ b/src/lib/srdb1/schema/kamailio-secfilter.xml @@ -0,0 +1,12 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!DOCTYPE database PUBLIC "-//kamailio.org//DTD DBSchema V1.1//EN" + "http://kamailio.org/pub/kamailio/dbschema/dtd/1.1/dbschema.dtd" [ + + <!ENTITY % entities SYSTEM "entities.xml"> + %entities; +]> + +<database xmlns:xi="http://www.w3.org/2001/XInclude"> + <name>SECFILTER Module</name> + <xi:include href="secfilter.xml"/> +</database>

1 0

plan for finding dependencies?
by Greg Troxel 24 Mar '20

24 Mar '20

[I've been working through making kamailio build on NetBSD -- thanks for merging my recent PR with two small fixes.] In src/Makefile.defs, there is a setting of LOCALBASE, which is basically a case statement by OS. A few examples: Linux /usr/local presuambly the tradition /usr/local per autucoonf FreeBSD /usr/local hijacked by ports system - not traditional /usr/local NetBSD /usr/pkg pkgsrc puts things here (local is still local) There is a need for two separate prefixes when building something like this: where the software being built should be installed: basically like --prefix=/foo in autoconf where things that the software depends on should be found, sort of what autoconf would use for --with-bar=/baz, so that /baz/include is added to CPPFLAGS and "-L/baz/lib -R/baz/lib" to LDFLAGS. I needed to add the C_INCLUDES as ifeq ($(OS), netbsd) C_INCLUDES+= -I$(LOCALBASE)/include since otherwise a libxml2 header is not found (and with the above it builds fine): gcc -fPIC -DPIC -g -funroll-loops -Wcast-align -m64 -minline-all-stringops -falign-loops -ftree-vectorize -fno-strict-overflow -mtune=generic -Wall -DNAME='"kamailio"' -DVERSION='"5.4.0-dev3"' -DARCH='"x86_64"' -DOS='netbsd_' -DOS_QUOTED='"netbsd"' -DCOMPILER='"gcc 5.5.0"' -D__CPU_x86_64 -D__OS_netbsd -DVERSIONVAL=5004000 -DCFG_DIR='"/usr/pkg/etc/kamailio/"' -DSHARE_DIR='"/usr/pkg/share/kamailio/"' -DRUN_DIR='"/var/run/kamailio/"' -DPKG_MALLOC -DSHM_MMAP -DDNS_IP_HACK -DUSE_MCAST -DUSE_TCP -DDISABLE_NAGLE -DHAVE_RESOLV_RES -DUSE_DNS_CACHE -DUSE_DNS_FAILOVER -DUSE_DST_BLACKLIST -DUSE_NAPTR -DWITH_XAVP -DMEM_JOIN_FREE -DF_MALLOC -DQ_MALLOC -DTLSF_MALLOC -DDBG_SR_MEMORY -DUSE_TLS -DTLS_HOOKS -DUSE_CORE_STATS -DSTATISTICS -DMALLOC_STATS -DUSE_SCTP -DFAST_LOCK -DADAPTIVE_WAIT -DADAPTIVE_WAIT_LOOPS=1024 -DCC_GCC_LIKE_ASM -DHAVE_SOCKADDR_SA_LEN -DHAVE_GETHOSTBYNAME2 -DHAVE_MSGHDR_MSG_CONTROL -DHAVE_CONNECT_ECONNRESET_BUG -DHAVE_TIMEGM -DHAVE_SELECT -I/usr/pkg/include/libxml2 -I/usr/include -DMOD_NAME='"ims_registrar_pcscf"' -c notify.c -o notify.o -MMD -MP notify.c:38:36: fatal error: libxml2/libxml/globals.h: No such file or directory Of course, on Linux this issue is usually avoided because everything is installed with --prefix=/usr which is in te default search path. So my questions are: Is LOCALBASE supposed to be where kamailio is built into? (If so, then /usr/pkg seems like a wrong default on NetBSD, following the autoconf /usr/local norm, even though pkgsrc builds would pass in /usr/pkg.) Or is it where dependencies are? (If so, why isn't LOCALBASE/include put in cflags?) If dependencies are supposed to be someplace else, what's the mechanism to look for them? C_INCLUDES is set to empty, so I can't pass that in. Shouldn't the plan be explained in INSTALL (and sorry if I missed it)? Even a very brief clue would be appreciated, so I can align my changes with the overall intent. Thanks, Greg

2 1

git:master:7c879b17: modules: readme files regenerated - lost ... [skip ci]
by Kamailio Dev 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: 7c879b176df397b87332418dc071c49c17fb5781 URL: https://github.com/kamailio/kamailio/commit/7c879b176df397b87332418dc071c49… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-23T23:01:10+01:00 modules: readme files regenerated - lost ... [skip ci] --- Modified: src/modules/lost/README --- Diff: https://github.com/kamailio/kamailio/commit/7c879b176df397b87332418dc071c49… Patch: https://github.com/kamailio/kamailio/commit/7c879b176df397b87332418dc071c49…

1 0

git:master:d5b2c1df: lost: new module parameters to set HeLD request attributes
by Wolfgang Kampichler 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: d5b2c1dfe37fbeb443912f2b80fb2877ebf09672 URL: https://github.com/kamailio/kamailio/commit/d5b2c1dfe37fbeb443912f2b80fb287… Author: Wolfgang Kampichler <dev(a)kampichler.info> Committer: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2020-03-23T22:44:27+01:00 lost: new module parameters to set HeLD request attributes - parameters are exact_type, response_time, and location_type - the module function lost_held_query now supports proper handling of location types 'any', 'civic', 'geodetic' or 'locationURI' (or any combination). - besides: README update and code refactoring. --- Modified: src/modules/lost/doc/lost_admin.xml Modified: src/modules/lost/functions.c Modified: src/modules/lost/functions.h Modified: src/modules/lost/lost.c Modified: src/modules/lost/utilities.c Modified: src/modules/lost/utilities.h --- Diff: https://github.com/kamailio/kamailio/commit/d5b2c1dfe37fbeb443912f2b80fb287… Patch: https://github.com/kamailio/kamailio/commit/d5b2c1dfe37fbeb443912f2b80fb287…

1 0

git:master:dda07c69: rtpengine: replaced rtpproxy with rtpengine
by Daniel-Constantin Mierla 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: dda07c69420e1a38948dae4b71f8005b2375253b URL: https://github.com/kamailio/kamailio/commit/dda07c69420e1a38948dae4b71f8005… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-23T18:42:23+01:00 rtpengine: replaced rtpproxy with rtpengine - avoid confusion in printed log messges --- Modified: src/modules/rtpengine/config.c Modified: src/modules/rtpengine/rtpengine.c Modified: src/modules/rtpengine/rtpengine.h Modified: src/modules/rtpengine/rtpengine_db.c --- Diff: https://github.com/kamailio/kamailio/commit/dda07c69420e1a38948dae4b71f8005… Patch: https://github.com/kamailio/kamailio/commit/dda07c69420e1a38948dae4b71f8005…

1 0

git:master:8965ff07: dialog: dmq operations under locked dlg table entry
by Daniel-Constantin Mierla 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: 8965ff07f2e9fa105fc56896eed9caf4b6faf261 URL: https://github.com/kamailio/kamailio/commit/8965ff07f2e9fa105fc56896eed9caf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-23T17:57:48+01:00 dialog: dmq operations under locked dlg table entry - protect against races that could be due to rentransmissions or other parallel processing cases - related to GH #2224 --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/8965ff07f2e9fa105fc56896eed9caf… Patch: https://github.com/kamailio/kamailio/commit/8965ff07f2e9fa105fc56896eed9caf… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index 08dbc84686..fdca3f0f0a 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -99,7 +99,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no { int content_length; str body; - dlg_cell_t *dlg; + dlg_cell_t *dlg = NULL; int unref = 0; int ret; srjson_doc_t jdoc, prof_jdoc; @@ -216,7 +216,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no } } - dlg = dlg_get_by_iuid(&iuid); + dlg = dlg_get_by_iuid_mode(&iuid, 1); if (dlg) { LM_DBG("found dialog [%u:%u] at %p\n", iuid.h_entry, iuid.h_id, dlg); unref++; @@ -237,6 +237,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no LM_ERR("inconsistent hash data from peer: " "make sure all Kamailio's use the same hash size\n"); shm_free(dlg); + dlg = NULL; goto error; } @@ -391,8 +392,14 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no case DLG_DMQ_NONE: break; } - if (dlg && unref) - dlg_unref(dlg, unref); + if (dlg) { + if(unref) { + dlg_unref(dlg, unref); + } + if(newdlg == 0) { + dlg_cell_unlock(dlg); + } + } srjson_DestroyDoc(&jdoc); resp->reason = dmq_200_rpl; @@ -407,6 +414,11 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no return 0; error: + if (dlg) { + if(newdlg == 0) { + dlg_cell_unlock(dlg); + } + } srjson_DestroyDoc(&jdoc); resp->reason = dmq_500_rpl; resp->resp_code = 500;

1 0

git:master:125031da: dialog: exposed functions to search dlg and lock table entry
by Daniel-Constantin Mierla 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: 125031daeade9dab5c36b912dda65700d95c4c6a URL: https://github.com/kamailio/kamailio/commit/125031daeade9dab5c36b912dda6570… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-23T17:48:39+01:00 dialog: exposed functions to search dlg and lock table entry --- Modified: src/modules/dialog/dlg_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/125031daeade9dab5c36b912dda6570… Patch: https://github.com/kamailio/kamailio/commit/125031daeade9dab5c36b912dda6570… --- diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h index eb933c5acb..ed5cd7bef0 100644 --- a/src/modules/dialog/dlg_hash.h +++ b/src/modules/dialog/dlg_hash.h @@ -324,6 +324,18 @@ int dlg_update_rr_set(struct dlg_cell * dlg, unsigned int leg, str *rr); int dlg_set_toroute(dlg_cell_t *dlg, str *route); +/*! + * \brief Lookup a dialog in the global list + * + * Note that the caller is responsible for decrementing (or reusing) + * the reference counter by one again iff a dialog has been found. + * \param h_entry number of the hash table entry + * \param h_id id of the hash table entry + * \param lmode id if 0, then dlg table entry is unlocked, otherwise is locked + * \return dialog structure on success, NULL on failure + */ +dlg_cell_t *dlg_lookup_mode(unsigned int h_entry, unsigned int h_id, int lmode); + /*! * \brief Lookup a dialog in the global list * @@ -335,6 +347,17 @@ int dlg_set_toroute(dlg_cell_t *dlg, str *route); */ dlg_cell_t* dlg_lookup(unsigned int h_entry, unsigned int h_id); +/*! + * \brief Search a dialog in the global list by iuid + * + * Note that the caller is responsible for decrementing (or reusing) + * the reference counter by one again if a dialog has been found. + * \param diuid internal unique id per dialog + * \param lmode id if 0, then dlg table entry is unlocked, otherwise is locked + * \return dialog structure on success, NULL on failure + */ +dlg_cell_t* dlg_get_by_iuid_mode(dlg_iuid_t *diuid, int lmode); + /*! * \brief Search and return dialog in the global list by iuid *

1 0

git:master:a4f8c029: dialog: functions to search dialog by uuid and keep table entry locked
by Daniel-Constantin Mierla 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: a4f8c0291bfd32752c0c2c323f618c6ac0c91d53 URL: https://github.com/kamailio/kamailio/commit/a4f8c0291bfd32752c0c2c323f618c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-23T17:36:44+01:00 dialog: functions to search dialog by uuid and keep table entry locked - helper macros to lock/unlock table entry with dlg cell structure --- Modified: src/modules/dialog/dlg_hash.c Modified: src/modules/dialog/dlg_hash.h --- Diff: https://github.com/kamailio/kamailio/commit/a4f8c0291bfd32752c0c2c323f618c6… Patch: https://github.com/kamailio/kamailio/commit/a4f8c0291bfd32752c0c2c323f618c6… --- diff --git a/src/modules/dialog/dlg_hash.c b/src/modules/dialog/dlg_hash.c index 4e0e28b788..5557e87574 100644 --- a/src/modules/dialog/dlg_hash.c +++ b/src/modules/dialog/dlg_hash.c @@ -762,9 +762,10 @@ int dlg_update_rr_set(struct dlg_cell * dlg, unsigned int leg, str *rr) * the reference counter by one again iff a dialog has been found. * \param h_entry number of the hash table entry * \param h_id id of the hash table entry + * \param lmode id if 0, then dlg table entry is unlocked, otherwise is locked * \return dialog structure on success, NULL on failure */ -dlg_cell_t *dlg_lookup( unsigned int h_entry, unsigned int h_id) +dlg_cell_t *dlg_lookup_mode(unsigned int h_entry, unsigned int h_id, int lmode) { dlg_cell_t *dlg; dlg_entry_t *d_entry; @@ -777,24 +778,59 @@ dlg_cell_t *dlg_lookup( unsigned int h_entry, unsigned int h_id) d_entry = &(d_table->entries[h_entry]); - dlg_lock( d_table, d_entry); + dlg_lock(d_table, d_entry); for( dlg=d_entry->first ; dlg ; dlg=dlg->next ) { if (dlg->h_id == h_id) { ref_dlg_unsafe(dlg, 1); - dlg_unlock( d_table, d_entry); + if (likely(lmode == 0)) { + dlg_unlock(d_table, d_entry); + } LM_DBG("dialog id=%u found on entry %u\n", h_id, h_entry); return dlg; } } - dlg_unlock( d_table, d_entry); + dlg_unlock(d_table, d_entry); not_found: LM_DBG("no dialog id=%u found on entry %u\n", h_id, h_entry); return 0; } +/*! + * \brief Lookup a dialog in the global list + * + * Note that the caller is responsible for decrementing (or reusing) + * the reference counter by one again iff a dialog has been found. + * \param h_entry number of the hash table entry + * \param h_id id of the hash table entry + * \return dialog structure on success, NULL on failure + */ +dlg_cell_t *dlg_lookup(unsigned int h_entry, unsigned int h_id) +{ + return dlg_lookup_mode(h_entry, h_id, 0); +} + +/*! + * \brief Search a dialog in the global list by iuid + * + * Note that the caller is responsible for decrementing (or reusing) + * the reference counter by one again if a dialog has been found. + * \param diuid internal unique id per dialog + * \param lmode id if 0, then dlg table entry is unlocked, otherwise is locked + * \return dialog structure on success, NULL on failure + */ +dlg_cell_t* dlg_get_by_iuid_mode(dlg_iuid_t *diuid, int lmode) +{ + if(diuid==NULL) + return NULL; + if(diuid->h_id==0) + return NULL; + /* dlg ref counter is increased by next line */ + return dlg_lookup_mode(diuid->h_entry, diuid->h_id, lmode); +} + /*! * \brief Search a dialog in the global list by iuid * @@ -810,7 +846,7 @@ dlg_cell_t* dlg_get_by_iuid(dlg_iuid_t *diuid) if(diuid->h_id==0) return NULL; /* dlg ref counter is increased by next line */ - return dlg_lookup(diuid->h_entry, diuid->h_id); + return dlg_lookup_mode(diuid->h_entry, diuid->h_id, 0); } /*! diff --git a/src/modules/dialog/dlg_hash.h b/src/modules/dialog/dlg_hash.h index 5ecf13f871..eb933c5acb 100644 --- a/src/modules/dialog/dlg_hash.h +++ b/src/modules/dialog/dlg_hash.h @@ -201,6 +201,21 @@ extern dlg_table_t *d_table; } \ } while(0) +/*! + * \brief Set a dialog lock (re-entrant) + * \param _dlg dialog cell + */ +#define dlg_cell_lock(_dlg) \ + dlg_lock(d_table, &(d_table->entries[(_dlg)->h_entry])) + +/*! + * \brief Set a dialog lock (re-entrant) + * \param _dlg dialog cell + */ +#define dlg_cell_unlock(_dlg) \ + dlg_unlock(d_table, &(d_table->entries[(_dlg)->h_entry])) + + /*! * \brief Unlink a dialog from the list without locking * \see unref_dlg_unsafe

1 0

git:master:eb846397: modules: readme files regenerated - sipcapture ... [skip ci]
by Kamailio Dev 23 Mar '20

23 Mar '20

Module: kamailio Branch: master Commit: eb846397009066c719ee37478a72f5296317f3b6 URL: https://github.com/kamailio/kamailio/commit/eb846397009066c719ee37478a72f52… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-23T15:31:17+01:00 modules: readme files regenerated - sipcapture ... [skip ci] --- Modified: src/modules/sipcapture/README --- Diff: https://github.com/kamailio/kamailio/commit/eb846397009066c719ee37478a72f52… Patch: https://github.com/kamailio/kamailio/commit/eb846397009066c719ee37478a72f52… --- diff --git a/src/modules/sipcapture/README b/src/modules/sipcapture/README index 201243ac17..6d671b5da6 100644 --- a/src/modules/sipcapture/README +++ b/src/modules/sipcapture/README @@ -51,6 +51,7 @@ Alexandr Dubovikov 3.20. topoh_unmask (int) 3.21. nonsip_hook (int) 3.22. event_callback (str) + 3.23. capture_bad_msgs (int) 4. Functions @@ -94,11 +95,12 @@ Alexandr Dubovikov 1.20. Set topoh_unmask parameter 1.21. Set nonsip_hook parameter 1.22. Set event_callback parameter - 1.23. sip_capture() usage - 1.24. report_capture() usage + 1.23. Set capture_bad_msgs parameter + 1.24. sip_capture() usage 1.25. report_capture() usage - 1.26. sip_capture_forward() usage - 1.27. event_route[sipcapture:request] usage + 1.26. report_capture() usage + 1.27. sip_capture_forward() usage + 1.28. event_route[sipcapture:request] usage Chapter 1. Admin Guide @@ -134,6 +136,7 @@ Chapter 1. Admin Guide 3.20. topoh_unmask (int) 3.21. nonsip_hook (int) 3.22. event_callback (str) + 3.23. capture_bad_msgs (int) 4. Functions @@ -209,6 +212,7 @@ Chapter 1. Admin Guide 3.20. topoh_unmask (int) 3.21. nonsip_hook (int) 3.22. event_callback (str) + 3.23. capture_bad_msgs (int) 3.1. db_url (str) @@ -513,6 +517,18 @@ function ksr_sipcapture_event(evname) end ... +3.23. capture_bad_msgs (int) + + If set to something different than 0, tries to capture also the broken + SIP messages. + + Default value is 0. + + Example 1.23. Set capture_bad_msgs parameter +... +modparam("sipcapture", "capture_bad_msgs", 1) +... + 4. Functions 4.1. sip_capture([table], [cmode]) @@ -536,7 +552,7 @@ end This function can be used from ANY_ROUTE. Default value is "NULL". - Example 1.23. sip_capture() usage + Example 1.24. sip_capture() usage ... sip_capture(); ... @@ -557,7 +573,7 @@ sip_capture("", "cmode"); This function can be used from ANY_ROUTE. Default value is "NULL". - Example 1.24. report_capture() usage + Example 1.25. report_capture() usage ... report_capture(); ... @@ -573,7 +589,7 @@ report_capture("report_data", "$ci", "{\"MOS\":4.1,\"PACKET_LOST\":100"}); This function can be used from ANY_ROUTE. - Example 1.25. report_capture() usage + Example 1.26. report_capture() usage ... $var(res) = float2int("10.5", "1"); ... @@ -588,7 +604,7 @@ $var(res) = float2int("10.5", "1"); This function can be used from ANY_ROUTE. - Example 1.26. sip_capture_forward() usage + Example 1.27. sip_capture_forward() usage ... event_route[sipcapture:request] { ... @@ -609,7 +625,7 @@ $var(res) = float2int("10.5", "1"); Event route block to be executed when HEP packet is received. It requires module parameter 'nonsip_hook' to be set to 1. - Example 1.27. event_route[sipcapture:request] usage + Example 1.28. event_route[sipcapture:request] usage ... # new event sipcapture socket modparam("sipcapture", "nonsip_hook", 1)

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2020