March 2020 - sr-dev - kamailio.org

git:5.2:1a142067: corex: check not in SHM before PKG free for path
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.2 Commit: 1a142067b04e41b98ce2f8d7f0946c2dcbd7914f URL: https://github.com/kamailio/kamailio/commit/1a142067b04e41b98ce2f8d7f0946c2… Author: Stefan Mititelu <stefan.mititelu92(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T12:45:41+01:00 corex: check not in SHM before PKG free for path Do the same for reset_path_vector() in core msg parser. (cherry picked from commit 395303dbb3572e57bd8d16bcbbfb29d6d54a60fe) --- … [View More]

1 0

git:5.2:16b0801b: core: fix a crash in cfg parser related to invalid syntax cases
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.2 Commit: 16b0801ba6b25a5660f2ba30fef35e9cc81fe9c0 URL: https://github.com/kamailio/kamailio/commit/16b0801ba6b25a5660f2ba30fef35e9… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T11:23:40+01:00 core: fix a crash in cfg parser related to invalid syntax cases (cherry picked from commit 54a0aeee9d30ee85045150d8ad5b75f7a4b71d15) --- Modified: src/core/cfg.y --- Diff: https://github.com/… [View More]

1 0

git:5.3:15ff3bbb: core: fix a crash in cfg parser related to invalid syntax cases
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.3 Commit: 15ff3bbb0fb79c49f1913fa604680a4904251a50 URL: https://github.com/kamailio/kamailio/commit/15ff3bbb0fb79c49f1913fa604680a4… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T11:23:16+01:00 core: fix a crash in cfg parser related to invalid syntax cases (cherry picked from commit 54a0aeee9d30ee85045150d8ad5b75f7a4b71d15) --- Modified: src/core/cfg.y --- Diff: https://github.com/… [View More]

1 0

git:master:1bbab692: ims_usrloc_scscf: extern declaration for duplicated global vars
by Daniel-Constantin Mierla 05 Mar '20

05 Mar '20

Module: kamailio Branch: master Commit: 1bbab692b749feee7f23a6c5c3fbee1ac890fffa URL: https://github.com/kamailio/kamailio/commit/1bbab692b749feee7f23a6c5c3fbee1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-05T11:22:45+01:00 ims_usrloc_scscf: extern declaration for duplicated global vars --- Modified: src/modules/ims_usrloc_scscf/udomain.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:54a0aeee: core: fix a crash in cfg parser related to invalid syntax cases
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: master Commit: 54a0aeee9d30ee85045150d8ad5b75f7a4b71d15 URL: https://github.com/kamailio/kamailio/commit/54a0aeee9d30ee85045150d8ad5b75f… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T11:22:21+01:00 core: fix a crash in cfg parser related to invalid syntax cases --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/54a0aeee9d30ee85045150d8ad5b75f… Patch: … [View More]

1 0

git:5.2:7916cb92: core: cfg.y - detect use of function call as parameter of another function
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.2 Commit: 7916cb92fdd12fce74dd6295890ea0bdb5ba36fd URL: https://github.com/kamailio/kamailio/commit/7916cb92fdd12fce74dd6295890ea0b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T11:01:02+01:00 core: cfg.y - detect use of function call as parameter of another function - GH #2227 (cherry picked from commit 047fdebff732c847fcde5b066ce1acd5f6c2219a) --- Modified: src/core/cfg.y -… [View More]

1 0

git:5.2:46d156c1: core: cfg.y - init static global variables
by Henning Westerholt 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.2 Commit: 46d156c1da3fa466abebb8bf036807163ff7c90a URL: https://github.com/kamailio/kamailio/commit/46d156c1da3fa466abebb8bf0368071… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-05T11:00:54+01:00 core: cfg.y - init static global variables (cherry picked from commit 8c5b92ee638a33e612e68cf85a1d37ab5e5d2c22) --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/… [View More]

1 0

[kamailio/kamailio] Kamailio crash with invalid statement in configuration (#2227)
by Henning Westerholt 05 Mar '20

05 Mar '20

Kamailio crash with invalid statement in configuration. I already investigated several probable causes to some extend, but did not managed to find a fix yet. ``` $ cat ../etc/crash.cfg (note the capital "I" at the if-case, memdbg was just added for debugging) #!KAMAILIO … [View More] memdbg=3 loadmodule "textops.so" request_route { Iif (is_method("CANCEL")) { exit; } } ``` henning@static:~/repositories/kamailio/src$ ./kamailio -L modules -Y /tmp -T -S -n 1 -D -m 16 -M 4 -f ../etc/crash.cfg -E 0(24666) ERROR: <core> [core/cfg.y:3403]: yyparse(): cfg. parser: failed to find command Iif (params 2) 0(24666) CRITICAL: <core> [core/cfg.y:3544]: yyerror_at(): parse error in config file /home/henning/repositories/kamailio/src/../etc/crash.cfg, line 7, column 26: unknown command, missing loadmodule? 0(24666) ERROR: <core> [core/cfg.y:3407]: yyparse(): free function 0x7fa138bc1d60 Segmentation fault ``` output from GDB, current git master: Program received signal SIGSEGV, Segmentation fault. 0x0000555555843e4e in rve_destroy (rve=0xc0c0c0c0) at core/rvalue.c:147 147 if (rve->op==RVE_RVAL_OP){ (gdb) bt #0 0x0000555555843e4e in rve_destroy (rve=0xc0c0c0c0) at core/rvalue.c:147 #1 0x00005555558447e1 in rve_destroy (rve=0x7ffff6c98738) at core/rvalue.c:168 #2 0x000055555599b031 in free_mod_func_action (a=0x7ffff6c97d60) at core/cfg.y:3997 #3 0x000055555599665b in yyparse () at core/cfg.y:3408 #4 0x000055555558fbd1 in main (argc=18, argv=0x7fffffffe378) at main.c:2309 (gdb) p rve->op Cannot access memory at address 0xc0c0c0c0 (gdb) p rve $1 = (struct rval_expr *) 0xc0c0c0c0 (gdb) f 1 #1 0x00005555558447e1 in rve_destroy (rve=0x7ffff6c98738) at core/rvalue.c:168 168 rve_destroy(rve->left.rve); (gdb) p rve->left $2 = {rve = 0xc0c0c0c0, rval = {type = 3233857728, refcnt = 0, v = {p = 0xabcdefed, l = 2882400237, s = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 0}, avps = {type = 2882400237, name = {n = 0, s = {s = 0x0, len = 0}, re = 0x0}, index = 8}, sel = {f = {0xabcdefed, 0x0, 0x0, 0x8}, param_offset = {0, 0, 3598392, 0, -154930224}, params = {{type = 1436524721, v = {i = 1436573777, s = {s = 0x555555a06051 "fragm. from qm_malloc", len = 1436524587}, p = 0x555555a06051}}, {type = 1260, v = { i = -252645136, s = {s = 0xf0f0f0f0 <error: Cannot access memory at address 0xf0f0f0f0>, len = 0}, p = 0xf0f0f0f0}}, {type = SEL_PARAM_INT, v = {i = 0, s = {s = 0x0, len = 0}, p = 0x0}} <repeats 30 times>}, n = 0}, pvs = {type = 2882400237, getf = 0x0, setf = 0x0, pvp = {pvn = {type = 8, nfree = 0x0, u = {isname = {type = 3598392, name = {n = -154930224, s = {s = 0x7ffff6c3f3d0 "", len = 1436524721}, re = 0x7ffff6c3f3d0}}, dname = 0x36e838}}, pvi = {type = 1436573777, u = {ival = 1436524587, dval = 0x5555559fa02b}}}, trans = 0x4ec}, action = 0xabcdefed, bexpr = 0xabcdefed, re = {s = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 0}, regex = 0x0}}, bsize = 0, flags = 0, buf = ""}} (gdb) p rve $3 = (struct rval_expr *) 0x7ffff6c98738 (gdb) p *rve $4 = {op = 1129201987, left = {rve = 0xc0c0c0c0, rval = {type = 3233857728, refcnt = 0, v = {p = 0xabcdefed, l = 2882400237, s = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 0}, avps = {type = 2882400237, name = {n = 0, s = {s = 0x0, len = 0}, re = 0x0}, index = 8}, sel = {f = {0xabcdefed, 0x0, 0x0, 0x8}, param_offset = {0, 0, 3598392, 0, -154930224}, params = {{type = 1436524721, v = {i = 1436573777, s = {s = 0x555555a06051 "fragm. from qm_malloc", len = 1436524587}, p = 0x555555a06051}}, {type = 1260, v = {i = -252645136, s = {s = 0xf0f0f0f0 <error: Cannot access memory at address 0xf0f0f0f0>, len = 0}, p = 0xf0f0f0f0}}, {type = SEL_PARAM_INT, v = {i = 0, s = {s = 0x0, len = 0}, p = 0x0}} <repeats 30 times>}, n = 0}, pvs = {type = 2882400237, getf = 0x0, setf = 0x0, pvp = {pvn = {type = 8, nfree = 0x0, u = {isname = {type = 3598392, name = {n = -154930224, s = {s = 0x7ffff6c3f3d0 "", len = 1436524721}, re = 0x7ffff6c3f3d0}}, dname = 0x36e838}}, pvi = { type = 1436573777, u = {ival = 1436524587, dval = 0x5555559fa02b}}}, trans = 0x4ec}, action = 0xabcdefed, bexpr = 0xabcdefed, re = {s = {s = 0xabcdefed <error: Cannot access memory at address 0xabcdefed>, len = 0}, regex = 0x0}}, bsize = 0, flags = 0, buf = ""}}, right = {rve = 0x0, rval = {type = RV_NONE, refcnt = 0, v = {p = 0x0, l = 0, s = {s = 0x0, len = 0}, avps = {type = 0, name = {n = 0, s = {s = 0x0, len = 0}, re = 0x0}, index = 0}, sel = {f = {0x0, 0x0, 0x0, 0x0}, param_offset = {0, 0, 0, 0, 0}, params = {{type = SEL_PARAM_INT, v = {i = 0, s = {s = 0x0, len = 0}, p = 0x0}} <repeats 32 times>}, n = 0}, pvs = {type = PVT_NONE, getf = 0x0, setf = 0x0, pvp = {pvn = {type = 0, nfree = 0x0, u = {isname = {type = 0, name = {n = 0, s = {s = 0x0, len = 0}, re = 0x0}}, dname = 0x0}}, pvi = {type = 0, u = {ival = 0, dval = 0x0}}}, trans = 0x0}, action = 0x0, bexpr = 0x0, re = {s = {s = 0x0, len = 0}, regex = 0x0}}, bsize = 0, flags = 0, buf = ""}}, fpos = {s_line = 0, e_line = 0, s_col = 0, e_col = 0, fname = 0x0, rname = 0x0}} (gdb) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2227 [View Less]

2 6

git:5.3:c887e563: corex: check not in SHM before PKG free for path
by Stefan Mititelu 05 Mar '20

05 Mar '20

Module: kamailio Branch: 5.3 Commit: c887e56311ea77c2d0ded051e93e6b7729edbe24 URL: https://github.com/kamailio/kamailio/commit/c887e56311ea77c2d0ded051e93e6b7… Author: Stefan Mititelu <stefan.mititelu92(a)gmail.com> Committer: Stefan Mititelu <stefan.mititelu92(a)gmail.com> Date: 2020-03-05T10:26:38+02:00 corex: check not in SHM before PKG free for path Do the same for reset_path_vector() in core msg parser. (cherry picked from commit 3bdfec4a357b9d33787108bcf1b5840de343cbe9) --… [View More]

1 0

git:master:395303db: corex: check not in SHM before PKG free for path
by Stefan Mititelu 05 Mar '20

05 Mar '20

Module: kamailio Branch: master Commit: 395303dbb3572e57bd8d16bcbbfb29d6d54a60fe URL: https://github.com/kamailio/kamailio/commit/395303dbb3572e57bd8d16bcbbfb29d… Author: Stefan Mititelu <stefan.mititelu92(a)gmail.com> Committer: Stefan Mititelu <stefan.mititelu(a)enea.com> Date: 2020-03-05T10:25:18+02:00 corex: check not in SHM before PKG free for path Do the same for reset_path_vector() in core msg parser. --- Modified: src/core/parser/msg_parser.c Modified: src/modules/corex/… [View More]

1 0

git:master:a041e94c: ims_registrar_scscf: global vars declared extern in header files
by Daniel-Constantin Mierla 05 Mar '20

05 Mar '20

Module: kamailio Branch: master Commit: a041e94c4dce464737d6531d11fbe4d61292d7b4 URL: https://github.com/kamailio/kamailio/commit/a041e94c4dce464737d6531d11fbe4d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-05T05:17:07+01:00 ims_registrar_scscf: global vars declared extern in header files --- Modified: src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c Modified: src/modules/… [View More]ims_registrar_scscf/registrar_notify.h Modified: src/modules/ims_registrar_scscf/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/a041e94c4dce464737d6531d11fbe4d… Patch: https://github.com/kamailio/kamailio/commit/a041e94c4dce464737d6531d11fbe4d… --- diff --git a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c index b7a408b023..c402ac3985 100644 --- a/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c +++ b/src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c @@ -79,8 +79,11 @@ MODULE_VERSION extern gen_lock_t* process_lock; /* lock on the process table */ -int * callback_singleton; /**< Cx callback singleton */ +int *callback_singleton; /**< Cx callback singleton */ +stat_var* stat_sar_timeouts; +stat_var* sar_replies_received; +stat_var* sar_replies_response_time; struct tm_binds tmb; @@ -176,7 +179,10 @@ int max_notification_list_size = 0; int notification_processes = 4; /*Number of processes that processes the notification queue*/ -extern reg_notification_list *notification_list; /**< list of notifications for reg to be sent */ +reg_notification_list *notification_list; /**< list of notifications for reg to be sent */ + +IMS_Events_enum_t IMS_Events; +IMS_Registrar_events_enum_t IMS_Registrar_events; #define RCV_NAME "received" str rcv_param = str_init(RCV_NAME); diff --git a/src/modules/ims_registrar_scscf/registrar_notify.h b/src/modules/ims_registrar_scscf/registrar_notify.h index ee1fec52e8..5491c43b5d 100644 --- a/src/modules/ims_registrar_scscf/registrar_notify.h +++ b/src/modules/ims_registrar_scscf/registrar_notify.h @@ -96,13 +96,15 @@ typedef struct { } reg_notification_list; /** Events for subscriptions */ -enum { +typedef enum { IMS_EVENT_NONE, /**< Generic, no event */ IMS_EVENT_REG /**< Registration event */ -} IMS_Events; +} IMS_Events_enum_t; + +extern IMS_Events_enum_t IMS_Events; /** Event types for "reg" to generated notifications after */ -enum { +typedef enum { IMS_REGISTRAR_NONE, /**< no event - donothing */ IMS_REGISTRAR_SUBSCRIBE, /**< Initial SUBSCRIBE - just send all data - this should not be treated though */ IMS_REGISTRAR_UNSUBSCRIBE, /**< Final UnSUBSCRIBE - just send a NOTIFY which will probably fail */ @@ -114,10 +116,11 @@ enum { IMS_REGISTRAR_CONTACT_EXPIRED, /**< A contact has expired and will be removed */ IMS_REGISTRAR_CONTACT_UNREGISTERED, /**< User unregistered with Expires 0 */ IMS_REGISTRAR_CONTACT_UNREGISTERED_IMPLICIT, /**< User unregistered implicitly, ie not via explicit deregister */ -} IMS_Registrar_events; +} IMS_Registrar_events_enum_t; +extern IMS_Registrar_events_enum_t IMS_Registrar_events; -reg_notification_list *notification_list; //< List of pending notifications +extern reg_notification_list *notification_list; //< List of pending notifications int can_subscribe_to_reg(struct sip_msg *msg, char *str1, char *str2); diff --git a/src/modules/ims_registrar_scscf/stats.h b/src/modules/ims_registrar_scscf/stats.h index 3b2c61b964..ea4418f426 100644 --- a/src/modules/ims_registrar_scscf/stats.h +++ b/src/modules/ims_registrar_scscf/stats.h @@ -43,9 +43,9 @@ #include "../../core/counters.h" -stat_var* stat_sar_timeouts; -stat_var* sar_replies_received; -stat_var* sar_replies_response_time; +extern stat_var* stat_sar_timeouts; +extern stat_var* sar_replies_received; +extern stat_var* sar_replies_response_time; int register_stats(); unsigned long get_avg_sar_response_time(); [View Less]

1 0

git:master:325a45e8: tm: safe list iteration in tm_clean_lifetime()
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 325a45e846faae3e5dfa333727d5fab294e44dac URL: https://github.com/kamailio/kamailio/commit/325a45e846faae3e5dfa333727d5fab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T22:29:04+01:00 tm: safe list iteration in tm_clean_lifetime() --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/325a45e846faae3e5dfa333727d5fab…… [View More]

1 0

git:5.3:5b6ce8ef: CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci]
by Henning Westerholt 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 5b6ce8ef92f876b4ec24305592fb285adbb9bce2 URL: https://github.com/kamailio/kamailio/commit/5b6ce8ef92f876b4ec24305592fb285… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-04T20:15:34+01:00 CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci] (cherry picked from commit 116302384110eccc9115ee8cbc96271d893a1f1a) --- Modified: .github/CONTRIBUTING.md --- Diff: … [View More]

1 0

git:master:11630238: CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci]
by Henning Westerholt 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 116302384110eccc9115ee8cbc96271d893a1f1a URL: https://github.com/kamailio/kamailio/commit/116302384110eccc9115ee8cbc96271… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-04T20:14:34+01:00 CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci] --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:5.3:a75be26a: pua: extern declaration of global variable in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: a75be26a5288a2e6c4a6f7d262581e590e3186b1 URL: https://github.com/kamailio/kamailio/commit/a75be26a5288a2e6c4a6f7d262581e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:30:18+01:00 pua: extern declaration of global variable in header file (cherry picked from commit e260447833f616066e0fa23e51e791822b55b039) --- Modified: src/modules/pua/pua.h --- Diff: … [View More]

1 0

git:5.3:f68f5f5a: siputils: contact encoding functions exported to kemi
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: f68f5f5adb504d7ee2d4a2c652fd0bebb8679696 URL: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:30:03+01:00 siputils: contact encoding functions exported to kemi (cherry picked from commit b7c47ce4ceea9ce97431bdd921afa2a59617e1c5) --- Modified: src/modules/siputils/contact_ops.c … [View More]Modified: src/modules/siputils/contact_ops.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… Patch: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index 5183f40ab6..bc48a8771b 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -44,7 +44,7 @@ #include <string.h> -int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr) { contact_body_t *cb; contact_t *c; @@ -85,7 +85,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) /* we visit each contact */ if(c != NULL) { uri = c->uri; - res = encode_uri(uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encoding contact.Code %d\n", res); @@ -103,8 +103,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) c = c->next; uri = c->uri; - res = encode_uri( - uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encode_uri.Code %d\n", res); #ifdef STRICT_CHECK @@ -121,8 +120,20 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) return 1; } - int -decode_contact (struct sip_msg *msg,char *unused1,char *unused2) +int encode_contact(sip_msg_t *msg, char *encoding_prefix, char *public_ip) +{ + str eprefix = STR_NULL; + str eaddr = STR_NULL; + + eprefix.s = encoding_prefix; + eprefix.len = strlen(eprefix.s); + eaddr.s = public_ip; + eaddr.len = strlen(eaddr.s); + + return ki_encode_contact(msg, &eprefix, &eaddr); +} + +int ki_decode_contact(sip_msg_t *msg) { str uri; @@ -177,8 +188,12 @@ decode_contact (struct sip_msg *msg,char *unused1,char *unused2) return 1; } - int -decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) +int decode_contact(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact(msg); +} + +int ki_decode_contact_header(sip_msg_t *msg) { contact_body_t *cb; @@ -255,6 +270,10 @@ decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) } +int decode_contact_header(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact_header(msg); +} int diff --git a/src/modules/siputils/contact_ops.h b/src/modules/siputils/contact_ops.h index ef925c761b..939b80ac6c 100644 --- a/src/modules/siputils/contact_ops.h +++ b/src/modules/siputils/contact_ops.h @@ -64,6 +64,9 @@ struct uri_format typedef struct uri_format contact_fields_t; +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr); +int ki_decode_contact(sip_msg_t *msg); +int ki_decode_contact_header(sip_msg_t *msg); int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip); int decode_contact (struct sip_msg *msg, char *unused1,char *unused2); diff --git a/src/modules/siputils/siputils.c b/src/modules/siputils/siputils.c index aa847ae9c4..e9593da3b4 100644 --- a/src/modules/siputils/siputils.c +++ b/src/modules/siputils/siputils.c @@ -546,6 +546,21 @@ static sr_kemi_t sr_kemi_siputils_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("siputils"), str_init("encode_contact"), + SR_KEMIP_INT, ki_encode_contact, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact"), + SR_KEMIP_INT, ki_decode_contact, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact_header"), + SR_KEMIP_INT, ki_decode_contact_header, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; [View Less]

1 0

git:5.3:68be831a: CONTRIBUTING.md: section for first line of the commit message [skip ci]
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 68be831aa83c09e99b35c55a6ff6d7f21a0502d6 URL: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:53+01:00 CONTRIBUTING.md: section for first line of the commit message [skip ci] - note about [skip ci] flag in first line (cherry picked from commit … [View More]04d082d2a89f8e0d3646856cb81666f9f03fdffa) --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… Patch: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index ea6ba9cdd8..293c0f98a2 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -75,13 +75,20 @@ Please create the commit messages following the GIT convention: * start with one short line, preferably less then 50 chars summarizing the changes (this is referred later as "first line of the commit message") * then one empty line - * then a more detailed description + * then a more detailed description (the "commit message content") + +#### First Line Of The Commit Message #### Think of the first line as of an email "Subject" line. In fact it will be used as "Subject" in the generated commit emails and it will also be used when generating the Changelog (e.g. git log --pretty=oneline). -Please start always with the prefix of the component (subsystem) that is modified by the commit, for example: + +The first line (subjecthas to contain meaningful text about what that commit +does, do not put just a reference to bug tracker or pull request items + +Please start always with the prefix of the component (subsystem) that is modified +by the commit, for example: * `core`: more fixup helper functions * `core`: tcp - support for haproxy protocol * `core`: mem - added faster malloc @@ -90,13 +97,19 @@ Please start always with the prefix of the component (subsystem) that is modifie * `lib`: srutils - critical bug fix for abc case * `kamctl`: added support for management of module xyz +At the end of the first line some CI flags can be added. Available at this +moment: + + * `[skip ci]` - skip continous integration builds for source code, recommended + to be added when updating documentation, example configs or other utilities. + Example: + * `msilo: docs - updated example for m_dump() function [skip ci]` + #### Commit Message Content #### - * first line (subject line) has to contain meaningful text about what that commit - does, do not put just a reference to bug tracker or pull request items - * commit message must describe the changes done by the patch +* commit message must describe the changes done by the patch * other details (e.g., how to reproduce, backtrace, sip packets, ...) belong - to content (comments) of the pull request. Example: + to content (comments) of the pull request. Example of a full commit message: ``` core: added latency_limit_cfg global parameter [View Less]

1 0

git:5.3:70f07adf: ims_qos: more extern declarations in the header files
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 70f07adf5778fdb7015bfce8ffd1b8ae0353d432 URL: https://github.com/kamailio/kamailio/commit/70f07adf5778fdb7015bfce8ffd1b8a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:43+01:00 ims_qos: more extern declarations in the header files (cherry picked from commit 7bea30203b85b7ed17434ee3f301faa0cedcba76) --- Modified: src/modules/ims_qos/ims_qos_mod.c … [View More]

1 0

git:5.3:8cb7d5c0: ims_qos: use extern in header files not to redeclare variables
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 8cb7d5c0bb59be44d55582844bd4021032cf5646 URL: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:04+01:00 ims_qos: use extern in header files not to redeclare variables (cherry picked from commit df5521fcdfc96462eb191b774f242fe1d4616adb) --- Modified: src/modules/ims_qos/… [View More]cdpeventprocessor.h Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/rx_avp.h --- Diff: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… Patch: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… --- diff --git a/src/modules/ims_qos/cdpeventprocessor.h b/src/modules/ims_qos/cdpeventprocessor.h index 4f2b4d688f..8f393656ee 100644 --- a/src/modules/ims_qos/cdpeventprocessor.h +++ b/src/modules/ims_qos/cdpeventprocessor.h @@ -67,8 +67,8 @@ typedef struct { int size; } cdp_cb_event_list_t; -str early_qosrelease_reason; -str confirmed_qosrelease_headers; +extern str early_qosrelease_reason; +extern str confirmed_qosrelease_headers; int init_cdp_cb_event_list(); void destroy_cdp_cb_event_list(); diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 684f3a75c5..2029035415 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -71,7 +71,7 @@ #define macro_name(_rc) #_rc //extern struct tm_binds tmb; -usrloc_api_t ul; +extern usrloc_api_t ul; extern struct ims_qos_counters_h ims_qos_cnts_h; diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index f12def162f..0a9a63b51a 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -55,7 +55,7 @@ #include "../../core/locking.h" struct cdp_binds cdpb; -cdp_avp_bind_t *cdp_avp; +extern cdp_avp_bind_t *cdp_avp; /*this is the parcel to pass for CDP async for AAR*/ typedef struct saved_transaction { diff --git a/src/modules/ims_qos/rx_avp.h b/src/modules/ims_qos/rx_avp.h index c8f81b6f85..55840f3e81 100644 --- a/src/modules/ims_qos/rx_avp.h +++ b/src/modules/ims_qos/rx_avp.h @@ -64,8 +64,8 @@ struct AAA_AVP_List; struct AAAMessage; enum dialog_direction; -int audio_default_bandwidth; -int video_default_bandwidth; +extern int audio_default_bandwidth; +extern int video_default_bandwidth; /*helper*/ [View Less]

1 0

git:5.3:2c2af66a: ims_icscf: stats global variables made extern in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 2c2af66acca5bbe49840683682323745a9f84b1f URL: https://github.com/kamailio/kamailio/commit/2c2af66acca5bbe4984068368232374… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:55+01:00 ims_icscf: stats global variables made extern in header file (cherry picked from commit bfb717fc8504a079066a0fdc09b856a937a7b430) --- Modified: src/modules/ims_icscf/… [View More]

1 0

git:5.3:c720a329: ims_isc: avoid duplicate declaration of isc_ulb by using extern
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: c720a32974f36873dd8dd9f127f5e28a03b5c9c7 URL: https://github.com/kamailio/kamailio/commit/c720a32974f36873dd8dd9f127f5e28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:46+01:00 ims_isc: avoid duplicate declaration of isc_ulb by using extern (cherry picked from commit 32f37cdc876abcd7127993e079c9a0132d1f6460) --- Modified: src/modules/ims_isc/… [View More]

1 0

git:5.3:5090a966: ims_auth: declare extern the stats variables in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 5090a9661d72679358abe25db19e87602c9d2f2f URL: https://github.com/kamailio/kamailio/commit/5090a9661d72679358abe25db19e876… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:36+01:00 ims_auth: declare extern the stats variables in header file (cherry picked from commit 8156dd87a977a011abb9652a997f4ba61eb3e642) --- Modified: src/modules/ims_auth/ims_auth_mod.… [View More]

1 0

git:5.3:f8288611: ims_dialog: declare extern dlg stats structure in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: f828861139a7e6d75cfff54a5106bca00721acee URL: https://github.com/kamailio/kamailio/commit/f828861139a7e6d75cfff54a5106bca… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:25+01:00 ims_dialog: declare extern dlg stats structure in header file (cherry picked from commit 15d5676fd7b6d64616fbf8ebf9517f0d56a47f5c) --- Modified: src/modules/ims_dialog/… [View More]

1 0

git:5.3:fd1d0db7: core: cfg.y - detect use of function call as parameter of another function
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: fd1d0db7c11e453b808e53102a6792082977bece URL: https://github.com/kamailio/kamailio/commit/fd1d0db7c11e453b808e53102a67920… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:12+01:00 core: cfg.y - detect use of function call as parameter of another function - GH #2227 (cherry picked from commit 047fdebff732c847fcde5b066ce1acd5f6c2219a) --- Modified: src/… [View More]

1 0

git:5.3:63aef547: core: cfg.y - init static global variables
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 63aef54729c61755fecfb1df94f6a793853c330c URL: https://github.com/kamailio/kamailio/commit/63aef54729c61755fecfb1df94f6a79… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:03+01:00 core: cfg.y - init static global variables (cherry picked from commit 8c5b92ee638a33e612e68cf85a1d37ab5e5d2c22) --- Modified: src/core/cfg.y --- Diff: https://github.com/… [View More]

1 0

git:5.3:023d3852: cdp: global variables declared extern in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 023d385299b6b0ec6a894d6a893a7cfb5292c5bd URL: https://github.com/kamailio/kamailio/commit/023d385299b6b0ec6a894d6a893a7cf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:27:48+01:00 cdp: global variables declared extern in header file (cherry picked from commit a88cf96b8ba3358c08e0e210f76320f6d7926b7d) --- Modified: src/modules/cdp/diameter_peer.h --- … [View More]

1 0

git:5.3:15ce49ba: sipcapture: declare extern heptime in hep.c and init it to null
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: 15ce49badcd67ec0a4227661b090c4e8318dd3cd URL: https://github.com/kamailio/kamailio/commit/15ce49badcd67ec0a4227661b090c4e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:27:35+01:00 sipcapture: declare extern heptime in hep.c and init it to null (cherry picked from commit 16bc15156ecc8a8f4f66c44b064db854d0e3e4e0) --- Modified: src/modules/sipcapture/hep.c … [View More]

1 0

git:5.3:a7248dd1: sms: removed duplicate declaration of global variables
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: a7248dd187b89cdeab9d72a2de574d4eaab4987d URL: https://github.com/kamailio/kamailio/commit/a7248dd187b89cdeab9d72a2de574d4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:27:24+01:00 sms: removed duplicate declaration of global variables (cherry picked from commit f8284418ea7d16dec970260cb92eb1af35bbf643) --- Modified: src/modules/sms/libsms_modem.c Modified:… [View More]

1 0

git:5.3:c96f7c20: pv: debug messages when setting shv via rpc
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: 5.3 Commit: c96f7c208499179b6931775084edda193e720dd9 URL: https://github.com/kamailio/kamailio/commit/c96f7c208499179b6931775084edda1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:27:10+01:00 pv: debug messages when setting shv via rpc (cherry picked from commit 7f95cd207b5dd56ace92837ad989f234e64a2471) --- Modified: src/modules/pv/pv_shv.c --- Diff: https://… [View More]

1 0

git:master:e2604478: pua: extern declaration of global variable in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: e260447833f616066e0fa23e51e791822b55b039 URL: https://github.com/kamailio/kamailio/commit/e260447833f616066e0fa23e51e7918… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:24:48+01:00 pua: extern declaration of global variable in header file --- Modified: src/modules/pua/pua.h --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:b7c47ce4: siputils: contact encoding functions exported to kemi
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: b7c47ce4ceea9ce97431bdd921afa2a59617e1c5 URL: https://github.com/kamailio/kamailio/commit/b7c47ce4ceea9ce97431bdd921afa2a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:19:40+01:00 siputils: contact encoding functions exported to kemi --- Modified: src/modules/siputils/contact_ops.c Modified: src/modules/siputils/contact_ops.h Modified: src/modules/… [View More]siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/b7c47ce4ceea9ce97431bdd921afa2a… Patch: https://github.com/kamailio/kamailio/commit/b7c47ce4ceea9ce97431bdd921afa2a… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index 5183f40ab6..bc48a8771b 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -44,7 +44,7 @@ #include <string.h> -int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr) { contact_body_t *cb; contact_t *c; @@ -85,7 +85,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) /* we visit each contact */ if(c != NULL) { uri = c->uri; - res = encode_uri(uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encoding contact.Code %d\n", res); @@ -103,8 +103,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) c = c->next; uri = c->uri; - res = encode_uri( - uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encode_uri.Code %d\n", res); #ifdef STRICT_CHECK @@ -121,8 +120,20 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) return 1; } - int -decode_contact (struct sip_msg *msg,char *unused1,char *unused2) +int encode_contact(sip_msg_t *msg, char *encoding_prefix, char *public_ip) +{ + str eprefix = STR_NULL; + str eaddr = STR_NULL; + + eprefix.s = encoding_prefix; + eprefix.len = strlen(eprefix.s); + eaddr.s = public_ip; + eaddr.len = strlen(eaddr.s); + + return ki_encode_contact(msg, &eprefix, &eaddr); +} + +int ki_decode_contact(sip_msg_t *msg) { str uri; @@ -177,8 +188,12 @@ decode_contact (struct sip_msg *msg,char *unused1,char *unused2) return 1; } - int -decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) +int decode_contact(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact(msg); +} + +int ki_decode_contact_header(sip_msg_t *msg) { contact_body_t *cb; @@ -255,6 +270,10 @@ decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) } +int decode_contact_header(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact_header(msg); +} int diff --git a/src/modules/siputils/contact_ops.h b/src/modules/siputils/contact_ops.h index ef925c761b..939b80ac6c 100644 --- a/src/modules/siputils/contact_ops.h +++ b/src/modules/siputils/contact_ops.h @@ -64,6 +64,9 @@ struct uri_format typedef struct uri_format contact_fields_t; +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr); +int ki_decode_contact(sip_msg_t *msg); +int ki_decode_contact_header(sip_msg_t *msg); int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip); int decode_contact (struct sip_msg *msg, char *unused1,char *unused2); diff --git a/src/modules/siputils/siputils.c b/src/modules/siputils/siputils.c index aa847ae9c4..e9593da3b4 100644 --- a/src/modules/siputils/siputils.c +++ b/src/modules/siputils/siputils.c @@ -546,6 +546,21 @@ static sr_kemi_t sr_kemi_siputils_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("siputils"), str_init("encode_contact"), + SR_KEMIP_INT, ki_encode_contact, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact"), + SR_KEMIP_INT, ki_decode_contact, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact_header"), + SR_KEMIP_INT, ki_decode_contact_header, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } }; [View Less]

1 0

git:master:04d082d2: CONTRIBUTING.md: section for first line of the commit message [skip ci]
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 04d082d2a89f8e0d3646856cb81666f9f03fdffa URL: https://github.com/kamailio/kamailio/commit/04d082d2a89f8e0d3646856cb81666f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T11:39:02+01:00 CONTRIBUTING.md: section for first line of the commit message [skip ci] - note about [skip ci] flag in first line --- Modified: .github/CONTRIBUTING.md --- Diff: https://… [View More]github.com/kamailio/kamailio/commit/04d082d2a89f8e0d3646856cb81666f… Patch: https://github.com/kamailio/kamailio/commit/04d082d2a89f8e0d3646856cb81666f… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index f90d1c492b..fca94e33de 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -81,13 +81,20 @@ Please create the commit messages following the GIT convention: * start with one short line, preferably less then 50 chars summarizing the changes (this is referred later as "first line of the commit message") * then one empty line - * then a more detailed description + * then a more detailed description (the "commit message content") + +#### First Line Of The Commit Message #### Think of the first line as of an email "Subject" line. In fact it will be used as "Subject" in the generated commit emails and it will also be used when generating the Changelog (e.g. git log --pretty=oneline). -Please start always with the prefix of the component (subsystem) that is modified by the commit, for example: + +The first line (subjecthas to contain meaningful text about what that commit +does, do not put just a reference to bug tracker or pull request items + +Please start always with the prefix of the component (subsystem) that is modified +by the commit, for example: * `core`: more fixup helper functions * `core`: tcp - support for haproxy protocol * `core`: mem - added faster malloc @@ -96,13 +103,19 @@ Please start always with the prefix of the component (subsystem) that is modifie * `lib`: srutils - critical bug fix for abc case * `kamctl`: added support for management of module xyz +At the end of the first line some CI flags can be added. Available at this +moment: + + * `[skip ci]` - skip continous integration builds for source code, recommended + to be added when updating documentation, example configs or other utilities. + Example: + * `msilo: docs - updated example for m_dump() function [skip ci]` + #### Commit Message Content #### - * first line (subject line) has to contain meaningful text about what that commit - does, do not put just a reference to bug tracker or pull request items - * commit message must describe the changes done by the patch +* commit message must describe the changes done by the patch * other details (e.g., how to reproduce, backtrace, sip packets, ...) belong - to content (comments) of the pull request. Example: + to content (comments) of the pull request. Example of a full commit message: ``` core: added latency_limit_cfg global parameter [View Less]

1 0

git:master:7bea3020: ims_qos: more extern declarations in the header files
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 7bea30203b85b7ed17434ee3f301faa0cedcba76 URL: https://github.com/kamailio/kamailio/commit/7bea30203b85b7ed17434ee3f301faa… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T11:14:26+01:00 ims_qos: more extern declarations in the header files --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/… [View More]

1 0

git:master:a8395274: modules: readme files regenerated - acc_json ... [skip ci]
by Kamailio Dev 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: a83952746263725500d92772038b64a3d58db3a0 URL: https://github.com/kamailio/kamailio/commit/a83952746263725500d92772038b64a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-04T10:46:17+01:00 modules: readme files regenerated - acc_json ... [skip ci] --- Modified: src/modules/acc_json/README Modified: src/modules/tm/README Modified: src/modules/usrloc/README Modified: src/… [View More]

1 0

git:master:8d5ea6fb: Merge pull request #2238 from btriller/doc-fixes
by GitHub 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 8d5ea6fbbc1d213c2f284720977dc67b8bb89b49 URL: https://github.com/kamailio/kamailio/commit/8d5ea6fbbc1d213c2f284720977dc67… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-03-04T10:42:29+01:00 Merge pull request #2238 from btriller/doc-fixes Doc fixes --- Modified: src/modules/acc_json/doc/acc_json_admin.xml Modified: src/modules/tm/doc/params.xml Modified: src/modules/usrloc/doc/… [View More]

1 0

[kamailio/kamailio] Doc fixes (#2238)
by Bastian Triller 04 Mar '20

04 Mar '20

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2238 -- Commit Summary -- * acc_json: doc fixes * usrloc: doc fixes * tm: docs - fix title for parameter event_callback_lres_sent * websocket: docs - fix title for parameter rm_delay_interval -- File Changes -- M src/modules/acc_json/doc/acc_json_admin.xml (29) M src/modules/tm/doc/params.xml (2) M src/modules/usrloc/doc/usrloc_admin.xml (22) M src/modules/websocket/doc/websocket_admin.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2238.patch https://github.com/kamailio/kamailio/pull/2238.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2238 [View Less]

2 2

git:master:c4a566bf: websocket: docs - fix title for parameter rm_delay_interval
by Bastian Triller 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: c4a566bf8df05b55a690a4ad9ea5f5dfe8961e0e URL: https://github.com/kamailio/kamailio/commit/c4a566bf8df05b55a690a4ad9ea5f5d… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Bastian Triller <bastian.triller(a)gmail.com> Date: 2020-03-04T10:26:42+01:00 websocket: docs - fix title for parameter rm_delay_interval --- Modified: src/modules/websocket/doc/websocket_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:32a21b5b: tm: docs - fix title for parameter event_callback_lres_sent
by Bastian Triller 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 32a21b5bd17309175ba99186629fa0d4e6b21fa7 URL: https://github.com/kamailio/kamailio/commit/32a21b5bd17309175ba99186629fa0d… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Bastian Triller <bastian.triller(a)gmail.com> Date: 2020-03-04T10:26:42+01:00 tm: docs - fix title for parameter event_callback_lres_sent --- Modified: src/modules/tm/doc/params.xml --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:305ba1b2: usrloc: doc fixes
by Bastian Triller 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 305ba1b23bae19a4042c3e8fa88451b47ac69ff5 URL: https://github.com/kamailio/kamailio/commit/305ba1b23bae19a4042c3e8fa88451b… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Bastian Triller <bastian.triller(a)gmail.com> Date: 2020-03-04T10:26:12+01:00 usrloc: doc fixes * add doc for parameter reg_id_column * fix title for parameter partition_column --- Modified: src/modules/usrloc/doc/usrloc_admin.xml --- Diff: https://… [View More]

1 0

git:master:81a9c09b: acc_json: doc fixes
by Bastian Triller 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: 81a9c09b7b25afc6bd9d0854c1bf7aa3c34d6b82 URL: https://github.com/kamailio/kamailio/commit/81a9c09b7b25afc6bd9d0854c1bf7aa… Author: Bastian Triller <bastian.triller(a)gmail.com> Committer: Bastian Triller <bastian.triller(a)gmail.com> Date: 2020-03-04T10:24:20+01:00 acc_json: doc fixes * fix parameter names acc_output_mqueue and acc_output_syslog * add missing parameter cdr_output_syslog --- Modified: src/modules/acc_json/doc/… [View More]acc_json_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/81a9c09b7b25afc6bd9d0854c1bf7aa… Patch: https://github.com/kamailio/kamailio/commit/81a9c09b7b25afc6bd9d0854c1bf7aa… --- diff --git a/src/modules/acc_json/doc/acc_json_admin.xml b/src/modules/acc_json/doc/acc_json_admin.xml index 70b6df1d2b..ae0f9d68c4 100644 --- a/src/modules/acc_json/doc/acc_json_admin.xml +++ b/src/modules/acc_json/doc/acc_json_admin.xml @@ -69,7 +69,7 @@ <title><varname>acc_flag</varname> (integer)</title> <para> Request flag which needs to be set to account a transaction in acc_json. - See output_mqueue and output_syslog + See acc_output_mqueue and acc_output_syslog </para> <para> Default value is not-set (no flag). @@ -88,7 +88,7 @@ modparam("acc_json", "acc_flag", 2) <title><varname>acc_missed_flag</varname> (integer)</title> <para> Request flag which needs to be set to account missed calls in acc_json. - See output_mqueue and output_syslog + See acc_output_mqueue and acc_output_syslog </para> <para> Default value is not-set (no flag). @@ -181,8 +181,8 @@ modparam("acc_json", "acc_time_format", "%Y/%m/%d %H:%M:%S") </example> </section> - <section id="acc_json.p.output_mqueue"> - <title><varname>output_mqueue</varname> (integer)</title> + <section id="acc_json.p.acc_output_mqueue"> + <title><varname>acc_output_mqueue</varname> (integer)</title> <para> Requires the mqueue module. The acc module will queue json acc events in the specified mqueue. @@ -195,13 +195,13 @@ modparam("acc_json", "acc_time_format", "%Y/%m/%d %H:%M:%S") Default value is not-set mqueue will not be required. </para> <example> - <title>output_mqueue usage example</title> + <title>acc_output_mqueue usage example</title> <programlisting format="linespecific"> ... # example using json_mqueue/http_client to publish to NSQD max_while_loops=100000 modparam("mqueue", "mqueue", "name=acc_events;size=100000") -modparam("acc_json", "output_mqueue", "acc_events") +modparam("acc_json", "acc_output_mqueue", "acc_events") modparam("acc_json", "acc_flag", 2) modparam("acc_json", "acc_extra", "caller_ip_port=$avp(caller_ip_port);") modparam("rtimer", "timer", "name=nsqt;interval=1;mode=1;") @@ -234,8 +234,8 @@ route[RUN_ACC_PUBLISH] { </example> </section> - <section id="acc_json.p.output_syslog"> - <title><varname>output_syslog</varname> (integer)</title> + <section id="acc_json.p.acc_output_syslog"> + <title><varname>acc_output_syslog</varname> (integer)</title> <para> Control if the output of acc json should be sent to syslog. This is not dependent on Kamailio global logging settings, @@ -246,10 +246,10 @@ route[RUN_ACC_PUBLISH] { Default value is not-set (no flag). </para> <example> - <title>output_syslog example</title> + <title>acc_output_syslog example</title> <programlisting format="linespecific"> ... -modparam("acc_json", "output_syslog", 1) +modparam("acc_json", "acc_output_syslog", 1) modparam("acc_json", "acc_log_level", 2) modparam("acc_json", "acc_log_facility", "LOG_DAEMON") ... @@ -408,8 +408,13 @@ route[RUN_CDR_PUBLISH] { </programlisting> </example> </section> - -<section id="acc_json.p.cdr_log_facility"> + <section id="acc_json.p.cdr_output_syslog"> + <title><varname>cdr_output_syslog</varname> (integer)</title> + <para> + The acc module will log json cdr events to syslog. + </para> + </section> + <section id="acc_json.p.cdr_log_facility"> <title><varname>cdr_log_facility</varname> (integer)</title> <para> Log facility to which accounting messages are issued to syslog. [View Less]

1 0

git:master:df5521fc: ims_qos: use extern in header files not to redeclare variables
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: df5521fcdfc96462eb191b774f242fe1d4616adb URL: https://github.com/kamailio/kamailio/commit/df5521fcdfc96462eb191b774f242fe… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T08:28:30+01:00 ims_qos: use extern in header files not to redeclare variables --- Modified: src/modules/ims_qos/cdpeventprocessor.h Modified: src/modules/ims_qos/rx_aar.c Modified: src/… [View More]

1 0

git:master:bfb717fc: ims_icscf: stats global variables made extern in header file
by Daniel-Constantin Mierla 04 Mar '20

04 Mar '20

Module: kamailio Branch: master Commit: bfb717fc8504a079066a0fdc09b856a937a7b430 URL: https://github.com/kamailio/kamailio/commit/bfb717fc8504a079066a0fdc09b856a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T07:19:57+01:00 ims_icscf: stats global variables made extern in header file --- Modified: src/modules/ims_icscf/ims_icscf_mod.c Modified: src/modules/ims_icscf/stats.h --- Diff: https://… [View More]

1 0

MRCP kamailio module (for use with rtpengine)
by Dmitriy Borisov 03 Mar '20

03 Mar '20

Hello! I want to implement kamailio module for MRCP interaction. I need it for automatic machine detection (AMD) system. I will be grateful for any help and have some initial questions: 1. Is it interesting for anyone? 2. Now I reading http://www.asipto.com/pub/kamailio-devel-guide/ guide. Is it the newest one or I can find something more actual? I want to implement such scheme: https://unimrcp.org/ea/index.htm?goto=2:1:30 Where kamailio will be on place of PBX, rtp-sender will be on place … [View More]

2 1

[kamailio/kamailio] New branch in DNS SRV failover is using wrong source socket (#2152)
by Thomas Lobker 03 Mar '20

03 Mar '20

### Description When relaying an `INVITE` from a Kamailio proxy to an interconnect we are using DNS SRV records for load-balancing and failover. The proxy is listening on both a private interface and a public interface with an rfc1918 (ie. `10.0.0.14`) and a public IP address (ie. `185.0.0.34`) respectively. The first branch (before DNS SRV failover) is working as expected. The message will be relayed from the received socket (`185.0.0.34`) to the interconnect. When this branch results in a … [View More]timeout, the proxy will try to do DNS SRV failover. This new branch and any subsequent branches will no longer use the initial received socket as source. In our case we see that the private address (`10.0.0.14`) is now being used as source address. ### Troubleshooting #### Reproduction DNS SRV: ``` _sip._udp.transit.net. SRV 10 10 5060 transit1.net. _sip._udp.transit.net. SRV 20 10 5060 transit2.net. transit1.net. A 185.10.20.30 transit2.net. A 185.10.20.31 ``` Kamailio: ``` $du = "sip:transit.net;transport=udp"; xinfo("Relaying [$rm] request: [$ru] with Call-ID [$ci]"); t_set_fr(0, 1000); if (not t_relay()) { sl_reply_error(); } ``` Network flow: ``` 12:30:00 INVITE udp:10.0.0.18:5060 => udp:185.0.0.34:5060 (internal request to proxy) 12:30:00 INVITE udp:185.0.0.34:5060 => udp:185.10.20.30:5060 (relaying from proxy to interconnect) ^^^^^^^^^^ (request times out after 1 second, proxy will do a failover to the next endpoint) 12:30:01 INVITE udp:10.0.0.14:5060 => udp:185.10.20.31:5060 (relaying to next interconnect address) ^^^^^^^^^ ``` #### Log Messages Attempt to see where it goes wrong: ``` onsend_route { xinfo("[$RAut] [$Rut] [$sas]\n"); xinfo("$snd(buf)\n"); } ``` ``` INFO: [sip:185.0.0.34:5060;transport=udp] [sip:185.0.0.34:5060;transport=udp] [udp:10.0.0.18:5060] INFO: INVITE sip:+1234567890@transit.net;user=phone SIP/2.0#015#012Record-Route: <sip:185.0.0.34;lr;ftag=tDr7m6erX1N3D>#015#012Via: SIP/2.0/UDP 10.0.0.14;branch=z9hG4bKafe7.7fb590e263fa44677514193a6a1156ce.1#015#012Via: SIP/2.0/UDP 10.0.0.18;received=10.0.0.18;rport=5060;branch=z9hG4bK6t59a17N60FcB ... ``` So the `Record-Route` seems to be correct, but the top most `Via` header shows the private IP address. The message is being sent from the private IP address as well and never reaches the second address from the interconnect. ### Possible Solutions A workaround to add `$fs = "udp:185.0.0.34:5060"` in the `onsend_route` seems to be effective. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.2.3 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 7.4.0 ``` * **Operating System**: ``` Ubuntu 18.04 LTS Linux proxy4 4.15.0-64-generic #73-Ubuntu SMP Thu Sep 12 13:16:13 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2152 [View Less]

2 11

git:master:32f37cdc: ims_isc: avoid duplicate declaration of isc_ulb by using extern
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 32f37cdc876abcd7127993e079c9a0132d1f6460 URL: https://github.com/kamailio/kamailio/commit/32f37cdc876abcd7127993e079c9a01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T17:26:58+01:00 ims_isc: avoid duplicate declaration of isc_ulb by using extern --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,stretch #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,stretch #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,bionic #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,bionic #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,jessie #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,jessie #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,buster #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,buster #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » amd64,precise #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

Jenkins build is back to normal : kamailiodev-nightly-binaries » i386,precise #1595
by kamailio＠sipwise.com 03 Mar '20

03 Mar '20

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 0

git:master:8156dd87: ims_auth: declare extern the stats variables in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 8156dd87a977a011abb9652a997f4ba61eb3e642 URL: https://github.com/kamailio/kamailio/commit/8156dd87a977a011abb9652a997f4ba… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T13:28:30+01:00 ims_auth: declare extern the stats variables in header file --- Modified: src/modules/ims_auth/ims_auth_mod.c Modified: src/modules/ims_auth/stats.h --- Diff: https://… [View More]

1 0

git:master:15d5676f: ims_dialog: declare extern dlg stats structure in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 15d5676fd7b6d64616fbf8ebf9517f0d56a47f5c URL: https://github.com/kamailio/kamailio/commit/15d5676fd7b6d64616fbf8ebf9517f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:40:40+01:00 ims_dialog: declare extern dlg stats structure in header file --- Modified: src/modules/ims_dialog/dlg_ng_stats.c Modified: src/modules/ims_dialog/dlg_ng_stats.h --- Diff: … [View More]

1 0

git:master:047fdebf: core: cfg.y - detect use of function call as parameter of another function
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 047fdebff732c847fcde5b066ce1acd5f6c2219a URL: https://github.com/kamailio/kamailio/commit/047fdebff732c847fcde5b066ce1acd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:30:04+01:00 core: cfg.y - detect use of function call as parameter of another function - GH #2227 --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:8c5b92ee: core: cfg.y - init static global variables
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 8c5b92ee638a33e612e68cf85a1d37ab5e5d2c22 URL: https://github.com/kamailio/kamailio/commit/8c5b92ee638a33e612e68cf85a1d37a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T11:01:53+01:00 core: cfg.y - init static global variables --- Modified: src/core/cfg.y --- Diff: https://github.com/kamailio/kamailio/commit/8c5b92ee638a33e612e68cf85a1d37a… Patch: https:… [View More]

1 0

git:master:a88cf96b: cdp: global variables declared extern in header file
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: a88cf96b8ba3358c08e0e210f76320f6d7926b7d URL: https://github.com/kamailio/kamailio/commit/a88cf96b8ba3358c08e0e210f76320f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T10:34:02+01:00 cdp: global variables declared extern in header file --- Modified: src/modules/cdp/diameter_peer.h --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]

1 0

git:master:16bc1515: sipcapture: declare extern heptime in hep.c and init it to null
by Daniel-Constantin Mierla 03 Mar '20

03 Mar '20

Module: kamailio Branch: master Commit: 16bc15156ecc8a8f4f66c44b064db854d0e3e4e0 URL: https://github.com/kamailio/kamailio/commit/16bc15156ecc8a8f4f66c44b064db85… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-03T09:11:59+01:00 sipcapture: declare extern heptime in hep.c and init it to null --- Modified: src/modules/sipcapture/hep.c Modified: src/modules/sipcapture/sipcapture.c --- Diff: https://… [View More]

1 0

git:master:f8284418: sms: removed duplicate declaration of global variables
by Daniel-Constantin Mierla 02 Mar '20

02 Mar '20

Module: kamailio Branch: master Commit: f8284418ea7d16dec970260cb92eb1af35bbf643 URL: https://github.com/kamailio/kamailio/commit/f8284418ea7d16dec970260cb92eb1a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-02T10:21:23+01:00 sms: removed duplicate declaration of global variables --- Modified: src/modules/sms/libsms_modem.c Modified: src/modules/sms/sms_funcs.c --- Diff: https://github.com/… [View More]

1 0

[kamailio/kamailio] [kamailio 5.2.5] Wrong send socket on a multi homed proxy (#2181)
by vitalikvoip 02 Mar '20

02 Mar '20

### Description Kamailio fails to forward in-dialog request over TCP/TLS/WS/WSS connection. ### Troubleshooting kamailio 5.2 branch has a commit 09ac3e47ef79dbd599b7dec5b84ae3b792f025ed cherry picked from master branch. It makes sense for master because get_send_socket2() behavior has changed and function became smarter and also there were some patches to propagate connection it to the uac structure. After applying this patch to 5.2.x kamailio searches for an outgoing socket, receives the … [View More]

3 6

git:5.2:ac37cb04: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.2 Commit: ac37cb04c0b5ca153342f44d7d7fd17a633afddd URL: https://github.com/kamailio/kamailio/commit/ac37cb04c0b5ca153342f44d7d7fd17… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-02T09:31:54+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/pua_dialoginfo/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]ac37cb04c0b5ca153342f44d7d7fd17… Patch: https://github.com/kamailio/kamailio/commit/ac37cb04c0b5ca153342f44d7d7fd17… --- diff --git a/src/modules/pua_dialoginfo/README b/src/modules/pua_dialoginfo/README index a8eecbb95a..e38c0e0eb5 100644 --- a/src/modules/pua_dialoginfo/README +++ b/src/modules/pua_dialoginfo/README @@ -48,10 +48,10 @@ Phil Lavin 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -98,10 +98,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -281,10 +281,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 5.1. include_callid (int) @@ -422,7 +422,7 @@ modparam("pua_dialoginfo", "disable_callee_publish_flag", 10) modparam("pua_dialoginfo", "use_pubruri_avps", 1) ... -5.11. pubruri_caller_avp (int) +5.11. pubruri_caller_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the caller (entity=caller) are sent using the @@ -438,7 +438,7 @@ modparam("pua_dialoginfo", "use_pubruri_avps", 1) modparam("pua_dialoginfo", "pubruri_caller_avp", "$avp(s:puburis_caller)") ... -5.12. pubruri_callee_avp (int) +5.12. pubruri_callee_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the callee (entity=callee) are sent using the @@ -468,7 +468,7 @@ modparam("pua_dialoginfo", "pubruri_callee_avp", "$avp(s:puburis_callee)") modparam("pua_dialoginfo", "pubruri_caller_dlg_var", "pubruri_caller") ... -5.14. pubruri_callee_dlg_var (int) +5.14. pubruri_callee_dlg_var (str) Must be set to the name of dialog variable where to store the URI for callee, used to send the notifications. This is needed to restored the [View Less]

1 0

git:5.3:0bed10f2: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.3 Commit: 0bed10f2ad80d192c50885ef3f7a948f1ba9322e URL: https://github.com/kamailio/kamailio/commit/0bed10f2ad80d192c50885ef3f7a948… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-02T09:31:40+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/pua_dialoginfo/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]0bed10f2ad80d192c50885ef3f7a948… Patch: https://github.com/kamailio/kamailio/commit/0bed10f2ad80d192c50885ef3f7a948… --- diff --git a/src/modules/pua_dialoginfo/README b/src/modules/pua_dialoginfo/README index a8eecbb95a..e38c0e0eb5 100644 --- a/src/modules/pua_dialoginfo/README +++ b/src/modules/pua_dialoginfo/README @@ -48,10 +48,10 @@ Phil Lavin 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -98,10 +98,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -281,10 +281,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 5.1. include_callid (int) @@ -422,7 +422,7 @@ modparam("pua_dialoginfo", "disable_callee_publish_flag", 10) modparam("pua_dialoginfo", "use_pubruri_avps", 1) ... -5.11. pubruri_caller_avp (int) +5.11. pubruri_caller_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the caller (entity=caller) are sent using the @@ -438,7 +438,7 @@ modparam("pua_dialoginfo", "use_pubruri_avps", 1) modparam("pua_dialoginfo", "pubruri_caller_avp", "$avp(s:puburis_caller)") ... -5.12. pubruri_callee_avp (int) +5.12. pubruri_callee_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the callee (entity=callee) are sent using the @@ -468,7 +468,7 @@ modparam("pua_dialoginfo", "pubruri_callee_avp", "$avp(s:puburis_callee)") modparam("pua_dialoginfo", "pubruri_caller_dlg_var", "pubruri_caller") ... -5.14. pubruri_callee_dlg_var (int) +5.14. pubruri_callee_dlg_var (str) Must be set to the name of dialog variable where to store the URI for callee, used to send the notifications. This is needed to restored the [View Less]

1 0

git:master:1ed7e896: modules: readme files regenerated - pua_dialoginfo ... [skip ci]
by Kamailio Dev 02 Mar '20

02 Mar '20

Module: kamailio Branch: master Commit: 1ed7e896f054a4c40dc1d95263f73c0aa1fcd29c URL: https://github.com/kamailio/kamailio/commit/1ed7e896f054a4c40dc1d95263f73c0… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-02T09:31:22+01:00 modules: readme files regenerated - pua_dialoginfo ... [skip ci] --- Modified: src/modules/pua_dialoginfo/README --- Diff: https://github.com/kamailio/kamailio/commit/… [View More]1ed7e896f054a4c40dc1d95263f73c0… Patch: https://github.com/kamailio/kamailio/commit/1ed7e896f054a4c40dc1d95263f73c0… --- diff --git a/src/modules/pua_dialoginfo/README b/src/modules/pua_dialoginfo/README index a8eecbb95a..e38c0e0eb5 100644 --- a/src/modules/pua_dialoginfo/README +++ b/src/modules/pua_dialoginfo/README @@ -48,10 +48,10 @@ Phil Lavin 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -98,10 +98,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 6. Functions @@ -281,10 +281,10 @@ Chapter 1. Admin Guide 5.8. disable_caller_publish_flag (int) 5.9. disable_callee_publish_flag (int) 5.10. use_pubruri_avps (int) - 5.11. pubruri_caller_avp (int) - 5.12. pubruri_callee_avp (int) + 5.11. pubruri_caller_avp (str) + 5.12. pubruri_callee_avp (str) 5.13. pubruri_caller_dlg_var (str) - 5.14. pubruri_callee_dlg_var (int) + 5.14. pubruri_callee_dlg_var (str) 5.15. callee_trying (int) 5.1. include_callid (int) @@ -422,7 +422,7 @@ modparam("pua_dialoginfo", "disable_callee_publish_flag", 10) modparam("pua_dialoginfo", "use_pubruri_avps", 1) ... -5.11. pubruri_caller_avp (int) +5.11. pubruri_caller_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the caller (entity=caller) are sent using the @@ -438,7 +438,7 @@ modparam("pua_dialoginfo", "use_pubruri_avps", 1) modparam("pua_dialoginfo", "pubruri_caller_avp", "$avp(s:puburis_caller)") ... -5.12. pubruri_callee_avp (int) +5.12. pubruri_callee_avp (str) If use_pubruri_avps is enabled, PUBLISH-requests reporting dialog-information about the callee (entity=callee) are sent using the @@ -468,7 +468,7 @@ modparam("pua_dialoginfo", "pubruri_callee_avp", "$avp(s:puburis_callee)") modparam("pua_dialoginfo", "pubruri_caller_dlg_var", "pubruri_caller") ... -5.14. pubruri_callee_dlg_var (int) +5.14. pubruri_callee_dlg_var (str) Must be set to the name of dialog variable where to store the URI for callee, used to send the notifications. This is needed to restored the [View Less]

1 0

git:5.2:3dee7c64: pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.2 Commit: 3dee7c6488eb143141becf47e0edd2f3e6ce3cef URL: https://github.com/kamailio/kamailio/commit/3dee7c6488eb143141becf47e0edd2f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:27:46+01:00 pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type (cherry picked from commit cd94a88d21c6d649d63791ba509845a38a6eb76b) --- Modified: src/modules/pua_dialoginfo/doc/… [View More]

1 0

git:5.2:6ece7d82: pua_dialoginfo: fix doc for pubruri_callee_dlg_var type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.2 Commit: 6ece7d8288aca10a6d653f164df5b386ed3eb63e URL: https://github.com/kamailio/kamailio/commit/6ece7d8288aca10a6d653f164df5b38… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:27:42+01:00 pua_dialoginfo: fix doc for pubruri_callee_dlg_var type (cherry picked from commit ee34fa46d008426f710c38bf247f4dac9e11bfe7) --- Modified: src/modules/pua_dialoginfo/doc/… [View More]

1 0

git:5.3:34dffb14: pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.3 Commit: 34dffb148e2fa3e9d354532817acf490ac8c8e95 URL: https://github.com/kamailio/kamailio/commit/34dffb148e2fa3e9d354532817acf49… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:27:14+01:00 pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type (cherry picked from commit cd94a88d21c6d649d63791ba509845a38a6eb76b) --- Modified: src/modules/pua_dialoginfo/doc/… [View More]

1 0

git:5.3:e2d4024a: pua_dialoginfo: fix doc for pubruri_callee_dlg_var type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.3 Commit: e2d4024a73306b3efc28b321e5d5d32b96601278 URL: https://github.com/kamailio/kamailio/commit/e2d4024a73306b3efc28b321e5d5d32… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:26:54+01:00 pua_dialoginfo: fix doc for pubruri_callee_dlg_var type (cherry picked from commit ee34fa46d008426f710c38bf247f4dac9e11bfe7) --- Modified: src/modules/pua_dialoginfo/doc/… [View More]

1 0

git:master:cd94a88d: pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: master Commit: cd94a88d21c6d649d63791ba509845a38a6eb76b URL: https://github.com/kamailio/kamailio/commit/cd94a88d21c6d649d63791ba509845a… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:24:29+01:00 pua_dialoginfo: fix doc for puburi_calle[e|r]_avp type --- Modified: src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml --- Diff: https://github.com/kamailio/… [View More]

1 0

git:master:ee34fa46: pua_dialoginfo: fix doc for pubruri_callee_dlg_var type
by Victor Seva 02 Mar '20

02 Mar '20

Module: kamailio Branch: master Commit: ee34fa46d008426f710c38bf247f4dac9e11bfe7 URL: https://github.com/kamailio/kamailio/commit/ee34fa46d008426f710c38bf247f4da… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-03-02T09:20:22+01:00 pua_dialoginfo: fix doc for pubruri_callee_dlg_var type --- Modified: src/modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml --- Diff: https://github.com/kamailio/… [View More]

1 0

git:5.3:e16ba9fe: Revert "tm: set send socket flag when computing the destination and local socket is found"
by Daniel-Constantin Mierla 02 Mar '20

02 Mar '20

Module: kamailio Branch: 5.3 Commit: e16ba9fe6b9e1a4c70b42c5822c7a05051da88c0 URL: https://github.com/kamailio/kamailio/commit/e16ba9fe6b9e1a4c70b42c5822c7a05… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-02T09:02:33+01:00 Revert "tm: set send socket flag when computing the destination and local socket is found" This reverts commit 8d608d1c3ed0fe4c69cb02868b746cd0497dd1f5. --- Modified: src/… [View More]

1 0

git:master:dd6e2fd7: Revert "tm: set send socket flag when computing the destination and local socket is found"
by Daniel-Constantin Mierla 02 Mar '20

02 Mar '20

Module: kamailio Branch: master Commit: dd6e2fd7740f351ef3acbd4d36d7e4546ca10ded URL: https://github.com/kamailio/kamailio/commit/dd6e2fd7740f351ef3acbd4d36d7e45… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-02T09:01:37+01:00 Revert "tm: set send socket flag when computing the destination and local socket is found" This reverts commit 8d608d1c3ed0fe4c69cb02868b746cd0497dd1f5. --- Modified: src/… [View More]

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2020