sr-dev March 2020

sr-dev@lists.kamailio.org

27 participants
473 discussions

git:master:e65ce2fd: pike: docs - aligned ip tree example

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: e65ce2fd407626acc89879033a2114cf521457dc URL: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T15:23:10+01:00 pike: docs - aligned ip tree example --- Modified: src/modules/pike/doc/pike_devel.xml --- Diff: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… Patch: https://github.com/kamailio/kamailio/commit/e65ce2fd407626acc89879033a2114c… --- diff --git a/src/modules/pike/doc/pike_devel.xml b/src/modules/pike/doc/pike_devel.xml index 3b96276da5..950b54cf90 100644 --- a/src/modules/pike/doc/pike_devel.xml +++ b/src/modules/pike/doc/pike_devel.xml @@ -19,10 +19,10 @@ <example> <title>Tree of &ip; addresses</title> <programlisting format="linespecific"> - / 193 - 175 - 132 - 164 -tree root / \ 142 - \ 195 - 37 - 78 - 163 - \ 79 - 134 + / 193 - 175 - 132 - 164 +tree root / \ - 142 + \ 195 - 37 - 78 - 163 + \ - 79 - 134 </programlisting> </example> <para>

4 years, 8 months

git:master:ca33c2de: modules: readme files regenerated - sst ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: ca33c2deb73e4532488ac8181622f2c7f723bd5f URL: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-03-24T15:01:12+01:00 modules: readme files regenerated - sst ... [skip ci] --- Modified: src/modules/sst/README --- Diff: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… Patch: https://github.com/kamailio/kamailio/commit/ca33c2deb73e4532488ac8181622f2c… --- diff --git a/src/modules/sst/README b/src/modules/sst/README index 725cffc95d..3444863563 100644 --- a/src/modules/sst/README +++ b/src/modules/sst/README @@ -219,20 +219,36 @@ modparam("sst", "min_se", 2400) 4.3. timeout_avp (string) - This parameter MUST be set to the same value as the dialog module - parameter of the same name. If this parameter is NOT set, the sst - module will not do anything! + This parameter must be set to the same value as the dialog module + parameter of the same name, when it is wanted to update dialog timeout + using Session-Expires header value. If this parameter is not set, the + sst module will not update dialog timeout. - This is how the sst module knows which avp in the dialog module it has - to change with the new expire value. + With this parameter, the sst module knows which avp is expected by the + dialog module to change to a new expire value. - Default value is “NULL!” it is not set by default. + Note that the avp is set only for requests within dialog, not for the + initial INVITE. For this one, it can be done using script operations, + see the next example for such solution. + + Default value is “NULL” (not set by default). Example 1.4. Set timeout_avp parameter ... -modparam("dialog", "timeout_avp", "$avp(i:10)") +modparam("dialog", "timeout_avp", "$avp(dlgtimeout)") # Set the sst modules timeout_avp to be the same value -modparam("sst", "timeout_avp", "$avp(i:10)") +modparam("sst", "timeout_avp", "$avp(dlgtimeout)") +... +request_route { + ... + # when wanting to use Session-Expires value for initial INVITE + if(is_method("INVITE") and !has_totag()) { + if(is_present_hf("Session-Expires")) { + $avp(dlgtimeout) = $(hdr(Session-Expires){s.int}); + } + } + ... +} ... 4.4. reject_to_small (integer)

4 years, 8 months

git:master:b800ffb9: sst: docs - more info about how timeout_avp is used

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b800ffb9fb1de6ee0d7b6c2b42a25669022c1142 URL: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T14:50:58+01:00 sst: docs - more info about how timeout_avp is used --- Modified: src/modules/sst/doc/sst_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… Patch: https://github.com/kamailio/kamailio/commit/b800ffb9fb1de6ee0d7b6c2b42a2566… --- diff --git a/src/modules/sst/doc/sst_admin.xml b/src/modules/sst/doc/sst_admin.xml index 49f2630287..a82132bd6e 100644 --- a/src/modules/sst/doc/sst_admin.xml +++ b/src/modules/sst/doc/sst_admin.xml @@ -207,25 +207,41 @@ modparam("sst", "min_se", 2400) <section id="sst.p.timeout_avp"> <title><varname>timeout_avp</varname> (string)</title> - <para>This parameter MUST be set to the same value as the - dialog module parameter of the same name. If this parameter is - NOT set, the sst module will not do anything!</para> - - <para>This is how the sst module knows which avp in the - dialog module it has to change with the new expire value.</para> + <para>This parameter must be set to the same value as the + dialog module parameter of the same name, when it is wanted to update + dialog timeout using Session-Expires header value. If this parameter is + not set, the sst module will not update dialog timeout.</para> + <para>With this parameter, the sst module knows which avp is expected + by the dialog module to change to a new expire value.</para> + <para> <para> + Note that the avp is set only for requests within dialog, not for + the initial INVITE. For this one, it can be done using script operations, + see the next example for such solution. + </para> <emphasis> - Default value is <quote>NULL!</quote> it is not set by default. + Default value is <quote>NULL</quote> (not set by default). </emphasis> </para> <example> <title>Set <varname>timeout_avp</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("dialog", "timeout_avp", "$avp(i:10)") +modparam("dialog", "timeout_avp", "$avp(dlgtimeout)") # Set the sst modules timeout_avp to be the same value -modparam("sst", "timeout_avp", "$avp(i:10)") +modparam("sst", "timeout_avp", "$avp(dlgtimeout)") +... +request_route { + ... + # when wanting to use Session-Expires value for initial INVITE + if(is_method("INVITE") and !has_totag()) { + if(is_present_hf("Session-Expires")) { + $avp(dlgtimeout) = $(hdr(Session-Expires){s.int}); + } + } + ... +} ... </programlisting> </example>

4 years, 8 months

[kamailio/kamailio] Fix returning multiple IP's for a cached DNS entry (#2260)

by Nathan

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description The method `dns_entry2he` was returning 10 `hostent` structures, containing the same record, because the rr counter was never updated (10 being the value of `DNS_HE_MAX_ADDR`). With this fix, the cache correctly returns all records found by the resolver. In the documentation of `dns_int_match_ip`, it says: >> At this moment, the function might not check all the IP addresses as returned by dns_sys_match_ip(), because the internal resolver targets to discover the first address to be used for relaying SIP traffic. I believe that with this patch, `dns_int_match_ip` now also works for DNS entries with multiple values. I'm not sure about mixed ipv4/ipv6 though. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2260 -- Commit Summary -- * Fix returning multiple IP's for a cached DNS entry -- File Changes -- M src/core/dns_cache.c (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2260.patch https://github.com/kamailio/kamailio/pull/2260.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2260

4 years, 8 months

git:master:29a35ec3: core: fix returning multiple IPs for a cached DNS entry

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 29a35ec3cec8b9c3ee4b45c8d84308701bda097c URL: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… Author: Nathan Bruning <nathan(a)iperity.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:24:28+01:00 core: fix returning multiple IPs for a cached DNS entry --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… Patch: https://github.com/kamailio/kamailio/commit/29a35ec3cec8b9c3ee4b45c8d843087… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 8f3f4aeaf9..81fc6a9e45 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -2304,6 +2304,7 @@ inline static struct hostent* dns_entry2he(struct dns_hash_entry* e) return 0; } memcpy(p_addr[i], ip, len); + rr_no++; } if (i==0){ LM_DBG("no good records found (%d) for %.*s (%d)\n",

4 years, 8 months

[kamailio/kamailio] modules: fix zero-length log placeholder (#2241)

by Zero King

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2241 -- Commit Summary -- * modules: fix zero-length log placeholder -- File Changes -- M src/modules/nathelper/nhelpr_funcs.c (2) M src/modules/rtpengine/rtpengine_funcs.c (2) M src/modules/rtpproxy/rtpproxy_funcs.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2241.patch https://github.com/kamailio/kamailio/pull/2241.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2241

4 years, 8 months

git:master:740afac1: rtpengine: fix zero-length log placeholder

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 740afac15b3d8d618b5101a761a37f5808d4b4f0 URL: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:12:39+01:00 rtpengine: fix zero-length log placeholder --- Modified: src/modules/rtpengine/rtpengine_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… Patch: https://github.com/kamailio/kamailio/commit/740afac15b3d8d618b5101a761a37f5… --- diff --git a/src/modules/rtpengine/rtpengine_funcs.c b/src/modules/rtpengine/rtpengine_funcs.c index b99153a063..598af6360e 100644 --- a/src/modules/rtpengine/rtpengine_funcs.c +++ b/src/modules/rtpengine/rtpengine_funcs.c @@ -231,7 +231,7 @@ int extract_body(struct sip_msg *msg, str *body ) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if ( rest > p2 ) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1-p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2-p1), p1); return -1; } while( rest<p2 ) {

4 years, 8 months

git:master:030f18b5: rtpproxy: fix zero-length log placeholder

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 030f18b5cffeb117dcf582cf12c5b3c35ace1469 URL: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:12:25+01:00 rtpproxy: fix zero-length log placeholder --- Modified: src/modules/rtpproxy/rtpproxy_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… Patch: https://github.com/kamailio/kamailio/commit/030f18b5cffeb117dcf582cf12c5b3c… --- diff --git a/src/modules/rtpproxy/rtpproxy_funcs.c b/src/modules/rtpproxy/rtpproxy_funcs.c index 858c5196d5..35401cdb24 100644 --- a/src/modules/rtpproxy/rtpproxy_funcs.c +++ b/src/modules/rtpproxy/rtpproxy_funcs.c @@ -228,7 +228,7 @@ int extract_body(struct sip_msg *msg, str *body ) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if ( rest > p2 ) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1-p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2-p1), p1); return -1; } while( rest<p2 ) {

4 years, 8 months

git:master:69714b26: nathelper: fix zero-length log placeholder

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 69714b26c63c75df6759f9158c7181d4f86b4764 URL: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… Author: Zero King <l2dy(a)icloud.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T11:11:54+01:00 nathelper: fix zero-length log placeholder --- Modified: src/modules/nathelper/nhelpr_funcs.c --- Diff: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… Patch: https://github.com/kamailio/kamailio/commit/69714b26c63c75df6759f9158c7181d… --- diff --git a/src/modules/nathelper/nhelpr_funcs.c b/src/modules/nathelper/nhelpr_funcs.c index 7300868532..c0db297c1e 100644 --- a/src/modules/nathelper/nhelpr_funcs.c +++ b/src/modules/nathelper/nhelpr_funcs.c @@ -227,7 +227,7 @@ int extract_body(struct sip_msg *msg, str *body) /* p2 is text limit for application parsing */ rest = eat_line(p1 + mpdel.len + 2, p2 - p1 - mpdel.len - 2); if(rest > p2) { - LM_ERR("Unparsable <%.*s>\n", (int)(p1 - p1), p1); + LM_ERR("Unparsable <%.*s>\n", (int)(p2 - p1), p1); return -1; } while(rest < p2) {

4 years, 8 months

git:master:63cd404d: kamctl: regenerated db schema file with secfilter updates

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 63cd404d4b46e4514ae1490303189a0f81def942 URL: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-24T10:33:30+01:00 kamctl: regenerated db schema file with secfilter updates --- Added: utils/kamctl/db_berkeley/kamailio/secfilter Added: utils/kamctl/db_redis/kamailio/secfilter Added: utils/kamctl/dbtext/kamailio/secfilter Added: utils/kamctl/mongodb/kamailio/secfilter.json Added: utils/kamctl/xhttp_pi/secfilter-mod Added: utils/kamctl/xhttp_pi/secfilter-table Modified: utils/kamctl/db_berkeley/kamailio/version Modified: utils/kamctl/db_sqlite/secfilter-create.sql Modified: utils/kamctl/dbtext/kamailio/version Modified: utils/kamctl/mongodb/kamailio/version-create.mongo Modified: utils/kamctl/mysql/secfilter-create.sql Modified: utils/kamctl/oracle/secfilter-create.sql Modified: utils/kamctl/postgres/secfilter-create.sql Modified: utils/kamctl/xhttp_pi/pi_framework.xml --- Diff: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0… Patch: https://github.com/kamailio/kamailio/commit/63cd404d4b46e4514ae1490303189a0…

4 years, 8 months

← Newer
1
...
16
17
18
19
20
21
22
...
48
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2020