<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [X] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
In our setup, we need one more ratelimit queue (in addition to the default of 10).
In this pull request, I am increasing the default number of ratelimit queus to 16.
Please let me know if this pull request is ok, or if I should do it via a modparam and dynamic allocation of ```static rl_queue_t queues```.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2257
-- Commit Summary --
* ratelimit: increase default number of queues
-- File Changes --
M src/modules/ratelimit/ratelimit.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2257.patchhttps://github.com/kamailio/kamailio/pull/2257.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2257
Module: kamailio
Branch: 5.3
Commit: 41967543be401413f5a93682ea537e2e7824ac3b
URL: https://github.com/kamailio/kamailio/commit/41967543be401413f5a93682ea537e2…
Author: Greg Troxel <gdt(a)lexort.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2020-03-19T19:20:26+01:00
Makefile.defs: Only add -ldl on systems that use it
kamailio uses dlopen, and on some systems, one must link with -ldl.
On others, this is not needed and there is no libdl. For now, simply
omit -ldl on NetBSD (which doesn't have or require it), and don't try
to change behavior on other systems.
(cherry picked from commit bca9768b6f2667bad8472fa99a113b8249ca0f9a)
---
Modified: src/Makefile.defs
---
Diff: https://github.com/kamailio/kamailio/commit/41967543be401413f5a93682ea537e2…
Patch: https://github.com/kamailio/kamailio/commit/41967543be401413f5a93682ea537e2…
---
diff --git a/src/Makefile.defs b/src/Makefile.defs
index a57bc2b91e..41f33a51a0 100644
--- a/src/Makefile.defs
+++ b/src/Makefile.defs
@@ -210,9 +210,18 @@ endif
endif
+# dlopen requires -ldl on some systems, but not others. Until there
+# is clarity on which require -ldl, add just enough ifeq to fix
+# systems known not to use it.
+ifeq ($(OS), netbsd)
+LIBDL=""
+else
+LIBDL="-ldl"
+endif
+
ifeq ($(LIBSSL_SET_MUTEX_SHARED), 1)
CC_PMUTEX_OPTS = -pthread -DKSR_PTHREAD_MUTEX_SHARED
-LD_PMUTEX_OPTS = -pthread -rdynamic -ldl -Wl,-Bsymbolic-functions
+LD_PMUTEX_OPTS = -pthread -rdynamic $(LIBDL) -Wl,-Bsymbolic-functions
else
CC_PMUTEX_OPTS =
LD_PMUTEX_OPTS =