sr-dev March 2020

sr-dev@lists.kamailio.org

27 participants
473 discussions

git:master:325a45e8: tm: safe list iteration in tm_clean_lifetime()

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 325a45e846faae3e5dfa333727d5fab294e44dac URL: https://github.com/kamailio/kamailio/commit/325a45e846faae3e5dfa333727d5fab… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T22:29:04+01:00 tm: safe list iteration in tm_clean_lifetime() --- Modified: src/modules/tm/h_table.c --- Diff: https://github.com/kamailio/kamailio/commit/325a45e846faae3e5dfa333727d5fab… Patch: https://github.com/kamailio/kamailio/commit/325a45e846faae3e5dfa333727d5fab… --- diff --git a/src/modules/tm/h_table.c b/src/modules/tm/h_table.c index 4d67b75a3a..a8545b220e 100644 --- a/src/modules/tm/h_table.c +++ b/src/modules/tm/h_table.c @@ -596,6 +596,7 @@ void tm_clean_lifetime(void) { int r; tm_cell_t *tcell; + tm_cell_t *bcell; ticks_t texp; texp = get_ticks_raw() - S_TO_TICKS(TM_LIFETIME_LIMIT); @@ -612,7 +613,7 @@ void tm_clean_lifetime(void) continue; } - clist_foreach(&_tm_table->entries[r], tcell, next_c) + clist_foreach_safe(&_tm_table->entries[r], tcell, bcell, next_c) { if(TICKS_GT(texp, tcell->end_of_life)) { tm_log_transaction(tcell, L_WARN, "[hard cleanup]");

4 years, 8 months

git:5.3:5b6ce8ef: CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci]

by Henning Westerholt

Module: kamailio Branch: 5.3 Commit: 5b6ce8ef92f876b4ec24305592fb285adbb9bce2 URL: https://github.com/kamailio/kamailio/commit/5b6ce8ef92f876b4ec24305592fb285… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-04T20:15:34+01:00 CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci] (cherry picked from commit 116302384110eccc9115ee8cbc96271d893a1f1a) --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/5b6ce8ef92f876b4ec24305592fb285… Patch: https://github.com/kamailio/kamailio/commit/5b6ce8ef92f876b4ec24305592fb285… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 293c0f98a2..6915550603 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -84,7 +84,7 @@ as "Subject" in the generated commit emails and it will also be used when generating the Changelog (e.g. git log --pretty=oneline). -The first line (subjecthas to contain meaningful text about what that commit +The first line (subject has to contain meaningful text about what that commit does, do not put just a reference to bug tracker or pull request items Please start always with the prefix of the component (subsystem) that is modified

4 years, 8 months

git:master:11630238: CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci]

by Henning Westerholt

Module: kamailio Branch: master Commit: 116302384110eccc9115ee8cbc96271d893a1f1a URL: https://github.com/kamailio/kamailio/commit/116302384110eccc9115ee8cbc96271… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-03-04T20:14:34+01:00 CONTRIBUTING.md: small spelling fix after recent doc extension [skip ci] --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/116302384110eccc9115ee8cbc96271… Patch: https://github.com/kamailio/kamailio/commit/116302384110eccc9115ee8cbc96271… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index fca94e33de..1fc1b6342b 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -90,7 +90,7 @@ as "Subject" in the generated commit emails and it will also be used when generating the Changelog (e.g. git log --pretty=oneline). -The first line (subjecthas to contain meaningful text about what that commit +The first line (subject has to contain meaningful text about what that commit does, do not put just a reference to bug tracker or pull request items Please start always with the prefix of the component (subsystem) that is modified

4 years, 8 months

git:5.3:a75be26a: pua: extern declaration of global variable in header file

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: a75be26a5288a2e6c4a6f7d262581e590e3186b1 URL: https://github.com/kamailio/kamailio/commit/a75be26a5288a2e6c4a6f7d262581e5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:30:18+01:00 pua: extern declaration of global variable in header file (cherry picked from commit e260447833f616066e0fa23e51e791822b55b039) --- Modified: src/modules/pua/pua.h --- Diff: https://github.com/kamailio/kamailio/commit/a75be26a5288a2e6c4a6f7d262581e5… Patch: https://github.com/kamailio/kamailio/commit/a75be26a5288a2e6c4a6f7d262581e5… --- diff --git a/src/modules/pua/pua.h b/src/modules/pua/pua.h index 3958294b77..57cc379ebe 100644 --- a/src/modules/pua/pua.h +++ b/src/modules/pua/pua.h @@ -48,7 +48,7 @@ extern str outbound_proxy; extern int check_remote_contact; extern int dbmode; -int reginfo_increase_version; +extern int reginfo_increase_version; extern int update_pua(ua_pres_t* p); extern int clean_puadb( int update_period, int min_expires );

4 years, 8 months

git:5.3:f68f5f5a: siputils: contact encoding functions exported to kemi

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: f68f5f5adb504d7ee2d4a2c652fd0bebb8679696 URL: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:30:03+01:00 siputils: contact encoding functions exported to kemi (cherry picked from commit b7c47ce4ceea9ce97431bdd921afa2a59617e1c5) --- Modified: src/modules/siputils/contact_ops.c Modified: src/modules/siputils/contact_ops.h Modified: src/modules/siputils/siputils.c --- Diff: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… Patch: https://github.com/kamailio/kamailio/commit/f68f5f5adb504d7ee2d4a2c652fd0be… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index 5183f40ab6..bc48a8771b 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -44,7 +44,7 @@ #include <string.h> -int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr) { contact_body_t *cb; contact_t *c; @@ -85,7 +85,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) /* we visit each contact */ if(c != NULL) { uri = c->uri; - res = encode_uri(uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encoding contact.Code %d\n", res); @@ -103,8 +103,7 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) c = c->next; uri = c->uri; - res = encode_uri( - uri, encoding_prefix, public_ip, separator, &newUri); + res = encode_uri(uri, eprefix->s, eaddr->s, separator, &newUri); if(res != 0) { LM_ERR("failed encode_uri.Code %d\n", res); #ifdef STRICT_CHECK @@ -121,8 +120,20 @@ int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip) return 1; } - int -decode_contact (struct sip_msg *msg,char *unused1,char *unused2) +int encode_contact(sip_msg_t *msg, char *encoding_prefix, char *public_ip) +{ + str eprefix = STR_NULL; + str eaddr = STR_NULL; + + eprefix.s = encoding_prefix; + eprefix.len = strlen(eprefix.s); + eaddr.s = public_ip; + eaddr.len = strlen(eaddr.s); + + return ki_encode_contact(msg, &eprefix, &eaddr); +} + +int ki_decode_contact(sip_msg_t *msg) { str uri; @@ -177,8 +188,12 @@ decode_contact (struct sip_msg *msg,char *unused1,char *unused2) return 1; } - int -decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) +int decode_contact(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact(msg); +} + +int ki_decode_contact_header(sip_msg_t *msg) { contact_body_t *cb; @@ -255,6 +270,10 @@ decode_contact_header (struct sip_msg *msg,char *unused1,char *unused2) } +int decode_contact_header(sip_msg_t *msg, char *unused1, char *unused2) +{ + return ki_decode_contact_header(msg); +} int diff --git a/src/modules/siputils/contact_ops.h b/src/modules/siputils/contact_ops.h index ef925c761b..939b80ac6c 100644 --- a/src/modules/siputils/contact_ops.h +++ b/src/modules/siputils/contact_ops.h @@ -64,6 +64,9 @@ struct uri_format typedef struct uri_format contact_fields_t; +int ki_encode_contact (sip_msg_t *msg, str *eprefix, str *eaddr); +int ki_decode_contact(sip_msg_t *msg); +int ki_decode_contact_header(sip_msg_t *msg); int encode_contact (struct sip_msg *msg, char *encoding_prefix,char *public_ip); int decode_contact (struct sip_msg *msg, char *unused1,char *unused2); diff --git a/src/modules/siputils/siputils.c b/src/modules/siputils/siputils.c index aa847ae9c4..e9593da3b4 100644 --- a/src/modules/siputils/siputils.c +++ b/src/modules/siputils/siputils.c @@ -546,6 +546,21 @@ static sr_kemi_t sr_kemi_siputils_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("siputils"), str_init("encode_contact"), + SR_KEMIP_INT, ki_encode_contact, + { SR_KEMIP_STR, SR_KEMIP_STR, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact"), + SR_KEMIP_INT, ki_decode_contact, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("siputils"), str_init("decode_contact_header"), + SR_KEMIP_INT, ki_decode_contact_header, + { SR_KEMIP_NULL, SR_KEMIP_NULL, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { {0, 0}, {0, 0}, 0, NULL, { 0, 0, 0, 0, 0, 0 } } };

4 years, 8 months

git:5.3:68be831a: CONTRIBUTING.md: section for first line of the commit message [skip ci]

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 68be831aa83c09e99b35c55a6ff6d7f21a0502d6 URL: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:53+01:00 CONTRIBUTING.md: section for first line of the commit message [skip ci] - note about [skip ci] flag in first line (cherry picked from commit 04d082d2a89f8e0d3646856cb81666f9f03fdffa) --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… Patch: https://github.com/kamailio/kamailio/commit/68be831aa83c09e99b35c55a6ff6d7f… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index ea6ba9cdd8..293c0f98a2 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -75,13 +75,20 @@ Please create the commit messages following the GIT convention: * start with one short line, preferably less then 50 chars summarizing the changes (this is referred later as "first line of the commit message") * then one empty line - * then a more detailed description + * then a more detailed description (the "commit message content") + +#### First Line Of The Commit Message #### Think of the first line as of an email "Subject" line. In fact it will be used as "Subject" in the generated commit emails and it will also be used when generating the Changelog (e.g. git log --pretty=oneline). -Please start always with the prefix of the component (subsystem) that is modified by the commit, for example: + +The first line (subjecthas to contain meaningful text about what that commit +does, do not put just a reference to bug tracker or pull request items + +Please start always with the prefix of the component (subsystem) that is modified +by the commit, for example: * `core`: more fixup helper functions * `core`: tcp - support for haproxy protocol * `core`: mem - added faster malloc @@ -90,13 +97,19 @@ Please start always with the prefix of the component (subsystem) that is modifie * `lib`: srutils - critical bug fix for abc case * `kamctl`: added support for management of module xyz +At the end of the first line some CI flags can be added. Available at this +moment: + + * `[skip ci]` - skip continous integration builds for source code, recommended + to be added when updating documentation, example configs or other utilities. + Example: + * `msilo: docs - updated example for m_dump() function [skip ci]` + #### Commit Message Content #### - * first line (subject line) has to contain meaningful text about what that commit - does, do not put just a reference to bug tracker or pull request items - * commit message must describe the changes done by the patch +* commit message must describe the changes done by the patch * other details (e.g., how to reproduce, backtrace, sip packets, ...) belong - to content (comments) of the pull request. Example: + to content (comments) of the pull request. Example of a full commit message: ``` core: added latency_limit_cfg global parameter

4 years, 8 months

git:5.3:70f07adf: ims_qos: more extern declarations in the header files

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 70f07adf5778fdb7015bfce8ffd1b8ae0353d432 URL: https://github.com/kamailio/kamailio/commit/70f07adf5778fdb7015bfce8ffd1b8a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:43+01:00 ims_qos: more extern declarations in the header files (cherry picked from commit 7bea30203b85b7ed17434ee3f301faa0cedcba76) --- Modified: src/modules/ims_qos/ims_qos_mod.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/70f07adf5778fdb7015bfce8ffd1b8a… Patch: https://github.com/kamailio/kamailio/commit/70f07adf5778fdb7015bfce8ffd1b8a… --- diff --git a/src/modules/ims_qos/ims_qos_mod.c b/src/modules/ims_qos/ims_qos_mod.c index 6f68b39be1..7e0d50b2df 100644 --- a/src/modules/ims_qos/ims_qos_mod.c +++ b/src/modules/ims_qos/ims_qos_mod.c @@ -75,7 +75,11 @@ MODULE_VERSION - extern gen_lock_t* process_lock; /* lock on the process table */ +extern gen_lock_t* process_lock; /* lock on the process table */ + +stat_var* stat_aar_timeouts; +stat_var* aar_replies_received; +stat_var* aar_replies_response_time; str orig_session_key = str_init("originating"); str term_session_key = str_init("terminating"); diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index 0a9a63b51a..10fa2cc059 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -54,7 +54,7 @@ #include "../../core/mod_fix.h" #include "../../core/locking.h" -struct cdp_binds cdpb; +extern struct cdp_binds cdpb; extern cdp_avp_bind_t *cdp_avp; /*this is the parcel to pass for CDP async for AAR*/ diff --git a/src/modules/ims_qos/stats.h b/src/modules/ims_qos/stats.h index 2de4bcdfa3..86424b94a2 100644 --- a/src/modules/ims_qos/stats.h +++ b/src/modules/ims_qos/stats.h @@ -51,9 +51,9 @@ #include "../../core/counters.h" -stat_var* stat_aar_timeouts; -stat_var* aar_replies_received; -stat_var* aar_replies_response_time; +extern stat_var* stat_aar_timeouts; +extern stat_var* aar_replies_received; +extern stat_var* aar_replies_response_time; int register_stats(); unsigned long get_avg_aar_response_time();

4 years, 8 months

git:5.3:8cb7d5c0: ims_qos: use extern in header files not to redeclare variables

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 8cb7d5c0bb59be44d55582844bd4021032cf5646 URL: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:29:04+01:00 ims_qos: use extern in header files not to redeclare variables (cherry picked from commit df5521fcdfc96462eb191b774f242fe1d4616adb) --- Modified: src/modules/ims_qos/cdpeventprocessor.h Modified: src/modules/ims_qos/rx_aar.c Modified: src/modules/ims_qos/rx_aar.h Modified: src/modules/ims_qos/rx_avp.h --- Diff: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… Patch: https://github.com/kamailio/kamailio/commit/8cb7d5c0bb59be44d55582844bd4021… --- diff --git a/src/modules/ims_qos/cdpeventprocessor.h b/src/modules/ims_qos/cdpeventprocessor.h index 4f2b4d688f..8f393656ee 100644 --- a/src/modules/ims_qos/cdpeventprocessor.h +++ b/src/modules/ims_qos/cdpeventprocessor.h @@ -67,8 +67,8 @@ typedef struct { int size; } cdp_cb_event_list_t; -str early_qosrelease_reason; -str confirmed_qosrelease_headers; +extern str early_qosrelease_reason; +extern str confirmed_qosrelease_headers; int init_cdp_cb_event_list(); void destroy_cdp_cb_event_list(); diff --git a/src/modules/ims_qos/rx_aar.c b/src/modules/ims_qos/rx_aar.c index 684f3a75c5..2029035415 100644 --- a/src/modules/ims_qos/rx_aar.c +++ b/src/modules/ims_qos/rx_aar.c @@ -71,7 +71,7 @@ #define macro_name(_rc) #_rc //extern struct tm_binds tmb; -usrloc_api_t ul; +extern usrloc_api_t ul; extern struct ims_qos_counters_h ims_qos_cnts_h; diff --git a/src/modules/ims_qos/rx_aar.h b/src/modules/ims_qos/rx_aar.h index f12def162f..0a9a63b51a 100644 --- a/src/modules/ims_qos/rx_aar.h +++ b/src/modules/ims_qos/rx_aar.h @@ -55,7 +55,7 @@ #include "../../core/locking.h" struct cdp_binds cdpb; -cdp_avp_bind_t *cdp_avp; +extern cdp_avp_bind_t *cdp_avp; /*this is the parcel to pass for CDP async for AAR*/ typedef struct saved_transaction { diff --git a/src/modules/ims_qos/rx_avp.h b/src/modules/ims_qos/rx_avp.h index c8f81b6f85..55840f3e81 100644 --- a/src/modules/ims_qos/rx_avp.h +++ b/src/modules/ims_qos/rx_avp.h @@ -64,8 +64,8 @@ struct AAA_AVP_List; struct AAAMessage; enum dialog_direction; -int audio_default_bandwidth; -int video_default_bandwidth; +extern int audio_default_bandwidth; +extern int video_default_bandwidth; /*helper*/

4 years, 8 months

git:5.3:2c2af66a: ims_icscf: stats global variables made extern in header file

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 2c2af66acca5bbe49840683682323745a9f84b1f URL: https://github.com/kamailio/kamailio/commit/2c2af66acca5bbe4984068368232374… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:55+01:00 ims_icscf: stats global variables made extern in header file (cherry picked from commit bfb717fc8504a079066a0fdc09b856a937a7b430) --- Modified: src/modules/ims_icscf/ims_icscf_mod.c Modified: src/modules/ims_icscf/stats.h --- Diff: https://github.com/kamailio/kamailio/commit/2c2af66acca5bbe4984068368232374… Patch: https://github.com/kamailio/kamailio/commit/2c2af66acca5bbe4984068368232374… --- diff --git a/src/modules/ims_icscf/ims_icscf_mod.c b/src/modules/ims_icscf/ims_icscf_mod.c index 3aa9814c5b..1bc7b7e430 100644 --- a/src/modules/ims_icscf/ims_icscf_mod.c +++ b/src/modules/ims_icscf/ims_icscf_mod.c @@ -63,6 +63,13 @@ cdp_avp_bind_t *cdp_avp; sl_api_t slb; +stat_var* stat_uar_timeouts = NULL; +stat_var* stat_lir_timeouts = NULL; +stat_var* uar_replies_received = NULL; +stat_var* lir_replies_received = NULL; +stat_var* uar_replies_response_time = NULL; +stat_var* lir_replies_response_time = NULL; + //module parameters char* ims_icscf_db_url="mysql://icscf:heslo@localhost/hssdata"; /**< DB URL */ char* ims_icscf_db_nds_table="nds_trusted_domains"; /**< NDS table in DB */ diff --git a/src/modules/ims_icscf/stats.h b/src/modules/ims_icscf/stats.h index eb293f80be..dbe1dcd5d2 100644 --- a/src/modules/ims_icscf/stats.h +++ b/src/modules/ims_icscf/stats.h @@ -46,12 +46,12 @@ #include "../../core/counters.h" -stat_var* stat_uar_timeouts; -stat_var* stat_lir_timeouts; -stat_var* uar_replies_received; -stat_var* lir_replies_received; -stat_var* uar_replies_response_time; -stat_var* lir_replies_response_time; +extern stat_var* stat_uar_timeouts; +extern stat_var* stat_lir_timeouts; +extern stat_var* uar_replies_received; +extern stat_var* lir_replies_received; +extern stat_var* uar_replies_response_time; +extern stat_var* lir_replies_response_time; int register_stats(); unsigned long get_avg_uar_response_time();

4 years, 8 months

git:5.3:c720a329: ims_isc: avoid duplicate declaration of isc_ulb by using extern

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: c720a32974f36873dd8dd9f127f5e28a03b5c9c7 URL: https://github.com/kamailio/kamailio/commit/c720a32974f36873dd8dd9f127f5e28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-03-04T12:28:46+01:00 ims_isc: avoid duplicate declaration of isc_ulb by using extern (cherry picked from commit 32f37cdc876abcd7127993e079c9a0132d1f6460) --- Modified: src/modules/ims_isc/third_party_reg.c --- Diff: https://github.com/kamailio/kamailio/commit/c720a32974f36873dd8dd9f127f5e28… Patch: https://github.com/kamailio/kamailio/commit/c720a32974f36873dd8dd9f127f5e28… --- diff --git a/src/modules/ims_isc/third_party_reg.c b/src/modules/ims_isc/third_party_reg.c index 41877fd515..870c85006f 100644 --- a/src/modules/ims_isc/third_party_reg.c +++ b/src/modules/ims_isc/third_party_reg.c @@ -46,7 +46,7 @@ #include "third_party_reg.h" #include "../../core/msg_translator.h" -usrloc_api_t isc_ulb;/*!< Structure containing pointers to usrloc functions*/ +extern usrloc_api_t isc_ulb;/*!< Structure containing pointers to usrloc functions*/ /*! \brief * Combines all Path HF bodies into one string.

4 years, 8 months

← Newer
1
...
39
40
41
42
43
44
45
...
48
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2020