sr-dev May 2020

sr-dev@lists.kamailio.org

24 participants
393 discussions

git:master:765efa80: utils/kamctl: dbtextdb remove DeprecationWarning on test
by Victor Seva 04 May '20

04 May '20

Module: kamailio Branch: master Commit: 765efa80c7d27e9447bc1ad8a354ee24723580ef URL: https://github.com/kamailio/kamailio/commit/765efa80c7d27e9447bc1ad8a354ee2… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-04T15:06:43+02:00 utils/kamctl: dbtextdb remove DeprecationWarning on test related #1747 --- Modified: utils/kamctl/dbtextdb/dbtextdb_test.py --- Diff: https://github.com/kamailio/kamailio/commit/765efa80c7d27e9447bc1ad8a354ee2… Patch: https://github.com/kamailio/kamailio/commit/765efa80c7d27e9447bc1ad8a354ee2…

1 0

git:master:b722a481: utils/kamctl: fix dbtestdb
by Victor Seva 04 May '20

04 May '20

Module: kamailio Branch: master Commit: b722a48144ac9e029bdbc2968dedbe56966a3f7c URL: https://github.com/kamailio/kamailio/commit/b722a48144ac9e029bdbc2968dedbe5… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-04T14:48:41+02:00 utils/kamctl: fix dbtestdb some indentantion errors introduced at https://github.com/kamailio/kamailio/commit/bc8bdcaa726f375f6deea8228a1ab0c… related #1747 --- Modified: utils/kamctl/dbtextdb/dbtextdb.py --- Diff: https://github.com/kamailio/kamailio/commit/b722a48144ac9e029bdbc2968dedbe5… Patch: https://github.com/kamailio/kamailio/commit/b722a48144ac9e029bdbc2968dedbe5… --- diff --git a/utils/kamctl/dbtextdb/dbtextdb.py b/utils/kamctl/dbtextdb/dbtextdb.py index 3d5ee7ecc5..7e1de04687 100755 --- a/utils/kamctl/dbtextdb/dbtextdb.py +++ b/utils/kamctl/dbtextdb/dbtextdb.py @@ -146,11 +146,11 @@ def _ParseColumns(self): # check if there is a function modifier on the columns if self.tokens[0] == 'COUNT': self.count = True - if col_end == 1: - raise ParseError('COUNT must be followed by column name[s]') - if not self.tokens[1].startswith(self._paren_placeholder): - raise ParseError('COUNT must be followed by ()') - cols_str = self._ReplaceParens(self.tokens[1]) + if col_end == 1: + raise ParseError('COUNT must be followed by column name[s]') + if not self.tokens[1].startswith(self._paren_placeholder): + raise ParseError('COUNT must be followed by ()') + cols_str = self._ReplaceParens(self.tokens[1]) cols = cols_str.split(',') for col in cols: @@ -300,7 +300,7 @@ def _ParseTargets(self): if self.tokens.pop(0) != 'SET': raise ParseError('UPDATE command must be followed by SET') - self.targets = self._ParsePairs(' '.join(self.tokens), ',') + self.targets = self._ParsePairs(' '.join(self.tokens), ',') # INSERT if self.command == 'INSERT': @@ -570,19 +570,19 @@ def _ParseOutHelper(self, placeholder, delims, mode): string = '%s%s' % (string, c) continue # wait for matching delim - started -= 1 - if not started: - values.append(string) - new_args = '%s %s' % (new_args, '%s%d' % (placeholder, - my_id)) - my_id += 1 - string = '' + started -= 1 + if not started: + values.append(string) + new_args = '%s %s' % (new_args, '%s%d' % (placeholder, + my_id)) + my_id += 1 + string = '' - else: - if not started: - new_args = '%s%s' % (new_args, c) else: - string = '%s%s' % (string, c) + if not started: + new_args = '%s%s' % (new_args, c) + else: + string = '%s%s' % (string, c) if started: if mode == 'parens': @@ -714,8 +714,8 @@ def _RunInsert(self): elif self.header[col]['auto']: new_row[col] = self._GetNextAuto(col) - else: - raise ExecuteError(col + ' cannot be empty or null') + else: + raise ExecuteError(col + ' cannot be empty or null') self.data.append(new_row) return [1]

1 0

git:5.3:5f6f4331: utils/kamctl: fix handling of Exceptions
by Victor Seva 04 May '20

04 May '20

Module: kamailio Branch: 5.3 Commit: 5f6f4331811e654e75b49263f8fb823bea9874a3 URL: https://github.com/kamailio/kamailio/commit/5f6f4331811e654e75b49263f8fb823… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-04T12:10:05+02:00 utils/kamctl: fix handling of Exceptions > Traceback (most recent call last): > File "/usr/lib/x86_64-linux-gnu/kamailio/kamctl/dbtextdb/dbtextdb.py", line 1239, in <module> > main(sys.argv) > File "/usr/lib/x86_64-linux-gnu/kamailio/kamctl/dbtextdb/dbtextdb.py", line 1233, in main > except (Error, e): > NameError: name 'e' is not defined (cherry picked from commit 1aca79c43cb8dbd920c1eb81c0c30cf89f0985b9) --- Modified: utils/kamctl/dbtextdb/dbtextdb.py --- Diff: https://github.com/kamailio/kamailio/commit/5f6f4331811e654e75b49263f8fb823… Patch: https://github.com/kamailio/kamailio/commit/5f6f4331811e654e75b49263f8fb823… --- diff --git a/utils/kamctl/dbtextdb/dbtextdb.py b/utils/kamctl/dbtextdb/dbtextdb.py index 3a35554013..3d5ee7ecc5 100755 --- a/utils/kamctl/dbtextdb/dbtextdb.py +++ b/utils/kamctl/dbtextdb/dbtextdb.py @@ -356,7 +356,7 @@ def _EscapeChars(self, value): # test that the value is string, if not return it as is try: value.find('a') - except: + except Exception: return value escaped = value @@ -377,7 +377,7 @@ def _UnEscapeChars(self, value): # test that the value is string, if not return it as is try: value.find('a') - except: + except Exception: return value escaped = value @@ -988,21 +988,19 @@ def _TypeCheck(self, val, col): if not val and not self.header[col]['null']: raise ExecuteError(col + ' cannot be empty or null') - if (self.header[col]['type'].lower() == 'int' or - self.header[col]['type'].lower() == 'double'): + hdr_t = self.header[col]['type'].lower() + if hdr_t == 'int' or hdr_t == 'double': try: if val: val = eval(val) - except (NameError, e): + except NameError as e: raise ExecuteError('Failed to parse %s in %s ' '(unable to convert to type %s): %s' % - (col, self.table, self.header[col]['type'], - e)) - except (SyntaxError, e): + (col, self.table, hdr_t, e)) + except SyntaxError as e: raise ExecuteError('Failed to parse %s in %s ' '(unable to convert to type %s): %s' % - (col, self.table, self.header[col]['type'], - e)) + (col, self.table, hdr_t, e)) return val @@ -1083,7 +1081,7 @@ def OpenTable(self): # save a copy of the data before modifying self.orig_data = self.data[:] - except (IOError, e): + except IOError as e: raise ExecuteError('Unable to open table %s: %s' % (self.table, e)) Debug('Header is: %s' % self.header) @@ -1230,7 +1228,7 @@ def main(argv): print('Updated %s, rows affected: %d' % (conn.table, row)) else: print(row) - except (Error, e): + except Error as e: print(e) sys.exit(1)

1 0

git:master:1aca79c4: utils/kamctl: fix handling of Exceptions
by Victor Seva 04 May '20

04 May '20

Module: kamailio Branch: master Commit: 1aca79c43cb8dbd920c1eb81c0c30cf89f0985b9 URL: https://github.com/kamailio/kamailio/commit/1aca79c43cb8dbd920c1eb81c0c30cf… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-05-04T11:33:12+02:00 utils/kamctl: fix handling of Exceptions > Traceback (most recent call last): > File "/usr/lib/x86_64-linux-gnu/kamailio/kamctl/dbtextdb/dbtextdb.py", line 1239, in <module> > main(sys.argv) > File "/usr/lib/x86_64-linux-gnu/kamailio/kamctl/dbtextdb/dbtextdb.py", line 1233, in main > except (Error, e): > NameError: name 'e' is not defined --- Modified: utils/kamctl/dbtextdb/dbtextdb.py --- Diff: https://github.com/kamailio/kamailio/commit/1aca79c43cb8dbd920c1eb81c0c30cf… Patch: https://github.com/kamailio/kamailio/commit/1aca79c43cb8dbd920c1eb81c0c30cf… --- diff --git a/utils/kamctl/dbtextdb/dbtextdb.py b/utils/kamctl/dbtextdb/dbtextdb.py index 3a35554013..3d5ee7ecc5 100755 --- a/utils/kamctl/dbtextdb/dbtextdb.py +++ b/utils/kamctl/dbtextdb/dbtextdb.py @@ -356,7 +356,7 @@ def _EscapeChars(self, value): # test that the value is string, if not return it as is try: value.find('a') - except: + except Exception: return value escaped = value @@ -377,7 +377,7 @@ def _UnEscapeChars(self, value): # test that the value is string, if not return it as is try: value.find('a') - except: + except Exception: return value escaped = value @@ -988,21 +988,19 @@ def _TypeCheck(self, val, col): if not val and not self.header[col]['null']: raise ExecuteError(col + ' cannot be empty or null') - if (self.header[col]['type'].lower() == 'int' or - self.header[col]['type'].lower() == 'double'): + hdr_t = self.header[col]['type'].lower() + if hdr_t == 'int' or hdr_t == 'double': try: if val: val = eval(val) - except (NameError, e): + except NameError as e: raise ExecuteError('Failed to parse %s in %s ' '(unable to convert to type %s): %s' % - (col, self.table, self.header[col]['type'], - e)) - except (SyntaxError, e): + (col, self.table, hdr_t, e)) + except SyntaxError as e: raise ExecuteError('Failed to parse %s in %s ' '(unable to convert to type %s): %s' % - (col, self.table, self.header[col]['type'], - e)) + (col, self.table, hdr_t, e)) return val @@ -1083,7 +1081,7 @@ def OpenTable(self): # save a copy of the data before modifying self.orig_data = self.data[:] - except (IOError, e): + except IOError as e: raise ExecuteError('Unable to open table %s: %s' % (self.table, e)) Debug('Header is: %s' % self.header) @@ -1230,7 +1228,7 @@ def main(argv): print('Updated %s, rows affected: %d' % (conn.table, row)) else: print(row) - except (Error, e): + except Error as e: print(e) sys.exit(1)

1 0

[kamailio/kamailio] Kamailio service is failed (#2309)
by rombojack 04 May '20

04 May '20

I recently installed kamailio and it was enabled & started--> Service is active & running But once I added users I see kamailio service is failed [root@rlab111053 kamailio]# systemctl status kamailio ● kamailio.service - Kamailio (OpenSER) - the Open Source SIP Server Loaded: loaded (/etc/systemd/system/kamailio.service; enabled; vendor preset: disabled) Active: failed (Result: start-limit) since Wed 2020-04-29 18:47:26 IST; 860ms ago Process: 16759 ExecStart=/usr/sbin/kamailio -DD -P /var/run/kamailio/kamailio.pid -f $CFGFILE -m $SHM_MEMORY -M $PKG_MEMORY (code=exited, status=255) Main PID: 16759 (code=exited, status=255) Apr 29 18:47:25 rlab111053 systemd[1]: kamailio.service: main process exited, code=exited, status=255/n/a Apr 29 18:47:25 rlab111053 systemd[1]: Unit kamailio.service entered failed state. Apr 29 18:47:25 rlab111053 systemd[1]: kamailio.service failed. Apr 29 18:47:26 rlab111053 systemd[1]: kamailio.service holdoff time over, scheduling restart. Apr 29 18:47:26 rlab111053 systemd[1]: Stopped Kamailio (OpenSER) - the Open Source SIP Server. Apr 29 18:47:26 rlab111053 systemd[1]: start request repeated too quickly for kamailio.service Apr 29 18:47:26 rlab111053 systemd[1]: Failed to start Kamailio (OpenSER) - the Open Source SIP Server. Apr 29 18:47:26 rlab111053 systemd[1]: Unit kamailio.service entered failed state. Apr 29 18:47:26 rlab111053 systemd[1]: kamailio.service failed. **I am using below version** [root@rlab111053 kamailio]# kamailio -version version: kamailio 5.1.10 (x86_64/linux) cfcfd5 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: cfcfd5 compiled on 15:40:49 Mar 6 2020 with gcc 4.8.5 [root@rlab111053 kamailio]# Can some help to fix it  ### Description  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2309

3 3

[kamailio/kamailio] Add iteration by all DNS NAPTR records (#2290)
by Semen Darienko 03 May '20

03 May '20

Current stable release support using only one (first by ordering) NAPTR DNS record. I didn't find any ideas how to configure possibility for use all supported NAPTR / SRV records. This pull request resolve this issue. General issue: PreConditions: # host -t naptr voip.somehost.com voip.somehost.com has NAPTR record 1 0 "S" "SIPS+D2T" "" _sips._tcp.voip.somehost.com. voip.somehost.com has NAPTR record 2 0 "S" "SIP+D2U" "" _sip._udp.voip.somehost.com. # host -t srv _sips._tcp.voip.somehost.com _sips._tcp.voip.somehost.com has SRV record 1 1 443 voip.somehost.com. _sips._tcp.voip.somehost.com has SRV record 2 1 5061 192.168.1.50. _sips._tcp.voip.somehost.com has SRV record 3 1 5061 10.100.1.20. # host -t srv _sip._udp.voip.somehost.com _sip._udp.voip.somehost.com has SRV record 1 1 5060 voip.somehost.com. _sip._udp.voip.somehost.com has SRV record 2 1 5060 192.168.1.50. _sip._udp.voip.somehost.com has SRV record 3 1 5060 10.100.1.20. In my configuration of kamailio I don't see trying to use second by priority NAPTR record: voip.somehost.com has NAPTR record 2 0 "S" "SIP+D2U" "" _sip._udp.voip.somehost.com. Kindly ask to share your ideas regarding faced issue and my pull request. Thank you. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2290 -- Commit Summary -- * Add using all NAPTR records -- File Changes -- M src/core/dns_cache.c (86) M src/core/resolve.c (1) M src/core/resolve.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2290.patch https://github.com/kamailio/kamailio/pull/2290.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2290

2 3

git:master:28049aaf: core: dns - use all NAPTR records
by Daniel-Constantin Mierla 03 May '20

03 May '20

Module: kamailio Branch: master Commit: 28049aafc8dd06c160ce5e7b8d5e4fc728441b0c URL: https://github.com/kamailio/kamailio/commit/28049aafc8dd06c160ce5e7b8d5e4fc… Author: Semen Darienko <semen.darienko(a)wildix.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-03T12:26:45+02:00 core: dns - use all NAPTR records - enable using of all NAPTR records instead of the first one ordered by priority - GH #2290 --- Modified: src/core/dns_cache.c Modified: src/core/resolve.c Modified: src/core/resolve.h --- Diff: https://github.com/kamailio/kamailio/commit/28049aafc8dd06c160ce5e7b8d5e4fc… Patch: https://github.com/kamailio/kamailio/commit/28049aafc8dd06c160ce5e7b8d5e4fc… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index 81fc6a9e45..c8567813e5 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -2644,6 +2644,10 @@ struct naptr_rdata* dns_naptr_sip_iterate(struct dns_rr* naptr_head, } LM_DBG("found a valid sip NAPTR rr %.*s, proto %d\n", naptr->repl_len, naptr->repl, (int)naptr_proto); + if (naptr->skip_record) { + i++; + continue; + } if ((naptr_proto_supported(naptr_proto))){ if (naptr_choose(&naptr_saved, &saved_proto, naptr, naptr_proto)) @@ -3203,6 +3207,63 @@ inline static int dns_srv_sip_resolve(struct dns_srv_handle* h, str* name, #ifdef USE_NAPTR + + +static void mark_skip_current_naptr(struct dns_rr* naptr_head, struct dns_hash_entry* srv) +{ + int i; + struct dns_rr* l; + struct naptr_rdata* naptr; + + if (!naptr_head || !srv) { + return; + } + + for(l=naptr_head, i=0; l && (i<MAX_NAPTR_RRS); l=l->next, i++) { + naptr = (struct naptr_rdata *) l->rdata; + if (naptr == 0) { + break; + } + if (naptr->skip_record) { + continue; + } + if (srv->name_len == naptr->repl_len && !memcmp(srv->name, naptr->repl, srv->name_len)) { + naptr->skip_record = 1; + LM_NOTICE("Mark to skip %.*s NAPTR record due to all IPs are unreachable\n", naptr->repl_len, naptr->repl); + break; + } + } +} + + +inline static int have_more_active_naptr(struct dns_rr* naptr_head) +{ + int i, res = 0; + struct dns_rr* l; + struct naptr_rdata* naptr; + char naptr_proto; + + if (!naptr_head) { + return res; + } + + for(l=naptr_head, i=0; l && (i<MAX_NAPTR_RRS); l=l->next, i++) { + naptr = (struct naptr_rdata *) l->rdata; + if (naptr == 0) { + break; + } + if (naptr->skip_record) { + continue; + } else if ((naptr_proto = naptr_get_sip_proto(naptr)) <= 0) { + continue; + } else if ((naptr_proto_supported(naptr_proto))) { + res = 1; + break; + } + } + return res; +} + /* resolves a host name trying: * - NAPTR lookup if the address is not an ip and proto!=0, port!=0 * *port==0 and *proto=0 and if flags allow NAPTR lookups @@ -3227,6 +3288,7 @@ inline static int dns_naptr_sip_resolve(struct dns_srv_handle* h, str* name, char n_proto, origproto; str srv_name; int ret; + int try_lookup_naptr = 0; ret=-E_DNS_NO_NAPTR; if(proto) origproto=*proto; @@ -3259,9 +3321,27 @@ inline static int dns_naptr_sip_resolve(struct dns_srv_handle* h, str* name, *port=h->port; return 0; } - /* do naptr lookup */ - if ((e=dns_get_entry(name, T_NAPTR))==0) - goto naptr_not_found; + try_lookup_naptr = 1; + } + /* do naptr lookup */ + if ((e=dns_get_entry(name, T_NAPTR))==0) + goto naptr_not_found; + + if (!try_lookup_naptr) { + if(proto) *proto=origproto; + int res = dns_srv_sip_resolve(h, name, ip, port, proto, flags); + if (res) { + mark_skip_current_naptr(e->rr_lst, h->srv); + if (have_more_active_naptr(e->rr_lst)) { + // No more avaliable IP for current NAPTR record, let's try next one + try_lookup_naptr = 1; + } + } else { + return res; + } + } + + if (try_lookup_naptr) { naptr_iterate_init(&tried_bmp); while(dns_naptr_sip_iterate(e->rr_lst, &tried_bmp, &srv_name, &n_proto)){ diff --git a/src/core/resolve.c b/src/core/resolve.c index af269a2b42..193ac528af 100644 --- a/src/core/resolve.c +++ b/src/core/resolve.c @@ -407,6 +407,7 @@ struct naptr_rdata* dns_naptr_parser( unsigned char* msg, unsigned char* end, PKG_MEM_ERROR; goto error; } + naptr->skip_record = 0; naptr->order=ntohs(order); naptr->pref=ntohs(pref); diff --git a/src/core/resolve.h b/src/core/resolve.h index 5ef849ccf8..d49ebdc206 100644 --- a/src/core/resolve.h +++ b/src/core/resolve.h @@ -123,6 +123,7 @@ struct naptr_rdata { unsigned char services_len; unsigned char regexp_len; unsigned char repl_len; /* not currently used */ + unsigned char skip_record; char str_table[1]; /* contains all the strings */ };

1 0

git:master:3c7d378d: core: added LGTM analysis config file
by Daniel-Constantin Mierla 03 May '20

03 May '20

Module: kamailio Branch: master Commit: 3c7d378ddf3a21a2d4e1ac6bd64f9ea40bbd3602 URL: https://github.com/kamailio/kamailio/commit/3c7d378ddf3a21a2d4e1ac6bd64f9ea… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-03T11:38:59+02:00 core: added LGTM analysis config file - LGTM is integrated by github --- Added: .lgtm.yml --- Diff: https://github.com/kamailio/kamailio/commit/3c7d378ddf3a21a2d4e1ac6bd64f9ea… Patch: https://github.com/kamailio/kamailio/commit/3c7d378ddf3a21a2d4e1ac6bd64f9ea… --- diff --git a/.lgtm.yml b/.lgtm.yml new file mode 100644 index 0000000000..b3fa71bbf3 --- /dev/null +++ b/.lgtm.yml @@ -0,0 +1,29 @@ +extraction: + cpp: + prepare: + packages: + - "bison" + - "default-libmysqlclient-dev" + - "flex" + - "libcurl4-openssl-dev" + - "libjansson-dev" + - "libhiredis-dev" + - "liblua5.1-0-dev" + - "libpcre3-dev" + - "libncurses5-dev" + - "libpq-dev" + - "libreadline-dev" + - "libssl-dev" + - "libunistring-dev" + - "libxml2-dev" + - "pkg-config" + - "python3" + - "python3-dev" + - "uuid-dev" + - "zlib1g-dev" + after_prepare: + - "export PKG_CONFIG_PATH=$LGTM_WORKSPACE/usr/lib/pkgconfig:$PKG_CONFIG_PATH" + configure: + command: "make include_modules='app_lua app_python3 db_mysql db_postgres db_redis dialplan http_client jansson lcr ndb_redis presence presence_xml presence_dialoginfo pua pua_dialoginfo topos_redis uuid websocket xmlops' cfg" + index: + build_command: "make all"

1 0

git:master:a7496069: core: utils/tmrec - use safer localtime_r() instead of localtime()
by Daniel-Constantin Mierla 03 May '20

03 May '20

Module: kamailio Branch: master Commit: a7496069c60479e41d92830172bd5b9315001df5 URL: https://github.com/kamailio/kamailio/commit/a7496069c60479e41d92830172bd5b9… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-03T11:38:59+02:00 core: utils/tmrec - use safer localtime_r() instead of localtime() - coherent whitespacing and indentation --- Modified: src/core/utils/tmrec.c --- Diff: https://github.com/kamailio/kamailio/commit/a7496069c60479e41d92830172bd5b9… Patch: https://github.com/kamailio/kamailio/commit/a7496069c60479e41d92830172bd5b9…

1 0

git:master:6b69754f: misc: examples/kemi - missing parameter in kamailio-basic-kemi-python.py
by Daniel-Constantin Mierla 03 May '20

03 May '20

Module: kamailio Branch: master Commit: 6b69754f28ab8df61852b9f8695e59305a7c6c3a URL: https://github.com/kamailio/kamailio/commit/6b69754f28ab8df61852b9f8695e593… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-05-03T11:38:59+02:00 misc: examples/kemi - missing parameter in kamailio-basic-kemi-python.py --- Modified: misc/examples/kemi/kamailio-basic-kemi-python.py --- Diff: https://github.com/kamailio/kamailio/commit/6b69754f28ab8df61852b9f8695e593… Patch: https://github.com/kamailio/kamailio/commit/6b69754f28ab8df61852b9f8695e593… --- diff --git a/misc/examples/kemi/kamailio-basic-kemi-python.py b/misc/examples/kemi/kamailio-basic-kemi-python.py index dc0f7957da..64e0cc43fd 100644 --- a/misc/examples/kemi/kamailio-basic-kemi-python.py +++ b/misc/examples/kemi/kamailio-basic-kemi-python.py @@ -362,7 +362,7 @@ def ksr_onreply_manage(self, msg): # Manage failure routing cases # -- equivalent of failure_route[...]{} def ksr_failure_manage(self, msg): - if self.ksr_route_natmanage()==-255 : return 1; + if self.ksr_route_natmanage(msg)==-255 : return 1; if KSR.tm.t_is_canceled()>0 : return 1;

1 0

← Newer
1
...
33
34
35
36
37
38
39
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev May 2020