June 2020 - sr-dev - kamailio.org

git:5.3:fca18567: cnxcc: updated readme file [skip ci]
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: 5.3 Commit: fca18567f458fd3860a63ab37a9e7e2fe89f0019 URL: https://github.com/kamailio/kamailio/commit/fca18567f458fd3860a63ab37a9e7e2… Author: Jose Luis Verdeguer <pepeluxx(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T14:19:48+02:00 cnxcc: updated readme file [skip ci] (cherry picked from commit cea7fa14b0aefc647d28eb1bf56faaec89d90d67) --- Modified: src/modules/cnxcc/doc/cnxcc_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/fca18567f458fd3860a63ab37a9e7e2… Patch: https://github.com/kamailio/kamailio/commit/fca18567f458fd3860a63ab37a9e7e2… --- diff --git a/src/modules/cnxcc/doc/cnxcc_admin.xml b/src/modules/cnxcc/doc/cnxcc_admin.xml index 4284437a8b..0c26cb0a58 100644 --- a/src/modules/cnxcc/doc/cnxcc_admin.xml +++ b/src/modules/cnxcc/doc/cnxcc_admin.xml @@ -128,21 +128,37 @@ modparam("cnxcc", "credit_check_period", 1) <para> Associates the call with a customer id and sets the max credit, connect cost, cost per second, initial pulse and final pulse. The discount - is calculated in pulses (30/6, 1/1, etc) and subtracted from the pool + is calculated in pulses (1/1, 60/1, etc) and subtracted from the pool of credit. </para> <para> The customer value can be provided as a string or a variable holding - a string. + a string. This value identifies all calls from the same customer. + </para> + <para> + The maxcredit (float) value is the maximum credit available for the current call. + </para> + <para> + The connect (float) value is the connect cost for the current call. + </para> + <para> + The cps (float) value is the cost per second for the current call. + </para> + <para> + The ipuse (integer) value is the initial pulse and establishes the minimum + time to be charged. For example, value 1 establishes a charge per second + and value 60 sets a charge per minute. If it is taken as value 60, even + if the duration is 5 seconds, 1 minute will be charged. </para> <para> - The maxcredit, connect and cps can be double (float) or integer values, they - have to be provided as static string values of variables holding string - values. + The fpulse (integer) value is the final pulse and establishes, from the initial + pulse, the time range to be charged. For example, the value 1 establishes a charge + per second, 5 sets a charge in blocks of 5 seconds, 60 sets a full minute charge. </para> <para> - The ipulse and fpulse values are integer values, they can be also - given via variables holding integers. + 1/1 will make a charge per seconds for the entire call. 60/1 will make a + charge per seconds with the first full minute. 60/60 always perform + a full minute charge. </para> <para> <emphasis>Return code:</emphasis> @@ -173,12 +189,15 @@ modparam("cnxcc", "credit_check_period", 1) ... cnxcc_set_max_credit("john-doe", "100", "3.0", "0.5", 60, 1); ... -$var(customer) = "john-doe-premium"; # customer id -$var(credit) = "100"; # max credit -$var(connect) = "3.0"; # connect const -$var(cps) = "0.5"; # cost per second -$var(initial_p) = 60; # initial pulse -$var(final_p) = 1; # final pulse +$var(customer) = "john-doe"; # customer id +$var(credit) = "100"; # max credit for all calls with the same + # customer id +$var(connect) = "3.0"; # connect cost or initial cost for the call +$var(cps) = "0.5"; # cost per second +$var(initial_p) = 60; # initial pulse (60 = the first minute will be + # charged even if the call is shorter) +$var(final_p) = 1; # final pulse (after the first minute, it will + # be charge in ranges of 1 second) cnxcc_set_max_credit("$var(customer)", "$var(credit)", "$var(connect)", "$var(cps)", "$var(initial_p)", "$var(final_p)"); ...

1 0

git:5.3:daecf049: cnxcc: use snprintf() instead of sprintf()
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: 5.3 Commit: daecf0490c144a6f3fd5c66c53a86f33b6295681 URL: https://github.com/kamailio/kamailio/commit/daecf0490c144a6f3fd5c66c53a86f3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T14:17:17+02:00 cnxcc: use snprintf() instead of sprintf() (cherry picked from commit 05bd956a9980ffc8938cdbce6bab3af5086350dd) --- Modified: src/modules/cnxcc/cnxcc_sip_msg_faker.c --- Diff: https://github.com/kamailio/kamailio/commit/daecf0490c144a6f3fd5c66c53a86f3… Patch: https://github.com/kamailio/kamailio/commit/daecf0490c144a6f3fd5c66c53a86f3… --- diff --git a/src/modules/cnxcc/cnxcc_sip_msg_faker.c b/src/modules/cnxcc/cnxcc_sip_msg_faker.c index 7b601d537a..dbb8694f6a 100644 --- a/src/modules/cnxcc/cnxcc_sip_msg_faker.c +++ b/src/modules/cnxcc/cnxcc_sip_msg_faker.c @@ -40,7 +40,7 @@ int faked_msg_init_with_dlg_info(str *callid, str *from_uri, str *from_tag, { memset(_faked_sip_msg_buf, 0, FAKED_SIP_MSG_BUF_LEN); - sprintf(_faked_sip_msg_buf, FAKED_SIP_MSG_FORMAT, from_uri->len, + snprintf(_faked_sip_msg_buf, FAKED_SIP_MSG_BUF_LEN, FAKED_SIP_MSG_FORMAT, from_uri->len, from_uri->s, from_tag->len, from_tag->s, to_uri->len, to_uri->s, to_tag->len, to_tag->s, callid->len, callid->s);

1 0

git:master:8e2c2e39: Merge pull request #2342 from kamailio/grumvalski/ds_load_table
by GitHub 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 8e2c2e391eb90f53b0fdc3e108bb84dab4e11593 URL: https://github.com/kamailio/kamailio/commit/8e2c2e391eb90f53b0fdc3e108bb84d… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-05T13:28:33+02:00 Merge pull request #2342 from kamailio/grumvalski/ds_load_table dispatcher: don't reset load table when adding/removing a destinationâ¦ --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/8e2c2e391eb90f53b0fdc3e108bb84d… Patch: https://github.com/kamailio/kamailio/commit/8e2c2e391eb90f53b0fdc3e108bb84d… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index d859dc3907..f481cb4d61 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -878,7 +878,7 @@ int ds_load_list(char *lfile) /* Update list - should it be sync'ed? */ _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0; @@ -1126,7 +1126,6 @@ int ds_load_db(void) /* update data - should it be sync'ed? */ _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); ds_log_sets(); @@ -1617,22 +1616,24 @@ int ds_load_replace(struct sip_msg *msg, str *duid) break; } } + /* old destination has not been found: has been removed meanwhile? */ if(olddst == -1) { - ds_unlock_cell(_dsht_load, &msg->callid->body); - LM_ERR("old destination address not found for [%d, %.*s]\n", set, + LM_WARN("old destination address not found for [%d, %.*s]\n", set, it->duid.len, it->duid.s); - return -1; - } + } if(newdst == -1) { + /* new destination has not been found: has been removed meanwhile? */ ds_unlock_cell(_dsht_load, &msg->callid->body); LM_ERR("new destination address not found for [%d, %.*s]\n", set, duid->len, duid->s); - return -1; + return -2; } ds_unlock_cell(_dsht_load, &msg->callid->body); ds_del_cell(_dsht_load, &msg->callid->body); - DS_LOAD_DEC(idx, olddst); + + if(olddst != -1) + DS_LOAD_DEC(idx, olddst); if(ds_load_add(msg, idx, set, newdst) < 0) { LM_ERR("unable to replace destination load [%.*s / %.*s]\n", duid->len, @@ -2336,6 +2337,7 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) int ds_update_dst(struct sip_msg *msg, int upos, int mode) { + int ret; socket_info_t *sock = NULL; sr_xavp_t *rxavp = NULL; sr_xavp_t *lxavp = NULL; @@ -2348,6 +2350,7 @@ int ds_update_dst(struct sip_msg *msg, int upos, int mode) } } +next_dst: rxavp = xavp_get(&ds_xavp_dst, NULL); if(rxavp == NULL || rxavp->val.type != SR_XTYPE_XAVP) { LM_DBG("no xavp with previous destination record\n"); @@ -2395,12 +2398,18 @@ int ds_update_dst(struct sip_msg *msg, int upos, int mode) return 1; } if(upos == DS_USE_NEXT) { - if(ds_load_replace(msg, &lxavp->val.v.s) < 0) { - LM_ERR("cannot update load distribution\n"); - return -1; + ret = ds_load_replace(msg, &lxavp->val.v.s); + switch(ret) { + case 0: + break; + case -2: + LM_ERR("cannot update load with %.*s, skipping dst.\n", lxavp->val.v.s.len, lxavp->val.v.s.s); + goto next_dst; + default: + LM_ERR("cannot update load distribution\n"); + return -1; } } - return 1; } @@ -2448,7 +2457,7 @@ int ds_add_dst(int group, str *address, int flags, str *attrs) _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0; @@ -2503,7 +2512,7 @@ int ds_remove_dst(int group, str *address) _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0;

1 0

git:master:4099a6ca: dispatcher: don't reset load table when adding/removing a destination or reloading the list
by Federico Cabiddu 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 4099a6caf856c9af4d7d89aec73db143efbcd40b URL: https://github.com/kamailio/kamailio/commit/4099a6caf856c9af4d7d89aec73db14… Author: Federico Cabiddu <federico.cabiddu(a)gmail.com> Committer: Federico Cabiddu <federico.cabiddu(a)gmail.com> Date: 2020-06-01T07:30:14+02:00 dispatcher: don't reset load table when adding/removing a destination or reloading the list --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/4099a6caf856c9af4d7d89aec73db14… Patch: https://github.com/kamailio/kamailio/commit/4099a6caf856c9af4d7d89aec73db14… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index d859dc3907..f481cb4d61 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -878,7 +878,7 @@ int ds_load_list(char *lfile) /* Update list - should it be sync'ed? */ _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0; @@ -1126,7 +1126,6 @@ int ds_load_db(void) /* update data - should it be sync'ed? */ _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); ds_log_sets(); @@ -1617,22 +1616,24 @@ int ds_load_replace(struct sip_msg *msg, str *duid) break; } } + /* old destination has not been found: has been removed meanwhile? */ if(olddst == -1) { - ds_unlock_cell(_dsht_load, &msg->callid->body); - LM_ERR("old destination address not found for [%d, %.*s]\n", set, + LM_WARN("old destination address not found for [%d, %.*s]\n", set, it->duid.len, it->duid.s); - return -1; - } + } if(newdst == -1) { + /* new destination has not been found: has been removed meanwhile? */ ds_unlock_cell(_dsht_load, &msg->callid->body); LM_ERR("new destination address not found for [%d, %.*s]\n", set, duid->len, duid->s); - return -1; + return -2; } ds_unlock_cell(_dsht_load, &msg->callid->body); ds_del_cell(_dsht_load, &msg->callid->body); - DS_LOAD_DEC(idx, olddst); + + if(olddst != -1) + DS_LOAD_DEC(idx, olddst); if(ds_load_add(msg, idx, set, newdst) < 0) { LM_ERR("unable to replace destination load [%.*s / %.*s]\n", duid->len, @@ -2336,6 +2337,7 @@ int ds_manage_routes(sip_msg_t *msg, ds_select_state_t *rstate) int ds_update_dst(struct sip_msg *msg, int upos, int mode) { + int ret; socket_info_t *sock = NULL; sr_xavp_t *rxavp = NULL; sr_xavp_t *lxavp = NULL; @@ -2348,6 +2350,7 @@ int ds_update_dst(struct sip_msg *msg, int upos, int mode) } } +next_dst: rxavp = xavp_get(&ds_xavp_dst, NULL); if(rxavp == NULL || rxavp->val.type != SR_XTYPE_XAVP) { LM_DBG("no xavp with previous destination record\n"); @@ -2395,12 +2398,18 @@ int ds_update_dst(struct sip_msg *msg, int upos, int mode) return 1; } if(upos == DS_USE_NEXT) { - if(ds_load_replace(msg, &lxavp->val.v.s) < 0) { - LM_ERR("cannot update load distribution\n"); - return -1; + ret = ds_load_replace(msg, &lxavp->val.v.s); + switch(ret) { + case 0: + break; + case -2: + LM_ERR("cannot update load with %.*s, skipping dst.\n", lxavp->val.v.s.len, lxavp->val.v.s.s); + goto next_dst; + default: + LM_ERR("cannot update load distribution\n"); + return -1; } } - return 1; } @@ -2448,7 +2457,7 @@ int ds_add_dst(int group, str *address, int flags, str *attrs) _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0; @@ -2503,7 +2512,7 @@ int ds_remove_dst(int group, str *address) _ds_list_nr = setn; *crt_idx = *next_idx; - ds_ht_clear_slots(_dsht_load); + ds_log_sets(); return 0;

1 0

git:5.3:a41dcf32: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 05 Jun '20

05 Jun '20

Module: kamailio Branch: 5.3 Commit: a41dcf3259d72dfecf4cd34638d885734dc7a5ea URL: https://github.com/kamailio/kamailio/commit/a41dcf3259d72dfecf4cd34638d8857… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-05T12:31:49+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/a41dcf3259d72dfecf4cd34638d8857… Patch: https://github.com/kamailio/kamailio/commit/a41dcf3259d72dfecf4cd34638d8857… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index 5eab39eb23..df5b99f7cc 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -472,8 +472,10 @@ modparam("siptrace", "auth_key", "spoihepuirthpeuia") Store or forward the current processed SIP message/transaction/dialog in database. It is stored in the form prior applying changes made to - it. Based on mode, one can trace the current message('m' - default), - the current transaction('t') or the current dialog('d'). + it. Based on mode, one can trace the current message('m'), the current + transaction('t') or the current dialog('d'). If no mode is given, it + falls back to the default mode - transaction tracking when trace_flag + is set, otherwise only the current message. Meaning of the parameters is as follows: * address - The address in form of SIP URI where to send a duplicate @@ -564,13 +566,13 @@ kamcmd siptrace.status check 6. Database setup - Before running Kamailio with siptrace, you have to setup the database - tables where the module will store the data. For that, if the table - were not created by the installation script or you choose to install - everything by yourself you can use the siptrace-create.sql SQL script - in the database directories in the kamailio/scripts folder as template. - You can also find the complete database documentation on the project - webpage, + Before running Kamailio with siptrace and activated trace_to_database + parameter, you have to setup the database tables where the module will + store the data. For that, if the table were not created by the + installation script or you choose to install everything by yourself you + can use the siptrace-create.sql SQL script in the database directories + in the kamailio/scripts folder as template. You can also find the + complete database documentation on the project webpage, https://www.kamailio.org/docs/db-tables/kamailio-db-devel.html. 7. Known issues

1 0

git:master:a118641a: modules: readme files regenerated - siptrace ... [skip ci]
by Kamailio Dev 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: a118641af8fb6bdd288e97c17b12076db6442ef9 URL: https://github.com/kamailio/kamailio/commit/a118641af8fb6bdd288e97c17b12076… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-05T12:31:22+02:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/a118641af8fb6bdd288e97c17b12076… Patch: https://github.com/kamailio/kamailio/commit/a118641af8fb6bdd288e97c17b12076… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index 9006415a23..d9130a312e 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -551,8 +551,10 @@ modparam("siptrace", "auth_key", "spoihepuirthpeuia") Store or forward the current processed SIP message/transaction/dialog in database. It is stored in the form prior applying changes made to - it. Based on mode, one can trace the current message('m' - default), - the current transaction('t') or the current dialog('d'). + it. Based on mode, one can trace the current message('m'), the current + transaction('t') or the current dialog('d'). If no mode is given, it + falls back to the default mode - transaction tracking when trace_flag + is set, otherwise only the current message. Meaning of the parameters is as follows: * address - The address in form of SIP URI where to send a duplicate @@ -643,13 +645,13 @@ kamcmd siptrace.status check 6. Database setup - Before running Kamailio with siptrace, you have to setup the database - tables where the module will store the data. For that, if the table - were not created by the installation script or you choose to install - everything by yourself you can use the siptrace-create.sql SQL script - in the database directories in the kamailio/scripts folder as template. - You can also find the complete database documentation on the project - webpage, + Before running Kamailio with siptrace and activated trace_to_database + parameter, you have to setup the database tables where the module will + store the data. For that, if the table were not created by the + installation script or you choose to install everything by yourself you + can use the siptrace-create.sql SQL script in the database directories + in the kamailio/scripts folder as template. You can also find the + complete database documentation on the project webpage, https://www.kamailio.org/docs/db-tables/kamailio-db-devel.html. 7. Known issues

1 0

git:5.3:0f733090: siptrace: fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode()
by Henning Westerholt 05 Jun '20

05 Jun '20

Module: kamailio Branch: 5.3 Commit: 0f733090f69f88a153040e0051057bfd3a9a8404 URL: https://github.com/kamailio/kamailio/commit/0f733090f69f88a153040e0051057bf… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-05T10:29:48Z siptrace: fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode() - fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode() - it was not working properly without destination uri in non-HEP mode (cherry picked from commit 21338195e74b09ccca29d6479e698417ed34cd42) --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/0f733090f69f88a153040e0051057bf… Patch: https://github.com/kamailio/kamailio/commit/0f733090f69f88a153040e0051057bf… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index e49946e525..161986d2cf 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -534,7 +534,8 @@ static int sip_trace_store(siptrace_data_t *sto, dest_info_t *dst, trace_send_hep_duplicate( &sto->body, &sto->fromip, &sto->toip, dst, correlation_id_str); } else { - if(dst) { + /* sip_trace_mode() will not set a destination, uses duplicate_uri */ + if(dst || trace_to_database == 0) { trace_send_duplicate(sto->body.s, sto->body.len, dst); } } @@ -996,10 +997,13 @@ static int w_sip_trace3(sip_msg_t *msg, char *dest, char *correlation_id, char * dest_info_t dest_info; enum siptrace_type_t trace_type; - if (dest) { - if(fixup_get_svalue(msg, (gparam_t *)dest, &dup_uri_param_str) != 0) { - LM_ERR("unable to parse the dest URI string\n"); - return -1; + /* to support tracing to database without destination parameter - old mode */ + if (dest || trace_to_database == 0) { + if (dest) { + if(fixup_get_svalue(msg, (gparam_t *)dest, &dup_uri_param_str) != 0) { + LM_ERR("unable to parse the dest URI string\n"); + return -1; + } } if (dup_uri_param_str.s == 0 || (is_null_pv(dup_uri_param_str))) {

1 0

git:5.3:05a6f13c: siptrace: manual backport of 75e6e370ceb7, improve documentation for siptrace and DB setup
by Henning Westerholt 05 Jun '20

05 Jun '20

Module: kamailio Branch: 5.3 Commit: 05a6f13c40249e0d658016652ae46b8512149857 URL: https://github.com/kamailio/kamailio/commit/05a6f13c40249e0d658016652ae46b8… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-05T10:29:10Z siptrace: manual backport of 75e6e370ceb7, improve documentation for siptrace and DB setup --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/05a6f13c40249e0d658016652ae46b8… Patch: https://github.com/kamailio/kamailio/commit/05a6f13c40249e0d658016652ae46b8… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 6b3a1f49f8..f5be1c663c 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -522,7 +522,9 @@ modparam("siptrace", "auth_key", "spoihepuirthpeuia") <para> Store or forward the current processed SIP message/transaction/dialog in database. It is stored in the form prior applying changes made to it. Based on mode, one can trace - the current message('m' - default), the current transaction('t') or the current dialog('d'). + the current message('m'), the current transaction('t') or the current dialog('d'). + If no mode is given, it falls back to the default mode - transaction tracking when + trace_flag is set, otherwise only the current message. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -674,12 +676,12 @@ hlog("$hdr(P-MyID)", "Another one with a custom correlation ID"); <section> <title>Database setup</title> <para> - Before running &kamailio; with siptrace, you have to setup the database - tables where the module will store the data. For that, if the - table were not created by the installation script or you choose - to install everything by yourself you can use the siptrace-create.sql - <acronym>SQL</acronym> script in the database directories in the - kamailio/scripts folder as template. + Before running &kamailio; with siptrace and activated trace_to_database + parameter, you have to setup the database tables where the module will + store the data. For that, if the table were not created by the + installation script or you choose to install everything by yourself + you can use the siptrace-create.sql <acronym>SQL</acronym> script in + the database directories in the kamailio/scripts folder as template. You can also find the complete database documentation on the project webpage, &kamailiodbdocslink;. </para>

1 0

git:master:21338195: siptrace: fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode()
by Henning Westerholt 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 21338195e74b09ccca29d6479e698417ed34cd42 URL: https://github.com/kamailio/kamailio/commit/21338195e74b09ccca29d6479e69841… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-05T10:25:46Z siptrace: fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode() - fix regression introduced from 4e9a760123c for siptrace(), sip_trace_mode() - it was not working properly without destination uri in non-HEP mode --- Modified: src/modules/siptrace/siptrace.c --- Diff: https://github.com/kamailio/kamailio/commit/21338195e74b09ccca29d6479e69841… Patch: https://github.com/kamailio/kamailio/commit/21338195e74b09ccca29d6479e69841… --- diff --git a/src/modules/siptrace/siptrace.c b/src/modules/siptrace/siptrace.c index 6cc3471fcf..1368e954a6 100644 --- a/src/modules/siptrace/siptrace.c +++ b/src/modules/siptrace/siptrace.c @@ -562,7 +562,8 @@ static int sip_trace_store(siptrace_data_t *sto, dest_info_t *dst, trace_send_hep_duplicate( &sto->body, &sto->fromip, &sto->toip, dst, correlation_id_str); } else { - if(dst) { + /* sip_trace_mode() will not set a destination, uses duplicate_uri */ + if(dst || trace_to_database == 0) { trace_send_duplicate(sto->body.s, sto->body.len, dst); } } @@ -1070,10 +1071,13 @@ static int w_sip_trace3(sip_msg_t *msg, char *dest, char *correlation_id, char * dest_info_t dest_info; enum siptrace_type_t trace_type; - if (dest) { - if(fixup_get_svalue(msg, (gparam_t *)dest, &dup_uri_param_str) != 0) { - LM_ERR("unable to parse the dest URI string\n"); - return -1; + /* to support tracing to database without destination parameter - old mode */ + if (dest || trace_to_database == 0) { + if (dest) { + if(fixup_get_svalue(msg, (gparam_t *)dest, &dup_uri_param_str) != 0) { + LM_ERR("unable to parse the dest URI string\n"); + return -1; + } } if (dup_uri_param_str.s == 0 || (is_null_pv(dup_uri_param_str))) {

1 0

git:master:75e6e370: siptrace: improve documentation about sip_trace and DB setup
by Henning Westerholt 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 75e6e370ceb701eabbdb2a1b7f12311ba0ae5024 URL: https://github.com/kamailio/kamailio/commit/75e6e370ceb701eabbdb2a1b7f12311… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-05T10:25:46Z siptrace: improve documentation about sip_trace and DB setup --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/75e6e370ceb701eabbdb2a1b7f12311… Patch: https://github.com/kamailio/kamailio/commit/75e6e370ceb701eabbdb2a1b7f12311… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 5bd274a2f0..7d5b0d34ef 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -643,7 +643,9 @@ modparam("siptrace", "auth_key", "spoihepuirthpeuia") <para> Store or forward the current processed SIP message/transaction/dialog in database. It is stored in the form prior applying changes made to it. Based on mode, one can trace - the current message('m' - default), the current transaction('t') or the current dialog('d'). + the current message('m'), the current transaction('t') or the current dialog('d'). + If no mode is given, it falls back to the default mode - transaction tracking when + trace_flag is set, otherwise only the current message. </para> <para>Meaning of the parameters is as follows:</para> <itemizedlist> @@ -795,12 +797,12 @@ hlog("$hdr(P-MyID)", "Another one with a custom correlation ID"); <section> <title>Database setup</title> <para> - Before running &kamailio; with siptrace, you have to setup the database - tables where the module will store the data. For that, if the - table were not created by the installation script or you choose - to install everything by yourself you can use the siptrace-create.sql - <acronym>SQL</acronym> script in the database directories in the - kamailio/scripts folder as template. + Before running &kamailio; with siptrace and activated trace_to_database + parameter, you have to setup the database tables where the module will + store the data. For that, if the table were not created by the + installation script or you choose to install everything by yourself + you can use the siptrace-create.sql <acronym>SQL</acronym> script in + the database directories in the kamailio/scripts folder as template. You can also find the complete database documentation on the project webpage, &kamailiodbdocslink;. </para>

1 0

[kamailio/kamailio] core: do not return connection if port does not match (#2307)
by Donato Sciarra 05 Jun '20

05 Jun '20

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description If kamailio is behind a NAT only return connection if port matches. We observed this issue on an instance after ~10h of operation. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2307 -- Commit Summary -- * core: do not return connection if port does not match -- File Changes -- M src/core/tcp_main.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2307.patch https://github.com/kamailio/kamailio/pull/2307.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2307

2 7

[kamailio/kamailio] topos and 183 replies without Contact header (#2344)
by Barry Flanagan 05 Jun '20

05 Jun '20

Further to the changes made in https://github.com/kamailio/kamailio/issues/1720 I am opening a new ticket regarding https://github.com/kamailio/kamailio/issues/1720#issuecomment-638158699 It is my understanding that 1xx replies do not require a Contact header, but commit https://github.com/kamailio/kamailio/commit/3b586d554740ae578283024c1508e91… specifically excludes 183 replies from passing without a Contact header. This is causing us some issues and I am wondering why 183 is set to require the Contact header. Thanks -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2344

2 2

[kamailio/kamailio] 180 Ringing without Contact with TOPOS enabled (#1720)
by Sergey Basov 05 Jun '20

05 Jun '20

### Description Kamailio with TOPOS enabled acts as a proxy between SIP client and SBC. When client sends "180 Ringing" without Contact header - kamailio does not forward it to SBC. If Contact header exists in "180 Ringing" - all works as expected. ### Troubleshooting #### Reproduction Load and configure topos module Make call with "180 Ringing" without Contact header - kamailio will not forward it. #### Log Messages ``` ERROR: topos [tps_storage.c:340]: tps_storage_link_msg(): bad sip message or missing Contact hdr ``` #### SIP Traffic ``` SIP/2.0 180 Ringing Via: SIP/2.0/TLS 1.2.3.4:5061;branch=z9hG4bKef45.8c75f0bae8a59dfaec6ff533ff0f3b2d.0 From: <sip:1111@1.2.3.4:5061>;tag=02000879948559 To: <sip:2.2.2.2@5.6.7.8:5061;transport=tls;user=phone>;tag=SDbsq8499-y2pMOVV Call-ID: apdW7374315131g0bcGhEfDjFof CSeq: 988207425 INVITE User-Agent: agent Supported: replaces, outbound Content-Length: 0 ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.1.6 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select ``` * **Operating System**: ``` Red Hat Enterprise Linux Server 7.3 3.10.0-514.el7.x86_64 #1 SMP Wed Oct 19 11:24:13 EDT 2016 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/1720

5 19

git:master:785326cd: topos: allow 183 without contact header
by Daniel-Constantin Mierla 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 785326cdfbee849a8436e7c07003ff0539d259cd URL: https://github.com/kamailio/kamailio/commit/785326cdfbee849a8436e7c07003ff0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-05T09:47:32+02:00 topos: allow 183 without contact header - some UAs do not add it, even it can create the session for PRACK, which requires it --- Modified: src/modules/topos/tps_storage.c --- Diff: https://github.com/kamailio/kamailio/commit/785326cdfbee849a8436e7c07003ff0… Patch: https://github.com/kamailio/kamailio/commit/785326cdfbee849a8436e7c07003ff0… --- diff --git a/src/modules/topos/tps_storage.c b/src/modules/topos/tps_storage.c index 8583f1b37c..9cdd9ff3d5 100644 --- a/src/modules/topos/tps_storage.c +++ b/src/modules/topos/tps_storage.c @@ -355,8 +355,7 @@ int tps_storage_link_msg(sip_msg_t *msg, tps_data_t *td, int dir) } if(msg->first_line.type==SIP_REPLY) { if(msg->first_line.u.reply.statuscode>=100 - && msg->first_line.u.reply.statuscode<200 - && msg->first_line.u.reply.statuscode!=183) { + && msg->first_line.u.reply.statuscode<200) { /* provisional response with no mandatory contact header */ return 0; }

1 0

git:master:974038f5: pv: vars to get the length for o-uri/r-uri/f-uri/t-uri username
by Daniel-Constantin Mierla 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 974038f5f81382fe6fa6565f0ab9ea0f2cf9896f URL: https://github.com/kamailio/kamailio/commit/974038f5f81382fe6fa6565f0ab9ea0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-05T09:39:50+02:00 pv: vars to get the length for o-uri/r-uri/f-uri/t-uri username - $oUl, $rUl, $fUl. $tUl - the length is already available in the str value, optimizing a bit by no longer having to use {s.len} --- Modified: src/modules/pv/pv.c Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/974038f5f81382fe6fa6565f0ab9ea0… Patch: https://github.com/kamailio/kamailio/commit/974038f5f81382fe6fa6565f0ab9ea0… --- diff --git a/src/modules/pv/pv.c b/src/modules/pv/pv.c index 0308514e70..4d3d8b343c 100644 --- a/src/modules/pv/pv.c +++ b/src/modules/pv/pv.c @@ -272,6 +272,9 @@ static pv_export_t mod_pvs[] = { {{"from.user", (sizeof("from.user")-1)}, /* */ PVT_OTHER, pv_get_from_attr, pv_set_from_username, 0, 0, pv_init_iname, 2}, + {{"fUl", (sizeof("fUl")-1)}, /* */ + PVT_OTHER, pv_get_from_attr, 0, + 0, 0, pv_init_iname, 6}, {{"mb", (sizeof("mb")-1)}, /* */ PVT_OTHER, pv_get_msg_buf, 0, 0, 0, 0, 0}, @@ -314,6 +317,9 @@ static pv_export_t mod_pvs[] = { {{"oU", (sizeof("oU")-1)}, /* */ PVT_OTHER, pv_get_ouri_attr, 0, 0, 0, pv_init_iname, 1}, + {{"oUl", (sizeof("oUl")-1)}, /* */ + PVT_OTHER, pv_get_ouri_attr, 0, + 0, 0, pv_init_iname, 6}, {{"pd", (sizeof("pd")-1)}, /* */ PVT_OTHER, pv_get_ppi_attr, 0, 0, pv_parse_index, pv_init_iname, 3}, @@ -383,6 +389,9 @@ static pv_export_t mod_pvs[] = { {{"ruri.user", (sizeof("ruri.user")-1)}, /* */ PVT_RURI_USERNAME, pv_get_ruri_attr, pv_set_ruri_user, 0, 0, pv_init_iname, 1}, + {{"rUl", (sizeof("rUl")-1)}, /* */ + PVT_RURI_USERNAME, pv_get_ruri_attr, 0, + 0, 0, pv_init_iname, 6}, {{"rv", (sizeof("rv")-1)}, /* */ PVT_OTHER, pv_get_version, 0, 0, 0, 0, 0}, @@ -470,6 +479,9 @@ static pv_export_t mod_pvs[] = { {{"to.user", (sizeof("to.user")-1)}, /* */ PVT_OTHER, pv_get_to_attr, pv_set_to_username, 0, 0, pv_init_iname, 2}, + {{"tUl", (sizeof("tUl")-1)}, /* */ + PVT_OTHER, pv_get_to_attr, pv_set_to_username, + 0, 0, pv_init_iname, 6}, {{"true", (sizeof("true")-1)}, /* */ PVT_OTHER, pv_get_true, 0, 0, 0, 0, 0}, diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index ae91aa9d82..7b28fb966e 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -323,6 +323,10 @@ int pv_get_xuri_attr(struct sip_msg *msg, struct sip_uri *parsed_uri, } else if(param->pvn.u.isname.name.n==5) /* uri scheme */ { return pv_get_strintval(msg, param, res, &pv_uri_scheme[parsed_uri->type], (int)parsed_uri->type); + } else if(param->pvn.u.isname.name.n==6) /* username length */ { + if(parsed_uri->user.s==NULL || parsed_uri->user.len<=0) + return pv_get_sintval(msg, param, res, 0); + return pv_get_sintval(msg, param, res, parsed_uri->user.len); } LM_ERR("unknown specifier\n"); return pv_get_null(msg, param, res); @@ -452,6 +456,11 @@ int pv_get_xto_attr(struct sip_msg *msg, pv_param_t *param, return pv_get_null(msg, param, res); } return pv_get_strval(msg, param, res, &uri->host); + } else if(param->pvn.u.isname.name.n==6) /* username length */ { + if(uri->user.s==NULL || uri->user.len<=0) { + return pv_get_sintval(msg, param, res, 0); + } + return pv_get_sintval(msg, param, res, uri->user.len); } LM_ERR("unknown specifier\n");

1 0

[kamailio/kamailio] core: PV_IDX_NONE to point that pv had no index (#2341)
by Victor Seva 05 Jun '20

05 Jun '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [x] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally #### Description  if index is 0 there were no way to know if the index was there $x_hdr(A) = "value" needs to append a value $(x_hdr(A)[0]) = "value" needs to set the value pv_parse_spec(str *s, pv_spec_p p) was always setting p->pvp.pvi.type to 0 == PV_IDX_INT You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2341 -- Commit Summary -- * core: PV_IDX_NONE to point that pv had no index -- File Changes -- M src/core/pvapi.c (7) M src/core/pvar.h (1) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2341.patch https://github.com/kamailio/kamailio/pull/2341.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2341

2 6

git:master:6e96e8a9: pv: fix for new PV_IDX_NONE value
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 6e96e8a9134ed204f4fcf3cd42f6f9f274ea7851 URL: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T08:54:17+02:00 pv: fix for new PV_IDX_NONE value --- Modified: src/modules/pv/pv_core.c --- Diff: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… Patch: https://github.com/kamailio/kamailio/commit/6e96e8a9134ed204f4fcf3cd42f6f9f… --- diff --git a/src/modules/pv/pv_core.c b/src/modules/pv/pv_core.c index e53db70c25..ae91aa9d82 100644 --- a/src/modules/pv/pv_core.c +++ b/src/modules/pv/pv_core.c @@ -1823,7 +1823,7 @@ int pv_get_avp(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) if ((avp=search_first_avp(name_type, avp_name, &avp_value, &state))==0) return pv_get_null(msg, param, res); res->flags = PV_VAL_STR; - if(idxf==0 && idx==0) + if(idx==0 && (idxf==PV_IDX_INT || idxf==PV_IDX_NONE)) { if(avp->flags & AVP_VAL_STR) { @@ -1981,7 +1981,7 @@ int pv_get_hdr(struct sip_msg *msg, pv_param_t *param, pv_value_t *res) /* get the value */ res->flags = PV_VAL_STR; - if(idxf==0 && idx==0) + if(idx==0 && (idxf==PV_IDX_INT || idxf==PV_IDX_NONE)) { res->rs = hf->body; return 0;

1 0

git:master:7bb26695: core: PV_IDX_NONE to point that pv had no index
by Victor Seva 05 Jun '20

05 Jun '20

Module: kamailio Branch: master Commit: 7bb2669528a819ec29a8193eebc9c641edd69993 URL: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-05T08:54:17+02:00 core: PV_IDX_NONE to point that pv had no index if index is 0 there were no way to know if the index was there $x_hdr(A) = "value" needs to append a value $(x_hdr(A)[0]) = "value" needs to set the value pv_parse_spec(str *s, pv_spec_p p) was always setting p->pvp.pvi.type to 0 == PV_IDX_INT --- Modified: src/core/pvapi.c Modified: src/core/pvar.h --- Diff: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… Patch: https://github.com/kamailio/kamailio/commit/7bb2669528a819ec29a8193eebc9c64… --- diff --git a/src/core/pvapi.c b/src/core/pvapi.c index 0148578315..30b2a7cdfe 100644 --- a/src/core/pvapi.c +++ b/src/core/pvapi.c @@ -857,6 +857,7 @@ char* pv_parse_spec2(str *in, pv_spec_p e, int silent) tr = 0; pvstate = 0; memset(e, 0, sizeof(pv_spec_t)); + e->pvp.pvi.type = PV_IDX_NONE; p = in->s; p++; if(*p==PV_LNBRACKET) @@ -1369,6 +1370,12 @@ int pv_get_spec_index(struct sip_msg* msg, pv_param_p ip, int *idx, int *flags) *idx = ip->pvi.u.ival; return 0; } + if(ip->pvi.type == PV_IDX_NONE) + { + *flags = PV_IDX_NONE; + *idx = ip->pvi.u.ival; + return 0; + } /* pvar */ if(pv_get_spec_value(msg, (pv_spec_p)ip->pvi.u.dval, &tv)!=0) diff --git a/src/core/pvar.h b/src/core/pvar.h index 1415f84af0..155b0125fb 100644 --- a/src/core/pvar.h +++ b/src/core/pvar.h @@ -61,6 +61,7 @@ #define PV_IDX_PVAR 1 #define PV_IDX_ALL 2 #define PV_IDX_ITR 3 +#define PV_IDX_NONE 4 /*! if PV name is dynamic, integer, or str */ #define pv_has_dname(pv) ((pv)->pvp.pvn.type==PV_NAME_PVAR)

1 0

git:master:dd28ea04: app_jsdt: duktape interpreter upgraded to v2.5.0
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: dd28ea040b78bf972a9b54177a8025eb8e885683 URL: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T19:26:09+02:00 app_jsdt: duktape interpreter upgraded to v2.5.0 --- Modified: src/modules/app_jsdt/duk_config.h Modified: src/modules/app_jsdt/duktape.c Modified: src/modules/app_jsdt/duktape.h --- Diff: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e… Patch: https://github.com/kamailio/kamailio/commit/dd28ea040b78bf972a9b54177a8025e…

1 0

git:master:2b3c4130: corex: exported file read/write functions to kemi
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: 2b3c4130e717f1b92eeb351e3bfe72e189138136 URL: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T19:15:22+02:00 corex: exported file read/write functions to kemi --- Modified: src/modules/corex/corex_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e… Patch: https://github.com/kamailio/kamailio/commit/2b3c4130e717f1b92eeb351e3bfe72e…

1 0

git:master:d581418b: crypto: check if netio crypto key is set if callbacks are enabled
by Daniel-Constantin Mierla 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: d581418bcc49ad30bd35910f988ac78c8d9047e0 URL: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-04T18:32:14+02:00 crypto: check if netio crypto key is set if callbacks are enabled --- Modified: src/modules/crypto/crypto_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… Patch: https://github.com/kamailio/kamailio/commit/d581418bcc49ad30bd35910f988ac78… --- diff --git a/src/modules/crypto/crypto_mod.c b/src/modules/crypto/crypto_mod.c index c2f7fe61e4..720042792b 100644 --- a/src/modules/crypto/crypto_mod.c +++ b/src/modules/crypto/crypto_mod.c @@ -137,6 +137,10 @@ static int mod_init(void) } if(_crypto_register_evcb!=0) { + if(_crypto_netio_key.s==NULL || _crypto_netio_key.len<=0) { + LM_ERR("crypto netio key parameter is not set\n"); + return -1; + } crypto_evcb_enable(); }

1 0

missing SAR messages
by Georgi Rosenov Stefanov 04 Jun '20

04 Jun '20

Hi Henning, At first I want to thanks you for reading my post :) Actually I tried to use DEBUG logs, but nothing ..... So I put an "abort()" :) into cxdx_send_sar, so I am able to track one successful test case. Here is the backtrace: #2 0x00007fcb469c12f7 in cxdx_send_sar (msg=0x7fcb4d66a968, public_identity=..., private_identity=..., server_name=..., assignment_type=1, data_available=0, transaction_data=0x7fcb3e455610) at cxdx_sar.c:328 #3 0x00007fcb469c3815 in scscf_assign_server (msg=0x7fcb4d66a968, public_identity=..., private_identity=..., assignment_type=1, data_available=0, transaction_data=0x7fcb3e455610) at server_assignment.c:88 #4 0x00007fcb469ba42f in save (msg=0x7fcb4d66a968, str1=0x7fcb3e423158 "X0B>\313\177", route=0x7fcb4d6656e0 " 3]M\313\177") at save.c:1438 #5 0x00007fcb469cce2a in w_save (_m=0x7fcb4d66a968, _route=0x7fcb4d6656e0 " 3]M\313\177", _d=0x7fcb3e423158 "X0B>\313\177", mode=0x7fcb4d66a968 "\001", _cflags=0x0) at ims_registrar_scscf_mod.c:623 #6 0x000000000047c5c9 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d2f80, msg=0x7fcb4d66a968) at core/action.c:1085 #7 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5d2be8, msg=0x7fcb4d66a968) at core/action.c:1578 #8 0x000000000047c422 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4010, msg=0x7fcb4d66a968) at core/action.c:1064 #9 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4010, msg=0x7fcb4d66a968) at core/action.c:1578 #10 0x000000000047c470 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5d4160, msg=0x7fcb4d66a968) at core/action.c:1068 #11 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d5c4d00, msg=0x7fcb4d66a968) at core/action.c:1578 #12 0x0000000000478ed9 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d573058, msg=0x7fcb4d66a968) at core/action.c:697 #13 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d573058, msg=0x7fcb4d66a968) at core/action.c:1578 #14 0x000000000047c422 in do_action (h=0x7ffd2e6d7e50, a=0x7fcb4d5732f8, msg=0x7fcb4d66a968) at core/action.c:1064 #15 0x000000000048907a in run_actions (h=0x7ffd2e6d7e50, a=0x7fcb4d571ea0, msg=0x7fcb4d66a968) at core/action.c:1578 #16 0x0000000000489803 in run_top_route (a=0x7fcb4d571ea0, msg=0x7fcb4d66a968, c=0x0) at core/action.c:1663 #17 0x00000000005b510e in receive_msg ( buf=0xa95500 <buf.6971> "REGISTER sip: scscf.mnc001.mcc001.3gppnetwork.org:6060 SIP/2.0\r\nVia: SIP/2.0/UDP 10.82.10.145:4060;branch=z9hG4bKe025.079fd766789513e3068d0dce7e1853f3.0\r\nVia: SIP/2.0/UDP 10.82.10.145;branch=z9hG4bKe02"..., len=1085, rcv_info=0x7ffd2e6d8490) at core/receive.c:424 #18 0x00000000004bc624 in udp_rcv_loop () at core/udp_server.c:548 So w_save is called from pcscf_save("location") from /usr/local/etc/kamailio/pcscf/route/register.cfg and save("PRE_REG_SAR_REPLY","location") or save("REG_SAR_REPLY","location"); from /usr/local/etc/kamailio/scscf/kamailio.cfg So I put err log messages(err to be clearly visible ) and then using "journal | grep "my string" -c I count how many times the SAR is triggered Then I count how many SAR messages a sent and the numbers mismatch

2 1

[kamailio/kamailio] cnxcc: when credit reach the limit non confirmed calls of the same customer fail to terminate (#2346)
by Victor Seva 04 Jun '20

04 Jun '20

### Description when credit reach the limit non confirmed calls of the same customer fail to terminate #### Reproduction Sending a call of the same customer while there's another call of the same customer consuming all the quota assigned to it. #### Log Messages first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` established: ``` Jun 3 12:05:39 kamailio[21658]: DEBUG: cnxcc [cnxcc_mod.c:446]: __dialog_created_callback(): Flag is not set for this message. Ignoring Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1583]: ki_set_max_credit(): Setting up new call for client [zs_00000], max-credit[1.000000], connect-cost[0.000000], cost-per-sec[0.100000], initial-pulse [1], final-pulse [1], call-id[450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1521]: set_ctrl_flag(): Flag set! Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1183]: __get_or_create_credit_data_entry(): Credit entry didn't exist. Allocated new entry [0x7f508161ed40] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:1312]: __alloc_new_call_by_money(): New call allocated for client [zs_00000] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:450]: __dialog_created_callback(): Dialog created for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:758]: __setup_billing(): Creating dialog for [450708880-22683-45(a)BAA.BAE.BJF.BDF], h_id [4406], h_entry [1215] Jun 3 12:05:39 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:797]: __setup_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] from client [zs_00000], created Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:464]: __dialog_confirmed_callback(): Dialog confirmed for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:811]: __start_billing(): Billing started for call [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:48 kamailio[21657]: DEBUG: cnxcc [cnxcc_mod.c:927]: __start_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] from client [zs_00000], confirmed. from=<sip:zs_pruebas201@pepelux.zoonsuite.com>;tag=1931637637, to=<sip:anonymous@pepelux.zoonsuite.com>;tag=as7138b4b8 Jun 3 12:05:48 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [0], consumed credit [0.100000] Jun 3 12:05:48 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.100000/1.000000 Jun 3 12:05:49 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [1], consumed credit [0.100000] Jun 3 12:05:49 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.100000/1.000000 Jun 3 12:05:50 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [2], consumed credit [0.300000] Jun 3 12:05:50 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.300000/1.000000 ``` Second call ``[d85f4ff9c923c9ea]``, first one is alive and consuming: ``` Jun 3 12:05:50 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:446]: __dialog_created_callback(): Flag is not set for this message. Ignoring Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1583]: ki_set_max_credit(): Setting up new call for client [zs_00000], max-credit[1.000000], connect-cost[0.000000], cost-per-sec[0.100000], initial-pulse [1], final-pulse [1], call-id[d85f4ff9c923c9ea] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1521]: set_ctrl_flag(): Flag set! Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1164]: __get_or_create_credit_data_entry(): Found key zs_00000 in hash table Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:1312]: __alloc_new_call_by_money(): New call allocated for client [zs_00000] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:450]: __dialog_created_callback(): Dialog created for CID [d85f4ff9c923c9ea] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:758]: __setup_billing(): Creating dialog for [d85f4ff9c923c9ea], h_id [1000], h_entry [1526] Jun 3 12:05:50 kamailio[21659]: DEBUG: cnxcc [cnxcc_mod.c:797]: __setup_billing(): Call [d85f4ff9c923c9ea] from client [zs_00000], created ``` first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` will consume all the customer credit and trigger ``terminate_all_calls`` : ``` Jun 3 12:05:51 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [3], consumed credit [0.400000] Jun 3 12:05:51 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.400000/1.000000 Jun 3 12:05:52 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [4], consumed credit [0.500000] Jun 3 12:05:52 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.500000/1.000000 Jun 3 12:05:53 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [5], consumed credit [0.600000] Jun 3 12:05:53 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.600000/1.000000 Jun 3 12:05:54 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [6], consumed credit [0.700000] Jun 3 12:05:54 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.700000/1.000000 Jun 3 12:05:55 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [7], consumed credit [0.800000] Jun 3 12:05:55 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.800000/1.000000 Jun 3 12:05:56 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [8], consumed credit [0.900000] Jun 3 12:05:56 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 0.900000/1.000000 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:93]: check_calls_by_money(): CID [450708880-22683-45(a)BAA.BAE.BJF.BDF], start_timestamp [1591178748], seconds alive [9], consumed credit [1.000000] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_check.c:122]: check_calls_by_money(): Client [zs_00000] | Ended-Calls-Credit-Spent: 0.000000 TotalCredit/MaxCredit: 1.000000/1.000000 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:974]: terminate_all_calls(): Killing call with CID [d85f4ff9c923c9ea] ``` second ``[d85f4ff9c923c9ea]`` non-confirmed call doesn't have call->from_uri, call->from_tag, call->to_uri, call->to_tag so...: ``` Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1095]: terminate_call(): Got kill signal for call [d85f4ff9c923c9ea] client [zs_00000] h_id [1000] h_entry [1526]. Dropping it now Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_sip_msg_faker.c:48]: cnxcc_faked_msg_init_with_dlg_info(): fake msg:#012OPTIONS sip:you@kamailio.org SIP/2.0#015#012Via: SIP/2.0/UDP 127.0.0.1#015#012From: <>;tag=#015#012To: <>;tag=#015#012Call-ID: d85f4ff9c923c9ea#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0 Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/parse_addr_spec.c:739]: parse_addr_spec(): unexpected char [>] in status 5: [<] . Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/msg_parser.c:164]: get_hdr_field(): bad to header Jun 3 12:05:57 kamailio[21673]: ERROR: <core> [core/parser/msg_parser.c:337]: parse_headers(): bad header field [To: <>;tag=#015#012Call-ID: d85f4ff9c923c9ea#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0#015#012#015#012] Jun 3 12:05:57 kamailio[21673]: ERROR: dialog [dlg_handlers.c:709]: pre_match_parse(): bad request or missing CALLID/TO hdr :-/ Jun 3 12:05:57 kamailio[21673]: ERROR: cnxcc [cnxcc_mod.c:1112]: terminate_call(): [d85f4ff9c923c9ea]: cannot get dialog Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1029]: __free_call(): Freeing call [d85f4ff9c923c9ea] ``` but the call ``[d85f4ff9c923c9ea]`` is been freed. The first call ``[450708880-22683-45(a)BAA.BAE.BJF.BDF]`` is been terminated properly and freed ``` Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:974]: terminate_all_calls(): Killing call with CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1095]: terminate_call(): Got kill signal for call [450708880-22683-45(a)BAA.BAE.BJF.BDF] client [zs_00000] h_id [4406] h_entry [1215]. Dropping it now Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_sip_msg_faker.c:48]: cnxcc_faked_msg_init_with_dlg_info(): fake msg:#012OPTIONS sip:you@kamailio.org SIP/2.0#015#012Via: SIP/2.0/UDP 127.0.0.1#015#012From: <sip:zs_pruebas201@pepelux.zoonsuite.com>;tag=1931637637#015#012To: <sip:anonymous@pepelux.zoonsuite.com>;tag=as7138b4b8#015#012Call-ID: 450708880-22683-45(a)BAA.BAE.BJF.BDF#015#012CSeq: 1 OPTIONS#015#012Content-Length: 0 Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:473]: __dialog_terminated_callback(): Dialog terminated for CID [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:656]: __stop_billing(): Call [450708880-22683-45(a)BAA.BAE.BJF.BDF] of client-ID [zs_00000], ended Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1117]: terminate_call(): dlg_end_dlg sent to call [450708880-22683-45(a)BAA.BAE.BJF.BDF] Jun 3 12:05:57 kamailio[21673]: INFO: <script>: [450708880-22683-45(a)BAA.BAE.BJF.BDF]: call killed zs_pruebas201->anonymous ... No credit available Jun 3 12:05:57 kamailio[21673]: DEBUG: cnxcc [cnxcc_mod.c:1029]: __free_call(): Freeing call [450708880-22683-45(a)BAA.BAE.BJF.BDF] ``` second call ``[d85f4ff9c923c9ea]`` is confirmed but call info was already freed ``` Jun 3 12:06:03 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:464]: __dialog_confirmed_callback(): Dialog confirmed for CID [d85f4ff9c923c9ea] Jun 3 12:06:03 kamailio[21660]: DEBUG: cnxcc [cnxcc_mod.c:811]: __start_billing(): Billing started for call [d85f4ff9c923c9ea] Jun 3 12:06:03 kamailio[21660]: ERROR: cnxcc [cnxcc_mod.c:819]: __start_billing(): Call [d85f4ff9c923c9ea] not found ``` ### Additional Information * **Kamailio Version** - output of `kamailio -v` kamailio master with #2343 applied -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2346

1 1

[kamailio/kamailio] cnxcc: don't terminate non confirmed calls (#2347)
by Victor Seva 04 Jun '20

04 Jun '20

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2346 #### Description * non confirmed calls can't be terminated via dialog.terminate_dlg() API * set call.max_amount to 0 to terminate the call if gets confirmed You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2347 -- Commit Summary -- * cnxcc: don't terminate non confirmed calls -- File Changes -- M src/modules/cnxcc/cnxcc_mod.c (249) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2347.patch https://github.com/kamailio/kamailio/pull/2347.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2347

1 1

git:master:ca0fc18e: cnxcc: don't terminate non confirmed calls
by Victor Seva 04 Jun '20

04 Jun '20

Module: kamailio Branch: master Commit: ca0fc18e1cfad86ed6b7530d6c520b680e5d6a4f URL: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2020-06-04T11:12:13+02:00 cnxcc: don't terminate non confirmed calls * non confirmed calls can't be terminated via dialog.terminate_dlg() API * set call.max_amount to 0 to terminate the call if gets confirmed fix #2346 --- Modified: src/modules/cnxcc/cnxcc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6… Patch: https://github.com/kamailio/kamailio/commit/ca0fc18e1cfad86ed6b7530d6c520b6…

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2020