June 2020 - sr-dev - kamailio.org

git:master:51d1c2eb: dispatcher: docbook - fixed 'Attribute "xmlns:xi" must be declared for element type'
by Sergey Safarov 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 51d1c2ebc251b930ee40d854a84995c911b86db4 URL: https://github.com/kamailio/kamailio/commit/51d1c2ebc251b930ee40d854a84995c… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-25T22:05:45+03:00 dispatcher: docbook - fixed 'Attribute "xmlns:xi" must be declared for element type' --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/51d1c2ebc251b930ee40d854a84995c… Patch: https://github.com/kamailio/kamailio/commit/51d1c2ebc251b930ee40d854a84995c… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index f853ca9a20..d454a14c47 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -6,6 +6,9 @@ <!ENTITY % docentities SYSTEM "../../../../doc/docbook/entities.xml"> %docentities; +<!ENTITY % xinclude SYSTEM "http://www.docbook.org/xml/4.4/xinclude.mod" > +%xinclude; + ]>

1 0

git:master:37895267: dispatcher: docbook - fixed "The content of the parent element type is element only."
by Sergey Safarov 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 378952672659ccec883f18f77b8c932a73fc657e URL: https://github.com/kamailio/kamailio/commit/378952672659ccec883f18f77b8c932… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-25T21:49:09+03:00 dispatcher: docbook - fixed "The content of the parent element type is element only." --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/378952672659ccec883f18f77b8c932… Patch: https://github.com/kamailio/kamailio/commit/378952672659ccec883f18f77b8c932…

1 0

git:master:44f62bd8: dispatcher: docbook - fixed "The content of the parent element type is element only."
by Sergey Safarov 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 44f62bd8e0a4c0ef7a9d2b87e52941b0f62d41bd URL: https://github.com/kamailio/kamailio/commit/44f62bd8e0a4c0ef7a9d2b87e52941b… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-25T21:42:59+03:00 dispatcher: docbook - fixed "The content of the parent element type is element only." --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/44f62bd8e0a4c0ef7a9d2b87e52941b… Patch: https://github.com/kamailio/kamailio/commit/44f62bd8e0a4c0ef7a9d2b87e52941b… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index e42c94fa3e..41a5749387 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -355,31 +355,32 @@ modparam("dispatcher", "force_dst", 1) <para> The addeded fields are: <itemizedlist> - <listitem> - grp - the set id (group id). - </listitem> - <listitem> - uri - the URI address. - </listitem> - <listitem> - sock - the socket pointer. - </listitem> - <listitem> - socket - the socket string - it is added only if xavp_dst_mode has bit 2 set - (value 2). - </listitem> - <listitem> - sockname - the sockname string - it is added only if xavp_dst_mode has bit 3 set - (value 3). - </listitem> - <listitem> - dstid - the destination unique id (in case of call load distribution algorithm). - </listitem> - <listitem> - attrs - the attributes - they are added if xavp_dst_mode does not have - the bit 1 set (value 1). - </listitem> - </itemizedlist> + <listitem> + <para>grp - the set id (group id).</para> + </listitem> + <listitem> + <para>uri - the URI address.</para> + </listitem> + <listitem> + <para>sock - the socket pointer.</para> + </listitem> + <listitem> + <para>socket - the socket string - it is added only if xavp_dst_mode has + bit 2 set (value 2).</para> + </listitem> + <listitem> + <para>sockname - the sockname string - it is added only if xavp_dst_mode + has bit 3 set (value 3).</para> + </listitem> + <listitem> + <para>dstid - the destination unique id (in case of call load distribution + algorithm).</para> + </listitem> + <listitem> + <para>attrs - the attributes - they are added if xavp_dst_mode does not + have the bit 1 set (value 1).</para> + </listitem> + </itemizedlist> </para> <para> <emphasis>

1 0

git:master:715d49b6: dispatcher: docbook - fixed "Document root element "chapter", must match DOCTYPE root "book"."
by Sergey Safarov 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 715d49b62bef30b485d3975acd20b406c444956f URL: https://github.com/kamailio/kamailio/commit/715d49b62bef30b485d3975acd20b40… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-25T21:28:19+03:00 dispatcher: docbook - fixed "Document root element "chapter", must match DOCTYPE root "book"." --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/715d49b62bef30b485d3975acd20b40… Patch: https://github.com/kamailio/kamailio/commit/715d49b62bef30b485d3975acd20b40… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 345f314621..e42c94fa3e 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1,5 +1,5 @@ <?xml version="1.0" encoding='ISO-8859-1'?> -<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook XML V4.4//EN" +<!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML V4.4//EN" "http://www.oasis-open.org/docbook/xml/4.4/docbookx.dtd" [

1 0

git:master:60e29f96: dispatcher: docbook space formating
by Sergey Safarov 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 60e29f96ae57489669d1c266255e94b449e07dac URL: https://github.com/kamailio/kamailio/commit/60e29f96ae57489669d1c266255e94b… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-25T21:05:55+03:00 dispatcher: docbook space formating --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/60e29f96ae57489669d1c266255e94b… Patch: https://github.com/kamailio/kamailio/commit/60e29f96ae57489669d1c266255e94b…

1 0

git:master:b7c7976d: modules: readme files regenerated - dlgs ... [skip ci]
by Kamailio Dev 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: b7c7976d3e84ac648b689e5e496e619f587a4eb9 URL: https://github.com/kamailio/kamailio/commit/b7c7976d3e84ac648b689e5e496e619… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-29T07:46:20+02:00 modules: readme files regenerated - dlgs ... [skip ci] --- Modified: src/modules/dlgs/README --- Diff: https://github.com/kamailio/kamailio/commit/b7c7976d3e84ac648b689e5e496e619… Patch: https://github.com/kamailio/kamailio/commit/b7c7976d3e84ac648b689e5e496e619… --- diff --git a/src/modules/dlgs/README b/src/modules/dlgs/README index 83cf48594e..837db4330b 100644 --- a/src/modules/dlgs/README +++ b/src/modules/dlgs/README @@ -10,7 +10,7 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> - Copyright © 2020 asipto.com + Copyright Â© 2020 asipto.com __________________________________________________________________ Table of Contents @@ -25,18 +25,27 @@ Daniel-Constantin Mierla 3. Parameters - 3.1. lifetime (int) + 3.1. active_lifetime (int) 3.2. timer_interval (int) 4. Functions - 4.1. dlgs_manage(src, dst, data) + 4.1. dlgs_init(src, dst, data) + 4.2. dlgs_update(src) + + 5. RPC Commands + + 5.1. rpc.list + 5.2. rpc.stats List of Examples - 1.1. Set lifetime parameter + 1.1. Set active_lifetime parameter 1.2. Set timer_interval parameter - 1.3. dlgs_manage usage + 1.3. dlgs_init usage + 1.4. dlgs_update usage + 1.5. dlgs.list usage + 1.6. dlgs.stats usage Chapter 1. Admin Guide @@ -50,12 +59,18 @@ Chapter 1. Admin Guide 3. Parameters - 3.1. lifetime (int) + 3.1. active_lifetime (int) 3.2. timer_interval (int) 4. Functions - 4.1. dlgs_manage(src, dst, data) + 4.1. dlgs_init(src, dst, data) + 4.2. dlgs_update(src) + + 5. RPC Commands + + 5.1. rpc.list + 5.2. rpc.stats 1. Overview @@ -90,18 +105,18 @@ Chapter 1. Admin Guide 3. Parameters - 3.1. lifetime (int) + 3.1. active_lifetime (int) 3.2. timer_interval (int) -3.1. lifetime (int) +3.1. active_lifetime (int) The lifetime in seconds of a dialog in memory. Default value is 10800 (3 hours). - Example 1.1. Set lifetime parameter + Example 1.1. Set active_lifetime parameter ... -modparam("dlgs", "lifetime", 3600) +modparam("dlgs", "active_lifetime", 3600) ... 3.2. timer_interval (int) @@ -118,22 +133,63 @@ modparam("dlgs", "timer_interval", 60) 4. Functions - 4.1. dlgs_manage(src, dst, data) + 4.1. dlgs_init(src, dst, data) + 4.2. dlgs_update(src) -4.1. dlgs_manage(src, dst, data) +4.1. dlgs_init(src, dst, data) - Track the dialog corresponding to the current SIP message. It has to be - used for INVITE messages. + Start track the dialog corresponding to the current SIP message. It has + to be used for INVITE messages. This function can be used from ANY_ROUTE. - Example 1.3. dlgs_manage usage + Example 1.3. dlgs_init usage ... request_route { ... if(is_method("INVITE")) { - dlgs_manage("$fu", "$tu", "my data"); + dlgs_init("$fu", "$tu", "my data"); + } + ... +} +... + +4.2. dlgs_update(src) + + Update dialog state. + + This function can be used from ONSEND_ROUTE. + + Example 1.4. dlgs_update usage +... +onsend_route { + ... + if(is_method("INVITE|ACK|BYE")) { + dlgs_init("$fu", "$tu", "my data"); } ... } ... + +5. RPC Commands + + 5.1. rpc.list + 5.2. rpc.stats + +5.1. rpc.list + + List dialog records. + + Example 1.5. dlgs.list usage +... +kamctl rpc dlgs.list +... + +5.2. rpc.stats + + Return dialog statistics. + + Example 1.6. dlgs.stats usage +... +kamctl rpc dlgs.stats +...

1 0

git:master:f757a5e1: dlgs: update final stats when item is destroyed
by Daniel-Constantin Mierla 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: f757a5e1a092bff4a1dbaa7da2d02f06e3a3e32e URL: https://github.com/kamailio/kamailio/commit/f757a5e1a092bff4a1dbaa7da2d02f0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-29T07:35:30+02:00 dlgs: update final stats when item is destroyed --- Modified: src/modules/dlgs/dlgs_records.c --- Diff: https://github.com/kamailio/kamailio/commit/f757a5e1a092bff4a1dbaa7da2d02f0… Patch: https://github.com/kamailio/kamailio/commit/f757a5e1a092bff4a1dbaa7da2d02f0… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index e62bd2c97e..3180fa02a2 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -437,8 +437,9 @@ int dlgs_del_item(sip_msg_t *msg) idx = dlgs_get_index(hid, dsht->htsize); /* head test and return */ - if(dsht->slots[idx].first == NULL) + if(dsht->slots[idx].first == NULL) { return 0; + } lock_get(&dsht->slots[idx].lock); it = dsht->slots[idx].first; @@ -456,6 +457,7 @@ int dlgs_del_item(sip_msg_t *msg) it->next->prev = it->prev; dsht->slots[idx].esize--; lock_release(&dsht->slots[idx].lock); + dlgs_update_stats(&dsht->fstats, it->state, 1); dlgs_item_free(it); return 0; } @@ -687,6 +689,7 @@ void dlgs_ht_timer(unsigned int ticks, void *param) it->prev = ite->prev; } } + dlgs_update_stats(&_dlgs_htb->fstats, ite->state, 1); dlgs_item_free(ite); } }

1 0

git:master:7a47812f: dlgs: docs for dlg.stats command
by Daniel-Constantin Mierla 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 7a47812f10f23897f3455a5abbede3a53c8c2d0e URL: https://github.com/kamailio/kamailio/commit/7a47812f10f23897f3455a5abbede3a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-29T07:35:30+02:00 dlgs: docs for dlg.stats command --- Modified: src/modules/dlgs/doc/dlgs_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7a47812f10f23897f3455a5abbede3a… Patch: https://github.com/kamailio/kamailio/commit/7a47812f10f23897f3455a5abbede3a… --- diff --git a/src/modules/dlgs/doc/dlgs_admin.xml b/src/modules/dlgs/doc/dlgs_admin.xml index 7bf05d0e3c..5947376689 100644 --- a/src/modules/dlgs/doc/dlgs_admin.xml +++ b/src/modules/dlgs/doc/dlgs_admin.xml @@ -174,6 +174,22 @@ onsend_route { ... &kamctl; rpc dlgs.list ... +</programlisting> + </example> + </section> + <section id="dlgs.rpc.stats"> + <title> + <function moreinfo="none">rpc.stats</function> + </title> + <para> + Return dialog statistics. + </para> + <example> + <title><function>dlgs.stats</function> usage</title> + <programlisting format="linespecific"> +... +&kamctl; rpc dlgs.stats +... </programlisting> </example> </section>

1 0

git:master:5c2b93f6: dlgs: dlgs.stats rpc command
by Daniel-Constantin Mierla 29 Jun '20

29 Jun '20

Module: kamailio Branch: master Commit: 5c2b93f61b8970cd174c4d4055f7dbc1ddccaa12 URL: https://github.com/kamailio/kamailio/commit/5c2b93f61b8970cd174c4d4055f7dbc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-29T07:35:30+02:00 dlgs: dlgs.stats rpc command --- Modified: src/modules/dlgs/dlgs_records.c --- Diff: https://github.com/kamailio/kamailio/commit/5c2b93f61b8970cd174c4d4055f7dbc… Patch: https://github.com/kamailio/kamailio/commit/5c2b93f61b8970cd174c4d4055f7dbc… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index 6fcfa50945..e62bd2c97e 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -707,6 +707,57 @@ static const char *dlgs_rpc_stats_doc[2] = { */ static void dlgs_rpc_stats(rpc_t *rpc, void *ctx) { + void *th; + void *ti; + dlgs_stats_t *sti; + dlgs_stats_t sta; + int i; + + if(_dlgs_htb == NULL) { + return; + } + + if (rpc->add(ctx, "{", &th) < 0) { + rpc->fault(ctx, 500, "Internal error creating rpc"); + return; + } + i = 0; + do { + if(i==0) { + sti = &_dlgs_htb->fstats; + if(rpc->struct_add(th, "{", "final", &ti)<0) { + rpc->fault(ctx, 500, "Internal error creating final stats"); + return; + } + } else { + memset(&sta, 0, sizeof(dlgs_stats_t)); + for(i=0; i<_dlgs_htb->htsize; i++) { + sta.c_init += _dlgs_htb->slots[i].astats.c_init; + sta.c_progress += _dlgs_htb->slots[i].astats.c_progress; + sta.c_answered += _dlgs_htb->slots[i].astats.c_answered; + sta.c_confirmed += _dlgs_htb->slots[i].astats.c_confirmed; + sta.c_terminted += _dlgs_htb->slots[i].astats.c_terminted; + sta.c_notanswered += _dlgs_htb->slots[i].astats.c_notanswered; + } + sti = &sta; + if(rpc->struct_add(th, "{", "active", &ti)<0) { + rpc->fault(ctx, 500, "Internal error creating final stats"); + return; + } + i = 1; + } + if(rpc->struct_add(ti, "uuuuuu", + "init", sti->c_init, + "progress", sti->c_progress, + "answered", sti->c_answered, + "confirmed", sti->c_confirmed, + "terminted", sti->c_terminted, + "notanswered", sti->c_notanswered)<0) { + rpc->fault(ctx, 500, "Internal error creating values"); + return; + } + i++; + } while(i<2); } static const char *dlgs_rpc_list_doc[2] = {

1 0

git:master:61d9d204: modules: readme files regenerated - ims_charging ... [skip ci]
by Kamailio Dev 28 Jun '20

28 Jun '20

Module: kamailio Branch: master Commit: 61d9d204c33c1b140ed90d51e9af13ec4ed12a96 URL: https://github.com/kamailio/kamailio/commit/61d9d204c33c1b140ed90d51e9af13e… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-28T15:01:25+02:00 modules: readme files regenerated - ims_charging ... [skip ci] --- Modified: src/modules/ims_charging/README --- Diff: https://github.com/kamailio/kamailio/commit/61d9d204c33c1b140ed90d51e9af13e… Patch: https://github.com/kamailio/kamailio/commit/61d9d204c33c1b140ed90d51e9af13e… --- diff --git a/src/modules/ims_charging/README b/src/modules/ims_charging/README index e9b08478c3..3311e14c9a 100644 --- a/src/modules/ims_charging/README +++ b/src/modules/ims_charging/README @@ -575,7 +575,7 @@ modparam("ims_charging", "destination_host", "ocs.kamailio-ims.org") Destination realm to be used in Diameter messages to charging-server. - Default value is "ims.smilecoms.com". + Default value is "". Example 1.16. destination_realmparameter usage ...

1 0

git:master:f679c118: ims_charging: fix error in destination_realm default vaulue
by Henning Westerholt 28 Jun '20

28 Jun '20

Module: kamailio Branch: master Commit: f679c118a589c80cb84954fb46271adef596e049 URL: https://github.com/kamailio/kamailio/commit/f679c118a589c80cb84954fb46271ad… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2020-06-28T12:56:01Z ims_charging: fix error in destination_realm default vaulue --- Modified: src/modules/ims_charging/doc/ims_charging_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/f679c118a589c80cb84954fb46271ad… Patch: https://github.com/kamailio/kamailio/commit/f679c118a589c80cb84954fb46271ad… --- diff --git a/src/modules/ims_charging/doc/ims_charging_admin.xml b/src/modules/ims_charging/doc/ims_charging_admin.xml index d6b959f41f..4c68b6e29c 100644 --- a/src/modules/ims_charging/doc/ims_charging_admin.xml +++ b/src/modules/ims_charging/doc/ims_charging_admin.xml @@ -549,7 +549,7 @@ modparam("ims_charging", "destination_host", "ocs.kamailio-ims.org") <para>Destination realm to be used in Diameter messages to charging-server.</para> - <para><emphasis>Default value is "ims.smilecoms.com".</emphasis></para> + <para><emphasis>Default value is "".</emphasis></para> <example> <title><varname>destination_realm</varname>parameter usage</title>

1 0

[kamailio/kamailio] Help for register kazoo to kamailio registrar server (#2378)
by Mohammad Dhnavi 27 Jun '20

27 Jun '20

### Description  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.0.8 (x86_64/linux) flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 6.3.0 ``` * **Operating System**:  ``` Linux trunk2-sbc 4.9.0-6-amd64 #1 SMP Debian 4.9.88-1+deb9u1 (2018-05-07) x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2378

2 2

git:master:ec0b1d31: siputils: docs - added section ids for parameters
by Daniel-Constantin Mierla 26 Jun '20

26 Jun '20

Module: kamailio Branch: master Commit: ec0b1d31f1d667abdcd7cce7fbfff110583e271c URL: https://github.com/kamailio/kamailio/commit/ec0b1d31f1d667abdcd7cce7fbfff11… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-26T22:27:43+02:00 siputils: docs - added section ids for parameters --- Modified: src/modules/siputils/doc/siputils_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ec0b1d31f1d667abdcd7cce7fbfff11… Patch: https://github.com/kamailio/kamailio/commit/ec0b1d31f1d667abdcd7cce7fbfff11… --- diff --git a/src/modules/siputils/doc/siputils_admin.xml b/src/modules/siputils/doc/siputils_admin.xml index 67e7d1e6c8..880105792a 100644 --- a/src/modules/siputils/doc/siputils_admin.xml +++ b/src/modules/siputils/doc/siputils_admin.xml @@ -72,7 +72,7 @@ <section> <title>Parameters</title> - <section> + <section id="siputils.p.ring_timeout"> <title><varname>ring_timeout</varname> (int)</title> <para> Timeout value in seconds, define how long the call-id is stored in the internal list kept for replacing 183 messages with 180. @@ -92,7 +92,7 @@ modparam("siputils", "ring_timeout", 30) </programlisting> </example> </section> - <section> + <section id="siputils.p.options_accept"> <title><varname>options_accept</varname> (string)</title> <para> This parameter is the content of the Accept header field. @@ -115,7 +115,7 @@ modparam("siputils", "options_accept", "application/*") </programlisting> </example> </section> - <section> + <section id="siputils.p.options_accept_encoding"> <title><varname>options_accept_encoding</varname> (string)</title> <para> This parameter is the content of the Accept-Encoding header field. @@ -137,7 +137,7 @@ modparam("siputils", "options_accept_encoding", "gzip") </example> </section> - <section> + <section id="siputils.p.contact_flds_separator"> <title><varname>contact_flds_separator</varname> (string)</title> <para> First char of this parameter is used as separator for encoding/decoding @@ -170,7 +170,7 @@ modparam("siputils", "contact_flds_separator", "-") </section> - <section> + <section id="siputils.p.options_accept_language"> <title><varname>options_accept_language</varname> (string)</title> <para> This parameter is the content of the Accept-Language header field. @@ -193,7 +193,7 @@ modparam("siputils", "options_accept_language", "de") </programlisting> </example> </section> - <section> + <section id="siputils.p.options_support"> <title><varname>options_support</varname> (string)</title> <para> This parameter is the content of the Support header field, @@ -215,7 +215,7 @@ modparam("siputils", "options_support", "100rel") </programlisting> </example> </section> - <section> + <section id="siputils.p.rpid_prefix"> <title><varname>rpid_prefix</varname> (string)</title> <para> Prefix to be added to Remote-Party-ID header field just before @@ -231,7 +231,7 @@ modparam("auth", "rpid_prefix", "Whatever <") </programlisting> </example> </section> - <section> + <section id="siputils.p.rpid_suffix"> <title><varname>rpid_suffix</varname> (string)</title> <para> Suffix to be added to Remote-Party-ID header field after the URI @@ -248,7 +248,7 @@ modparam("auth", "rpid_suffix", "@1.2.3.4>") </programlisting> </example> </section> - <section> + <section id="siputils.p.rpid_avp"> <title><varname>rpid_avp</varname> (string)</title> <para> Full AVP specification for the AVP which

1 0

[kamailio/kamailio] Dispatcher : Re-distribution of messages when hash used and destination not available (#2361)
by Kalki70 26 Jun '20

26 Jun '20

### Description Selected algorithm is a hash, over Call-ID, From, etc. If destination is not available, a new one must be selected, without breaking the hash assignation (all messages with the same hash must be forwarded to the same destination) ### Expected behavior The load to the failed destination to be (hopefully) evenly distributed over the remaining destinations. #### Actual observed behavior All the messages that were supposed to be sent to the failed destination are sent to only one of the remaining, causing it to receive double load, comparing with the rest #### Debugging Data In this test, 6000 Calls were sent to a group of six destinations, using algorithm "0" (hash over Call-ID) | All destinations active -- | -- Dest1 | 996 Dest2 | 997 Dest3 | 999 Dest4 | 1006 Dest5 | 1005 Dest6 | 997 Total | 6000 ![all_active](https://user-images.githubusercontent.com/20492105/84825429-6719a580-afef-11ea-971c-d59152fc6550.png) Repeating the test, but with destination Dest4 down: | OriginalImplementation -- | -- Dest1 | 975 Dest2 | 993 Dest3 | 2022 Dest4 | 0 Dest5 | 1019 Dest6 | 991 Total | 6000 ![one_down_original](https://user-images.githubusercontent.com/20492105/84826132-8107b800-aff0-11ea-9663-f6e8992ed5e2.png) We can see that poor destination Dest3 receives double traffic ### Possible Solutions I implemented a solution that does not break the expected behavior (messages with same hash are assigned the same destination, but with a better distribution over remaining destinations) | New Implementation -- | -- Dest1 | 1175 Dest2 | 1206 Dest3 | 1191 Dest4 | 0 Dest5 | 1216 Dest6 | 1212 Total | 6000 ![one_down_new](https://user-images.githubusercontent.com/20492105/84826051-62092600-aff0-11ea-8f89-f06102e732d5.png) Basically, the solution is as simple as to execute a rehash of the original hash. I will create a pull request with the proposed change, which I already tested, as it can be seen on the previous chart. ### Additional Information * **Kamailio Version** ``` kamailio 5.4.0-dev4 (x86_64/linux) 0c29e8-dirty ``` * **Operating System**: ``` Linux Rechitsa 5.4.19-100.fc30.x86_64 #1 SMP Tue Feb 11 22:27:11 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2361

2 3

[kamailio/kamailio] icmp failover (#2377)
by sergey-safarov 26 Jun '20

26 Jun '20

### Description I found that kamailio ignores ICMP messages from remote hosts ### Expected behavior Immediately failover after ICMP message. #### Actual observed behavior kamailio ignores ICMP messages #### How to reproduce Create kamailio config ``` loadmodule "pv.so" loadmodule "tm.so" listen = udp:eth0 request_route { $du = "sip:127.0.0.1"; t_relay(); } ``` Start kamailio using the command ``` kamailio -DD -E -ddd ``` Make a call. #### Debugging Data None #### Log Messages ``` 1(20746) DEBUG: <core> [core/udp_server.c:498]: udp_rcv_loop(): received on udp socket: (106/100/712) [[INVITE sip:6003@office.nga911.com SIP/2.0 0D 0A Via: SIP/2.0/UDP 192.168.2.10:17082;rport;branch=z9hG4bK1]] 1(20746) DEBUG: <core> [core/parser/msg_parser.c:610]: parse_msg(): SIP Request: 1(20746) DEBUG: <core> [core/parser/msg_parser.c:612]: parse_msg(): method: <INVITE> 1(20746) DEBUG: <core> [core/parser/msg_parser.c:614]: parse_msg(): uri: <sip:6003@office.nga911.com> 1(20746) DEBUG: <core> [core/parser/msg_parser.c:616]: parse_msg(): version: <SIP/2.0> 1(20746) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 235, <rport> = <n/a>; state=6 1(20746) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK194358777>; state=16 1(20746) DEBUG: <core> [core/parser/parse_via.c:2639]: parse_via(): end of header reached, state=5 1(20746) DEBUG: <core> [core/parser/msg_parser.c:498]: parse_headers(): Via found, flags=2 1(20746) DEBUG: <core> [core/parser/msg_parser.c:500]: parse_headers(): this is the first via 1(20746) DEBUG: <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=10 1(20746) DEBUG: <core> [core/parser/msg_parser.c:171]: get_hdr_field(): <To> [30]; uri=[sip:6003@office.nga911.com] 1(20746) DEBUG: <core> [core/parser/msg_parser.c:174]: get_hdr_field(): to body [<sip:6003@office.nga911.com> ], to tag [] 1(20746) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <20> <INVITE> 1(20746) DEBUG: <core> [core/receive.c:319]: receive_msg(): --- received sip message - request - call-id: [943928765] - cseq: [20 INVITE] 1(20746) DEBUG: <core> [core/receive.c:379]: receive_msg(): preparing to run routing scripts... 1(20746) DEBUG: tm [t_lookup.c:1328]: t_newtran(): msg (0x7fcf6e57b720) id=1/20746 global id=0/0 T start=0xffffffffffffffff 1(20746) DEBUG: <core> [core/parser/msg_parser.c:185]: get_hdr_field(): content_length=212 1(20746) DEBUG: <core> [core/parser/msg_parser.c:89]: get_hdr_field(): found end of header 1(20746) DEBUG: tm [t_lookup.c:497]: t_lookup_request(): start searching: hash=911, isACK=0 1(20746) DEBUG: tm [t_lookup.c:455]: matching_3261(): RFC3261 transaction matching failed - via branch [z9hG4bK194358777] 1(20746) DEBUG: tm [t_lookup.c:675]: t_lookup_request(): no transaction found 1(20746) DEBUG: <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=1971363051 1(20746) DEBUG: <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=29 1(20746) DEBUG: <core> [core/md5utils.c:67]: MD5StringArray(): MD5 calculated: 5806eb9c98c0f8e99344758d43fcc364 1(20746) DEBUG: tm [t_funcs.c:325]: t_relay_to(): new INVITE 1(20746) DEBUG: tm [t_reply.c:610]: _reply_light(): reply sent out. buf=0x7fcf6e57cde0: SIP/2.0 100 trying -..., shmem=0x7fcf69bd11b8: SIP/2.0 100 trying - 1(20746) DEBUG: tm [t_reply.c:621]: _reply_light(): finished 1(20746) DEBUG: <core> [core/msg_translator.c:1765]: check_boundaries(): no multi-part body 1(20746) DEBUG: tm [t_funcs.c:373]: t_relay_to(): new transaction forwarded 1(20746) DEBUG: <core> [core/receive.c:437]: receive_msg(): request-route executed in: 845 usec 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 1(20746) DEBUG: <core> [core/xavp.c:529]: xavp_destroy_list(): destroying xavp list (nil) 1(20746) DEBUG: <core> [core/receive.c:528]: receive_msg(): cleaning up 9(20754) DEBUG: tm [t_reply.c:1274]: t_should_relay_response(): ->>>>>>>>> T_code=100, new_code=408 9(20754) DEBUG: tm [t_reply.c:1500]: t_should_relay_response(): rps completed - uas status: 100 branch: 0 9(20754) DEBUG: tm [t_reply.c:1823]: relay_reply(): reply status=4 branch=0, save=0, relay=0 icode=0 msg status=408 9(20754) DEBUG: tm [t_reply.c:2016]: relay_reply(): reply buffer sent out 3(20748) DEBUG: <core> [core/udp_server.c:498]: udp_rcv_loop(): received on udp socket: (106/100/341) [[ACK sip:6003@office.nga911.com SIP/2.0 0D 0A Via: SIP/2.0/UDP 192.168.2.10:17082;rport;branch=z9hG4bK1943]] 3(20748) DEBUG: <core> [core/parser/msg_parser.c:610]: parse_msg(): SIP Request: 3(20748) DEBUG: <core> [core/parser/msg_parser.c:612]: parse_msg(): method: <ACK> 3(20748) DEBUG: <core> [core/parser/msg_parser.c:614]: parse_msg(): uri: <sip:6003@office.nga911.com> 3(20748) DEBUG: <core> [core/parser/msg_parser.c:616]: parse_msg(): version: <SIP/2.0> 3(20748) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 235, <rport> = <n/a>; state=6 3(20748) DEBUG: <core> [core/parser/parse_via.c:1303]: parse_via_param(): Found param type 232, <branch> = <z9hG4bK194358777>; state=16 3(20748) DEBUG: <core> [core/parser/parse_via.c:2639]: parse_via(): end of header reached, state=5 3(20748) DEBUG: <core> [core/parser/msg_parser.c:498]: parse_headers(): Via found, flags=2 3(20748) DEBUG: <core> [core/parser/msg_parser.c:500]: parse_headers(): this is the first via 3(20748) DEBUG: <core> [core/parser/parse_addr_spec.c:185]: parse_to_param(): add param: tag=5e29a5d2a0b42789624a70ddd04f640f-81ca6283 3(20748) DEBUG: <core> [core/parser/parse_addr_spec.c:864]: parse_addr_spec(): end of header reached, state=29 3(20748) DEBUG: <core> [core/parser/msg_parser.c:171]: get_hdr_field(): <To> [76]; uri=[sip:6003@office.nga911.com] 3(20748) DEBUG: <core> [core/parser/msg_parser.c:174]: get_hdr_field(): to body [<sip:6003@office.nga911.com>], to tag [5e29a5d2a0b42789624a70ddd04f640f-81ca6283] 3(20748) DEBUG: <core> [core/parser/msg_parser.c:152]: get_hdr_field(): cseq <CSeq>: <20> <ACK> 3(20748) DEBUG: <core> [core/receive.c:319]: receive_msg(): --- received sip message - request - call-id: [943928765] - cseq: [20 ACK] 3(20748) DEBUG: <core> [core/receive.c:379]: receive_msg(): preparing to run routing scripts... 3(20748) DEBUG: tm [t_lookup.c:1328]: t_newtran(): msg (0x7fcf6e57b720) id=1/20748 global id=0/0 T start=0xffffffffffffffff 3(20748) DEBUG: <core> [core/parser/msg_parser.c:185]: get_hdr_field(): content_length=0 3(20748) DEBUG: <core> [core/parser/msg_parser.c:89]: get_hdr_field(): found end of header 3(20748) DEBUG: tm [t_lookup.c:497]: t_lookup_request(): start searching: hash=911, isACK=1 3(20748) DEBUG: tm [t_lookup.c:439]: matching_3261(): RFC3261 transaction matched, tid=194358777 3(20748) DEBUG: tm [t_lookup.c:692]: t_lookup_request(): transaction found (T=0x7fcf69bce838) 3(20748) DEBUG: tm [t_reply.c:1667]: cleanup_uac_timers(): RETR/FR timers reset 3(20748) DEBUG: <core> [core/timer.c:557]: timer_add_safe(): timer_add called on an active timer 0x7fcf69bce8c0 (0x7fcf699a8720, 0x7fcf699a8720), flags 201 3(20748) DEBUG: tm [t_funcs.c:146]: put_on_wait(): transaction 0x7fcf69bce838 already on wait 3(20748) DEBUG: <core> [core/receive.c:437]: receive_msg(): request-route executed in: 237 usec 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/usr_avp.c:636]: destroy_avp_list(): destroying list (nil) 3(20748) DEBUG: <core> [core/xavp.c:529]: xavp_destroy_list(): destroying xavp list (nil) 3(20748) DEBUG: <core> [core/receive.c:528]: receive_msg(): cleaning up ``` #### SIP Traffic Call signaling in attached file [icmp.pcap.gz](https://github.com/kamailio/kamailio/files/4837863/icmp.pcap.… ### Possible Solutions Not Know ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.4 (x86_64/linux) 117ff9 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 117ff9 compiled on 15:31:51 May 6 2020 with gcc 8.3.1 ``` * **Operating System**: ``` [centos@ip-172-22-6-233 ~]$ cat /etc/os-release NAME="CentOS Linux" VERSION="8 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="8" PLATFORM_ID="platform:el8" PRETTY_NAME="CentOS Linux 8 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:8" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-8" CENTOS_MANTISBT_PROJECT_VERSION="8" REDHAT_SUPPORT_PRODUCT="centos" REDHAT_SUPPORT_PRODUCT_VERSION="8" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2377

3 5

[kamailio/kamailio] dispatcher use only one server from SRV results (#2376)
by sergey-safarov 26 Jun '20

26 Jun '20

### Description I have configured dispatcher with set: ``` id 1 setid 1 destination "sip:trial.nga911.com" flags 16 priority 0 attrs "" description "trial esrp" ``` Record above from `redis` database Then kamailio report dispatcher dump ```sh [root@ip-172-22-6-233 config]# kamctl dispatcher dump which: no gdb in (/usr/local/sbin:/sbin:/bin:/usr/sbin:/usr/bin:/root/bin:/) { "jsonrpc": "2.0", "result": { "NRSETS": 1, "RECORDS": [{ "SET": { "ID": 1, "TARGETS": [{ "DEST": { "URI": "sip:trial.nga911.com", "FLAGS": "AP", "PRIORITY": 0 } }] } }] }, "id": 16982 } ``` Using tcpdump I can see kamailio resolve `A/AAAA` records only for one SRV record. ```sh [root@ip-172-22-6-233 config]# tcpdump -ni any port 53 tcpdump: verbose output suppressed, use -v or -vv for full protocol decode listening on any, link-type LINUX_SLL (Linux cooked), capture size 262144 bytes 11:04:23.812111 IP 172.22.6.233.53464 > 172.22.0.2.domain: 30262+ PTR? 233.6.22.172.in-addr.arpa. (43) 11:04:23.812923 IP 172.22.0.2.domain > 172.22.6.233.53464: 30262 1/0/0 PTR ip-172-22-6-233.us-west-1.compute.internal. (99) 11:04:23.813168 IP 172.22.6.233.48244 > 172.22.0.2.domain: 12029+ PTR? 233.6.22.172.in-addr.arpa. (43) 11:04:23.813248 IP 172.22.0.2.domain > 172.22.6.233.48244: 12029 1/0/0 PTR ip-172-22-6-233.us-west-1.compute.internal. (99) 11:04:23.855004 IP 172.22.6.233.45589 > 172.22.0.2.domain: 19167+ A? trial.nga911.com. (34) 11:04:23.856309 IP 172.22.0.2.domain > 172.22.6.233.45589: 19167 0/1/0 (118) 11:04:33.942992 IP 172.22.6.233.56344 > 172.22.0.2.domain: 24272+ SRV? _sip._udp.trial.nga911.com. (44) 11:04:33.944340 IP 172.22.0.2.domain > 172.22.6.233.56344: 24272 2/0/0 SRV proxy-us-west-2-trial-1.nga911.com.:5060 30 30, SRV proxy-us-west-2-trial-0.nga911.com.:5060 30 30 (152) 11:04:33.944580 IP 172.22.6.233.57863 > 172.22.0.2.domain: 27694+ A? proxy-us-west-2-trial-1.nga911.com. (52) 11:04:33.945786 IP 172.22.0.2.domain > 172.22.6.233.57863: 27694 1/0/0 A 172.21.1.32 (68) ``` If host from `A/AAAA` response if failed, then Kamailio do not use other hosts from SRV records. ### Troubleshooting #### Reproduction 1) configured dispatcher set with `16` flag; 2) SIP URI needs a point to SRV records with two or more backend hosts; 3) start kamailio and check with kamailio use backend; 4) stop used backend; 5) make a call. #### Debugging Data none #### Log Messages none #### SIP Traffic none ### Possible Solutions not known ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` [root@ip-172-22-6-233 config]# kamailio -v version: kamailio 5.3.4 (x86_64/linux) 117ff9 flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 117ff9 compiled on 15:31:51 May 6 2020 with gcc 8.3.1 ``` * **Operating System**: ``` [root@ip-172-22-6-233 config]# cat /etc/os-release NAME="CentOS Linux" VERSION="8 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="8" PLATFORM_ID="platform:el8" PRETTY_NAME="CentOS Linux 8 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:8" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-8" CENTOS_MANTISBT_PROJECT_VERSION="8" REDHAT_SUPPORT_PRODUCT="centos" REDHAT_SUPPORT_PRODUCT_VERSION="8" ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2376

2 2

Re: [sr-dev] [SR-Users] Question about textops
by Henning Westerholt 26 Jun '20

26 Jun '20

Hi Mojtaba, not looked in the code – but it could be related to be able to check with this function for request and replies. Replies will have the method name in their CSEQ. If you have a requirement that is not available right now in the module, it can be of course extended (e.g. by pull request). Cheers, Henning -- Henning Westerholt – https://skalatan.de/blog/ Kamailio services – https://gilawa.com<https://gilawa.com/> From: sr-users <sr-users-bounces(a)lists.kamailio.org> On Behalf Of Mojtaba Sent: Friday, June 26, 2020 12:43 PM To: Kamailio (SER) - Users Mailing List <sr-users(a)lists.kamailio.org> Subject: Re: [SR-Users] Question about textops Any idea? On Wed, 24 Jun 2020, 14:26 Mojtaba, <mespio(a)gmail.com<mailto:mespio@gmail.com>> wrote: Hello, Some confusing things while developing in Kamailio: In is_method_f function in textops module, the code checks the HDR_CSEQ_F in msg also, and if the method name appears in CSEQ_F, The result is returned TRUE. These question will arise why in this function, the CSEQ field in message will check? if(parse_headers(msg, HDR_CSEQ_F, 0)!=0 || msg->cseq==NULL) { LM_ERR("cannot parse cseq header\n"); return -1; /* should it be 0 ?!?! */ } if(m->s==0) return (get_cseq(msg)->method_id&m->len)?1:-1; else return (get_cseq(msg)->method_id==METHOD_OTHER && get_cseq(msg)->method.len==m->len && (strncasecmp(get_cseq(msg)->method.s, m->s, m->len)==0))?1:-1; I think it would be nice to add new function like: is_cseq_method_f in module to avoid some problem understanding. -- --Mojtaba Esfandiari.S

1 0

git:master:319d9251: dlgs: update stats on hash table slots
by Daniel-Constantin Mierla 25 Jun '20

25 Jun '20

Module: kamailio Branch: master Commit: 319d925187149d3fdb373938662dc28a1687d43c URL: https://github.com/kamailio/kamailio/commit/319d925187149d3fdb373938662dc28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-25T09:17:38+02:00 dlgs: update stats on hash table slots --- Modified: src/modules/dlgs/dlgs_records.c Modified: src/modules/dlgs/dlgs_records.h --- Diff: https://github.com/kamailio/kamailio/commit/319d925187149d3fdb373938662dc28… Patch: https://github.com/kamailio/kamailio/commit/319d925187149d3fdb373938662dc28… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index 1a21f355db..6fcfa50945 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -496,11 +496,39 @@ int dlgs_ht_dbg(void) return 0; } +/** + * + */ +void dlgs_update_stats(dlgs_stats_t *stats, int state, int val) +{ + switch(state) { + case DLGS_STATE_INIT: + stats->c_init += val; + return; + case DLGS_STATE_PROGRESS: + stats->c_progress += val; + return; + case DLGS_STATE_ANSWERED: + stats->c_answered += val; + return; + case DLGS_STATE_CONFIRMED: + stats->c_confirmed += val; + return; + case DLGS_STATE_TERMINATED: + stats->c_terminted += val; + return; + case DLGS_STATE_NOTANSWERED: + stats->c_notanswered += val; + return; + } +} + /** * */ int dlgs_update_item(sip_msg_t *msg) { + unsigned int idx; int rtype = 0; int rmethod = 0; int rcode = 0; @@ -534,24 +562,31 @@ int dlgs_update_item(sip_msg_t *msg) LM_DBG("no matching item found\n"); return 0; } + idx = dlgs_get_index(it->hashid, _dlgs_htb->htsize); ostate = it->state; if(rtype == SIP_REQUEST) { switch(rmethod) { case METHOD_ACK: if(it->state==DLGS_STATE_ANSWERED) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_CONFIRMED; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); } break; case METHOD_CANCEL: if(it->state<DLGS_STATE_ANSWERED) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_NOTANSWERED; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); it->ts_finish = tnow; } break; case METHOD_BYE: if(it->state==DLGS_STATE_ANSWERED || it->state==DLGS_STATE_CONFIRMED) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_TERMINATED; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); it->ts_finish = tnow; } break; @@ -563,12 +598,16 @@ int dlgs_update_item(sip_msg_t *msg) case METHOD_INVITE: if(rcode>=100 && rcode<200) { if(it->state==DLGS_STATE_INIT) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_PROGRESS; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); } } else if(rcode>=200 && rcode<300) { if(it->state==DLGS_STATE_INIT || it->state==DLGS_STATE_PROGRESS) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_ANSWERED; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); it->ts_answer = tnow; if(it->ttag.len<=0) { to_body_t *tb; @@ -583,7 +622,9 @@ int dlgs_update_item(sip_msg_t *msg) } else if(rcode>=300) { if(it->state==DLGS_STATE_INIT || it->state==DLGS_STATE_PROGRESS) { + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, -1); it->state = DLGS_STATE_NOTANSWERED; + dlgs_update_stats(&_dlgs_htb->slots[idx].astats, it->state, 1); it->ts_finish = tnow; } } diff --git a/src/modules/dlgs/dlgs_records.h b/src/modules/dlgs/dlgs_records.h index 6ecd668d76..189f468c85 100644 --- a/src/modules/dlgs/dlgs_records.h +++ b/src/modules/dlgs/dlgs_records.h @@ -47,6 +47,8 @@ typedef struct _dlgs_stats { unsigned int c_notanswered; } dlgs_stats_t; +void dlgs_update_stats(dlgs_stats_t *stats, int state, int val); + typedef struct _dlgs_item { unsigned int hashid; /* item hash id */ str callid; /* sip call-id */ @@ -67,7 +69,8 @@ typedef struct _dlgs_item { typedef struct _dlgs_slot { unsigned int esize; dlgs_item_t *first; - gen_lock_t lock; + dlgs_stats_t astats; + gen_lock_t lock; } dlgs_slot_t; typedef struct _dlgs_ht { @@ -103,4 +106,4 @@ int dlgs_destroy(void); int dlgs_rpc_init(void); int dlgs_update_item(sip_msg_t *msg); -#endif \ No newline at end of file +#endif

1 0

git:master:9d9bb4c0: dlgs: fill in the totag on answer response
by Daniel-Constantin Mierla 25 Jun '20

25 Jun '20

Module: kamailio Branch: master Commit: 9d9bb4c02e8dc870e5a65a5fb87ec28c825738d1 URL: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-25T09:17:38+02:00 dlgs: fill in the totag on answer response --- Modified: src/modules/dlgs/dlgs_records.c --- Diff: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… Patch: https://github.com/kamailio/kamailio/commit/9d9bb4c02e8dc870e5a65a5fb87ec28… --- diff --git a/src/modules/dlgs/dlgs_records.c b/src/modules/dlgs/dlgs_records.c index 08b0ab4bad..1a21f355db 100644 --- a/src/modules/dlgs/dlgs_records.c +++ b/src/modules/dlgs/dlgs_records.c @@ -570,6 +570,15 @@ int dlgs_update_item(sip_msg_t *msg) || it->state==DLGS_STATE_PROGRESS) { it->state = DLGS_STATE_ANSWERED; it->ts_answer = tnow; + if(it->ttag.len<=0) { + to_body_t *tb; + tb = get_to(msg); + if(tb!=NULL && tb->tag_value.len>0 + && (tb->tag_value.len<DLGS_TOTAG_SIZE-1)) { + it->ttag.len = tb->tag_value.len; + memcpy(it->ttag.s, tb->tag_value.s, tb->tag_value.len); + } + } } } else if(rcode>=300) { if(it->state==DLGS_STATE_INIT

1 0

git:master:edd35d35: modules: readme files regenerated - pua ... [skip ci]
by Kamailio Dev 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: edd35d35e4a0bffc0d68decb6a7895b4d47823dc URL: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2020-06-24T21:16:15+02:00 modules: readme files regenerated - pua ... [skip ci] --- Modified: src/modules/pua/README --- Diff: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… Patch: https://github.com/kamailio/kamailio/commit/edd35d35e4a0bffc0d68decb6a7895b… --- diff --git a/src/modules/pua/README b/src/modules/pua/README index e232590207..3079312646 100644 --- a/src/modules/pua/README +++ b/src/modules/pua/README @@ -193,7 +193,7 @@ modparam("pua", "hash_size", 11) Example 1.2. Set db_url parameter ... -modparam("pua", "db_url" "dbdriver://username:password@dbhost/dbname") +modparam("pua", "db_url", "dbdriver://username:password@dbhost/dbname") ... 3.3. db_table (str)

1 0

[kamailio/kamailio] pua readme : small typo (#2371)
by ThomasSevestre 24 Jun '20

24 Jun '20

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2371 -- Commit Summary -- * pua readme : small typo -- File Changes -- M src/modules/pua/README (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2371.patch https://github.com/kamailio/kamailio/pull/2371.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2371

2 4

git:master:9adccda3: pua: docs - fixed missing comma in example
by GitHub 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 9adccda325d258fe539b54ec67d4389d3a2fc72c URL: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-24T21:05:56+02:00 pua: docs - fixed missing comma in example - picked from #2371 --- Modified: src/modules/pua/doc/pua_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… Patch: https://github.com/kamailio/kamailio/commit/9adccda325d258fe539b54ec67d4389… --- diff --git a/src/modules/pua/doc/pua_admin.xml b/src/modules/pua/doc/pua_admin.xml index 51d0fa3794..c4d6ab7c29 100644 --- a/src/modules/pua/doc/pua_admin.xml +++ b/src/modules/pua/doc/pua_admin.xml @@ -112,7 +112,7 @@ modparam("pua", "hash_size", 11) <title>Set <varname>db_url</varname> parameter</title> <programlisting format="linespecific"> ... -modparam("pua", "db_url" "&exampledb;") +modparam("pua", "db_url", "&exampledb;") ... </programlisting> </example>

1 0

[kamailio/kamailio] keepalive: manage the `ping_from` config value as str. (#2372)
by Daniel Martínez Ruiz 24 Jun '20

24 Jun '20

Managing the config value as a string (`char*`) doesn't change the string size, so the value is cut off to the default value size (26 chars).   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2372 -- Commit Summary -- * keepalive: manage the `ping_from` config value as str. -- File Changes -- M src/modules/keepalive/keepalive_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2372.patch https://github.com/kamailio/kamailio/pull/2372.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2372

2 2

[kamailio/kamailio] MOHQUEUE: Crash on procesing ACK (#2370)
by Alexander Butenko 24 Jun '20

24 Jun '20

### Description Kamailio is crashing every 2-3 calls with this sample config. I dont mind paying for a paid support. Please help :) Ive used asterisk server to generate calls like ``` for i in `seq 1 4`;do asterisk -rx'originate Local/1@test application MusicOnHold';done extensions.conf: [test] exten => 1,1,Set(CALLERID(all)=12345) same=n,Dial(SIP/q_1_Test_Queue@1.1.1.1:5060) request_route { # MOH queue? if ($rU=~"c_" || $rU=~"q_") { if (mohq_process ()) { if (is_method("INVITE")) { route(ACCSTART); xlog("L_INFO", "QUEUE JOIN: $ci $rm from $fu to $rU/$ruri (IP:$si:$sp)\n"); } exit; } } } route[ACCPREPARE] { $var(callid) = "$ci"; $var(referCallid) = ""; $var(did) = "$rU"; $var(clid) = "$fU"; } route[ACCSTART] { route(ACCPREPARE); xlog("L_INFO", "ACC START: did $var(did) didid $var(didid) action $var(action)-$var(value) valueid $var(valueid) trunk $si:$sp\n refered-by $(hdr(Referred-By))"); } ``` ### Troubleshooting ``` Jun 23 22:33:38 dialer-gw-qa kamailio: INFO: <script>: ACC START: did $rU didid 0 action 0-0 valueid 0 trunk 45.55.203.176:5060#012 refered-by <null> Jun 23 22:33:38 dialer-gw-qa kamailio: INFO: <script>: QUEUE JOIN: 42c9d48d39329106158a600b6c4b059e@xxxx:5060 INVITE from sip:12345@xxxxx to q_1_Test_Queue/sip:q_1_Test_Queue@xxxxx:5060 Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6825ad5 in t_check_msg (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1086 1086 t_lookup.c: No such file or directory. (gdb) (gdb) (gdb) bt #0 0x00007ffff6825ad5 in t_check_msg (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1086 #1 0x00007ffff6826997 in t_check (p_msg=0x7ffff76941a0, param_branch=0x0) at t_lookup.c:1137 #2 0x00007ffff68d1b94 in t_release (msg=0x7ffff76941a0) at tm.c:1528 #3 0x00007ffff68d1c0b in w_t_release (msg=0x7ffff76941a0, str=0x2 <error: Cannot access memory at address 0x2>, str2=0x7ffff76941a0 "\b") at tm.c:1540 #4 0x00007ffff64ce57f in ack_msg (pmsg=0x7ffff7695d38, pcall=0x7ffff2301050) at mohq_funcs.c:218 #5 0x00007ffff64e9431 in mohq_process (pmsg=0x7ffff7695d38) at mohq_funcs.c:2733 #6 0x0000555555731e23 in do_action (h=0x7fffffffcc90, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1071 #7 0x000055555573fe86 in run_actions (h=0x7fffffffcc90, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1576 #8 0x000055555574058c in run_actions_safe (h=0x7fffffffde80, a=0x7ffff76703b0, msg=0x7ffff7695d38) at core/action.c:1640 #9 0x0000555555593f30 in rval_get_int (h=0x7fffffffde80, msg=0x7ffff7695d38, i=0x7fffffffd000, rv=0x7ffff7670508, cache=0x0) at core/rvalue.c:915 #10 0x0000555555598a80 in rval_expr_eval_int (h=0x7fffffffde80, msg=0x7ffff7695d38, res=0x7fffffffd000, rve=0x7ffff7670500) at core/rvalue.c:1913 #11 0x0000555555731890 in do_action (h=0x7fffffffde80, a=0x7ffff7671ff8, msg=0x7ffff7695d38) at core/action.c:1047 #12 0x000055555573fe86 in run_actions (h=0x7fffffffde80, a=0x7ffff7671ff8, msg=0x7ffff7695d38) at core/action.c:1576 #13 0x0000555555731d8f in do_action (h=0x7fffffffde80, a=0x7ffff7672148, msg=0x7ffff7695d38) at core/action.c:1062 #14 0x000055555573fe86 in run_actions (h=0x7fffffffde80, a=0x7ffff7672148, msg=0x7ffff7695d38) at core/action.c:1576 #15 0x0000555555740698 in run_top_route (a=0x7ffff7672148, msg=0x7ffff7695d38, c=0x0) at core/action.c:1661 #16 0x0000555555747718 in receive_msg ( buf=0x555555a31820 <buf> "ACK sip:q_1_Test_Queue@xxxx:5060 SIP/2.0\r\nVia: SIP/2.0/UDP xxxx:5060;branch=z9hG4bK1415e654\r\nMax-Forwards: 70\r\nFrom: <sip:12345@xxx>;tag=as2aeac8b5\r\nTo: <sip:q_1_Test_Queu"..., len=429, rcv_info=0x7fffffffe270) at core/receive.c:423 #17 0x0000555555613318 in udp_rcv_loop () at core/udp_server.c:554 #18 0x00005555555857a5 in main_loop () at main.c:1471 #19 0x000055555559043b in main (argc=2, argv=0x7fffffffebb8) at main.c:2802 (gdb) ``` #### SIP Traffic there is nothing special in the SIP dialog. everything looks correct. ### Possible Solutions no solution yet. ### Additional Information ```` Happens with all versions of kamailio 5.2.1,5.3.1-5.3.5 version: kamailio 5.3.5 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` * **Operating System**: debian 10 latest updates ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2370

2 1

git:master:6e3a8aea: Merge pull request #2372 from danielmartinezruiz/keepalive_config_ka_ping_from_value_cut_off
by GitHub 24 Jun '20

24 Jun '20

Module: kamailio Branch: master Commit: 6e3a8aea7f9f6dde462c86dfd8cd3027c2751e98 URL: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-24T21:00:11+02:00 Merge pull request #2372 from danielmartinezruiz/keepalive_config_ka_ping_from_value_cut_off keepalive: manage the `ping_from` config value as str. --- Modified: src/modules/keepalive/keepalive_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… Patch: https://github.com/kamailio/kamailio/commit/6e3a8aea7f9f6dde462c86dfd8cd302… --- diff --git a/src/modules/keepalive/keepalive_mod.c b/src/modules/keepalive/keepalive_mod.c index e1da2e9db2..bcf021d461 100644 --- a/src/modules/keepalive/keepalive_mod.c +++ b/src/modules/keepalive/keepalive_mod.c @@ -83,8 +83,8 @@ static param_export_t params[] = { {"ping_interval", PARAM_INT, &ka_ping_interval}, {"destination", PARAM_STRING | USE_FUNC_PARAM, (void *)ka_mod_add_destination}, - {"ping_from", PARAM_STRING, &ka_ping_from}, - {"delete_counter", PARAM_INT, &ka_counter_del}, + {"ping_from", PARAM_STR, &ka_ping_from}, + {"delete_counter", PARAM_INT, &ka_counter_del}, {0, 0, 0} };

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2020