sr-dev June 2020

sr-dev@lists.kamailio.org

24 participants
395 discussions

[kamailio/kamailio] dialog: improve warning message to help better identify dialog lookup failures (#2367)

by Emmanuel Schmidbauer

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description adding the call-id will allow users to better trace when they see the warning message: ```WARNING: dialog [dlg_handlers.c:1322]: dlg_onroute(): unable to find dialog...``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2367 -- Commit Summary -- * dialog: improve warning message to help better identify lookup failures -- File Changes -- M src/modules/dialog/dlg_handlers.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2367.patch https://github.com/kamailio/kamailio/pull/2367.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2367

4 years

git:master:92ef21d7: Merge pull request #2367 from kamailio/dialog-improve-warning-msg

by GitHub

Module: kamailio Branch: master Commit: 92ef21d77d9ded1f1fda7dd83934e073e557dfb8 URL: https://github.com/kamailio/kamailio/commit/92ef21d77d9ded1f1fda7dd83934e07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2020-06-24T08:26:29+02:00 Merge pull request #2367 from kamailio/dialog-improve-warning-msg dialog: improve warning message to help better identify dialog lookup failures --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/92ef21d77d9ded1f1fda7dd83934e07… Patch: https://github.com/kamailio/kamailio/commit/92ef21d77d9ded1f1fda7dd83934e07… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 43e01eece7..4c19e98417 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1320,10 +1320,12 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) dlg = dlg_lookup(h_entry, h_id); if (dlg==0) { LM_WARN("unable to find dialog for %.*s " - "with route param '%.*s' [%u:%u]\n", + "with route param '%.*s' [%u:%u] " + "and call-id '%.*s'\n", req->first_line.u.request.method.len, req->first_line.u.request.method.s, - val.len,val.s, h_entry, h_id); + val.len,val.s, h_entry, h_id, + req->callid->body.len, req->callid->body.s); if (seq_match_mode==SEQ_MATCH_STRICT_ID ) return; } else {

4 years

git:master:c4684574: dialog: improve warning message to help better identify lookup failures

by Emmanuel Schmidbauer

Module: kamailio Branch: master Commit: c4684574e0e0e1cca4c1489a16513182f821a643 URL: https://github.com/kamailio/kamailio/commit/c4684574e0e0e1cca4c1489a1651318… Author: Emmanuel Schmidbauer <emmanuel.schmidbauer(a)textnow.com> Committer: Emmanuel Schmidbauer <emmanuel.schmidbauer(a)textnow.com> Date: 2020-06-19T16:54:40-04:00 dialog: improve warning message to help better identify lookup failures --- Modified: src/modules/dialog/dlg_handlers.c --- Diff: https://github.com/kamailio/kamailio/commit/c4684574e0e0e1cca4c1489a1651318… Patch: https://github.com/kamailio/kamailio/commit/c4684574e0e0e1cca4c1489a1651318… --- diff --git a/src/modules/dialog/dlg_handlers.c b/src/modules/dialog/dlg_handlers.c index 43e01eece7..4c19e98417 100644 --- a/src/modules/dialog/dlg_handlers.c +++ b/src/modules/dialog/dlg_handlers.c @@ -1320,10 +1320,12 @@ void dlg_onroute(struct sip_msg* req, str *route_params, void *param) dlg = dlg_lookup(h_entry, h_id); if (dlg==0) { LM_WARN("unable to find dialog for %.*s " - "with route param '%.*s' [%u:%u]\n", + "with route param '%.*s' [%u:%u] " + "and call-id '%.*s'\n", req->first_line.u.request.method.len, req->first_line.u.request.method.s, - val.len,val.s, h_entry, h_id); + val.len,val.s, h_entry, h_id, + req->callid->body.len, req->callid->body.s); if (seq_match_mode==SEQ_MATCH_STRICT_ID ) return; } else {

4 years

git:master:71248a2f: pkg: obs/kamailio.spec - set version to 5.4.0

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 71248a2f7394b69c85f030f103afb2a8f6a5a49e URL: https://github.com/kamailio/kamailio/commit/71248a2f7394b69c85f030f103afb2a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-23T19:00:13+02:00 pkg: obs/kamailio.spec - set version to 5.4.0 - set packager to Sergey Safarov - add more build requirements, including those from GH #2368 --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/71248a2f7394b69c85f030f103afb2a… Patch: https://github.com/kamailio/kamailio/commit/71248a2f7394b69c85f030f103afb2a… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 059aa431a9..7ca4184cde 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1,5 +1,5 @@ %define name kamailio -%define ver 5.2.0 +%define ver 5.4.0 %define rel dev1.0%{dist} %if 0%{?fedora} @@ -238,11 +238,11 @@ %endif -Summary: Kamailio (former OpenSER) - the Open Source SIP Server +Summary: Kamailio - the Open Source SIP Server Name: %name Version: %ver Release: %rel -Packager: Peter Dunkley <peter(a)dunkley.me.uk> +Packager: Sergey Safarov <s.safarov(a)gmail.com> License: GPL-2.0 Group: %{PKGGROUP} Source: http://kamailio.org/pub/kamailio/%{ver}/src/%{name}-%{ver}_src.tar.gz @@ -271,11 +271,20 @@ Conflicts: kamailio-utils < %ver, kamailio-websocket < %ver Conflicts: kamailio-xhttp-pi < %ver, kamailio-xmlops < %ver Conflicts: kamailio-xmlrpc < %ver, kamailio-xmpp < %ver Conflicts: kamailio-uuid < %ver -BuildRequires: bison, flex +BuildRequires: bison, flex, which, make, gcc, gcc-c++ %if 0%{?rhel} != 6 Requires: systemd BuildRequires: systemd-devel %endif + +%if 0%{?rhel} || 0%{?centos_ver} +%if 0%{?rhel} > 6 || 0%{?centos_ver} > 6 +BuildRequires: pkgconfig +%endif +%else +BuildRequires: pkgconfig +%endif + %if 0%{?suse_version} == 1315 || 0%{?suse_version} == 1330 Requires: filesystem BuildRequires: shadow

4 years

git:master:f4036c53: dialog: use the dlg hash table slot to unlock on dmq handling

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f4036c535033a333cb551b5af70703135305e7b3 URL: https://github.com/kamailio/kamailio/commit/f4036c535033a333cb551b5af707031… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-23T08:03:06+02:00 dialog: use the dlg hash table slot to unlock on dmq handling - the dlg can be destroyed on dmq replication and unlocking may fail --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/f4036c535033a333cb551b5af707031… Patch: https://github.com/kamailio/kamailio/commit/f4036c535033a333cb551b5af707031… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index fdca3f0f0a..a5628f485b 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -115,6 +115,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no unsigned int state = 1; srjson_t *vj; int newdlg = 0; + dlg_entry_t *d_entry = NULL; /* received dmq message */ LM_DBG("dmq message received\n"); @@ -219,6 +220,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no dlg = dlg_get_by_iuid_mode(&iuid, 1); if (dlg) { LM_DBG("found dialog [%u:%u] at %p\n", iuid.h_entry, iuid.h_id, dlg); + d_entry = &(d_table->entries[dlg->h_entry]); unref++; } @@ -396,9 +398,9 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no if(unref) { dlg_unref(dlg, unref); } - if(newdlg == 0) { - dlg_cell_unlock(dlg); - } + } + if(newdlg == 0 && d_entry!=NULL) { + dlg_unlock(d_table, d_entry); } srjson_DestroyDoc(&jdoc); @@ -414,10 +416,8 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no return 0; error: - if (dlg) { - if(newdlg == 0) { - dlg_cell_unlock(dlg); - } + if(newdlg == 0 && d_entry!=NULL) { + dlg_unlock(d_table, d_entry); } srjson_DestroyDoc(&jdoc); resp->reason = dmq_500_rpl;

4 years

git:master:ea8dec94: pkg/kamailio: fixed -pre release RPM packaging

by Sergey Safarov

Module: kamailio Branch: master Commit: ea8dec941897f23a0c04d045edfed80a41e042cf URL: https://github.com/kamailio/kamailio/commit/ea8dec941897f23a0c04d045edfed80… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-22T19:49:00+03:00 pkg/kamailio: fixed -pre release RPM packaging --- Modified: pkg/kamailio/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/ea8dec941897f23a0c04d045edfed80… Patch: https://github.com/kamailio/kamailio/commit/ea8dec941897f23a0c04d045edfed80… --- diff --git a/pkg/kamailio/Makefile b/pkg/kamailio/Makefile index d6ce6672f4..e30e546c29 100644 --- a/pkg/kamailio/Makefile +++ b/pkg/kamailio/Makefile @@ -7,7 +7,7 @@ $(error Please start "make cfg" first) endif RPMBUILD_TOP := /tmp/kamailio_rpmbuild -RPM_VER = ${shell echo "$(RELEASE)" | sed -e "s/-dev[0-9]//" -e "s/-rc[0-9]//"} +RPM_VER = ${shell echo "$(RELEASE)" | sed -e "s/-dev[0-9]//" -e "s/-rc[0-9]//" -e "s/-pre[0-9]//"} RPM_REL = ${shell echo "$(RELEASE)." | grep -o -P "dev[0-9]\." } DIST_ARCHIVE = ${shell echo "kamailio-$(RPM_VER)_src.tar.gz"} APK_VERSION = ${shell echo "$(RELEASE)" | grep -o "^[0-9.]*"}

4 years

git:master:a7e08a6c: pkg/kamailio/obs: packaged dlgs module

by Sergey Safarov

Module: kamailio Branch: master Commit: a7e08a6c6baa9a4cf35f3a6589dff53f27253deb URL: https://github.com/kamailio/kamailio/commit/a7e08a6c6baa9a4cf35f3a6589dff53… Author: Sergey Safarov <s.safarov(a)gmail.com> Committer: Sergey Safarov <s.safarov(a)gmail.com> Date: 2020-06-22T17:58:57+03:00 pkg/kamailio/obs: packaged dlgs module --- Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/a7e08a6c6baa9a4cf35f3a6589dff53… Patch: https://github.com/kamailio/kamailio/commit/a7e08a6c6baa9a4cf35f3a6589dff53… --- diff --git a/pkg/kamailio/obs/kamailio.spec b/pkg/kamailio/obs/kamailio.spec index 1eb7db7c30..059aa431a9 100644 --- a/pkg/kamailio/obs/kamailio.spec +++ b/pkg/kamailio/obs/kamailio.spec @@ -1428,6 +1428,7 @@ fi %doc %{_docdir}/kamailio/modules/README.dialog %doc %{_docdir}/kamailio/modules/README.dispatcher %doc %{_docdir}/kamailio/modules/README.diversion +%doc %{_docdir}/kamailio/modules/README.dlgs %doc %{_docdir}/kamailio/modules/README.dmq %doc %{_docdir}/kamailio/modules/README.domain %doc %{_docdir}/kamailio/modules/README.domainpolicy @@ -1584,6 +1585,7 @@ fi %{_libdir}/kamailio/modules/dialog.so %{_libdir}/kamailio/modules/dispatcher.so %{_libdir}/kamailio/modules/diversion.so +%{_libdir}/kamailio/modules/dlgs.so %{_libdir}/kamailio/modules/dmq.so %{_libdir}/kamailio/modules/domain.so %{_libdir}/kamailio/modules/domainpolicy.so

4 years

git:master:41db985e: evapi: free addr info in case of bind error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 41db985ebfcb691f2e20e689a83379e382ef6c03 URL: https://github.com/kamailio/kamailio/commit/41db985ebfcb691f2e20e689a83379e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-22T15:32:30+02:00 evapi: free addr info in case of bind error --- Modified: src/modules/evapi/evapi_dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/41db985ebfcb691f2e20e689a83379e… Patch: https://github.com/kamailio/kamailio/commit/41db985ebfcb691f2e20e689a83379e… --- diff --git a/src/modules/evapi/evapi_dispatch.c b/src/modules/evapi/evapi_dispatch.c index 4d253865e9..0f95291bad 100644 --- a/src/modules/evapi/evapi_dispatch.c +++ b/src/modules/evapi/evapi_dispatch.c @@ -694,6 +694,7 @@ int evapi_run_dispatcher(char *laddr, int lport) if (bind(evapi_srv_sock, ai_res->ai_addr, ai_res->ai_addrlen) < 0) { LM_ERR("cannot bind to local address and port [%s:%d]\n", laddr, lport); close(evapi_srv_sock); + freeaddrinfo(ai_res); return -1; } freeaddrinfo(ai_res);

4 years

Kamailio v5.3.5 Released

by Daniel-Constantin Mierla

Hello, Kamailio SIP Server v5.3.5 stable release is out. This is a maintenance release of the latest stable branch, 5.3, that includes fixes since the release of v5.3.4. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.3.x. Deployments running previous v5.3.x versions are strongly recommended to be upgraded to v5.3.5. For more details about version 5.3.5 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2020/06/kamailio-v5-3-5-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

4 years

git:5.3:9e70e8ec: ChangeLog: content updated for v5.3.5

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.3 Commit: 9e70e8ec1a80787cfafc63ea0200766e385ae022 URL: https://github.com/kamailio/kamailio/commit/9e70e8ec1a80787cfafc63ea0200766… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-06-22T11:53:41+02:00 ChangeLog: content updated for v5.3.5 --- Modified: ChangeLog --- Diff: https://github.com/kamailio/kamailio/commit/9e70e8ec1a80787cfafc63ea0200766… Patch: https://github.com/kamailio/kamailio/commit/9e70e8ec1a80787cfafc63ea0200766…

4 years

← Newer
1
...
14
15
16
17
18
19
20
...
40
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2020