Yes, but did it actually break the delete operation, or was it just a performance optimisation? In either case I can probably come up with an alternative patch that doesn't break the set indexes.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…
>From the original issue "Former code always assumed filters would be involved so this change skips the filter matching if no filter is applied."
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…
I did a review and merged it, if it causes a regression I will revert it. But @rdboisvert can problably best comment on the reasoning for this change, wait a bit for him to reply.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…
If @rdboisvert or @henningw don't have other comments, it can be reverted, or maybe a modparam should added to enable/disable the behaviour of this patch, with default setting to be disabled, as it seems to be the one to have it working.
As you said, it would be good to know what was the reason for this patch, what cases it was supposed to fix. I merged it based on the fact that we have to support the `delete all` operation and seemed to have that purpose.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…
Hello,
so far it looks pretty calm during the testing phase, some static
analysis didn't reveal any new major issues (well, this is done also
during development phase). Therefore, if nothing else is proposed or
shows up, I am considering to create the git branch 5.4 next week on
Thursday -- this branch will hold the code for 5.4.x release series.
After branching 5.4, the master branch will be open again for new
features. The 5.4.0 enters the release candidate phase, likely to have
the first release out in 1-2 weeks after branching.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Funding: https://www.paypal.me/dcmierla
Hello,
on Wednesday, July 8, 2020, there will be some work on Kamailio project
infrastructure. Therefore there could be short intervals of downtime for
online resources like the web server, wiki, documentation and downloads
portals, mailing lists or the GIT repository mirror.
Once the maintenance work is finished, we will post an update.
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Funding: https://www.paypal.me/dcmierla