sr-dev July 2020

sr-dev@lists.kamailio.org

26 participants
390 discussions

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Richard Fuchs 08 Jul '20

08 Jul '20

Yes, but did it actually break the delete operation, or was it just a performance optimisation? In either case I can probably come up with an alternative patch that doesn't break the set indexes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Henning Westerholt 08 Jul '20

08 Jul '20

>From the original issue "Former code always assumed filters would be involved so this change skips the filter matching if no filter is applied." -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Richard Fuchs 08 Jul '20

08 Jul '20

@rdboisvert it should already do this. Which part was not working for you? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by rdboisvert 08 Jul '20

08 Jul '20

We would like to have a delete row function as described in in section [9.2.9](http://www.asipto.com/pub/kamailio-devel-guide/#c09f_delete) of the Kamailio SIP Server v3.2.0 Development Guide. If I implemented the feature incorrectly then we would appreciate someone fixing this. Thanks! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Henning Westerholt 08 Jul '20

08 Jul '20

I did a review and merged it, if it causes a regression I will revert it. But @rdboisvert can problably best comment on the reasoning for this change, wait a bit for him to reply. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Re: [sr-dev] [kamailio/kamailio] db_redis: allow deletion of all rows (bf2ecd4)
by Daniel-Constantin Mierla 08 Jul '20

08 Jul '20

If @rdboisvert or @henningw don't have other comments, it can be reverted, or maybe a modparam should added to enable/disable the behaviour of this patch, with default setting to be disabled, as it seems to be the one to have it working. As you said, it would be good to know what was the reason for this patch, what cases it was supposed to fix. I merged it based on the fact that we have to support the `delete all` operation and seemed to have that purpose. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/bf2ecd4dec55d5009e0904392d083e1…

1 0

Branching 5.4 in git repository
by Daniel-Constantin Mierla 08 Jul '20

08 Jul '20

Hello, so far it looks pretty calm during the testing phase, some static analysis didn't reveal any new major issues (well, this is done also during development phase). Therefore, if nothing else is proposed or shows up, I am considering to create the git branch 5.4 next week on Thursday -- this branch will hold the code for 5.4.x release series. After branching 5.4, the master branch will be open again for new features. The 5.4.0 enters the release candidate phase, likely to have the first release out in 1-2 weeks after branching. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Funding: https://www.paypal.me/dcmierla

1 1

Maintenance work on kamailio.org server - Wed, July 8, 2020
by Daniel-Constantin Mierla 08 Jul '20

08 Jul '20

Hello, on Wednesday, July 8, 2020, there will be some work on Kamailio project infrastructure. Therefore there could be short intervals of downtime for online resources like the web server, wiki, documentation and downloads portals, mailing lists or the GIT repository mirror. Once the maintenance work is finished, we will post an update. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Funding: https://www.paypal.me/dcmierla

1 2

git:master:317f7074: core: tcp - debug message when removing connection from list
by Daniel-Constantin Mierla 08 Jul '20

08 Jul '20

Module: kamailio Branch: master Commit: 317f707425a4cf0be144d2c874fcdf2ad8d7f992 URL: https://github.com/kamailio/kamailio/commit/317f707425a4cf0be144d2c874fcdf2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-08T14:44:34+02:00 core: tcp - debug message when removing connection from list --- Modified: src/core/tcp_read.c --- Diff: https://github.com/kamailio/kamailio/commit/317f707425a4cf0be144d2c874fcdf2… Patch: https://github.com/kamailio/kamailio/commit/317f707425a4cf0be144d2c874fcdf2… --- diff --git a/src/core/tcp_read.c b/src/core/tcp_read.c index ed0a5753cb..655db7da7b 100644 --- a/src/core/tcp_read.c +++ b/src/core/tcp_read.c @@ -1881,6 +1881,13 @@ inline static int handle_io(struct fd_map* fm, short events, int idx) ip_addr2a(&con->rcv.dst_ip), con->rcv.dst_port); } if(tcp_conn_lst!=NULL) { + LM_DBG("removing from list %p id %d fd %d," + " state %d, flags %x, main fd %d, refcnt %d" + " ([%s]:%u -> [%s]:%u)\n", + con, con->id, con->fd, con->state, + con->flags, con->s, atomic_get(&con->refcnt), + ip_addr2a(&con->rcv.src_ip), con->rcv.src_port, + ip_addr2a(&con->rcv.dst_ip), con->rcv.dst_port); tcpconn_listrm(tcp_conn_lst, con, c_next, c_prev); local_timer_del(&tcp_reader_ltimer, &con->timer); if (unlikely(resp!=CONN_EOF))

1 0

git:master:41bdb340: kamailio.cfg: set disable_sctp to yes
by Daniel-Constantin Mierla 08 Jul '20

08 Jul '20

Module: kamailio Branch: master Commit: 41bdb340952aa3c2c9b45ca2807e4366908c1b42 URL: https://github.com/kamailio/kamailio/commit/41bdb340952aa3c2c9b45ca2807e436… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2020-07-08T14:28:04+02:00 kamailio.cfg: set disable_sctp to yes - in auto mode a log message is printed about not having sctp module loaded, which is not done in the default config --- Modified: etc/kamailio.cfg --- Diff: https://github.com/kamailio/kamailio/commit/41bdb340952aa3c2c9b45ca2807e436… Patch: https://github.com/kamailio/kamailio/commit/41bdb340952aa3c2c9b45ca2807e436… --- diff --git a/etc/kamailio.cfg b/etc/kamailio.cfg index c0e618719b..ba0bccb6b7 100644 --- a/etc/kamailio.cfg +++ b/etc/kamailio.cfg @@ -192,6 +192,10 @@ tcp_connection_lifetime=3605 /* upper limit for TCP connections (it includes the TLS connections) */ tcp_max_connections=2048 +#!ifdef WITH_JSONRPC +tcp_accept_no_cl=yes +#!endif + #!ifdef WITH_TLS enable_tls=yes @@ -199,9 +203,8 @@ enable_tls=yes tls_max_connections=2048 #!endif -#!ifdef WITH_JSONRPC -tcp_accept_no_cl=yes -#!endif +/* set it to yes to enable sctp and load sctp.so module */ +disable_sctp = yes ####### Custom Parameters #########

1 0

← Newer
1
...
27
28
29
30
31
32
33
...
39
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev July 2020