<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [X] Commit message has the format required by CONTRIBUTING guide
- [X] Commits are split per component (core, individual modules, libs, utils, ...)
- [X] Each component has a single commit (if not, squash them into one commit)
- [X] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [X] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
`ctx` was not getting initialized with the result of `run_top_route()` execution preventing `drop();` to work in the `siptrace:msg` event route
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2431
-- Commit Summary --
* siptrace: fix run_top_route() call to set ctx
-- File Changes --
M src/modules/siptrace/siptrace.c (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2431.patchhttps://github.com/kamailio/kamailio/pull/2431.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2431
[View Less]
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, …
[View More]tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x ] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
Histogram metric and minor issues.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2435
-- Commit Summary --
* xhttp_prom: add support for histogram metrics.
-- File Changes --
M src/modules/xhttp_prom/doc/xhttp_prom_admin.xml (203)
M src/modules/xhttp_prom/prom.c (102)
M src/modules/xhttp_prom/prom.h (21)
M src/modules/xhttp_prom/prom_metric.c (909)
M src/modules/xhttp_prom/prom_metric.h (50)
M src/modules/xhttp_prom/xhttp_prom.c (630)
M src/modules/xhttp_prom/xhttp_prom.h (25)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2435.patchhttps://github.com/kamailio/kamailio/pull/2435.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2435
[View Less]
Indeed, thanks! Pushed a commit using NULL comparison to follow recommendations to highlight is about pointers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/6da946e4a3d6d6949dd6babe9cf3919…
if(_ksr_shutdown_phase) {
instance of _ksr_shutdown_phase cannot be initialized here.
it supposed to be: if(!_ksr_shutdown_phase) {
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/6da946e4a3d6d6949dd6babe9cf3919…
### Description
I prefer to use interface name for `listen`
*example*
```
listen=udp:eth0:5060
```
When `kamailo` started then bounded only to IPv4 address.
Could be added feature dual-stack bounding when used interface name.
tested latest master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2404
Extract from examples.
```
Jun 19 11:07:47 localhost kamailio[8645]: 5(8658) ERROR: app_python3 [python_support.c:156]: python_handle_exception(): apy_exec: ksr_request_route((null)): Unhandled exception in the Python code:
Jun 19 11:07:47 localhost kamailio[8645]: AttributeError: 'kamailio' object has no attribute 'ksr_onsend_route'
Jun 19 11:07:47 localhost kamailio[8645]: During handling of the above exception, another exception occurred:
Jun 19 11:07:47 localhost kamailio[8645]: Traceback …
[View More](most recent call last):
Jun 19 11:07:47 localhost kamailio[8645]: File "/etc/kamailio/kamailio.py", line 68, in ksr_request_route
Jun 19 11:07:47 localhost kamailio[8645]: if self.ksr_route_withindlg(msg) ==- 255:
Jun 19 11:07:47 localhost kamailio[8645]: File "/etc/kamailio/kamailio.py", line 202, in ksr_route_withindlg
Jun 19 11:07:47 localhost kamailio[8645]: self.ksr_route_relay(msg)
Jun 19 11:07:47 localhost kamailio[8645]: File "/etc/kamailio/kamailio.py", line 135, in ksr_route_relay
Jun 19 11:07:47 localhost kamailio[8645]: if KSR.tm.t_relay():
Jun 19 11:07:47 localhost kamailio[8645]: SystemError: <built-in function t_relay> returned a result with an error set
Jun 19 11:07:47 localhost kamailio[8645]: 5(8658) DEBUG: app_python3 [apy_kemi.c:112]: sr_kemi_config_engine_python(): execution of route type 1 with no name returned -1
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2366
[View Less]