Module: kamailio
Branch: master
Commit: 857e9deb4c2455ee2ea0c05446da54f97e1f0a63
URL: https://github.com/kamailio/kamailio/commit/857e9deb4c2455ee2ea0c05446da54f…
Author: Juha Heinanen <jh(a)tutpro.com>
Committer: Juha Heinanen <jh(a)tutpro.com>
Date: 2021-02-11T17:44:19+02:00
Improved README.
---
Modified: src/modules/rr/doc/rr_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/857e9deb4c2455ee2ea0c05446da54f…
Patch: https://github.com/kamailio/kamailio/commit/857e9deb4c2455ee2ea0c05446da54f…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 7dc08b7b5c..7916789a82 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -628,7 +628,8 @@ record_route_advertised_address("1.2.3.4:5080");
<para>Adds a parameter to the Record-Route URI (param must be in
<quote>;name=value</quote> format. The function may be called also
- before or after the record_route() or record_route_advertised_address()
+ before or after the record_route(),
+ record_route_advertised_address(), and record_route_preset()
calls (see <xref linkend="rr.f.record_route"/> or <xref
linkend="rr.f.record_route_adv_addr"/>)).</para>
R-R URI parameters do not get added to outgoing R-R header(s) when add_rr_param() call is made after record_route_preset() call.
I don't know if this a bug or a feature, but it would be very useful if add_rr_param() would work same way after record_route_preset() as it works after record_route().
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/2634
Module: kamailio
Branch: master
Commit: f8e60bcba548b25657cc295f8a593adf371f9fda
URL: https://github.com/kamailio/kamailio/commit/f8e60bcba548b25657cc295f8a593ad…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2021-02-11T16:22:06+01:00
rr: docs - added missing end tag for para introduced in previous commit
---
Modified: src/modules/rr/doc/rr_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/f8e60bcba548b25657cc295f8a593ad…
Patch: https://github.com/kamailio/kamailio/commit/f8e60bcba548b25657cc295f8a593ad…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 18c9e3156f..a925014715 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -561,7 +561,7 @@ remove_record_route();
the value has to be like "address:port;parameters", the port and
parameters are optional. If the second parameter is provided, do not
forget to add the parameter "r2=0" so the proxy processes both
- corresponding Route headers at once.
+ corresponding Route headers at once.</para>
<para>When the <quote>outbound</quote> module was loaded before this
module this function will determine whether outbound is required for the
Module: kamailio
Branch: master
Commit: f318fab629c308250531046d453a8ac76f80ca42
URL: https://github.com/kamailio/kamailio/commit/f318fab629c308250531046d453a8ac…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2021-02-11T16:06:12+01:00
rr: docs - note about format of record_route_preset() parameters
---
Modified: src/modules/rr/doc/rr_admin.xml
---
Diff: https://github.com/kamailio/kamailio/commit/f318fab629c308250531046d453a8ac…
Patch: https://github.com/kamailio/kamailio/commit/f318fab629c308250531046d453a8ac…
---
diff --git a/src/modules/rr/doc/rr_admin.xml b/src/modules/rr/doc/rr_admin.xml
index 514c8b4a04..18c9e3156f 100644
--- a/src/modules/rr/doc/rr_admin.xml
+++ b/src/modules/rr/doc/rr_admin.xml
@@ -535,8 +535,8 @@ remove_record_route();
<title><function moreinfo="none">record_route_preset(string
[,string2])</function></title>
- <para>This function will put the string into Record-Route, don't use
- unless you know what you are doing.</para>
+ <para>This function will put the string params into Record-Route, avoid
+ to use it unless you know what you are doing.</para>
<para>Meaning of the parameters is as follows:</para>
@@ -556,6 +556,13 @@ remove_record_route();
to the outbound interface and the 'string2' param is pointing to the
inbound interface.</para>
+ <para>Note: The value of parameters must not contain the SIP protocol
+ scheme (sip: or sips:), one is added based on routing requirements. Thus
+ the value has to be like "address:port;parameters", the port and
+ parameters are optional. If the second parameter is provided, do not
+ forget to add the parameter "r2=0" so the proxy processes both
+ corresponding Route headers at once.
+
<para>When the <quote>outbound</quote> module was loaded before this
module this function will determine whether outbound is required for the
request and generate and add a flow-token as the username part of the