sr-dev February 2021

sr-dev@lists.kamailio.org

20 participants
250 discussions

[kamailio/kamailio] authentificated INVITE badly managed when topos is activated (#2629)

by fgaisnon

### Description If topos is activated and kamailio responds a 407 "proxy authentication required" to a initial INVITE, INVITE received after with credentials (MD5 response in Proxy-Authorization header) is badly managed. Credentials are never validated and kamailio responds 407 again. If topoh is used instead topos all works fine and credential are validated. ### Troubleshooting #### Reproduction Always. #### SIP Traffic ### Possible Solutions I have tested with official kamailio 5.4.3-0. * **Operating System**: centos 7 (3.10.0-693.11.1.el7.x86_64) -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2629

4 years

git:5.4:218350f0: siputils: free params for contact param decode and remove

by Daniel-Constantin Mierla

Module: kamailio Branch: 5.4 Commit: 218350f089be9c3b5505079079df63d25dd74cc4 URL: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-08T12:04:38+01:00 siputils: free params for contact param decode and remove (cherry picked from commit d6504e28f7fef8d48480861ea12e9bd457288661) --- Modified: src/modules/siputils/contact_ops.c --- Diff: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… Patch: https://github.com/kamailio/kamailio/commit/218350f089be9c3b5505079079df63d… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index a299db32e5..f21d7705b3 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -773,6 +773,7 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) } if(pit==NULL || pit->body.len<=0) { free_params(params); + params = NULL; continue; } @@ -816,6 +817,8 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) pkg_free(nval.s); return -2; } + free_params(params); + params = NULL; } return 1; @@ -974,6 +977,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) } if(pit==NULL) { free_params(params); + params = NULL; continue; } rms.s = pit->name.s; @@ -984,6 +988,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) LM_ERR("failed to find start of the parameter delimiter [%.*s]\n", c->uri.len, c->uri.s); free_params(params); + params = NULL; continue; } if(pit->body.len>0) { @@ -1004,6 +1009,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) continue; } free_params(params); + params = NULL; } return 1;

4 years

git:master:d6504e28: siputils: free params for contact param decode and remove

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d6504e28f7fef8d48480861ea12e9bd457288661 URL: https://github.com/kamailio/kamailio/commit/d6504e28f7fef8d48480861ea12e9bd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-08T11:54:32+01:00 siputils: free params for contact param decode and remove --- Modified: src/modules/siputils/contact_ops.c --- Diff: https://github.com/kamailio/kamailio/commit/d6504e28f7fef8d48480861ea12e9bd… Patch: https://github.com/kamailio/kamailio/commit/d6504e28f7fef8d48480861ea12e9bd… --- diff --git a/src/modules/siputils/contact_ops.c b/src/modules/siputils/contact_ops.c index a299db32e5..f21d7705b3 100644 --- a/src/modules/siputils/contact_ops.c +++ b/src/modules/siputils/contact_ops.c @@ -773,6 +773,7 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) } if(pit==NULL || pit->body.len<=0) { free_params(params); + params = NULL; continue; } @@ -816,6 +817,8 @@ int ki_contact_param_decode(sip_msg_t *msg, str *nparam) pkg_free(nval.s); return -2; } + free_params(params); + params = NULL; } return 1; @@ -974,6 +977,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) } if(pit==NULL) { free_params(params); + params = NULL; continue; } rms.s = pit->name.s; @@ -984,6 +988,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) LM_ERR("failed to find start of the parameter delimiter [%.*s]\n", c->uri.len, c->uri.s); free_params(params); + params = NULL; continue; } if(pit->body.len>0) { @@ -1004,6 +1009,7 @@ int ki_contact_param_rm(sip_msg_t *msg, str *nparam) continue; } free_params(params); + params = NULL; } return 1;

4 years

git:master:120c4717: modules: readme files regenerated - siptrace ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 120c47178475ad658a8a1846b6cd65b755cde2ac URL: https://github.com/kamailio/kamailio/commit/120c47178475ad658a8a1846b6cd65b… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-02-06T16:16:24+01:00 modules: readme files regenerated - siptrace ... [skip ci] --- Modified: src/modules/siptrace/README --- Diff: https://github.com/kamailio/kamailio/commit/120c47178475ad658a8a1846b6cd65b… Patch: https://github.com/kamailio/kamailio/commit/120c47178475ad658a8a1846b6cd65b… --- diff --git a/src/modules/siptrace/README b/src/modules/siptrace/README index 892c7946ee..59f677e899 100644 --- a/src/modules/siptrace/README +++ b/src/modules/siptrace/README @@ -526,7 +526,7 @@ modparam("siptrace", "trace_init_mode", 1) * 0 - no automatic mirroring or storing of SIP traffic. * 1 (1st bit set) - mirror the traffic to HEP server. * 2 (2nd bit set) - store the traffic to database server. - * 4 (3rd bit set) - mirro the traffic to the SIP URI specified by + * 4 (3rd bit set) - mirror the traffic to the SIP URI specified by duplicate_uri. The trace_on parameter still has to be set, allowing also to control

4 years

git:master:7d846f92: siptrace: docs - fixed small typo

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 7d846f928b75a3bc1b8e8c1a70e39bfede939c15 URL: https://github.com/kamailio/kamailio/commit/7d846f928b75a3bc1b8e8c1a70e39bf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-02-06T16:06:47+01:00 siptrace: docs - fixed small typo --- Modified: src/modules/siptrace/doc/siptrace_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7d846f928b75a3bc1b8e8c1a70e39bf… Patch: https://github.com/kamailio/kamailio/commit/7d846f928b75a3bc1b8e8c1a70e39bf… --- diff --git a/src/modules/siptrace/doc/siptrace_admin.xml b/src/modules/siptrace/doc/siptrace_admin.xml index 6966289a69..c160b97275 100644 --- a/src/modules/siptrace/doc/siptrace_admin.xml +++ b/src/modules/siptrace/doc/siptrace_admin.xml @@ -587,7 +587,7 @@ modparam("siptrace", "trace_init_mode", 1) </listitem> <listitem> <para> - 4 (3rd bit set) - mirro the traffic to the SIP URI specified by + 4 (3rd bit set) - mirror the traffic to the SIP URI specified by duplicate_uri. </para> </listitem>

4 years

[kamailio/kamailio] http_client: http_client_request to include default clientcert, clien… (#2612)

by Wolfgang Kampichler

- the lost module uses http_client API functions and in the course of NG112 client certificates are used for authentication when querying LIS or ECRF, the fix allows these to be read out via http_client module parameters.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  To use client certificates for authentication when sending HTTP requests via the http_client API function `http_client_request`, the auth. specific module parameters (default values) are not passed to curl. The fix allows these to be read out via http_client module parameters to set proper curl config parameters. Maybe it's a new feature rather than a fix. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2612 -- Commit Summary -- * http_client: http_client_request to include default clientcert, clientkey,... -- File Changes -- M src/modules/http_client/functions.c (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2612.patch https://github.com/kamailio/kamailio/pull/2612.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2612

4 years

git:master:5b596373: Merge pull request #2612 from kamailio/wkampich/dev

by GitHub

Module: kamailio Branch: master Commit: 5b596373e022bca905ecb9802c0fdf28d29b2a87 URL: https://github.com/kamailio/kamailio/commit/5b596373e022bca905ecb9802c0fdf2… Author: Olle E. Johansson <oej(a)edvina.net> Committer: GitHub <noreply(a)github.com> Date: 2021-02-05T20:39:55+01:00 Merge pull request #2612 from kamailio/wkampich/dev http_client: http_client_request to include default clientcert, clienâ¦ --- Modified: src/modules/http_client/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/5b596373e022bca905ecb9802c0fdf2… Patch: https://github.com/kamailio/kamailio/commit/5b596373e022bca905ecb9802c0fdf2… --- diff --git a/src/modules/http_client/functions.c b/src/modules/http_client/functions.c index a04065d6db..7db116ed21 100644 --- a/src/modules/http_client/functions.c +++ b/src/modules/http_client/functions.c @@ -673,6 +673,18 @@ int http_client_request( query_params.http_proxy_port = default_http_proxy_port; } } + if(default_tls_clientcert.s != NULL && default_tls_clientcert.len > 0) { + query_params.clientcert = default_tls_clientcert.s; + } + if(default_tls_clientkey.s != NULL && default_tls_clientkey.len > 0) { + query_params.clientkey = default_tls_clientkey.s; + } + if(default_tls_cacert != NULL) { + query_params.cacert = default_tls_cacert; + } + if(default_cipher_suite_list.s != NULL && default_cipher_suite_list.len) { + query_params.ciphersuites = default_cipher_suite_list.s; + } res = curL_request_url(_m, _met, _url, _dst, &query_params);

4 years

git:master:7d5868ab: http_client: http_client_request to include default clientcert, clientkey, ...

by Wolfgang Kampichler

Module: kamailio Branch: master Commit: 7d5868ab1242eb8166e6af1bb8a21b39001df663 URL: https://github.com/kamailio/kamailio/commit/7d5868ab1242eb8166e6af1bb8a21b3… Author: Wolfgang Kampichler <dev(a)kampichler.info> Committer: Wolfgang Kampichler <dev(a)kampichler.info> Date: 2021-01-27T19:53:24+01:00 http_client: http_client_request to include default clientcert, clientkey,... - the lost module uses http_client API functions and in the course of NG112 client certificates are used for authentication when querying LIS or ECRF, the fix allows these to be read out via http_client module parameters. --- Modified: src/modules/http_client/functions.c --- Diff: https://github.com/kamailio/kamailio/commit/7d5868ab1242eb8166e6af1bb8a21b3… Patch: https://github.com/kamailio/kamailio/commit/7d5868ab1242eb8166e6af1bb8a21b3… --- diff --git a/src/modules/http_client/functions.c b/src/modules/http_client/functions.c index a04065d6db..7db116ed21 100644 --- a/src/modules/http_client/functions.c +++ b/src/modules/http_client/functions.c @@ -673,6 +673,18 @@ int http_client_request( query_params.http_proxy_port = default_http_proxy_port; } } + if(default_tls_clientcert.s != NULL && default_tls_clientcert.len > 0) { + query_params.clientcert = default_tls_clientcert.s; + } + if(default_tls_clientkey.s != NULL && default_tls_clientkey.len > 0) { + query_params.clientkey = default_tls_clientkey.s; + } + if(default_tls_cacert != NULL) { + query_params.cacert = default_tls_cacert; + } + if(default_cipher_suite_list.s != NULL && default_cipher_suite_list.len) { + query_params.ciphersuites = default_cipher_suite_list.s; + } res = curL_request_url(_m, _met, _url, _dst, &query_params);

4 years

[kamailio/kamailio] keepalive.list crash (#2618)

by juha-h

With Kamalio master, RPC command keepalive.list causes crash (at least when there is nothing in the list). gdb) bt full #0 rpc_struct_add (s=0x560b4df75830, fmt=0x7f2da23322c3 "SS") at binrpc_run.c:1092 ap = {{gp_offset = 32, fp_offset = 48, overflow_arg_area = 0x7ffebd54cfc0, reg_save_area = 0x7ffebd54ced0}} err = -1118515440 avp = {name = {s = 0x7f2da23322bf "uri", len = 3}, type = 1, u = {strval = {s = 0x0, len = 0}, fval = 0, intval = 0, end = 0}} rs = 0x7ffebd54d0e0 __func__ = "rpc_struct_add" #1 0x00007f2da2322776 in keepalive_rpc_list (rpc=0x7f2da2f022e0 <binrpc_callbacks>, ctx=0x7ffebd54d0e0) at keepalive_rpc.c:86 sub = 0x560b4df75830 dest = 0x1 t_buf = '\000' <repeats 25 times> #2 0x00007f2da2ecc993 in process_rpc_req ( buf=0x560b4df55784 "\241\003\021'\332D}\221\017keepalive.list", size=24, bytes_needed=0x7ffebd54d1e8, sh=0x7ffebd54d250, saved_state=0x560b4df65788) at binrpc_run.c:683 err = 0 val = {name = {s = 0x7ffebd54d1c0 " \323T\275\376\177", len = -1561476359}, type = 1, u = {strval = {s = 0x560b4df5578d "keepalive.list", len = 14}, fval = 4.6741847488088159e-310, intval = 1307924365, end = 1307924365}} rpc_e = 0x7f2da3c91910 f_ctx = {in = {ctx = {tlen = 17, cookie = 668615805, type = 0, flags = 1, offset = 17, in_struct = 0, in_array = 0}, s = 0x560b4df5579c "", end = 0x560b4df5579c "", record_no = 0, in_struct = 0}, out = {pkt = { body = 0x560b4df65820 "\003\203", end = 0x560b4df75820 "", crt = 0x560b4df65822 ""}, structs = {next = 0x560b4df75830, prev = 0x560b4df75830}}, send_h = 0x7ffebd54d250, method = 0x560b4df5578d "keepalive.list", gc = 0x0, replied = 0, err_code = 0, --Type <RET> for more, q to quit, c to continue without paging-- err_phrase = {s = 0x0, len = 0}} ctx = 0x7ffebd54d0e0 __func__ = "process_rpc_req" #3 0x00007f2da2ee9ae9 in handle_stream_read (s_c=0x560b4df55750, idx=-1) at io_listener.c:511 bytes_free = 65535 bytes_read = 24 bytes_needed = 1307733728 bytes_processed = 22027 r = 0x560b4df55770 sh = {fd = 15, type = 0, from = {sa_in = {s = {sa_family = 0, sa_data = "\000\000\000\000\000\000\001\000\377\377\377\377\377\377"}, sin = { sin_family = 0, sin_port = 0, sin_addr = {s_addr = 0}, sin_zero = "\001\000\377\377\377\377\377\377"}, sin6 = {sin6_family = 0, sin6_port = 0, sin6_flowinfo = 0, sin6_addr = {__in6_u = { __u6_addr8 = "\001\000", '\377' <repeats 14 times>, __u6_addr16 = {1, 65535, 65535, 65535, 65535, 65535, 65535, 65535}, __u6_addr32 = { 4294901761, 4294967295, 4294967295, 4294967295}}}, sin6_scope_id = 0}, sas = {ss_family = 0, __ss_padding = "\000\000\000\000\000\000\001\000", '\377' <repeats 14 times>, '\000' <repeats 16 times>, "\001\000\000\000\000\000\000\000\260:\n\232-\177", '\000' <repeats 18 times>, "\340\322T\275\001\000\000\000\260:\n\232-\177\000\000\340\322T\275\376\177\000\000\231{\355\242-\177\000\000\000\000\300\000\000\000\000\000\260:\n\232-\177\000", __ss_align = 10513424}}, sa_un = {sun_family = 0, sun_path = "\000\000\000\000\000\000\001\000", '\377' <repeats 14 times>, '\000' <repeats 16 times>, "\001\000\000\000\000\000\000\000\260:\n\232-\177", '\000' <repeats 18 times>, "\340\322T\275\001\000\000\000\260:\n\232-\177\000\000\340\322T\275\376\177\000\000\231{\355\242-\177\000\000\000\000\300\000\000"}}, from_len = 0} __func__ = "handle_stream_read" #4 0x00007f2da2eeb870 in handle_io (fm=0x7f2da3ca38a8, events=1, idx=-1) at io_listener.c:706 --Type <RET> for more, q to quit, c to continue without paging-- ret = 1 __func__ = "handle_io" #5 0x00007f2da2ee2092 in io_wait_loop_epoll (h=0x7f2da2f02380 <ctl_io_h>, t=10, repeat=0) at ../../core/io_wait.h:1070 n = 1 r = 0 fm = 0x7f2da3ca38a8 revents = 1 __func__ = "io_wait_loop_epoll" #6 0x00007f2da2ee6707 in io_listen_loop (fd_no=1, cs_lst=0x560b4df26ee0) at io_listener.c:281 max_fd_no = 295 poll_err = 0x0 poll_method = 2 cs = 0x0 type = 2 __func__ = "io_listen_loop" #7 0x00007f2da2ef1aa2 in mod_child (rank=0) at ctl.c:338 pid = 0 cs = 0x7f2d9a0a2850 rpc_handler = 1 __func__ = "mod_child" #8 0x0000560b4d8349f7 in init_mod_child (m=0x7f2da3cc0370, rank=0) at core/sr_module.c:827 __func__ = "init_mod_child" #9 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc07a0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #10 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc0ad0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #11 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc12b0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" --Type <RET> for more, q to quit, c to continue without paging-- #12 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc1770, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #13 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc1a40, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #14 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc1ed0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #15 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc2710, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #16 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc2a20, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #17 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc2d20, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #18 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc3730, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #19 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc39c0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #20 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc3c10, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #21 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc3f40, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #22 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc47c0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #23 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc4a90, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #24 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc4e30, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #25 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc5370, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #26 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc5980, rank=0) at core/sr_module.c:823 --Type <RET> for more, q to quit, c to continue without paging-- __func__ = "init_mod_child" #27 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc7850, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #28 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc7ec0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #29 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc81d0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #30 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc8550, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #31 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc87a0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #32 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc9270, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #33 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cc99f0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #34 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cca070, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #35 0x0000560b4d834612 in init_mod_child (m=0x7f2da3ccfb30, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #36 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd0260, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #37 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd05d0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #38 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd0970, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #39 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd0bc0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #40 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd1280, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" --Type <RET> for more, q to quit, c to continue without paging-- #41 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd1580, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #42 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd1960, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #43 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd24c0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #44 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd29f0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #45 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd2d00, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #46 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd3330, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #47 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd35c0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #48 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd38f0, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #49 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd4340, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #50 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd4990, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #51 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd4d50, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #52 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd5d70, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #53 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd6010, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #54 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd6230, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #55 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd64f0, rank=0) at core/sr_module.c:823 --Type <RET> for more, q to quit, c to continue without paging-- __func__ = "init_mod_child" #56 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd6a90, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #57 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd6d90, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #58 0x0000560b4d834612 in init_mod_child (m=0x7f2da3cd7300, rank=0) at core/sr_module.c:823 __func__ = "init_mod_child" #59 0x0000560b4d835322 in init_child (rank=0) at core/sr_module.c:872 ret = 32557 type = 0x560b4db1a8ab "PROC_MAIN" __func__ = "init_child" #60 0x0000560b4d6dfd7c in main_loop () at main.c:1767 i = 8 pid = 14131 si = 0x0 si_desc = "udp receiver child=7 sock=127.0.0.1:5070\000\060\060\062\000\000\000\000\003\000\000\000)\000\000\000\000\223\354\277LǶ\a\000\000\000\000\000\000\000\000\210p\256M\vV\000\000\000\000\000\000\000\000\000\000\260\f\225\244-\177\000\000\003\263\263M\vV\000\000\000\000\000\b\000\000\000\000 \002U\275\376\177\000\000\201\210\231M\vV\000" nrprocs = 8 woneinit = 1 __func__ = "main_loop" #61 0x0000560b4d6ea1fa in main (argc=17, argv=0x7ffebd550768) at main.c:2878 cfg_stream = 0x560b4de16260 c = -1 r = 0 tmp = 0x7ffebd551f2d "" tmp_len = 32766 port = -1530935202 --Type <RET> for more, q to quit, c to continue without paging-- proto = 32557 ahost = 0x0 aport = 0 options = 0x560b4dae9a20 ":f:cm:M:dVIhEeb:l:L:n:vKrRDTN:W:w:t:u:g:P:G:SQ:O:a:A:x:X:Y:" ret = -1 seed = 3854247729 rfd = 4 debug_save = 0 debug_flag = 0 dont_fork_cnt = 0 n_lst = 0x7f2da4be1f10 p = 0x0 st = {st_dev = 20, st_ino = 21827, st_nlink = 2, st_mode = 16832, st_uid = 110, st_gid = 115, __pad0 = 0, st_rdev = 0, st_size = 40, st_blksize = 4096, st_blocks = 0, st_atim = {tv_sec = 1605600824, tv_nsec = 239389389}, st_mtim = { tv_sec = 1612186501, tv_nsec = 682961986}, st_ctim = {tv_sec = 1612186523, tv_nsec = 411094638}, __glibc_reserved = {0, 0, 0}} tbuf = "\001\000\000\000\000\000\000\000\b\000\000\000\000\000\000\000\060\307\301\244-\177\000\000\000\000\000\000\000\000\000\000\240\241U\275\376\177\000\000\364ʿ\244-\177\000\000\b\000\000\000\000\000\000\000\230\242U\275\376\177\000\000\060\307\301\244-\177\000\000\b\005U\275\376\177\000\000\004\005U\275\376\177", '\000' <repeats 18 times>, "\230\242U\275\376\177\000\000\250\241U\275\376\177\000\000'ޝ\244-\177\000\000&\260be\000\000\000\000p\006U\275\376\177\000\000\300\212\225\001\000\000\000\000\320\005U\275\376\177\000\000\300\005U\275\376\177\000\000\b\005U\275\376\177\000\000X\307\301\244-\177\000\000\001", '\000' <repeats 31 times>... option_index = 0 long_options = {{name = 0x560b4daeba77 "help", has_arg = 0, flag = 0x0, val = 104}, { name = 0x560b4dae74e3 "version", has_arg = 0, flag = 0x0, val = 118}, { name = 0x560b4daeba7c "alias", has_arg = 1, flag = 0x0, val = 1024}, { name = 0x560b4daeba82 "subst", has_arg = 1, flag = 0x0, val = 1025}, { --Type <RET> for more, q to quit, c to continue without paging-- name = 0x560b4daeba88 "substdef", has_arg = 1, flag = 0x0, val = 1026}, { name = 0x560b4daeba91 "substdefs", has_arg = 1, flag = 0x0, val = 1027}, { name = 0x560b4daeba9b "server-id", has_arg = 1, flag = 0x0, val = 1028}, { name = 0x560b4daebaa5 "loadmodule", has_arg = 1, flag = 0x0, val = 1029}, { name = 0x560b4daebab0 "modparam", has_arg = 1, flag = 0x0, val = 1030}, { name = 0x560b4daebab9 "log-engine", has_arg = 1, flag = 0x0, val = 1031}, { name = 0x560b4daebac4 "debug", has_arg = 1, flag = 0x0, val = 1032}, { name = 0x560b4daebaca "cfg-print", has_arg = 0, flag = 0x0, val = 1033}, { name = 0x0, has_arg = 0, flag = 0x0, val = 0}} __func__ = "main" -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2618

4 years

rtpengine_allow_op usage doubt

by David Escartin

Dear all since version 4.4 we are using this parameter to 1 to allow that ongoing calls process their messages through a particular rtpengine when disabling it manually from database. But we see that enabling it also makes all the messages select the rtpengine and attempt to send its own op command. This is causing an impact in cases where the rtpengine crashes (luckily not so often). We have been doing some tests, and with this change diff --git a/src/modules/rtpengine/rtpengine.c > b/src/modules/rtpengine/rtpengine.c > index 20df725d2e..2f6130c62a 100644 > --- a/src/modules/rtpengine/rtpengine.c > +++ b/src/modules/rtpengine/rtpengine.c > @@ -3138,11 +3138,12 @@ select_rtpp_node(str callid, str viabranch, int > do_test, struct rtpp_node **quer > if (node->rn_recheck_ticks == RTPENGINE_MAX_RECHECK_TICKS) > { > LM_DBG("node=%.*s for calllen=%d callid=%.*s is > disabled(permanent) (probably still UP)! Return it\n", > node->rn_url.len, node->rn_url.s, > callid.len, callid.len, callid.s); > + return node; > } else { > LM_DBG("node=%.*s for calllen=%d callid=%.*s is > disabled, either broke or timeout disabled! Return it\n", > node->rn_url.len, node->rn_url.s, > callid.len, callid.len, callid.s); > } > - return node; > + /*return node;*/ > } > > return NULL; it would make to only use allow_op for manually disabled rtpengine nodes, and would make to not select the node and not try to send the rtpp command, so we would not have almost any impact in kamailio like timeouts and congestion, expect having messages not doing rtpengine in a call where others did. Do you think this change could make sense? Is there any reason for being like it is now? thanks a lot and regards david -- [image: Logo] David Escartín Almudévar VoIP/Switch Engineer descartin(a)sonoc.io *SONOC* C/ Josefa Amar y Borbón, 10, 4ª · 50001 Zaragoza, España Tlf: +34 917019888 · www.sonoc.io

4 years

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2021