sr-dev March 2021

sr-dev@lists.kamailio.org

28 participants
490 discussions

git:5.3:57529832: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.3 Commit: 575298326cc2de40123262497dcc9baece74715a URL: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T15:01:37+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/htable/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/textops/README --- Diff: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba… Patch: https://github.com/kamailio/kamailio/commit/575298326cc2de40123262497dcc9ba…

1 0

git: new commits in branch 5.3
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

- URL: https://github.com/kamailio/kamailio/commit/9758c88a12cf08edf2f18ae71e13952… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:50:35+02:00 core: kemi - KSR.is_method_in() uses E/e to match PRACK (cherry picked from commit b04111b583b454b12ea0c6a265a14858c195b213) (cherry picked from commit ff5283b156f6aa934bd5f621537427d9f2b31b1d) - URL: https://github.com/kamailio/kamailio/commit/b3623ff5cf1eed58b0af9f0ed85b615… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:51:01+02:00 core: info message made dbg when adding a subst expression (cherry picked from commit 80b3d5d036da493316a93594c770df1ef8218e5e) (cherry picked from commit 0b98ddb1ea04603851ce581a69111581a1d30a67) - URL: https://github.com/kamailio/kamailio/commit/0d2edc1871aa8bf163e50612ded2668… Author: Dennis <dennis_y(a)mail.ru> Date: 2021-03-29T10:51:20+02:00 rtpengine: fixing wrong parsing the pair of IPv6 addr:port (#2592) - fixing wrong parsing the pair of IPv6 addr:port in rtpengine module, when loading node information from database. (cherry picked from commit 13d786e33d6f04a718af40ba345cf0827f752c2f) (cherry picked from commit f64d41efc8bf08daa8f4a36cb81d4620bea2b367) - URL: https://github.com/kamailio/kamailio/commit/14fd3f6432e1385be78022c21f0f666… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-03-29T10:51:48+02:00 core: work around interface enum buffer overrun When a system has too many interfaces and too many addresses, 8 kilobytes isn't enough to fit all of the netlink responses. As the result, kamailio gets stuck in a loop where it tries to do a 0-length recv. Increase the buffer to 32K. It's a miniscule amount for modern times anyway. Also, add diagnostics to make further troubleshooting easier. Proper fix would be to switch to libnl here, which would make a good weekend project. (cherry picked from commit d2fd204b0ae35512a04702e480bb0d16878e98be) (cherry picked from commit 252b0dd2d778c15ac6e96c7c415296619df3dc3e) - URL: https://github.com/kamailio/kamailio/commit/82476273898615f278ee209c65ad2be… Author: Paul Komkoff <i(a)stingr.net> Date: 2021-03-29T10:52:00+02:00 core: fix unused argument in socket_info.c:get_flags get_flags has an argument - family - which is supposed to be used in netlink message, otherwise why would we need it? (cherry picked from commit 42f7702430c312b2c9caea8f617af4e3719ef12f) (cherry picked from commit 23000a3ab3d88419d4f0ac797aae201a22f0e1fb) - URL: https://github.com/kamailio/kamailio/commit/0761382626bb4c8882c7fa5226e6380… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:52:39+02:00 kamctl: option for rpc command to replace tokens in parameters - supported now: replace '=CRLF=' with '\r\n' - fix 'kamctl ping' command by replacing '=CRLF=' with '\r\n' in multi-headers parameter (cherry picked from commit 1c66f6a1a5d04c33f1912609a36729b06b6eebd7) (cherry picked from commit 9b5eade1faa8deeb3fcc8f9cb010f803c17ee309) - URL: https://github.com/kamailio/kamailio/commit/577f8b9b8bb3920be739f940d0a1c8e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:52:52+02:00 kamctl: use tm.t_uac_wait for ping command (cherry picked from commit 20d075a17189961baf63ac000e4417d7f04d8a08) (cherry picked from commit 6769d44cfab686824a6b077bc8cbb4a347fd3356) - URL: https://github.com/kamailio/kamailio/commit/aee753d522088c09620e73872d5b18a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:53:30+02:00 kamctl: use param evaluation mode for cisco restart command (cherry picked from commit 359050f9be40002aec1d3894dc43a2a8762ce8cc) (cherry picked from commit b8a7d2bfd1118d556c9e46dcab97fbcb45fa6187) - URL: https://github.com/kamailio/kamailio/commit/ac05b82e8036b14423652b3bee2b347… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:55:23+02:00 kamctl: added srv debug subcommand - control server debug level via rpc (cherry picked from commit 6b5aa70f09e294338a65a0bf2fcae8b92fdc6fae) (cherry picked from commit 3027f8b9daed5ca4f36d0779cd6f79e596bf42e1) - URL: https://github.com/kamailio/kamailio/commit/5d34b8e4cc025c8b1bceee9fa066b9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:55:58+02:00 app_python3: handle deprecated PyEval_InitThreads() - https://docs.python.org/3/c-api/init.html#c.PyEval_InitThreads - GH #2626 (cherry picked from commit ca37f9247ecb6754fbdbd210fc59158bf0f32def) (cherry picked from commit f9f33d37f80003836cf87338a4dd96b1b4614c22) - URL: https://github.com/kamailio/kamailio/commit/5030d4f7e066222e88813cf89ed387e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:57:08+02:00 tls: fixed small typo in log message (cherry picked from commit 3c1a454a1ac4fe8e668f709d3e278bbce59c51d3) (cherry picked from commit a36805a26aa84e865ba18260d94587be44688883) - URL: https://github.com/kamailio/kamailio/commit/7898de48fe58b3a17e846ba7b8e4af6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:57:44+02:00 core: cfg.lex - do not destroy action if pre-fixup fails - params might be in inconsistent state, shutdown is triggered which cleans the pkg anyhow - GH #2630 (cherry picked from commit dddd530ed9fa7b6ca8b31ff299105a53c39c1a5e) (cherry picked from commit 38dd7fd703f043c51756df936abc56103c891545) - URL: https://github.com/kamailio/kamailio/commit/b2b0979ab435c82ea2dc9ba6e2552e3… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:58:32+02:00 htable: docs - not about use of event_route[htable:mod-init] (cherry picked from commit e0dcb1617bedf13cc3fc76cf7f3b5cd516806bc8) (cherry picked from commit e0461d1c4026dd2953e4352bea0586419980180b) - URL: https://github.com/kamailio/kamailio/commit/17af137c8ce2112387b6e356bbc4797… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:59:04+02:00 pv: proper transfomation name in the log message (cherry picked from commit b4d1def5d8a5ffaddbd87708d8dc99f0f5f8853c) (cherry picked from commit e8595172d317b03a335bfd7c29fdf09d2e6da8b5) - URL: https://github.com/kamailio/kamailio/commit/f78d112e7c7e03e0c9121b9f34471c4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:59:52+02:00 rr: catch uri without host part when matching local addresses - can happen for tel or urn uri (cherry picked from commit 81cd9c5d6934392cafd4b73541a19dbfa4b553f9) (cherry picked from commit 908acb8f0995d10b1ed9334fc7b81166b14ab8cc) - URL: https://github.com/kamailio/kamailio/commit/55689451b6902f6bcd61e3eaf5221d5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:03+02:00 core: early detect of empty host for check_self() (cherry picked from commit 6863cb8b0253c641146633bd063575a53bc6a466) (cherry picked from commit 5b6a77222eca4e927480ed7b18e7f233e3fdf822) - URL: https://github.com/kamailio/kamailio/commit/856c5632011480b1281bb5f6ce8ebd6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:13+02:00 jsonrpcs: use json null value for c null char* or str* (cherry picked from commit c48e409b741821fa470788b3bca0ead32e4d6efc) (cherry picked from commit 3632d39b557d2b926ccfce4fd83b4c16568e6ee1) - URL: https://github.com/kamailio/kamailio/commit/77a8514ee2c459579b706078237d134… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:00:28+02:00 ipops: use local ip struct for internal resolving - static structure from core can be overwritten on subsequential use - GH #2645 (cherry picked from commit 2ce244825bf7bc38f145699209ef7125ae5480d0) (cherry picked from commit 47b45b60a037808a675f7d52dd5b2ee80bfe0868) - URL: https://github.com/kamailio/kamailio/commit/7c9f6aeb7f7bbaad68a14252f084b33… Author: Piotr Gregor <piotr(a)signalwire.com> Date: 2021-03-29T11:00:45+02:00 kamdbctl: typo in log message - core tables successfully installed (cherry picked from commit 571fe52f4ad0cf5ceef98fb2d77c2711f3692c28) (cherry picked from commit 68ec1e125e5069160696c8a634cac43e14d35ddd) - URL: https://github.com/kamailio/kamailio/commit/fe17b6f7117105a644b5888db0ffe30… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:11:35+02:00 ims_qos: typos in comments (cherry picked from commit f9c336aa9a78169cf9c7f3fd9bfcfd22218078fb) (cherry picked from commit c9a46eb88365add327b5d6f11f121c26a6230e58) - URL: https://github.com/kamailio/kamailio/commit/bad7d0aeb170b7a93787c3f60806d55… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:38:58+02:00 ims_charging: renamed str_list_t to str_htlist_t - fix conflict added by e1dc6dd6d9b206168f6da2929560ca6a64e1b41e (cherry picked from commit 1f751775525fdcdb5a75b45fbf451e2bef3696ec) (cherry picked from commit 0df03a96e9ed07ff1683690f95598bf44b87701a) - URL: https://github.com/kamailio/kamailio/commit/0301ed59003aceb645a8f7c781596c6… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:35+02:00 ipops: proper handling of return code for ip to buf conversion - reported in GH #2695 (cherry picked from commit 1d7d78c31eeab717c7013a00650d3cb07895bac8) (cherry picked from commit 8bd9404ff172671338a91a16aa04cbf8e22db501) - URL: https://github.com/kamailio/kamailio/commit/068f5d10a97e5aa79a14ac74e9b6d60… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:47+02:00 topos: handle 100 response completely - it may be needed by other modules to be processed with all via stack (cherry picked from commit 80e812caf83a131c5f830b7d23de754136fd54f7) (cherry picked from commit 8ac768c9da3102db87a420b5a5bea8a960183698) - URL: https://github.com/kamailio/kamailio/commit/fbf0e1eeb84f1bc3a66cc3f0f68d10f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T11:39:59+02:00 topos: one more update to enable processing ofr 100 (cherry picked from commit 620194165e0c6c27dfe9dbe382dc2e7b58be13b5) (cherry picked from commit a7442d19734a40c6b2f9df2d427216bf5631d3a9) - URL: https://github.com/kamailio/kamailio/commit/3458fe7b341f312079948f86a1f01e2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T12:18:08+02:00 xmlrpc: use <nil/> for null string values - XML-RPC extension listed at https://en.wikipedia.org/wiki/XML-RPC#Data_types (cherry picked from commit 17b9a6add82781f71b4d84da7c804e0e72c8b026) (cherry picked from commit e8c38b14f2cecaaf41468e52bc23e5b15aa5cf81) - URL: https://github.com/kamailio/kamailio/commit/3d4eb57841a07deb09e01afc214db9a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T12:18:18+02:00 ctl: handle null char* and str* values everywhere - not all cases were covered (cherry picked from commit fa0d2f05ad5124f6166a0384265a827187c6c83f) (cherry picked from commit 25c26de179f3e5081afb2f1ff063bc535a7cc06b) - URL: https://github.com/kamailio/kamailio/commit/34076bfe3a018a48addbfc5e4b017ac… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:54:12+02:00 xmlrpc: fixed error assigning to str variable added by previous commit (cherry picked from commit 4c6715b5e4a0938ece2937a787c6d2ed6e81a3d8) (cherry picked from commit 2c154f3cfaba97d9a97ca924ce17e01ac3519c74) - URL: https://github.com/kamailio/kamailio/commit/18024d670a28602080e1ff32fa26658… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:54:31+02:00 textops: docs - note about search() doing posix regex matching (cherry picked from commit 0cbee55284c4f4d5fef09a3185de31d04776e569) (cherry picked from commit 5a1c7faa6b72feaa71da383e5b19e6442a50b27d) - URL: https://github.com/kamailio/kamailio/commit/0f10d2dee358ddf3dd4db9d1da6bff2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:01+02:00 usrloc: adjusted rpc reply text when the location domain table is not found (cherry picked from commit d3a36ed6757eeda42dc32608a63b857ee9a67bb9) (cherry picked from commit a0a5b201041616d1df7f497eb4db7eb49b080f96) - URL: https://github.com/kamailio/kamailio/commit/2710b7825ce4b74c7448575693c711c… Author: easyrider14 <stephane.houssin(a)hotmail.fr> Date: 2021-03-29T13:55:25+02:00 cplc: permanent contact not skipped by lookup anymore - a permanently registered contact has an "expires" value of 0 in usrloc when processing lookup, cplc module checks that contacts are not expired by checking that the "expires" value of the contact is not lower than current time as a consequence, permanently registered contact are alsways skipped and never targeted (cherry picked from commit 525ee139abcb45f71bda42b417b5f8e75c12a622) (cherry picked from commit 631232a502de1e6ec60a72b4828ddfcaff57e805) - URL: https://github.com/kamailio/kamailio/commit/d37e5da02d1de9b1c39a890a4c4536d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:38+02:00 tm: log message if starting cancel retransmission fails (cherry picked from commit afe84defa4ab391064c266e15f557415c5249f7c) (cherry picked from commit 5ae6e5222a65030d8e2fd313ca1da8c4dad12830) - URL: https://github.com/kamailio/kamailio/commit/d6a9148faff05125d06a3c7e6650ed7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:55:53+02:00 registrar: documented lookup_to_dset() cfg function [skip ci] - function available for long time, but somehow was not documented - GH #2623 (cherry picked from commit 56cdf70ea008b5401bdd7d1824f15788f85fc6fa) (cherry picked from commit c6a07c6891fd14aa0d46d5b0d064bc45d41b1a88) - URL: https://github.com/kamailio/kamailio/commit/d011770220830454219518da7f586ff… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2021-03-29T13:56:16+02:00 rtpengine: remove square brackets from IPv6 address for getaddrinfo function - After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:nnnn, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN. (cherry picked from commit 491d1261e04e09f13990d5062c21faca7eb32b37) (cherry picked from commit 3141310b5cd6283d1f7b1ebed3d7471fb0d03138) - URL: https://github.com/kamailio/kamailio/commit/1219a949663dd1e18499ec135e06fe0… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T13:56:26+02:00 nathelper: small spelling fixes (cherry picked from commit 46dee155ee10a2f11ecfd41b103f92752042c5ec) (cherry picked from commit 695439f128ccae4306730735eac7a9e8dd286eb9) - URL: https://github.com/kamailio/kamailio/commit/081407592b57b3704b4183ae6c2466e… Author: Miteshkumar Thakkar <mitesht(a)users.noreply.github.com> Date: 2021-03-29T13:56:37+02:00 app_lua: Fixed error 'too many parameters' - Calling function KSR.secsipid.secsipid_add_identity() has six parameters, is giving error 'too many parameters' (cherry picked from commit 5460949614c92c7dbfb7f63274540500f2a69d5b) (cherry picked from commit d0f028b4f48fc6e55612ed43bc9160d2bf67fb10) - URL: https://github.com/kamailio/kamailio/commit/66a35ce02a1b68672dbd965e632877b… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2021-03-29T13:56:59+02:00 rtpengine: fix typo in docs (cherry picked from commit 5cc888f0e9e305734621c0db1f63a47f2f0c381a) (cherry picked from commit ad6559f48735a9b369caad851bf87392a12dee9a) - URL: https://github.com/kamailio/kamailio/commit/ad4f9c76fc607bbd195eb612f1a4707… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:57:43+02:00 acc_diameter: init variables for safer cleanup (cherry picked from commit 5c48d437935e971482c9bbf41f067d120911e2c8) (cherry picked from commit 652c3fb55f94efee0c9d5b16f3f492ad8e771984) - URL: https://github.com/kamailio/kamailio/commit/e3deee64670b9d4280a5fe53d449240… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T13:58:10+02:00 pv: use unsigned for safer non-ascii bit shifting for hexa - related to GH #2690 (cherry picked from commit c331e6dddb238abe5fc832ce3d3934fbe56ad2f7) (cherry picked from commit 7faaf17a532de7c2f4f781f3a33bfd8306458ca0)

1 0

git:master:08ccff91: modules: readme files regenerated - rtpengine ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 08ccff9107f4c1ff1f0e863967be688b6c821bb4 URL: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T12:01:13+02:00 modules: readme files regenerated - rtpengine ... [skip ci] --- Modified: src/modules/rtpengine/README --- Diff: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… Patch: https://github.com/kamailio/kamailio/commit/08ccff9107f4c1ff1f0e863967be688… --- diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README index 27c2337426..24d02d1c5d 100644 --- a/src/modules/rtpengine/README +++ b/src/modules/rtpengine/README @@ -421,7 +421,9 @@ Chapter 1. Admin Guide module parameter definition for syntax description. The balancing inside a set is done automatically by the module based on - the weight of each RTPEngine from the set. + the weight of each RTPEngine from the set. The default weight is 1, if + another RTPEngine should be used twice as often as the first one, one + would specify the weight 2 for this server, for example. The selection of the set is done from script prior using rtpengine_delete(), rtpengine_offer() or rtpengine_answer() functions -

1 0

git:master:ab68c7a6: rtpengine: improvement in docs related to sock weights
by Henning Westerholt 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: ab68c7a6190bb89775cb92428bc2c5ac4798f560 URL: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… Author: Henning Westerholt <hw(a)skalatan.de> Committer: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T09:51:59Z rtpengine: improvement in docs related to sock weights --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… Patch: https://github.com/kamailio/kamailio/commit/ab68c7a6190bb89775cb92428bc2c5a… --- diff --git a/src/modules/rtpengine/doc/rtpengine_admin.xml b/src/modules/rtpengine/doc/rtpengine_admin.xml index d7f102ece5..ef7d5a4fd7 100644 --- a/src/modules/rtpengine/doc/rtpengine_admin.xml +++ b/src/modules/rtpengine/doc/rtpengine_admin.xml @@ -46,7 +46,9 @@ </para> <para> The balancing inside a set is done automatically by the module based on - the weight of each RTPEngine from the set. + the weight of each RTPEngine from the set. The default weight is 1, if + another RTPEngine should be used twice as often as the first one, one + would specify the weight 2 for this server, for example. </para> <para> The selection of the set is done from script prior using

1 0

git:5.4:fa2e5178: modules: readme files regenerated - modules ... [skip ci]
by Kamailio Dev 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.4 Commit: fa2e51786dcb3daaa389055c6dc2b17c2a2d7c7b URL: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2021-03-29T10:46:39+02:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/pv/README Modified: src/modules/registrar/README Modified: src/modules/rtpengine/README Modified: src/modules/textops/README Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17… Patch: https://github.com/kamailio/kamailio/commit/fa2e51786dcb3daaa389055c6dc2b17…

1 0

git:5.4:b864dcf0: kemix: exported function get_rcvadvip() and get_rcvadvport()
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.4 Commit: b864dcf0eaf984c83b4e7b5c4d1c70f7a3b32ac5 URL: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:45:03+02:00 kemix: exported function get_rcvadvip() and get_rcvadvport() - return advertised address and port of the receiving socket - forward porting from 5.3 (cherry picked from commit 070a9c042a1caf19162d3d97b26f8d7548747cbb) (cherry picked from commit a76f06eb010765216450bd78bcc1040aa9902280) --- Modified: src/modules/kemix/kemix_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… Patch: https://github.com/kamailio/kamailio/commit/b864dcf0eaf984c83b4e7b5c4d1c70f… --- diff --git a/src/modules/kemix/kemix_mod.c b/src/modules/kemix/kemix_mod.c index 4bd6f839d1..66cdcf1bc1 100644 --- a/src/modules/kemix/kemix_mod.c +++ b/src/modules/kemix/kemix_mod.c @@ -520,6 +520,38 @@ static sr_kemi_xval_t* ki_kx_get_rcvport(sip_msg_t *msg) return &_sr_kemi_kx_xval; } +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rcvadvip(sip_msg_t *msg) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + if(msg->rcv.bind_address!=NULL + && msg->rcv.bind_address->useinfo.address_str.len > 0) { + _sr_kemi_kx_xval.vtype = SR_KEMIP_STR; + _sr_kemi_kx_xval.v.s = msg->rcv.bind_address->useinfo.address_str; + return &_sr_kemi_kx_xval; + } + + return ki_kx_get_rcvip(msg); +} + +/** + * + */ +static sr_kemi_xval_t* ki_kx_get_rcvadvport(sip_msg_t *msg) +{ + memset(&_sr_kemi_kx_xval, 0, sizeof(sr_kemi_xval_t)); + if(msg->rcv.bind_address!=NULL + && msg->rcv.bind_address->useinfo.port_no_str.len > 0) { + _sr_kemi_kx_xval.vtype = SR_KEMIP_INT; + _sr_kemi_kx_xval.v.n = (int)msg->rcv.bind_address->useinfo.port_no; + return &_sr_kemi_kx_xval; + } + + return ki_kx_get_rcvport(msg); +} + /** * */ @@ -1085,6 +1117,16 @@ static sr_kemi_t sr_kemi_kx_exports[] = { { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } }, + { str_init("kx"), str_init("get_rcvadvip"), + SR_KEMIP_XVAL, ki_kx_get_rcvadvip, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, + { str_init("kx"), str_init("get_rcvadvport"), + SR_KEMIP_XVAL, ki_kx_get_rcvadvport, + { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE, + SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE } + }, { str_init("kx"), str_init("get_proto"), SR_KEMIP_XVAL, ki_kx_get_proto, { SR_KEMIP_NONE, SR_KEMIP_NONE, SR_KEMIP_NONE,

1 0

git: new commits in branch 5.4
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

- URL: https://github.com/kamailio/kamailio/commit/8ac768c9da3102db87a420b5a5bea8a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:04+02:00 topos: handle 100 response completely - it may be needed by other modules to be processed with all via stack (cherry picked from commit 80e812caf83a131c5f830b7d23de754136fd54f7) - URL: https://github.com/kamailio/kamailio/commit/a7442d19734a40c6b2f9df2d427216b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:17+02:00 topos: one more update to enable processing ofr 100 (cherry picked from commit 620194165e0c6c27dfe9dbe382dc2e7b58be13b5) - URL: https://github.com/kamailio/kamailio/commit/e8c38b14f2cecaaf41468e52bc23e5b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:45+02:00 xmlrpc: use <nil/> for null string values - XML-RPC extension listed at https://en.wikipedia.org/wiki/XML-RPC#Data_types (cherry picked from commit 17b9a6add82781f71b4d84da7c804e0e72c8b026) - URL: https://github.com/kamailio/kamailio/commit/25c26de179f3e5081afb2f1ff063bc5… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:15:56+02:00 ctl: handle null char* and str* values everywhere - not all cases were covered (cherry picked from commit fa0d2f05ad5124f6166a0384265a827187c6c83f) - URL: https://github.com/kamailio/kamailio/commit/2c154f3cfaba97d9a97ca924ce17e01… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:16:10+02:00 xmlrpc: fixed error assigning to str variable added by previous commit (cherry picked from commit 4c6715b5e4a0938ece2937a787c6d2ed6e81a3d8) - URL: https://github.com/kamailio/kamailio/commit/beb59d4bf335c927d1224e02a67e81d… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:25+02:00 ims_diameter_server: check response is not null before json conversion (cherry picked from commit 6968f1df9e9d3d66810df910d290f3d9368255fe) - URL: https://github.com/kamailio/kamailio/commit/9fb04eb982ef4903801970981faff9b… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:42+02:00 ims_diameter_server: fix initialization of s_message (cherry picked from commit faf1edabf732af5a24ad0399098ad11e27b3a1ab) - URL: https://github.com/kamailio/kamailio/commit/0d4e6c8b7450823dfb8caa6baaa6ce0… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:17:58+02:00 ims_diameter_server: drop cdp session to avoid deadlock (cherry picked from commit 84c342277f2a73196cb377476f2b80e6b4085e7b) - URL: https://github.com/kamailio/kamailio/commit/532eedac63d0bd2b0c4c6b4f9557ac2… Author: Riccardo Villa <riccardo.villa(a)netaxis.be> Date: 2021-03-29T10:18:17+02:00 ims_diameter_server: fix check for addAVPsfromJSON return code (cherry picked from commit 88d38bd306f595585af6e972ac529b40d7a93b58) - URL: https://github.com/kamailio/kamailio/commit/5a1c7faa6b72feaa71da383e5b19e64… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:18:40+02:00 textops: docs - note about search() doing posix regex matching (cherry picked from commit 0cbee55284c4f4d5fef09a3185de31d04776e569) - URL: https://github.com/kamailio/kamailio/commit/50e9db0cd53381cec5e522777556adb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:02+02:00 pv: handle missing fields (otcid, instance) for $banch() and $sbranch() (cherry picked from commit 0c4becd70428ef15be76fb0aa53932e5803c6bd0) - URL: https://github.com/kamailio/kamailio/commit/a0a5b201041616d1df7f497eb4db7eb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:17+02:00 usrloc: adjusted rpc reply text when the location domain table is not found (cherry picked from commit d3a36ed6757eeda42dc32608a63b857ee9a67bb9) - URL: https://github.com/kamailio/kamailio/commit/8248442af0d32ee4045590dbb8b083b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:21:36+02:00 rtp_media_server: Makefile - removed unnecessary DEFS+=-DKAMAILIO_MOD_INTERFACE (cherry picked from commit 7532f864cb9698aff95b9023bc9ff6959a41fd3f) - URL: https://github.com/kamailio/kamailio/commit/631232a502de1e6ec60a72b4828ddfc… Author: easyrider14 <stephane.houssin(a)hotmail.fr> Date: 2021-03-29T10:22:14+02:00 cplc: permanent contact not skipped by lookup anymore - a permanently registered contact has an "expires" value of 0 in usrloc when processing lookup, cplc module checks that contacts are not expired by checking that the "expires" value of the contact is not lower than current time as a consequence, permanently registered contact are alsways skipped and never targeted (cherry picked from commit 525ee139abcb45f71bda42b417b5f8e75c12a622) - URL: https://github.com/kamailio/kamailio/commit/5ae6e5222a65030d8e2fd313ca1da8c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:14+02:00 tm: log message if starting cancel retransmission fails (cherry picked from commit afe84defa4ab391064c266e15f557415c5249f7c) - URL: https://github.com/kamailio/kamailio/commit/9fb67b2d70dadefe667c0bfbff7e324… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:38+02:00 uac: docs - listed uac_auth_mode() function (cherry picked from commit be4e1843c54e70206688c1f2d1f5483165baef8f) - URL: https://github.com/kamailio/kamailio/commit/da5df462c81ba7e4ef700fbd19bc57c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:23:48+02:00 uac: exposed uac_auth_mode() also as uac_mode([mode]) to match docs (cherry picked from commit bb1fe2fc12cb0499c5242c220dd8065e83fe6e61) - URL: https://github.com/kamailio/kamailio/commit/c6a07c6891fd14aa0d46d5b0d064bc4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:24:02+02:00 registrar: documented lookup_to_dset() cfg function [skip ci] - function available for long time, but somehow was not documented - GH #2623 (cherry picked from commit 56cdf70ea008b5401bdd7d1824f15788f85fc6fa) - URL: https://github.com/kamailio/kamailio/commit/293e161fb8828310954ea37f522c2e0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:24:19+02:00 presence: do not init db in dmq worker for in-memory only mode - GH #2642 (cherry picked from commit 2b475553ef77f63cb444c34ad6c2df0ea237c88b) - URL: https://github.com/kamailio/kamailio/commit/5d47465d6791f6213994ae77089d156… Author: Aleksandar Yosifov <alexyosifov(a)gmail.com> Date: 2021-03-29T10:26:07+02:00 smsops: fix parsing of validity period - Validity period is present only for SUBMIT msg type and it is an optional parameter. For now supports only Relative VP format. (cherry picked from commit c4b1d0ab700ea03869114d08daa78ab6a6a56b96) - URL: https://github.com/kamailio/kamailio/commit/3141310b5cd6283d1f7b1ebed3d7471… Author: Dennis Yurasov <dennis-y(a)yandex-team.ru> Date: 2021-03-29T10:31:05+02:00 rtpengine: remove square brackets from IPv6 address for getaddrinfo function - After loading from DB rn_address is in form: [x:x:x:x:x:x:x:x]:nnnn, getaddrinfo function expect ipv6 in node argument without square brackets, otherwise, the argument is interpreted as FQDN. (cherry picked from commit 491d1261e04e09f13990d5062c21faca7eb32b37) - URL: https://github.com/kamailio/kamailio/commit/695439f128ccae4306730735eac7a9e… Author: Henning Westerholt <hw(a)skalatan.de> Date: 2021-03-29T10:31:38+02:00 nathelper: small spelling fixes (cherry picked from commit 46dee155ee10a2f11ecfd41b103f92752042c5ec) - URL: https://github.com/kamailio/kamailio/commit/d0f028b4f48fc6e55612ed43bc9160d… Author: Miteshkumar Thakkar <mitesht(a)users.noreply.github.com> Date: 2021-03-29T10:32:02+02:00 app_lua: Fixed error 'too many parameters' - Calling function KSR.secsipid.secsipid_add_identity() has six parameters, is giving error 'too many parameters' (cherry picked from commit 5460949614c92c7dbfb7f63274540500f2a69d5b) - URL: https://github.com/kamailio/kamailio/commit/d23aef79e6ecd6149b9a6db7a09dd46… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:17+02:00 core: comments updated for msg_send_buffer() (cherry picked from commit 9c2c4bafa0f0cd980b5867e7d4c0995255730f87) - URL: https://github.com/kamailio/kamailio/commit/e2c7d171bbd65e2689a3c498330c546… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:34+02:00 core: events - rename SREV_NET_DATA_SEND to SREV_NET_DATA_SENT - reflects better the purpose, being executed after the message is sent (cherry picked from commit 93df5a5241f57ffb71dad0b0df04a256b7b0b7b4) - URL: https://github.com/kamailio/kamailio/commit/d8871bfa1d0a3b2f1c01fb51e518e1e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:32:47+02:00 siptrace: renamed SREV_NET_DATA_SEND to SREV_NET_DATA_SENT (cherry picked from commit e1570a115f99c896d3703b756fe95cc28e0cb7d5) - URL: https://github.com/kamailio/kamailio/commit/0c0d833aeeaf6a4fed91300189e2c4f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:33:05+02:00 pv: docs - note about use of $shv() in kemi scripts for shvset param [skip ci] (cherry picked from commit bcc6370cdc00f25ce3d0f29e168c20ca880dcda2) - URL: https://github.com/kamailio/kamailio/commit/9a8002541773108a3a9dcb8a2f31a91… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:33:19+02:00 pv: docs - relocated shvset note outside of param definition details [skip ci] (cherry picked from commit c959a3c5f5efa1158bd53a31476f33d080793928) - URL: https://github.com/kamailio/kamailio/commit/ad6559f48735a9b369caad851bf8739… Author: Richard Fuchs <rfuchs(a)sipwise.com> Date: 2021-03-29T10:33:40+02:00 rtpengine: fix typo in docs (cherry picked from commit 5cc888f0e9e305734621c0db1f63a47f2f0c381a) - URL: https://github.com/kamailio/kamailio/commit/75caa3c348706838722898c01e324b9… Author: Ovidiu Sas <osas(a)voipembedded.com> Date: 2021-03-29T10:34:12+02:00 siptrace: properly terminate logs with '\n' (cherry picked from commit 5ac49634c18955ffedd0ad909d2199e5881905c6) - URL: https://github.com/kamailio/kamailio/commit/652c3fb55f94efee0c9d5b16f3f492a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:00+02:00 acc_diameter: init variables for safer cleanup (cherry picked from commit 5c48d437935e971482c9bbf41f067d120911e2c8) - URL: https://github.com/kamailio/kamailio/commit/d7cec6d68fc2198ae69d3c5d30dd0fb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:40+02:00 core: use unsigned for safer non-ascii bit shifting for hexa (cherry picked from commit 9efe1e0c32ae43d67240d6a97306e3cff61c3c55) - URL: https://github.com/kamailio/kamailio/commit/7faaf17a532de7c2f4f781f3a33bfd8… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T10:35:50+02:00 pv: use unsigned for safer non-ascii bit shifting for hexa - related to GH #2690 (cherry picked from commit c331e6dddb238abe5fc832ce3d3934fbe56ad2f7)

1 0

[kamailio/kamailio] Fix ip parsing in ipops (#2695)
by Nathan 29 Mar '21

29 Mar '21

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #2645 #### Description For #2645, a patch was pushed in 47b45b60a037808a675f7d52dd5b2ee80bfe0868, but this code does not correctly check the return value of `str2ip6buf` and `str2ipbuf`. As described in the comments on both methods, they return zero *for success*. This MR should be backported to 5.4 as well. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/2695 -- Commit Summary -- * Fix ip parsing in ipops -- File Changes -- M src/modules/ipops/ipops_mod.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/2695.patch https://github.com/kamailio/kamailio/pull/2695.diff -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/2695

2 3

git:5.4:8bd9404f: ipops: proper handling of return code for ip to buf conversion
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: 5.4 Commit: 8bd9404ff172671338a91a16aa04cbf8e22db501 URL: https://github.com/kamailio/kamailio/commit/8bd9404ff172671338a91a16aa04cbf… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T09:58:43+02:00 ipops: proper handling of return code for ip to buf conversion - reported in GH #2695 (cherry picked from commit 1d7d78c31eeab717c7013a00650d3cb07895bac8) --- Modified: src/modules/ipops/ipops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/8bd9404ff172671338a91a16aa04cbf… Patch: https://github.com/kamailio/kamailio/commit/8bd9404ff172671338a91a16aa04cbf… --- diff --git a/src/modules/ipops/ipops_mod.c b/src/modules/ipops/ipops_mod.c index cb7422b988..273f232fa7 100644 --- a/src/modules/ipops/ipops_mod.c +++ b/src/modules/ipops/ipops_mod.c @@ -1105,15 +1105,15 @@ static inline ip_addr_t *strtoipX(str *ips) { /* IPv6 */ if(str2ip6buf(ips, &ipb) < 0) { - return &ipb; + return NULL; } } else { /* IPv4 */ if (str2ipbuf(ips, &ipb)<0) { - return &ipb; + return NULL; } } - return NULL; + return &ipb; } static int ki_dns_sys_match_ip(sip_msg_t *msg, str *vhn, str *vip)

1 0

git:master:1d7d78c3: ipops: proper handling of return code for ip to buf conversion
by Daniel-Constantin Mierla 29 Mar '21

29 Mar '21

Module: kamailio Branch: master Commit: 1d7d78c31eeab717c7013a00650d3cb07895bac8 URL: https://github.com/kamailio/kamailio/commit/1d7d78c31eeab717c7013a00650d3cb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2021-03-29T09:56:36+02:00 ipops: proper handling of return code for ip to buf conversion - reported in GH #2695 --- Modified: src/modules/ipops/ipops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/1d7d78c31eeab717c7013a00650d3cb… Patch: https://github.com/kamailio/kamailio/commit/1d7d78c31eeab717c7013a00650d3cb… --- diff --git a/src/modules/ipops/ipops_mod.c b/src/modules/ipops/ipops_mod.c index cb7422b988..273f232fa7 100644 --- a/src/modules/ipops/ipops_mod.c +++ b/src/modules/ipops/ipops_mod.c @@ -1105,15 +1105,15 @@ static inline ip_addr_t *strtoipX(str *ips) { /* IPv6 */ if(str2ip6buf(ips, &ipb) < 0) { - return &ipb; + return NULL; } } else { /* IPv4 */ if (str2ipbuf(ips, &ipb)<0) { - return &ipb; + return NULL; } } - return NULL; + return &ipb; } static int ki_dns_sys_match_ip(sip_msg_t *msg, str *vhn, str *vip)

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
49
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2021