Hi all,
I need to modify headers and body of the ingress INVITE in the BRANCH_FAILURE_ROUTE block to reflect failure to deliver message to the first destination and include some additional information. However checking the documentation of the “sip_msg_apply_changes” (https://github.com/kamailio/kamailio/blob/master/src/core/msg_translator.c#…) I can see that it can only be executed from request and reply routes. That seems overly restrictive. Can someone shine some light on why is that and whether it’s safe to patch this part of the code to allow function execution from BRANCH_FAILURE_ROUTE as well?
Thanks in advance,
Ivan
Module: kamailio
Branch: master
Commit: ed518fd6fa4652e2a06a09e6d54ce5b19d0b9493
URL: https://github.com/kamailio/kamailio/commit/ed518fd6fa4652e2a06a09e6d54ce5b…
Author: Kamailio Dev <kamailio.dev(a)kamailio.org>
Committer: Kamailio Dev <kamailio.dev(a)kamailio.org>
Date: 2021-07-13T15:16:15+02:00
modules: readme files regenerated - rtpengine ... [skip ci]
---
Modified: src/modules/rtpengine/README
---
Diff: https://github.com/kamailio/kamailio/commit/ed518fd6fa4652e2a06a09e6d54ce5b…
Patch: https://github.com/kamailio/kamailio/commit/ed518fd6fa4652e2a06a09e6d54ce5b…
---
diff --git a/src/modules/rtpengine/README b/src/modules/rtpengine/README
index 24d02d1c5d..8a1abb2643 100644
--- a/src/modules/rtpengine/README
+++ b/src/modules/rtpengine/README
@@ -648,9 +648,11 @@ modparam("rtpengine", "rtpengine_tout_ms", 2000)
4.5. rtpengine_allow_op (integer)
Enable this setting to allow finishing the current sessions while
- denying new sessions for the manually deactivated nodes via kamctl
- command i.e. "disabled(permanent)" nodes. Probably the manually
- deactivated machine is still running(did not crash).
+ denying new sessions for deactivated nodes.
+
+ Nodes can be manually deactivated via kamctl command i.e.
+ "disabled(permanent)" nodes. Probably the manually deactivated machine
+ is still running(did not crash).
This is useful when deactivating a node for maintenance and reject new
sessions but allow current ones to finish.
@@ -664,6 +666,12 @@ modparam("rtpengine", "rtpengine_tout_ms", 2000)
Default value is “0” to keep the current behaviour.
+ If value set to “1” it will send commands to all disabled nodes for the
+ existing call.
+
+ If value set to “2” it will send commands only to manually disabled
+ nodes. (Not when timeout is disabled or node broken)
+
Example 1.5. Set rtpengine_allow_op parameter
...
modparam("rtpengine", "rtpengine_allow_op", 1)
When using rtpengine_allow_op param, return node for ongoing calls only if rtpengine is manually disabled.
When a rtpengine instance is disabled, rtpengine_allow_op will allow the indialog requests to be processed through that rtpengine.
But it's not desirable to return the node when the rtpengine has unexpectedly crashed or has any undesired issues, because the rtp commands attempted cause congestion problem in the kamailio.
So with this patch we only return the node if the rtpengine has been manually disabled and it's still supposed to be working.
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/2800
-- Commit Summary --
* rtpengine: On rtpengine_allow_op, return node only if rtpengine is manually disabled
-- File Changes --
M src/modules/rtpengine/rtpengine.c (3)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/2800.patchhttps://github.com/kamailio/kamailio/pull/2800.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/2800