sr-dev January 2022

sr-dev@lists.kamailio.org

13 participants
261 discussions

git:master:682f9984: dialog: init variable to fix warning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 682f9984fc4942d5f786f0ca9d798630d618f8da URL: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T09:02:35+01:00 dialog: init variable to fix warning --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… Patch: https://github.com/kamailio/kamailio/commit/682f9984fc4942d5f786f0ca9d79863… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index 38dc105fb8..36d43f90f3 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -106,7 +106,7 @@ int dlg_dmq_handle_msg(struct sip_msg* msg, peer_reponse_t* resp, dmq_node_t* no srjson_t *it = NULL; dlg_dmq_action_t action = DLG_DMQ_NONE; - dlg_iuid_t iuid; + dlg_iuid_t iuid = {0}; str profiles = {0, 0}, callid = {0, 0}, tag1 = {0,0}, tag2 = {0,0}, contact1 = {0,0}, contact2 = {0,0}, k={0,0}, v={0,0}; str cseq1 = {0,0}, cseq2 = {0,0}, route_set1 = {0,0}, route_set2 = {0,0},

2 years, 10 months

git:master:102b7c62: db_text: init variable to fix warning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 102b7c62ae9877151ce542b8b5747051fb954acb URL: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T09:02:11+01:00 db_text: init variable to fix warning --- Modified: src/modules/db_text/dbt_file.c --- Diff: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… Patch: https://github.com/kamailio/kamailio/commit/102b7c62ae9877151ce542b8b574705… --- diff --git a/src/modules/db_text/dbt_file.c b/src/modules/db_text/dbt_file.c index 8b88ed8074..6480210ebc 100644 --- a/src/modules/db_text/dbt_file.c +++ b/src/modules/db_text/dbt_file.c @@ -87,7 +87,7 @@ dbt_table_p dbt_load_file(const str *tbn, const str *dbn) char path[512]; char *buf; int c, crow, ccol, bp, sign, max_auto; - dbt_val_t dtval; + dbt_val_t dtval = {0}; dbt_table_p dtp = NULL; dbt_column_p colp, colp0 = NULL; dbt_row_p rowp, rowp0 = NULL;

2 years, 10 months

git:master:b7815d04: avpops: init variable to fix warning

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: b7815d04ced35d5b5ccbcdaa39d41ef4a2cb2ad0 URL: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:41:35+01:00 avpops: init variable to fix warning --- Modified: src/modules/avpops/avpops_impl.c --- Diff: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… Patch: https://github.com/kamailio/kamailio/commit/b7815d04ced35d5b5ccbcdaa39d41ef… --- diff --git a/src/modules/avpops/avpops_impl.c b/src/modules/avpops/avpops_impl.c index 8a6e4c2b2d..28f270fe17 100644 --- a/src/modules/avpops/avpops_impl.c +++ b/src/modules/avpops/avpops_impl.c @@ -505,7 +505,7 @@ int ops_dbstore_avps (struct sip_msg* msg, struct fis_param *sp, avp_list_t avp_list; struct usr_avp *avp; unsigned short name_type; - int_str avp_name; + int_str avp_name = {0}; int_str i_s; str uuid; int keys_nr;

2 years, 10 months

git:master:55f23d09: rls: free xml doc in case of error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 55f23d09faee06a892dde13e371d144b98bae68f URL: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:30:46+01:00 rls: free xml doc in case of error --- Modified: src/modules/rls/resource_notify.c --- Diff: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… Patch: https://github.com/kamailio/kamailio/commit/55f23d09faee06a892dde13e371d144… --- diff --git a/src/modules/rls/resource_notify.c b/src/modules/rls/resource_notify.c index d42c29666b..0f31e7c877 100644 --- a/src/modules/rls/resource_notify.c +++ b/src/modules/rls/resource_notify.c @@ -183,6 +183,7 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, subs_t* dialog= NULL; int len_est = 0; int resource_added = 0; /* Flag to indicate that we have added at least one resource */ + int ok = 0; /* generate the boundary string */ boundary_string= generate_string(BOUNDARY_STRING_LEN); @@ -430,6 +431,7 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, } done: + ok = 1; if (dbmode == RLS_DB_ONLY && rls_dbf.end_transaction) { if (rls_dbf.end_transaction(rls_db) < 0) @@ -454,6 +456,11 @@ static void send_notifies(db1_res_t *result, int did_col, int resource_uri_col, LM_ERR("in abort_transaction\n"); } + if(ok==0) { + if(rlmi_doc!=NULL) { + xmlFreeDoc(rlmi_doc); + } + } return; }

2 years, 10 months

git:master:5443db4d: dispatcher: safety checks for str fields

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5443db4d632c8502dc622cc28fe2847fb0c147c1 URL: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:20:30+01:00 dispatcher: safety checks for str fields --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… Patch: https://github.com/kamailio/kamailio/commit/5443db4d632c8502dc622cc28fe2847… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 661b4a9533..26836433f1 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -1192,7 +1192,7 @@ unsigned int ds_get_hash(str *x, str *y) if(!x && !y) return 0; h = 0; - if(x) { + if(x && x->s) { p = x->s; if(x->len >= 4) { for(; p <= (x->s + x->len - 4); p += 4) { @@ -1207,7 +1207,7 @@ unsigned int ds_get_hash(str *x, str *y) } h += v ^ (v >> 3); } - if(y) { + if(y && y->s) { p = y->s; if(y->len >= 4) { for(; p <= (y->s + y->len - 4); p += 4) {

2 years, 10 months

git:master:0247c336: lcr: init buffers to try to get rid of new warnings

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 0247c336e208912324c71aea9843e688d7c5a463 URL: https://github.com/kamailio/kamailio/commit/0247c336e208912324c71aea9843e68… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:19:42+01:00 lcr: init buffers to try to get rid of new warnings --- Modified: src/modules/lcr/lcr_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0247c336e208912324c71aea9843e68… Patch: https://github.com/kamailio/kamailio/commit/0247c336e208912324c71aea9843e68… --- diff --git a/src/modules/lcr/lcr_mod.c b/src/modules/lcr/lcr_mod.c index 630593bd36..9647dde044 100644 --- a/src/modules/lcr/lcr_mod.c +++ b/src/modules/lcr/lcr_mod.c @@ -2900,6 +2900,8 @@ static int ki_next_gw(sip_msg_t *_m) struct ip_addr addr; tag_str.s = &(tag[0]); + r_uri[0] = '\0'; + dst_uri[0] = '\0'; ru_avp = search_first_avp( ruri_user_avp_type, ruri_user_avp, &ruri_user_val, 0);

2 years, 10 months

git:master:33c40170: presence: utils - use memcpy instead of strncpy for coherence

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 33c40170e73adc71e2ad66d8dbb6c776b771ce5d URL: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-11T08:19:06+01:00 presence: utils - use memcpy instead of strncpy for coherence --- Modified: src/modules/presence/utils_func.h --- Diff: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… Patch: https://github.com/kamailio/kamailio/commit/33c40170e73adc71e2ad66d8dbb6c77… --- diff --git a/src/modules/presence/utils_func.h b/src/modules/presence/utils_func.h index 27fcc07d0a..5c5d58b22a 100644 --- a/src/modules/presence/utils_func.h +++ b/src/modules/presence/utils_func.h @@ -137,7 +137,7 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) contact->len += 1; p += 1; } - strncpy(p, ip.s, ip.len); + memcpy(p, ip.s, ip.len); contact->len += ip.len; p += ip.len; if(msg->rcv.bind_address->address.af == AF_INET6) { @@ -145,7 +145,7 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) contact->len += 1; p += 1; } - if(contact->len > LCONTACT_BUF_SIZE - 21) { + if(contact->len > LCONTACT_BUF_SIZE - 22) { LM_ERR("buffer overflow\n"); goto error; } @@ -156,8 +156,9 @@ static inline int ps_fill_local_contact(struct sip_msg *msg, str *contact) } contact->len += len; p += len; - strncpy(p, proto, plen); + memcpy(p, proto, plen); contact->len += plen; + contact->s[contact->len] = '\0'; return 0; error:

2 years, 10 months

git:master:819ca1d7: ims_usrloc_scscf: removed unrelated comment with is_main

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 819ca1d7afe558d944fa88b2d453bf7ae7fcc819 URL: https://github.com/kamailio/kamailio/commit/819ca1d7afe558d944fa88b2d453bf7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-10T18:38:00+01:00 ims_usrloc_scscf: removed unrelated comment with is_main - was not even used --- Modified: src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/819ca1d7afe558d944fa88b2d453bf7… Patch: https://github.com/kamailio/kamailio/commit/819ca1d7afe558d944fa88b2d453bf7… --- diff --git a/src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c b/src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c index 0b01fdc437..bb5c394704 100644 --- a/src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c +++ b/src/modules/ims_usrloc_scscf/ims_usrloc_scscf_mod.c @@ -47,7 +47,7 @@ #include "../../core/dprint.h" #include "../../core/rpc_lookup.h" #include "../../core/timer.h" /* register_timer */ -#include "../../core/globals.h" /* is_main */ +#include "../../core/globals.h" #include "../../core/ut.h" /* str_init */ #include "dlist.h" /* register_udomain */ #include "udomain.h" /* {insert,delete,get,release}_urecord */

2 years, 10 months

git:master:9d280b58: p_usrloc: removed unrelated comment with is_main

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 9d280b589a035fa04cd4c7235671d1fdb6ae44e9 URL: https://github.com/kamailio/kamailio/commit/9d280b589a035fa04cd4c7235671d1f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-10T18:38:00+01:00 p_usrloc: removed unrelated comment with is_main - was not even used --- Modified: src/modules/p_usrloc/p_usrloc_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/9d280b589a035fa04cd4c7235671d1f… Patch: https://github.com/kamailio/kamailio/commit/9d280b589a035fa04cd4c7235671d1f… --- diff --git a/src/modules/p_usrloc/p_usrloc_mod.c b/src/modules/p_usrloc/p_usrloc_mod.c index 8804e5cd86..e6fd33d9b9 100644 --- a/src/modules/p_usrloc/p_usrloc_mod.c +++ b/src/modules/p_usrloc/p_usrloc_mod.c @@ -45,7 +45,7 @@ #include "../../core/dprint.h" #include "../../core/rpc_lookup.h" #include "../../core/timer_proc.h" -#include "../../core/globals.h" /* is_main */ +#include "../../core/globals.h" #include "../../core/ut.h" /* str_init */ #include "udomain.h" /* {insert,delete,get,release}_urecord */ #include "urecord.h" /* {insert,delete,get}_ucontact */

2 years, 10 months

git:master:5978ec11: ims_usrloc_pcscf: removed unrelated comment with is_main

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 5978ec116c3efacacf260e9f579d93c9e9bfb780 URL: https://github.com/kamailio/kamailio/commit/5978ec116c3efacacf260e9f579d93c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-01-10T18:38:00+01:00 ims_usrloc_pcscf: removed unrelated comment with is_main - was not even used --- Modified: src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/5978ec116c3efacacf260e9f579d93c… Patch: https://github.com/kamailio/kamailio/commit/5978ec116c3efacacf260e9f579d93c… --- diff --git a/src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c b/src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c index 9765526015..fe9a1f5f02 100644 --- a/src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c +++ b/src/modules/ims_usrloc_pcscf/ims_usrloc_pcscf_mod.c @@ -47,7 +47,7 @@ #include "../../core/dprint.h" #include "../../core/rpc_lookup.h" #include "../../core/timer.h" /* register_timer */ -#include "../../core/globals.h" /* is_main */ +#include "../../core/globals.h" #include "../../core/ut.h" /* str_init */ #include "dlist.h" /* register_udomain */ #include "udomain.h" /* {insert,delete,get,release}_urecord */

2 years, 10 months

← Newer
1
...
18
19
20
21
22
23
24
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2022