sr-dev January 2022

sr-dev@lists.kamailio.org

13 participants
261 discussions

Re: [sr-dev] [kamailio/kamailio] mtree: Add RPC response on successful reload, re-organise function rpc_mtree_reload (559b52b)

by Daniel-Constantin Mierla

The commit seems to remove the existing error log messages and they are useful with the systems that monitor syslog and trigger alerts. While the commit adds text to rpc response, that is visible on client app and it might not be easily caught by server devops team. The error logs should be reintroduced. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/commit/559b52b194f813c0c8584b3becbac9b… You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/commit/559b52b194f813c0c8584b3becbac9b2ab8e0343/62841330(a)github.com>

2 years, 10 months

git:master:9ebf483a: rtpengine: Fix typo in RPC response handling

by Olle E. Johansson

Module: kamailio Branch: master Commit: 9ebf483a51b8584c05a2bcd3d4b26ac22a878ce8 URL: https://github.com/kamailio/kamailio/commit/9ebf483a51b8584c05a2bcd3d4b26ac… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T16:36:46+01:00 rtpengine: Fix typo in RPC response handling --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/9ebf483a51b8584c05a2bcd3d4b26ac… Patch: https://github.com/kamailio/kamailio/commit/9ebf483a51b8584c05a2bcd3d4b26ac… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 3440daec93..ab6920c01d 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -1341,7 +1341,7 @@ static void rtpengine_rpc_reload(rpc_t* rpc, void* ctx) LM_DBG("current rtpengines list version: %d (%u)\n", _rtpe_list_version->vernum, (unsigned int)_rtpe_list_version->vertime); - rpc->rpl_printf(c, "Ok. Reload successful."); + rpc->rpl_printf(ctx, "Ok. Reload successful."); } static int rtpengine_rpc_iterate(rpc_t* rpc, void* ctx, const str *rtpp_url,

2 years, 10 months

git:master:7feb3865: secfilter: Convert error messages to error responses in secf_rpc_add_dst()

by Olle E. Johansson

Module: kamailio Branch: master Commit: 7feb38651970fc1f3cfd90769685c46804ab25ae URL: https://github.com/kamailio/kamailio/commit/7feb38651970fc1f3cfd90769685c46… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T16:36:46+01:00 secfilter: Convert error messages to error responses in secf_rpc_add_dst() --- Modified: src/modules/secfilter/secfilter_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/7feb38651970fc1f3cfd90769685c46… Patch: https://github.com/kamailio/kamailio/commit/7feb38651970fc1f3cfd90769685c46… --- diff --git a/src/modules/secfilter/secfilter_rpc.c b/src/modules/secfilter/secfilter_rpc.c index cea9d400e8..2f763e4732 100644 --- a/src/modules/secfilter/secfilter_rpc.c +++ b/src/modules/secfilter/secfilter_rpc.c @@ -63,7 +63,7 @@ void secf_rpc_add_dst(rpc_t *rpc, void *ctx) char *text = NULL; if(rpc->scan(ctx, "d", &number) < 1) { - rpc->fault(ctx, 0, + rpc->fault(ctx, 500, "Invalid Parameters. Usage: secfilter.add_dst " "number\n Example: secfilter.add_dst " "555123123"); @@ -73,7 +73,7 @@ void secf_rpc_add_dst(rpc_t *rpc, void *ctx) data.s = pkg_malloc(data.len * sizeof(char)); if(!data.s) { PKG_MEM_ERROR; - rpc->rpl_printf(ctx, "Error insert values in the blacklist"); + rpc->fault(ctx, 500, "Error insert values in the blacklist"); return; } memcpy(data.s, text, data.len); @@ -82,7 +82,7 @@ void secf_rpc_add_dst(rpc_t *rpc, void *ctx) rpc->rpl_printf(ctx, "Values (%s) inserted into blacklist destinations", data); } else { - rpc->rpl_printf(ctx, "Error insert values in the blacklist"); + rpc->fault(ctx, 500, "Error insert values in the blacklist"); } lock_release(&secf_data->lock); if(data.s)

2 years, 10 months

git:master:b108bd6a: modules: readme files regenerated - rtp_media_server ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: b108bd6aaa7f25f91bd058c92103e9f0910bba0e URL: https://github.com/kamailio/kamailio/commit/b108bd6aaa7f25f91bd058c92103e9f… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-01-03T16:31:27+01:00 modules: readme files regenerated - rtp_media_server ... [skip ci] --- Modified: src/modules/rtp_media_server/README --- Diff: https://github.com/kamailio/kamailio/commit/b108bd6aaa7f25f91bd058c92103e9f… Patch: https://github.com/kamailio/kamailio/commit/b108bd6aaa7f25f91bd058c92103e9f… --- diff --git a/src/modules/rtp_media_server/README b/src/modules/rtp_media_server/README index 511263f880..769af84350 100644 --- a/src/modules/rtp_media_server/README +++ b/src/modules/rtp_media_server/README @@ -85,11 +85,9 @@ Chapter 1. Admin Guide 1. Overview - rtp_media_server module is adding RTP and media processing - functionalities to Kamailio - - Kamailio is providing SIP signaling including and enpoint with Dialog - state, SDP parsing and scripting language + rtp_media_server module adds RTP and media processing functionalities + to Kamailio. Kamailio is providing SIP signaling including an endpoint + with Dialog state, SDP parsing and scripting language. oRTP: is providing Real-time Transport Protocol (RFC 3550) @@ -106,10 +104,11 @@ Chapter 1. Admin Guide 2.1. Building on Debian, Dockerfile and docker image - The module includes Dockerfile that can also be use as a reference on - how to build everything from source on Debian, the of libmediastreamer - on Linux is usually outdated. A docker image is also available from - dockerhub https://hub.docker.com/r/jchavanton/rtp_media_server + The module includes Dockerfile that can also be used as a reference on + how to build everything from source on Debian, the package of + libmediastreamer on Linux is usually outdated. A Docker image is also + available from dockerhub + https://hub.docker.com/r/jchavanton/rtp_media_server 3. Dependencies @@ -118,9 +117,9 @@ Chapter 1. Admin Guide 3.1. Kamailio Modules - The module depends on the following modules (in the other words the - listed modules must be loaded before this module): - * tm - accounting module + The module depends on the following modules (in other words the listed + modules must be loaded before this module): + * tm - transaction module 3.2. External Libraries or Applications @@ -129,7 +128,7 @@ Chapter 1. Admin Guide If you want to build oRTP and mediastreamer from source, you can use the provided script for Debian "install_bc.sh". - * oRTP git://git.linphone.org/ortp.git + * oRTP git clone git://git.linphone.org/ortp.git oRTP is a library implemeting Real-time Transport Protocol (RFC 3550), distributed under GNU GPLv2 or proprietary license. * mediastreamer2 git clone git://git.linphone.org/mediastreamer2.git @@ -167,7 +166,7 @@ modparam("rtp_media_server", "log_file_name", "/var/log/rms/rms_ortp.log") 5.1. rms_answer (event_route) - Create a call leg : with a SIP dialog and an RTP session call the + Create a call leg with a SIP dialog and an RTP session call the event_route This function can be used from REQUEST_ROUTE, REPLY_ROUTE and @@ -201,7 +200,7 @@ route { 5.2. rms_hangup () - Send a BYE, delete the RTP session and the media ressources. + Send a BYE, delete the RTP session and the media resources. This function can be used from EVENT_ROUTE. @@ -245,7 +244,7 @@ e in-dialog request needs to be handled by it. 5.4. rms_dialog_check () Returns true if the current SIP message it handled/known by the RMS - module, else it may be handle in any other way by Kamailio. + module, else it may be handled in any other way by Kamailio. This function can be used from REQUEST_ROUTE, REPLY_ROUTE and FAILURE_ROUTE.

2 years, 10 months

git:master:82721b91: rtp_media_server: Documentation update, typo fixing

by Olle E. Johansson

Module: kamailio Branch: master Commit: 82721b916d9743cca58b69a5772b3e5a7ce8461e URL: https://github.com/kamailio/kamailio/commit/82721b916d9743cca58b69a5772b3e5… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T16:28:27+01:00 rtp_media_server: Documentation update, typo fixing --- Modified: src/modules/rtp_media_server/doc/rtp_media_server_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/82721b916d9743cca58b69a5772b3e5… Patch: https://github.com/kamailio/kamailio/commit/82721b916d9743cca58b69a5772b3e5…

2 years, 10 months

git:master:2468473c: rtpengine: Add RPC success message on reload

by Olle E. Johansson

Module: kamailio Branch: master Commit: 2468473c18200161bba42e01468d3007541329ef URL: https://github.com/kamailio/kamailio/commit/2468473c18200161bba42e01468d300… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T16:14:19+01:00 rtpengine: Add RPC success message on reload --- Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/2468473c18200161bba42e01468d300… Patch: https://github.com/kamailio/kamailio/commit/2468473c18200161bba42e01468d300… --- diff --git a/src/modules/rtpengine/rtpengine.c b/src/modules/rtpengine/rtpengine.c index 738e55d312..3440daec93 100644 --- a/src/modules/rtpengine/rtpengine.c +++ b/src/modules/rtpengine/rtpengine.c @@ -283,7 +283,7 @@ static str body_intermediate; static str rtp_inst_pv_param = {NULL, 0}; static pv_spec_t *rtp_inst_pvar = NULL; -/* array with the sockets used by rtpporxy (per process)*/ +/* array with the sockets used by rtpproxy (per process)*/ static unsigned int *rtpp_no = 0; static gen_lock_t *rtpp_no_lock = 0; static int *rtpp_socks = 0; @@ -1341,6 +1341,7 @@ static void rtpengine_rpc_reload(rpc_t* rpc, void* ctx) LM_DBG("current rtpengines list version: %d (%u)\n", _rtpe_list_version->vernum, (unsigned int)_rtpe_list_version->vertime); + rpc->rpl_printf(c, "Ok. Reload successful."); } static int rtpengine_rpc_iterate(rpc_t* rpc, void* ctx, const str *rtpp_url,

2 years, 10 months

git:master:261b7e13: matrix: Add RPC response on matrix reload success

by Olle E. Johansson

Module: kamailio Branch: master Commit: 261b7e13d711e5361ed491a8fd04efee2d73709e URL: https://github.com/kamailio/kamailio/commit/261b7e13d711e5361ed491a8fd04efe… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T16:00:05+01:00 matrix: Add RPC response on matrix reload success --- Modified: src/modules/matrix/matrix.c --- Diff: https://github.com/kamailio/kamailio/commit/261b7e13d711e5361ed491a8fd04efe… Patch: https://github.com/kamailio/kamailio/commit/261b7e13d711e5361ed491a8fd04efe… --- diff --git a/src/modules/matrix/matrix.c b/src/modules/matrix/matrix.c index d2177ccb24..54f26aa0f7 100644 --- a/src/modules/matrix/matrix.c +++ b/src/modules/matrix/matrix.c @@ -526,11 +526,12 @@ static void matrix_rpc_reload(rpc_t* rpc, void* c) if(db_reload_matrix() < 0) { rpc->fault(c, 500, "Reload failed"); } + rpc->rpl_printf(c, "Ok. Reload successful."); matrix_db_close(); } static const char *matrix_rpc_reload_doc[2] = { - "reload matrix records from database", + "Reload matrix records from database", 0 };

2 years, 10 months

git:master:41e20d7f: keepalive: Add RPC success responses

by Olle E. Johansson

Module: kamailio Branch: master Commit: 41e20d7f5106748a415951f6766cf64b9d14180d URL: https://github.com/kamailio/kamailio/commit/41e20d7f5106748a415951f6766cf64… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T15:58:41+01:00 keepalive: Add RPC success responses --- Modified: src/modules/keepalive/keepalive_rpc.c --- Diff: https://github.com/kamailio/kamailio/commit/41e20d7f5106748a415951f6766cf64… Patch: https://github.com/kamailio/kamailio/commit/41e20d7f5106748a415951f6766cf64… --- diff --git a/src/modules/keepalive/keepalive_rpc.c b/src/modules/keepalive/keepalive_rpc.c index e6a64dbcd1..ef9fe24a56 100644 --- a/src/modules/keepalive/keepalive_rpc.c +++ b/src/modules/keepalive/keepalive_rpc.c @@ -123,7 +123,7 @@ static void keepalive_rpc_add(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "couldn't add data to list"); return; } - + rpc->rpl_printf(ctx, "Ok. Destination added."); return; } static const char *keepalive_rpc_add_doc[2] = { @@ -156,7 +156,7 @@ static void keepalive_rpc_del(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "couldn't delete data from list"); return; } - + rpc->rpl_printf(ctx, "Ok. Destination removed."); return; } static const char *keepalive_rpc_del_doc[2] = { @@ -217,7 +217,7 @@ static const char *keepalive_rpc_get_doc[2] = { static void keepalive_rpc_flush(rpc_t *rpc, void *ctx) { ka_dest_t *dest; - LM_DBG("keepalive flushe\n"); + LM_DBG("keepalive flush\n"); ka_lock_destination_list(); for(dest = ka_destinations_list->first; dest != NULL; dest = dest->next) { @@ -225,7 +225,7 @@ static void keepalive_rpc_flush(rpc_t *rpc, void *ctx) } ka_destinations_list->first = 0; ka_unlock_destination_list(); - + rpc->rpl_printf(ctx, "Ok. Destination list flushed."); return; } static const char *keepalive_rpc_flush_doc[2] = {

2 years, 10 months

git:master:e5dac2fb: dmq: Add RPC success response on removing a node

by Olle E. Johansson

Module: kamailio Branch: master Commit: e5dac2fb61f375ccd131d4ad0c85ddabda32754c URL: https://github.com/kamailio/kamailio/commit/e5dac2fb61f375ccd131d4ad0c85dda… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T15:41:10+01:00 dmq: Add RPC success response on removing a node --- Modified: src/modules/dmq/dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/e5dac2fb61f375ccd131d4ad0c85dda… Patch: https://github.com/kamailio/kamailio/commit/e5dac2fb61f375ccd131d4ad0c85dda… --- diff --git a/src/modules/dmq/dmq.c b/src/modules/dmq/dmq.c index 817fc3f3bb..843b7e3e4d 100644 --- a/src/modules/dmq/dmq.c +++ b/src/modules/dmq/dmq.c @@ -442,6 +442,7 @@ void rpc_dmq_remove(rpc_t* rpc, void* ctx) rpc->fault(ctx, 500, "Failure"); return; } + rpc->rpl_printf(ctx, "Ok. DMQ node removed."); } static const char* rpc_dmq_remove_doc[3] = {

2 years, 10 months

git:master:101ddb5e: dispatcher: Add RPC success message when removing destination from set

by Olle E. Johansson

Module: kamailio Branch: master Commit: 101ddb5efe16fd415410be1ac86ff759e83bdc54 URL: https://github.com/kamailio/kamailio/commit/101ddb5efe16fd415410be1ac86ff75… Author: Olle E. Johansson <oej(a)edvina.net> Committer: Olle E. Johansson <oej(a)edvina.net> Date: 2022-01-03T15:41:10+01:00 dispatcher: Add RPC success message when removing destination from set --- Modified: src/modules/dispatcher/dispatcher.c --- Diff: https://github.com/kamailio/kamailio/commit/101ddb5efe16fd415410be1ac86ff75… Patch: https://github.com/kamailio/kamailio/commit/101ddb5efe16fd415410be1ac86ff75… --- diff --git a/src/modules/dispatcher/dispatcher.c b/src/modules/dispatcher/dispatcher.c index 551e1e0ffd..fbf65d33fe 100644 --- a/src/modules/dispatcher/dispatcher.c +++ b/src/modules/dispatcher/dispatcher.c @@ -1897,7 +1897,7 @@ static void dispatcher_rpc_remove(rpc_t *rpc, void *ctx) rpc->fault(ctx, 500, "Removing dispatcher dst failed"); return; } - + rpc->rpl_printf(ctx, "Ok. Dispatcher destination removed."); return; }

2 years, 10 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2022