sr-dev October 2022

sr-dev@lists.kamailio.org

12 participants
200 discussions

[kamailio/kamailio] Update sca.c - Fix done for Appearance purge stale (PR #3249)

by bensly-shanmugam

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  We have observed that when the call is answered and it is in active state more than 30 seconds, kamailio sends the notify messages with the "Idle" appearance to all the subscribed extensions. Practically it should not send the idle notification when the call is in active state. We have tried to change the mod parameter "purge_expired_interval" to 3600 seconds. but still idle notification transmit in 30 seconds. To overcome this issue, we have commented below line in the sca.c file. register_timer( sca_appearance_purge_stale, sca, sca->cfg->purge_expired_interval); You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3249 -- Commit Summary -- * Update sca.c - Fix done for Appearance purge stale -- File Changes -- M src/modules/sca/sca.c (4) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3249.patch https://github.com/kamailio/kamailio/pull/3249.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3249 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3249(a)github.com>

1 year, 10 months

[kamailio/kamailio] Stirshaken module not handling certificate chain caching (Issue #3246)

by Sylvain Fontaine

### Description The stirshaken module has an option to cache certificates instead of downloading it using http for each calls. The problem is that the module doesn't save the certificate chain in the cached file. from here: https://github.com/kamailio/kamailio/blob/f7b35f05f31bd7cc01aea4572c79ba48d… We see that only `cert->x` is saved to the file. It needs to save `cert->chainx` as well. Similarly, the load function should load both the x509 and associated x509 chain. ### Troubleshooting #### Reproduction To reproduce, we need to configure the stirshaken module to do cerrtificate caching: ``` modparam("stirshaken", "vs_verify_x509_cert_path", 1) modparam("stirshaken", "vs_ca_dir", "/path/to/ca") modparam("stirshaken", "vs_cache_certificates", 1) modparam("stirshaken", "vs_cache_dir", "/path/to/cert_cache") modparam("stirshaken", "vs_cache_expire_s", 100) ``` Then send 2 calls featuring an identity header signed by a private key associated to a public certificate that includes a chain such as https://pstn-cdn.live.gtc.goto.com/certs/stirshaken/goto-2022-09 Verification for the fist call should work, but verification of x509 cert path will fail on second call #### SIP Traffic Example sip INVITE that should help reproduce the problem. ``` INVITE sip:+13855551212@216.82.227.102:5060 SIP/2.0 Max-Forwards: 61 f: <sip:+13852194167@reg.mydomain.net>;tag=as04e1a3e0 t: <sip:+13851212@somedomain.net> m: <sip:+13852194167@reg.mydomain.net:5060> i: 59ede93214794e1033b27ed249a90f15(a)reg.mydomain.net CSeq: 102 INVITE Date: Mon, 19 Sep 2022 15:04:01 GMT l: 0 Identity: eyJhbGciOiJFUzI1NiIsInBwdCI6InNoYWtlbiIsInR5cCI6InBhc3Nwb3J0IiwieDV1IjoiaHR0cHM6Ly9wc3RuLWNkbi5saXZlLmd0Yy5nb3RvLmNvbS9jZXJ0cy9zdGlyc2hha2VuL2dvdG8tMjAyMi0wOSJ9.eyJhdHRlc3QiOiJBIiwiZGVzdCI6eyJ0biI6WyIxNTE0ODM4MjY0NyJdfSwiaWF0IjoxNjYzNTk5ODQxLCJvcmlnIjp7InRuIjoiMTM4NTIxOTQxNjcifSwib3JpZ2lkIjoiNTllZGU5MzIxNDc5NGUxMDMzYjI3ZWQyNDlhOTBmMTVAcmVnLmppdmVpcC5uZXQifQ.wX5H0FhPt99MPWbdk_xgZXOWCHPGRcS_RiGTBBE5mG_r6By6StdnsBWiipdU9xyLuG3nSPKKFybhdO1S8OIeSQ;info=<https://pstn-cdn.live.gtc.goto.com/certs/stirshaken/goto-2022-09>;alg=ES256;ppt=shaken ``` ### Possible Solutions The module should save/load `cert->chainx` as well. Maybe a new set of function in libstirshaken should be added to save/load a certificate (vs saving/loading x509) -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3246 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3246(a)github.com>

1 year, 11 months

[kamailio/kamailio] Building Alpine APKs fail due to sunsetting of Python2 (Issue #3257)

by Ben Kaufman

### Description Issues building `PYTHON` module on Alpine Linux due to [sunsetting of Python2](https://www.python.org/doc/sunset-python-2/). The `python2` package (apk) has been removed from the current Alpine linux. The APKBUILD file in the current Kamailio branches includes build settings for installing the Python (python2) module. While I'm guessing it's possible to build python2 in the current Alpine container it was a conscious decision to no longer have a package for it. Given this, what is the opinion about not building this by default within the APKBUILD file? ### Troubleshooting Running `abuild -r` fails due to lack of python2 libraries. #### Reproduction Running `abuild -r` fails due to lack of python2 libraries. #### Debugging Data N/A #### Log Messages N/A #### SIP Traffic N/A ### Possible Solutions In `APKBUILD` remove references to `python2` and `python` (but not `python3`). I'll submit a pull request to do this. ### Additional Information Kamailio 5.7 * **Operating System**: Alpine Linux latest -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3257 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3257(a)github.com>

1 year, 11 months

[kamailio/kamailio] APKBUILD: remove python2 references (PR #3258)

by Ben Kaufman

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [x] PR should be backported to stable branches - [x] Tested changes locally - [x] Related to issue #3257 #### Description Do not build python2 module with default APKBUILD file due to python2 being sunsetted within Alpine Linux (there is no python2 APK). You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3258 -- Commit Summary -- * APKBUILD: remove python2 references -- File Changes -- M pkg/kamailio/alpine/APKBUILD (12) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3258.patch https://github.com/kamailio/kamailio/pull/3258.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3258 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3258(a)github.com>

1 year, 11 months

[kamailio/kamailio] stirshaken: Properly handle intermediary/chain certificates when caching certificates (PR #3175)

by mrtrev

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When the stirshaken module is in use and configured to cache certifications, validation will succeed on the very first attempt but will then fail every time the certificate is loaded from cache. The reason is because this module only saves the certificate and discards the any supplied chain certificates. This patch causes the module to save all supplied certificates and properly loads them upon retrieval. For the loading to work a patch is required in libstirshaken. A PR has already been submitted and is linked below. Without that patch the problem will persist but no other harm is done. This is a safe change to make that does not break existing behaviour. - save all certificates provided by signor to the disk cache - properly load all certificates when loading from cache - requires patch to libstirshaken (PR 123); this patch causes no harm (but no benefit) without it - resolve unrelated compiler warnings on 32bit systems https://github.com/signalwire/libstirshaken/pull/123 You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3175 -- Commit Summary -- * stirshaken: Properly handle intermediary/chain certificates when caching certificates * stirshaken: close file in write failure cases -- File Changes -- M src/modules/stirshaken/stirshaken_mod.c (106) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3175.patch https://github.com/kamailio/kamailio/pull/3175.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3175 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3175(a)github.com>

1 year, 11 months

opinion on kamailio docker file extensions

by Henning Westerholt

Hello, are there any objections to extend the https://github.com/kamailio/kamailio-docker packages to support some environment variables to allow some customization? * add a run.sh script * evaluate SHM_MEMORY and PKG_MEMORY variables * set "-M" and "-m" parameters appropriately for startup The shared memory pool can be set in the kamailio.cfg, but AFAIK the private memory pool not. Additionally using environment variables would be the common way that is used also in other well-known packages. If no variable is set, the default would be used. Thanks, Henning

2 years

git:master:065a83fb: modules: readme files regenerated - dispatcher ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 065a83fbb1a8b9b1912aadecff039a485c2d46dd URL: https://github.com/kamailio/kamailio/commit/065a83fbb1a8b9b1912aadecff039a4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-10-29T09:31:37+02:00 modules: readme files regenerated - dispatcher ... [skip ci] --- Modified: src/modules/dispatcher/README --- Diff: https://github.com/kamailio/kamailio/commit/065a83fbb1a8b9b1912aadecff039a4… Patch: https://github.com/kamailio/kamailio/commit/065a83fbb1a8b9b1912aadecff039a4… --- diff --git a/src/modules/dispatcher/README b/src/modules/dispatcher/README index 9d4287804f..abf41a6d85 100644 --- a/src/modules/dispatcher/README +++ b/src/modules/dispatcher/README @@ -1206,7 +1206,9 @@ With congestion control the formula becomes : set is chosen. * limit - the maximum number of items to be stored in XAVP list for further fail-overs (the first selected destination and default - destination are the first to be put in the list) + destination are the first to be put in the list). This can improve + the performance especially if you are using a large list of + gateways. This function can be used from REQUEST_ROUTE, FAILURE_ROUTE.

2 years

git:master:9b4d4d05: dispatcher: small spelling fix in comment

by Henning Westerholt

Module: kamailio Branch: master Commit: 9b4d4d059e6222a64a9b9cadb0b867bea27ed0d8 URL: https://github.com/kamailio/kamailio/commit/9b4d4d059e6222a64a9b9cadb0b867b… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-10-29T07:15:10Z dispatcher: small spelling fix in comment --- Modified: src/modules/dispatcher/dispatch.c --- Diff: https://github.com/kamailio/kamailio/commit/9b4d4d059e6222a64a9b9cadb0b867b… Patch: https://github.com/kamailio/kamailio/commit/9b4d4d059e6222a64a9b9cadb0b867b… --- diff --git a/src/modules/dispatcher/dispatch.c b/src/modules/dispatcher/dispatch.c index 8f06f6f5cbb..66ebd19996e 100644 --- a/src/modules/dispatcher/dispatch.c +++ b/src/modules/dispatcher/dispatch.c @@ -2065,7 +2065,7 @@ int ds_select_dst(struct sip_msg *msg, int set, int alg, int mode) * Set destination address from group 'set' selected with alogorithm 'alg' * - the rest of addresses in group are added as next destination in xavps, * up to the 'limit' - * - mode specify to set address in R-URI or outboud proxy + * - mode specify to set address in R-URI or outbound proxy * */ int ds_select_dst_limit(sip_msg_t *msg, int set, int alg, uint32_t limit,

2 years

git:master:0dc7d711: dispatcher: small docs extensions regarding to ds_select_dst

by Henning Westerholt

Module: kamailio Branch: master Commit: 0dc7d711c4c2d16d532862344f9ccd629de38e20 URL: https://github.com/kamailio/kamailio/commit/0dc7d711c4c2d16d532862344f9ccd6… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-10-29T07:17:10Z dispatcher: small docs extensions regarding to ds_select_dst --- Modified: src/modules/dispatcher/doc/dispatcher_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/0dc7d711c4c2d16d532862344f9ccd6… Patch: https://github.com/kamailio/kamailio/commit/0dc7d711c4c2d16d532862344f9ccd6… --- diff --git a/src/modules/dispatcher/doc/dispatcher_admin.xml b/src/modules/dispatcher/doc/dispatcher_admin.xml index 1c9de29ba78..022c915e139 100644 --- a/src/modules/dispatcher/doc/dispatcher_admin.xml +++ b/src/modules/dispatcher/doc/dispatcher_admin.xml @@ -1399,7 +1399,8 @@ With congestion control the formula becomes : <emphasis>limit</emphasis> - the maximum number of items to be stored in XAVP list for further fail-overs (the first selected destination and default destination are the first to be put in - the list) + the list). This can improve the performance especially if you + are using a large list of gateways. </para> </listitem> </itemizedlist>

2 years

git:master:e7e23666: core: small spelling fix in comment

by Henning Westerholt

Module: kamailio Branch: master Commit: e7e2366634f7b56136b11d4b196150467a18b651 URL: https://github.com/kamailio/kamailio/commit/e7e2366634f7b56136b11d4b1961504… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-10-29T07:14:57Z core: small spelling fix in comment --- Modified: src/core/parser/msg_parser.h --- Diff: https://github.com/kamailio/kamailio/commit/e7e2366634f7b56136b11d4b1961504… Patch: https://github.com/kamailio/kamailio/commit/e7e2366634f7b56136b11d4b1961504… --- diff --git a/src/core/parser/msg_parser.h b/src/core/parser/msg_parser.h index 595c1be8957..d582ddf7200 100644 --- a/src/core/parser/msg_parser.h +++ b/src/core/parser/msg_parser.h @@ -110,7 +110,7 @@ typedef enum request_method { #define FL_MSG_NOREPLY (1<<23) /*!< do not send sip reply for request */ #define FL_SIPTRACE (1<<24) /*!< message to be traced in stateless replies */ #define FL_ROUTE_ADDR (1<<25) /*!< request has Route address for next hop */ -#define FL_USE_OTCPID (1<<26) /*!< request to be routed using outboud tcp con id */ +#define FL_USE_OTCPID (1<<26) /*!< request to be routed using outbound tcp con id */ /* WARNING: Value (1 << 28) is reserved for use in kamailio call_control * module (flag FL_USE_CALL_CONTROL )! */

2 years

← Newer
1
...
8
9
10
11
12
13
14
...
20
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2022