sr-dev October 2022

sr-dev@lists.kamailio.org

12 participants
203 discussions

git:master:17ef6f22: src/Makefile: deb-stable is bullseye nowadays
by Victor Seva 12 Oct '22

12 Oct '22

Module: kamailio Branch: master Commit: 17ef6f22f24a77fba64d8076c8be771fac2ab00a URL: https://github.com/kamailio/kamailio/commit/17ef6f22f24a77fba64d8076c8be771… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-10-12T09:48:38+02:00 src/Makefile: deb-stable is bullseye nowadays https://github.com/kamailio/pkg-kamailio-docker/issues/3 --- Modified: src/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/17ef6f22f24a77fba64d8076c8be771… Patch: https://github.com/kamailio/kamailio/commit/17ef6f22f24a77fba64d8076c8be771… --- diff --git a/src/Makefile b/src/Makefile index a6380c2283..8fc3f57aaa 100644 --- a/src/Makefile +++ b/src/Makefile @@ -626,7 +626,7 @@ deb-stable: dpkg-buildpackage -rfakeroot -tc -uc -us; \ rm debian; \ else \ - ln -s pkg/$(MAIN_NAME)/deb/buster debian; \ + ln -s pkg/$(MAIN_NAME)/deb/bullseye debian; \ dpkg-buildpackage -rfakeroot -tc -uc -us; \ rm debian; \ fi)

1 0

[kamailio/kamailio] Unexpected kamailio 5.4 segfault (#2828)
by nmateo26 11 Oct '22

11 Oct '22

Dear all we have seen a core in a running production kamailio instance today, i attach you the bt in dropbox version: kamailio 5.4.4 (x86_64/linux) 0ddb01-dirty centos7 3.10.0-693.17.1.el7.x86_64 https://www.dropbox.com/s/fpunfs0o9aqhwww/kamailio_core_17agosto.txt?dl=0 ~~~ #0 0x00007f4c131446ad in print_lists (dlg=0x7f4b60abb2e8) at dlg_var.c:277 #1 0x00007f4c131467ff in pv_set_dlg_variable (msg=0x7f4c17592d70, param=0x7f4c17aa88d0, op=254, val=0x7ffc8de8c990) at dlg_var.c:443 #2 0x00000000004f9c82 in lval_pvar_assign (h=0x7ffc8de8ddc0, msg=0x7f4c17592d70, lv=0x7f4c17aa8998, rv=0x7f4c17aa8b18) at core/lvalue.c:352 #3 0x00000000004fa780 in lval_assign (h=0x7ffc8de8ddc0, msg=0x7f4c17592d70, lv=0x7f4c17aa8998, rve=0x7f4c17aa8b10) at core/lvalue.c:400 #4 0x00000000004c3f6f in do_action (h=0x7ffc8de8ddc0, a=0x7f4c17aa92b0, msg=0x7f4c17592d70) at core/action.c:1455 #5 0x00000000004c5cab in run_actions (h=0x7ffc8de8ddc0, a=0x7f4c17aa8668, msg=0x7f4c17592d70) at core/action.c:1581 #6 0x00000000004b8867 in do_action (h=0x7ffc8de8ddc0, a=0x7f4c17aac2b0, msg=0x7f4c17592d70) at core/action.c:1067 #7 0x00000000004c5cab in run_actions (h=0x7ffc8de8ddc0, a=0x7f4c17aa34c0, msg=0x7f4c17592d70) at core/action.c:1581 #8 0x00000000004c63ef in run_top_route (a=0x7f4c17aa34c0, msg=0x7f4c17592d70, c=0x7ffc8de8ddc0) at core/action.c:1666 #9 0x00007f4c16bbc0a2 in reply_received (p_msg=0x7f4c17592d70) at t_reply.c:2543 #10 0x00000000005d0b69 in do_forward_reply (msg=0x7f4c17592d70, mode=0) at core/forward.c:764 #11 0x00000000005d283b in forward_reply (msg=0x7f4c17592d70) at core/forward.c:865 #12 0x0000000000622dd2 in receive_msg ( buf=0xb034a0 <buf.7140> "SIP/2.0 100 Trying\r\nVia: SIP/2.0/UDP 79.170.68.186;branch=z9hG4bK895d.0e2ee1cb7a0cde9ed9e78d7f0ec22c00.0\r\nVia: SIP/2.0/UDP 79.170.71.172:5080;received=79.170.71.172;rport=5080;branch=z9hG4bKtmtBy7jaQ5"..., len=449, rcv_info=0x7ffc8de8e8b0) at core/receive.c:509 #13 0x0000000000521e67 in udp_rcv_loop () at core/udp_server.c:543 #14 0x0000000000429f56 in main_loop () at main.c:1689 #15 0x0000000000434034 in main (argc=13, argv=0x7ffc8de8f148) at main.c:2876 ~~~ Best regards, Noel -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2828

5 10

git:master:cbe6cef5: keepalive: removed redundant checks
by Daniel-Constantin Mierla 11 Oct '22

11 Oct '22

Module: kamailio Branch: master Commit: cbe6cef58da8de7efa18c4e34458a81176d23e42 URL: https://github.com/kamailio/kamailio/commit/cbe6cef58da8de7efa18c4e34458a81… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-10-11T10:17:34+02:00 keepalive: removed redundant checks --- Modified: src/modules/keepalive/keepalive_api.c --- Diff: https://github.com/kamailio/kamailio/commit/cbe6cef58da8de7efa18c4e34458a81… Patch: https://github.com/kamailio/kamailio/commit/cbe6cef58da8de7efa18c4e34458a81… --- diff --git a/src/modules/keepalive/keepalive_api.c b/src/modules/keepalive/keepalive_api.c index d68e97e374b..e8b1e044be8 100644 --- a/src/modules/keepalive/keepalive_api.c +++ b/src/modules/keepalive/keepalive_api.c @@ -224,10 +224,7 @@ int ka_find_destination(str *uri, str *owner, ka_dest_t **target, ka_dest_t **he ka_dest_t *dest=0 ,*temp=0; LM_DBG("finding destination: %.*s\n", uri->len, uri->s); - for(dest = ka_destinations_list->first ;dest; temp=dest, dest= dest->next ){ - if(!dest) - break; - + for(dest = ka_destinations_list->first; dest; temp=dest, dest=dest->next) { if (STR_EQ(*uri, dest->uri) && STR_EQ(*owner, dest->owner)){ *head = temp; *target = dest; @@ -255,10 +252,7 @@ int ka_find_destination_by_uuid(str uuid, ka_dest_t **target, ka_dest_t **head){ LM_DBG("finding destination with uuid:%.*s\n", uuid.len, uuid.s); - for(dest = ka_destinations_list->first ;dest ; temp = dest, dest = dest->next ){ - if(!dest) - break; - + for(dest = ka_destinations_list->first; dest; temp = dest, dest = dest->next) { if (STR_EQ(uuid, dest->uuid)){ *head = temp; *target = dest;

1 0

git:master:611cfede: core: dns cache - check pointer and small formatting
by Daniel-Constantin Mierla 11 Oct '22

11 Oct '22

Module: kamailio Branch: master Commit: 611cfede181f4cd61f576068708975efe5f66ffc URL: https://github.com/kamailio/kamailio/commit/611cfede181f4cd61f576068708975e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-10-11T09:40:56+02:00 core: dns cache - check pointer and small formatting --- Modified: src/core/dns_cache.c --- Diff: https://github.com/kamailio/kamailio/commit/611cfede181f4cd61f576068708975e… Patch: https://github.com/kamailio/kamailio/commit/611cfede181f4cd61f576068708975e… --- diff --git a/src/core/dns_cache.c b/src/core/dns_cache.c index e5e1b473ba..bf80c5fa16 100644 --- a/src/core/dns_cache.c +++ b/src/core/dns_cache.c @@ -4399,8 +4399,8 @@ int dns_cache_add_record(unsigned short type, } if (!rr_p) { - for ( rr_p = rr_iter; - *rr_p && (*rr_p != new_rr); + for (rr_p = rr_iter; + rr_p && *rr_p && (*rr_p != new_rr); rr_p = &((*rr_p)->next) ); }

1 0

git:master:609962b4: ims_registrar_pcscf: go to error to free variables on failure cases
by Daniel-Constantin Mierla 10 Oct '22

10 Oct '22

Module: kamailio Branch: master Commit: 609962b49a79dc5650f72470f4b03746d2e6db46 URL: https://github.com/kamailio/kamailio/commit/609962b49a79dc5650f72470f4b0374… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-10-10T13:01:21+02:00 ims_registrar_pcscf: go to error to free variables on failure cases --- Modified: src/modules/ims_registrar_pcscf/ul_callback.c --- Diff: https://github.com/kamailio/kamailio/commit/609962b49a79dc5650f72470f4b0374… Patch: https://github.com/kamailio/kamailio/commit/609962b49a79dc5650f72470f4b0374… --- diff --git a/src/modules/ims_registrar_pcscf/ul_callback.c b/src/modules/ims_registrar_pcscf/ul_callback.c index 57b89da3e18..320714f8b1c 100644 --- a/src/modules/ims_registrar_pcscf/ul_callback.c +++ b/src/modules/ims_registrar_pcscf/ul_callback.c @@ -92,13 +92,13 @@ str* build_reginfo_partial(ppublic_t *impu, struct pcontact* c, int type) { doc = xmlNewDoc(BAD_CAST "1.0"); if (doc == 0) { LM_ERR("Unable to create XML-Doc\n"); - return NULL; + goto error; } root_node = xmlNewNode(NULL, BAD_CAST "reginfo"); if (root_node == 0) { LM_ERR("Unable to create reginfo-XML-Element\n"); - return NULL; + goto error; } /* This is our Root-Element: */ xmlDocSetRootElement(doc, root_node); @@ -157,7 +157,7 @@ str* build_reginfo_partial(ppublic_t *impu, struct pcontact* c, int type) { body = (str*) pkg_malloc(sizeof(str)); if (body == NULL) { LM_ERR("while allocating memory\n"); - return NULL; + goto error; } memset(body, 0, sizeof(str));

1 0

git:master:d39f12ce: cdp: use empty string for debug messages when value is not set
by Daniel-Constantin Mierla 10 Oct '22

10 Oct '22

Module: kamailio Branch: master Commit: d39f12ced4c79f3b7d60b5477f5065d9589547e8 URL: https://github.com/kamailio/kamailio/commit/d39f12ced4c79f3b7d60b5477f5065d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-10-10T11:46:14+02:00 cdp: use empty string for debug messages when value is not set --- Modified: src/modules/cdp/receiver.c --- Diff: https://github.com/kamailio/kamailio/commit/d39f12ced4c79f3b7d60b5477f5065d… Patch: https://github.com/kamailio/kamailio/commit/d39f12ced4c79f3b7d60b5477f5065d… --- diff --git a/src/modules/cdp/receiver.c b/src/modules/cdp/receiver.c index 692cc363ae2..333b22c5c1c 100644 --- a/src/modules/cdp/receiver.c +++ b/src/modules/cdp/receiver.c @@ -709,7 +709,7 @@ int receive_loop(peer *original_peer) LM_DBG("select_recv(): fd exchange pipe says fd [%d] for peer %p:[%.*s]\n",fd, p, p?p->fqdn.len:0, - p?p->fqdn.s:0); + p?p->fqdn.s:""); if (p){ sp2=0; for(sp=serviced_peers;sp;sp=sp->next) @@ -748,7 +748,7 @@ int receive_loop(peer *original_peer) if (sp->tcp_socket>=0 && FD_ISSET(sp->tcp_socket,&efds)) { LM_INFO("select_recv(): [%.*s] Peer socket [%d] found on the exception list... dropping\n", sp->p?sp->p->fqdn.len:0, - sp->p?sp->p->fqdn.s:0, + sp->p?sp->p->fqdn.s:"", sp->tcp_socket); goto drop_peer; } @@ -776,7 +776,7 @@ int receive_loop(peer *original_peer) continue; LM_ERR("select_recv(): [%.*s] write on socket [%d] returned error> %s... dropping\n", sp->p?sp->p->fqdn.len:0, - sp->p?sp->p->fqdn.s:0, + sp->p?sp->p->fqdn.s:"", sp->tcp_socket, strerror(errno)); AAAFreeMessage(&msg); @@ -787,7 +787,7 @@ int receive_loop(peer *original_peer) if (cnt!=msg->buf.len){ LM_ERR("select_recv(): [%.*s] write on socket [%d] only wrote %d/%d bytes... dropping\n", sp->p?sp->p->fqdn.len:0, - sp->p?sp->p->fqdn.s:0, + sp->p?sp->p->fqdn.s:"", sp->tcp_socket, cnt, msg->buf.len); @@ -807,7 +807,7 @@ int receive_loop(peer *original_peer) if (cnt<=0) { LM_INFO("select_recv(): [%.*s] read on socket [%d] returned %d > %s... dropping\n", sp->p?sp->p->fqdn.len:0, - sp->p?sp->p->fqdn.s:0, + sp->p?sp->p->fqdn.s:"", sp->tcp_socket, cnt, errno?strerror(errno):"");

1 0

[kamailio/kamailio] KEMI API implementation for carrierroute module (PR #3247)
by Muhammad Shahzad Shafi 10 Oct '22

10 Oct '22

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Ported all carrierroute module functions to KEMI API. Here is an example, ```python3 ... # User location service def ksr_route_location(self, msg): if KSR.pv.get("$rm") == "INVITE" and KSR.carrierroute.cr_user_carrier("$fU", "$fd", "$avp(carrier)") > 0: if KSR.pv.get("$rm") == "INVITE" and KSR.carrierroute.cr_route("$avp(carrier)","$avp(domain)","$rU","$rU","call_id") > 0: KSR.info('Routing call via user carrier route\n') self.ksr_route_relay(msg) rc = KSR.registrar.lookup("location") if rc < 0: KSR.tm.t_newtran() if rc == -1 or rc == -3: KSR.sl.send_reply(404, "Not Found") return -255 elif rc == -2: KSR.sl.send_reply(405, "Method Not Allowed") return -255 # when routing via usrloc, log the missed calls also if KSR.is_INVITE() : KSR.setflag(FLT_ACCMISSED) self.ksr_route_relay(msg) return -255 ... ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3247 -- Commit Summary -- * KEMI API implementation for carrierroute module -- File Changes -- M src/modules/carrierroute/carrierroute.c (50) M src/modules/carrierroute/carrierroute.h (1) M src/modules/carrierroute/cr_func.c (260) M src/modules/carrierroute/cr_func.h (63) A src/modules/carrierroute/cr_kemi.c (199) A src/modules/carrierroute/cr_kemi.h (119) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3247.patch https://github.com/kamailio/kamailio/pull/3247.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3247 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3247(a)github.com>

4 14

git:master:d92a8a6d: modules: readme files regenerated - app_python ... [skip ci]
by Kamailio Dev 10 Oct '22

10 Oct '22

Module: kamailio Branch: master Commit: d92a8a6d8d4c0d226f740a67c76ca742a3ffed2a URL: https://github.com/kamailio/kamailio/commit/d92a8a6d8d4c0d226f740a67c76ca74… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-10-10T09:46:23+02:00 modules: readme files regenerated - app_python ... [skip ci] --- Modified: src/modules/app_python/README --- Diff: https://github.com/kamailio/kamailio/commit/d92a8a6d8d4c0d226f740a67c76ca74… Patch: https://github.com/kamailio/kamailio/commit/d92a8a6d8d4c0d226f740a67c76ca74… --- diff --git a/src/modules/app_python/README b/src/modules/app_python/README index a1269d14f0..a9d0b02890 100644 --- a/src/modules/app_python/README +++ b/src/modules/app_python/README @@ -77,6 +77,10 @@ Chapter 1. Admin Guide module, look at the files inside source tree located at 'modules/app_python/python_examples/'. + As python2 is deprecated in Debian and other distributions, please use + the “app_python3” module instead. This module will be removed future + releases. + 2. Dependencies 2.1. Kamailio Modules

1 0

git:master:7306e768: app_python: add a note that python2 is deprecated and app_python3 should be used
by Henning Westerholt 10 Oct '22

10 Oct '22

Module: kamailio Branch: master Commit: 7306e7683fd50420e93b44ec5593705194bf3616 URL: https://github.com/kamailio/kamailio/commit/7306e7683fd50420e93b44ec5593705… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-10-10T07:39:56Z app_python: add a note that python2 is deprecated and app_python3 should be used --- Modified: src/modules/app_python/doc/app_python_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/7306e7683fd50420e93b44ec5593705… Patch: https://github.com/kamailio/kamailio/commit/7306e7683fd50420e93b44ec5593705… --- diff --git a/src/modules/app_python/doc/app_python_admin.xml b/src/modules/app_python/doc/app_python_admin.xml index f9a39a8364a..f428bed6d7f 100644 --- a/src/modules/app_python/doc/app_python_admin.xml +++ b/src/modules/app_python/doc/app_python_admin.xml @@ -25,6 +25,11 @@ this module, look at the files inside source tree located at 'modules/app_python/python_examples/'. </para> + <para> + As python2 is deprecated in Debian and other distributions, please + use the <quote>app_python3</quote> module instead. This module will + be removed future releases. + </para> </section> <section> <title>Dependencies</title>

1 0

git:master:25a060bb: core: snexpr - assign the lv to evaluated variable with number value
by Daniel-Constantin Mierla 07 Oct '22

07 Oct '22

Module: kamailio Branch: master Commit: 25a060bb5d72cac5bafcd4e8e5960635bf848205 URL: https://github.com/kamailio/kamailio/commit/25a060bb5d72cac5bafcd4e8e596063… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-10-07T13:50:42+02:00 core: snexpr - assign the lv to evaluated variable with number value --- Modified: src/core/utils/snexpr.h --- Diff: https://github.com/kamailio/kamailio/commit/25a060bb5d72cac5bafcd4e8e596063… Patch: https://github.com/kamailio/kamailio/commit/25a060bb5d72cac5bafcd4e8e596063… --- diff --git a/src/core/utils/snexpr.h b/src/core/utils/snexpr.h index df409f8381..4fb6e3f3b7 100644 --- a/src/core/utils/snexpr.h +++ b/src/core/utils/snexpr.h @@ -781,7 +781,7 @@ static struct snexpr *snexpr_eval(struct snexpr *e) if(e->param.var.vref->evflags & SNEXPR_TSTRING) { lv = snexpr_convert_stz(e->param.var.vref->v.sval, SNE_OP_CONSTSTZ); } else { - snexpr_convert_num(e->param.var.vref->v.nval, SNE_OP_CONSTNUM); + lv = snexpr_convert_num(e->param.var.vref->v.nval, SNE_OP_CONSTNUM); } } else { lv = _snexternval_cbf(e->param.var.vref->name);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev October 2022