<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [ ] Commit message has the format required by CONTRIBUTING guide
- [ ] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
When the stirshaken module is in use and configured to cache certifications, validation will succeed on the very first attempt but will then fail every time the certificate is loaded from cache. The reason is because this module only saves the certificate and discards the any supplied chain certificates. This patch causes the module to save all supplied certificates and properly loads them upon retrieval.
For the loading to work a patch is required in libstirshaken. A PR has already been submitted and is linked below. Without that patch the problem will persist but no other harm is done. This is a safe change to make that does not break existing behaviour.
- save all certificates provided by signor to the disk cache
- properly load all certificates when loading from cache
- requires patch to libstirshaken (PR 123); this patch causes no harm (but no benefit) without it
- resolve unrelated compiler warnings on 32bit systems
https://github.com/signalwire/libstirshaken/pull/123
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3175
-- Commit Summary --
* stirshaken: Properly handle intermediary/chain certificates when caching certificates
* stirshaken: close file in write failure cases
-- File Changes --
M src/modules/stirshaken/stirshaken_mod.c (106)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3175.patchhttps://github.com/kamailio/kamailio/pull/3175.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3175
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3175(a)github.com>
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
For correct work geoip2 in KEMI, need preinit container for save result from module. I made changes based on phonenum module.
Without preinit in log we get err:
```
geoip2_update_pv(): container not found: XXX.XXX.XXX.XXX
```
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3288
-- Commit Summary --
* preinit container for KEMI
* add resid in Readme
* add xml doc
* update numbering
* format
-- File Changes --
M src/modules/geoip2/README (24)
M src/modules/geoip2/doc/geoip2_admin.xml (28)
M src/modules/geoip2/geoip2_mod.c (21)
M src/modules/geoip2/geoip2_pv.c (7)
M src/modules/geoip2/geoip2_pv.h (1)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3288.patchhttps://github.com/kamailio/kamailio/pull/3288.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3288
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3288(a)github.com>
Module: kamailio
Branch: 5.6
Commit: a7ded9247f5a3f0a6c133dea41dfd61e4b7d4682
URL: https://github.com/kamailio/kamailio/commit/a7ded9247f5a3f0a6c133dea41dfd61…
Author: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-11-30T08:46:15+01:00
pkg/kamailio/deb: refresh files [skip ci]
---
Modified: pkg/kamailio/deb/jammy/rules
---
Diff: https://github.com/kamailio/kamailio/commit/a7ded9247f5a3f0a6c133dea41dfd61…
Patch: https://github.com/kamailio/kamailio/commit/a7ded9247f5a3f0a6c133dea41dfd61…
---
diff --git a/pkg/kamailio/deb/jammy/rules b/pkg/kamailio/deb/jammy/rules
index 77ff6490f6..52bc98a96b 100755
--- a/pkg/kamailio/deb/jammy/rules
+++ b/pkg/kamailio/deb/jammy/rules
@@ -21,12 +21,12 @@ include /usr/share/dpkg/buildflags.mk
export RADCLI=1
# modules not in the "main" kamailio package
-EXCLUDED_MODULES=
+EXCLUDED_MODULES= java python
# extra modules to skip, because they are not compilable now
# - regardless if they go to the main kamailio package or to some module package,
# they will be excluded from compile and install of all
-EXTRA_EXCLUDED_MODULES=bdb dbtext oracle pa iptrtpproxy mi_xmlrpc
+EXTRA_EXCLUDED_MODULES=bdb dbtext oracle pa iptrtpproxy mi_xmlrpc dnssec
# module groups that are packaged in separate packages
# (with the name kamailio-$(group_name)-modules)
@@ -34,9 +34,9 @@ EXTRA_EXCLUDED_MODULES=bdb dbtext oracle pa iptrtpproxy mi_xmlrpc
# on which other depend first)
PACKAGE_GROUPS=mysql postgres berkeley unixodbc radius presence \
ldap xml perl utils lua memcached \
- snmpstats carrierroute xmpp cpl redis python geoip geoip2 \
- sqlite json mono ruby ims sctp java \
- tls outbound websocket autheph dnssec kazoo cnxcc \
+ snmpstats carrierroute xmpp cpl redisgeoip geoip2 \
+ sqlite json mono ruby ims sctp \
+ tls outbound websocket autheph kazoo cnxcc \
erlang systemd phonenum mongodb rabbitmq python3 mqtt secsipid lwsc nats
# module groups to be packaged onto kamailio-extra-modules