sr-dev December 2022

sr-dev@lists.kamailio.org

11 participants
266 discussions

[kamailio/kamailio] file_read() and file_write() contain no documentation on return values (Issue #3314)

by Дилян Палаузов

According to https://www.kamailio.org/docs/modules/5.6.x/modules/corex.html#corex.f.file… the functions cores.file_read() and cores.file_write() do not return a value (return void). The examples after functions are `if (file_write("z', "z")) {...}`. Since the functions appear in `if ()` they return se value. * document the return values of both functions -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3314 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3314(a)github.com>

1 year, 11 months

[kamailio/kamailio] Unclear conversion from number to boolean (Issue #3315)

by Дилян Палаузов

According to https://www.kamailio.org/wikidocs/cookbooks/devel/core/ (Core Cookbook) type boolean is documented as: * boolean - aliases to 1 (true, on, yes) or 0 (false, off, no) Moreover the if() and while() statement can accept a number as condition. My expectation was that passing non-zero is always converted to true, but this is not correct. Please document how numbers are converted to booleans in case of if() and while() conditions. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3315 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3315(a)github.com>

1 year, 11 months

git:5.6:e292ba27: modules: readme files regenerated - modules ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: 5.6 Commit: e292ba270c9a924e0849ef1ad90af6df0272640b URL: https://github.com/kamailio/kamailio/commit/e292ba270c9a924e0849ef1ad90af6d… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-12-18T09:16:58+01:00 modules: readme files regenerated - modules ... [skip ci] --- Modified: src/modules/registrar/README --- Diff: https://github.com/kamailio/kamailio/commit/e292ba270c9a924e0849ef1ad90af6d… Patch: https://github.com/kamailio/kamailio/commit/e292ba270c9a924e0849ef1ad90af6d… --- diff --git a/src/modules/registrar/README b/src/modules/registrar/README index ae37150c97..d40de57809 100644 --- a/src/modules/registrar/README +++ b/src/modules/registrar/README @@ -1115,7 +1115,7 @@ lookup_branches("location"); 4.5. registered(domain [, uri [, match_option [, match_action]]]) The function returns true if the AOR in the URI is registered, false - otherwise. The function does not modify the message being process, it + otherwise. The function does not modify the message being processed, it neither rewrites the Request-URI if a contact is found nor append branches. If uri parameter is not provided, then it considered to be the Request-URI for SIP requests and To-URI for SIP replies.

1 year, 11 months

git:5.5:fe4706da: core: typo instaNces

by Henning Westerholt

Module: kamailio Branch: 5.5 Commit: fe4706dab8851834ecb604160146d9bbd223f247 URL: https://github.com/kamailio/kamailio/commit/fe4706dab8851834ecb604160146d9b… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-12-18T08:11:48Z core: typo instaNces (cherry picked from commit 9cff22564db3664faa7b4b5bef86f5f71ff87bc8) (cherry picked from commit b3b066b9f4164bdb7e502b42f522b42d3b6cce66) --- Modified: src/core/cfg/cfg_struct.c Modified: src/core/cfg/cfg_struct.h --- Diff: https://github.com/kamailio/kamailio/commit/fe4706dab8851834ecb604160146d9b… Patch: https://github.com/kamailio/kamailio/commit/fe4706dab8851834ecb604160146d9b… --- diff --git a/src/core/cfg/cfg_struct.c b/src/core/cfg/cfg_struct.c index 49a885d8af6..94e5b2a5b9c 100644 --- a/src/core/cfg/cfg_struct.c +++ b/src/core/cfg/cfg_struct.c @@ -1099,7 +1099,7 @@ static int apply_add_var_list(cfg_block_t *block, cfg_group_t *group) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst) { diff --git a/src/core/cfg/cfg_struct.h b/src/core/cfg/cfg_struct.h index e03024e7006..0864a93fa5f 100644 --- a/src/core/cfg/cfg_struct.h +++ b/src/core/cfg/cfg_struct.h @@ -299,7 +299,7 @@ static inline void cfg_child_cb_free_item(cfg_child_cb_t *cb) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst);

1 year, 11 months

git:5.6:a3f5abb0: registrar: typo

by Henning Westerholt

Module: kamailio Branch: 5.6 Commit: a3f5abb0852d8c7d4006724639605cc26e74806b URL: https://github.com/kamailio/kamailio/commit/a3f5abb0852d8c7d4006724639605cc… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-12-18T08:11:04Z registrar: typo (cherry picked from commit c738a65c2fd0a40c3cdc236a3d3b48b0d18add21) --- Modified: src/modules/registrar/doc/registrar_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/a3f5abb0852d8c7d4006724639605cc… Patch: https://github.com/kamailio/kamailio/commit/a3f5abb0852d8c7d4006724639605cc… --- diff --git a/src/modules/registrar/doc/registrar_admin.xml b/src/modules/registrar/doc/registrar_admin.xml index 7246dd095b..8f15084af6 100644 --- a/src/modules/registrar/doc/registrar_admin.xml +++ b/src/modules/registrar/doc/registrar_admin.xml @@ -1457,7 +1457,7 @@ lookup_branches("location"); <para> The function returns true if the AOR in the URI is registered, false otherwise. The function does not modify the - message being process, it neither rewrites the Request-URI if a + message being processed, it neither rewrites the Request-URI if a contact is found nor append branches. If uri parameter is not provided, then it considered to be the Request-URI for SIP requests and To-URI for SIP replies.

1 year, 11 months

git:5.6:b3b066b9: core: typo instaNces

by Henning Westerholt

Module: kamailio Branch: 5.6 Commit: b3b066b9f4164bdb7e502b42f522b42d3b6cce66 URL: https://github.com/kamailio/kamailio/commit/b3b066b9f4164bdb7e502b42f522b42… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-12-18T08:10:52Z core: typo instaNces (cherry picked from commit 9cff22564db3664faa7b4b5bef86f5f71ff87bc8) --- Modified: src/core/cfg/cfg_struct.c Modified: src/core/cfg/cfg_struct.h --- Diff: https://github.com/kamailio/kamailio/commit/b3b066b9f4164bdb7e502b42f522b42… Patch: https://github.com/kamailio/kamailio/commit/b3b066b9f4164bdb7e502b42f522b42… --- diff --git a/src/core/cfg/cfg_struct.c b/src/core/cfg/cfg_struct.c index 49a885d8af6..94e5b2a5b9c 100644 --- a/src/core/cfg/cfg_struct.c +++ b/src/core/cfg/cfg_struct.c @@ -1099,7 +1099,7 @@ static int apply_add_var_list(cfg_block_t *block, cfg_group_t *group) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst) { diff --git a/src/core/cfg/cfg_struct.h b/src/core/cfg/cfg_struct.h index 03f38f322de..e789cf80282 100644 --- a/src/core/cfg/cfg_struct.h +++ b/src/core/cfg/cfg_struct.h @@ -299,7 +299,7 @@ static inline void cfg_child_cb_free_item(cfg_child_cb_t *cb) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst);

1 year, 11 months

git:master:a5f69e46: modules: readme files regenerated - registrar ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: a5f69e46613af05097debf1c373a138dd69fbdaf URL: https://github.com/kamailio/kamailio/commit/a5f69e46613af05097debf1c373a138… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-12-17T13:31:18+01:00 modules: readme files regenerated - registrar ... [skip ci] --- Modified: src/modules/registrar/README --- Diff: https://github.com/kamailio/kamailio/commit/a5f69e46613af05097debf1c373a138… Patch: https://github.com/kamailio/kamailio/commit/a5f69e46613af05097debf1c373a138… --- diff --git a/src/modules/registrar/README b/src/modules/registrar/README index 406fd0fe25..1e5d041324 100644 --- a/src/modules/registrar/README +++ b/src/modules/registrar/README @@ -1152,7 +1152,7 @@ xinfo("first contact record - socket: $xavp(cul>socket)\n"); 4.6. registered(domain [, uri [, match_option [, match_action]]]) The function returns true if the AOR in the URI is registered, false - otherwise. The function does not modify the message being process, it + otherwise. The function does not modify the message being processed, it neither rewrites the Request-URI if a contact is found nor append branches. If uri parameter is not provided, then it considered to be the Request-URI for SIP requests and To-URI for SIP replies.

1 year, 11 months

[kamailio/kamailio] Typos (PR #3312)

by Дилян Палаузов

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3312 -- Commit Summary -- * registrar: typo * core: typo instaNces * misc/examples: update comments -- File Changes -- M misc/examples/exec/exec_s5b.cfg (2) M misc/examples/kamailio/fork.cfg (4) M misc/examples/kamailio/serial_183.cfg (3) M misc/examples/mixed/ccdiversion.cfg (2) M misc/examples/mixed/onr.cfg (4) M misc/examples/mixed/serial_183.cfg (3) M src/core/cfg/cfg_struct.c (2) M src/core/cfg/cfg_struct.h (2) M src/modules/registrar/doc/registrar_admin.xml (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3312.patch https://github.com/kamailio/kamailio/pull/3312.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3312 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3312(a)github.com>

1 year, 11 months

git:master:49f42b36: misc/examples: update comments

by Henning Westerholt

Module: kamailio Branch: master Commit: 49f42b36b586a2b08b9f5a327263bfa9124df77b URL: https://github.com/kamailio/kamailio/commit/49f42b36b586a2b08b9f5a327263bfa… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-12-17T13:16:57+01:00 misc/examples: update comments --- Modified: misc/examples/exec/exec_s5b.cfg Modified: misc/examples/kamailio/fork.cfg Modified: misc/examples/kamailio/serial_183.cfg Modified: misc/examples/mixed/ccdiversion.cfg Modified: misc/examples/mixed/onr.cfg Modified: misc/examples/mixed/serial_183.cfg --- Diff: https://github.com/kamailio/kamailio/commit/49f42b36b586a2b08b9f5a327263bfa… Patch: https://github.com/kamailio/kamailio/commit/49f42b36b586a2b08b9f5a327263bfa… --- diff --git a/misc/examples/exec/exec_s5b.cfg b/misc/examples/exec/exec_s5b.cfg index 959cab137b4..302a7f7b211 100644 --- a/misc/examples/exec/exec_s5b.cfg +++ b/misc/examples/exec/exec_s5b.cfg @@ -34,7 +34,7 @@ route{ }; # user found, forward to his current uri now; if any # forwarding error occurs (e.g., busy or cancelled recevied - # from downstream), proceed to reply_route[1] + # from downstream), proceed to failure_route[1] t_on_failure("1"); if (!t_relay()) { sl_reply_error(); diff --git a/misc/examples/kamailio/fork.cfg b/misc/examples/kamailio/fork.cfg index 98e537350c2..671ca8c16cb 100644 --- a/misc/examples/kamailio/fork.cfg +++ b/misc/examples/kamailio/fork.cfg @@ -42,7 +42,7 @@ route{ # wait until timer hits seturi("sip:nobody@kamailio.org"); append_branch("sip:parallel@kamailio.org:9"); - # if we do not get a positive reply, continue at reply_route[1] + # if we do not get a positive reply, continue at failure_route[1] t_on_failure("1"); # forward the request to all destinations in destination set now t_relay(); @@ -52,7 +52,7 @@ failure_route[1] { # forwarding failed -- try again at another destination append_branch("sip:nonsense@kamailio.org"); log(1, "first redirection\n"); - # if this alternative destination fails too, proceed to reply_route[2] + # if this alternative destination fails too, proceed to failure_route[2] t_on_failure("2"); t_relay(); } diff --git a/misc/examples/kamailio/serial_183.cfg b/misc/examples/kamailio/serial_183.cfg index c707fc6cad0..f88f607d6d4 100644 --- a/misc/examples/kamailio/serial_183.cfg +++ b/misc/examples/kamailio/serial_183.cfg @@ -41,8 +41,7 @@ route{ log(1, "forwarding now to primary destination\n"); if (method=="INVITE") { rewriteuri("sip:xxx@192.168.2.16:5064"); - # if transaction broken, try other an alternative - # route + # if transaction is broken, try an alternative route t_on_failure("1"); # if a provisional came, stop alternating t_on_reply("1"); diff --git a/misc/examples/mixed/ccdiversion.cfg b/misc/examples/mixed/ccdiversion.cfg index 3123f962bcd..3d0b659dc03 100644 --- a/misc/examples/mixed/ccdiversion.cfg +++ b/misc/examples/mixed/ccdiversion.cfg @@ -9,7 +9,7 @@ loadmodule "modules/tm/tm.so" # ----------------- setting module-specific parameters --------------- route{ - # if we do not get a positive reply, continue at reply_route[2] + # if we do not get a positive reply, continue at failure_route[2] t_on_failure("2"); # forward the request to all destinations in destination set now t_relay(); diff --git a/misc/examples/mixed/onr.cfg b/misc/examples/mixed/onr.cfg index 2af311d5b83..c5fcc328677 100644 --- a/misc/examples/mixed/onr.cfg +++ b/misc/examples/mixed/onr.cfg @@ -38,7 +38,7 @@ route{ # wait until timer hits seturi("sip:nobody@iptel.org"); append_branch("sip:parallel@iptel.org:9"); - # if we do not get a positive reply, continue at reply_route[1] + # if we do not get a positive reply, continue at failure_route[1] t_on_failure("1"); # forward the request to all destinations in destination set now t_relay(); @@ -48,7 +48,7 @@ failure_route[1] { # forwarding failed -- try again at another destination append_branch("sip:nonsense@iptel.org"); log(1, "first redirection\n"); - # if this alternative destination fails too, proceed to reply_route[2] + # if this alternative destination fails too, proceed to failure_route[2] t_on_failure("2"); t_relay(); } diff --git a/misc/examples/mixed/serial_183.cfg b/misc/examples/mixed/serial_183.cfg index b08a61abe08..4ab2fb036d2 100644 --- a/misc/examples/mixed/serial_183.cfg +++ b/misc/examples/mixed/serial_183.cfg @@ -38,8 +38,7 @@ route{ log(1, "forwarding now to primary destination\n"); if (method=="INVITE") { rewriteuri("sip:xxx@192.168.2.16:5064"); - # if transaction broken, try other an alternative - # route + # if transaction is broken, try an alternative route t_on_failure("1"); # if a provisional came, stop alternating t_on_reply("1");

1 year, 11 months

git:master:9cff2256: core: typo instaNces

by Henning Westerholt

Module: kamailio Branch: master Commit: 9cff22564db3664faa7b4b5bef86f5f71ff87bc8 URL: https://github.com/kamailio/kamailio/commit/9cff22564db3664faa7b4b5bef86f5f… Author: �� <git-dpa(a)aegee.org> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-12-17T13:16:57+01:00 core: typo instaNces --- Modified: src/core/cfg/cfg_struct.c Modified: src/core/cfg/cfg_struct.h --- Diff: https://github.com/kamailio/kamailio/commit/9cff22564db3664faa7b4b5bef86f5f… Patch: https://github.com/kamailio/kamailio/commit/9cff22564db3664faa7b4b5bef86f5f… --- diff --git a/src/core/cfg/cfg_struct.c b/src/core/cfg/cfg_struct.c index 49a885d8af6..94e5b2a5b9c 100644 --- a/src/core/cfg/cfg_struct.c +++ b/src/core/cfg/cfg_struct.c @@ -1099,7 +1099,7 @@ static int apply_add_var_list(cfg_block_t *block, cfg_group_t *group) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst) { diff --git a/src/core/cfg/cfg_struct.h b/src/core/cfg/cfg_struct.h index 03f38f322de..e789cf80282 100644 --- a/src/core/cfg/cfg_struct.h +++ b/src/core/cfg/cfg_struct.h @@ -299,7 +299,7 @@ static inline void cfg_child_cb_free_item(cfg_child_cb_t *cb) * Both parameters can be NULL meaning that the src/dst config is the default, * not an additional group instance. * The function executes all the per-child process callbacks which are different - * in the two instaces. + * in the two instances. */ void cfg_move_handle(cfg_group_t *group, cfg_group_inst_t *src_ginst, cfg_group_inst_t *dst_ginst);

1 year, 11 months

← Newer
1
...
12
13
14
15
16
17
18
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2022