As of openssl 1.1.1s SSL_load_error_strings(); exists only in this form in include/openssl/ssl.h:
```c
# if OPENSSL_API_COMPAT < 0x10100000L
# define SSL_load_error_strings() \
OPENSSL_init_ssl(OPENSSL_INIT_LOAD_SSL_STRINGS \
| OPENSSL_INIT_LOAD_CRYPTO_STRINGS, NULL)
# endif
```
It does not exist, when OPENSSL_API_COMPAT == 0x10100000L. When openssl is ./Configure’d with `no-deprecated`then OPENSSL_API_COMPAT is set in include/openssl/opensslconf.h to OPENSSL_MIN_API=0x10100000L. That is: when OpenSSL 1.1.1s is `./Configure no-deprecated`, the macro SSL_load_error_strings() does not exist, but tls_h_mod_pre_init_f() calls it. This might or might not help:
```diff
diff --git a/src/modules/tls/tls_init.c b/src/modules/tls/tls_init.c
index 4c858bbbd8..784168c6f7 100644
--- a/src/modules/tls/tls_init.c
+++ b/src/modules/tls/tls_init.c
@@ -647,8 +647,8 @@ int tls_h_mod_pre_init_f(void)
#else
LM_DBG("preparing tls env for modules initialization (libssl <=1.0)\n");
SSL_library_init();
-#endif
SSL_load_error_strings();
+#endif
tls_mod_preinitialized=1;
return 0;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/commit/6df13e614cf6898b6d67f36c9b185a7…
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/commit/6df13e614cf6898b6d67f36c9b185a7530102ef1/92954312(a)github.com>
stirshaken: Properly handle intermediary/chain certificates when caching certificates
- requires patch to libstirshaken (https://github.com/signalwire/libstirshaken/pull/124) to do anything
- if patched version of libstirshaken detected, uses new methods to store all intermediary certs
- unrelated minor logging tweaks
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [x] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
The guts of this PR have been submitted to the libstirshaken side based on the suggestions of my previous PR. I didn't mean to close it but since I hadn't created a branch, it got closed when I updated my repo. Original PR is https://github.com/kamailio/kamailio/pull/3175
I've been running this in production for a day and it seems to be performing the same as my previous attempt.
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3289
-- Commit Summary --
* stirshaken: Properly handle intermediary/chain certificates when caching certificates
-- File Changes --
M src/modules/stirshaken/stirshaken_mod.c (24)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3289.patchhttps://github.com/kamailio/kamailio/pull/3289.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3289
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3289(a)github.com>
Hi,
the new module app_python3s is causing compilation issues, probably needs to be included in the exclude list:
$ make cfg
$ make all
make[2]: python3.8-config: Command not found
CC (gcc) [M app_python3s.so] apy3s_exception.o
apy3s_exception.c:22:10: fatal error: Python.h: No such file or directory
22 | #include <Python.h>
| ^~~~~~~~~~
compilation terminated.
Thanks,
Henning
--
Henning Westerholt - https://skalatan.de/blog/
Kamailio services - https://gilawa.com<https://gilawa.com/>