Module: kamailio
Branch: master
Commit: 236fada43f610b910490f7e0c216ac9aa3d9480c
URL: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
Author: Donat Zenichev <dzenichev(a)sipwise.com>
Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org>
Date: 2022-02-28T09:13:21+01:00
core: add support of ICE media options to SDP parser
In the current implementation only parsing of ICE candidate
attributes is supported, which makes it Possible to work
with ICE …
[View More]candidates and parameters specifically related per
candidate, but makes it Impossible to work
with ICE options of the media stream level (ICE options which
have an impact on the whole specific media stream).
ICE candidate attributes and ICE media options have different
dedication.
In order to target this matter, a new linked list is introduced
to store ICE media stream options.
Additionally, now when parsing media stream's attributes,
a couple of new helper functions have been introduced to
properly extract and store ICE media options:
- extract_ice_option()
- add_sdp_ice_opt()
The following extraction approaches are supported:
- multi-valued ICE options attribute (more than one value per a= header)
- one value per attribute (multiple a= headers with ICE options present)
Also now the way how a "zeroed" on-hold is detected is improved,
in case of the ICE (re)negotiation (when the connection address is equal
to '0.0.0.0', the media port is equal to '9' and ice-option 'trickle' is
present) the SDP is Not considered as an on-hold case, and it clearly
detects it's the ICE (re)negotiation (RFC 8840), which for e.g.
leads to a proper work of other side modules' functions (which use SDP
parser's data structures),
such as 'is_audio_on_hold()' from the textops.so module.
---
Modified: src/core/parser/sdp/sdp.c
Modified: src/core/parser/sdp/sdp.h
Modified: src/core/parser/sdp/sdp_helpr_funcs.c
Modified: src/core/parser/sdp/sdp_helpr_funcs.h
---
Diff: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
Patch: https://github.com/kamailio/kamailio/commit/236fada43f610b910490f7e0c216ac9…
[View Less]
fixes the deleted space after "erlang"
introduced by a593f518dd62fd68c330eb42470ce5d5e1dce636
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with &#…
[View More]39;git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [ ] Each component has a single commit (if not, squash them into one commit)
- [ ] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [ ] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [ ] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3041
-- Commit Summary --
* pkg::deb: Missing spaces
-- File Changes --
M pkg/kamailio/deb/bionic/rules (2)
M pkg/kamailio/deb/bullseye/rules (2)
M pkg/kamailio/deb/buster/rules (2)
M pkg/kamailio/deb/focal/rules (2)
M pkg/kamailio/deb/jessie/rules (2)
M pkg/kamailio/deb/stretch/rules (2)
M pkg/kamailio/deb/trusty/rules (2)
M pkg/kamailio/deb/xenial/rules (2)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3041.patchhttps://github.com/kamailio/kamailio/pull/3041.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3041
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3041(a)github.com>
[View Less]
### Description
Kamailio uses Ducktape 2 without module-node or module-ducktape, requiring all routing in a single file.
https://wiki.duktape.org/howtomodules
I'm attempting to add module-node support and creating this issue to track with PR.
Response from mailing list
> Hello,
>
> I didn't notice that require() was not in the duktape 2.x, I will try to add support for module-duktape when I get a chance. If someone wants to do it, pull requests are welcome -- it does not seem to …
[View More]be complex:
> * https://github.com/svaarala/duktape/tree/master/extras/module-duktape
> The module-node sounds interesting, but not being familiar with node.js, looks it need more work to enable it:
> * https://github.com/svaarala/duktape/tree/master/extras/module-node
>
> Cheers,
> Daniel
### Expected behavior
Include the required() JS file
`
var test = require('./test');
`
#### Actual observed behavior
Calling require() in a JSDT script throws TypeError: undefined not callable
#### Log Messages
```
ERROR: app_jsdt [app_jsdt_api.c:448]: jsdt_kemi_load_script(): failed running: TypeError: undefined not callable
```
### Possible Solutions
I played around a little with `module-duktape` but wasn't smart enough to define a `Duktape.modSearch()` that would work as desired. I'm probably missing something obvious. I've recently been playing with `asterisk/node-ari-client` which got me curious if `module-node` might be more aligned with thinking.
### Additional Information
* **Kamailio Version** - kamailio 5.5.4
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3037
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3037(a)github.com>
[View Less]
Module: kamailio
Branch: master
Commit: c37ccdc6e3bad0af4644941a872f510c51936c58
URL: https://github.com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
Author: Daniel-Constantin Mierla <miconda(a)gmail.com>
Committer: Daniel-Constantin Mierla <miconda(a)gmail.com>
Date: 2022-02-25T09:13:46+01:00
core: fixed comment typo
---
Modified: src/core/sr_module.h
---
Diff: https://github.com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
Patch: https://github.…
[View More]com/kamailio/kamailio/commit/c37ccdc6e3bad0af4644941a872f510…
---
diff --git a/src/core/sr_module.h b/src/core/sr_module.h
index 33f4f00095..251be938b0 100644
--- a/src/core/sr_module.h
+++ b/src/core/sr_module.h
@@ -160,7 +160,7 @@ void ksr_module_set_flag(unsigned int flag);
@warning child_init(PROC_MAIN) is again called
in the same process (main), but latter
(before tcp), so make sure you don't init things
- twice, bot in PROC_MAIN and PROC_INT */
+ twice, both in PROC_MAIN and PROC_INT */
#define PROC_NOCHLDINIT -128 /**< no child init functions will be called
if this rank is used in fork_process() */
[View Less]