sr-dev March 2022

sr-dev@lists.kamailio.org

10 participants
245 discussions

Roadmap to the next major release - v5.6.0
by Daniel-Constantin Mierla 14 Apr '22

14 Apr '22

Hello, it is the time to plan a bit the road to the next major release, to be versioned 5.6.0. The 5.5.0 was release about one year ago, therefore it is time to set the milestones for getting 5.6.0 out. I would propose to freeze the development on Thursday, April 14, 2020, test till mid of May or so, then release v5.6.0. There is a lot of development to existing components and a couple of new modules. If anyone wants a different time line towards 5.6.0, let's discuss and choose the one that suits most of the developers. Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda

1 2

[kamailio/kamailio] [Feature Request] Add reload capability for geoip2 module (#2029)
by Joel Serrano 13 Apr '22

13 Apr '22

### Description Currently, the `geoip2` module loads the IP database at startup and keeps it in cache and there is no way to tell Kamailio to reload the database without a full restart. ### Possible Solutions To keep this module inline with other modules that use external datasources, I would suggest to implement a new RPC command and a new geoip2 function to reload the database defined in the `path` geoip2 modparam without the need of a restart. I'm not aware of the effort required for implementing either of them, but only having an RPC command would effectively solve this issue as you can call RPC commands from within Kamailio conf, thus, the reload function would not be something strictly required but more of a nice-to-have. ### Examples: Function: ``` geoip2_reload() ``` RPC command: ``` kamctl rpc gip2.reload / kamctl rpc geoip2.reload ``` Kamcmd command: ``` kamcmd geoip2.reload ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2029

2 3

[kamailio/kamailio] pv_headers: Add support to remove a specific value from a header (PR #3070)
by Tomohare 11 Apr '22

11 Apr '22

- To be used with headers containing values separated by commas - pvh_header_param_exists() check if the value is present to a given header - pvh_remove_header_param() remove the value from the given header or the entire header if no other value is present   #### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Previously, to remove a parameter from a header it was needed to create a complex method on the configuration file for each header/parameter. This modification moves this complexity to the 'pv_headers' module. Two new functions: * pvh_header_param_exists * pvh_remove_header_param Both functions take as parameters the name of the header and the name of the parameter. It returns '-1' if the combination header/parameter: - is not found (pvh_header_param_exists) - couldn't be removed (pvh_remove_header_param). Examples (proxy configuration): if (pvh_header_param_exists("Supported", "100rel")) { // "100rel" is present on the "Supported" header } if (pvh_remove_header_param("Supported", "100rel")) { // "100rel" removed from header "Supported" } You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3070 -- Commit Summary -- * pv_headers: Add support to remove a specific value from a header -- File Changes -- M src/modules/pv_headers/doc/functions.xml (35) M src/modules/pv_headers/doc/pv_headers.xml (6) M src/modules/pv_headers/pv_headers.c (61) M src/modules/pv_headers/pvh_func.c (87) M src/modules/pv_headers/pvh_func.h (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3070.patch https://github.com/kamailio/kamailio/pull/3070.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3070 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3070(a)github.com>

4 4

[kamailio/kamailio] mqueue: add mqueue_mode modparam (PR #3053)
by Stefan Mititelu 07 Apr '22

07 Apr '22

2 12

[kamailio/kamailio] uac: fix shm leak (PR #3065)
by Stefan Mititelu 01 Apr '22

01 Apr '22

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Setup: uac_req_send() with evroute=2 and tm module enable_uac_fr=1 Noticed following shm errors while intensively testing uac_req_send(), happening quite soon after a fresh restart (e.g. 10 min): ``` kamailio[5384]: ERROR: <core> [core/mem/q_malloc.c:297]: qm_find_free(): qm_find_free(0x7fe8943bc000, 40632); Free fragment not found! kamailio[5384]: ERROR: <core> [core/mem/q_malloc.c:430]: qm_malloc(): qm_malloc(0x7fe8943bc000, 40632) called from uac: uac_send.c: uac_send_info_clone(105), module: uac; Free fragment not found! kamailio[5384]: ERROR: uac [uac_send.c:108]: uac_send_info_clone(): no more shm memory kamailio[5384]: ERROR: uac [uac_send.c:837]: uac_req_send(): cannot clone the uac structure ``` I tried monitoring system memory using `free` tool and noticed that the "used" memory didn't grow alot. However, I noticed the "buff/cached" memory had a steep growth when 200OK(s) started to come, for my setup. Noticed that, for my setup, when 200OK come, event_route[uac:reply] is not called, so the tm callback set by UAC module is not called. => the "tp" callback parameter shm allocated by UAC module is not freed. By analogy, when using uac_req_send() with evroute=1 and timeout happens (e.g. no reply comes), event_route[uac:reply] won't be called and same leak should happen => *i didn;t tested that*, was just an analogy. I updated the code to call the callback on TMCB_DESTROY, and make sure tp parameter is freed, *one time*. Let me know what you think of this... in my setup/tests I got no kamailio shm logs anymore. Also "buff/cached" memory didn't have that steep growth anymore. Thank you, Stefan You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3065 -- Commit Summary -- * uac: fix shm leak -- File Changes -- M src/modules/uac/uac_send.c (14) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3065.patch https://github.com/kamailio/kamailio/pull/3065.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3065 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3065(a)github.com>

3 4

[kamailio/kamailio] ims_qos: Added new parameters for AAR, AVP517 (PR #3066)
by alexyosifov 01 Apr '22

01 Apr '22

- Added new parameters: af_signaling_ip6, component_media_type, flow_protocol, omit_flow_ports, rs_default_bandwidth, rr_default_bandwidth. Check doc for details.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3066 -- Commit Summary -- * ims_qos: Added new parameters for AAR,AVP517 -- File Changes -- M src/modules/ims_qos/doc/ims_qos_admin.xml (134) M src/modules/ims_qos/ims_qos_mod.c (13) M src/modules/ims_qos/rx_aar.c (29) M src/modules/ims_qos/rx_avp.c (67) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3066.patch https://github.com/kamailio/kamailio/pull/3066.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3066 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3066(a)github.com>

2 2

[kamailio/kamailio] stirshaken: fix doc typos (PR #3067)
by mrtrev 01 Apr '22

01 Apr '22

2 1

git:master:0292cae2: evrexec: exposed src ip and port via variable
by Daniel-Constantin Mierla 31 Mar '22

31 Mar '22

Module: kamailio Branch: master Commit: 0292cae2812628e433cc07af6a45bf229e2ba708 URL: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-31T08:23:58+02:00 evrexec: exposed src ip and port via variable --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… Patch: https://github.com/kamailio/kamailio/commit/0292cae2812628e433cc07af6a45bf2… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index e3d131ff9f..253197d100 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -286,6 +286,11 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) NI_NUMERICHOST | NI_NUMERICSERV); if(ret == 0) { LM_DBG("received data from %s port %s\n", srchostval, srcportval); + _evrexec_info.srcip.s = srchostval; + _evrexec_info.srcip.len = strlen(_evrexec_info.srcip.s); + _evrexec_info.srcport.s = srcportval; + _evrexec_info.srcport.len = strlen(_evrexec_info.srcport.s); + str2sint(&_evrexec_info.srcport, &_evrexec_info.srcportno); } _evrexec_info.data.s = rcvbuf; @@ -424,6 +429,19 @@ static int pv_get_evr(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) switch(param->pvn.u.isname.name.n) { case 0: /* data */ return pv_get_strval(msg, param, res, &_evrexec_info.data); + case 1: /* srcpip */ + if(_evrexec_info.srcip.s==NULL) { + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_evrexec_info.srcip); + case 2: /* srcport */ + if(_evrexec_info.srcport.s==NULL) { + return pv_get_null(msg, param, res); + } + return pv_get_strval(msg, param, res, &_evrexec_info.srcport); + case 3: /* srcportno */ + return pv_get_sintval(msg, param, res, _evrexec_info.srcportno); + default: return pv_get_null(msg, param, res); } @@ -445,6 +463,27 @@ static int pv_parse_evr_name(pv_spec_p sp, str *in) goto error; } break; + case 5: + if(strncmp(in->s, "srcip", 5)==0) { + sp->pvp.pvn.u.isname.name.n = 1; + } else { + goto error; + } + break; + case 7: + if(strncmp(in->s, "srcport", 7)==0) { + sp->pvp.pvn.u.isname.name.n = 2; + } else { + goto error; + } + break; + case 9: + if(strncmp(in->s, "srcportno", 9)==0) { + sp->pvp.pvn.u.isname.name.n = 3; + } else { + goto error; + } + break; default: goto error; }

1 0

git:master:22041301: evrexec: use structure of exec context attributes
by Daniel-Constantin Mierla 31 Mar '22

31 Mar '22

Module: kamailio Branch: master Commit: 220413010fa1e268501edd8808dc02fcc8b9d0d1 URL: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T17:28:29+02:00 evrexec: use structure of exec context attributes --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… Patch: https://github.com/kamailio/kamailio/commit/220413010fa1e268501edd8808dc02f… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 89a189c9c8..e3d131ff9f 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -52,7 +52,14 @@ typedef struct evrexec_task { evrexec_task_t *_evrexec_list = NULL; -static str *pv_evr_data = NULL; +typedef struct evrexec_info { + str data; + str srcip; + str srcport; + int srcportno; +} evrexec_info_t; + +static evrexec_info_t _evrexec_info = { 0 }; /** module functions */ static int mod_init(void); @@ -222,7 +229,6 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) struct sockaddr_storage src_addr; socklen_t src_addr_len; ssize_t count; - str evr_data = STR_NULL; char srchostval[NI_MAXHOST]; char srcportval[NI_MAXSERV]; @@ -282,9 +288,8 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) LM_DBG("received data from %s port %s\n", srchostval, srcportval); } - evr_data.s = rcvbuf; - evr_data.len = (int)count; - pv_evr_data = &evr_data; + _evrexec_info.data.s = rcvbuf; + _evrexec_info.data.len = (int)count; fmsg = faked_msg_next(); set_route_type(LOCAL_ROUTE); @@ -302,7 +307,7 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) LM_ERR("error running event route kemi callback\n"); } } - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } /* avoid exiting the process */ while(1) { sleep(3600); } @@ -412,13 +417,13 @@ int evrexec_param(modparam_t type, void *val) */ static int pv_get_evr(sip_msg_t *msg, pv_param_t *param, pv_value_t *res) { - if(param==NULL || pv_evr_data==NULL) { + if(param==NULL || _evrexec_info.data.s==NULL) { return pv_get_null(msg, param, res); } switch(param->pvn.u.isname.name.n) { case 0: /* data */ - return pv_get_strval(msg, param, res, pv_evr_data); + return pv_get_strval(msg, param, res, &_evrexec_info.data); default: return pv_get_null(msg, param, res); } @@ -489,12 +494,12 @@ void rpc_evr_run(rpc_t *rpc, void *c) evr_data.len = strlen(evr_data.s); } - pv_evr_data = &evr_data; + _evrexec_info.data = evr_data; keng = sr_kemi_eng_get(); if(keng==NULL) { evr_id = route_lookup(&event_rt, evr_name.s); if(evr_id == -1) { - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); LM_ERR("event route not found: %.*s\n", evr_name.len, evr_name.s); rpc->fault(c, 500, "Event route not found"); return; @@ -522,7 +527,7 @@ void rpc_evr_run(rpc_t *rpc, void *c) } } set_route_type(rtbk); - pv_evr_data = NULL; + memset(&_evrexec_info, 0, sizeof(evrexec_info_t)); } /**

1 0

git:master:b81000ca: evrexec: log src ip and port
by Daniel-Constantin Mierla 30 Mar '22

30 Mar '22

Module: kamailio Branch: master Commit: b81000ca0f3332a00831ce9d6e774027beb4a605 URL: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-03-30T13:01:03+02:00 evrexec: log src ip and port --- Modified: src/modules/evrexec/evrexec_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… Patch: https://github.com/kamailio/kamailio/commit/b81000ca0f3332a00831ce9d6e77402… --- diff --git a/src/modules/evrexec/evrexec_mod.c b/src/modules/evrexec/evrexec_mod.c index 71e7c94921..89a189c9c8 100644 --- a/src/modules/evrexec/evrexec_mod.c +++ b/src/modules/evrexec/evrexec_mod.c @@ -223,6 +223,8 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) socklen_t src_addr_len; ssize_t count; str evr_data = STR_NULL; + char srchostval[NI_MAXHOST]; + char srcportval[NI_MAXSERV]; if(parse_protohostport(&it->sockaddr, &phostp)<0 || phostp.port==0 || phostp.host.len>62 || phostp.sport.len>5) { @@ -273,6 +275,13 @@ void evrexec_process_socket(evrexec_task_t *it, int idx) } rcvbuf[count] = '\0'; + ret = getnameinfo((struct sockaddr *)&src_addr, src_addr_len, srchostval, + sizeof(srchostval), srcportval, sizeof(srcportval), + NI_NUMERICHOST | NI_NUMERICSERV); + if(ret == 0) { + LM_DBG("received data from %s port %s\n", srchostval, srcportval); + } + evr_data.s = rcvbuf; evr_data.len = (int)count; pv_evr_data = &evr_data;

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2022