sr-dev April 2022

sr-dev@lists.kamailio.org

17 participants
284 discussions

[kamailio/kamailio] pv_headers: fix possible mem. overflow issue and wrong size string (PR #3095)

by Tomohare

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [X] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  - remove a variable creation Put two variable accessible to the entire function, renaming one to have some clarity. Remove the useless variable. - Change from using snprintf to memset (no more \0 at last position) This fix possible a memory overflow while using `snprintf`. This also add a \0 at the end of the structure, so a more direct approach with `memset` was used. - change the destination of an allocated space being smaller than the source Elements were being put into a smaller string, this commit makes the destination bigger then the source. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3095 -- Commit Summary -- * pv_headers: fix possible mem. overflow issue and wrong size string -- File Changes -- M src/modules/pv_headers/pvh_func.c (26) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3095.patch https://github.com/kamailio/kamailio/pull/3095.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3095 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3095(a)github.com>

2 years, 6 months

[kamailio/kamailio] userblocklist: add RPC functions (PR #3097)

by Stefan Mititelu

#### Pre-Submission Checklist    - [X] Commit message has the format required by CONTRIBUTING guide - [X] Commits are split per component (core, individual modules, libs, utils, ...) - [X] Each component has a single commit (if not, squash them into one commit) - [X] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [X] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Ported mi functions to RPC. Note that in order to send long number strings (e.g. username) from kamcmd one must prefix it with "s:" You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3097 -- Commit Summary -- * userblocklist: add RPC functions -- File Changes -- M src/modules/userblocklist/userblocklist.c (348) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3097.patch https://github.com/kamailio/kamailio/pull/3097.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3097 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3097(a)github.com>

2 years, 6 months

[kamailio/kamailio] pua_dialoginfo: Determine dialog event types in mod_init (PR #3079)

by Bastian Triller

Determine dialog event types for dialog callback on module initialization, since these will not change.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3079 -- Commit Summary -- * pua_dialoginfo: Determine dialog event types in mod_init -- File Changes -- M src/modules/pua_dialoginfo/pua_dialoginfo.c (29) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3079.patch https://github.com/kamailio/kamailio/pull/3079.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3079 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3079(a)github.com>

2 years, 6 months

[kamailio/kamailio] core/crypto: fix several mismatched bound warnings (PR #3098)

by Ovidiu Sas

#### Pre-Submission Checklist    - [*] Commit message has the format required by CONTRIBUTING guide - [*] Commits are split per component (core, individual modules, libs, utils, ...) - [*] Each component has a single commit (if not, squash them into one commit) - [*] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [*] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist: - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Fix for the following compiler warnings: ``` core/crypto/sha256.c:548:32: warning: argument 1 of type ‘sha2_byte[]’ {aka ‘unsigned char[]’} with mismatched bound [-Warray-parameter=] 548 | void sr_SHA256_Final(sha2_byte digest[], SHA256_CTX* context) { | ~~~~~~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:86:22: note: previously declared as ‘uint8_t[32]’ {aka ‘unsigned char[32]’} 86 | void sr_SHA256_Final(uint8_t[SHA256_DIGEST_LENGTH], SHA256_CTX*); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/crypto/sha256.c:611:47: warning: argument 2 of type ‘char[]’ with mismatched bound [-Warray-parameter=] 611 | char *sr_SHA256_End(SHA256_CTX* context, char buffer[]) { | ~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:87:34: note: previously declared as ‘char[65]’ 87 | char* sr_SHA256_End(SHA256_CTX*, char[SHA256_DIGEST_STRING_LENGTH]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/crypto/sha256.c:911:32: warning: argument 1 of type ‘sha2_byte[]’ {aka ‘unsigned char[]’} with mismatched bound [-Warray-parameter=] 911 | void sr_SHA512_Final(sha2_byte digest[], SHA512_CTX* context) { | ~~~~~~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:98:22: note: previously declared as ‘uint8_t[64]’ {aka ‘unsigned char[64]’} 98 | void sr_SHA512_Final(uint8_t[SHA512_DIGEST_LENGTH], SHA512_CTX*); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/crypto/sha256.c:940:47: warning: argument 2 of type ‘char[]’ with mismatched bound [-Warray-parameter=] 940 | char *sr_SHA512_End(SHA512_CTX* context, char buffer[]) { | ~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:99:34: note: previously declared as ‘char[129]’ 99 | char* sr_SHA512_End(SHA512_CTX*, char[SHA512_DIGEST_STRING_LENGTH]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/crypto/sha256.c:986:32: warning: argument 1 of type ‘sha2_byte[]’ {aka ‘unsigned char[]’} with mismatched bound [-Warray-parameter=] 986 | void sr_SHA384_Final(sha2_byte digest[], SHA384_CTX* context) { | ~~~~~~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:92:22: note: previously declared as ‘uint8_t[48]’ {aka ‘unsigned char[48]’} 92 | void sr_SHA384_Final(uint8_t[SHA384_DIGEST_LENGTH], SHA384_CTX*); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ core/crypto/sha256.c:1015:47: warning: argument 2 of type ‘char[]’ with mismatched bound [-Warray-parameter=] 1015 | char *sr_SHA384_End(SHA384_CTX* context, char buffer[]) { | ~~~~~^~~~~~~~ In file included from core/crypto/sha256.c:36: core/crypto/sha256.h:93:34: note: previously declared as ‘char[97]’ 93 | char* sr_SHA384_End(SHA384_CTX*, char[SHA384_DIGEST_STRING_LENGTH]); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3098 -- Commit Summary -- * core/crypto: fix several mismatched bound warnings -- File Changes -- M src/core/crypto/sha256.c (16) M src/core/crypto/sha256.h (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3098.patch https://github.com/kamailio/kamailio/pull/3098.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3098 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3098(a)github.com>

2 years, 6 months

git:master:69c004ee: core: modparam - safety check for str s pointer

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 69c004eec161c14d957f9e4011aeff4163af858d URL: https://github.com/kamailio/kamailio/commit/69c004eec161c14d957f9e4011aeff4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-29T14:04:12+02:00 core: modparam - safety check for str s pointer - deal with the case of argument with 'nonnull' attribute passed null --- Modified: src/core/modparam.c --- Diff: https://github.com/kamailio/kamailio/commit/69c004eec161c14d957f9e4011aeff4… Patch: https://github.com/kamailio/kamailio/commit/69c004eec161c14d957f9e4011aeff4… --- diff --git a/src/core/modparam.c b/src/core/modparam.c index 361536691d..0ccecf7c90 100644 --- a/src/core/modparam.c +++ b/src/core/modparam.c @@ -147,6 +147,12 @@ int set_mod_param_regex(char* regex, char* name, modparam_t type, void* val) break; case PARAM_STR: + if( ((str*)val2)->s==NULL) { + LM_ERR("null value\n"); + regfree(&preg); + pkg_free(reg); + return -1; + } ((str*)ptr)->s = pkg_malloc(((str*)val2)->len+1); if (!((str*)ptr)->s) { PKG_MEM_ERROR;

2 years, 6 months

git:master:dfc407c4: core: main - check the debug cli param value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: dfc407c4009acbd6e05ecfaf4e727b0636ab92a4 URL: https://github.com/kamailio/kamailio/commit/dfc407c4009acbd6e05ecfaf4e727b0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-29T09:44:46+02:00 core: main - check the debug cli param value --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/dfc407c4009acbd6e05ecfaf4e727b0… Patch: https://github.com/kamailio/kamailio/commit/dfc407c4009acbd6e05ecfaf4e727b0… --- diff --git a/src/main.c b/src/main.c index 2a268a689b..cb0c92e357 100644 --- a/src/main.c +++ b/src/main.c @@ -2100,6 +2100,10 @@ int main(int argc, char** argv) ksr_slog_init(optarg); break; case KARGOPTVAL+8: + if (optarg == NULL) { + fprintf(stderr, "bad debug level value\n"); + goto error; + } debug_flag = 1; default_core_cfg.debug=(int)strtol(optarg, &tmp, 10); if ((tmp==0) || (*tmp)){

2 years, 6 months

Kamailio functionality clarification - call forwarding no replay (call is ringing but not answered)

by VESELOVSKY Pavel

Hallo all, I would need help with Kamailio. I hope, you can give me some hints. I would like use Kamailio for CFNRy feature call forward no replay, i.e. * call is forked to multiple destination * 180 is received, call is ringing, but not answered, no 200 OK is received from some destination * after predefined time (CFNRy timer), only this specific branch has to be rerouted to another destination Expected behaviour is described in this flow: [cid:image001.png@01D85B0C.FCF06DE0] My current behavior: * Kamailio TM module is involved for parallel forking (https://www.kamailio.org/docs/modules/stable/modules/tm.html#:~:text=1.-,Ov…) * all branches are CANCEL-ed, it is not possible send CANCEL just to one specific branch [cid:image002.png@01D85B0C.FCF06DE0] My questions: * is it possible to CANCEL just specific branch? * is it possible start timer just for specific branch? * do you think is it possible somehow implement this feature with Kamailio? Thanks a lot in advance for any comment. Pavel.

2 years, 6 months

git:master:89495b85: db_redis: free db vals on error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 89495b8595d37f4d24e10e5ed1177614b2979d82 URL: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T14:09:13+02:00 db_redis: free db vals on error --- Modified: src/modules/db_redis/redis_dbase.c --- Diff: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… Patch: https://github.com/kamailio/kamailio/commit/89495b8595d37f4d24e10e5ed117761… --- diff --git a/src/modules/db_redis/redis_dbase.c b/src/modules/db_redis/redis_dbase.c index 68536816a8..254e0f6b3e 100644 --- a/src/modules/db_redis/redis_dbase.c +++ b/src/modules/db_redis/redis_dbase.c @@ -2164,6 +2164,8 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con if (db_redis_build_type_keys(con, CON_TABLE(_h), db_keys, db_vals, all_type_keys_count, &type_keys, &set_keys, &type_keys_count) != 0) { LM_ERR("failed to build type keys\n"); + pkg_free(db_vals); + db_vals = NULL; goto error; } pkg_free(db_keys); @@ -2306,7 +2308,7 @@ static int db_redis_perform_update(const db1_con_t* _h, km_redis_con_t *con, con if (scard != 0) continue; - + if (db_redis_key_add_string(&query_v, "SREM", 4) != 0) { LM_ERR("Failed to add srem command to post-delete query\n"); goto error;

2 years, 7 months

git:master:eba6c7d7: presence_xml: free uri for http xcap auth

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: eba6c7d78088cde411f5cd1b7730ba458e62a69e URL: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T14:03:55+02:00 presence_xml: free uri for http xcap auth --- Modified: src/modules/presence_xml/xcap_auth.c --- Diff: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… Patch: https://github.com/kamailio/kamailio/commit/eba6c7d78088cde411f5cd1b7730ba4… --- diff --git a/src/modules/presence_xml/xcap_auth.c b/src/modules/presence_xml/xcap_auth.c index 0cf0669ca1..c40f0a899e 100644 --- a/src/modules/presence_xml/xcap_auth.c +++ b/src/modules/presence_xml/xcap_auth.c @@ -521,7 +521,7 @@ int get_rules_doc( int http_get_rules_doc(str user, str domain, str *rules_doc) { - str uri; + str uri = STR_NULL; xcap_doc_sel_t doc_sel; char *doc = NULL; xcap_serv_t *xs; @@ -559,6 +559,8 @@ int http_get_rules_doc(str user, str domain, str *rules_doc) rules_doc->s = doc; rules_doc->len = doc ? strlen(doc) : 0; + pkg_free(uri.s); + return 0; error:

2 years, 7 months

git:master:33921b79: cfgt: free dest.s before return on error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 33921b79a4f5849f85a588332fe8debfb4d27c0e URL: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-28T13:42:21+02:00 cfgt: free dest.s before return on error --- Modified: src/modules/cfgt/cfgt_int.c --- Diff: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… Patch: https://github.com/kamailio/kamailio/commit/33921b79a4f5849f85a588332fe8deb… --- diff --git a/src/modules/cfgt/cfgt_int.c b/src/modules/cfgt/cfgt_int.c index b8345b4565..489fdfe445 100644 --- a/src/modules/cfgt/cfgt_int.c +++ b/src/modules/cfgt/cfgt_int.c @@ -394,6 +394,7 @@ void cfgt_save_node(cfgt_node_p node) LM_DBG("dir [%s] already exists\n", dest.s); } else if(mkdir(dest.s, S_IRWXO | S_IXGRP | S_IRWXU) < 0) { LM_ERR("failed to make directory: %s\n", strerror(errno)); + pkg_free(dest.s); return; } dest.s[dir] = '/';

2 years, 7 months

← Newer
1
...
8
9
10
11
12
13
14
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2022