sr-dev April 2022

sr-dev@lists.kamailio.org

17 participants
284 discussions

[kamailio/kamailio] the recursive lock of tm module is not safe? (Issue #3083)

by progromm

### Description See `lock_hash` in `h_table.c`: ```C void lock_hash(int i) { int mypid; mypid = my_pid(); if (likely(atomic_get(&_tm_table->entries[i].locker_pid) != mypid)) { lock(&_tm_table->entries[i].mutex); atomic_set(&_tm_table->entries[i].locker_pid, mypid); } else { /* locked within the same process that called us*/ _tm_table->entries[i].rec_lock_level++; } } ``` Flowing lines of code do not guarantee atomicity and I think it is not safe: * atomic_get(&_tm_table->entries[i].locker_pid) != mypid * lock(&_tm_table->entries[i].mutex) * atomic_set(&_tm_table->entries[i].locker_pid, mypid) Would you mind solving my confusion? -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3083 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3083(a)github.com>

2 years, 7 months

git:master:bf69b85f: modules: readme files regenerated - geoip2 ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: bf69b85fe9f383debcae6420c5d2d53a2ba452e9 URL: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-13T12:01:10+02:00 modules: readme files regenerated - geoip2 ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… Patch: https://github.com/kamailio/kamailio/commit/bf69b85fe9f383debcae6420c5d2d53… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 98d8d97f5c..80691c5516 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -37,7 +37,7 @@ Henning Westerholt 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload 6. Exported pseudo-variables @@ -67,7 +67,7 @@ Chapter 1. Admin Guide 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload 6. Exported pseudo-variables @@ -144,9 +144,9 @@ if(geoip2_match("$si", "src")) 5. RPC Commands - 5.1. userblocklist.reload_blocklist + 5.1. geoip2.reload -5.1. userblocklist.reload_blocklist +5.1. geoip2.reload Reload the internal GeoIP database. This is necessary after the database file has been changed on the disk.

2 years, 7 months

git:master:282bbf18: geoip2: docs - fixed the rpc command geoip2.reload title

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 282bbf188831bf9b4187fa2aa54fd9b2412e066c URL: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-04-13T11:58:01+02:00 geoip2: docs - fixed the rpc command geoip2.reload title --- Modified: src/modules/geoip2/doc/geoip2_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… Patch: https://github.com/kamailio/kamailio/commit/282bbf188831bf9b4187fa2aa54fd9b… --- diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml index cbcc2d8c79..8c5a96caa8 100644 --- a/src/modules/geoip2/doc/geoip2_admin.xml +++ b/src/modules/geoip2/doc/geoip2_admin.xml @@ -128,9 +128,9 @@ if(geoip2_match("$si", "src")) <section> <title>RPC Commands</title> - <section id="userblocklist.r.reload_blocklist"> + <section id="geoip2.r.reload"> <title> - <function moreinfo="none">userblocklist.reload_blocklist</function> + <function moreinfo="none">geoip2.reload</function> </title> <para> Reload the internal GeoIP database. This is necessary after

2 years, 7 months

[kamailio/kamailio] The I-CSCF does not send Ringing under heavy load. (Issue #3071)

by Eugeniy

### Description  I set up Kamailio IMS , in the end everything turned out great, calls are made, and I decided to check how Kamailio copes with the load. I am creating load using sipp application. There is no problem with a low call generation rate, but if you raise the call generation to more than 20 calls per second, some of the calls fail. ### Troubleshooting Challenges are always dropped sequentially ![image](https://user-images.githubusercontent.com/92918808/161745286-264d6e9b-47bb-4fcb-923a-1f5ded4cd999.png) I compared the calls and saw that the ICSCF does not send a 180 Ringing message towards the SCSCF. ![image](https://user-images.githubusercontent.com/92918808/161745354-2f97f8d1-2eb4-4a53-a9b0-2cb9d9d536d6.png) Below is an example of a successful call. ![image](https://user-images.githubusercontent.com/92918808/161745412-20f0ecc6-3952-4e01-9c74-4f6fa6cfd3c8.png) CPU, MEM indicators are normal. I increased the shr_mem and pkg_mem parameters. S-CSCF and I-CSCF communicate over UDP, but reside on the same server. It doesn't look like the packets are dropping or suffering from collisions. 10.21.4.226 external IP P-CSCF 10.10.0.1 IP P-CSCF 10.10.0.2 IP S/I-CSCF #### Reproduction  Using the sipp application, generate 100 calls at a generation rate greater than 20 calls per second. #### Debugging Data  ``` none ``` #### Log Messages  ``` attached below ``` [logs.zip](https://github.com/kamailio/kamailio/files/8417659/logs.zip) #### SIP Traffic  ``` attached below ``` [call_rejected.zip](https://github.com/kamailio/kamailio/files/8417640/call_… ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.3.2 (x86_64/linux) 42be5d flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 42be5d compiled on 10:39:53 Dec 27 2021 with gcc 9.3.0 ``` * **Operating System**:  ``` Ubuntu 20.04.3 LTS Linux ims-core 5.4.0-104-generic #118-Ubuntu SMP Wed Mar 2 19:02:41 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3071 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3071(a)github.com>

2 years, 7 months

git:master:c43432e6: modules: readme files regenerated - geoip2 ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: c43432e6fda8db527ffca3442d7cea8e601a211e URL: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-13T11:16:09+02:00 modules: readme files regenerated - geoip2 ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… Patch: https://github.com/kamailio/kamailio/commit/c43432e6fda8db527ffca3442d7cea8… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 0362750258..98d8d97f5c 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -91,7 +91,10 @@ Chapter 1. Admin Guide to enable access to the results of a query to the database. Many queries can be done and store results in different containers to - be able to use in parallel. Database is loaded at startup in cache. + be able to use in parallel. Database is loaded at startup in cache. The + cache can be reloaded with an RPC command. In this case make sure that + you do not overwrite the file in place, but replace it, e.g. with a + “move” command. 2. Dependencies

2 years, 7 months

git:master:166edc37: geoip2: add a note about db replacement recommendations

by Henning Westerholt

Module: kamailio Branch: master Commit: 166edc37177c2a92f57a31591ca781b15202a57f URL: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-13T09:04:31Z geoip2: add a note about db replacement recommendations --- Modified: src/modules/geoip2/doc/geoip2_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… Patch: https://github.com/kamailio/kamailio/commit/166edc37177c2a92f57a31591ca781b… --- diff --git a/src/modules/geoip2/doc/geoip2_admin.xml b/src/modules/geoip2/doc/geoip2_admin.xml index d3d0228946..cbcc2d8c79 100644 --- a/src/modules/geoip2/doc/geoip2_admin.xml +++ b/src/modules/geoip2/doc/geoip2_admin.xml @@ -44,6 +44,9 @@ <para> Many queries can be done and store results in different containers to be able to use in parallel. Database is loaded at startup in cache. + The cache can be reloaded with an RPC command. In this case make sure + that you do not overwrite the file in place, but replace it, e.g. with + a <quote>move</quote> command. </para> </section> <section>

2 years, 7 months

git:master:6a001d3f: geoip2: fix logging for reload failures, initialize memory for db

by Henning Westerholt

Module: kamailio Branch: master Commit: 6a001d3f90a8cfa2514b5b2781fc61dec50fc0c4 URL: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-13T08:20:54Z geoip2: fix logging for reload failures, initialize memory for db --- Modified: src/modules/geoip2/geoip2_pv.c --- Diff: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… Patch: https://github.com/kamailio/kamailio/commit/6a001d3f90a8cfa2514b5b2781fc61d… --- diff --git a/src/modules/geoip2/geoip2_pv.c b/src/modules/geoip2/geoip2_pv.c index 0b50fd4447..0995ae2d25 100644 --- a/src/modules/geoip2/geoip2_pv.c +++ b/src/modules/geoip2/geoip2_pv.c @@ -490,6 +490,8 @@ int geoip2_init_pv(char *path) { int status; _handle_GeoIP = shm_malloc(sizeof(struct MMDB_s)); + memset(_handle_GeoIP, 0, sizeof(struct MMDB_s)); + if (_handle_GeoIP == NULL) { SHM_MEM_ERROR; @@ -522,9 +524,13 @@ int geoip2_reload_pv(char *path) if(MMDB_SUCCESS != status) { LM_ERR("cannot reload GeoIP database file at: %s\n", path); + + } + else + { + LM_INFO("reloaded GeoIP database file at: %s\n", path); } lock_release(lock); - LM_INFO("reloaded GeoIP database file at: %s\n", path); return status; }

2 years, 7 months

git:master:85c4ad10: modules: readme files regenerated - geoip2 ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 85c4ad1025cc3aa882ddfb42cb35257500f4528b URL: https://github.com/kamailio/kamailio/commit/85c4ad1025cc3aa882ddfb42cb35257… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2022-04-13T08:46:12+02:00 modules: readme files regenerated - geoip2 ... [skip ci] --- Modified: src/modules/geoip2/README --- Diff: https://github.com/kamailio/kamailio/commit/85c4ad1025cc3aa882ddfb42cb35257… Patch: https://github.com/kamailio/kamailio/commit/85c4ad1025cc3aa882ddfb42cb35257… --- diff --git a/src/modules/geoip2/README b/src/modules/geoip2/README index 697ccf0889..0362750258 100644 --- a/src/modules/geoip2/README +++ b/src/modules/geoip2/README @@ -10,6 +10,10 @@ Daniel-Constantin Mierla <miconda(a)gmail.com> +Henning Westerholt + + gilawa.com + Copyright © 2010 Daniel-Constantin Mierla (asipto.com) __________________________________________________________________ @@ -31,12 +35,17 @@ Daniel-Constantin Mierla 4.1. geoip2_match(ipaddr, pvc) - 5. Exported pseudo-variables + 5. RPC Commands + + 5.1. userblocklist.reload_blocklist + + 6. Exported pseudo-variables List of Examples 1.1. Set path parameter 1.2. geoip2_match usage + 1.3. geoip2.reload usage Chapter 1. Admin Guide @@ -56,7 +65,11 @@ Chapter 1. Admin Guide 4.1. geoip2_match(ipaddr, pvc) - 5. Exported pseudo-variables + 5. RPC Commands + + 5.1. userblocklist.reload_blocklist + + 6. Exported pseudo-variables 1. Overview @@ -126,7 +139,21 @@ if(geoip2_match("$si", "src")) xlog("SIP message from: $gip2(src=>cc)\n"); ... -5. Exported pseudo-variables +5. RPC Commands + + 5.1. userblocklist.reload_blocklist + +5.1. userblocklist.reload_blocklist + + Reload the internal GeoIP database. This is necessary after the + database file has been changed on the disk. + + Example 1.3. geoip2.reload usage +... +kamcmd geoip2.reload +... + +6. Exported pseudo-variables * $gip2(pvc=>key) - pvc is an identifier for this query result; it is designated by the second parameter of geoip2_match(). The key can

2 years, 7 months

[kamailio/kamailio] [Feature Request] Add reload capability for geoip2 module (#2029)

by Joel Serrano

### Description Currently, the `geoip2` module loads the IP database at startup and keeps it in cache and there is no way to tell Kamailio to reload the database without a full restart. ### Possible Solutions To keep this module inline with other modules that use external datasources, I would suggest to implement a new RPC command and a new geoip2 function to reload the database defined in the `path` geoip2 modparam without the need of a restart. I'm not aware of the effort required for implementing either of them, but only having an RPC command would effectively solve this issue as you can call RPC commands from within Kamailio conf, thus, the reload function would not be something strictly required but more of a nice-to-have. ### Examples: Function: ``` geoip2_reload() ``` RPC command: ``` kamctl rpc gip2.reload / kamctl rpc geoip2.reload ``` Kamcmd command: ``` kamcmd geoip2.reload ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2029

2 years, 7 months

git:master:2f78b97e: geoip2: add reload RCP command fuctionality (related to GH #2029)

by Henning Westerholt

Module: kamailio Branch: master Commit: 2f78b97eaf3d4232a623be0d2eb2da575c93f13b URL: https://github.com/kamailio/kamailio/commit/2f78b97eaf3d4232a623be0d2eb2da5… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-04-13T06:36:23Z geoip2: add reload RCP command fuctionality (related to GH #2029) --- Modified: src/modules/geoip2/doc/geoip2.xml Modified: src/modules/geoip2/doc/geoip2_admin.xml Modified: src/modules/geoip2/geoip2_mod.c Modified: src/modules/geoip2/geoip2_pv.c Modified: src/modules/geoip2/geoip2_pv.h --- Diff: https://github.com/kamailio/kamailio/commit/2f78b97eaf3d4232a623be0d2eb2da5… Patch: https://github.com/kamailio/kamailio/commit/2f78b97eaf3d4232a623be0d2eb2da5…

2 years, 7 months

← Newer
1
...
18
19
20
21
22
23
24
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev April 2022