Hello,
with some effort directed lately to convert the wiki content to markdown
files and host them on github, it's time to now to nail down the path to
release nest major release for Kamailio, respectively v5.6.0.
What's new in this major release as well as upgrade guidelines have to
be built, but I hope to be done in time to release Kamailio v5.6.0
either on Monday, June 23, 2022 or on Wednesday, June 25, 2022. Should
anyone consider a different release planning, let's discuss it.
If anyone wants to help with them, the content has to be added to the
github wiki repository:
* https://github.com/kamailio/kamailio-wiki
If not there, new files have to be created and linked from the main page.
The wiki is built with mkdocs into html and made available for browsing at:
* https://kamailio.org/wikidocs/
Cheers,
Daniel
--
Daniel-Constantin Mierla -- www.asipto.comwww.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - Online: June 20-23, 2022
* https://www.asipto.com/sw/kamailio-advanced-training-online/
### Description
I noticed at least one regression while testing out kamailio 5.6.0: the same configuration yields a different result after upgrading from 5.5.4. More specifically, this xlog line/statement:
```
xlog("L_CRIT", "vn is $vn(cli_164_src_noccgr), to int is $(vn(cli_164_src_noccgr){s.int})\n");
```
Prints the following in syslog for `$vn(cli_164_src_noccgr) = "2152157200"`:
* On 5.5.4: `vn is 2152157200, to int is 2152157200`
* On 5.6.0~rc1: `vn is 2152157200, to int is`
I've only tested this with a couple of values and it doesn't always happen, for example for `$vn(cli_164_src_noccgr) = "2103260000"` the issue doesn't manifest.
Only thing I could think of is 2103260000 can be represented (unsigned) by 31 bits, whereas you need 32 bits for 2152157200? I skimmed over pv_trans.c and there weren't any obvious commits that could take the blame, at least not to me. Perhaps this is a compiler/glibc thing?
### Troubleshooting
#### Reproduction
Try the transformation above with various values for the pseudovariable being transformed, I guess.
<!--
If the issue can be reproduced, describe how it can be done.
-->
### Additional Information
```
version: kamailio 5.6.0-rc1 (x86_64/linux)
flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED
ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB
poll method support: poll, epoll_lt, epoll_et, sigio_rt, select.
id: unknown
compiled with gcc 10.2.1
```
* **Operating System**:
```
Linux sbcprov0-stage-lhe0-cn1 5.10.0-10-amd64 #1 SMP Debian 5.10.84-1 (2021-12-08) x86_64 GNU/Linux
```
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/issues/3116
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/issues/3116(a)github.com>
benign const qualifiers in inline functions
<!-- Kamailio Pull Request Template -->
<!--
IMPORTANT:
- for detailed contributing guidelines, read:
https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md
- pull requests must be done to master branch, unless they are backports
of fixes from master branch to a stable branch
- backports to stable branches must be done with 'git cherry-pick -x ...'
- code is contributed under BSD for core and main components (tm, sl, auth, tls)
- code is contributed GPLv2 or a compatible license for the other components
- GPL code is contributed with OpenSSL licensing exception
-->
#### Pre-Submission Checklist
<!-- Go over all points below, and after creating the PR, tick all the checkboxes that apply -->
<!-- All points should be verified, otherwise, read the CONTRIBUTING guidelines from above-->
<!-- If you're unsure about any of these, don't hesitate to ask on sr-dev mailing list -->
- [x] Commit message has the format required by CONTRIBUTING guide
- [x] Commits are split per component (core, individual modules, libs, utils, ...)
- [x] Each component has a single commit (if not, squash them into one commit)
- [x] No commits to README files for modules (changes must be done to docbook files
in `doc/` subfolder, the README file is autogenerated)
#### Type Of Change
- [x] Small bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds new functionality)
- [ ] Breaking change (fix or feature that would change existing functionality)
#### Checklist:
<!-- Go over all points below, and after creating the PR, tick the checkboxes that apply -->
- [ ] PR should be backported to stable branches
- [x] Tested changes locally
- [ ] Related to issue #XXXX (replace XXXX with an open issue number)
#### Description
<!-- Describe your changes in detail -->
You can view, comment on, or merge this pull request online at:
https://github.com/kamailio/kamailio/pull/3120
-- Commit Summary --
* core: const correctness
-- File Changes --
M src/core/ip_addr.h (12)
-- Patch Links --
https://github.com/kamailio/kamailio/pull/3120.patchhttps://github.com/kamailio/kamailio/pull/3120.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/kamailio/kamailio/pull/3120
You are receiving this because you are subscribed to this thread.
Message ID: <kamailio/kamailio/pull/3120(a)github.com>
Hello,
this seems to be caused from 7c347e244cf761d0:
dialog.c: In function ‘ki_dlg_get_var’:
dialog.c:1552:51: error: ‘k’ undeclared (first use in this function)
1552 | val = ki_dlg_get_var_helper(msg, &sc, &sf, &st, &k);
| ^
dialog.c:1552:51: note: each undeclared identifier is reported only once for each function it appears in
dialog.c:1552:35: warning: passing argument 2 of ‘ki_dlg_get_var_helper’ from incompatible pointer type [-Wincompatible-pointer-types]
1552 | val = ki_dlg_get_var_helper(msg, &sc, &sf, &st, &k);
| ^~~
[..]
make[2]: *** [../../Makefile.rules:100: dialog.o] Error 1
Cheers,
Henning
From: Henning Westerholt <notifications(a)github.com>
Sent: Friday, May 20, 2022 6:42 PM
To: Kamailio Devel List <sr-dev(a)lists.sip-router.org>
Cc: Ci activity <ci_activity(a)noreply.github.com>
Subject: [kamailio/kamailio] Run failed: build - master (130ce1b)
[GitHub]
[kamailio/kamailio] build workflow run
[https://github.githubassets.com/images/email/icons/actions.png]
build: Some jobs were not successful
View workflow run<https://github.com/kamailio/kamailio/actions/runs/2359532599>
[build (bullseye, gcc)]
build / build (bullseye, gcc)
Failed in 2 minutes and 29 seconds
[annotations for build / build (bullseye, gcc)]11 <https://github.com/kamailio/kamailio/actions/runs/2359532599>
[build (bullseye, clang)]
build / build (bullseye, clang)
Cancelled
[annotations for build / build (bullseye, clang)]2 <https://github.com/kamailio/kamailio/actions/runs/2359532599>
[build (sid, gcc)]
build / build (sid, gcc)
Failed in 2 minutes and 35 seconds
[annotations for build / build (sid, gcc)]13 <https://github.com/kamailio/kamailio/actions/runs/2359532599>
[build (sid, clang)]
build / build (sid, clang)
Cancelled
[annotations for build / build (sid, clang)]2 <https://github.com/kamailio/kamailio/actions/runs/2359532599>
—
You are receiving this because this workflow ran on your branch.
Manage your GitHub Actions notifications<https://github.com/settings/notifications>
GitHub, Inc. ・88 Colin P Kelly Jr Street ・San Francisco, CA 94107