sr-dev June 2022

sr-dev@lists.kamailio.org

20 participants
281 discussions

[kamailio/kamailio] command line arg `--substdefs` doesn't work anymore (Issue #3152)

by Seven Du

### Description  with the following args ``` --substdefs=/S_KAM_IP_PUBLIC/$KAM_IP_PUBLIC/ \ --substdefs=/S_KAM_SIP_PORT/$KAM_SIP_PORT/ ``` error logs when start ``` 0(24400) ERROR: <core> [core/ppcfg.c:57]: pp_def_qvalue(): defined value is too large 0 < 15 0(24400) ERROR: <core> [core/ppcfg.c:192]: pp_substdef_add(): failed to enclose in quotes the value 0(24400) ERROR: <core> [main.c:2371]: main(): failed to add substdefs expression: /S_KAM_IP_PUBLIC/192.168.7.8/ ``` ### Troubleshooting the first log was reported with this pr https://github.com/kamailio/kamailio/pull/3151 so looks like `pv_get_buffer_size()` returns `0`, and there looks like nowhere called `pv_set_buffer_size()`. I can confirm the same args works with the docker image: `kamailio/kamailio-ci:5.4.4-alpine`. the following config works in `kamailio.cfg`, so only the command line arg has problem. ``` #!substdef "!HOMER_DB_USER!homer_user!g" #!substdefs "/ID/subst/" ``` #### Reproduction  add the following arg to command line when kamailio start ``` --substdefs=/ID/VALUE/ ``` #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3152 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3152(a)github.com>

2 years, 4 months

git:master:a78adb53: core: init pv buffers earlier to be avaialble for cli params

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: a78adb5340ae6cb57f756189d070c32c49bfa426 URL: https://github.com/kamailio/kamailio/commit/a78adb5340ae6cb57f756189d070c32… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-28T18:43:53+02:00 core: init pv buffers earlier to be avaialble for cli params - GH #3152 --- Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/a78adb5340ae6cb57f756189d070c32… Patch: https://github.com/kamailio/kamailio/commit/a78adb5340ae6cb57f756189d070c32… --- diff --git a/src/main.c b/src/main.c index e919a23274..c6855e2033 100644 --- a/src/main.c +++ b/src/main.c @@ -2178,6 +2178,10 @@ int main(int argc, char** argv) init_tcp_options(); /* set the defaults before the config */ #endif + if (pv_init_buffer()<0) { + goto error; + } + pp_define_core(); /* process command line (cfg. file path etc) */

2 years, 4 months

git:5.6:203d0ca9: pv_headers: rework pvh_remove_header_param

by Victor Seva

Module: kamailio Branch: 5.6 Commit: 203d0ca9b5564d006ad3f56bdf7c1e8572f456fb URL: https://github.com/kamailio/kamailio/commit/203d0ca9b5564d006ad3f56bdf7c1e8… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-28T12:58:45+02:00 pv_headers: rework pvh_remove_header_param * fix KEMI interface, this is suppose to be called like pvh_remove_header_param(header_name, string_to_remove) * use pv buffer for temporal value * use xavi interface to set the new value (cherry picked from commit d9626dc9f341718ad7d78e62042695124ba52c32) --- Modified: src/modules/pv_headers/pv_headers.c Modified: src/modules/pv_headers/pvh_func.c Modified: src/modules/pv_headers/pvh_func.h --- Diff: https://github.com/kamailio/kamailio/commit/203d0ca9b5564d006ad3f56bdf7c1e8… Patch: https://github.com/kamailio/kamailio/commit/203d0ca9b5564d006ad3f56bdf7c1e8…

2 years, 4 months

git:master:d9626dc9: pv_headers: rework pvh_remove_header_param

by Victor Seva

Module: kamailio Branch: master Commit: d9626dc9f341718ad7d78e62042695124ba52c32 URL: https://github.com/kamailio/kamailio/commit/d9626dc9f341718ad7d78e620426951… Author: Victor Seva <vseva(a)sipwise.com> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-28T12:56:35+02:00 pv_headers: rework pvh_remove_header_param * fix KEMI interface, this is suppose to be called like pvh_remove_header_param(header_name, string_to_remove) * use pv buffer for temporal value * use xavi interface to set the new value --- Modified: src/modules/pv_headers/pv_headers.c Modified: src/modules/pv_headers/pvh_func.c Modified: src/modules/pv_headers/pvh_func.h --- Diff: https://github.com/kamailio/kamailio/commit/d9626dc9f341718ad7d78e620426951… Patch: https://github.com/kamailio/kamailio/commit/d9626dc9f341718ad7d78e620426951…

2 years, 4 months

git:master:03a489ad: pkg/kamailio/deb: update lintian overrides [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: 03a489addb248bd7e4820dc281ade4f4f3deda3c URL: https://github.com/kamailio/kamailio/commit/03a489addb248bd7e4820dc281ade4f… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2022-06-28T09:37:59+02:00 pkg/kamailio/deb: update lintian overrides [skip ci] --- Modified: pkg/kamailio/deb/bionic/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/bionic/kamailio.lintian-overrides Modified: pkg/kamailio/deb/bookworm/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/bookworm/kamailio.lintian-overrides Modified: pkg/kamailio/deb/bullseye/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/bullseye/kamailio.lintian-overrides Modified: pkg/kamailio/deb/buster/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/buster/kamailio.lintian-overrides Modified: pkg/kamailio/deb/debian/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/debian/kamailio.lintian-overrides Modified: pkg/kamailio/deb/focal/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/focal/kamailio.lintian-overrides Modified: pkg/kamailio/deb/jessie/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/jessie/kamailio.lintian-overrides Modified: pkg/kamailio/deb/precise/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/precise/kamailio.lintian-overrides Modified: pkg/kamailio/deb/sid/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/sid/kamailio.lintian-overrides Modified: pkg/kamailio/deb/stretch/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/stretch/kamailio.lintian-overrides Modified: pkg/kamailio/deb/trusty/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/trusty/kamailio.lintian-overrides Modified: pkg/kamailio/deb/wheezy/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/wheezy/kamailio.lintian-overrides Modified: pkg/kamailio/deb/xenial/kamailio-tls-modules.lintian-overrides Modified: pkg/kamailio/deb/xenial/kamailio.lintian-overrides --- Diff: https://github.com/kamailio/kamailio/commit/03a489addb248bd7e4820dc281ade4f… Patch: https://github.com/kamailio/kamailio/commit/03a489addb248bd7e4820dc281ade4f…

2 years, 4 months

[kamailio/kamailio] second auth via uac_reg_request_to (Issue #3166)

by Alberto bebbo Capponi

When using uac_reg_request_to and the first trunk fails (as invalid credentials) try a second trunk, but there is something not cleaned or just doesn't get the new trunk auth params. code example ``` failure_route[RETRY_OUTBOUND] { if (t_check_status("401|407")) { if(uac_reg_request_to("$rd", 0)) { t_on_failure("RETRY_OUTBOUND"); xinfo("[RETRY_OUTBOUND] <$ci> | Doing authentication with $dd"); uac_auth(); t_relay(); exit; } } if (next_routing()) { $avp(out_trunk) = $rd; # t_relay(); t_on_failure("RETRY_OUTBOUND"); t_relay(); exit; } } ``` running this code to those targets: - TRUNK 10.3.3.11 (invalid user/pass) - TRUNK 10.3.3.12 (correct user/pass) produce this output in logs: ``` INFO: [RETRY_OUTBOUND] <xxxx1xxx@10.3.3.11:5060> | Doing authentication with 10.3.3.10 INFO: uac [auth.c:450]: uac_auth_mode(): no credential for realm "10.3.3.11" INFO: [RETRY_OUTBOUND] <xxxx1yyyy@10.3.3.12:5060> | Doing authentication with 10.3.3.10 ``` but if I simply remove the first trunk those credential works on the second trunk. is like some stuff (like the $dd) is not cleaned up / refreshed? version: ``` version: kamailio 5.5.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 8.3.0 ``` running with drouting module to get next trunk -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3166 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3166(a)github.com>

2 years, 4 months

[kamailio/kamailio] Writing to $fU or $tU appends to header user (Issue #3165)

by Benoît Panizzon

Dear Gang Possibly @oej could provide more in-depth information as he has witnessed this issue. Usually the user of the from URI is the phone number displayed at the destination. There are situations where this phone number is translated. As example. In Switzerland, the user is used to see numbers in a local format. National number starting with 0 and international numbers with 00 but on interconnection between telcos, e164 is used. So basically when a call is sent to a customer '+41' is replaced by '0' and '+' is replaced by '00'. Let's start with an example From: header: `From: "Maurice Moss" <sip:+41991234567@example.com>;user=phone` So shortly before the call is sent out to the location of the registered CPE, this is done: ``` if ($fU =~ "^\+41") { $fU = "0" + $(fU{s.substr,3,0}); } else if ($fU = ~ "^\+") { $fU = "00" + $(fU{s.substr,1,0}); } ``` What is sent to the CPE now looks like this: `From: "Maurice Moss" <sip:0991234567@example.com>;user=phone` Now we hit an error like 486 BUSY and the destination has call forwarding active to a mobile phone on another TSP. So we have to send the call out back the IC and numbers need to be translated back to e164. We handle this in a failure route, which in turn could trigger a branch route. So we revert the number back to e164: `$fU = "+41" + $(fU{s.substr,1,0});` Expected outcome: `From: "Maurice Moss" <sip:+41991234567@example.com>;user=phone` Observed outcome: `From: "Maurice Moss" <sip:0991234567+41991234567@example.com>;user=phone` So setting $fU more than once is appending to the user element of the From header URI. This behavior has not been found in any documentation. I have been working around most of the issues by making sure I change $fU (and $tU) at the latest possible time and only once. But in the case described above, I have not been able to come up with a work-around yet. I also can't think of any benefit of the way those PV are handled or any harm that could be done, to handle them differently and make the last 'write' overwrite and previous value, instead of appending. Thank you for looking into this. -Benoît- -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3165 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3165(a)github.com>

2 years, 4 months

git:master:c170cc81: tls_wolfssl: make - use kamailio make infra vars

by S-P Chan

Module: kamailio Branch: master Commit: c170cc811b9a03383c07578f4b4c88e15b96b637 URL: https://github.com/kamailio/kamailio/commit/c170cc811b9a03383c07578f4b4c88e… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2022-06-27T21:50:20+08:00 tls_wolfssl: make - use kamailio make infra vars --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/c170cc811b9a03383c07578f4b4c88e… Patch: https://github.com/kamailio/kamailio/commit/c170cc811b9a03383c07578f4b4c88e… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 6dd9e1b770..687fe1a494 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -9,17 +9,13 @@ auto_gen= NAME=tls_wolfssl.so LIBS += lib/lib/libwolfssl.a -DEFS += -I./lib/include/ +INCLUDES += -I./lib/include/ include ../../Makefile.modules -SOURCES := $(shell ls *.c) -OBJECTS = $(SOURCES:.c=.o) -MOD_DIR := $(shell pwd) +$(objs): lib/include/wolfssl/options.h -$(OBJECTS): lib/lib/libwolfssl.a - -lib/lib/libwolfssl.a: +lib/include/wolfssl/options.h lib/lib/libwolfssl.a: @cd ./lib/wolfssl; \ if [ ! -f "configure" ]; then \ ./autogen.sh; \ @@ -28,9 +24,8 @@ lib/lib/libwolfssl.a: env -u DEFS -u CFLAGS -u LDFLAGS -u LIBS EXTRA_CFLAGS="-g -fPIC -Wno-error=array-bounds -Wno-error=stringop-overflow" ./configure \ --enable-all --enable-pkcs11 --enable-static --enable-aligndata=no \ --disable-shared --disable-examples \ - --prefix=$(MOD_DIR)/lib \ - --exec-prefix=$(MOD_DIR)/lib; \ - sed -i s/-Werror// Makefile; \ + --prefix=$(CURDIR)/lib \ + --exec-prefix=$(CURDIR)/lib; \ fi; @$(MAKE) -C ./lib/wolfssl install @@ -38,7 +33,7 @@ $(NAME): lib/lib/libwolfssl.a clean-wolfssl: @rm -rf ./lib/{bin,include,share,lib}; \ - cd ./lib/wolfssl; make clean || /bin/true + (cd ./lib/wolfssl; make distclean) || /bin/true clean-module: @rm -f *.o *.so @@ -46,3 +41,6 @@ clean-module: clean-all: clean-wolfssl clean-module .PHONY: clean-wolfssl clean-module clean-all + +# debugging for dependency on lib/wolfssl +$(warning sources = $(sources), auto_gen = $(auto_gen), objs = $(objs))

2 years, 4 months

git:master:fa6a2d79: ipops: added fixup free functions and use of ANY_ROUTE

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fa6a2d79aca3bc4733276ce99a53efd8fe63ffd5 URL: https://github.com/kamailio/kamailio/commit/fa6a2d79aca3bc4733276ce99a53efd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-25T14:48:35+02:00 ipops: added fixup free functions and use of ANY_ROUTE --- Modified: src/modules/ipops/ipops_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/fa6a2d79aca3bc4733276ce99a53efd… Patch: https://github.com/kamailio/kamailio/commit/fa6a2d79aca3bc4733276ce99a53efd…

2 years, 4 months

[kamailio/kamailio] detailed_ipv4_type func pkg memory leak. (Issue #3159)

by 杰哥

### Description when call detailed_ipv4_type function, pkg memory leak. ```c detailed_ipv4_type($si,"$var(iptype)"); ``` ### Troubleshooting #### Reproduction just call detailed_ipv4_type function. #### Debugging Data ``` ALERT: qm_sums: qm_sums(): count= 48161 size= 1789640 bytes from core: core/rvalue.c: rval_get_str(1293) ``` ### Possible Solutions ip address string not free in rval_get_str() function. [s->s=pkg_malloc(tmp.len+1/* 0 term */);](https://github.com/kamailio/kamailio/blob/1ddc27f199061025a6a43da3e8a1388fcaddfe19/src/core/rvalue.c#L1293) need call pkg_free() free memory. ### Additional Information test 3 version. ``` kamailio 5.5.4 kamailio 5.4.8 kamailio 5.3.9 ``` * **Operating System**: ``` buster 10 ubuntu 20.04 ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3159 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3159(a)github.com>

2 years, 5 months

← Newer
1
...
10
11
12
13
14
15
16
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2022