sr-dev June 2022

sr-dev@lists.kamailio.org

20 participants
281 discussions

[kamailio/kamailio] ppcfg: add values to log to better tell the problem (PR #3151)

by Seven Du

#### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3151 -- Commit Summary -- * ppcfg: add values to log to better tell the problem -- File Changes -- M src/core/ppcfg.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3151.patch https://github.com/kamailio/kamailio/pull/3151.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3151 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3151(a)github.com>

2 years, 5 months

git:master:67901854: ppcfg: add values to log to better tell the problem

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6790185478ba96ebb0626846386b28aea15dcce8 URL: https://github.com/kamailio/kamailio/commit/6790185478ba96ebb0626846386b28a… Author: Seven Du <dujinfang(a)x-y-t.cn> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-06-21T08:19:08+02:00 ppcfg: add values to log to better tell the problem --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/6790185478ba96ebb0626846386b28a… Patch: https://github.com/kamailio/kamailio/commit/6790185478ba96ebb0626846386b28a… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index 3d91679df6..5a85a4007c 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -54,7 +54,7 @@ int pp_def_qvalue(str *defval, str *outval) str_list_t *sb; if(pv_get_buffer_size() < defval->len + 4) { - LM_ERR("defined value is too large\n"); + LM_ERR("defined value is too large %d < %d\n", pv_get_buffer_size(), defval->len + 4); return -1; } newval.s = pv_get_buffer();

2 years, 5 months

git:master:20d0b221: tls_wolfssl: memory handling cleanup

by S-P Chan

Module: kamailio Branch: master Commit: 20d0b2211ef6023149c4dd1cdcaf23d0edf42846 URL: https://github.com/kamailio/kamailio/commit/20d0b2211ef6023149c4dd1cdcaf23d… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2022-06-21T08:19:50+08:00 tls_wolfssl: memory handling cleanup Set memory allocators to align up to 16-bytes --- Modified: src/modules/tls_wolfssl/tls_init.c Modified: src/modules/tls_wolfssl/tls_server.c --- Diff: https://github.com/kamailio/kamailio/commit/20d0b2211ef6023149c4dd1cdcaf23d… Patch: https://github.com/kamailio/kamailio/commit/20d0b2211ef6023149c4dd1cdcaf23d…

2 years, 5 months

git:master:1affa052: benchmark: use common error logging defines for memory allocation problems

by Henning Westerholt

Module: kamailio Branch: master Commit: 1affa052deb00885156c33538d081647d44e53d5 URL: https://github.com/kamailio/kamailio/commit/1affa052deb00885156c33538d08164… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-06-20T17:22:38Z benchmark: use common error logging defines for memory allocation problems --- Modified: src/modules/benchmark/benchmark.c --- Diff: https://github.com/kamailio/kamailio/commit/1affa052deb00885156c33538d08164… Patch: https://github.com/kamailio/kamailio/commit/1affa052deb00885156c33538d08164… --- diff --git a/src/modules/benchmark/benchmark.c b/src/modules/benchmark/benchmark.c index a1d5f63ef0..cb1e288be1 100644 --- a/src/modules/benchmark/benchmark.c +++ b/src/modules/benchmark/benchmark.c @@ -220,7 +220,7 @@ static int bm_init_mycfg(void) } bm_mycfg = (bm_cfg_t*)shm_malloc(sizeof(bm_cfg_t)); if(bm_mycfg==NULL) { - LM_ERR("failed to allocated shared memory\n"); + SHM_MEM_ERROR; return -1; } memset(bm_mycfg, 0, sizeof(bm_cfg_t)); @@ -407,7 +407,7 @@ int _bm_register_timer(char *tname, int mode, unsigned int *id) if(bmt==0) { - LM_ERR("no more shm\n"); + SHM_MEM_ERROR; return -1; } memset(bmt, 0, sizeof(benchmark_timer_t)); @@ -417,7 +417,7 @@ int _bm_register_timer(char *tname, int mode, unsigned int *id) if(bmt->start == NULL) { shm_free(bmt); - LM_ERR("no more pkg\n"); + PKG_MEM_ERROR; return -1; } memset(bmt->start, 0, sizeof(bm_timeval_t)); @@ -442,7 +442,7 @@ int _bm_register_timer(char *tname, int mode, unsigned int *id) sizeof(benchmark_timer_t*)); if(bm_mycfg->tindex==0) { - LM_ERR("no more share memory\n"); + SHM_MEM_ERROR; if(tidx!=0) shm_free(tidx); return -1;

2 years, 5 months

[kamailio/kamailio] benchmark: Fix debug level for registered timer (PR #3150)

by Mvondo Eric

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  Fix debug level for registered timer to DBG instead of ERR You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3150 -- Commit Summary -- * benchmark: Fix debug level for registered timer -- File Changes -- M src/modules/benchmark/benchmark.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3150.patch https://github.com/kamailio/kamailio/pull/3150.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3150 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3150(a)github.com>

2 years, 5 months

git:master:0b2942e1: benchmark: use INFO log level for timer registration (related to GH #3150)

by Henning Westerholt

Module: kamailio Branch: master Commit: 0b2942e1dfe6cd84f97d62f6b4fccc86e5802eff URL: https://github.com/kamailio/kamailio/commit/0b2942e1dfe6cd84f97d62f6b4fccc8… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-06-20T17:19:55Z benchmark: use INFO log level for timer registration (related to GH #3150) --- Modified: src/modules/benchmark/benchmark.c --- Diff: https://github.com/kamailio/kamailio/commit/0b2942e1dfe6cd84f97d62f6b4fccc8… Patch: https://github.com/kamailio/kamailio/commit/0b2942e1dfe6cd84f97d62f6b4fccc8… --- diff --git a/src/modules/benchmark/benchmark.c b/src/modules/benchmark/benchmark.c index fb60513f45a..a1d5f63ef0e 100644 --- a/src/modules/benchmark/benchmark.c +++ b/src/modules/benchmark/benchmark.c @@ -474,7 +474,7 @@ int bm_register_timer_param(modparam_t type, void* val) LM_ERR("cannot find timer [%s]\n", (char*)val); return -1; } - LM_ERR("timer [%s] registered: %u\n", (char*)val, tid); + LM_INFO("timer [%s] registered: %u\n", (char*)val, tid); return 0; }

2 years, 5 months

[kamailio/kamailio] nats: fix the nats:connected event_route not being triggered on a successful connect (PR #3153)

by Seven Du

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  according to nats docs: http://nats-io.github.io/nats.c/group__opts_group.html#ga20946800d024b7089e… If [natsConnection_Connect()](http://nats-io.github.io/nats.c/group__conn_mgt_group.html#ga740be1ba16a8570eb98ef6755ebf52ce) returns NATS_OK (that is, a connection to a NATS Server was established in that call), then the connectedCb callback will not be invoked. this patch fixes it by manually call the callback function. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3153 -- Commit Summary -- * nats: fix the nats:connected event_route not being triggered on a successful connect -- File Changes -- M src/modules/nats/nats_mod.c (3) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3153.patch https://github.com/kamailio/kamailio/pull/3153.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3153 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3153(a)github.com>

2 years, 5 months

git:master:b3c8329c: nats: fix the nats:connected event_route not being triggered on a successful connect

by Henning Westerholt

Module: kamailio Branch: master Commit: b3c8329cfbfa19613dfbadaea7f220443dbb7f55 URL: https://github.com/kamailio/kamailio/commit/b3c8329cfbfa19613dfbadaea7f2204… Author: Seven Du <dujinfang(a)x-y-t.cn> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2022-06-20T19:16:13+02:00 nats: fix the nats:connected event_route not being triggered on a successful connect --- Modified: src/modules/nats/nats_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/b3c8329cfbfa19613dfbadaea7f2204… Patch: https://github.com/kamailio/kamailio/commit/b3c8329cfbfa19613dfbadaea7f2204… --- diff --git a/src/modules/nats/nats_mod.c b/src/modules/nats/nats_mod.c index 2a53beda82f..6108d555e81 100644 --- a/src/modules/nats/nats_mod.c +++ b/src/modules/nats/nats_mod.c @@ -298,7 +298,10 @@ int _nats_pub_worker_proc( != NATS_OK) { LM_ERR("could not connect to nats servers [%s]\n", natsStatus_GetText(s)); + } else { + connectedCB(worker->nc->conn, NULL); } + s = natsOptions_SetEventLoop(worker->nc->opts, (void *)worker->uvLoop, natsLibuv_Attach, natsLibuv_Read, natsLibuv_Write, natsLibuv_Detach);

2 years, 5 months

[kamailio/kamailio] ims_registrar_scscf: 200OK changes according to RFC3261 (PR #3146)

by alexyosifov

Added corrections for 200OK reply on Re-Registration according to RFC3261 - registrar respond with multiple bindings in case of multiple bindings. Added a new parameter skip_multiple_bindings_on_reg_resp for 200OK reply used for Re-Registration. Default value is 0. If set to 1 - registrar replies only with current contact, not with multiple bindings.   #### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3146 -- Commit Summary -- * ims_registrar_scscf: 200OK changes according to RFC3261 -- File Changes -- M src/modules/ims_registrar_scscf/doc/ims_registrar_scscf_admin.xml (20) M src/modules/ims_registrar_scscf/ims_registrar_scscf_mod.c (2) M src/modules/ims_registrar_scscf/save.c (5) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3146.patch https://github.com/kamailio/kamailio/pull/3146.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3146 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3146(a)github.com>

2 years, 5 months

- ims_registrar_scscf: fix multiple contacts in 200OK

by Scherney Theodor

Dear developer, we have a question about the reasons of the changes made in this commit to Kamailio module ims_registrar_scscf commit 23341c60519bd3e8eb91974c7aca0b283735665e Author: Aleksandar Yosifov alexyosifov(a)gmail.com Date: Thu May 7 15:51:34 2020 +0300 ims_registrar_scscf: fix multiple contacts in 200OK - Prevent sending of multiple contacts in 200OK reply for UE Re-Registration. Now S-CSCF replies with the exact contact for Re-Registration. We read in Section 10.3 "Processing REGISTER Requests" of the RFC3261 ( https://datatracker.ietf.org/doc/html/rfc3261#section-10.3 ) : 8. The registrar returns a 200 (OK) response. The response MUST contain Contact header field values enumerating all current bindings. We have a test case where for one single IMPU there are two different consecutive REGISTER using different combination of IP/port. Running our testcase on a version previous your commit, the 200OK of the second registration lists 2 bindings (correctly, as we expect by the RFC). After your commit, in this testcase, the 200OK lists only one binding. It seems that the changes in your commit do not match the RFC specifications. Can you please explain why these changes have been made? Thanks and Kind Regards,

2 years, 5 months

← Newer
1
...
15
16
17
18
19
20
21
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev June 2022