sr-dev September 2022

sr-dev@lists.kamailio.org

16 participants
275 discussions

[kamailio/kamailio] rtpengine module added receive-from option to flags to managing rtpengine by a kamailio node behind dispatcher (PR #3230)

by toharish

Add receive-from option to flags receive-from=1.2.3.4 required for managing rtpengine by a kamailio node behind a dispatcher kamailio node  UE behind NAT --------------->Dispatcher Kamailio--------> Location & Media managementKamailio ---------------> C5 SoftSwitch | | | V | RTPENGINE | |---------------------------->Location & Media management Kamailio ---------------> C5 SoftSwitch | V RTPENGINE In this scenario when the Kamailio behind the Dispatcher will be getting the $Ri as dispatcher IP and by default that will be passed to RTP Engine for NAT negotiation which will fail. In this pull merge requst, RTP engine module a new flag is added receive-from=IP which is supposed to be the received IP from the First node through P-Accessnetwork-Info header or the contact recived tag etc..  #### Pre-Submission Checklist    - [ ] Commit message has the format required by CONTRIBUTING guide - [ ] Commits are split per component (core, individual modules, libs, utils, ...) - [ ] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3230 -- Commit Summary -- * Add receive-from option -- File Changes -- M src/modules/rtpengine/rtpengine.c (47) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3230.patch https://github.com/kamailio/kamailio/pull/3230.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3230 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3230(a)github.com>

2 years

git:master:74501044: rtpengine: added receive-from option (#3230)

by GitHub

Module: kamailio Branch: master Commit: 745010442f0a7298d8b4576cdebfe5f5b664c102 URL: https://github.com/kamailio/kamailio/commit/745010442f0a7298d8b4576cdebfe5f… Author: toharish <toharishs(a)gmail.com> Committer: GitHub <noreply(a)github.com> Date: 2022-09-07T17:34:41-04:00 rtpengine: added receive-from option (#3230) - Add receive-from option to flags - receive-from=1.2.3.4 - required for manageing rtpengine by a kamailio node behind a dispatcher kamailio node - add received-from option in Document --- Modified: src/modules/rtpengine/doc/rtpengine_admin.xml Modified: src/modules/rtpengine/rtpengine.c --- Diff: https://github.com/kamailio/kamailio/commit/745010442f0a7298d8b4576cdebfe5f… Patch: https://github.com/kamailio/kamailio/commit/745010442f0a7298d8b4576cdebfe5f…

2 years

[kamailio/kamailio] [presence] `active_watchers` entries not removed on timeout or expiration. (Issue #3074)

by Mike Moore

### Description  When handling a `PUBLISH` we call [handle_publish()](https://kamailio.org/docs/modules/5.5.x/modules/presence.… and `NOTIFY`s are sent to all of the corresponding `active_watchers` (as expected). However, when `NOTIFY`s timeout (`408`), we're seeing that the corresponding entries in the `active_watchers` table are _not_ being deleted as expected. Furthermore, we've noticed that `NOTIFY`s are being sent to `active_watchers` which are expired (i.e. `expires < UNIX_TIMESTAMP()`) and when we run `kamcmd presence.cleanup`, no expired entries are removed from the `active_watchers` table. We suspect that all of these things might be related--the common theme being that records aren't deleted when expected. ### Troubleshooting #### Reproduction  In our setup, we're using Kamailio as a "presence server" (via the [presence](https://kamailio.org/docs/modules/5.5.x/modules/presence.html), [presence_dialoginfo](https://kamailio.org/docs/modules/5.5.x/modules/presen…, and [presence_xml](https://kamailio.org/docs/modules/5.5.x/modules/presence_xml.… modules). We're using [`subs_db_mode`](https://kamailio.org/docs/modules/5.5.x/modules/presence.html#presence.p.subs_db_mode) `3` (DB-only scheme) and we have multiple Kamailio instances connected to a shared database (MySQL `8.0.27`). Everything seems to be working as expected. However, as we accumulated stale entries in the `active_watchers` table we're finding that we're wasting more and more time on sending `NOTIFY`s to black holes. We're generating a _lot_ of traffic and waiting for the timeouts to hit is causing memory issues and backups. Here are the relevant portions of our `kamailio.cfg` file: ``` # ----- presence params ----- modparam("presence", "db_table_lock_type", 0) # Disable locking; MySQL has issues with this is enabled. modparam("presence", "db_update_period", -1) # Disable synchronization. modparam("presence", "db_url", PRESENCE_DB_URL) modparam("presence", "expires_offset", 60) # Force the client to send an UPDATE before the old PUBLISH expires. modparam("presence", "max_expires", 1800) modparam("presence", "min_expires", 1700) modparam("presence", "publ_cache", 0) # Disable the PUBLISH cache since the database is shared. modparam("presence", "server_address", "sip:$CLUSTER_DOMAIN_NAME:5060") # This becomes the value of the Contact header. modparam("presence", "sip_uri_match", 1) # Use case insensitive URI matching. modparam("presence", "subs_db_mode", 3) # Database-only scheme; everything is stored in the database. modparam("presence", "notifier_processes", 0) # Caution! Under load a race condition can cause CSeq's to be reused. modparam("presence", "timeout_rm_subs", 1) # ----- presence_dialoginfo params ----- modparam("presence_dialoginfo", "force_single_dialog", 1) # Maybe not all phones support multiple "dialog" elements? modparam("presence_dialoginfo", "force_dummy_dialog", 1) # Maybe not all phones support a null body? # ----- presence_xml params ----- modparam("presence_xml", "db_url", PRESENCE_DB_URL) modparam("presence_xml", "force_active", 1) # Skip permission/XCAP checks. modparam("presence_xml", "force_dummy_presence", 1) # Default to a simple "open" status when presentity info is unavailable. # ... route[PRESENCE] { if (!is_method("PUBLISH|SUBSCRIBE")) { return; } if (!t_newtran()) { sl_reply_error(); exit; } if (is_method("PUBLISH")) { handle_publish(); t_release(); } else if (is_method("SUBSCRIBE")) { handle_subscribe(); t_release(); } exit; } ``` #### SIP Traffic  Here's a somewhat sanitized example (the message seems OK to us; however, the `Subscription-State: terminated; reason=timeout` does make us wonder--do we as the sender _know_ that the client is terminated/timed-out?): ``` 2022/04/05 21:09:55.209846 10.21.3.12:5060 -> 10.31.0.226:6060 NOTIFY sip:SomeUser@192.168.86.24:54639;alias=123.21.125.232~54639~1 SIP/2.0 Via: SIP/2.0/UDP presence-w.staging.internal:5060;branch=z9hG4bK43ea.648a1952000000000000000000000000.0 To: <sip:SomeOtherUser@9bfadf66-a77b-6a69-25f3-02d96d4aa946>;tag=2607596073 From: <sip:SomeUser@9bfadf66-a77b-6a69-25f3-02d96d4aa946>;tag=69309ea83adcd977af8788878e9f31b3-42e32342 CSeq: 66 NOTIFY Call-ID: 0_2607659559(a)192.168.86.24 Route: <sip:10.31.0.226:6060;r2=on;lr;ftag=2607596073>, <sip:55.8.122.110;r2=on;lr;ftag=2607596073> Content-Length: 710 Max-Forwards: 70 Event: dialog Contact: <sip:presence-w.staging.internal:5060> Subscription-State: terminated;reason=timeout Content-Type: application/dialog-info+xml <?xml version="1.0"?> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="66" state="full" entity="sip:SomeUser@9bfadf66-a77b-6a69-25f3-02d96d4aa946"> <dialog id="0_1364146118(a)192.168.1.244" call-id="0_1364146118(a)192.168.1.244" direction="initiator"> <state>confirmed</state> <remote> <identity>sip:4355558565@9bfadf66-a77b-6a69-25f3-02d96d4aa945:5060</identity> <target uri="sip:4355558565@9bfadf66-a77b-6a69-25f3-02d96d4aa946:5060"/> </remote> <local> <identity>sip:SomeUser@9bfadf66-a77b-6a69-25f3-02d96d4aa946:5060</identity> <target uri="sip:SomeUser@123.130.50.202:58872"/> </local> </dialog> </dialog-info> ``` ### Possible Solutions  We didn't see any functions in the `presence` module that we could call directly to clean things up. One thought we had was to manually run some database commands from `event_route[presence:notify-reply]` (or in a `reply_route`). We've noticed that once the problematic entries are manually removed from the database that we no longer attempt to send `NOTIFY`s to the defunct destinations. ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` version: kamailio 5.5.4 (x86_64/linux) flags: USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLOCKLIST, HAVE_RESOLV_RES, TLS_PTHREAD_MUTEX_SHARED ADAPTIVE_WAIT_LOOPS 1024, MAX_RECV_BUFFER_SIZE 262144, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: unknown compiled with gcc 10.2.1 ``` * **Operating System**:  ``` $ lsb_release -a No LSB modules are available. Distributor ID: Debian Description: Debian GNU/Linux 11 (bullseye) Release: 11 Codename: bullseye $ uname -a Linux ip-10-21-3-12 5.10.0-13-cloud-amd64 #1 SMP Debian 5.10.106-1 (2022-03-17) x86_64 GNU/Linux ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3074 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3074(a)github.com>

2 years

[kamailio/kamailio] 5.5.1 crash processing INVITE and CANCEL at almost the same time (Issue #3156)

by Victor Seva

### Description While a INVITE is been processed the CANCEL of that transaction is been processed in other process almost at the same time ### Troubleshooting #### Reproduction Quite difficult to reproduce I would say #### Debugging Data ``` Reading symbols from /usr/sbin/kamailio... Reading symbols from /usr/lib/debug/.build-id/e3/9bd8ad0900c980149b00579cce26035c9cb118.debug... warning: Can't open file /dev/zero (deleted) during file-backed mapping note processing [New LWP 4136750] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/usr/sbin/kamailio -P /run/kamailio/kamailio.proxy.pid -f /etc/kamailio/proxy/k'. Program terminated with signal SIGSEGV, Segmentation fault. #0 atomic_dec_and_test_int (var=0x20) at ../../core/parser/../mem/../atomic/atomic_x86.h:222 222 ../../core/parser/../mem/../atomic/atomic_x86.h: No such file or directory. (gdb) backtrace #0 atomic_dec_and_test_int (var=0x20) at ../../core/parser/../mem/../atomic/atomic_x86.h:222 0000001 t_unref (p_msg=<optimized out>) at t_lookup.c:1514 #2 0x000055eee962d69b in exec_post_script_cb (msg=msg@entry=0x7f7e265822c8, type=type@entry=REQUEST_CB_TYPE) at core/script_cb.c:182 0000003 0x000055eee95dfcbe in receive_msg ( buf=buf@entry=0x55eee9a00740 <buf> "INVITE sip:...@fake.dom:5060;transport=udp SIP/2.0\r\nRecord- Route: <sip:X.X.X.X;r2=on;lr=on;ftag=1E7F0816-6299BCF10003883E-7FFFF700;ngcplb=yes;socket=udp:Y.Y.Y.Y:5060>\r \nRe"..., len=<optimized out>, rcv_info=rcv_info@entry=0x7ffc96d12af0) at core/receive.c:520 #4 0x000055eee96d4c40 in udp_rcv_loop () at core/udp_server.c:543 #5 0x000055eee94db634 in main_loop () at main.c:1730 #6 0x000055eee94d2d2c in main (argc=<optimized out>, argv=<optimized out>) at main.c:3053 ``` #### Log Messages Notice that both messages came in the same second ( IPs and numbers have been changed ) ``` Jun 3 09:49:05 sipwise2-prx03a proxy[4136750]: NOTICE: DEFAULT_ROUTE <script>: New request on proxy - M=INVITE R=«sip:+49......@X.X.X.X :5060;transport=udp» F=«sip:+49...@fake.dom» T=«sip:+49...@Y.Y.Y.Z» IP=«Y.Y.Y.Z»:«5060» («Y.Y.Y.Y»:«5060») ID=«31668-TN-030322e6-0904f8ba1(a)fake.xn--dom_b2b-1-era UA='Cirpack/v4.88 (gw_sip)' DESTIP=«Y.Y.Y.G»:«5062» ``` ``` Jun 3 09:49:05 sipwise2-prx03a proxy[4136755]: NOTICE: DEFAULT_ROUTE <script>: New request on proxy - M=CANCEL R=«sip:+49...@X.X.X.X :5060;transport=udp» F=«sip:+49...@fake.dom» T=«sip:+49...@Y.Y.Y.Z» IP=«Y.Y.Y.Y»:«5060» («Y.Y.Y.Y»:«5060 ») ID=«31668-TN-030322e6-0904f8ba1(a)fake.xn--dom_b2b-1-era UA='<null>' DESTIP=«Z.Z.Z.Z»:«5062» Jun 3 09:49:05 sipwise2-prx03a proxy[4136755]: NOTICE: DEFAULT_ROUTE <script>: Sending reply S=100 Trying M=CANCEL fs='«Z.Z.Z.Z»:«5062»' du ='«Y.Y.Y.Y»:«5060»' - R=«sip:+49...@X.X.X.X:5060;transport=udp» ID=«31668-TN-030322e6-0904f8ba1(a)fake.xn--dom_b2b-1-era UA='<n ull>' ``` ### Additional Information This is the Sipwise flavor 5.5.1-1+0~mr9.5.3.2 -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3156 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3156(a)github.com>

2 years

git:master:2c622a61: core: define OS_NAME at startup

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2c622a6183dab5c5f50c8d46436bed014eae1146 URL: https://github.com/kamailio/kamailio/commit/2c622a6183dab5c5f50c8d46436bed0… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-06T09:16:53+02:00 core: define OS_NAME at startup --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/2c622a6183dab5c5f50c8d46436bed0… Patch: https://github.com/kamailio/kamailio/commit/2c622a6183dab5c5f50c8d46436bed0… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index cfb70dc02e..34f1c224fb 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -354,6 +354,15 @@ void pp_define_core(void) LM_ERR("error setting version define value\n"); return; } + + if(pp_define(strlen("OS_NAME"), "OS_NAME")<0) { + LM_ERR("unable to set cfg define OS_NAME\n"); + return; + } + if(pp_define_set(strlen(OS_QUOTED), OS_QUOTED, KSR_PPDEF_NORMAL)<0) { + LM_ERR("error setting OS_NAME define value\n"); + return; + } } /* vi: set ts=4 sw=4 tw=79:ai:cindent: */

2 years

git:master:05694d88: core: define KAMAILIO_VERSION with VERSION number value

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 05694d88e3e697417be12e269511b0711404656b URL: https://github.com/kamailio/kamailio/commit/05694d88e3e697417be12e269511b07… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-05T13:06:45+02:00 core: define KAMAILIO_VERSION with VERSION number value --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/05694d88e3e697417be12e269511b07… Patch: https://github.com/kamailio/kamailio/commit/05694d88e3e697417be12e269511b07… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index e92cc872a8..cfb70dc02e 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -289,6 +289,7 @@ void pp_define_core(void) char defval[64]; char *p; int n; + str_list_t *sb; strcpy(defval, NAME); p = defval; @@ -331,6 +332,28 @@ void pp_define_core(void) LM_ERR("unable to set cfg define: %s\n", defval); return; } + + strcpy(p, "_VERSION"); + pp_define_set_type(0); + if(pp_define(strlen(defval), defval)<0) { + LM_ERR("unable to set cfg define: %s\n", defval); + return; + } + + n = snprintf(defval, 64, "%u", VERSIONVAL); + if(n<0 || n>=64) { + LM_ERR("failed to build version define value\n"); + return; + } + sb = str_list_block_add(&_ksr_substdef_strlist, defval, strlen(defval)); + if(sb==NULL) { + LM_ERR("failed to store version define value\n"); + return; + } + if(pp_define_set(sb->s.len, sb->s.s, KSR_PPDEF_NORMAL)<0) { + LM_ERR("error setting version define value\n"); + return; + } } /* vi: set ts=4 sw=4 tw=79:ai:cindent: */

2 years

git:master:3e94dd4b: core: use unsigned printing for version defines

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3e94dd4bd3901d503c7be655d761f1d70453a451 URL: https://github.com/kamailio/kamailio/commit/3e94dd4bd3901d503c7be655d761f1d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-05T10:24:06+02:00 core: use unsigned printing for version defines --- Modified: src/core/ppcfg.c --- Diff: https://github.com/kamailio/kamailio/commit/3e94dd4bd3901d503c7be655d761f1d… Patch: https://github.com/kamailio/kamailio/commit/3e94dd4bd3901d503c7be655d761f1d… --- diff --git a/src/core/ppcfg.c b/src/core/ppcfg.c index 5a85a4007c..e92cc872a8 100644 --- a/src/core/ppcfg.c +++ b/src/core/ppcfg.c @@ -297,7 +297,7 @@ void pp_define_core(void) p++; } - n = snprintf(p, 64 - (int)(p-defval), "_%d", VERSIONVAL/1000000); + n = snprintf(p, 64 - (int)(p-defval), "_%u", VERSIONVAL/1000000); if(n<0 || n>=64 - (int)(p-defval)) { LM_ERR("failed to build define token\n"); return; @@ -308,7 +308,7 @@ void pp_define_core(void) return; } - n = snprintf(p, 64 - (int)(p-defval), "_%d_%d", VERSIONVAL/1000000, + n = snprintf(p, 64 - (int)(p-defval), "_%u_%u", VERSIONVAL/1000000, (VERSIONVAL%1000000)/1000); if(n<0 || n>=64 - (int)(p-defval)) { LM_ERR("failed to build define token\n"); @@ -320,7 +320,7 @@ void pp_define_core(void) return; } - n = snprintf(p, 64 - (int)(p-defval), "_%d_%d_%d", VERSIONVAL/1000000, + n = snprintf(p, 64 - (int)(p-defval), "_%u_%u_%u", VERSIONVAL/1000000, (VERSIONVAL%1000000)/1000, VERSIONVAL%1000); if(n<0 || n>=64 - (int)(p-defval)) { LM_ERR("failed to build define token\n");

2 years

git:master:d4670ed5: pua_dialoginfo: safety check for request pointer

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: d4670ed58fb6e4325d5e3782f344237f8da5b70f URL: https://github.com/kamailio/kamailio/commit/d4670ed58fb6e4325d5e3782f344237… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-05T08:31:51+02:00 pua_dialoginfo: safety check for request pointer --- Modified: src/modules/pua_dialoginfo/pua_dialoginfo.c --- Diff: https://github.com/kamailio/kamailio/commit/d4670ed58fb6e4325d5e3782f344237… Patch: https://github.com/kamailio/kamailio/commit/d4670ed58fb6e4325d5e3782f344237… --- diff --git a/src/modules/pua_dialoginfo/pua_dialoginfo.c b/src/modules/pua_dialoginfo/pua_dialoginfo.c index a1953ef238..10aa5b467d 100644 --- a/src/modules/pua_dialoginfo/pua_dialoginfo.c +++ b/src/modules/pua_dialoginfo/pua_dialoginfo.c @@ -364,7 +364,8 @@ __dialog_sendpublish(struct dlg_cell *dlg, int type, struct dlg_cb_params *_para } if(use_pubruri_avps && (refresh_pubruri_avps_flag > -1 - || (request->flags & (1U<<(unsigned int)refresh_pubruri_avps_flag)))) + || (request + && (request->flags & (1U<<(unsigned int)refresh_pubruri_avps_flag))))) { lock_get(&dlginfo->lock); refresh_pubruri_avps(dlginfo, &uri);

2 years

git:master:f5c98a49: core: support to specify options for load module

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: f5c98a49c98aedcf6e1afec3c42dd862d0eeb9a3 URL: https://github.com/kamailio/kamailio/commit/f5c98a49c98aedcf6e1afec3c42dd86… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-02T13:15:35+02:00 core: support to specify options for load module - prototypes: loadmodule("path", "options") loadmodulex("path", "options") - options is a string with characters: - 'g' or 'G' - open the module shared object file with RTLD_GLOBAL set, wich can be used for modules related to external scripting languages to avoid reloading - example: loadmodule("app_lua", "g") --- Modified: src/core/cfg.y Modified: src/core/sr_module.c Modified: src/core/sr_module.h Modified: src/main.c --- Diff: https://github.com/kamailio/kamailio/commit/f5c98a49c98aedcf6e1afec3c42dd86… Patch: https://github.com/kamailio/kamailio/commit/f5c98a49c98aedcf6e1afec3c42dd86…

2 years

git:master:43f764ca: core: kemi - duplicate module name when registering the api exports

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 43f764cae870b15a96b8ca88f1eb195d4ceb8455 URL: https://github.com/kamailio/kamailio/commit/43f764cae870b15a96b8ca88f1eb195… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2022-09-02T12:50:56+02:00 core: kemi - duplicate module name when registering the api exports --- Modified: src/core/kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/43f764cae870b15a96b8ca88f1eb195… Patch: https://github.com/kamailio/kamailio/commit/43f764cae870b15a96b8ca88f1eb195… --- diff --git a/src/core/kemi.c b/src/core/kemi.c index 13428d4a43..d6716507b3 100644 --- a/src/core/kemi.c +++ b/src/core/kemi.c @@ -3396,7 +3396,12 @@ int sr_kemi_modules_add(sr_kemi_t *klist) _sr_kemi_modules[_sr_kemi_modules_size-1].kexp = klist; } else { LM_DBG("adding module: %.*s\n", klist[0].mname.len, klist[0].mname.s); - _sr_kemi_modules[_sr_kemi_modules_size].mname = klist[0].mname; + if(pkg_str_dup(&_sr_kemi_modules[_sr_kemi_modules_size].mname, + &klist[0].mname)<0) { + LM_ERR("failed to clone module name: %.*s\n", klist[0].mname.len, + klist[0].mname.s); + return -1; + } _sr_kemi_modules[_sr_kemi_modules_size].kexp = klist; _sr_kemi_modules_size++; }

2 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev September 2022