sr-dev January 2023

sr-dev@lists.kamailio.org

14 participants
280 discussions

[kamailio/kamailio] Custom Headers are not forwarding on CANCEL Request to downstream (Issue #3326)
by HimaBinduGrg 10 Jan '23

10 Jan '23

### Description When we send any custom header in the CANCEL Request.. same request is not forwarding to the down stream. Custom Header are missing in th request which is received by the downstream. We are using t_relay() to forwards the request. Please let me know if any parameters are required to be enabled for this issue.  ### Troubleshooting #### Reproduction  #### Debugging Data  ``` (paste your debugging data here) ``` #### Log Messages  ``` (paste your log messages here) ``` #### SIP Traffic  Upstream CANCEL Request Sent ---------------------------------------------- Session Initiation Protocol (CANCEL) Request-Line: CANCEL sip:inbound@192.168.2.200:5060;transport=UDP SIP/2.0 Message Header Via: SIP/2.0/UDP 192.168.2.192:8000;branch=z9hG4bK-25588-1-0 From: <sip:inbound@192.168.2.192:8000>;tag=1 To: <sip:inbound@192.168.2.200:5060;user=phone> Call-ID: 1-25588(a)192.168.2.192 [Generated Call-ID: 1-25588(a)192.168.2.192] CSeq: 1 CANCEL Max-Forwards: 70 Session-ID: 357f74433c5454178cde3d5278b40ec6 User-Agent: A175 Collaboration Tablet Content-Length: 0 Down Stream CANCEL Request received ---------------------------------------------------- Session Initiation Protocol (CANCEL) Request-Line: CANCEL sip:inbound@192.168.2.200:5060;transport=UDP SIP/2.0 Message Header From: <sip:inbound@192.168.2.192:8000>;tag=1 To: <sip:inbound@192.168.2.200:5060;user=phone> Call-ID: 1-25588(a)192.168.2.192 [Generated Call-ID: 1-25588(a)192.168.2.192] CSeq: 1 CANCEL Via: SIP/2.0/UDP 192.168.1.200;branch=z9hG4bK561f.944ad825d740820aeb834f49c3cea1b7.0;rport Max-Forwards: 69 Content-Length: 0 ``` (paste your sip traffic here) ``` ### Possible Solutions  ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` (paste your output here) ``` * **Operating System**:  ``` (paste your output here) ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3326 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3326(a)github.com>

2 2

git:master:f9d45fee: pkg/kamailio/deb: version set 5.7.0~dev3 [skip ci]
by Victor Seva 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: f9d45feec21efa77b7c5b5957f896732e486580e URL: https://github.com/kamailio/kamailio/commit/f9d45feec21efa77b7c5b5957f89673… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-01-10T14:08:38+01:00 pkg/kamailio/deb: version set 5.7.0~dev3 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/f9d45feec21efa77b7c5b5957f89673… Patch: https://github.com/kamailio/kamailio/commit/f9d45feec21efa77b7c5b5957f89673…

1 0

git:master:c9e33ad7: Makefile.defs: version set to 5.7.0-dev3
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: c9e33ad739e4cf3ded314e86d231b2265e7ab775 URL: https://github.com/kamailio/kamailio/commit/c9e33ad739e4cf3ded314e86d231b22… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:48:24+01:00 Makefile.defs: version set to 5.7.0-dev3 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/c9e33ad739e4cf3ded314e86d231b22… Patch: https://github.com/kamailio/kamailio/commit/c9e33ad739e4cf3ded314e86d231b22… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index cb41c11227..48a2bb275c 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 7 SUBLEVEL = 0 -EXTRAVERSION = -dev2 +EXTRAVERSION = -dev3 # memory manager switcher # 0 - f_malloc (fast malloc)

1 0

git:master:f717c142: app_python3s: use local var to avoid overlapping values when casting
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: f717c142b0184b5785c9ff1b128868f7b7814136 URL: https://github.com/kamailio/kamailio/commit/f717c142b0184b5785c9ff1b128868f… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:46:58+01:00 app_python3s: use local var to avoid overlapping values when casting --- Modified: src/modules/app_python3s/apy3s_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/f717c142b0184b5785c9ff1b128868f… Patch: https://github.com/kamailio/kamailio/commit/f717c142b0184b5785c9ff1b128868f… --- diff --git a/src/modules/app_python3s/apy3s_kemi.c b/src/modules/app_python3s/apy3s_kemi.c index e00eadd810..7003a9f17b 100644 --- a/src/modules/app_python3s/apy3s_kemi.c +++ b/src/modules/app_python3s/apy3s_kemi.c @@ -423,7 +423,8 @@ PyObject *sr_apy_kemi_exec_func_ex(sr_kemi_t *ket, PyObject *self, PyObject *arg } if(ket->ptypes[i]==SR_KEMIP_INT) { vps[i].vtype = SR_KEMIP_INT; - vps[i].v.n = (int)vps[i].v.l; + ret = (int)vps[i].v.l; + vps[i].v.n = ret; } else { vps[i].vtype = SR_KEMIP_LONG; }

1 0

git:master:9142d589: app_python3: use local var to avoid overlapping values when casting
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: 9142d58906eb9327a24290737b833d79dc2d605c URL: https://github.com/kamailio/kamailio/commit/9142d58906eb9327a24290737b833d7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:46:48+01:00 app_python3: use local var to avoid overlapping values when casting --- Modified: src/modules/app_python3/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/9142d58906eb9327a24290737b833d7… Patch: https://github.com/kamailio/kamailio/commit/9142d58906eb9327a24290737b833d7… --- diff --git a/src/modules/app_python3/apy_kemi.c b/src/modules/app_python3/apy_kemi.c index 71bc849e118..1fe02c5bac8 100644 --- a/src/modules/app_python3/apy_kemi.c +++ b/src/modules/app_python3/apy_kemi.c @@ -312,7 +312,8 @@ PyObject *sr_apy_kemi_exec_func_ex(sr_kemi_t *ket, PyObject *self, PyObject *arg } if(ket->ptypes[i]==SR_KEMIP_INT) { vps[i].vtype = SR_KEMIP_INT; - vps[i].v.n = (int)vps[i].v.l; + ret = (int)vps[i].v.l; + vps[i].v.n = ret; } else { vps[i].vtype = SR_KEMIP_LONG; }

1 0

git:master:a5dcd979: app_python: use local var to avoid overlapping values when casting
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: a5dcd9794d6a26469968f8d9d3ee79af8a6e0142 URL: https://github.com/kamailio/kamailio/commit/a5dcd9794d6a26469968f8d9d3ee79a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:46:06+01:00 app_python: use local var to avoid overlapping values when casting --- Modified: src/modules/app_python/apy_kemi.c --- Diff: https://github.com/kamailio/kamailio/commit/a5dcd9794d6a26469968f8d9d3ee79a… Patch: https://github.com/kamailio/kamailio/commit/a5dcd9794d6a26469968f8d9d3ee79a… --- diff --git a/src/modules/app_python/apy_kemi.c b/src/modules/app_python/apy_kemi.c index 9a1e635c1a6..3d4d6d342d7 100644 --- a/src/modules/app_python/apy_kemi.c +++ b/src/modules/app_python/apy_kemi.c @@ -316,7 +316,8 @@ PyObject *sr_apy_kemi_exec_func_ex(sr_kemi_t *ket, PyObject *self, } if(ket->ptypes[i]==SR_KEMIP_INT) { vps[i].vtype = SR_KEMIP_INT; - vps[i].v.n = (int)vps[i].v.l; + ret = (int)vps[i].v.l; + vps[i].v.n = ret; } else { vps[i].vtype = SR_KEMIP_LONG; }

1 0

git:master:f8fdd336: rtp_media_server: return or continue on null values inside rms_dialog_action_check()
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: f8fdd336504702d9353b1ab7a1ffabca5ff4723e URL: https://github.com/kamailio/kamailio/commit/f8fdd336504702d9353b1ab7a1ffabc… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:28:50+01:00 rtp_media_server: return or continue on null values inside rms_dialog_action_check() --- Modified: src/modules/rtp_media_server/rtp_media_server.c --- Diff: https://github.com/kamailio/kamailio/commit/f8fdd336504702d9353b1ab7a1ffabc… Patch: https://github.com/kamailio/kamailio/commit/f8fdd336504702d9353b1ab7a1ffabc… --- diff --git a/src/modules/rtp_media_server/rtp_media_server.c b/src/modules/rtp_media_server/rtp_media_server.c index ac1e8ba73b..07a2eb83a6 100644 --- a/src/modules/rtp_media_server/rtp_media_server.c +++ b/src/modules/rtp_media_server/rtp_media_server.c @@ -240,12 +240,16 @@ static rms_dialog_info_t *rms_stop(rms_dialog_info_t *di) static rms_dialog_info_t *rms_dialog_action_check(rms_dialog_info_t *di) { rms_action_t *a; - if (!di) - LM_ERR("Dialog info NULL\n"); + if (!di) { + LM_ERR("Dialog info NULL\n"); + return NULL; + } clist_foreach(&di->action, a, next) { - if (!a) + if (!a) { LM_ERR("dialog action NULL\n"); + continue; + } if(a->type == RMS_HANGUP) { LM_INFO("dialog action RMS_HANGUP [%s]\n", di->callid.s);

1 0

git:master:ebe0466a: rtp_media_server: safety check on error inside rms_dialog_new()
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: ebe0466a35b9ef3ed1f754c8cb63d5df766ae499 URL: https://github.com/kamailio/kamailio/commit/ebe0466a35b9ef3ed1f754c8cb63d5d… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:26:15+01:00 rtp_media_server: safety check on error inside rms_dialog_new() --- Modified: src/modules/rtp_media_server/rms_dialog_info.c --- Diff: https://github.com/kamailio/kamailio/commit/ebe0466a35b9ef3ed1f754c8cb63d5d… Patch: https://github.com/kamailio/kamailio/commit/ebe0466a35b9ef3ed1f754c8cb63d5d… --- diff --git a/src/modules/rtp_media_server/rms_dialog_info.c b/src/modules/rtp_media_server/rms_dialog_info.c index 824eca3f91..ea0384e769 100644 --- a/src/modules/rtp_media_server/rms_dialog_info.c +++ b/src/modules/rtp_media_server/rms_dialog_info.c @@ -274,7 +274,9 @@ rms_dialog_info_t *rms_dialog_new(struct sip_msg *msg) return si; error: LM_ERR("can not create dialog info.\n"); - rms_dialog_free(si); + if(si) { + rms_dialog_free(si); + } return NULL; }

1 0

git:master:04d02692: rtp_media_server: check before free
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: 04d0269298b9816a384a70439fa75b1bee20df46 URL: https://github.com/kamailio/kamailio/commit/04d0269298b9816a384a70439fa75b1… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:24:37+01:00 rtp_media_server: check before free --- Modified: src/modules/rtp_media_server/rms_dialog_info.c --- Diff: https://github.com/kamailio/kamailio/commit/04d0269298b9816a384a70439fa75b1… Patch: https://github.com/kamailio/kamailio/commit/04d0269298b9816a384a70439fa75b1… --- diff --git a/src/modules/rtp_media_server/rms_dialog_info.c b/src/modules/rtp_media_server/rms_dialog_info.c index efd4c26f68..824eca3f91 100644 --- a/src/modules/rtp_media_server/rms_dialog_info.c +++ b/src/modules/rtp_media_server/rms_dialog_info.c @@ -199,27 +199,31 @@ rms_dialog_info_t *rms_dialog_new_bleg(struct sip_msg *msg) return NULL; rms_dialog_info_t *si = shm_malloc(sizeof(rms_dialog_info_t)); if(!si) { - LM_ERR("can not allocate dialog info !\n"); + LM_ERR("can not allocate dialog info!\n"); goto error; } memset(si, 0, sizeof(rms_dialog_info_t)); if(!rms_str_dup(&si->callid, &msg->callid->body, 1)) { - LM_ERR("can not get callid .\n"); + LM_ERR("can not get callid\n"); goto error; } - if(!rms_str_dup(&si->remote_uri, &msg->from->body, 1)) + if(!rms_str_dup(&si->remote_uri, &msg->from->body, 1)) { goto error; + } str ip; ip.s = ip_addr2a(&msg->rcv.dst_ip); ip.len = strlen(ip.s); - if(!rms_str_dup(&si->local_ip, &ip, 1)) + if(!rms_str_dup(&si->local_ip, &ip, 1)) { goto error; + } clist_init(&si->action, next, prev); return si; error: LM_ERR("can not create dialog info.\n"); - rms_dialog_free(si); + if(si) { + rms_dialog_free(si); + } return NULL; }

1 0

git:master:72cd0ac5: app_python3s: checks for function execution handler
by Daniel-Constantin Mierla 10 Jan '23

10 Jan '23

Module: kamailio Branch: master Commit: 72cd0ac533d4e6b881aa5e4f2e1724c6da312ca2 URL: https://github.com/kamailio/kamailio/commit/72cd0ac533d4e6b881aa5e4f2e1724c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-01-10T13:21:27+01:00 app_python3s: checks for function execution handler --- Modified: src/modules/app_python3s/app_python3s_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/72cd0ac533d4e6b881aa5e4f2e1724c… Patch: https://github.com/kamailio/kamailio/commit/72cd0ac533d4e6b881aa5e4f2e1724c… --- diff --git a/src/modules/app_python3s/app_python3s_mod.c b/src/modules/app_python3s/app_python3s_mod.c index ba68d019e2..f2614f27a8 100644 --- a/src/modules/app_python3s/app_python3s_mod.c +++ b/src/modules/app_python3s/app_python3s_mod.c @@ -323,7 +323,9 @@ int apy3s_script_init_exec(PyObject* pModule, str *fname, int *vparam) if (PyErr_Occurred()) { LM_ERR("error exception occurred\n"); apy3s_handle_exception("script_init"); - Py_DECREF(pHandler); + if (pHandler != NULL) { + Py_DECREF(pHandler); + } goto error; } @@ -331,11 +333,10 @@ int apy3s_script_init_exec(PyObject* pModule, str *fname, int *vparam) LM_ERR("PyObject_CallObject() returned NULL but no exception!\n"); if (!PyErr_Occurred()) PyErr_Format(PyExc_TypeError, - "Function '%s' of module '%s' has returned not returned" - " object. Should be a class instance.", + "Function '%s' of module '%s' has not returned" + " an object. Should be a class instance.", fname->s, _sr_apy3s_bname); apy3s_handle_exception("script_init"); - Py_DECREF(pHandler); goto error; } Py_XDECREF(pHandler);

1 0

← Newer
1
...
21
22
23
24
25
26
27
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev January 2023