sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
394 discussions

git:master:870e4dc8: pkg: RPM packaging add kamailio-tls_wolfssl subpackage
by S-P Chan 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 870e4dc86dec7bf51a513bb1a716ad2417a12fa9 URL: https://github.com/kamailio/kamailio/commit/870e4dc86dec7bf51a513bb1a716ad2… Author: S-P Chan <shihping.chan(a)gmail.com> Committer: S-P Chan <shihping.chan(a)gmail.com> Date: 2023-11-28T06:25:41+08:00 pkg: RPM packaging add kamailio-tls_wolfssl subpackage --- Modified: pkg/kamailio/obs/kamailio-9-x86_64.cfg Modified: pkg/kamailio/obs/kamailio.spec --- Diff: https://github.com/kamailio/kamailio/commit/870e4dc86dec7bf51a513bb1a716ad2… Patch: https://github.com/kamailio/kamailio/commit/870e4dc86dec7bf51a513bb1a716ad2…

1 0

Info: Issue and PR automatic management
by Daniel-Constantin Mierla 27 Nov '23

27 Nov '23

Hello, during the Kamailio Development Meeting that took place in Dusseldorf earlier this month, one topic was related to administrative tasks related to project development and management, how to simplify/automatize such tasks. To reduce the work load on volunteering contributors, GitHub Actions were already used for various tasks related to project development and management (e.g., automatic builds on commits and pull requests to detect compile errors or code formatting mistakes). In Dusseldorf another task was configured to be managed with GitHub Actions, respectively the check of open issues and pull requests to evaluate the interest of submitters, developers and community users to pursue them. If there is no activity on an issue (potential bug or feature request) or a pull request, after 6 weeks it is marked with the label `stale`. After two more weeks of no activity, the issue or the pull request is marked with the label `expired` and closed. Note that any comment postpones the expire timeline, being considered that there is interest in pursuing the issue or the pull request. Requests for features were already treated in this way: if nobody commits to implement it, it can be closed after one month, but it needed manual work and many were still kept open. Potential bug reports that become very old are hard to tackle if the source code changes or new major releases are out, they might even not be valid anymore. Anyhow, this automatic operations can be reverted if there is still interest in pursuing the specific issues or pull requests. A registered developer can remove labels and reopen a closed issue or pull request. The non-registered-developer contributors have to make a comment that includes the token `/notstale` to remove the label `stale` or includes the token `/notexpired` to reopen a closed item. This new kind of automatic task management might add a little inconvenience because one has to restate the interest from time to time for those items that could not be addressed. However, considering that Kamailio is an open source collaborative project, in order to be fair for those that volunteer to spend time and resources for development of Kamailio, also the users/submitters have to stay engaged, not just report and forget about. The process to automatize tasks related to Kamailio development and administration is work in progress. Everything can be adjusted based on feedback (e.g., time lines), feel free to suggest improvements or new solutions to make things easier for everyone within the project ecosystem. Cheers, Daniel -- Daniel-Constantin Mierla (@ asipto.com) twitter.com/miconda -- linkedin.com/in/miconda Kamailio Consultancy and Development Services Kamailio Advanced Training -- asipto.com

1 0

git:master:4840ea75: .github/CONTRIBUTING.md: section for issue and pr automatic management
by Daniel-Constantin Mierla 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 4840ea7536610d07ad6fda76da60ded04dfeabc7 URL: https://github.com/kamailio/kamailio/commit/4840ea7536610d07ad6fda76da60ded… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-27T19:23:36+01:00 .github/CONTRIBUTING.md: section for issue and pr automatic management --- Modified: .github/CONTRIBUTING.md --- Diff: https://github.com/kamailio/kamailio/commit/4840ea7536610d07ad6fda76da60ded… Patch: https://github.com/kamailio/kamailio/commit/4840ea7536610d07ad6fda76da60ded… --- diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 2c5d46842b8..e01dd82c3ce 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -20,6 +20,7 @@ changes to this document in a pull request. * [Commit Message Examples](#commit-message-examples) * [See Also](#see-also) * [Reporting Issues](#reporting-issues) + * [Issue And PR Automatic Management](#issue-and-pr-automatic-management) * [License](#license) * [License Of New Code Contributions](#license-of-new-code-contributions) * [Further Assistance](#further-assistance) @@ -251,6 +252,32 @@ Note: replace any sensitive information in the content you add to the issue (e.g., passwords in modparams can be replaced with xyz, each IP address can be replaced with tokens like a.b.c.d, f.g.h.j). +## Issue And PR Automatic Management ## + +This section presents details about the automatic management of potential bug +reports and requests for new features using github actions. + +Kamailio is an open source collaborative project, in order to be fair for those +that volunteer to spend time and resources for development of Kamailio, the users +have to stay engaged, not just report and forget about. + +To reduce the work load on volunteering contributors, GitHub Actions are used +for various tasks related to project development and management (e.g., automatic +builds on commits and pull requests to detect compile errors or code formatting +mistakes). + +One task managed with GitHub Actions is related to the check of open +issues and pull requests to evaluate the interest of submitter, developers and +community users. If there is no activity on an issue (potential bug or feature +request) or a pull request, after 6 weeks it is marked with the label `stale`. +After two more weeks of no activity, the issue or the pull request is marked +with the label `expired` and closed. + +A registered developer can remove labels and reopen a closed issue or pull +request. The other contributors have to make a comment that includes the token +`/notstale` to remove the label `stale` or includes the token `/notexpired` to +reopen a closed item. + ## License ## Kamailio Main License: *GPLv2*.

1 0

git:master:96300556: .github/ISSUE_TEMPLATE: notes about expiration of items and how to reopen
by Daniel-Constantin Mierla 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 96300556ea4787f6f99926dcc7305ec6e4e3df75 URL: https://github.com/kamailio/kamailio/commit/96300556ea4787f6f99926dcc7305ec… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-27T17:11:53+01:00 .github/ISSUE_TEMPLATE: notes about expiration of items and how to reopen --- Modified: .github/ISSUE_TEMPLATE/bug_report.md Modified: .github/ISSUE_TEMPLATE/feature_request.md --- Diff: https://github.com/kamailio/kamailio/commit/96300556ea4787f6f99926dcc7305ec… Patch: https://github.com/kamailio/kamailio/commit/96300556ea4787f6f99926dcc7305ec… --- diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index e657ee1a979..01b1672bbb7 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -17,6 +17,15 @@ If you have questions about developing extensions to Kamailio or its existing C Please try to fill this template as much as possible for any issue. It helps the developers to troubleshoot the issue. +Note that an issue report may be closed automatically after about 2 months +if there is no interest from developers or community users on pursuing it, being +considered expired. In such case, it can be reopened by writing a comment that includes +the token `/notexpired`. About two weeks before considered expired, the issue is +marked with the label `stale`, trying to notify the submitter and everyone else +that might be interested in it. To remove the label `stale`, write a comment that +includes the token `/notstale`. Also, any comment postpone the `expire` timeline, +being considered that there is interest in pursuing the issue. + If there is no content to be filled in a section, the entire section can be removed. You can delete the comments from the template sections when filling. diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 2c21427e600..6206cee95c7 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -21,6 +21,15 @@ If you submit a feature request (or enhancement) add the description of what you If there is no content to be filled in a section, the entire section can be removed. +Note that a feature request may be closed automatically after about 2 months +if there is no interest from developers or community users to implement it, being +considered expired. In such case can be reopened by writing a comment that includes +the token `/notexpired`. About two weeks before considered expired, the item is +marked with the label `stale`, trying to notify the submitter and everyone else +that might be interested in it. To remove the label `stale`, write a comment that +includes the token `/notstale`. Also, any comment postpone the `expire` timeline, +being considered that there is interest in the proposed feature request. + You can delete the comments from the template sections when filling. You can delete next line and everything above before submitting (it is a comment).

1 0

git:master:5a65791e: modules: readme files regenerated - topoh ... [skip ci]
by Kamailio Dev 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 5a65791e3959439a699d746ce8e63d438e8db0a5 URL: https://github.com/kamailio/kamailio/commit/5a65791e3959439a699d746ce8e63d4… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-27T14:17:09+01:00 modules: readme files regenerated - topoh ... [skip ci] --- Modified: src/modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/5a65791e3959439a699d746ce8e63d4… Patch: https://github.com/kamailio/kamailio/commit/5a65791e3959439a699d746ce8e63d4… --- diff --git a/src/modules/topoh/README b/src/modules/topoh/README index f1a761bf8f9..0217b90d30f 100644 --- a/src/modules/topoh/README +++ b/src/modules/topoh/README @@ -162,12 +162,12 @@ modparam("topoh", "mask_key", "some secret here") IP address to be used in masked headers to build valid SIP URIs. Can be any IP address, even a private-space or non-existing IP address (e.g., 192.168.1.1, 127.0.0.2), including the SIP server address, but must not - be an address potentially used by clients. If not set, the advertised - IP of the incoming or outgoing socket is used. If there is no - advertised IP, the IP of the socket is used. It is not used at all for - SIP routing. + be an address potentially used by clients. If set to empty string, the + advertised IP of the incoming or outgoing socket is used when + specified, otherwise the IP of the socket is used. Note that the value + is actually not used at all for SIP routing. - Default value is empty. + Default value is "127.0.0.8". Example 1.2. Set mask_ip parameter ...

1 0

git:master:e479abe5: github: rework labels workflow [skip ci]
by Victor Seva 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: e479abe5a56e0576b5d5707fbdd7b65d33cf3599 URL: https://github.com/kamailio/kamailio/commit/e479abe5a56e0576b5d5707fbdd7b65… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-27T14:06:15+01:00 github: rework labels workflow [skip ci] --- Modified: .github/workflows/labels.yml --- Diff: https://github.com/kamailio/kamailio/commit/e479abe5a56e0576b5d5707fbdd7b65… Patch: https://github.com/kamailio/kamailio/commit/e479abe5a56e0576b5d5707fbdd7b65… --- diff --git a/.github/workflows/labels.yml b/.github/workflows/labels.yml index 51aa34a603f..6dc1ba6f8a0 100644 --- a/.github/workflows/labels.yml +++ b/.github/workflows/labels.yml @@ -11,10 +11,10 @@ jobs: with: script: | github.rest.issues.removeLabel({ - context.repo.owner, - context.repo.repo, - context.issue.number, - name, + owner: context.repo.owner, + repo: context.repo.repo, + issue_number:context.issue.number, + name: "stale", }); - uses: actions/github-script@v7 if: ${{ !github.event.issue.pull_request && contains(github.event.comment.body, '/notexpired') }} @@ -36,3 +36,19 @@ jobs: pull_number: context.issue.number, state: "open", }); + - uses: actions/github-script@v7 + if: ${{ contains(github.event.comment.body, '/notexpired') }} + with: + script: | + github.rest.issues.removeLabel({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + name: "stale", + }); + github.rest.issues.removeLabel({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + name: "expired", + });

1 0

git:master:949b0079: topoh: mask_ip initialized again to 127.0.0.8
by Daniel-Constantin Mierla 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 949b00795d748aa6b6af64c4ced8a3e8de369021 URL: https://github.com/kamailio/kamailio/commit/949b00795d748aa6b6af64c4ced8a3e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-27T14:04:31+01:00 topoh: mask_ip initialized again to 127.0.0.8 - docs updated - code formatting updated by pre-commit hooks --- Modified: src/modules/topoh/doc/topoh_admin.xml Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/949b00795d748aa6b6af64c4ced8a3e… Patch: https://github.com/kamailio/kamailio/commit/949b00795d748aa6b6af64c4ced8a3e…

1 0

git:master:52cee630: modules: readme files regenerated - topoh ... [skip ci]
by Kamailio Dev 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 52cee630d367287daa4b15c042b25bec76192e80 URL: https://github.com/kamailio/kamailio/commit/52cee630d367287daa4b15c042b25be… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-11-27T14:02:31+01:00 modules: readme files regenerated - topoh ... [skip ci] --- Modified: src/modules/topoh/README --- Diff: https://github.com/kamailio/kamailio/commit/52cee630d367287daa4b15c042b25be… Patch: https://github.com/kamailio/kamailio/commit/52cee630d367287daa4b15c042b25be… --- diff --git a/src/modules/topoh/README b/src/modules/topoh/README index 2fa0f4fd398..f1a761bf8f9 100644 --- a/src/modules/topoh/README +++ b/src/modules/topoh/README @@ -162,10 +162,12 @@ modparam("topoh", "mask_key", "some secret here") IP address to be used in masked headers to build valid SIP URIs. Can be any IP address, even a private-space or non-existing IP address (e.g., 192.168.1.1, 127.0.0.2), including the SIP server address, but must not - be an address potentially used by clients. It is not used at all for + be an address potentially used by clients. If not set, the advertised + IP of the incoming or outgoing socket is used. If there is no + advertised IP, the IP of the socket is used. It is not used at all for SIP routing. - Default value is "127.0.0.8". + Default value is empty. Example 1.2. Set mask_ip parameter ...

1 0

git:master:026e9035: github: react to PR/issue comments [skip ci]
by Victor Seva 27 Nov '23

27 Nov '23

Module: kamailio Branch: master Commit: 026e90350d0b4ec64695c373b70fa554d9337c34 URL: https://github.com/kamailio/kamailio/commit/026e90350d0b4ec64695c373b70fa55… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-27T13:53:26+01:00 github: react to PR/issue comments [skip ci] ``/notstale`` will remove ``stale`` label ``/notexpired`` will change the status to ``open`` > https://github.com/marketplace/actions/github-script --- Added: .github/workflows/labels.yml --- Diff: https://github.com/kamailio/kamailio/commit/026e90350d0b4ec64695c373b70fa55… Patch: https://github.com/kamailio/kamailio/commit/026e90350d0b4ec64695c373b70fa55… --- diff --git a/.github/workflows/labels.yml b/.github/workflows/labels.yml new file mode 100644 index 00000000000..51aa34a603f --- /dev/null +++ b/.github/workflows/labels.yml @@ -0,0 +1,38 @@ +name: manage labels from comments + +on: [issue_comment] + +jobs: + manage: + runs-on: ubuntu-latest + steps: + - uses: actions/github-script@v7 + if: ${{ contains(github.event.comment.body, '/notstale') }} + with: + script: | + github.rest.issues.removeLabel({ + context.repo.owner, + context.repo.repo, + context.issue.number, + name, + }); + - uses: actions/github-script@v7 + if: ${{ !github.event.issue.pull_request && contains(github.event.comment.body, '/notexpired') }} + with: + script: | + github.rest.issues.update({ + owner: context.repo.owner, + repo: context.repo.repo, + issue_number: context.issue.number, + state: "open", + }); + - uses: actions/github-script@v7 + if: ${{ github.event.issue.pull_request && contains(github.event.comment.body, '/notexpired') }} + with: + script: | + github.rest.pulls.update({ + owner: context.repo.owner, + repo: context.repo.repo, + pull_number: context.issue.number, + state: "open", + });

1 0

[kamailio/kamailio] topoh: uses socket IP when no mask_ip is defined (PR #3341)
by TorPetterson 27 Nov '23

27 Nov '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [ ] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [ ] PR should be backported to stable branches - [ ] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  topoh: uses socket IP when no mask_ip is defined If the parameter mask_ip is not defined the module finds the socket IP and uses that as mask IP for the message. If the socket has an advertised IP it is used, otherwise the socket IP is used. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3341 -- Commit Summary -- * topoh: uses socket IP when no mask_ip is defined * Merge remote-tracking branch 'upstream/master' -- File Changes -- M src/modules/topoh/doc/topoh_admin.xml (4) M src/modules/topoh/th_msg.c (55) M src/modules/topoh/th_msg.h (16) M src/modules/topoh/topoh_mod.c (309) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3341.patch https://github.com/kamailio/kamailio/pull/3341.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3341 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3341(a)github.com>

5 14

← Newer
1
...
7
8
9
10
11
12
13
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023