sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
391 discussions

[kamailio/kamailio] track_cseq_updates does not update Rack SIP header in PRACK. (#801)
by scfcplummy 23 Nov '23

23 Nov '23

Hi, When using dialog module and track_cseq_updates when needing to update CSeq for authenticated invites, if early media is present the CSeq in the Rack header is not also incremented. Kamailio version: version: kamailio 4.4.2 (x86_64/linux) 892ad6 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 892ad6 compiled on 11:18:36 Sep 28 2016 with gcc 5.4.0 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/801

4 6

[kamailio/kamailio] sca: implement db_mode only (#781)
by Victor Seva 23 Nov '23

23 Nov '23

Sipwise hat ON: We have more than one server and we need to keep things in db in order to share sca subscription/appearance between servers -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/781

4 6

git:master:26d57116: sca: update rr if necessary for subscriptions
by Victor Seva 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 26d57116abc86e5d10bb1e5fe05c555e70e731c4 URL: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-22T18:26:10+01:00 sca: update rr if necessary for subscriptions --- Modified: src/modules/sca/sca_subscribe.c --- Diff: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… Patch: https://github.com/kamailio/kamailio/commit/26d57116abc86e5d10bb1e5fe05c555… --- diff --git a/src/modules/sca/sca_subscribe.c b/src/modules/sca/sca_subscribe.c index 6cdf33a6f74..6e9949a5d78 100644 --- a/src/modules/sca/sca_subscribe.c +++ b/src/modules/sca/sca_subscribe.c @@ -905,6 +905,17 @@ static int sca_subscription_update_unsafe(sca_mod *scam, } SCA_STR_COPY(&update_sub->rr, &saved_sub->rr); + } else if(!SCA_STR_EMPTY(&update_sub->rr) + && !STR_EQ(update_sub->rr, saved_sub->rr)) { + if(!SCA_STR_EMPTY(&saved_sub->rr)) { + shm_free(saved_sub->rr.s); + saved_sub->rr.len = 0; + } + if((saved_sub->rr.s = (char *)shm_malloc(update_sub->rr.len)) == NULL) { + SHM_MEM_ERROR; + goto done; + } + SCA_STR_COPY(&saved_sub->rr, &update_sub->rr); } rc = 1;

1 0

[kamailio/kamailio] sca: update rr if necessary for subscriptions (PR #3571)
by Victor Seva 22 Nov '23

22 Nov '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [ ] Tested changes locally #### Description From https://github.com/kamailio/kamailio/pull/3569 After initial subscription by the SCA device, if we power off and on again, we won't get an unsubscribe notification and we are getting a new record-route with sca-subscription. In this case kamailio not updating the new record-route for the SCA Device. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3571 -- Commit Summary -- * sca: update rr if necessary for subscriptions -- File Changes -- M src/modules/sca/sca_subscribe.c (11) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3571.patch https://github.com/kamailio/kamailio/pull/3571.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3571 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3571(a)github.com>

3 6

git:master:e45c97d1: dialog: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: e45c97d112c7c396ae0a11b7a431582a71361e5b URL: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 dialog: do not print module name in log messages - it is added automatically --- Modified: src/modules/dialog/dialog.c --- Diff: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… Patch: https://github.com/kamailio/kamailio/commit/e45c97d112c7c396ae0a11b7a431582… --- diff --git a/src/modules/dialog/dialog.c b/src/modules/dialog/dialog.c index e937947432c..a6e8179326e 100644 --- a/src/modules/dialog/dialog.c +++ b/src/modules/dialog/dialog.c @@ -552,7 +552,7 @@ static int mod_init(void) /* register statistics */ if(dlg_enable_stats && (register_module_stats(exports.name, mod_stats) != 0)) { - LM_ERR("failed to register %s statistics\n", exports.name); + LM_ERR("failed to register statistics\n"); return -1; } #endif

1 0

git:master:463d5b34: avp: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 463d5b34390e330a2b733deb673c1c77e5be9fcb URL: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 avp: do not print module name in log messages - it is added automatically --- Modified: src/modules/avp/avp.c --- Diff: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… Patch: https://github.com/kamailio/kamailio/commit/463d5b34390e330a2b733deb673c1c7… --- diff --git a/src/modules/avp/avp.c b/src/modules/avp/avp.c index 2478f38513c..38fa08fe1cb 100644 --- a/src/modules/avp/avp.c +++ b/src/modules/avp/avp.c @@ -1704,6 +1704,6 @@ select_row_t sel_declaration[] = {{NULL, SEL_PARAM_STR, STR_STATIC_INIT("avp"), static int mod_init() { - DBG("%s - initializing\n", exports.name); + DBG("initializing\n"); return register_select_table(sel_declaration); }

1 0

git:master:89a95ce1: avpops: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 89a95ce1abefd772c0f09054473b07bbfc5426bc URL: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 avpops: do not print module name in log messages - it is added automatically --- Modified: src/modules/avpops/avpops.c --- Diff: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… Patch: https://github.com/kamailio/kamailio/commit/89a95ce1abefd772c0f09054473b07b… --- diff --git a/src/modules/avpops/avpops.c b/src/modules/avpops/avpops.c index 577a7d7fabe..9fc662ab603 100644 --- a/src/modules/avpops/avpops.c +++ b/src/modules/avpops/avpops.c @@ -810,12 +810,12 @@ static int fixup_subst(void **param, int param_no) } *param = (void *)av; } else if(param_no == 2) { - LM_DBG("%s fixing %s\n", exports.name, (char *)(*param)); + LM_DBG("fixing: %s\n", (char *)(*param)); subst.s = *param; subst.len = strlen(*param); se = subst_parser(&subst); if(se == 0) { - LM_ERR("%s: bad subst re %s\n", exports.name, (char *)*param); + LM_ERR("bad subst re: %s\n", (char *)*param); return E_BAD_RE; } /* don't free string -- needed for specifiers */

1 0

git:master:ba1c0424: textops: do not print module name in log messages
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: ba1c0424732f1f2ab01bfd078ee272221a6b3e10 URL: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:53:33+01:00 textops: do not print module name in log messages - it is added automatically --- Modified: src/modules/textops/textops.c --- Diff: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722… Patch: https://github.com/kamailio/kamailio/commit/ba1c0424732f1f2ab01bfd078ee2722…

1 0

git:master:145659f9: github: set ``expired`` label when closing PR or issues automatically [skip ci]
by Victor Seva 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 145659f9b81a0d489548fa8a0f75c0bd05660e2e URL: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-11-22T14:50:21+01:00 github: set ``expired`` label when closing PR or issues automatically [skip ci] --- Modified: .github/workflows/issue_management.yml --- Diff: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… Patch: https://github.com/kamailio/kamailio/commit/145659f9b81a0d489548fa8a0f75c0b… --- diff --git a/.github/workflows/issue_management.yml b/.github/workflows/issue_management.yml index 063df358c62..0d0b2ef9aa5 100644 --- a/.github/workflows/issue_management.yml +++ b/.github/workflows/issue_management.yml @@ -17,6 +17,8 @@ jobs: stale-pr-message: 'This PR is stale because it has been open 6 weeks with no activity. Remove stale label or comment or this will be closed in 2 weeks.' days-before-stale: 42 days-before-close: 14 + close-issue-label: expired + close-pr-label: expired exempt-issue-labels: bug remove-stale-when-updated: true operations-per-run: 500

1 0

git:master:65322a8e: app_ruby: use module name prefix for exports structure
by Daniel-Constantin Mierla 22 Nov '23

22 Nov '23

Module: kamailio Branch: master Commit: 65322a8ea66ed18fb2d089ade54702341e064944 URL: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-22T14:05:21+01:00 app_ruby: use module name prefix for exports structure --- Modified: src/modules/app_ruby/app_ruby_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… Patch: https://github.com/kamailio/kamailio/commit/65322a8ea66ed18fb2d089ade547023… --- diff --git a/src/modules/app_ruby/app_ruby_mod.c b/src/modules/app_ruby/app_ruby_mod.c index 4d08464a996..4f713efea54 100644 --- a/src/modules/app_ruby/app_ruby_mod.c +++ b/src/modules/app_ruby/app_ruby_mod.c @@ -86,7 +86,7 @@ static param_export_t params[]={ {0, 0, 0} }; -struct module_exports exports = { +struct module_exports _app_ruby_exports = { "app_ruby", DEFAULT_DLFLAGS, /* dlopen flags */ cmds, /* exported functions */

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023