sr-dev November 2023

sr-dev@lists.kamailio.org

15 participants
394 discussions

git:master:a59bc67c: pv: transformation number parmeter kept long value to match pv field type
by Daniel-Constantin Mierla 20 Nov '23

20 Nov '23

Module: kamailio Branch: master Commit: a59bc67cd4bd1df3e81bdb494896b5a076f9d40d URL: https://github.com/kamailio/kamailio/commit/a59bc67cd4bd1df3e81bdb494896b5a… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-20T09:43:15+01:00 pv: transformation number parmeter kept long value to match pv field type --- Modified: src/modules/pv/pv_trans.c --- Diff: https://github.com/kamailio/kamailio/commit/a59bc67cd4bd1df3e81bdb494896b5a… Patch: https://github.com/kamailio/kamailio/commit/a59bc67cd4bd1df3e81bdb494896b5a… --- diff --git a/src/modules/pv/pv_trans.c b/src/modules/pv/pv_trans.c index 48557ca977d..2c60cc7e656 100644 --- a/src/modules/pv/pv_trans.c +++ b/src/modules/pv/pv_trans.c @@ -2563,7 +2563,7 @@ int tr_eval_val( && (*_p == ' ' || *_p == '\t' || *_p == '\n')) \ _p++; \ while(is_in_str(_p, _in) && *_p >= '0' && *_p <= '9') { \ - if(_n > ((INT_MAX / 10) - 10)) { \ + if(_n > ((LONG_MAX / 10) - 10)) { \ LM_ERR("number value is too large\n"); \ goto error; \ } \ @@ -2577,7 +2577,7 @@ int tr_eval_val( } \ memset(_tp, 0, sizeof(tr_param_t)); \ _tp->type = TR_PARAM_NUMBER; \ - _tp->v.n = sign * n; \ + _tp->v.n = n * sign; \ } else { \ LM_ERR("tinvalid param in transformation: %.*s!!\n", _in->len, \ _in->s); \ @@ -2660,7 +2660,7 @@ char *tr_parse_string(str *in, trans_t *t) str name; str s; pv_spec_t *spec = NULL; - int n; + long n; int sign; tr_param_t *tp = NULL; @@ -3323,7 +3323,7 @@ char *tr_parse_paramlist(str *in, trans_t *t) char *start_pos; str s; str name; - int n; + long n; int sign; pv_spec_t *spec = NULL; tr_param_t *tp = NULL; @@ -3560,7 +3560,7 @@ char *tr_parse_line(str *in, trans_t *t) char *ps; str s; str name; - int n; + long n; int sign; pv_spec_t *spec = NULL; tr_param_t *tp = NULL;

1 0

git:master:6cc8f126: app_jsdt: length checks for resolving js module path
by Daniel-Constantin Mierla 20 Nov '23

20 Nov '23

Module: kamailio Branch: master Commit: 6cc8f126391476a05f8d90a35d6d57eec7c4e8d8 URL: https://github.com/kamailio/kamailio/commit/6cc8f126391476a05f8d90a35d6d57e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-11-20T09:43:15+01:00 app_jsdt: length checks for resolving js module path --- Modified: src/modules/app_jsdt/app_jsdt_api.c --- Diff: https://github.com/kamailio/kamailio/commit/6cc8f126391476a05f8d90a35d6d57e… Patch: https://github.com/kamailio/kamailio/commit/6cc8f126391476a05f8d90a35d6d57e… --- diff --git a/src/modules/app_jsdt/app_jsdt_api.c b/src/modules/app_jsdt/app_jsdt_api.c index 8ad015c89d9..68dc38f1b23 100644 --- a/src/modules/app_jsdt/app_jsdt_api.c +++ b/src/modules/app_jsdt/app_jsdt_api.c @@ -1072,23 +1072,42 @@ duk_ret_t cb_resolve_module(duk_context *JJ) const char *parent_id = duk_get_string(JJ, 1); char requested_path[PATH_MAX]; + char resolved_id[PATH_MAX]; + char *ptr = NULL; + + if(requested_id == NULL) { + return duk_generic_error(JJ, "Invalid parameter"); + } + if(strlen(requested_id) >= PATH_MAX) { + return duk_generic_error(JJ, "Parameter too long"); + } + requested_path[0] = '\0'; if(requested_id[0] == '/') { // absolute strcpy(requested_path, requested_id); } else if(strncmp(requested_id, "./", 2) || strncmp(requested_id, "../", 3)) { - if(strlen(parent_id)) { + if(parent_id != NULL && strlen(parent_id) > 0) { + if(strlen(parent_id) >= PATH_MAX) { + return duk_generic_error(JJ, "Second parameter too long"); + } // relative to parent strcpy(requested_path, parent_id); } else { + if(strlen(_sr_jsdt_load_file.s) >= PATH_MAX) { + return duk_generic_error(JJ, "Load file path too long"); + } // no parent so relative to jsdt_load_file strcpy(requested_path, _sr_jsdt_load_file.s); } - char *ptr = strrchr(requested_path, '/'); + ptr = strrchr(requested_path, '/'); if(ptr) { ptr++; *ptr = '\0'; } + if(strlen(requested_path) + strlen(requested_id) >= PATH_MAX) { + return duk_generic_error(JJ, "Path too long"); + } strcat(requested_path, requested_id); } else { LM_INFO("cb_resolve_module - TODO resolve pathless module names"); @@ -1096,9 +1115,11 @@ duk_ret_t cb_resolve_module(duk_context *JJ) } // if missing add .js ext if(strcmp(strrchr(requested_path, '\0') - 3, ".js")) { + if(strlen(requested_path) + 3 >= PATH_MAX) { + return duk_generic_error(JJ, "Path too long"); + } strcat(requested_path, ".js"); } - char resolved_id[PATH_MAX]; if(realpath(requested_path, resolved_id)) { duk_push_string(JJ, resolved_id); return 1; /*nrets*/

1 0

git:master:e54a4187: tls_wolfssl: enable building with external package
by SPChan 18 Nov '23

18 Nov '23

Module: kamailio Branch: master Commit: e54a41874de6393d71b50368ffb8a4982aed2d2d URL: https://github.com/kamailio/kamailio/commit/e54a41874de6393d71b50368ffb8a49… Author: SPChan <shihping.chan(a)gmail.com> Committer: SPChan <shihping.chan(a)gmail.com> Date: 2023-11-18T21:14:06+08:00 tls_wolfssl: enable building with external package - build with git submodule: make ...WOLFSSL_INTERNAL=yes... - the default - build with external package: make ...WOLFSSL_INTERNAL=no... Debian recommended environment is libwolfssl41 5.6.4, libwolfssl-dev 5.6.4 --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/e54a41874de6393d71b50368ffb8a49… Patch: https://github.com/kamailio/kamailio/commit/e54a41874de6393d71b50368ffb8a49… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index fe2e7d8d4ed..1a6254ea7b2 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -8,6 +8,13 @@ include ../../Makefile.defs auto_gen= NAME=tls_wolfssl.so +# make WOLFSSL_INTERNAL=yes... for internal submodule +# make WOLFSSL_INTERNAL=no... for system package +# default: yes + +WOLFSSL_INTERNAL ?= yes + +ifeq ($(WOLFSSL_INTERNAL),yes) WOLFSSL_PREFIX = ../../../misc/external/wolfssl/build WOLFSSL_SRC = ../../../misc/external/wolfssl/wolfssl @@ -34,6 +41,15 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: $(NAME): $(WOLFSSL_PREFIX)/lib/libwolfssl.a +else +WOLFSSL_LIBS ?= $(shell pkg-config wolfssl --libs) +WOLFSSL_INCLUDES ?= $(shell pkg-config wolfssl --cflags) + +LIBS += $(WOLFSSL_LIBS) +INCLUDES += $(WOLFSSL_INCLUDES) +include ../../Makefile.modules +endif + clean-wolfssl: @rm -rf $(WOLFSSL_PREFIX)/{bin,include,share,lib}; \ (cd $(WOLFSSL_SRC); make distclean) || /bin/true

1 0

git:master:38aa7e5f: tls_wolfssl: update internal submodule to v5.6.4, and target 5.6.x for distro package
by SPChan 18 Nov '23

18 Nov '23

Module: kamailio Branch: master Commit: 38aa7e5fffcb68979a9bb5771aaa6ef9e14b517d URL: https://github.com/kamailio/kamailio/commit/38aa7e5fffcb68979a9bb5771aaa6ef… Author: SPChan <shihping.chan(a)gmail.com> Committer: SPChan <shihping.chan(a)gmail.com> Date: 2023-11-18T19:07:59+08:00 tls_wolfssl: update internal submodule to v5.6.4, and target 5.6.x for distro package --- Modified: misc/external/wolfssl/wolfssl --- Diff: https://github.com/kamailio/kamailio/commit/38aa7e5fffcb68979a9bb5771aaa6ef… Patch: https://github.com/kamailio/kamailio/commit/38aa7e5fffcb68979a9bb5771aaa6ef… --- diff --git a/misc/external/wolfssl/wolfssl b/misc/external/wolfssl/wolfssl index 3b3c175af0e..37884f864d6 160000 --- a/misc/external/wolfssl/wolfssl +++ b/misc/external/wolfssl/wolfssl @@ -1 +1 @@ -Subproject commit 3b3c175af0e993ffaae251871421e206cc41963f +Subproject commit 37884f864d6fd9b04f44677cb04da15d0c9d6526

1 0

git:master:dea9b252: tls_wolfssl: re-enable optimizations as qm/fm default to 16-byte alignment
by SPChan 18 Nov '23

18 Nov '23

Module: kamailio Branch: master Commit: dea9b25299ee273e45b0e08acacff8de87b7ceb9 URL: https://github.com/kamailio/kamailio/commit/dea9b25299ee273e45b0e08acacff8d… Author: SPChan <shihping.chan(a)gmail.com> Committer: SPChan <shihping.chan(a)gmail.com> Date: 2023-11-18T12:21:03+08:00 tls_wolfssl: re-enable optimizations as qm/fm default to 16-byte alignment --- Modified: src/modules/tls_wolfssl/Makefile --- Diff: https://github.com/kamailio/kamailio/commit/dea9b25299ee273e45b0e08acacff8d… Patch: https://github.com/kamailio/kamailio/commit/dea9b25299ee273e45b0e08acacff8d… --- diff --git a/src/modules/tls_wolfssl/Makefile b/src/modules/tls_wolfssl/Makefile index 730076023a9..fe2e7d8d4ed 100644 --- a/src/modules/tls_wolfssl/Makefile +++ b/src/modules/tls_wolfssl/Makefile @@ -25,7 +25,7 @@ $(WOLFSSL_PREFIX)/include/wolfssl/options.h $(WOLFSSL_PREFIX)/lib/libwolfssl.a: if [ ! -f "Makefile" ]; then \ env -u DEFS -u CFLAGS -u LDFLAGS -u LIBS EXTRA_CFLAGS="-g -O2 -fPIC" ./configure \ --enable-all --enable-pkcs11 --enable-static --enable-writedup \ - --disable-aligndata --disable-shared --disable-examples \ + --disable-shared --disable-examples \ --disable-jni --disable-crl-monitor \ --prefix=$(CURDIR)/$(WOLFSSL_PREFIX) \ --exec-prefix=$(CURDIR)/$(WOLFSSL_PREFIX); \

1 0

[kamailio/kamailio] topos: BYE sent by caller before call was connected was badly managed (PR #3644)
by Frédéric Gaisnon 17 Nov '23

17 Nov '23

#### Pre-Submission Checklist    - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [x] Small bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description  When caller sent a BYE instead a CANCEL into a non connected call, route are badly reappend by topos. regression introduced by patch 091dc9a76bcec5c8a4bc73e863ed10b1b9d76c92 topos: fix early-dialog b-side UPDATE requests routing (GH #3437) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3644 -- Commit Summary -- * topos: BYE sent by caller before call was connected was badly managed -- File Changes -- M src/modules/topos/tps_msg.c (2) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3644.patch https://github.com/kamailio/kamailio/pull/3644.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3644 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3644(a)github.com>

3 8

git:master:9898c586: topos: BYE sent by caller before call was connected was badly managed
by Henning Westerholt 17 Nov '23

17 Nov '23

Module: kamailio Branch: master Commit: 9898c586095bd75cd31f0ca383ba0a347bfc4891 URL: https://github.com/kamailio/kamailio/commit/9898c586095bd75cd31f0ca383ba0a3… Author: frederic <frederic.gaisnon(a)mmtt.fr> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-11-17T14:48:35+01:00 topos: BYE sent by caller before call was connected was badly managed regression introduced by patch 091dc9a76bcec5c8a4bc73e863ed10b1b9d76c92 topos: fix early-dialog b-side UPDATE requests routing (GH #3437) --- Modified: src/modules/topos/tps_msg.c --- Diff: https://github.com/kamailio/kamailio/commit/9898c586095bd75cd31f0ca383ba0a3… Patch: https://github.com/kamailio/kamailio/commit/9898c586095bd75cd31f0ca383ba0a3… --- diff --git a/src/modules/topos/tps_msg.c b/src/modules/topos/tps_msg.c index 942629568b9..4d680e53f45 100644 --- a/src/modules/topos/tps_msg.c +++ b/src/modules/topos/tps_msg.c @@ -962,7 +962,7 @@ int tps_request_received(sip_msg_t *msg, int dialog) LM_DBG("use branch for routing information, request from direction " "%d\n", direction); - if(tps_reappend_route(msg, &stsd, &stsd.s_rr, 1) < 0) { + if(tps_reappend_route(msg, &stsd, &stsd.s_rr, (direction == TPS_DIR_UPSTREAM) ? 0 : 1) < 0) { LM_ERR("failed to reappend s-route\n"); return -1; }

1 0

Problems with fsn
by aaron.soto＠dialapplet.com 17 Nov '23

17 Nov '23

Hello to all, I am having a problem that when I send an invite from kamailio, when I change the variable $fsn by an alias it takes the ip well, but the port sends it by a random port, when observing the capture with the sngrep it is shown as the source port is completely random. If someone can help me, let me know what kind of information you can help. Thanks

1 0

Kamailio v5.7.3 Released
by Daniel-Constantin Mierla 17 Nov '23

17 Nov '23

Hello, Kamailio SIP Server v5.7.3 stable release is out. This is a maintenance release of the latest stable branch, 5.7, that includes fixes since the release of v5.7.2. There is no change to database schema or configuration language structure that you have to do on previous installations of v5.7.x. Deployments running previous v5.7.x versions are strongly recommended to be upgraded to v5.7.3. For more details about version 5.7.3 (including links and guidelines to download the tarball or from GIT repository), visit: * https://www.kamailio.org/w/2023/11/kamailio-v5-7-3-released/ RPM, Debian/Ubuntu packages will be available soon as well. Many thanks to all contributing and using Kamailio! Cheers, Daniel -- Daniel-Constantin Mierla -- www.asipto.com www.twitter.com/miconda -- www.linkedin.com/in/miconda Kamailio World Conference - www.kamailioworld.com

1 0

[kamailio/kamailio] Allow function set_advertised_address to receive variable as parameter (#2137)
by pwakano 17 Nov '23

17 Nov '23

### Description Currently the functions set_advertised_address and set_advertised_port only accept strings as parameters. Trying to use it with variable causes an error. Having the function using a hard coded value is not a good practice and in order to add flexibility to the script in different installations it would be nice to have this function accepting variables. Also, the 'advertise' option on the 'listen' parameter is not always desired because it apply for all messages sent via the socket, and there are situations where different advertised IP for the same interface are necessary. ### Expected behavior set_advertised_address should receive a variable as parameter and use its value to change the SIP headers. ### Actual observed behavior Kamailio won't start if set_advertised_address is used with a variable due to script parse error or it will set the SIP message with the literal string "$var(test)" for example, instead of using the value of $var(test). ### Additional Information * **Kamailio Version** - output of `kamailio -v` ``` # kamailio -v version: kamailio 5.2.2 (x86_64/linux) 67f967 flags: STATS: Off, USE_TCP, USE_TLS, USE_SCTP, TLS_HOOKS, USE_RAW_SOCKS, DISABLE_NAGLE, USE_MCAST, DNS_IP_HACK, SHM_MEM, SHM_MMAP, PKG_MALLOC, Q_MALLOC, F_MALLOC, TLSF_MALLOC, DBG_SR_MEMORY, USE_FUTEX, FAST_LOCK-ADAPTIVE_WAIT, USE_DNS_CACHE, USE_DNS_FAILOVER, USE_NAPTR, USE_DST_BLACKLIST, HAVE_RESOLV_RES ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144 MAX_URI_SIZE 1024, BUF_SIZE 65535, DEFAULT PKG_SIZE 8MB poll method support: poll, epoll_lt, epoll_et, sigio_rt, select. id: 67f967 compiled on 11:40:41 Mar 11 2019 with gcc 4.8.5 ``` * **Operating System**:  ``` # uname -a Linux voice-conn-kamailio-1 3.10.0-514.21.2.el7.x86_64 #1 SMP Tue Jun 20 12:24:47 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/2137

7 9

← Newer
1
...
25
26
27
28
29
30
31
...
40
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev November 2023