sr-dev December 2023

sr-dev@lists.kamailio.org

14 participants
234 discussions

git:master:3a02bf42: ims_charging: log message on db updated error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 3a02bf42bc182e0eb809e63d8fe828e3ece5f1da URL: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:26:22+01:00 ims_charging: log message on db updated error --- Modified: src/modules/ims_charging/ro_db_handler.c --- Diff: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… Patch: https://github.com/kamailio/kamailio/commit/3a02bf42bc182e0eb809e63d8fe828e… --- diff --git a/src/modules/ims_charging/ro_db_handler.c b/src/modules/ims_charging/ro_db_handler.c index 7aaf6fb3a5d..d75126e33bc 100644 --- a/src/modules/ims_charging/ro_db_handler.c +++ b/src/modules/ims_charging/ro_db_handler.c @@ -717,7 +717,9 @@ void ro_update_db(unsigned int ticks, void *param) for(ro_session = ro_session_entry.first; ro_session != NULL; ro_session = ro_session->next) { - update_ro_dbinfo_unsafe(ro_session); + if(update_ro_dbinfo_unsafe(ro_session) != 0) { + LM_ERR("failed to update ro_session in DB\n"); + } } ro_session_unlock(ro_session_table, &ro_session_entry); }

1 year

git:master:4f6a2686: topoh: reorder conditions for safety of cleaning on error

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 4f6a2686c01a65fe3a23e4d2057c7940eedcf12a URL: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:20:01+01:00 topoh: reorder conditions for safety of cleaning on error - in the part related to the new th_build_socket_strings() internal function --- Modified: src/modules/topoh/topoh_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… Patch: https://github.com/kamailio/kamailio/commit/4f6a2686c01a65fe3a23e4d2057c794… --- diff --git a/src/modules/topoh/topoh_mod.c b/src/modules/topoh/topoh_mod.c index dbb08d83084..d40f70fdd86 100644 --- a/src/modules/topoh/topoh_mod.c +++ b/src/modules/topoh/topoh_mod.c @@ -357,14 +357,18 @@ int th_build_socket_strings(socket_info_t *socket) return 0; error: - if(socket_strings->ip.s != NULL) - pkg_free(socket_strings->ip.s); - if(table_entry->key.s != NULL) - pkg_free(table_entry->key.s); - if(table_entry != NULL) - pkg_free(table_entry); - if(socket_strings != NULL) + if(socket_strings != NULL) { + if(socket_strings->ip.s != NULL) { + pkg_free(socket_strings->ip.s); + } pkg_free(socket_strings); + } + if(table_entry != NULL) { + if(table_entry->key.s != NULL) { + pkg_free(table_entry->key.s); + } + pkg_free(table_entry); + } return -1; }

1 year

git:master:0d78a1ad: pkg/kamailio/deb: version set 5.8.0~dev2 [skip ci]

by Victor Seva

Module: kamailio Branch: master Commit: 0d78a1add4292ff1e10347c0199f0d70d31678ea URL: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7… Author: Victor Seva <linuxmaniac(a)torreviejawireless.org> Committer: Victor Seva <linuxmaniac(a)torreviejawireless.org> Date: 2023-12-05T12:04:36+01:00 pkg/kamailio/deb: version set 5.8.0~dev2 [skip ci] --- Modified: pkg/kamailio/deb/bionic/changelog Modified: pkg/kamailio/deb/bookworm/changelog Modified: pkg/kamailio/deb/bullseye/changelog Modified: pkg/kamailio/deb/buster/changelog Modified: pkg/kamailio/deb/debian/changelog Modified: pkg/kamailio/deb/focal/changelog Modified: pkg/kamailio/deb/jammy/changelog Modified: pkg/kamailio/deb/jessie/changelog Modified: pkg/kamailio/deb/precise/changelog Modified: pkg/kamailio/deb/sid/changelog Modified: pkg/kamailio/deb/stretch/changelog Modified: pkg/kamailio/deb/trusty/changelog Modified: pkg/kamailio/deb/wheezy/changelog Modified: pkg/kamailio/deb/xenial/changelog --- Diff: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7… Patch: https://github.com/kamailio/kamailio/commit/0d78a1add4292ff1e10347c0199f0d7…

1 year

git:master:6305adef: Makefile.defs: version set to 5.8.0-dev2

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6305adef50079891386a048b986fd27e9b6e7ca1 URL: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T12:00:00+01:00 Makefile.defs: version set to 5.8.0-dev2 --- Modified: src/Makefile.defs --- Diff: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… Patch: https://github.com/kamailio/kamailio/commit/6305adef50079891386a048b986fd27… --- diff --git a/src/Makefile.defs b/src/Makefile.defs index 075ac2041a6..68225943982 100644 --- a/src/Makefile.defs +++ b/src/Makefile.defs @@ -107,7 +107,7 @@ INSTALL_FLAVOUR=$(FLAVOUR) VERSION = 5 PATCHLEVEL = 8 SUBLEVEL = 0 -EXTRAVERSION = -dev1 +EXTRAVERSION = -dev2 # memory manager switcher # 0 - f_malloc (fast malloc)

1 year

git:master:ca7e1e49: dialog: prevent duplicate of leg1 attributes in json for dmq

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: ca7e1e49aecd3e0f12cc783e3b97868980f1d3d2 URL: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-05T10:27:32+01:00 dialog: prevent duplicate of leg1 attributes in json for dmq - reported by #3656 --- Modified: src/modules/dialog/dlg_dmq.c --- Diff: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… Patch: https://github.com/kamailio/kamailio/commit/ca7e1e49aecd3e0f12cc783e3b97868… --- diff --git a/src/modules/dialog/dlg_dmq.c b/src/modules/dialog/dlg_dmq.c index 419fa50a29c..bb8a69cffd6 100644 --- a/src/modules/dialog/dlg_dmq.c +++ b/src/modules/dialog/dlg_dmq.c @@ -535,6 +535,7 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, &jdoc, jdoc.root, "to_uri", dlg->to_uri.s, dlg->to_uri.len); srjson_AddStrToObject(&jdoc, jdoc.root, "req_uri", dlg->req_uri.s, dlg->req_uri.len); + srjson_AddStrToObject( &jdoc, jdoc.root, "tag1", dlg->tag[0].s, dlg->tag[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", dlg->cseq[0].s, @@ -578,14 +579,16 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, srjson_AddNumberToObject( &jdoc, jdoc.root, "lifetime", dlg->lifetime); - srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", - dlg->tag[0].s, dlg->tag[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", - dlg->cseq[0].s, dlg->cseq[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", - dlg->route_set[0].s, dlg->route_set[0].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", - dlg->contact[0].s, dlg->contact[0].len); + if(action != DLG_DMQ_UPDATE) { + srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", + dlg->tag[0].s, dlg->tag[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", + dlg->cseq[0].s, dlg->cseq[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", + dlg->route_set[0].s, dlg->route_set[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", + dlg->contact[0].s, dlg->contact[0].len); + } break; case DLG_STATE_CONFIRMED: srjson_AddNumberToObject( @@ -593,23 +596,24 @@ int dlg_dmq_replicate_action(dlg_dmq_action_t action, dlg_cell_t *dlg, srjson_AddNumberToObject( &jdoc, jdoc.root, "lifetime", dlg->lifetime); - srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", - dlg->tag[0].s, dlg->tag[0].len); + if(action != DLG_DMQ_UPDATE) { + srjson_AddStrToObject(&jdoc, jdoc.root, "tag1", + dlg->tag[0].s, dlg->tag[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", + dlg->cseq[0].s, dlg->cseq[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", + dlg->route_set[0].s, dlg->route_set[0].len); + srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", + dlg->contact[0].s, dlg->contact[0].len); + } srjson_AddStrToObject(&jdoc, jdoc.root, "tag2", dlg->tag[1].s, dlg->tag[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "cseq1", - dlg->cseq[0].s, dlg->cseq[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "cseq2", dlg->cseq[1].s, dlg->cseq[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "route_set1", - dlg->route_set[0].s, dlg->route_set[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "route_set2", dlg->route_set[1].s, dlg->route_set[1].len); - srjson_AddStrToObject(&jdoc, jdoc.root, "contact1", - dlg->contact[0].s, dlg->contact[0].len); srjson_AddStrToObject(&jdoc, jdoc.root, "contact2", dlg->contact[1].s, dlg->contact[1].len); - break; case DLG_STATE_DELETED: //dlg->iflags &= ~DLG_IFLAG_DMQ_SYNC;

1 year

Jenkins build is still unstable: kamailiodev-nightly-binaries » amd64,stretch #2544

by kamailio＠sipwise.com

See <https://kamailio.sipwise.com/job/kamailiodev-nightly-binaries/architecture=…>

1 year

git:master:2f98aaca: ims_ipsec_pcscf: declare vars at beginning of the block

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 2f98aaca9e4b71b8086abce4c2b41c215fb2a26f URL: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-04T20:33:40+01:00 ims_ipsec_pcscf: declare vars at beginning of the block --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… Patch: https://github.com/kamailio/kamailio/commit/2f98aaca9e4b71b8086abce4c2b41c2… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index 80a714559ba..de61ad7cf6b 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -806,6 +806,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) struct pcontact_info ci; int ret = IPSEC_CMD_FAIL; // FAIL by default tm_cell_t *t = NULL; + sip_msg_t *req = NULL; + security_t *req_sec_params = NULL; + ipsec_t *s = NULL; + ipsec_t *old_s = NULL; if(m->first_line.type == SIP_REPLY) { t = tmb.t_gett(); @@ -847,12 +851,10 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) goto cleanup; } - struct sip_msg *req = t->uas.request; + req = t->uas.request; // Parse security parameters from the REGISTER request and get some data for the new tunnels - security_t *req_sec_params = cscf_get_security(req); - ipsec_t *s; - ipsec_t *old_s = NULL; + req_sec_params = cscf_get_security(req); // Update contacts only for initial registration, for re-registration the existing contacts shouldn't be updated. if(ci.via_port == SIP_PORT

1 year

git:master:812df264: ims_ipsec_pcscf: handle IPSec registration case where first SIP REGISTER does not have VIA port as 5060

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 812df26470b50d626ce9ee03b9272373b231ce2a URL: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… Author: Supreeth Herle <herlesupreeth(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-12-04T20:29:40+01:00 ims_ipsec_pcscf: handle IPSec registration case where first SIP REGISTER does not have VIA port as 5060 --- Modified: src/modules/ims_ipsec_pcscf/cmd.c --- Diff: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… Patch: https://github.com/kamailio/kamailio/commit/812df26470b50d626ce9ee03b927237… --- diff --git a/src/modules/ims_ipsec_pcscf/cmd.c b/src/modules/ims_ipsec_pcscf/cmd.c index c863eff5407..80a714559ba 100644 --- a/src/modules/ims_ipsec_pcscf/cmd.c +++ b/src/modules/ims_ipsec_pcscf/cmd.c @@ -855,7 +855,9 @@ int ipsec_create(struct sip_msg *m, udomain_t *d, int _cflags) ipsec_t *old_s = NULL; // Update contacts only for initial registration, for re-registration the existing contacts shouldn't be updated. - if(ci.via_port == SIP_PORT) { + if(ci.via_port == SIP_PORT + || (pcontact->security_temp->data.ipsec->port_ps == 0 + && pcontact->security_temp->data.ipsec->port_pc == 0)) { LM_DBG("Registration for contact with AOR [%.*s], VIA [%d://%.*s:%d], " "received_host [%d://%.*s:%d]\n", ci.aor.len, ci.aor.s, ci.via_prot, ci.via_host.len,

1 year

[kamailio/kamailio] Hi, could you provide me with a .cfg demo for using SEMS as Announcements in the IMS module? (Issue #3662)

by Helloworld1668

Hello Kamailio team, I am an enthusiast of the Kamailio project, interested in an IMS project. I am working on integrating Kamailio with SEMS and am keen to utilize SEMS's Announcements (Prompts, Ringbacktones, Pre-call-prompts) feature. However, in the current project's PCSCF module, SEMS is being used as an SBC. Could you possibly provide some .cfg demos for using SEMS specifically for Announcements? I would greatly appreciate your assistance. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3662 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3662(a)github.com>

1 year

[kamailio/kamailio] [Textops] replace_body_all does not apply for SDP which process from RTPEngine (Issue #3661)

by Jakihiko

the function replace_body_all place after rtpengine_offer(), I expect that it will change the SDP however actually It does not. pseudo code like: ``` rtpengine_offer(); replace_body_all("Asterisk", "NipponMedia"); ``` -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3661 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3661(a)github.com>

1 year

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev December 2023