sr-dev February 2023

sr-dev@lists.kamailio.org

10 participants
299 discussions

[kamailio/kamailio] Typos (PR #3357)
by Дилян Палаузов 08 Feb '23

08 Feb '23

You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3357 -- Commit Summary -- * usrloc: typos * src/lib: typos * acc: typos * acc_diameter: typos -- File Changes -- M src/lib/Makefile.defs (6) M src/lib/README (2) M src/lib/binrpc/binrpc_api.c (2) M src/lib/binrpc/binrpc_api.h (2) M src/lib/cds/doc/destroy_sstream.xml (4) M src/lib/cds/dstring.h (2) M src/lib/cds/msg_queue.c (2) M src/lib/cds/… [View More]

2 1

git:master:8fbd788c: acc_diameter: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 8fbd788c5ae29df35b9fbde2ec60efd3fa4df0df URL: https://github.com/kamailio/kamailio/commit/8fbd788c5ae29df35b9fbde2ec60efd… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 acc_diameter: typos --- Modified: src/modules/acc_diameter/acc_diameter_mod.c Modified: src/modules/acc_diameter/diam_avp.c Modified: src/modules/… [View More]acc_diameter/diam_message.c Modified: src/modules/acc_diameter/diam_tcp.c Modified: src/modules/acc_diameter/doc/acc_diameter_admin.xml --- Diff: https://github.com/kamailio/kamailio/commit/8fbd788c5ae29df35b9fbde2ec60efd… Patch: https://github.com/kamailio/kamailio/commit/8fbd788c5ae29df35b9fbde2ec60efd… --- diff --git a/src/modules/acc_diameter/acc_diameter_mod.c b/src/modules/acc_diameter/acc_diameter_mod.c index 5bdf0765dce..04cf17d1f4a 100644 --- a/src/modules/acc_diameter/acc_diameter_mod.c +++ b/src/modules/acc_diameter/acc_diameter_mod.c @@ -76,7 +76,7 @@ acc_engine_t _acc_diameter_engine; /* ----- DIAMETER acc variables ----------- */ -/*! \name AccDiamaterVariables Radius Variables */ +/*! \name AccDiameterVariables Radius Variables */ /*@{*/ int diameter_flag = -1; int diameter_missed_flag = -1; @@ -287,7 +287,7 @@ int acc_diam_init(acc_extra_t *leg_info) m = extra2int( leg_info, diam_attrs+n); if (m<0) { - LM_ERR("leg info names for DIAMTER must be integer AVP codes\n"); + LM_ERR("leg info names for DIAMETER must be integer AVP codes\n"); return -1; } n += m; diff --git a/src/modules/acc_diameter/diam_avp.c b/src/modules/acc_diameter/diam_avp.c index f8ad15a525e..aeb363f6430 100644 --- a/src/modules/acc_diameter/diam_avp.c +++ b/src/modules/acc_diameter/diam_avp.c @@ -53,7 +53,7 @@ void set_avp_fields( AAA_AVPCode code, AAA_AVP *avp) case 296: /*AVP Origin_Realm*/ case 400: /* AVP_Resource */ case 401: /* AVP_Response */ - case 402: /* AVP_Chalenge */ + case 402: /* AVP_Challenge */ case 403: /* AVP_Method */ case 404: /* Service_Type AVP */ case 405: /* User_Group AVP*/ @@ -62,7 +62,7 @@ void set_avp_fields( AAA_AVPCode code, AAA_AVP *avp) avp->type = AAA_AVP_STRING_TYPE; break; case 27: /*AVP_Session_Timeout*/ - case 258: /*AVP_Auth_Aplication_Id*/ + case 258: /*AVP_Auth_Application_Id*/ case 262: /*AVP_Redirect_Max_Cache_Time*/ case 265: /*AVP_Supported_Vendor_Id*/ case 266: /*AVP_Vendor_Id*/ diff --git a/src/modules/acc_diameter/diam_message.c b/src/modules/acc_diameter/diam_message.c index 098b51e9066..9b39d25c167 100644 --- a/src/modules/acc_diameter/diam_message.c +++ b/src/modules/acc_diameter/diam_message.c @@ -230,7 +230,7 @@ AAAMessage* AAATranslateMessage( unsigned char* source, unsigned int sourceLen, msg_len = get_3bytes( ptr ); ptr += MESSAGE_LENGTH_SIZE; if (msg_len>sourceLen) { - LM_ERR("AAA message len [%d] bigger then buffer len [%d]\n", + LM_ERR("AAA message len [%d] bigger than buffer len [%d]\n", msg_len,sourceLen); goto error; } diff --git a/src/modules/acc_diameter/diam_tcp.c b/src/modules/acc_diameter/diam_tcp.c index 19cf2c76e90..e7412533784 100644 --- a/src/modules/acc_diameter/diam_tcp.c +++ b/src/modules/acc_diameter/diam_tcp.c @@ -77,7 +77,7 @@ int init_mytcp(char* host, int port) if (connect(sfd, (const struct sockaddr *)&serv_addr, sizeof(serv_addr)) < 0) { - LM_ERR("failed to connec to the DIAMETER client\n"); + LM_ERR("failed to connect to the DIAMETER client\n"); close(sfd); return -1; } diff --git a/src/modules/acc_diameter/doc/acc_diameter_admin.xml b/src/modules/acc_diameter/doc/acc_diameter_admin.xml index f3bf9dd52f9..c2251c9a82b 100644 --- a/src/modules/acc_diameter/doc/acc_diameter_admin.xml +++ b/src/modules/acc_diameter/doc/acc_diameter_admin.xml @@ -46,7 +46,7 @@ <section> <title>&kamailio; Modules</title> <para> - The module depends on the following modules (in the other words + The module depends on the following modules (in other words the listed modules must be loaded before this module): <itemizedlist> <listitem> [View Less]

1 0

git:master:901d9cac: acc: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 901d9cac2f69b78d3d7d2ff52696a37276446b3b URL: https://github.com/kamailio/kamailio/commit/901d9cac2f69b78d3d7d2ff52696a37… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 acc: typos --- Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc_api.h Modified: src/modules/acc/acc_logic.c Modified: src/modules/acc/… [View More]

1 0

git:master:fdce4fe9: src/lib: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: fdce4fe980dda02fd76dc06912dac585992d6759 URL: https://github.com/kamailio/kamailio/commit/fdce4fe980dda02fd76dc06912dac58… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 src/lib: typos --- Modified: src/lib/Makefile.defs Modified: src/lib/README Modified: src/lib/binrpc/binrpc_api.c Modified: src/lib/binrpc/… [View More]

1 0

git:master:6c4f9b04: usrloc: typos
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 6c4f9b049e784fc9aff65bfcef6f366b78fff48e URL: https://github.com/kamailio/kamailio/commit/6c4f9b049e784fc9aff65bfcef6f366… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 usrloc: typos --- Modified: src/modules/usrloc/doc/usrloc_admin.xml Modified: src/modules/usrloc/doc/usrloc_devel.xml Modified: src/modules/usrloc/… [View More]

1 0

git:master:46e9963e: modules: readme files regenerated - uac ... [skip ci]
by Kamailio Dev 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 46e9963e07a44077184ac503cc72ff9d57c532d0 URL: https://github.com/kamailio/kamailio/commit/46e9963e07a44077184ac503cc72ff9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-02-08T11:01:27+01:00 modules: readme files regenerated - uac ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/46e9963e07a44077184ac503cc72ff9… … [View More]

1 0

git:master:76df5390: uac: allow uac_auth* functions call from t_on_branch_failure event route
by Daniel-Constantin Mierla 08 Feb '23

08 Feb '23

Module: kamailio Branch: master Commit: 76df53900b96852345d1ef368e5539197a3c5570 URL: https://github.com/kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… Author: ovoshlook <ovoshlook(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T10:59:09+01:00 uac: allow uac_auth* functions call from t_on_branch_failure event route --- Modified: src/modules/uac/doc/uac_admin.xml Modified: src/modules/uac/uac.c --- Diff: https://github.com/… [View More]kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… Patch: https://github.com/kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 68123e5af5..b51fc4483c 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -886,7 +886,7 @@ uac_restore_to(); The parameter can be a static integer or a variable holding an integer value. </para> <para> - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE event route. </para> <example> <title><function>uac_auth</function> usage</title> @@ -938,7 +938,7 @@ failure_route[TRUNKAUTH] { The parameter can be a static integer or a variable holding an integer value. </para> <para> - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE event route. </para> <example> <title><function>uac_auth_mode</function> usage</title> diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 50873ef557..f768f82ed1 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -136,11 +136,14 @@ static cmd_export_t cmds[]={ {"uac_replace_to", (cmd_function)w_replace_to, 1, fixup_spve_spve, 0, REQUEST_ROUTE | BRANCH_ROUTE }, {"uac_restore_to", (cmd_function)w_restore_to, 0, 0, 0, REQUEST_ROUTE }, - {"uac_auth", (cmd_function)w_uac_auth, 0, 0, 0, FAILURE_ROUTE }, + {"uac_auth", (cmd_function)w_uac_auth, 0, 0, 0, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_auth", (cmd_function)w_uac_auth_mode, 1, - fixup_igp_null, fixup_free_igp_null, FAILURE_ROUTE }, + fixup_igp_null, fixup_free_igp_null, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_auth_mode", (cmd_function)w_uac_auth_mode, 1, - fixup_igp_null, fixup_free_igp_null, FAILURE_ROUTE }, + fixup_igp_null, fixup_free_igp_null, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_req_send", (cmd_function)w_uac_req_send, 0, 0, 0, ANY_ROUTE}, {"uac_reg_lookup", (cmd_function)w_uac_reg_lookup, 2, fixup_spve_pvar, fixup_free_spve_pvar, ANY_ROUTE }, [View Less]

1 0

[kamailio/kamailio] uac: allow uac_auth* functions call from t_on_branch_failure event route (PR #3360)
by ovoshlook 08 Feb '23

08 Feb '23

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Adds the possibility to call uac_auth* functions from the t_branch_on_failure event route Useful in case of MID_REGISTRAR implementation, especially when REGISTER forked to multiple registrars and each one requests authentication requests separately Result example: ![image](https://user-images.githubusercontent.com/8499399/216847091-17f8b9f0-1a08-47d1-89ee-978007cef36b.png) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3360 -- Commit Summary -- * uac: allow uac_auth* functions call from t_on_branch_failure event route -- File Changes -- M src/modules/uac/doc/uac_admin.xml (4) M src/modules/uac/uac.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3360.patch https://github.com/kamailio/kamailio/pull/3360.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3360 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3360(a)github.com> [View Less]

2 2

git:master:63095ef1: lib/ims: check return of strtok(...)
by Daniel-Constantin Mierla 07 Feb '23

07 Feb '23

Module: kamailio Branch: master Commit: 63095ef1bef36a35952ed265f41d87ccbc1bba70 URL: https://github.com/kamailio/kamailio/commit/63095ef1bef36a35952ed265f41d87c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-07T12:57:04+01:00 lib/ims: check return of strtok(...) --- Modified: src/lib/ims/ims_getters.c --- Diff: https://github.com/kamailio/kamailio/commit/63095ef1bef36a35952ed265f41d87c… Patch: … [View More]

1 0

[kamailio/kamailio] typos https://kamailio.org/docs/db-tables/kamailio-db-devel.html (Issue #3361)
by Дилян Палаузов 07 Feb '23

07 Feb '23

https://kamailio.org/docs/db-tables/kamailio-db-devel.html#idm9040 contains: * thay instead of they, (UID_AUTH_DB Module) * `,if` without comma in between (in UAC Module) * for table "uacreg" column realm is described as “Remote username”, it should be Remote realm For table dbaliases indexes contains: * alias_user_idx on column alias_username * alias_idx composite index on columns alias_username and alias_domain I would say the composite index will also be used on queries only on the … [View More]

2 4

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2023