sr-dev February 2023

sr-dev@lists.kamailio.org

10 participants
296 discussions

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: fdce4fe980dda02fd76dc06912dac585992d6759 URL: https://github.com/kamailio/kamailio/commit/fdce4fe980dda02fd76dc06912dac58… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 src/lib: typos --- Modified: src/lib/Makefile.defs Modified: src/lib/README Modified: src/lib/binrpc/binrpc_api.c Modified: src/lib/binrpc/binrpc_api.h Modified: src/lib/cds/doc/destroy_sstream.xml Modified: src/lib/cds/dstring.h Modified: src/lib/cds/msg_queue.c Modified: src/lib/cds/msg_queue.h Modified: src/lib/cds/sstr.h Modified: src/lib/ims/ims_getters.c Modified: src/lib/ims/ims_getters.h Modified: src/lib/presence/notifier.h Modified: src/lib/presence/notifier_domain.c Modified: src/lib/presence/subscriber.h Modified: src/lib/presence/xml_utils.c Modified: src/lib/srdb2/db_con.c Modified: src/lib/srdb2/db_gen.h Modified: src/lib/xcap/xcap_client.c Modified: src/lib/xcap/xml_utils.c --- Diff: https://github.com/kamailio/kamailio/commit/fdce4fe980dda02fd76dc06912dac58… Patch: https://github.com/kamailio/kamailio/commit/fdce4fe980dda02fd76dc06912dac58…

1 year, 9 months

git:master:6c4f9b04: usrloc: typos

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 6c4f9b049e784fc9aff65bfcef6f366b78fff48e URL: https://github.com/kamailio/kamailio/commit/6c4f9b049e784fc9aff65bfcef6f366… Author: �� <git-dpa(a)aegee.org> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T11:32:19+01:00 usrloc: typos --- Modified: src/modules/usrloc/doc/usrloc_admin.xml Modified: src/modules/usrloc/doc/usrloc_devel.xml Modified: src/modules/usrloc/udomain.c Modified: src/modules/usrloc/urecord.c Modified: src/modules/usrloc/urecord.h --- Diff: https://github.com/kamailio/kamailio/commit/6c4f9b049e784fc9aff65bfcef6f366… Patch: https://github.com/kamailio/kamailio/commit/6c4f9b049e784fc9aff65bfcef6f366…

1 year, 9 months

git:master:46e9963e: modules: readme files regenerated - uac ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 46e9963e07a44077184ac503cc72ff9d57c532d0 URL: https://github.com/kamailio/kamailio/commit/46e9963e07a44077184ac503cc72ff9… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-02-08T11:01:27+01:00 modules: readme files regenerated - uac ... [skip ci] --- Modified: src/modules/uac/README --- Diff: https://github.com/kamailio/kamailio/commit/46e9963e07a44077184ac503cc72ff9… Patch: https://github.com/kamailio/kamailio/commit/46e9963e07a44077184ac503cc72ff9… --- diff --git a/src/modules/uac/README b/src/modules/uac/README index f87187cf9a..652344958a 100644 --- a/src/modules/uac/README +++ b/src/modules/uac/README @@ -828,7 +828,8 @@ uac_restore_to(); format. The parameter can be a static integer or a variable holding an integer value. - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE + event route. Example 1.31. uac_auth usage ... @@ -872,7 +873,8 @@ failure_route[TRUNKAUTH] { format. The parameter can be a static integer or a variable holding an integer value. - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE + event route. Example 1.32. uac_auth_mode usage ...

1 year, 9 months

git:master:76df5390: uac: allow uac_auth* functions call from t_on_branch_failure event route

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 76df53900b96852345d1ef368e5539197a3c5570 URL: https://github.com/kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… Author: ovoshlook <ovoshlook(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-08T10:59:09+01:00 uac: allow uac_auth* functions call from t_on_branch_failure event route --- Modified: src/modules/uac/doc/uac_admin.xml Modified: src/modules/uac/uac.c --- Diff: https://github.com/kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… Patch: https://github.com/kamailio/kamailio/commit/76df53900b96852345d1ef368e55391… --- diff --git a/src/modules/uac/doc/uac_admin.xml b/src/modules/uac/doc/uac_admin.xml index 68123e5af5..b51fc4483c 100644 --- a/src/modules/uac/doc/uac_admin.xml +++ b/src/modules/uac/doc/uac_admin.xml @@ -886,7 +886,7 @@ uac_restore_to(); The parameter can be a static integer or a variable holding an integer value. </para> <para> - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE event route. </para> <example> <title><function>uac_auth</function> usage</title> @@ -938,7 +938,7 @@ failure_route[TRUNKAUTH] { The parameter can be a static integer or a variable holding an integer value. </para> <para> - This function can be used from FAILURE_ROUTE. + This function can be used from FAILURE_ROUTE and BRANCH_FAILURE_ROUTE event route. </para> <example> <title><function>uac_auth_mode</function> usage</title> diff --git a/src/modules/uac/uac.c b/src/modules/uac/uac.c index 50873ef557..f768f82ed1 100644 --- a/src/modules/uac/uac.c +++ b/src/modules/uac/uac.c @@ -136,11 +136,14 @@ static cmd_export_t cmds[]={ {"uac_replace_to", (cmd_function)w_replace_to, 1, fixup_spve_spve, 0, REQUEST_ROUTE | BRANCH_ROUTE }, {"uac_restore_to", (cmd_function)w_restore_to, 0, 0, 0, REQUEST_ROUTE }, - {"uac_auth", (cmd_function)w_uac_auth, 0, 0, 0, FAILURE_ROUTE }, + {"uac_auth", (cmd_function)w_uac_auth, 0, 0, 0, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_auth", (cmd_function)w_uac_auth_mode, 1, - fixup_igp_null, fixup_free_igp_null, FAILURE_ROUTE }, + fixup_igp_null, fixup_free_igp_null, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_auth_mode", (cmd_function)w_uac_auth_mode, 1, - fixup_igp_null, fixup_free_igp_null, FAILURE_ROUTE }, + fixup_igp_null, fixup_free_igp_null, + FAILURE_ROUTE | BRANCH_FAILURE_ROUTE | EVENT_ROUTE }, {"uac_req_send", (cmd_function)w_uac_req_send, 0, 0, 0, ANY_ROUTE}, {"uac_reg_lookup", (cmd_function)w_uac_reg_lookup, 2, fixup_spve_pvar, fixup_free_spve_pvar, ANY_ROUTE },

1 year, 9 months

[kamailio/kamailio] uac: allow uac_auth* functions call from t_on_branch_failure event route (PR #3360)

by ovoshlook

#### Pre-Submission Checklist - [x] Commit message has the format required by CONTRIBUTING guide - [x] Commits are split per component (core, individual modules, libs, utils, ...) - [x] Each component has a single commit (if not, squash them into one commit) - [x] No commits to README files for modules (changes must be done to docbook files in `doc/` subfolder, the README file is autogenerated) #### Type Of Change - [ ] Small bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds new functionality) - [ ] Breaking change (fix or feature that would change existing functionality) #### Checklist:  - [x] PR should be backported to stable branches - [x] Tested changes locally - [ ] Related to issue #XXXX (replace XXXX with an open issue number) #### Description Adds the possibility to call uac_auth* functions from the t_branch_on_failure event route Useful in case of MID_REGISTRAR implementation, especially when REGISTER forked to multiple registrars and each one requests authentication requests separately Result example: ![image](https://user-images.githubusercontent.com/8499399/216847091-17f8b9f0-1a08-47d1-89ee-978007cef36b.png) You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3360 -- Commit Summary -- * uac: allow uac_auth* functions call from t_on_branch_failure event route -- File Changes -- M src/modules/uac/doc/uac_admin.xml (4) M src/modules/uac/uac.c (9) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3360.patch https://github.com/kamailio/kamailio/pull/3360.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3360 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3360(a)github.com>

1 year, 9 months

git:master:63095ef1: lib/ims: check return of strtok(...)

by Daniel-Constantin Mierla

Module: kamailio Branch: master Commit: 63095ef1bef36a35952ed265f41d87ccbc1bba70 URL: https://github.com/kamailio/kamailio/commit/63095ef1bef36a35952ed265f41d87c… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-02-07T12:57:04+01:00 lib/ims: check return of strtok(...) --- Modified: src/lib/ims/ims_getters.c --- Diff: https://github.com/kamailio/kamailio/commit/63095ef1bef36a35952ed265f41d87c… Patch: https://github.com/kamailio/kamailio/commit/63095ef1bef36a35952ed265f41d87c… --- diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index 1e47e20e3d..1dda5f139b 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -1247,12 +1247,13 @@ int cscf_get_p_charging_vector(struct sip_msg *msg, str * icid, str * orig_ioi, LM_DBG("p_charging_vector body is %.*s\n", header_body.len, header_body.s); p = strtok(header_body.s, " ;:\r\t\n\"="); - loop: if (p > (header_body.s + header_body.len)) +loop: + if (p == NULL || p > (header_body.s + header_body.len)) return 1; if (strncmp(p, "icid-value", 10) == 0) { p = strtok(NULL, " ;:\r\t\n\"="); - if (p > (header_body.s + header_body.len)) { + if (p == NULL || p > (header_body.s + header_body.len)) { LM_ERR("cscf_get_p_charging_vector: no value for icid\n"); return 0; } @@ -1272,7 +1273,7 @@ int cscf_get_p_charging_vector(struct sip_msg *msg, str * icid, str * orig_ioi, } else if (strncmp(p, "orig-ioi", 8) == 0) { p = strtok(NULL, " ;:\r\t\n\"="); - if (p > (header_body.s + header_body.len)) { + if (p == NULL || p > (header_body.s + header_body.len)) { LM_ERR("cscf_get_p_charging_vector: no value for icid\n"); return 0; } @@ -1292,7 +1293,7 @@ int cscf_get_p_charging_vector(struct sip_msg *msg, str * icid, str * orig_ioi, } else if (strncmp(p, "term-ioi", 8) == 0) { p = strtok(NULL, " ;:\r\t\n\"="); - if (p > (header_body.s + header_body.len)) { + if (p == NULL || p > (header_body.s + header_body.len)) { LM_ERR("cscf_get_p_charging_vector: no value for icid\n"); return 0; } @@ -1314,7 +1315,7 @@ int cscf_get_p_charging_vector(struct sip_msg *msg, str * icid, str * orig_ioi, LM_DBG("end\n"); str_free(header_body, pkg); return 1; - out_of_memory: +out_of_memory: PKG_MEM_ERROR; return 0; }

1 year, 9 months

[kamailio/kamailio] typos https://kamailio.org/docs/db-tables/kamailio-db-devel.html (Issue #3361)

by Дилян Палаузов

https://kamailio.org/docs/db-tables/kamailio-db-devel.html#idm9040 contains: * thay instead of they, (UID_AUTH_DB Module) * `,if` without comma in between (in UAC Module) * for table "uacreg" column realm is described as “Remote username”, it should be Remote realm For table dbaliases indexes contains: * alias_user_idx on column alias_username * alias_idx composite index on columns alias_username and alias_domain I would say the composite index will also be used on queries only on the alias_username column, so the index alias_user_idx is redundant and should be deleted. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3361 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3361(a)github.com>

1 year, 9 months

[kamailio/kamailio] Unclear default value for mem_join (Issue #3355)

by Дилян Палаузов

According to https://www.kamailio.org/wikidocs/cookbooks/devel/core/#mem_join the default value for mem_join is `1 (enabled)`. [https://github.com/kamailio/kamailio-wiki/blob/main/docs/tutorials/troubles… says: > In order to merge the free memory fragments one should enable memory join. Default is disabled (mem_join=0). So depending on the source of information the default value of mem_join is different. -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/issues/3355 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/issues/3355(a)github.com>

1 year, 9 months

git:master:7a960bd9: modules: readme files regenerated - websocket ... [skip ci]

by Kamailio Dev

Module: kamailio Branch: master Commit: 7a960bd9d0002516dcbb50b89dd5d4ab5c38eb61 URL: https://github.com/kamailio/kamailio/commit/7a960bd9d0002516dcbb50b89dd5d4a… Author: Kamailio Dev <kamailio.dev(a)kamailio.org> Committer: Kamailio Dev <kamailio.dev(a)kamailio.org> Date: 2023-02-03T19:01:20+01:00 modules: readme files regenerated - websocket ... [skip ci] --- Modified: src/modules/websocket/README --- Diff: https://github.com/kamailio/kamailio/commit/7a960bd9d0002516dcbb50b89dd5d4a… Patch: https://github.com/kamailio/kamailio/commit/7a960bd9d0002516dcbb50b89dd5d4a… --- diff --git a/src/modules/websocket/README b/src/modules/websocket/README index bc808cbefb..7bbe8527a9 100644 --- a/src/modules/websocket/README +++ b/src/modules/websocket/README @@ -72,7 +72,7 @@ Peter Dunkley 1.9. Set cors_mode parameter 1.10. Set verbose_list parameter 1.11. Set event_callback parameter - 1.12. Set timer_intervalparameter + 1.12. Set timer_interval parameter 1.13. Set rm_delay_intervalparameter 1.14. ws_handle_handshake usage 1.15. ws_close usage @@ -504,7 +504,7 @@ end Default value is 1. - Example 1.12. Set timer_intervalparameter + Example 1.12. Set timer_interval parameter ... modparam("websocket", "timer_interval", 5) ...

1 year, 9 months

[kamailio/kamailio] websocket: move some logging from ERROR to INFO (PR #3349)

by Дилян Палаузов

I run Kamailio with ``` log_stderror=yes /* LOG Levels: 3=DBG, 2=INFO, 1=NOTICE, 0=WARN, -1=ERR, ... */ debug=-1 ``` and inspect the output. Some messages from the websocket module are logged repeatedly at ERROR-level, but they are in no way errors. This changes moves such periodially logged no-error messages to debug-level INFO. You can view, comment on, or merge this pull request online at: https://github.com/kamailio/kamailio/pull/3349 -- Commit Summary -- * websocket: move some logging from ERROR to INFO -- File Changes -- M src/modules/websocket/doc/websocket_admin.xml (2) M src/modules/websocket/utf8_decode.h (2) M src/modules/websocket/ws_frame.c (6) -- Patch Links -- https://github.com/kamailio/kamailio/pull/3349.patch https://github.com/kamailio/kamailio/pull/3349.diff -- Reply to this email directly or view it on GitHub: https://github.com/kamailio/kamailio/pull/3349 You are receiving this because you are subscribed to this thread. Message ID: <kamailio/kamailio/pull/3349(a)github.com>

1 year, 9 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev February 2023