sr-dev March 2023

sr-dev@lists.kamailio.org

14 participants
251 discussions

git:master:19c9d56f: auth_ephemeral: convert to memory logging helper
by Henning Westerholt 29 Mar '23

29 Mar '23

Module: kamailio Branch: master Commit: 19c9d56f3f6a53433949d2dac5494ad7b3b393a0 URL: https://github.com/kamailio/kamailio/commit/19c9d56f3f6a53433949d2dac5494ad… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-29T09:14:24Z auth_ephemeral: convert to memory logging helper --- Modified: src/modules/auth_ephemeral/auth_ephemeral_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/19c9d56f3f6a53433949d2dac5494ad… Patch: https://github.com/kamailio/kamailio/commit/19c9d56f3f6a53433949d2dac5494ad… --- diff --git a/src/modules/auth_ephemeral/auth_ephemeral_mod.c b/src/modules/auth_ephemeral/auth_ephemeral_mod.c index 2a00c7879d9..717432caa89 100644 --- a/src/modules/auth_ephemeral/auth_ephemeral_mod.c +++ b/src/modules/auth_ephemeral/auth_ephemeral_mod.c @@ -223,7 +223,7 @@ static inline int add_secret(str _secret_key) secret_struct = (struct secret *) shm_malloc(sizeof(struct secret)); if (secret_struct == NULL) { - LM_ERR("unable to allocate shared memory\n"); + SHM_MEM_ERROR; return -1; } @@ -313,7 +313,7 @@ static int secret_param(modparam_t _type, void *_val) sval.s = (char *) shm_malloc(sizeof(char) * sval.len); if (sval.s == NULL) { - LM_ERR("unable to allocate shared memory\n"); + SHM_MEM_ERROR; return -1; } memcpy(sval.s, (char *) _val, sval.len); @@ -363,7 +363,7 @@ void autheph_rpc_add_secret(rpc_t* rpc, void* ctx) sval.s = shm_malloc(sizeof(char) * sval.len); if (sval.s == NULL) { - LM_ERR("Unable to allocate shared memory\n"); + SHM_MEM_ERROR; rpc->fault(ctx, 500, "Not enough memory"); return; }

1 0

git:master:bc47875c: auth_diameter: add missing allocation checks, convert to memory logging helper, clarify logging
by Henning Westerholt 29 Mar '23

29 Mar '23

Module: kamailio Branch: master Commit: bc47875c2da39e755009c81ba1f2b4e7267b905e URL: https://github.com/kamailio/kamailio/commit/bc47875c2da39e755009c81ba1f2b4e… Author: Pantelis Kolatsis <pk(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-29T09:11:41Z auth_diameter: add missing allocation checks, convert to memory logging helper, clarify logging --- Modified: src/modules/auth_diameter/auth_diameter.c Modified: src/modules/auth_diameter/authorize.c Modified: src/modules/auth_diameter/avp.c Modified: src/modules/auth_diameter/message.c Modified: src/modules/auth_diameter/tcp_comm.c Modified: src/modules/auth_diameter/user_in.c --- Diff: https://github.com/kamailio/kamailio/commit/bc47875c2da39e755009c81ba1f2b4e… Patch: https://github.com/kamailio/kamailio/commit/bc47875c2da39e755009c81ba1f2b4e…

1 0

git:master:811ede41: acc_diameter: convert to memory logging helper
by Henning Westerholt 29 Mar '23

29 Mar '23

Module: kamailio Branch: master Commit: 811ede41167455369518adadff338a2064645d55 URL: https://github.com/kamailio/kamailio/commit/811ede41167455369518adadff338a2… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-29T08:26:53Z acc_diameter: convert to memory logging helper --- Modified: src/modules/acc_diameter/diam_avp.c --- Diff: https://github.com/kamailio/kamailio/commit/811ede41167455369518adadff338a2… Patch: https://github.com/kamailio/kamailio/commit/811ede41167455369518adadff338a2… --- diff --git a/src/modules/acc_diameter/diam_avp.c b/src/modules/acc_diameter/diam_avp.c index aeb363f6430..6df88397fe4 100644 --- a/src/modules/acc_diameter/diam_avp.c +++ b/src/modules/acc_diameter/diam_avp.c @@ -150,7 +150,7 @@ AAA_AVP* AAACreateAVP( return avp; error: - LM_ERR("no more free memory for a new AVP!\n"); + PKG_MEM_ERROR_FMT("for a new AVP!\n"); if(avp) ad_free(avp); return 0; }

1 0

git:master:0b9442b1: acc: convert to memory logging helper, properly free memory in case of errors
by Henning Westerholt 29 Mar '23

29 Mar '23

Module: kamailio Branch: master Commit: 0b9442b14adccdc7305ba222833a149e64488d66 URL: https://github.com/kamailio/kamailio/commit/0b9442b14adccdc7305ba222833a149… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-29T08:23:13Z acc: convert to memory logging helper, properly free memory in case of errors --- Modified: src/modules/acc/acc.c Modified: src/modules/acc/acc_cdr.c Modified: src/modules/acc/acc_extra.c --- Diff: https://github.com/kamailio/kamailio/commit/0b9442b14adccdc7305ba222833a149… Patch: https://github.com/kamailio/kamailio/commit/0b9442b14adccdc7305ba222833a149… --- diff --git a/src/modules/acc/acc.c b/src/modules/acc/acc.c index 6e9d8ed5a48..216ff7685fc 100644 --- a/src/modules/acc/acc.c +++ b/src/modules/acc/acc.c @@ -634,32 +634,37 @@ void acc_api_set_arrays(acc_info_t *inf) int acc_arrays_alloc(void) { if ((val_arr = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(str))) == NULL) { - LM_ERR("failed to alloc val_arr\n"); + PKG_MEM_ERROR_FMT("failed to alloc val_arr\n"); return -1; } if ((int_arr = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(int))) == NULL) { - LM_ERR("failed to alloc int_arr\n"); + PKG_MEM_ERROR_FMT("failed to alloc int_arr\n"); + acc_arrays_free(); return -1; } if ((type_arr = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(char))) == NULL) { - LM_ERR("failed to alloc type_arr\n"); + PKG_MEM_ERROR_FMT("failed to alloc type_arr\n"); + acc_arrays_free(); return -1; } if ((log_attrs = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(str))) == NULL) { - LM_ERR("failed to alloc log_attrs\n"); + PKG_MEM_ERROR_FMT("failed to alloc log_attrs\n"); + acc_arrays_free(); return -1; } if ((db_keys = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(db_key_t))) == NULL) { - LM_ERR("failed to alloc db_keys\n"); + PKG_MEM_ERROR_FMT("failed to alloc db_keys\n"); + acc_arrays_free(); return -1; } if ((db_vals = pkg_mallocxz((ACC_CORE_LEN + acc_extra_size + MAX_ACC_LEG + 3) * sizeof(db_val_t))) == NULL) { - LM_ERR("failed to alloc db_vals\n"); + PKG_MEM_ERROR_FMT("failed to alloc db_vals\n"); + acc_arrays_free(); return -1; } diff --git a/src/modules/acc/acc_cdr.c b/src/modules/acc/acc_cdr.c index d15340b3481..0afa7630352 100644 --- a/src/modules/acc/acc_cdr.c +++ b/src/modules/acc/acc_cdr.c @@ -1028,32 +1028,37 @@ void cdr_api_set_arrays(cdr_info_t *inf) int cdr_arrays_alloc(void) { if ((cdr_attrs = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(str))) == NULL) { - LM_ERR("failed to alloc cdr_attrs\n"); + PKG_MEM_ERROR_FMT("failed to alloc cdr_attrs\n"); return -1; } if ((cdr_value_array = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(str))) == NULL) { - LM_ERR("failed to alloc cdr_value_array\n"); + PKG_MEM_ERROR_FMT("failed to alloc cdr_value_array\n"); + cdr_arrays_free(); return -1; } if ((cdr_int_array = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(int))) == NULL) { - LM_ERR("failed to alloc cdr_int_array\n"); + PKG_MEM_ERROR_FMT("failed to alloc cdr_int_array\n"); + cdr_arrays_free(); return -1; } if ((cdr_type_array = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(char))) == NULL) { - LM_ERR("failed to alloc cdr_type_array\n"); + PKG_MEM_ERROR_FMT("failed to alloc cdr_type_array\n"); + cdr_arrays_free(); return -1; } if ((db_cdr_keys = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(db_key_t))) == NULL) { - LM_ERR("failed to alloc db_cdr_keys\n"); + PKG_MEM_ERROR_FMT("failed to alloc db_cdr_keys\n"); + cdr_arrays_free(); return -1; } if ((db_cdr_vals = pkg_malloc((MAX_CDR_CORE + cdr_extra_size) * sizeof(db_val_t))) == NULL) { - LM_ERR("failed to alloc db_cdr_vals\n"); + PKG_MEM_ERROR_FMT("failed to alloc db_cdr_vals\n"); + cdr_arrays_free(); return -1; } diff --git a/src/modules/acc/acc_extra.c b/src/modules/acc/acc_extra.c index 6205ba1a17d..dc0e1259990 100644 --- a/src/modules/acc/acc_extra.c +++ b/src/modules/acc/acc_extra.c @@ -386,7 +386,7 @@ int acc_extra_arrays_alloc(void) { } if ((int_buf = pkg_malloc((INT2STR_MAX_LEN * acc_int_buf_size) * sizeof(char))) == NULL) { - LM_ERR("failed to alloc int_buf\n"); + PKG_MEM_ERROR_FMT("failed to alloc int_buf\n"); return -1; }

1 0

OpenSSL 1.1 end of life
by Olle E. Johansson 29 Mar '23

29 Mar '23

https://www.openssl.org/blog/blog/2023/03/28/1.1.1-EOL/ Are we ready for OpenSSL 3 in production? /O

2 1

Changing location id from INT(10) to BIGINT
by Julius Flohr 29 Mar '23

29 Mar '23

Hi, we've been using kamailio successfully for many years now and we've noticed that the id field in the location database of our installation (userloc module) will overflow in the foreseeable future. Currently it is setup as a INT(10). Are there any reasons not to change it to BIGINT and upstream that change? Cheers Julius

2 2

git:master:ba365102: evapi: initialize internal message queue
by Daniel-Constantin Mierla 28 Mar '23

28 Mar '23

Module: kamailio Branch: master Commit: ba365102fe9faa403717eb30f36d363bad13114b URL: https://github.com/kamailio/kamailio/commit/ba365102fe9faa403717eb30f36d363… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-28T17:31:31+02:00 evapi: initialize internal message queue --- Modified: src/modules/evapi/evapi_dispatch.h Modified: src/modules/evapi/evapi_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/ba365102fe9faa403717eb30f36d363… Patch: https://github.com/kamailio/kamailio/commit/ba365102fe9faa403717eb30f36d363… --- diff --git a/src/modules/evapi/evapi_dispatch.h b/src/modules/evapi/evapi_dispatch.h index 23b4c2565c..c96bcbf275 100644 --- a/src/modules/evapi/evapi_dispatch.h +++ b/src/modules/evapi/evapi_dispatch.h @@ -53,4 +53,6 @@ int pv_set_evapi(sip_msg_t *msg, pv_param_t *param, int op, int evapi_cfg_close(sip_msg_t *msg); int evapi_set_tag(sip_msg_t* msg, str* stag); +int evapi_queue_init(void); + #endif diff --git a/src/modules/evapi/evapi_mod.c b/src/modules/evapi/evapi_mod.c index 27b3582698..708159ba3a 100644 --- a/src/modules/evapi/evapi_mod.c +++ b/src/modules/evapi/evapi_mod.c @@ -163,6 +163,10 @@ static int mod_init(void) _evapi_bind_addr = _evapi_bind_param; } + if(evapi_queue_init() < 0) { + LM_ERR("failed to init faked internal message queue\n"); + return -1; + } /* add space for one extra process */ register_procs(1 + _evapi_workers);

1 0

git:master:cc950166: ndb_redis: break on finding a server via sentinel
by Daniel-Constantin Mierla 28 Mar '23

28 Mar '23

Module: kamailio Branch: master Commit: cc9501663d6dd0fa91aef23ce00a7cdf86319201 URL: https://github.com/kamailio/kamailio/commit/cc9501663d6dd0fa91aef23ce00a7cd… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-28T08:12:00+02:00 ndb_redis: break on finding a server via sentinel --- Modified: src/modules/ndb_redis/redis_client.c --- Diff: https://github.com/kamailio/kamailio/commit/cc9501663d6dd0fa91aef23ce00a7cd… Patch: https://github.com/kamailio/kamailio/commit/cc9501663d6dd0fa91aef23ce00a7cd… --- diff --git a/src/modules/ndb_redis/redis_client.c b/src/modules/ndb_redis/redis_client.c index d6b7e0b95b9..a3ee1c332d4 100644 --- a/src/modules/ndb_redis/redis_client.c +++ b/src/modules/ndb_redis/redis_client.c @@ -156,6 +156,7 @@ int redisc_init(void) for(i= 0; i< sentinels_count; i++) { char *sentinelAddr = sentinels[i]; char *pos; + int srvfound = 0; redisContext *redis; redisReply *res, *res2; @@ -177,9 +178,9 @@ int redisc_init(void) res->element[0]->len + 1); port = atoi(res->element[1]->str); LM_DBG("sentinel replied: %s:%d\n", addr, port); + srvfound = 1; } - } - else { + } else { res = redisCommand(redis, "SENTINEL slaves %s", sentinel_group); if( res && (res->type == REDIS_REPLY_ARRAY) ) { @@ -201,9 +202,13 @@ int redisc_init(void) } LOG(ndb_redis_debug, "slave for %s: %s:%d\n", sentinel_group, addr, port); + srvfound = 1; } } } + if(srvfound==1) { + break; + } } }

1 0

git:master:f5bd2748: evapi: remove static specifier for evapi workers variable
by Daniel-Constantin Mierla 27 Mar '23

27 Mar '23

Module: kamailio Branch: master Commit: f5bd2748a7d06d0592fc5ab835bf970b3c023eaa URL: https://github.com/kamailio/kamailio/commit/f5bd2748a7d06d0592fc5ab835bf970… Author: Daniel-Constantin Mierla <miconda(a)gmail.com> Committer: Daniel-Constantin Mierla <miconda(a)gmail.com> Date: 2023-03-27T16:36:41+02:00 evapi: remove static specifier for evapi workers variable - it is exposed with extern --- Modified: src/modules/evapi/evapi_mod.c --- Diff: https://github.com/kamailio/kamailio/commit/f5bd2748a7d06d0592fc5ab835bf970… Patch: https://github.com/kamailio/kamailio/commit/f5bd2748a7d06d0592fc5ab835bf970… --- diff --git a/src/modules/evapi/evapi_mod.c b/src/modules/evapi/evapi_mod.c index e5ac255691..27b3582698 100644 --- a/src/modules/evapi/evapi_mod.c +++ b/src/modules/evapi/evapi_mod.c @@ -44,7 +44,7 @@ MODULE_VERSION -static int _evapi_workers = 1; +int _evapi_workers = 1; static char *_evapi_bind_addr = "127.0.0.1"; static int _evapi_bind_port = 8448; static char *_evapi_bind_param = NULL;

1 0

git:5.5:667eed70: carrierroute: remove redundant capabilities check, related to commit cf147ab7888c4e2
by Henning Westerholt 24 Mar '23

24 Mar '23

Module: kamailio Branch: 5.5 Commit: 667eed709ac31589d6ed0c3bd1003babdc1152a1 URL: https://github.com/kamailio/kamailio/commit/667eed709ac31589d6ed0c3bd1003ba… Author: Henning Westerholt <hw(a)gilawa.com> Committer: Henning Westerholt <hw(a)gilawa.com> Date: 2023-03-24T14:22:34Z carrierroute: remove redundant capabilities check, related to commit cf147ab7888c4e2 (cherry picked from commit f44e93a4171668d1c1182b186bea8c41db0a9300) (cherry picked from commit 7fcfc9ef6d624d7c817c83b5bb8008638d387e78) --- Modified: src/modules/carrierroute/cr_db.c --- Diff: https://github.com/kamailio/kamailio/commit/667eed709ac31589d6ed0c3bd1003ba… Patch: https://github.com/kamailio/kamailio/commit/667eed709ac31589d6ed0c3bd1003ba… --- diff --git a/src/modules/carrierroute/cr_db.c b/src/modules/carrierroute/cr_db.c index 0e59a681e4..04e3659dfe 100644 --- a/src/modules/carrierroute/cr_db.c +++ b/src/modules/carrierroute/cr_db.c @@ -335,11 +335,6 @@ int load_route_data_db(struct route_data_t * rd) { return -1; } - if (!DB_CAPABILITY(carrierroute_dbf, DB_CAP_RAW_QUERY)) { - LM_ERR("Database does not support required raw queries capability\n"); - return -1; - } - if (DB_CAPABILITY(carrierroute_dbf, DB_CAP_FETCH)) { if (carrierroute_dbf.query(carrierroute_dbh, NULL, NULL, NULL, (db_key_t *) columns, 0, columns_load_num, NULL, NULL) < 0) {

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
26
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

sr-dev March 2023